From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 10:37:56 2023 Received: (at submit) by debbugs.gnu.org; 5 Sep 2023 14:37:56 +0000 Received: from localhost ([127.0.0.1]:57563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXBk-0002cK-2O for submit@debbugs.gnu.org; Tue, 05 Sep 2023 10:37:56 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXBg-0002c3-3n for submit@debbugs.gnu.org; Tue, 05 Sep 2023 10:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdXBZ-0000mj-2E for guix-patches@gnu.org; Tue, 05 Sep 2023 10:37:45 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdXBW-0002PQ-GH for guix-patches@gnu.org; Tue, 05 Sep 2023 10:37:44 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-401e6ce2d9fso7549725e9.1 for ; Tue, 05 Sep 2023 07:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693924660; x=1694529460; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QJ3qVnMK4ZwoNiwvps6KbQ7N6MkdETeCuLS9k1DEonI=; b=PSv+tZzmvhS+4cdAn53Fg1kNM8Iuug4TMtRpwGESDC5+1oi0bKZ0Ntm3isD4pUcDee g+a/2YnRAR4sQ/pgSetUbsD8kwr4JvvQ015dJABSIm3ufbeCCJeOwrxGpGYekEd1twzF fsfHN9lHGDxoJHjgHGfB5/SrLFJ/mrni1Lip0cjkbNcBqeCAWMJn7Lqf6bFkej28LeTG qmCKsrs0733HbAVip1Z1kA7WEYj+q41mgFrAa3BBVaNE9SF40hznkoUwIkmx6NIWqQiE I+LfScOP7WFPVGE5iLelocrda85WDiivyNoaeQKLc30RZOc29NtFqQmN/uXxQlyqe04x 26Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693924660; x=1694529460; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QJ3qVnMK4ZwoNiwvps6KbQ7N6MkdETeCuLS9k1DEonI=; b=hd2eQ6nYIuqTUCwPAcvtNC/E3LSjl9NPQbO2/92mLNnTkuqnyWHezmgeiD9a7Vgwj4 B1lzl7eFjz9+TEPTHPz8Ta8t17jgq9zhv1pqnuHmOnPSjhpPHfTMcjABtxqAdJxL/gYM 4BSrGaSsPfYCpr+/BCaLzch9i6WEwGm2+5WZUxHH+Iny79QcAqS4TtdHQHyozUiQowfo m1KrJRdzV1PPqaTIv6lPtYuVlMO80ne1Q7lI89FCedsbOUAQdLJfvvb/eBEUyOWutMr+ m8i7U6nX+O5KkIYLVBGj5Fb4/efgOCET57TR2Pd5jZDa3nS+GCa7DJqGzP45ITN+vtEx bcXw== X-Gm-Message-State: AOJu0YzfUDdyY1wm1ZhXXsf5kwcOUKwsO86/u08Sf4q3IyXpAMWUfC8G JCn8CI8EG5F5SLTNeQckLIkqE7o1T0Y= X-Google-Smtp-Source: AGHT+IFk8YtTzZaUZBqjCSW1e5/uEx7il3hU3g72FVyrlgnv412Bg0bxaYngX48FrwO4dJR7Unl6wg== X-Received: by 2002:a05:600c:3b83:b0:3ff:c342:f296 with SMTP id n3-20020a05600c3b8300b003ffc342f296mr10518209wms.1.1693924660242; Tue, 05 Sep 2023 07:37:40 -0700 (PDT) Received: from localhost.localdomain ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c021100b003fefca26c72sm17180798wmi.23.2023.09.05.07.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 07:37:39 -0700 (PDT) From: Simon Tournier To: guix-patches@gnu.org Subject: [PATCH] guix: packages: Support package/inherit by package-field-location. Date: Tue, 5 Sep 2023 16:37:32 +0200 Message-Id: <6cefcfecf409ffdd5fe856c23fbbc7b9cae7161d.1693924596.git.zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Debbugs-CC: Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Fixes . Reported by Maxim Cournoyer . * guix/packages.scm (package-field-location): Add package/inherit case. --- guix/packages.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/packages.scm b/guix/packages.scm index ba98bb0fb484..821eddb72d5d 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -761,7 +761,8 @@ (define (package-field-location package field) (lambda (port) (go-to-location port line column) (match (read port) - (('package inits ...) + ((or ('package inits ...) + ('package/inherit inits ...)) (let ((field (assoc field inits))) (match field ((_ value) base-commit: bedcdf0fb5ac035f696790827679406c7146396c -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 06 16:41:46 2023 Received: (at 65757-done) by debbugs.gnu.org; 6 Sep 2023 20:41:46 +0000 Received: from localhost ([127.0.0.1]:37975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdzLO-0007Jg-8i for submit@debbugs.gnu.org; Wed, 06 Sep 2023 16:41:46 -0400 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]:45337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdzLI-0007JK-OC for 65757-done@debbugs.gnu.org; Wed, 06 Sep 2023 16:41:44 -0400 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-413636c6d6aso1714571cf.3 for <65757-done@debbugs.gnu.org>; Wed, 06 Sep 2023 13:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694032893; x=1694637693; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=347Jr/XXtceLMIvirq0gSkYF/jIOj2Q+bkQWKR06hB8=; b=QIkaaI03tm1H/kMOpiFWQVapuO+j7/Ty6+Rx/dAYZvTfuVPBj2JGAu4zrN4xAYpd2p vuTHMhA5VtP+RFB0Y/pCx9fgvLl6JKFXdxQu8KOwE3DPcSg8d6Pw8eoBPOz/7NsymdaG yJGqf/pRjDTkbmEE0wQCqgZ8rgzvhsNDUDmwCvl+CzGBVcCFbiqDyv9ZJ/FhTR75L6zm fxn+qibO6ndcRv9zbzN8++PNvwmEe3T/tv2puRzP0hWZmfJ3a3yNgjbpZih6viWyKFo9 9EHGtgwBrv6ez1wSLGJda1dQ82RWZkLsSagQxZ9uB3oU+9DPN/zQt/JE/y1ozFUEvVOU AGmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694032893; x=1694637693; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=347Jr/XXtceLMIvirq0gSkYF/jIOj2Q+bkQWKR06hB8=; b=fS7sYE7J8uEwHRwL+LaN3uxqRPEbRuNwLVlDI/3NxCTVAF5OdRTRzaS5yIu2StZRxw CL6Txkt5qZIh0MereScj6hPR8wJu5QZagy8uXvIwYrZGdE4i05VDhvn+F4SQVL+U2egv lUMkQLF4hm/r4K5wd/vW8QUseLZ1xgb/YE77sWhRBm0l6ui7PNz0q8GL83XRGmsjvoxx cZaXvDJLXbzwA0IN9g8+C7mBdxx1LKnsDyOLjtflCGmB5v32dVLHSDY7qQyyxV8Klcde AgOVk8truJt8Ngj2mzrMeDwB763vNN35bLh94kqrFwCTXSRteI3R1UftnwMUd8OPKTR+ 1NPw== X-Gm-Message-State: AOJu0YyNV8Kk+iZGECsGUzBsRfZu51RCVPdbv3tZxWvZ97XaKuN/Gi65 pIPxhz8Cwu6ZRQPr15DZSJOO+6cxJ2cd0A== X-Google-Smtp-Source: AGHT+IEVnIBUTJ5SEG8T/+GjMDeylqCdAgqr8a+fan6ry7xhSKZygRDmPwoUQgNCrdA3Ln/KdGLrJA== X-Received: by 2002:a0c:a9c8:0:b0:64f:3db0:ab31 with SMTP id c8-20020a0ca9c8000000b0064f3db0ab31mr18683692qvb.26.1694032893477; Wed, 06 Sep 2023 13:41:33 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id z14-20020a0cda8e000000b0063cfe9adb2csm5709352qvj.108.2023.09.06.13.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 13:41:33 -0700 (PDT) From: Maxim Cournoyer To: Simon Tournier Subject: Re: [bug#65757] [PATCH] guix: packages: Support package/inherit by package-field-location. References: <6cefcfecf409ffdd5fe856c23fbbc7b9cae7161d.1693924596.git.zimon.toutoune@gmail.com> Date: Wed, 06 Sep 2023 16:41:31 -0400 In-Reply-To: <6cefcfecf409ffdd5fe856c23fbbc7b9cae7161d.1693924596.git.zimon.toutoune@gmail.com> (Simon Tournier's message of "Tue, 5 Sep 2023 16:37:32 +0200") Message-ID: <875y4nqbk4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65757-done Cc: 65757-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, Simon Tournier writes: > Fixes . > Reported by Maxim Cournoyer . nitpick: 'Reported-by:' is a Git trailing (message tag); it should appear at the bottom of the commit message for Git tools to correctly parse it. > * guix/packages.scm (package-field-location): Add package/inherit case. > --- > guix/packages.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/guix/packages.scm b/guix/packages.scm > index ba98bb0fb484..821eddb72d5d 100644 > --- a/guix/packages.scm > +++ b/guix/packages.scm > @@ -761,7 +761,8 @@ (define (package-field-location package field) > (lambda (port) > (go-to-location port line column) > (match (read port) > - (('package inits ...) > + ((or ('package inits ...) > + ('package/inherit inits ...)) I tested it in 'guix repl' for zxing-cpp-1.2, and something didn't go well: --8<---------------cut here---------------start------------->8--- scheme@(guix-user)> ,use (guix packages) scheme@(guix-user)> ,use (gnu packages aidc) scheme@(guix-user)> zxing-cpp-1.2 $1 =3D # scheme@(guix-user)> (package-field-location $1 'version) ice-9/boot-9.scm:1685:16: In procedure raise-exception: In procedure assoc: Wrong type argument: zxing-cpp Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue. scheme@(guix-user) [1]> ,bt In ice-9/boot-9.scm: 1747:15 4 (with-exception-handler # _ # _ # =E2=80=A6) In ice-9/ports.scm: 433:17 3 (call-with-input-file _ _ #:binary _ #:encoding _ #:guess-enco= ding _) In guix/packages.scm: 766:32 2 (_ _) In srfi/srfi-1.scm: 241:2 1 (assoc _ _ _) In ice-9/boot-9.scm: 1685:16 0 (raise-exception _ #:continuable? _) --8<---------------cut here---------------end--------------->8--- I modified it like: --8<---------------cut here---------------start------------->8--- modified guix/packages.scm @@ -762,7 +762,7 @@ (define (package-field-location package field) (go-to-location port line column) (match (read port) ((or ('package inits ...) - ('package/inherit parent inits ...)) + ('package/inherit _ inits ...)) (let ((field (assoc field inits))) (match field ((_ value) --8<---------------cut here---------------end--------------->8--- And it now works; yay! Will install shortly. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 06 18:03:16 2023 Received: (at 65757-done) by debbugs.gnu.org; 6 Sep 2023 22:03:16 +0000 Received: from localhost ([127.0.0.1]:38045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qe0cF-0006O7-TG for submit@debbugs.gnu.org; Wed, 06 Sep 2023 18:03:16 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:40422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qe0cA-0006Nr-67 for 65757-done@debbugs.gnu.org; Wed, 06 Sep 2023 18:03:14 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-31c3f574ef8so77815f8f.1 for <65757-done@debbugs.gnu.org>; Wed, 06 Sep 2023 15:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694037783; x=1694642583; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/9mgl//1A0Xs5O+Bl1MbC4eAKSn+V8wAr0n8qM+GCeM=; b=FzOnNHCXXgLIScLRkYY1QaRmgAvN2w7rGzx5ZtM17VSHXbaoRJRIWVkKNN5wdO2hZ6 /dupLXMP3jol3nzJQfHJL8vWjFTkIaffCAIGMbX7J4ftNR6JCghlEvh4VSdtTrzplfPL ZTddmthAM7/n1O5PWhTmuE9WG7S0aLtL3uz2j55vVSB0TyEESlUpTsGTEGY/vi75DCjW YZUdQ84mBTsPKOpjfeH7j4/0yEazdwIYe3OpwdHFpOTWPy/3hOT7Hje0XAoFQs1nJf2s 9TSY1LKePodjppJdH+rBTmKZw7fkx1ktD3veHvNBxjFM/+yg0Jg2uHq0HWdYl3QfHPAq 0QUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694037783; x=1694642583; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/9mgl//1A0Xs5O+Bl1MbC4eAKSn+V8wAr0n8qM+GCeM=; b=I4TJl8Rm6Wsg7RtzT14pCNVYWea3cMr1inlrjQ7mBYxWBNP6FZGwDMQKqCKQlYNcLT gtAYA4jVxnPBXTrabJ3bkfs3hcSRlzB1mmYFqQkAMkkonjKy5vwNr2B2kisfEtQCP4qc EJ1ELZAo54RNLrlBKehwjuYU3YjrLPrNw8lYw4F2NjvfDwnYD8aecLcfJlObTxT/m9zw Dy/0VEL8Gz0P2lW2XFv2YOMKojPF2Tkpxr23nj5D/a91BFlJt1KJ/RZ3X/gHM2ouSY5d x49hBEOyuIyFW1Ov+qKMUyzgB+FiS68TthQGfST1sGonL0SLAhEg6ML/GXbNAabSMhVE 9nwA== X-Gm-Message-State: AOJu0YxGqey3zsC22mKuAElm1ihiW561p+c8aQ0AXEUpM0uLYCvE6+gU d5dxPxkiwTymNWDhPOUI+S/+3/LbERo= X-Google-Smtp-Source: AGHT+IECGr/LtrYywrN0whz9ik+3U6QHsUo6IaOLqXTwyVOKTYnV8EWh5D2EbX50G9LqA7f6ZyksTA== X-Received: by 2002:a5d:4b05:0:b0:31a:ed75:75e8 with SMTP id v5-20020a5d4b05000000b0031aed7575e8mr13368285wrq.2.1694037782738; Wed, 06 Sep 2023 15:03:02 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id x3-20020adff643000000b003188358e08esm21345970wrp.42.2023.09.06.15.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 15:03:02 -0700 (PDT) From: Simon Tournier To: Maxim Cournoyer Subject: Re: bug#65757: [PATCH] guix: packages: Support package/inherit by package-field-location. In-Reply-To: <875y4nqbk4.fsf@gmail.com> References: <6cefcfecf409ffdd5fe856c23fbbc7b9cae7161d.1693924596.git.zimon.toutoune@gmail.com> <875y4nqbk4.fsf@gmail.com> Date: Thu, 07 Sep 2023 00:01:35 +0200 Message-ID: <87fs3rm05c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65757-done Cc: 65757-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Wed, 06 Sep 2023 at 16:41, Maxim Cournoyer w= rote: > --8<---------------cut here---------------start------------->8--- > modified guix/packages.scm > @@ -762,7 +762,7 @@ (define (package-field-location package field) > (go-to-location port line column) > (match (read port) > ((or ('package inits ...) > - ('package/inherit parent inits ...)) > + ('package/inherit _ inits ...)) > (let ((field (assoc field inits))) > (match field > ((_ value) > --8<---------------cut here---------------end--------------->8--- > > And it now works; yay! Will install shortly. Oops! Indeed, sorry for missing the obvious. Thanks for the fix. Cheers, simon PS: For the record, the change you made is: - ('package/inherit inits ...)) + ('package/inherit _ inits ...)) because the one above would be equivalent :-) =E2=80=93 if I understand eno= ugh Guile patterning matching. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 06 21:56:13 2023 Received: (at 65757-done) by debbugs.gnu.org; 7 Sep 2023 01:56:13 +0000 Received: from localhost ([127.0.0.1]:38196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qe4Fh-0006W9-8B for submit@debbugs.gnu.org; Wed, 06 Sep 2023 21:56:13 -0400 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]:56518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qe4Fb-0006Vt-LE for 65757-done@debbugs.gnu.org; Wed, 06 Sep 2023 21:56:12 -0400 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-4121b5334f3so3550561cf.0 for <65757-done@debbugs.gnu.org>; Wed, 06 Sep 2023 18:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694051760; x=1694656560; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=oAM3XXhb1iBHVr5lLps/2djKRa0rxQuXZFytUcIS+p4=; b=Hmd9qHAME8W/rB3jho1ukK8XZs1mDk1pn7fN3ra82JJsvC8f/ZNbdGkk+b5jspb0IR jhEW9P/BWcIMwaIyfESaWqMZmQPMr7Qx5tqALMzaXBn8zbsVYb7xE1Fyh4RQeu+T//Gn mw95Lp8T3R/FUTLOESYqLs9Dm94ironK50LfkuGYM6rsCtRlPJgVN9pt5uPWUZ10QlLG LkZ61HZrE8LQLHCwN1RFPdu6f+KMc3ymQL8Lt75tRvIlEA1CVlvpFHyrItxDjRo1bh55 OKIMri+q973uo5q/QMsTvR8+UQOEpGqTeIXJS0yIQTRbvMIYq4GUrnQUh2s/H62/DvTP 8kcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694051760; x=1694656560; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oAM3XXhb1iBHVr5lLps/2djKRa0rxQuXZFytUcIS+p4=; b=V2FA3PNHgQF1c1csJXMBH403W0mPopdrcjv3Fi0hYPQmtIS4b8DWbNpDij0QngmNk1 xzEsxBjf4MKQmh4LR/vf5nnYhhMjvj+oBm6RClbdhx9XRHtvh2TZ/Vwy0s3KrD0G3A2+ 9a/H5FZ6kX16WMr1Z0aCM1NtlD6qX3mtd3cjXNBOf+cHHNfvnwoK88pXCiUfRToXCCSp TJ6IcquHCLj9TW+4ZtR8QT3dMxH227QykTBgohsoLV5Ckm2BFYbRZA8fQn7bJiLmm0px wdjVXeiTjeo0QiC2J6EyVe/xKQYruIcSIbawCRwnYpE571u9aY8wV3XbCLy26UUXa7y/ fH7w== X-Gm-Message-State: AOJu0YyB+J3LVYFlyNihA3c+GPcHjFIXMFt6oRVGsR8JlufsHhQmIAf9 WLAqb2EzWsvoUBkbjQSiLea1Tkg1oNucJw== X-Google-Smtp-Source: AGHT+IFkX14KETbGATBn1Thrsq1l7Ofz8Rjrly1LCIHZ2jL01h4e9LGDoe8QBZr7krnPLFPiRliVMQ== X-Received: by 2002:a05:622a:100c:b0:403:eecb:9cfd with SMTP id d12-20020a05622a100c00b00403eecb9cfdmr21797243qte.23.1694051760440; Wed, 06 Sep 2023 18:56:00 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id fk26-20020a05622a559a00b00411f7da6e1bsm5707210qtb.60.2023.09.06.18.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 18:56:00 -0700 (PDT) From: Maxim Cournoyer To: Simon Tournier Subject: Re: bug#65757: [PATCH] guix: packages: Support package/inherit by package-field-location. References: <6cefcfecf409ffdd5fe856c23fbbc7b9cae7161d.1693924596.git.zimon.toutoune@gmail.com> <875y4nqbk4.fsf@gmail.com> <87fs3rm05c.fsf@gmail.com> Date: Wed, 06 Sep 2023 21:55:59 -0400 In-Reply-To: <87fs3rm05c.fsf@gmail.com> (Simon Tournier's message of "Thu, 07 Sep 2023 00:01:35 +0200") Message-ID: <871qfapx00.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65757-done Cc: 65757-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Simon Tournier writes: > Hi Maxim, > > On Wed, 06 Sep 2023 at 16:41, Maxim Cournoyer = wrote: > >> --8<---------------cut here---------------start------------->8--- >> modified guix/packages.scm >> @@ -762,7 +762,7 @@ (define (package-field-location package field) >> (go-to-location port line column) >> (match (read port) >> ((or ('package inits ...) >> - ('package/inherit parent inits ...)) >> + ('package/inherit _ inits ...)) >> (let ((field (assoc field inits))) >> (match field >> ((_ value) >> --8<---------------cut here---------------end--------------->8--- >> >> And it now works; yay! Will install shortly. > > Oops! Indeed, sorry for missing the obvious. Thanks for the fix. > > Cheers, > simon > > PS: For the record, the change you made is: > > - ('package/inherit inits ...)) > + ('package/inherit _ inits ...)) > > because the one above would be equivalent :-) =E2=80=93 if I understand e= nough > Guile patterning matching. The one with 'parent' was working as well, but because the binding was never used, Guile was emitting a warning, silence by renaming 'parent' to '_' :-). --=20 Thanks, Maxim From unknown Sat Aug 09 13:22:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Oct 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator