GNU bug report logs - #65731
[PATCH] services: syncthing: ensure that service runs after mounting home directories

Previous Next

Package: guix-patches;

Reported by: Adam Maleszka <adam_maleszka <at> aol.com>

Date: Mon, 4 Sep 2023 12:26:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Adam Maleszka <adam_maleszka <at> aol.com>
Subject: bug#65731: closed (Re: bug#65731: [PATCH] services: syncthing:
 ensure that service runs after mounting home directories)
Date: Sun, 17 Sep 2023 09:57:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#65731: [PATCH] services: syncthing: ensure that service runs after mounting home directories

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65731 <at> debbugs.gnu.org.

-- 
65731: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65731
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Adam Maleszka <adam_maleszka <at> aol.com>
Cc: 65731-done <at> debbugs.gnu.org
Subject: Re: bug#65731: [PATCH] services: syncthing: ensure that service
 runs after mounting home directories
Date: Sun, 17 Sep 2023 11:56:22 +0200
Hi,

Adam Maleszka <adam_maleszka <at> aol.com> skribis:

> Sometimes `syncthing-service-type' fails during startup because it tries
> to read configuration files from the user's home directory:
>
> Failure on home directory: mkdir /home/xyz/.config: permission denied
>
> This patch adds `user-processes' to the shepherd service requirements to
> ensure that `user-homes' is fired before `syncthing' tries to read data
> from the home directory.
>
> * gnu/services/syncthing.scm (syncthing-shepherd-service): add
> `user-processes' to requirements

Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]
From: Adam Maleszka <adam_maleszka <at> aol.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: syncthing: ensure that service runs after
 mounting home directories
Date: Mon, 04 Sep 2023 14:25:23 +0200
[Message part 4 (text/plain, inline)]
Sometimes `syncthing-service-type' fails during startup because it tries
to read configuration files from the user's home directory:

Failure on home directory: mkdir /home/xyz/.config: permission denied

This patch adds `user-processes' to the shepherd service requirements to
ensure that `user-homes' is fired before `syncthing' tries to read data
from the home directory.

* gnu/services/syncthing.scm (syncthing-shepherd-service): add
`user-processes' to requirements

---
 gnu/services/syncthing.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/syncthing.scm b/gnu/services/syncthing.scm
index 2f7c822827..9bb623186b 100644
--- a/gnu/services/syncthing.scm
+++ b/gnu/services/syncthing.scm
@@ -63,7 +63,7 @@ (define syncthing-shepherd-service
                      (list (string->symbol
                             (string-append "syncthing-" user)))))
       (documentation "Run syncthing.")
-      (requirement (if home-service? '() '(loopback)))
+      (requirement (if home-service? '() '(loopback user-processes)))
       (start #~(make-forkexec-constructor
                 (append (list (string-append #$syncthing "/bin/syncthing")
                               "--no-browser"
-- 
2.41.0
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 1 year and 247 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.