From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 65719@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169376933222937 (code B ref -1); Sun, 03 Sep 2023 19:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Sep 2023 19:28:52 +0000 Received: from localhost ([127.0.0.1]:46959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcsmB-0005xt-Tr for submit@debbugs.gnu.org; Sun, 03 Sep 2023 15:28:52 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcsmA-0005xh-7X for submit@debbugs.gnu.org; Sun, 03 Sep 2023 15:28:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcsm4-0003SF-Qd for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 15:28:45 -0400 Received: from mail.elken.dev ([165.22.120.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcsm1-0008A5-Qm for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 15:28:44 -0400 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id D834E45D52 for ; Sun, 3 Sep 2023 21:28:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1693769314; bh=VPe8aYrLge9ApuDynvwvY9YEXObu1+TjlbqtB4BJkDQ=; h=Date:From:To:Subject:From; b=jJhnrMRPJbzlCvm0M6kG/HTgZZc9Ed1awC7bfBlTDQJR1OsTaXJmolX3WYd47EVGN clhqw5BEiGnVzTSJyR5JxhgT5OGxKE8BasbuUTpZwb5Ue/JM3KN4fHsFZpGyOgh7Ye 3T29oazic0Otb1iKbMOENZ7rRrx61DzAkPWCitQMsbX5yf3Pt8Vo2lpfg4iYm0QqL4 bfNJlkHLa4LW/4yPqZdSX7ESLsYZPa6PFPziMy8+lgghkP7IdSTaqCG9qysRSTau7x 4HXCisDvAF0p5ikVBL71ATLVU9g2tJjqNIxgng2hgWNqxlBlKhK8w/EEXw5ePxSdOQ Ar/LKCqXHvnFQ== MIME-Version: 1.0 Date: Sun, 03 Sep 2023 20:28:34 +0100 From: me@elken.dev Message-ID: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> X-Sender: me@elken.dev Content-Type: multipart/mixed; boundary="=_69c6835b0749f6a7ab6541f194863d1c" Received-SPF: pass client-ip=165.22.120.78; envelope-from=me@elken.dev; helo=mail.elken.dev X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=_69c6835b0749f6a7ab6541f194863d1c Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi all, Small change here to pass the restart status to 'kill-emacs-query-functions' in 'save-buffers-kill-emacs' so any functions there can react to being restarted, sample use-case this may be useful is if one is using a package like perspective.el to handle buffer/window management and when calling `M-x restart-emacs` you WANT your last session to be persisted, but just starting Emacs normally you don't. There are other potential use-cases for this too, so hopefully this patch is well-received. Thanks all, Ellis (@lkn) --=_69c6835b0749f6a7ab6541f194863d1c Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Add-restart-argument-to-kill-emacs-query-functions.patch Content-Disposition: attachment; filename=0001-Add-restart-argument-to-kill-emacs-query-functions.patch; size=2423 RnJvbSAyNTBjMGM0Zjg4ZjFkMTY5NDE1ZDRmNmM2NjM0ZTE3ODI5MDY0NzQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGxpcyBLZW55byA8bWVAZWxrZW4uZGV2PgpEYXRlOiBTdW4s IDMgU2VwIDIwMjMgMjA6MTc6MjEgKzAxMDAKU3ViamVjdDogW1BBVENIXSBBZGQgcmVzdGFydCBh cmd1bWVudCB0byAna2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMnCgoqIGV0Yy9ORVdTOiBVcGRh dGUgTkVXUyBmaWxlLgoKKiBsaXNwL2ZpbGVzLmVsIChzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcyk6 IFBhc3MgaW4gdGhlIFJFU1RBUlQKYXJndW1lbnQgdG8gc3Vic2VxdWVudCBob29rIGNhbGxzLgot LS0KIGV0Yy9ORVdTICAgICAgfCAgNyArKysrKysrCiBsaXNwL2ZpbGVzLmVsIHwgMTEgKysrKysr LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGJiZjRiNjdmZTM0Li43Mjcz ZWJkMjE4MyAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTc3Niw2ICs3 NzYsMTMgQEAgdGhlIGN1cnJlbnQgcHJvamVjdC4KIFRoZSBsb29rIG9mIHRoZSBrZXkgcHJvbXB0 IGluIHRoZSBwcm9qZWN0IHN3aXRjaGVyIGhhcyBiZWVuIGNoYW5nZWQKIHNsaWdodGx5LiAgVG8g Z2V0IHRoZSBwcmV2aW91cyBvbmUsIHNldCB0aGlzIG9wdGlvbiB0byAnYnJhY2tldHMnLgogCisq KiBGaWxlcworCisqKiogJ2tpbGwtZW1hY3MtcXVlcnktZnVuY3Rpb25zJyBub3cgdGFrZXMgUkVT VEFSVCBhcyBhbiBhcmd1bWVudC4KK0Z1bmN0aW9ucyBhZGRlZCB0byB0aGlzIGhvb2sgY2FuIG5v dyBhY2NlcHQgYW4gYXJndW1lbnQgZGVub3RpbmcKK3doZXRoZXIgb3Igbm90IHRoZSBjYWxsIGlz IGR1ZSB0byBjYWxsIHJlc3RhcnQgRW1hY3M7IGlmIGNhbGxlZCBmcm9tCitzYXkgJ3Jlc3RhcnQt ZW1hY3MnLgorCiAMCiAqIEluY29tcGF0aWJsZSBMaXNwIENoYW5nZXMgaW4gRW1hY3MgMzAuMQog CmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxlcy5lbAppbmRleCA0MTg4NjE1 ZTQ5MC4uMDk1Y2JhNjkzZDAgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMuZWwKKysrIGIvbGlzcC9m aWxlcy5lbApAQCAtODEzNCwxMCArODEzNCwxMSBAQCBkZWZ1biBpbnNlcnQtZGlyZWN0b3J5LXNh ZmVseQogICAgIChpbnNlcnQgKGZvcm1hdCAiJXM6IE5vIHN1Y2ggZmlsZSBvciBkaXJlY3Rvcnlc biIgZmlsZSkpKSkKIAogKGRlZmN1c3RvbSBraWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucyBuaWwK LSAgIkZ1bmN0aW9ucyB0byBjYWxsIHdpdGggbm8gYXJndW1lbnRzIHRvIHF1ZXJ5IGFib3V0IGtp bGxpbmcgRW1hY3MuCi1JZiBhbnkgb2YgdGhlc2UgZnVuY3Rpb25zIHJldHVybnMgbmlsLCBraWxs aW5nIEVtYWNzIGlzIGNhbmNlbGVkLgotYHNhdmUtYnVmZmVycy1raWxsLWVtYWNzJyBjYWxscyB0 aGVzZSBmdW5jdGlvbnMsIGJ1dCBga2lsbC1lbWFjcycsCi10aGUgbG93IGxldmVsIHByaW1pdGl2 ZSwgZG9lcyBub3QuICBTZWUgYWxzbyBga2lsbC1lbWFjcy1ob29rJy4iCisgICJGdW5jdGlvbnMg dG8gY2FsbCB3aXRoIHJlc3RhcnQgc3RhdHVzIGFzIGFuIGFyZ3VtZW50IHRvIHF1ZXJ5IGFib3V0 CitraWxsaW5nIEVtYWNzLiBJZiBhbnkgb2YgdGhlc2UgZnVuY3Rpb25zIHJldHVybnMgbmlsLCBr aWxsaW5nIEVtYWNzIGlzCitjYW5jZWxlZC4gYHNhdmUtYnVmZmVycy1raWxsLWVtYWNzJyBjYWxs cyB0aGVzZSBmdW5jdGlvbnMsIGJ1dAorYGtpbGwtZW1hY3MnLHRoZSBsb3cgbGV2ZWwgcHJpbWl0 aXZlLCBkb2VzIG5vdC4gIFNlZSBhbHNvCitga2lsbC1lbWFjcy1ob29rJy4iCiAgIDp0eXBlICdo b29rCiAgIDp2ZXJzaW9uICIyNi4xIgogICA6Z3JvdXAgJ2NvbnZlbmllbmNlKQpAQCAtODIyOCw3 ICs4MjI5LDcgQEAgZGVmdW4gc2F2ZS1idWZmZXJzLWtpbGwtZW1hY3MKICAgICAgICAgICAgICAg ICAgICAgICAgICh3aGVuICh3aW5kb3ctbGl2ZS1wIHdpbmRvdykKICAgICAgICAgICAgICAgICAg ICAgICAgICAgKHF1aXQtcmVzdG9yZS13aW5kb3cgd2luZG93ICdraWxsKSkpKSkpKSkpCiAgICAg IDs7IFF1ZXJ5IHRoZSB1c2VyIGZvciBvdGhlciB0aGluZ3MsIHBlcmhhcHMuCi0gICAgIChydW4t aG9vay13aXRoLWFyZ3MtdW50aWwtZmFpbHVyZSAna2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMp CisgICAgIChydW4taG9vay13aXRoLWFyZ3MtdW50aWwtZmFpbHVyZSAna2lsbC1lbWFjcy1xdWVy eS1mdW5jdGlvbnMgcmVzdGFydCkKICAgICAgKG9yIChudWxsIGNvbmZpcm0pCiAgICAgICAgICAo ZnVuY2FsbCBjb25maXJtICJSZWFsbHkgZXhpdCBFbWFjcz8gIikpCiAgICAgIChraWxsLWVtYWNz IG5pbCByZXN0YXJ0KSkpKQotLSAKMi40MS4wCgo= --=_69c6835b0749f6a7ab6541f194863d1c-- From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 01:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: me@elken.dev, 65719@debbugs.gnu.org Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.16937892981003 (code B ref 65719); Mon, 04 Sep 2023 01:02:01 +0000 Received: (at 65719) by debbugs.gnu.org; 4 Sep 2023 01:01:38 +0000 Received: from localhost ([127.0.0.1]:47855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcxyD-0000G6-PU for submit@debbugs.gnu.org; Sun, 03 Sep 2023 21:01:38 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:45131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcxyB-0000Fp-Cu for 65719@debbugs.gnu.org; Sun, 03 Sep 2023 21:01:36 -0400 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-500c37d479aso1400124e87.2 for <65719@debbugs.gnu.org>; Sun, 03 Sep 2023 18:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693789289; x=1694394089; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=tflNqeWQq9UJWYunW6pzd2F2Y9MSLaC2pm6kXUJOPEk=; b=TI5WVNy6t9C/wI7Yc8GeB5uzjuYOr5ggEK0iP8eqKht4NzN+CzArLf5/i2d+XNnnDs WDG7LzYdaqyRmcqnsRrRgUlaxqIe0eJxpQ0raj/Ro6lx8/KP8Nk+g4Mjm0SQRXumKI7/ 9ZtaUPFLZcs303Yr8zmnqX7PIgzy8Ht7I46VXpjtw5S8fxQoXhiH/iXLMljGMh3/8s1H Xf2sqltv0zWk3g9ZxdrEXGNFvsZp3cvgDdLEBm0StACAnTZY41bikhLBX/PL/daYqdlE X1NsOsBBtVFavQe4vfP5NuHPAEXq0+9YvEVm97yuspRnHUjj9kXZRwsq0t6uyYRj08TR yhew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693789289; x=1694394089; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tflNqeWQq9UJWYunW6pzd2F2Y9MSLaC2pm6kXUJOPEk=; b=AL22Wf3k2AOk8DtkzLFAsOHgVmF5G9sA8RL8H+meCzTZZVn1E3rPEeaij2CjmIQYlu KALqvnGfOyTJWztdHNybwkppcGvTllEbv/xPBOeO3jYU27qqquMKetFAx+5Jpx6R7wbm Jk4F4+XucnXvzBPTaLRH1ppkxx+GZvuUsKWU+kpklk9Vc6W5Tv2jkTYNexEt5lalBH53 TzjRyaXDf3wtK6DOVdeIRR6gGUuPZSDRKUidXKWVwWPjLYshjTO1H/ox5ojaRGShhieY vS9FkboppT7tKjopQXrQtPg630D08t7ByRVbJLenKViesd0TaA6nRW6+vGzg8UZxpgMB kJwQ== X-Gm-Message-State: AOJu0YzSJ0yYDXoj+VOpyQMEUb7Yli1z/Yd21i4s/bpsY0XMEvRZGSLq Uiay2gj/G4C9xzXVbCcTdZws6DKRXQGnKV0B0e3iS8/6YT0= X-Google-Smtp-Source: AGHT+IHMHdbDxYdf54Y4PXKsJwYfQhcpEoAghGvy7/vUaXXUOv8Cemohyr10/RrVZyL0NpQWK3x0YL8MbeuVeKsHqFI= X-Received: by 2002:a05:6512:398e:b0:500:be66:e014 with SMTP id j14-20020a056512398e00b00500be66e014mr5927928lfu.53.1693789289265; Sun, 03 Sep 2023 18:01:29 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 18:01:28 -0700 From: Stefan Kangas In-Reply-To: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> MIME-Version: 1.0 Date: Sun, 3 Sep 2023 18:01:28 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) me--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Small change here to pass the restart status to > 'kill-emacs-query-functions' in 'save-buffers-kill-emacs' so any > functions there can react to being restarted, sample use-case this may > be useful is if one is using a package like perspective.el to handle > buffer/window management and when calling `M-x restart-emacs` you WANT > your last session to be persisted, but just starting Emacs normally you > don't. > > There are other potential use-cases for this too, so hopefully this > patch is well-received. Thanks. The feature sounds useful, and the use-case makes sense. But isn't the change backwards-incompatible? Can we find a way to do this without any breaking changes? One idea would be to simply introduce a new variable that takes the argument, while making the old one obsolete. That would allow people to slowly migrate over to the new one, without everything suddenly breaking under their feet. From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Elken Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 05:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas , 65719@debbugs.gnu.org Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.169380389229371 (code B ref 65719); Mon, 04 Sep 2023 05:05:02 +0000 Received: (at 65719) by debbugs.gnu.org; 4 Sep 2023 05:04:52 +0000 Received: from localhost ([127.0.0.1]:48026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd1lb-0007dc-11 for submit@debbugs.gnu.org; Mon, 04 Sep 2023 01:04:51 -0400 Received: from mail.elken.dev ([165.22.120.78]:38917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd1lK-0007cu-MF for 65719@debbugs.gnu.org; Mon, 04 Sep 2023 01:04:49 -0400 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 4D5DB3F39F; Mon, 4 Sep 2023 07:04:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1693803868; bh=C8FHMxUHiPbaxqAdmsZ1jHfytYKBLT7D5RL0pW3RlgY=; h=Date:From:To:Subject:In-Reply-To:References:From; b=oy05QhZpZrniGAsCn/c9faRuaZoabFCznXQe7TtwyFiZMl2jq3ViQUYehJ+9tktlU IcKetmRTRDPntMo16fQXhgZZN1HQ5gc10ZdvlqVT/h6t5eL8kjBSaT14gtVbUViRqq ucabM8qJ7voW9oEWFOK7pbTH4pgCReVwny7+rte6YWDFVAWAgzR0ReomgMrz0IwCC2 kCXCQPKmM4b1uTlntxKMMWM+vtoAqjEwmUZzF6XaZctr/7dpCLgQjTBt1b4/ZzKMou 73pW4o+ozAvOd8LByRWjBcP2zrHDgvcY033XPch12AXDM8ii4XnhwInbVd9l7pmWCD JBq6tA5a3gJEQ== Date: Mon, 04 Sep 2023 06:04:25 +0100 From: Elken In-Reply-To: References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> Message-ID: <5F5E625D-2425-48DB-B1B4-CEE81496144F@elken.dev> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----5AWU35ZDGMM4O2TOT0BCPSO89FU8J8 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------5AWU35ZDGMM4O2TOT0BCPSO89FU8J8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Stefan,=20 Thanks for the positive feedback=2E=20 I'm not sure that's the case, I'll do more testing locally=2E If that is t= he case, then I can introduce 'restart-emacs-query-functions' instead when = 'restart' is t for the same outcome, which may actually be a preferable cha= nge anyway=2E=20 Thanks,=20 Ellis (@lkn) ------5AWU35ZDGMM4O2TOT0BCPSO89FU8J8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi Stefan,

Thanks for = the positive feedback=2E

I'm not sure that's the case, I'll do more= testing locally=2E If that is the case, then I can introduce 'restart-emac= s-query-functions' instead when 'restart' is t for the same outcome, which = may actually be a preferable change anyway=2E

Thanks,

Ellis= (@lkn)
------5AWU35ZDGMM4O2TOT0BCPSO89FU8J8-- From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 05:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 65719@debbugs.gnu.org Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.169380520132430 (code B ref 65719); Mon, 04 Sep 2023 05:27:02 +0000 Received: (at 65719) by debbugs.gnu.org; 4 Sep 2023 05:26:41 +0000 Received: from localhost ([127.0.0.1]:48054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd26i-0008Qz-IG for submit@debbugs.gnu.org; Mon, 04 Sep 2023 01:26:40 -0400 Received: from mail.elken.dev ([165.22.120.78]:58977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd26c-0008Qf-Mb for 65719@debbugs.gnu.org; Mon, 04 Sep 2023 01:26:39 -0400 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id B34F945D52; Mon, 4 Sep 2023 07:26:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1693805188; bh=T/DTNM8w+a0bVkd8iSjRt5dD7SujTzJlroAqf5HwVcA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1GRvoDcga5VoxP8ynkGj4rcBgyCYT6jwtKYZ0oiDU6B6oeiaC8bIOXOM/YcF/ZgW7 B/XmniKUbic2wi61bBvb5BPBcMK8vFOj0X4ilD5u2uR48d6SegfjMtqSm+dfShve33 97hx1/2mKD7BZeWi73rPl7ky/AmxlbImdD+rUyqdW9IeEa1YnAVBZGA7epCOn9jkjM FPAX2n4qSbeTZ1E685srzh538/WUhL2CEbNKOZOZUotj2wOjH6Bwa6vIzO8mebegqt Qvx6tleo4UxMsb60Ve75gLOFzJdFYGDwtaNwpb/c/ZIV6RDD4oveNqljy5KRdc3nTQ V7aBWAos1GyxA== MIME-Version: 1.0 Date: Mon, 04 Sep 2023 06:26:28 +0100 From: me@elken.dev In-Reply-To: References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> Message-ID: <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> X-Sender: me@elken.dev Content-Type: multipart/mixed; boundary="=_10f08f0369320f673f07700601e3a5cf" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=_10f08f0369320f673f07700601e3a5cf Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed > One idea would be to simply introduce a new variable that takes the > argument, while making the old one obsolete. That would allow people > to > slowly migrate over to the new one, without everything suddenly > breaking > under their feet. How does this patch sound? I think it's the best of both worlds :) --=_10f08f0369320f673f07700601e3a5cf Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Introduce-restart-emacs-query-functions.patch Content-Disposition: attachment; filename=0001-Introduce-restart-emacs-query-functions.patch; size=2369 RnJvbSA3ZDZmNWMyNTljZWZlNjViNWUwMjFkYWNlZTE4OTY2YWNjNmJjMTIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGxpcyBLZW55byA8bWVAZWxrZW4uZGV2PgpEYXRlOiBNb24s IDQgU2VwIDIwMjMgMDY6MjA6MzMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBJbnRyb2R1Y2UgJ3Jl c3RhcnQtZW1hY3MtcXVlcnktZnVuY3Rpb25zJwoKKiBldGMvTkVXUzogVXBkYXRlIE5FV1MgZmls ZS4KCiogbGlzcC9maWxlcy5lbCAoc2F2ZS1idWZmZXJzLWtpbGwtZW1hY3MpOiBBZGQgbmV3IG9w dGlvbgoncmVzdGFydC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMnIGZvciBmdW5jdGlvbnMgdGhhdCBz aG91bGQgYmUgY2FsbGVkCndoZW4gJ3Jlc3RhcnQnIGlzIHBhc3NlZC4KLS0tCiBldGMvTkVXUyAg ICAgIHwgIDcgKysrKysrKwogbGlzcC9maWxlcy5lbCB8IDEzICsrKysrKysrKysrKysKIDIgZmls ZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRj L05FV1MKaW5kZXggYmJmNGI2N2ZlMzQuLjk1ZTYyNDhjMDhhIDEwMDY0NAotLS0gYS9ldGMvTkVX UworKysgYi9ldGMvTkVXUwpAQCAtNzc2LDYgKzc3NiwxMyBAQCB0aGUgY3VycmVudCBwcm9qZWN0 LgogVGhlIGxvb2sgb2YgdGhlIGtleSBwcm9tcHQgaW4gdGhlIHByb2plY3Qgc3dpdGNoZXIgaGFz IGJlZW4gY2hhbmdlZAogc2xpZ2h0bHkuICBUbyBnZXQgdGhlIHByZXZpb3VzIG9uZSwgc2V0IHRo aXMgb3B0aW9uIHRvICdicmFja2V0cycuCiAKKyoqIEZpbGVzCisKKyoqKiBOZXcgdXNlciBvcHRp b24gJ3Jlc3RhcnQtZW1hY3MtcXVlcnktZnVuY3Rpb25zJy4KK0VxdWl2YWxlbnQgdG8gJ2tpbGwt ZW1hY3MtcXVlcnktZnVuY3Rpb25zJywgdGhpcyBob29rIGlzIGNhbGxlZCB3aGVuCisnc2F2ZS1i dWZmZXJzLWtpbGwtZW1hY3MnIGlzIGNhbGxlZCB3aXRoIHRoZSAncmVzdGFydCcgZmxhZzsgaWYK K2ludm9rZWQgZnJvbSBzYXkgJ00teCByZXN0YXJ0LWVtYWNzJy4KKwogDAogKiBJbmNvbXBhdGli bGUgTGlzcCBDaGFuZ2VzIGluIEVtYWNzIDMwLjEKIApkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5l bCBiL2xpc3AvZmlsZXMuZWwKaW5kZXggNDE4ODYxNWU0OTAuLjc4NDlkNmI3YzgxIDEwMDY0NAot LS0gYS9saXNwL2ZpbGVzLmVsCisrKyBiL2xpc3AvZmlsZXMuZWwKQEAgLTgxNDIsNiArODE0Miwx NSBAQCBkZWZjdXN0b20ga2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMKICAgOnZlcnNpb24gIjI2 LjEiCiAgIDpncm91cCAnY29udmVuaWVuY2UpCiAKKyhkZWZjdXN0b20gcmVzdGFydC1lbWFjcy1x dWVyeS1mdW5jdGlvbnMgbmlsCisgICJGdW5jdGlvbnMgdG8gY2FsbCB3aXRoIG5vIGFyZ3VtZW50 cyB0byBxdWVyeSBhYm91dCByZXN0YXJ0aW5nCitFbWFjcy4gSWYgYW55IG9mIHRoZXNlIGZ1bmN0 aW9ucyByZXR1cm5zIG5pbCwgcmVzdGFydGluZyBFbWFjcyBpcworY2FuY2VsZWQuIGBzYXZlLWJ1 ZmZlcnMta2lsbC1lbWFjcycgY2FsbHMgdGhlc2UgZnVuY3Rpb25zIHdoZW4gcGFzc2VkCitgcmVz dGFydCcuICBTZWUgYWxzbyBga2lsbC1lbWFjcy1ob29rJy4iCisgIDp0eXBlICdob29rCisgIDp2 ZXJzaW9uICIzMC4xIgorICA6Z3JvdXAgJ2NvbnZlbmllbmNlKQorCiAoZGVmY3VzdG9tIGNvbmZp cm0ta2lsbC1lbWFjcyBuaWwKICAgIkhvdyB0byBhc2sgZm9yIGNvbmZpcm1hdGlvbiB3aGVuIGxl YXZpbmcgRW1hY3MuCiBJZiBuaWwsIHRoZSBkZWZhdWx0LCBkb24ndCBhc2sgYXQgYWxsLiAgSWYg dGhlIHZhbHVlIGlzIG5vbi1uaWwsIGl0IHNob3VsZApAQCAtODIyNyw2ICs4MjM2LDEwIEBAIGRl ZnVuIHNhdmUtYnVmZmVycy1raWxsLWVtYWNzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KHllcy1vci1uby1wICJBY3RpdmUgcHJvY2Vzc2VzIGV4aXN0OyBraWxsIHRoZW0gYW5kIGV4aXQg YW55d2F5PyAiKSkKICAgICAgICAgICAgICAgICAgICAgICAgICh3aGVuICh3aW5kb3ctbGl2ZS1w IHdpbmRvdykKICAgICAgICAgICAgICAgICAgICAgICAgICAgKHF1aXQtcmVzdG9yZS13aW5kb3cg d2luZG93ICdraWxsKSkpKSkpKSkpCisgICAgIDs7IE9ubHkgY2FsbCB0aGVzZSB3aGVuIHJlc3Rh cnRpbmcKKyAgICAgKHdoZW4gcmVzdGFydAorICAgICAgIChydW4taG9vay13aXRoLWFyZ3MtdW50 aWwtZmFpbHVyZSAncmVzdGFydC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMpKQorCiAgICAgIDs7IFF1 ZXJ5IHRoZSB1c2VyIGZvciBvdGhlciB0aGluZ3MsIHBlcmhhcHMuCiAgICAgIChydW4taG9vay13 aXRoLWFyZ3MtdW50aWwtZmFpbHVyZSAna2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMpCiAgICAg IChvciAobnVsbCBjb25maXJtKQotLSAKMi40MS4wCgo= --=_10f08f0369320f673f07700601e3a5cf-- From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Sep 2023 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: me@elken.dev Cc: 65719@debbugs.gnu.org Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.169417308530132 (code B ref 65719); Fri, 08 Sep 2023 11:39:02 +0000 Received: (at 65719) by debbugs.gnu.org; 8 Sep 2023 11:38:05 +0000 Received: from localhost ([127.0.0.1]:42381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeZoL-0007ps-05 for submit@debbugs.gnu.org; Fri, 08 Sep 2023 07:38:05 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:53361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeZoI-0007pG-1G for 65719@debbugs.gnu.org; Fri, 08 Sep 2023 07:38:03 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2bb9a063f26so34324671fa.2 for <65719@debbugs.gnu.org>; Fri, 08 Sep 2023 04:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694173074; x=1694777874; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Spaj9moJ83N/lUuXJIU14mnjYzBvaEbc4XPTc4ZU2UI=; b=aHwTw/XCo9xvZ3MIeBZn0ksVaJ05RHZ9l9NWvDdiLQ4REb/lJOuvdnV3BXrq5RbHZ5 o080pcnAFm2Th4JIQ8v5khtlXxztuFLGKsm6T9uqGatq7Pb5Vh/5NTLyOLy7VT7xGEME s5GOm0htfq303qdQ5Hj82vuwooQcotM2fIZFSxHzmaGLI2UBWB8RmhHkDFeZ4P4k3F8f 3PKh6HBo1zTKbcng/t3B/HJhv6R2LctvTv86TH6Xhn1al5EzbqlnZ7f+Hn+BGYe6/5nC HbV+MTtwu2IT78MtlQQdE/jrTYm9Irc1ENPmgfZsmycieCWjEfq8yMau12UfkGr0UdT0 MN7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694173074; x=1694777874; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Spaj9moJ83N/lUuXJIU14mnjYzBvaEbc4XPTc4ZU2UI=; b=uwE7Mup52kiWqBcPjNqGx+FhBxAeXAqYiTB9GUlCtQqy4QoMxhls4GR5tnTV0UsdJL KIpJcyIEH0WQ5igLAQWvdcjZa4qWQLpOD/gWmUk/Z2+5bU+pHcJldZomJTCzKTo1KQ5x KQNVF13xF2SNqFhK3uBLqjJJOsJNZWTT0sVrBhkUptMDAB518Z4/Nnam0JIAtTb0q95D QjE5BPCrchWvB/SlpOHidu8ekBUxgjkiR8wouft5dmQmHlSgQyAynxg3ewpAyaG6b1Sy HMdmQo08cbDOEsGskDARjlvx0m5H8AQ+KoV5eQU7iAVdD4vIPgykd+YQJdvDRyNUF+NK HQVA== X-Gm-Message-State: AOJu0YxN4h7gr2l+6hjPY8F/7mhwyg1kdChWXaWejOGouhc0RTvOxktU Z7gPZ5dtwXegVUwcdVAUY61xAZns6JpiWM9twoc= X-Google-Smtp-Source: AGHT+IG4vb/tRKDD3WnSFNmv2zAYRO7/vX5TPm54a/legdAVbGM7Q64Wzy2wd8qWc0yQ6BL3fI+xSTzuOQDg5Yzc0No= X-Received: by 2002:a2e:7813:0:b0:2be:541c:d06b with SMTP id t19-20020a2e7813000000b002be541cd06bmr1498975ljc.53.1694173073494; Fri, 08 Sep 2023 04:37:53 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 8 Sep 2023 04:37:53 -0700 From: Stefan Kangas In-Reply-To: <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> MIME-Version: 1.0 Date: Fri, 8 Sep 2023 04:37:53 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) me@elken.dev writes: >> One idea would be to simply introduce a new variable that takes the >> argument, while making the old one obsolete. That would allow people >> to slowly migrate over to the new one, without everything suddenly >> breaking under their feet. > > How does this patch sound? I think it's the best of both worlds :) LGTM, but let's see if anyone else has any comments. > From 7d6f5c259cefe65b5e021dacee18966acc6bc120 Mon Sep 17 00:00:00 2001 > From: Ellis Kenyo > Date: Mon, 4 Sep 2023 06:20:33 +0100 > Subject: [PATCH] Introduce 'restart-emacs-query-functions' > > * etc/NEWS: Update NEWS file. > > * lisp/files.el (save-buffers-kill-emacs): Add new option > 'restart-emacs-query-functions' for functions that should be called > when 'restart' is passed. > --- > etc/NEWS | 7 +++++++ > lisp/files.el | 13 +++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/etc/NEWS b/etc/NEWS > index bbf4b67fe34..95e6248c08a 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -776,6 +776,13 @@ the current project. > The look of the key prompt in the project switcher has been changed > slightly. To get the previous one, set this option to 'brackets'. > > +** Files > + > +*** New user option 'restart-emacs-query-functions'. > +Equivalent to 'kill-emacs-query-functions', this hook is called when > +'save-buffers-kill-emacs' is called with the 'restart' flag; if > +invoked from say 'M-x restart-emacs'. > + > =0C > * Incompatible Lisp Changes in Emacs 30.1 > > diff --git a/lisp/files.el b/lisp/files.el > index 4188615e490..7849d6b7c81 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -8142,6 +8142,15 @@ defcustom kill-emacs-query-functions > :version "26.1" > :group 'convenience) > > +(defcustom restart-emacs-query-functions nil > + "Functions to call with no arguments to query about restarting > +Emacs. If any of these functions returns nil, restarting Emacs is > +canceled. `save-buffers-kill-emacs' calls these functions when passed > +`restart'. See also `kill-emacs-hook'." > + :type 'hook > + :version "30.1" > + :group 'convenience) > + > (defcustom confirm-kill-emacs nil > "How to ask for confirmation when leaving Emacs. > If nil, the default, don't ask at all. If the value is non-nil, it shou= ld > @@ -8227,6 +8236,10 @@ defun save-buffers-kill-emacs > (yes-or-no-p "Active processes exist; kill t= hem and exit anyway? ")) > (when (window-live-p window) > (quit-restore-window window 'kill))))))))) > + ;; Only call these when restarting > + (when restart > + (run-hook-with-args-until-failure 'restart-emacs-query-functions)= ) > + > ;; Query the user for other things, perhaps. > (run-hook-with-args-until-failure 'kill-emacs-query-functions) > (or (null confirm) > -- > 2.41.0 From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Oct 2023 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: me@elken.dev Cc: 65719@debbugs.gnu.org Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.169738038831562 (code B ref 65719); Sun, 15 Oct 2023 14:34:02 +0000 Received: (at 65719) by debbugs.gnu.org; 15 Oct 2023 14:33:08 +0000 Received: from localhost ([127.0.0.1]:53894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs2B1-0008Cz-WF for submit@debbugs.gnu.org; Sun, 15 Oct 2023 10:33:08 -0400 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:48224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs2Az-0008CR-Fr for 65719@debbugs.gnu.org; Sun, 15 Oct 2023 10:33:06 -0400 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-507a62d4788so1312601e87.0 for <65719@debbugs.gnu.org>; Sun, 15 Oct 2023 07:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697380355; x=1697985155; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=IKbJk8aE+2CfiAXEm2Qd+AQdbzt3eYbCX1nJJs2IGfM=; b=biHXtAnZX+SSjN3lNkIFIAxWj9Wpv9mHy/GApy+Vd4ntphJblBLJb8k6K5uI19ZbN3 tGqCmzG/emWODaISSkpmR1o7Kl9yB5pWOaSO0PClEMM0D+ouGql5MR7aZ+KtTowFAllR nqpXZFWmtSuOkBfo/yZYAzDNobGSfjjnezOztiVq/2G5spVjltxqs7O9QyI5Oo+Pl4S+ vjf42gpSBg34cn12NRV9oWU6erdIJrl+6pqFaDQKR35wKoy4ov/ZN4ISPtLdEb/quqao 0W/bNS8nf6obBEIqRBrP6pXlKqLFipOIHHkoogYbWb7QST6pOFaW9qlOJqdMFNqUbF1G etXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697380355; x=1697985155; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IKbJk8aE+2CfiAXEm2Qd+AQdbzt3eYbCX1nJJs2IGfM=; b=r1856JFzxvQGQpVSYE2w148wAILwH++IikxrcvO5erBIo9DqJb4d8cpNpLjTsJGw9l zNEL3fSBAiqPjRh+6yaAZN5djPs7jg5S1HSxG2jfeZYkaiAlbBQPu/Z1T7Mh1pqmnkeS 0vLzUDUYPMNtmYn0/6XLPzgsSzzuCWsjC46ewzg8BiBr3va5zNWfwhId3SUg8y7a/f17 g8k48sseJm0Gcy4kxaeWv8v2Fwml5nCB965q8BTaCe+vZsAi4oNwty0rHXE5zvxmgSGr GQ53MC2P6qbdhvisyOYqBvcYqxypsKL73IwGALnqPkk9iNLWKAEd8RPJiDTUs7oaPJNW vXAA== X-Gm-Message-State: AOJu0YzUh7kzdQInGfM7x+DaUmqeTgJUs9AZpB8RB+3VZ2wDDBYqVT92 LDZZ2xtAV8u3/ji2/jffC9eaiwzhJ8V/ZY+fqtY9Ln8JSmbFCQ== X-Google-Smtp-Source: AGHT+IFStsaYBCL+cx8WEHW7JxIALCf8ygE1Q3BrjPQKLFY3E/Gj84dmw2MMc03lCVEjacAb5nXJpSt8BI0cAIAb4SI= X-Received: by 2002:a05:6512:32a3:b0:507:b099:749f with SMTP id q3-20020a05651232a300b00507b099749fmr663430lfe.15.1697380354901; Sun, 15 Oct 2023 07:32:34 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Oct 2023 07:32:34 -0700 From: Stefan Kangas In-Reply-To: <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> MIME-Version: 1.0 Date: Sun, 15 Oct 2023 07:32:34 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) me@elken.dev writes: >> One idea would be to simply introduce a new variable that takes the >> argument, while making the old one obsolete. That would allow people >> to >> slowly migrate over to the new one, without everything suddenly >> breaking >> under their feet. > > How does this patch sound? I think it's the best of both worlds :) Thanks, sounds good to me. Before it can go in, I think it should also be added to the user manual, next to where `kill-emacs-query-functions' is documented. And add the correct "+++" tag to the NEWS entry. Thanks in advance. From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Ellis Kenyo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 65719@debbugs.gnu.org Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.170774971022880 (code B ref 65719); Mon, 12 Feb 2024 14:56:02 +0000 Received: (at 65719) by debbugs.gnu.org; 12 Feb 2024 14:55:10 +0000 Received: from localhost ([127.0.0.1]:32955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZXi9-0005wr-2t for submit@debbugs.gnu.org; Mon, 12 Feb 2024 09:55:10 -0500 Received: from mail.elken.dev ([165.22.120.78]:54965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZXi5-0005vI-HG for 65719@debbugs.gnu.org; Mon, 12 Feb 2024 09:55:07 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 6077A3F3A5; Mon, 12 Feb 2024 15:54:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1707749680; bh=LqaD2AcLW0l1iKoB4pjXGNk9ddKK0NlpX06/jgVlaJA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ee0auJrlmfsq/FEa12WAfqDfaMa/rxUhgYxo+Dwe0OV2ybSupYzvgMW3eKmLIIYVP 8IHIxJJ5e3x+NT7dMmSOgqA2iUcuDR4s0hapZQ3ZSJpqIMCM7017/ADAbHYA2kcok+ MCCJCp5YBy5fp/epfKO91a3rRk69qCfNAGMeaTeMOK7V0+GyfVKCE2AmBeSz+gpxiN efCsU96XnDxqrDPGte2O9efjqmoOInJAhSRAk5TAGA+6rcqPVVWTmcdHIAjJKXPRYw 41lrzg1NHzu3LyfsSAJbkQGUr4DgVuQnwZ6TG1tn5sMxm7YTqbsTh3AnrtyWFxJn+3 9GGF6yII/dpYQ== Message-ID: <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> Date: Mon, 12 Feb 2024 14:54:37 +0000 MIME-Version: 1.0 Content-Language: en-US References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> From: Ellis Kenyo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Apologies for letting this one slip, I must have forgotten to reply. Some time has passed since so I'll create a new patch in the next few hours including that manual change and mail it in :) Sorry for the delay! Thanks, Ellis From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Ellis Kenyo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 65719@debbugs.gnu.org Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.170775181812973 (code B ref 65719); Mon, 12 Feb 2024 15:31:01 +0000 Received: (at 65719) by debbugs.gnu.org; 12 Feb 2024 15:30:18 +0000 Received: from localhost ([127.0.0.1]:37021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZYG9-0003N7-PI for submit@debbugs.gnu.org; Mon, 12 Feb 2024 10:30:18 -0500 Received: from mail.elken.dev ([165.22.120.78]:33507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZYG6-0003LG-B4 for 65719@debbugs.gnu.org; Mon, 12 Feb 2024 10:30:15 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 145F6462BA; Mon, 12 Feb 2024 16:29:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1707751791; bh=+wzMhWKdxaHTcC1+D+zviR81zj8trq4GUwv5aR07mww=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=K/F07dl4hGnVfwVmVEdzChXoYbuH8q3oMXAzxVFsYhHL5vaE3Ll8XJopAUet2IJt3 DTVazXdhA00dsiAopvCr2j3j4FQo1cA+FXI98HbptowIHH5vIR8iaeXEJPlB3L1F75 U7ysKNR4tLF1Ndd57TJTAK5llrCWpXB/KhXLoXpCXkSIXLoiAo+UaCsWZLmxeGIvPO JepXE+mxZoTngh3jXcAdQLZuX1YuLJMszcJWtO2ST5AVQG9vf+MeHg/X+DP/31gG/g nbEtDyDyec66bxCoA6mTt2xw8bN86IOYSdyAtKVuy1Jb6fOoxVWXh7kixaaIqajBXS 8Et6p7BD4Njpw== Content-Type: multipart/mixed; boundary="------------tc5H8658SCr54gMaxBIMgJN2" Message-ID: <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> Date: Mon, 12 Feb 2024 15:29:50 +0000 MIME-Version: 1.0 Content-Language: en-US From: Ellis Kenyo References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> In-Reply-To: <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------tc5H8658SCr54gMaxBIMgJN2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit One patch hot and fresh out the oven :) Hope we can get this one in! Thanks, Ellis --------------tc5H8658SCr54gMaxBIMgJN2 Content-Type: text/x-patch; charset=UTF-8; name="0001-Introduce-restart-emacs-query-functions.patch" Content-Disposition: attachment; filename="0001-Introduce-restart-emacs-query-functions.patch" Content-Transfer-Encoding: base64 RnJvbSA3YjE4YjAxYjQzNDAwM2U2ZjI1ZmU4YjcxZDUxMDQ2NGI4YWMwYWZkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBFbGxpcyBLZW55byA8bWVAZWxrZW4uZGV2PgpEYXRl OiBNb24sIDEyIEZlYiAyMDI0IDE1OjI1OjI1ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gSW50 cm9kdWNlICdyZXN0YXJ0LWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucycKCiogZXRjL05FV1M6IFVw ZGF0ZSBORVdTIGZpbGUuCgoqIGxpc3AvZmlsZXMuZWwgKHNhdmUtYnVmZmVycy1raWxsLWVt YWNzKTogQWRkIG5ldyBvcHRpb24KJ3Jlc3RhcnQtZW1hY3MtcXVlcnktZnVuY3Rpb25zJyBm b3IgZnVuY3Rpb25zIHRoYXQgc2hvdWxkIGJlIGNhbGxlZAp3aGVuICdyZXN0YXJ0JyBpcyBw YXNzZWQuCgoqIGRvYy9saXNwcmVmL29zLnRleGk6IERvY3VtZW50ICdyZXN0YXJ0LWVtYWNz LXF1ZXJ5LWZ1bmN0aW9ucycgYW5kCmFkanVzdCAncmVzdGFydC1lbWFjcycgdG8gcmVmbGVj dCBuZXcgY2hhbmdlLgotLS0KIGRvYy9saXNwcmVmL29zLnRleGkgfCAxMiArKysrKysrKysr Ky0KIGV0Yy9ORVdTICAgICAgICAgICAgfCAgNyArKysrKysrCiBsaXNwL2ZpbGVzLmVsICAg ICAgIHwgMTIgKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDMwIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kb2MvbGlzcHJlZi9vcy50ZXhpIGIv ZG9jL2xpc3ByZWYvb3MudGV4aQppbmRleCA2MGFlNTdkNGMxZC4uNTUzM2VkY2RkZWYgMTAw NjQ0Ci0tLSBhL2RvYy9saXNwcmVmL29zLnRleGkKKysrIGIvZG9jL2xpc3ByZWYvb3MudGV4 aQpAQCAtNzYyLDExICs3NjIsMjEgQEAgS2lsbGluZyBFbWFjcwogZGlyZWN0bHkgZG9lcyBu b3QgcnVuIHRoaXMgaG9vay4KIEBlbmQgZGVmb3B0CiAKK0BkZWZvcHQgcmVzdGFydC1lbWFj cy1xdWVyeS1mdW5jdGlvbnMKK1NpbWlsYXIgdG8gaG93IEBjb2Rle2tpbGwtZW1hY3MtcXVl cnktZnVuY3Rpb25zfSBpcyBjYWxsZWQsIHdoZW4gdGhlCitAY29kZXtyZXN0YXJ0fSBmbGFn IGlzIHBhc3NlZDsgdGhlc2UgaG9va3MgdHJpZ2dlci4gQ2FsbGluZworQGNvZGV7cmVzdGFy dC1lbWFjc30gaXMgb25lIHN1Y2ggd2F5IHRvIGVuc3VyZSB0aGlzIGZsYWcgaXMgcGFzc2Vk LgorCitUaGV5IG9iZXkgdGhlIHNhbWUgcnVsZXMgYXMgQGNvZGV7a2lsbC1lbWFjcy1xdWVy eS1mdW5jdGlvbnN9LCBhbmQgYXMKK3N1Y2ggb25lIHNob3VsZCByZWZlcmVuY2UgdGhvc2Ug cnVsZXMgYWJvdmUuCitAZW5kIGRlZm9wdAorCiBAZGVmZm4gQ29tbWFuZCByZXN0YXJ0LWVt YWNzCiBUaGlzIGNvbW1hbmQgZG9lcyB0aGUgc2FtZSBhcyBAY29kZXtzYXZlLWJ1ZmZlcnMt a2lsbC1lbWFjc30sIGJ1dAogaW5zdGVhZCBvZiBqdXN0IGtpbGxpbmcgdGhlIGN1cnJlbnQg RW1hY3MgcHJvY2VzcyBhdCB0aGUgZW5kLCBpdCdsbAogcmVzdGFydCBhIG5ldyBFbWFjcyBw cm9jZXNzLCB1c2luZyB0aGUgc2FtZSBjb21tYW5kIGxpbmUgYXJndW1lbnRzIGFzCi10aGUg Y3VycmVudGx5IHJ1bm5pbmcgRW1hY3MgcHJvY2Vzcy4KK3RoZSBjdXJyZW50bHkgcnVubmlu ZyBFbWFjcyBwcm9jZXNzIGFuZCBhbHNvIHRyaWdnZXIgYWxsIHRoZSBmdW5jdGlvbnMKK2Rl ZmluZWQgaW4gQGNvZGV7cmVzdGFydC1lbWFjcy1xdWVyeS1mdW5jdGlvbnN9LgogQGVuZCBk ZWZmbgogCiBAbm9kZSBTdXNwZW5kaW5nIEVtYWNzCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBi L2V0Yy9ORVdTCmluZGV4IGFmYzJjMjJlNjhiLi5kYTdjZTQ1ZTg3YiAxMDA2NDQKLS0tIGEv ZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTUzOCw2ICs1MzgsMTMgQEAgeW91IGNhbiBh ZGQgdGhpcyB0byB5b3VyIGluaXQgc2NyaXB0OgogCiAgICAgKHNldG9wdCBwcm9qZWN0LXN3 aXRjaC1jb21tYW5kcyAjJ3Byb2plY3QtcHJlZml4LW9yLWFueS1jb21tYW5kKQogCisqKiBG aWxlcworCisqKiogTmV3IHVzZXIgb3B0aW9uICdyZXN0YXJ0LWVtYWNzLXF1ZXJ5LWZ1bmN0 aW9ucycuCitFcXVpdmFsZW50IHRvICdraWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucycsIHRo aXMgaG9vayBpcyBjYWxsZWQgd2hlbgorJ3NhdmUtYnVmZmVycy1raWxsLWVtYWNzJyBpcyBj YWxsZWQgd2l0aCB0aGUgJ3Jlc3RhcnQnIGZsYWc7IGlmCitpbnZva2VkIGZyb20gc2F5ICdN LXggcmVzdGFydC1lbWFjcycuCisKICoqIFZDCiAKIC0tLQpkaWZmIC0tZ2l0IGEvbGlzcC9m aWxlcy5lbCBiL2xpc3AvZmlsZXMuZWwKaW5kZXggZjY3YjY1MGNiOTIuLjk3MDRkODE4MzEw IDEwMDY0NAotLS0gYS9saXNwL2ZpbGVzLmVsCisrKyBiL2xpc3AvZmlsZXMuZWwKQEAgLTgy NTIsNiArODI1MiwxNSBAQCBraWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucwogICA6dmVyc2lv biAiMjYuMSIKICAgOmdyb3VwICdjb252ZW5pZW5jZSkKIAorKGRlZmN1c3RvbSByZXN0YXJ0 LWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucyBuaWwKKyAgIkZ1bmN0aW9ucyB0byBjYWxsIHdpdGgg bm8gYXJndW1lbnRzIHRvIHF1ZXJ5IGFib3V0IHJlc3RhcnRpbmcKK0VtYWNzLiBJZiBhbnkg b2YgdGhlc2UgZnVuY3Rpb25zIHJldHVybnMgbmlsLCByZXN0YXJ0aW5nIEVtYWNzIGlzCitj YW5jZWxlZC4gYHNhdmUtYnVmZmVycy1raWxsLWVtYWNzJyBjYWxscyB0aGVzZSBmdW5jdGlv bnMgd2hlbiBwYXNzZWQKK2ByZXN0YXJ0Jy4gIFNlZSBhbHNvIGBraWxsLWVtYWNzLWhvb2sn LiIKKyAgOnR5cGUgJ2hvb2sKKyAgOnZlcnNpb24gIjMwLjEiCisgIDpncm91cCAnY29udmVu aWVuY2UpCisKIChkZWZjdXN0b20gY29uZmlybS1raWxsLWVtYWNzIG5pbAogICAiSG93IHRv IGFzayBmb3IgY29uZmlybWF0aW9uIHdoZW4gbGVhdmluZyBFbWFjcy4KIElmIG5pbCwgdGhl IGRlZmF1bHQsIGRvbid0IGFzayBhdCBhbGwuICBJZiB0aGUgdmFsdWUgaXMgbm9uLW5pbCwg aXQgc2hvdWxkCkBAIC04MzM3LDYgKzgzNDYsOSBAQCBzYXZlLWJ1ZmZlcnMta2lsbC1lbWFj cwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICh5ZXMtb3Itbm8tcCAiQWN0aXZlIHBy b2Nlc3NlcyBleGlzdDsga2lsbCB0aGVtIGFuZCBleGl0IGFueXdheT8gIikpCiAgICAgICAg ICAgICAgICAgICAgICAgICAod2hlbiAod2luZG93LWxpdmUtcCB3aW5kb3cpCiAgICAgICAg ICAgICAgICAgICAgICAgICAgIChxdWl0LXJlc3RvcmUtd2luZG93IHdpbmRvdyAna2lsbCkp KSkpKSkpKQorICAgICA7OyBPbmx5IGNhbGwgdGhlc2Ugd2hlbiByZXN0YXJ0aW5nCisgICAg ICh3aGVuIHJlc3RhcnQKKyAgICAgICAocnVuLWhvb2std2l0aC1hcmdzLXVudGlsLWZhaWx1 cmUgJ3Jlc3RhcnQtZW1hY3MtcXVlcnktZnVuY3Rpb25zKSkKICAgICAgOzsgUXVlcnkgdGhl IHVzZXIgZm9yIG90aGVyIHRoaW5ncywgcGVyaGFwcy4KICAgICAgKHJ1bi1ob29rLXdpdGgt YXJncy11bnRpbC1mYWlsdXJlICdraWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucykKICAgICAg KG9yIChudWxsIGNvbmZpcm0pCi0tIAoyLjQzLjAKCg== --------------tc5H8658SCr54gMaxBIMgJN2-- From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Ellis Kenyo Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.17077568384949 (code B ref 65719); Mon, 12 Feb 2024 16:54:01 +0000 Received: (at 65719) by debbugs.gnu.org; 12 Feb 2024 16:53:58 +0000 Received: from localhost ([127.0.0.1]:42224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZZZ7-0001Hj-DK for submit@debbugs.gnu.org; Mon, 12 Feb 2024 11:53:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZZZ4-0001H1-DI for 65719@debbugs.gnu.org; Mon, 12 Feb 2024 11:53:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZZYh-0000Jk-Bt; Mon, 12 Feb 2024 11:53:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AM7+SB7Pt9Sll60NDH8yppnjULXG6Czuo1f96aiRdgU=; b=nsG0lUzjYwK1 IUcBdvHgv/L+cIKb1YUmhWtxSdL8dimfQ18DZtYMN9d1xtfWq5Uc5dE1GO4sOLpnmT0iyuZneuuh0 A25bfLebFrr8mpHNs33MbeSGgu22KKb/+1dnA9ZcCQ8zi0rooJm3WlG/Hhm2Z8xiiljQuAXAL6qwN z0lYpirqclOc/nKBOgAeQ3hSD/PaiO6BeF3xv9ulX8bEhNl4N/LtlBGZ9z0xTulEYpWIYQAFosDVI rzLLf/42qWnJEqrL73XkmrpWZU/dVq1uE/B38KKFZzNSUtLag8FplMJ3eB1Qv08mSMIGDOYdjI6Po E5vwnc81zEtSzNjGzXOTMQ==; Date: Mon, 12 Feb 2024 18:53:28 +0200 Message-Id: <86v86tr5dj.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> (bug-gnu-emacs@gnu.org) References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 65719@debbugs.gnu.org > Date: Mon, 12 Feb 2024 15:29:50 +0000 > From: Ellis Kenyo via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > From 7b18b01b434003e6f25fe8b71d510464b8ac0afd Mon Sep 17 00:00:00 2001 > From: Ellis Kenyo > Date: Mon, 12 Feb 2024 15:25:25 +0000 > Subject: [PATCH] Introduce 'restart-emacs-query-functions' > > * etc/NEWS: Update NEWS file. > > * lisp/files.el (save-buffers-kill-emacs): Add new option > 'restart-emacs-query-functions' for functions that should be called > when 'restart' is passed. Thanks, but can you tell in what cases kill-emacs-query-functions (which will be called anyway in this case) is not enough? From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Elken Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.170776062222879 (code B ref 65719); Mon, 12 Feb 2024 17:58:01 +0000 Received: (at 65719) by debbugs.gnu.org; 12 Feb 2024 17:57:02 +0000 Received: from localhost ([127.0.0.1]:45896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZaY6-0005wZ-TF for submit@debbugs.gnu.org; Mon, 12 Feb 2024 12:57:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZaY1-0005vp-Om for 65719@debbugs.gnu.org; Mon, 12 Feb 2024 12:56:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZaDp-00013C-Sw; Mon, 12 Feb 2024 12:36:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YZ4hcB27v1RckaXkW+8AWYbQ7/+fGeEV67eKMr24uBk=; b=PNXClSIejRVP XXkfd2PMYUXiJNGGnj/avOzKNzDhI3Ex+bwWHNUBjZUkcQzKXCk7vZ6uAU5i9BZneBE1VjAxErEQq zin6/D9QwxvlwchpoMk6PK1K743lNOmUJxuEsFVvMrRreqBHrmPk0/pZXF4qQwGDIR7I3YHpOkc22 7PGome9xHWu1RHLKr7u1/a57EoEuloNPxmK4mAztCB9a2MkuT9ZobgwaPyTQ39OE49sXRa7AvkGFA 2gsY6R4ASiY2IdfdMVU4yj33YR8Od6X3FvjsvEjC2F4e54DTgC+CTuTaFRGUw78DwtJzGRRk4pMIc FovV6u5lNUXYtRhqcHTlEw==; Date: Mon, 12 Feb 2024 19:35:58 +0200 Message-Id: <86sf1xr3ep.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Elken on Mon, 12 Feb 2024 17:21:04 +0000) References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [Please use Reply All to reply, to keep everybody CC'ed.] > Date: Mon, 12 Feb 2024 17:21:04 +0000 > From: Elken > > The use case that raised it for me was loading perspective workspaces when I restart in place (due to a > configuration change or other reason) but I don't want to load the workspaces every time I start Emacs. And why cannot you use kill-emacs-query-functions for this purpose? From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Elken Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.170776232230871 (code B ref 65719); Mon, 12 Feb 2024 18:26:02 +0000 Received: (at 65719) by debbugs.gnu.org; 12 Feb 2024 18:25:22 +0000 Received: from localhost ([127.0.0.1]:47628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZazY-00081l-Ng for submit@debbugs.gnu.org; Mon, 12 Feb 2024 13:25:21 -0500 Received: from mail.elken.dev ([165.22.120.78]:54603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZaZB-00061L-JJ for 65719@debbugs.gnu.org; Mon, 12 Feb 2024 12:58:07 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 5972D3F172; Mon, 12 Feb 2024 18:52:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1707760345; bh=gHAzdbP/DNhDw0U635Qeht4iou1Gs1kInQaUyOIdKX0=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=v12hoBB8Wbfe3DMbqiXSnQUQ3lguNHdD0wLa6A60N3koQIVyHos1kfvSp7iQO6VLp kUDC3Edjf9g140oHlx72kJEXtU/8yfEc6O8vAlUiSyE4Y0wFAff1L5e2l4LjqtsnlK K3W3JJVembX67qCxyS7iaorbAfZcLIc01/fyKPmGZuMSu8iz+7y7m5Khjq4TtjYhmf laLJSuwwbpW6CKP7tB/EfRo5GN8VTooWxRjGIwLqON95Iz3UxvBOf7o+UODqI5quIy ViTVPo33Xz/3f1hSImusBtMEC4ePP+z8YKzKwjmP6iZayTFDW0Q+hb2n7U9N6AB5lj nWM8P5EGkj8mQ== Date: Mon, 12 Feb 2024 17:52:24 +0000 From: Elken In-Reply-To: <86sf1xr3ep.fsf@gnu.org> References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> <86sf1xr3ep.fsf@gnu.org> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----0GFMEIR8JG319CL9LX7R8359DQD3I1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------0GFMEIR8JG319CL9LX7R8359DQD3I1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > but I don't want to load the workspaces every time I start Emacs=2E :) ------0GFMEIR8JG319CL9LX7R8359DQD3I1 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
> but I don't want to load = the workspaces every time I start Emacs=2E

:)
------0GFMEIR8JG319CL9LX7R8359DQD3I1-- From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.17358268627795 (code B ref 65719); Thu, 02 Jan 2025 14:08:01 +0000 Received: (at 65719) by debbugs.gnu.org; 2 Jan 2025 14:07:42 +0000 Received: from localhost ([127.0.0.1]:43262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTLrR-00021f-HC for submit@debbugs.gnu.org; Thu, 02 Jan 2025 09:07:41 -0500 Received: from mail.elken.dev ([165.22.120.78]:50223) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTLrP-00021O-NH for 65719@debbugs.gnu.org; Thu, 02 Jan 2025 09:07:40 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 7C9DB46331; Thu, 2 Jan 2025 15:07:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1735826853; bh=Txh29vSxzFc1Y1s5V5EPrCJABaQFGnXgUMR93Xgu/Jk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AeQfJXMZ89qU8sOd2cborGflAKCWMVQH93vv2Z2GHXkDq5ewWtc/Gwgi0W+5fWs9I t+Pe8j1vKzuVtzbFIO0vkvQBfepJBZaMIvhtjiY16k+WGO0mYu0f5Yj8EbEehuJodY Q/4527W9EHCyf43vw3La+at1GYVVdIbtfgH7Cdzp2ZW5Aqi4Qg7WaMoPA8nvaMQYUm +HD7oqfRI4fUqDobeyQEmaMQ/MVcsYfZ5tFbISEPwVDvhSNA972wFcLBjy7FuTj1BE JCYWt26Kue1pFg3JMKai/4uQgajomNhw1SD2rbGIElwsgI8QGgYph8xbjpNkAm+nOS KyZ4O47IMZnfw== MIME-Version: 1.0 Date: Thu, 02 Jan 2025 14:07:33 +0000 From: me@elken.dev In-Reply-To: <86sf1xr3ep.fsf@gnu.org> References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> <86sf1xr3ep.fsf@gnu.org> Message-ID: <60592464472415a836939db15e38a8cf@elken.dev> X-Sender: me@elken.dev Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-02-12 17:35, Eli Zaretskii wrote: > [Please use Reply All to reply, to keep everybody CC'ed.] > >> Date: Mon, 12 Feb 2024 17:21:04 +0000 >> From: Elken >> >> The use case that raised it for me was loading perspective workspaces >> when I restart in place (due to a >> configuration change or other reason) but I don't want to load the >> workspaces every time I start Emacs. > > And why cannot you use kill-emacs-query-functions for this purpose? Bumping this patch again as it would be nice to have in. To answer the question more clearly (I thought I did before, my apologies) using kill-emacs-query-functions would technically work but also add another prompt every time I quit or restart. It makes sense to have a clear separation of quitting for good and restarting in place. I also noticed this morning that `kill-emacs` and `restart-emacs` don't handle the prefix argument for the hooks. Would you accept either another patch for that or an amendment to this patch? The current patch I imagine will need to be rebased anyway, so whichever is easier for you. Again apologies for letting this one slip so long. Thanks all, Ellis From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: me@elken.dev Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.173599617527717 (code B ref 65719); Sat, 04 Jan 2025 13:10:01 +0000 Received: (at 65719) by debbugs.gnu.org; 4 Jan 2025 13:09:35 +0000 Received: from localhost ([127.0.0.1]:53860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU3uG-0007Ct-3X for submit@debbugs.gnu.org; Sat, 04 Jan 2025 08:09:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54372) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU3uA-0007Ca-Ik for 65719@debbugs.gnu.org; Sat, 04 Jan 2025 08:09:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU3u4-00009H-Ij; Sat, 04 Jan 2025 08:09:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=T3QVHTRoS200WphlvyQWsMc9n77b5fIWLgkSheszN1g=; b=S0Fk+5lEcqwv z4tAMwb14IYcTXc2c691JYAvNlp3xdFbVHJLEhqJHTpy1MkPOJLFj5B4KPSUOHWN0O3Oh0rGps3kV hRqZGH4ite178Sxsy4VKf6kYVQaoDNc1G2cUlMWzSCV/3VqW8FItv287yVRXIDnWW2titk584wNcF ZfCpe6W+jEVl5cQXlWlsc2Qb2wtlD46U8BRgCkp7P/KEz3hH1+/f81NNZPxpnZq3QhOFCJRkNTi4Q kCF+tuAd4ymWJSq8ptNVpK/FqqizzycjKSf6BqCvYzoxYrW7SwuysUl1kxgysyymgzhMhSkOtJnQX 4RB0UHPD/82Odag8ghuvdw==; Date: Sat, 04 Jan 2025 15:09:17 +0200 Message-Id: <86v7uud8ua.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <60592464472415a836939db15e38a8cf@elken.dev> (me@elken.dev) References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> <86sf1xr3ep.fsf@gnu.org> <60592464472415a836939db15e38a8cf@elken.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 02 Jan 2025 14:07:33 +0000 > From: me@elken.dev > Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com > > On 2024-02-12 17:35, Eli Zaretskii wrote: > > [Please use Reply All to reply, to keep everybody CC'ed.] > > > >> Date: Mon, 12 Feb 2024 17:21:04 +0000 > >> From: Elken > >> > >> The use case that raised it for me was loading perspective workspaces > >> when I restart in place (due to a > >> configuration change or other reason) but I don't want to load the > >> workspaces every time I start Emacs. > > > > And why cannot you use kill-emacs-query-functions for this purpose? > > Bumping this patch again as it would be nice to have in. To answer the > question more clearly (I thought I did before, my apologies) using > kill-emacs-query-functions would technically work but also add another > prompt every time I quit or restart. It makes sense to have a clear > separation of quitting for good and restarting in place. Sorry, I still don't follow. What does your kill-emacs-query-functions hook do when passed the RESTART argument that is different from RESTART being nil (i.e. killing Emacs without restarting it)? And what does "loading workspaces" mean in this context? > I also noticed this morning that `kill-emacs` and `restart-emacs` don't > handle the prefix argument for the hooks. What would these hooks do with the prefix argument? In any case, the prefix argument is available via current-prefix-arg. From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.173599767232183 (code B ref 65719); Sat, 04 Jan 2025 13:35:02 +0000 Received: (at 65719) by debbugs.gnu.org; 4 Jan 2025 13:34:32 +0000 Received: from localhost ([127.0.0.1]:53924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU4IS-0008N1-1y for submit@debbugs.gnu.org; Sat, 04 Jan 2025 08:34:32 -0500 Received: from mail.elken.dev ([165.22.120.78]:55215) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tU4IQ-0008Mn-5x for 65719@debbugs.gnu.org; Sat, 04 Jan 2025 08:34:31 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 9573946330; Sat, 4 Jan 2025 14:34:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1735997663; bh=7c3hIuSt6ZdsZkAIrXTpzK8bzH1aqVtiJingsJHjf4k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NQANo4lfPQn2xFIdYoG8wcxNpFNNK508lNAQU2wFIdIPtv4Rf7iNzseGYqer/XfwT wmP0zbVbFgOeSWrNzjcwzxoRj/0IQ0AQXmz8zEuJ6/a7rub1Zodm94zOTCQ0v4KXPY g0FhyB9N0lYHAiSRmt7iU8oSU2ZY6o0DNKQR3EeyddRM5V6NiHCQ0zASab3dIG+YJd 6VyIZiP4CztB2Lvdo4osl+lDlgY6a5mjH6oijtx03XPWa1abFLnXIAVPTRpLqwz9Fp wYlHEwGWPHvo5qC7/fV5AquEmdNBjbof7TZkkrHjhWTs/emK+tKpE8/WKeFqQxhMP2 mUGbyX1ndelvg== MIME-Version: 1.0 Date: Sat, 04 Jan 2025 13:34:23 +0000 From: me@elken.dev In-Reply-To: <86v7uud8ua.fsf@gnu.org> References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> <86sf1xr3ep.fsf@gnu.org> <60592464472415a836939db15e38a8cf@elken.dev> <86v7uud8ua.fsf@gnu.org> Message-ID: <9422f3bb7316d0fb3eba6dcc832e26c5@elken.dev> X-Sender: me@elken.dev Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Sorry, I still don't follow. What does your > kill-emacs-query-functions hook do when passed the RESTART argument > that is different from RESTART being nil (i.e. killing Emacs without > restarting it)? The point is differentiating between a quick "Oh I just need to clear out some memory or reset the state of my Emacs, but I want to carry on working as I was" and "I'm done with Emacs now, next time I start it I want it to be a clean slate". Adding another hook was the cleanest option I could come up with. > And what does "loading workspaces" mean in this context? Maybe I should refer to them as perspectives instead, but this package: https://github.com/nex3/perspective-el. An arrangement of buffers and frames categorised by some condition (in my case project.el project) so each perspective has its own "tab" with all the buffers that belong to the perspective and a specific window arrangement. Basically, I want all the open buffers and window arrangement remembered. When I close down Emacs proper, I don't want it to load the exact arrangement when I then re-open it next time. However, when I call `restart-emacs`, I DO want it to load the previous arrangement of buffers, windows and tabs. > In any case, the prefix argument is available via current-prefix-arg. Yes you're right, I realised after I sent it.... From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 14:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: me@elken.dev Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.17360000736664 (code B ref 65719); Sat, 04 Jan 2025 14:15:03 +0000 Received: (at 65719) by debbugs.gnu.org; 4 Jan 2025 14:14:33 +0000 Received: from localhost ([127.0.0.1]:54024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU4vA-0001jQ-Hk for submit@debbugs.gnu.org; Sat, 04 Jan 2025 09:14:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43052) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU4v7-0001j8-7F for 65719@debbugs.gnu.org; Sat, 04 Jan 2025 09:14:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU4v1-0000nX-Gi; Sat, 04 Jan 2025 09:14:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2qhD1K0GK5+KdtD7TPR+B2fTgmg4/y+xMryyPnnWS2A=; b=RkPfDLqVMrw4 4hv0AySC6kkoQ6WHieRfwMRWC89+i5PXHWm1iV+UUsasdNe1yhOafN4oLlz6gtqeTM98L2I0PxL78 G361dpnVqTxHDEPdY0Vdhrrt9M/CHM0HkcDc2zH/1sAaJY5otBoCLTwEu96+ByEagxeZLPy78x98Y dg44NgQPRed3D4m59c2rZQvBTxn2d/gxCzcP7qOx4JPvtpWp0qChiEN1NZcTD2U+iOmZTcbSg5wUV BSlQU4HINWFa7FpO36Fc/rYOuwjDsduIctcXb4sySUmPJaOTyp0Wz3YANkWbfFL1xJVtWd6BZBwAQ mKaN/QvWsvGnse5Ck2yNlw==; Date: Sat, 04 Jan 2025 16:14:17 +0200 Message-Id: <86cyh2d5ty.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <9422f3bb7316d0fb3eba6dcc832e26c5@elken.dev> (me@elken.dev) References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> <86sf1xr3ep.fsf@gnu.org> <60592464472415a836939db15e38a8cf@elken.dev> <86v7uud8ua.fsf@gnu.org> <9422f3bb7316d0fb3eba6dcc832e26c5@elken.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 04 Jan 2025 13:34:23 +0000 > From: me@elken.dev > Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com > > > Sorry, I still don't follow. What does your > > kill-emacs-query-functions hook do when passed the RESTART argument > > that is different from RESTART being nil (i.e. killing Emacs without > > restarting it)? > > The point is differentiating between a quick "Oh I just need to clear > out some memory or reset the state of my Emacs, but I want to carry on > working as I was" and "I'm done with Emacs now, next time I start it I > want it to be a clean slate". Adding another hook was the cleanest > option I could come up with. It's a strange (and maybe even dangerous) distinction. But in any case, I think a cleaner solution would be to bind a variable inside restart-emacs, and then your hook could examine it. Alternatively, ... > > In any case, the prefix argument is available via current-prefix-arg. > > Yes you're right, I realised after I sent it.... ...you could invoke restart-emacs with a prefix argument, and examine that in your kill-emacs-query-functions hook. AFAICT, this should work without any changes. From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2025 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.173626529125164 (code B ref 65719); Tue, 07 Jan 2025 15:55:02 +0000 Received: (at 65719) by debbugs.gnu.org; 7 Jan 2025 15:54:51 +0000 Received: from localhost ([127.0.0.1]:44276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVBus-0006Xo-U5 for submit@debbugs.gnu.org; Tue, 07 Jan 2025 10:54:51 -0500 Received: from mail.elken.dev ([165.22.120.78]:47737) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVBur-0006XV-05 for 65719@debbugs.gnu.org; Tue, 07 Jan 2025 10:54:49 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 6083C46327; Tue, 7 Jan 2025 16:54:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1736265282; bh=HYVZCzikBRCMdMHtGcPzWJ6HrIm2UBbByc7Z4e/nkkU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bl47H0ZDt9D/tEGAyVxZJ9vflVINpI7toKtAjdvOm6jl7i1ZWb+3engY1XPzbc9Nc PrSR6x8MPuctWqFcizFmQ8UMBVUgdQ8iTY7Vr3tQEnL8q85t7A+3KQNCgYZgGi0mCn 1q1aPPQRsOJwDUK0fk8Y/ZUH29TBUwHIwFHwGhQhiMTxiiQz4TP1n5BXJDojb8S2de FqFj1sSmqkdjEOJN9grIwtqLs3RNYFnwX+9RfgCoNSp7IefAIDVp0Dda+OdWgMkSN9 0ajf63/xqZTa0vIsHDLL5yWNpIxAOAiX7kS70baZp0Umf85qMj1EuB4lNVxS6xmxHz nnLlNGNkN27iA== MIME-Version: 1.0 Date: Tue, 07 Jan 2025 15:54:42 +0000 From: me@elken.dev In-Reply-To: <86cyh2d5ty.fsf@gnu.org> References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> <86sf1xr3ep.fsf@gnu.org> <60592464472415a836939db15e38a8cf@elken.dev> <86v7uud8ua.fsf@gnu.org> <9422f3bb7316d0fb3eba6dcc832e26c5@elken.dev> <86cyh2d5ty.fsf@gnu.org> Message-ID: <681a879f34e51bf76bea93a65822b572@elken.dev> X-Sender: me@elken.dev Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > It's a strange (and maybe even dangerous) distinction. I'm afraid I don't see this, could you elaborate? > But in any case, I think a cleaner solution would be to bind a > variable inside restart-emacs, and then your hook could examine it. > Alternatively, ... > >> > In any case, the prefix argument is available via current-prefix-arg. >> >> Yes you're right, I realised after I sent it.... > > ...you could invoke restart-emacs with a prefix argument, and examine > that in your kill-emacs-query-functions hook. AFAICT, this should > work without any changes. I'm afraid I also don't follow here, how is that cleaner than introducing a specific hook? Rather than needing to specifically modify a function to work with the prefix argument, you can just add it to the hook. From unknown Tue Jun 17 01:26:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2025 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: me@elken.dev Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.17362678991201 (code B ref 65719); Tue, 07 Jan 2025 16:39:02 +0000 Received: (at 65719) by debbugs.gnu.org; 7 Jan 2025 16:38:19 +0000 Received: from localhost ([127.0.0.1]:44387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVCat-0000J8-QM for submit@debbugs.gnu.org; Tue, 07 Jan 2025 11:38:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34742) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVCar-0000Io-8D for 65719@debbugs.gnu.org; Tue, 07 Jan 2025 11:38:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVCal-0004N2-Ec; Tue, 07 Jan 2025 11:38:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gqJvjDVSJzoqwG4yWeQo6bGWvRvQzWICxbeqehPUeqA=; b=bKkmzO403l2J d96oNlLR7j1abassn/Erl7aKZ68oIDaHDtxqT4pBUCdztWy9hZafTLDKyjIH5EPfajBupp/uAIw+e xG5MATNh6MlVWdfuZlaUdRXrQpY3rzx3j2T7wiRIGVXv0uRzVfYUtxj7FDrRhb92qF+ww4wI8dk5M 2SfMRI1K02JtyGMlIfelMpWTfalMARplY44kwy21bRQVxNUcFKw2HBcwwQnZrmkJpPn1ExbIXLTXp LjBj4Ug4zGx6PyVsmx0fWCAFr1uLctiffQryL10MHFXRroYoTPAOYtAdpuIW7FOsRPMcI4ZglNe15 S2crAfTbLOvRkQqzqdJb7A==; Date: Tue, 07 Jan 2025 18:38:04 +0200 Message-Id: <86jzb64m1f.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <681a879f34e51bf76bea93a65822b572@elken.dev> (me@elken.dev) References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> <86sf1xr3ep.fsf@gnu.org> <60592464472415a836939db15e38a8cf@elken.dev> <86v7uud8ua.fsf@gnu.org> <9422f3bb7316d0fb3eba6dcc832e26c5@elken.dev> <86cyh2d5ty.fsf@gnu.org> <681a879f34e51bf76bea93a65822b572@elken.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 07 Jan 2025 15:54:42 +0000 > From: me@elken.dev > Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com > > > It's a strange (and maybe even dangerous) distinction. > > I'm afraid I don't see this, could you elaborate? > > > But in any case, I think a cleaner solution would be to bind a > > variable inside restart-emacs, and then your hook could examine it. > > Alternatively, ... > > > >> > In any case, the prefix argument is available via current-prefix-arg. > >> > >> Yes you're right, I realised after I sent it.... > > > > ...you could invoke restart-emacs with a prefix argument, and examine > > that in your kill-emacs-query-functions hook. AFAICT, this should > > work without any changes. > > I'm afraid I also don't follow here, how is that cleaner than > introducing > a specific hook? Rather than needing to specifically modify a function > to work with the prefix argument, you can just add it to the hook. It isn't necessarily cleaner, but it is a local solution for what I consider a local and very specialized problem. There's no reason to expect Emacs to have an OOTB solution for every possible niche use case that some user needs to handle. Adding a hook means we all have to pay the price in documenting it, maintaining it, etc. Each request for adding a new feature should have a solid enough basis before we must consider it for addition. FWIW, I don't yet see why this particular request qualifies. From unknown Tue Jun 17 01:26:26 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: me@elken.dev Subject: bug#65719: closed (Re: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions') Message-ID: References: <86bjvlg99p.fsf@gnu.org> <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> X-Gnu-PR-Message: they-closed 65719 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 65719@debbugs.gnu.org Date: Sat, 01 Feb 2025 12:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1738411562-23705-1" This is a multi-part message in MIME format... ------------=_1738411562-23705-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 65719@debbugs.gnu.org. --=20 65719: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65719 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1738411562-23705-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 65719-done) by debbugs.gnu.org; 1 Feb 2025 12:05:51 +0000 Received: from localhost ([127.0.0.1]:56851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teCFz-00069z-8d for submit@debbugs.gnu.org; Sat, 01 Feb 2025 07:05:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60856) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teCFx-00069g-24 for 65719-done@debbugs.gnu.org; Sat, 01 Feb 2025 07:05:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1teCFr-0000YP-2l; Sat, 01 Feb 2025 07:05:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kdzFW8V9Xjdb3yrzi7mxy3Eo2leVUN3YlD7YamUqoEI=; b=UTH7kmxMvFQd F9drHmKEDno1MK9cODT/BY8yUC2WchWDq49GjEYe488bl3+LdlvbdpA4KwRbcCmTA6gZrwVv0zob0 c4a2injH/PRHvpOMT5A5VA0d4MaSbMtpztEkwhf4b56FLAVzU/qblGUAuyo29RBIdgj3VzEj10KOB rCFmNXbh2YC2itnBfB/DiRLfXOJVPSz9ovJc0JyYg6GFFIVUYXU48I8Ct1UOZLXucrjvaabdgITU5 Tvx8JlX4kDrGP2UyZCA0GQUvXPGuLnjPHVae4y5FwBzdOB7V3n1U5clG8jLRZcH+La6jd+3WMsbHQ 51IK0hreM6AdmN6YN9JoGw==; Date: Sat, 01 Feb 2025 14:05:38 +0200 Message-Id: <86bjvlg99p.fsf@gnu.org> From: Eli Zaretskii To: me@elken.dev In-Reply-To: <86jzb64m1f.fsf@gnu.org> (message from Eli Zaretskii on Tue, 07 Jan 2025 18:38:04 +0200) Subject: Re: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> <0817cde8dd8dab055dafe2e8aa3d30d5@elken.dev> <2aae66e7-f7e3-4da4-aee8-0ff9a8db1f0a@elken.dev> <0d97a409-b9c4-4204-b5d0-1bb386056c56@elken.dev> <86v86tr5dj.fsf@gnu.org> <86sf1xr3ep.fsf@gnu.org> <60592464472415a836939db15e38a8cf@elken.dev> <86v7uud8ua.fsf@gnu.org> <9422f3bb7316d0fb3eba6dcc832e26c5@elken.dev> <86cyh2d5ty.fsf@gnu.org> <681a879f34e51bf76bea93a65822b572@elken.dev> <86jzb64m1f.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65719-done Cc: 65719-done@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com > Date: Tue, 07 Jan 2025 18:38:04 +0200 > From: Eli Zaretskii > > > Date: Tue, 07 Jan 2025 15:54:42 +0000 > > From: me@elken.dev > > Cc: 65719@debbugs.gnu.org, stefankangas@gmail.com > > > > > It's a strange (and maybe even dangerous) distinction. > > > > I'm afraid I don't see this, could you elaborate? > > > > > But in any case, I think a cleaner solution would be to bind a > > > variable inside restart-emacs, and then your hook could examine it. > > > Alternatively, ... > > > > > >> > In any case, the prefix argument is available via current-prefix-arg. > > >> > > >> Yes you're right, I realised after I sent it.... > > > > > > ...you could invoke restart-emacs with a prefix argument, and examine > > > that in your kill-emacs-query-functions hook. AFAICT, this should > > > work without any changes. > > > > I'm afraid I also don't follow here, how is that cleaner than > > introducing > > a specific hook? Rather than needing to specifically modify a function > > to work with the prefix argument, you can just add it to the hook. > > It isn't necessarily cleaner, but it is a local solution for what I > consider a local and very specialized problem. There's no reason to > expect Emacs to have an OOTB solution for every possible niche use > case that some user needs to handle. Adding a hook means we all have > to pay the price in documenting it, maintaining it, etc. > > Each request for adding a new feature should have a solid enough basis > before we must consider it for addition. FWIW, I don't yet see why > this particular request qualifies. No further comments, so I'm closing this bug. ------------=_1738411562-23705-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Sep 2023 19:28:52 +0000 Received: from localhost ([127.0.0.1]:46959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcsmB-0005xt-Tr for submit@debbugs.gnu.org; Sun, 03 Sep 2023 15:28:52 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcsmA-0005xh-7X for submit@debbugs.gnu.org; Sun, 03 Sep 2023 15:28:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcsm4-0003SF-Qd for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 15:28:45 -0400 Received: from mail.elken.dev ([165.22.120.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcsm1-0008A5-Qm for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 15:28:44 -0400 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id D834E45D52 for ; Sun, 3 Sep 2023 21:28:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1693769314; bh=VPe8aYrLge9ApuDynvwvY9YEXObu1+TjlbqtB4BJkDQ=; h=Date:From:To:Subject:From; b=jJhnrMRPJbzlCvm0M6kG/HTgZZc9Ed1awC7bfBlTDQJR1OsTaXJmolX3WYd47EVGN clhqw5BEiGnVzTSJyR5JxhgT5OGxKE8BasbuUTpZwb5Ue/JM3KN4fHsFZpGyOgh7Ye 3T29oazic0Otb1iKbMOENZ7rRrx61DzAkPWCitQMsbX5yf3Pt8Vo2lpfg4iYm0QqL4 bfNJlkHLa4LW/4yPqZdSX7ESLsYZPa6PFPziMy8+lgghkP7IdSTaqCG9qysRSTau7x 4HXCisDvAF0p5ikVBL71ATLVU9g2tJjqNIxgng2hgWNqxlBlKhK8w/EEXw5ePxSdOQ Ar/LKCqXHvnFQ== MIME-Version: 1.0 Date: Sun, 03 Sep 2023 20:28:34 +0100 From: me@elken.dev To: bug-gnu-emacs@gnu.org Subject: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Message-ID: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> X-Sender: me@elken.dev Content-Type: multipart/mixed; boundary="=_69c6835b0749f6a7ab6541f194863d1c" Received-SPF: pass client-ip=165.22.120.78; envelope-from=me@elken.dev; helo=mail.elken.dev X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=_69c6835b0749f6a7ab6541f194863d1c Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi all, Small change here to pass the restart status to 'kill-emacs-query-functions' in 'save-buffers-kill-emacs' so any functions there can react to being restarted, sample use-case this may be useful is if one is using a package like perspective.el to handle buffer/window management and when calling `M-x restart-emacs` you WANT your last session to be persisted, but just starting Emacs normally you don't. There are other potential use-cases for this too, so hopefully this patch is well-received. Thanks all, Ellis (@lkn) --=_69c6835b0749f6a7ab6541f194863d1c Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Add-restart-argument-to-kill-emacs-query-functions.patch Content-Disposition: attachment; filename=0001-Add-restart-argument-to-kill-emacs-query-functions.patch; size=2423 RnJvbSAyNTBjMGM0Zjg4ZjFkMTY5NDE1ZDRmNmM2NjM0ZTE3ODI5MDY0NzQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGxpcyBLZW55byA8bWVAZWxrZW4uZGV2PgpEYXRlOiBTdW4s IDMgU2VwIDIwMjMgMjA6MTc6MjEgKzAxMDAKU3ViamVjdDogW1BBVENIXSBBZGQgcmVzdGFydCBh cmd1bWVudCB0byAna2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMnCgoqIGV0Yy9ORVdTOiBVcGRh dGUgTkVXUyBmaWxlLgoKKiBsaXNwL2ZpbGVzLmVsIChzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcyk6 IFBhc3MgaW4gdGhlIFJFU1RBUlQKYXJndW1lbnQgdG8gc3Vic2VxdWVudCBob29rIGNhbGxzLgot LS0KIGV0Yy9ORVdTICAgICAgfCAgNyArKysrKysrCiBsaXNwL2ZpbGVzLmVsIHwgMTEgKysrKysr LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGJiZjRiNjdmZTM0Li43Mjcz ZWJkMjE4MyAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTc3Niw2ICs3 NzYsMTMgQEAgdGhlIGN1cnJlbnQgcHJvamVjdC4KIFRoZSBsb29rIG9mIHRoZSBrZXkgcHJvbXB0 IGluIHRoZSBwcm9qZWN0IHN3aXRjaGVyIGhhcyBiZWVuIGNoYW5nZWQKIHNsaWdodGx5LiAgVG8g Z2V0IHRoZSBwcmV2aW91cyBvbmUsIHNldCB0aGlzIG9wdGlvbiB0byAnYnJhY2tldHMnLgogCisq KiBGaWxlcworCisqKiogJ2tpbGwtZW1hY3MtcXVlcnktZnVuY3Rpb25zJyBub3cgdGFrZXMgUkVT VEFSVCBhcyBhbiBhcmd1bWVudC4KK0Z1bmN0aW9ucyBhZGRlZCB0byB0aGlzIGhvb2sgY2FuIG5v dyBhY2NlcHQgYW4gYXJndW1lbnQgZGVub3RpbmcKK3doZXRoZXIgb3Igbm90IHRoZSBjYWxsIGlz IGR1ZSB0byBjYWxsIHJlc3RhcnQgRW1hY3M7IGlmIGNhbGxlZCBmcm9tCitzYXkgJ3Jlc3RhcnQt ZW1hY3MnLgorCiAMCiAqIEluY29tcGF0aWJsZSBMaXNwIENoYW5nZXMgaW4gRW1hY3MgMzAuMQog CmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxlcy5lbAppbmRleCA0MTg4NjE1 ZTQ5MC4uMDk1Y2JhNjkzZDAgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMuZWwKKysrIGIvbGlzcC9m aWxlcy5lbApAQCAtODEzNCwxMCArODEzNCwxMSBAQCBkZWZ1biBpbnNlcnQtZGlyZWN0b3J5LXNh ZmVseQogICAgIChpbnNlcnQgKGZvcm1hdCAiJXM6IE5vIHN1Y2ggZmlsZSBvciBkaXJlY3Rvcnlc biIgZmlsZSkpKSkKIAogKGRlZmN1c3RvbSBraWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucyBuaWwK LSAgIkZ1bmN0aW9ucyB0byBjYWxsIHdpdGggbm8gYXJndW1lbnRzIHRvIHF1ZXJ5IGFib3V0IGtp bGxpbmcgRW1hY3MuCi1JZiBhbnkgb2YgdGhlc2UgZnVuY3Rpb25zIHJldHVybnMgbmlsLCBraWxs aW5nIEVtYWNzIGlzIGNhbmNlbGVkLgotYHNhdmUtYnVmZmVycy1raWxsLWVtYWNzJyBjYWxscyB0 aGVzZSBmdW5jdGlvbnMsIGJ1dCBga2lsbC1lbWFjcycsCi10aGUgbG93IGxldmVsIHByaW1pdGl2 ZSwgZG9lcyBub3QuICBTZWUgYWxzbyBga2lsbC1lbWFjcy1ob29rJy4iCisgICJGdW5jdGlvbnMg dG8gY2FsbCB3aXRoIHJlc3RhcnQgc3RhdHVzIGFzIGFuIGFyZ3VtZW50IHRvIHF1ZXJ5IGFib3V0 CitraWxsaW5nIEVtYWNzLiBJZiBhbnkgb2YgdGhlc2UgZnVuY3Rpb25zIHJldHVybnMgbmlsLCBr aWxsaW5nIEVtYWNzIGlzCitjYW5jZWxlZC4gYHNhdmUtYnVmZmVycy1raWxsLWVtYWNzJyBjYWxs cyB0aGVzZSBmdW5jdGlvbnMsIGJ1dAorYGtpbGwtZW1hY3MnLHRoZSBsb3cgbGV2ZWwgcHJpbWl0 aXZlLCBkb2VzIG5vdC4gIFNlZSBhbHNvCitga2lsbC1lbWFjcy1ob29rJy4iCiAgIDp0eXBlICdo b29rCiAgIDp2ZXJzaW9uICIyNi4xIgogICA6Z3JvdXAgJ2NvbnZlbmllbmNlKQpAQCAtODIyOCw3 ICs4MjI5LDcgQEAgZGVmdW4gc2F2ZS1idWZmZXJzLWtpbGwtZW1hY3MKICAgICAgICAgICAgICAg ICAgICAgICAgICh3aGVuICh3aW5kb3ctbGl2ZS1wIHdpbmRvdykKICAgICAgICAgICAgICAgICAg ICAgICAgICAgKHF1aXQtcmVzdG9yZS13aW5kb3cgd2luZG93ICdraWxsKSkpKSkpKSkpCiAgICAg IDs7IFF1ZXJ5IHRoZSB1c2VyIGZvciBvdGhlciB0aGluZ3MsIHBlcmhhcHMuCi0gICAgIChydW4t aG9vay13aXRoLWFyZ3MtdW50aWwtZmFpbHVyZSAna2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMp CisgICAgIChydW4taG9vay13aXRoLWFyZ3MtdW50aWwtZmFpbHVyZSAna2lsbC1lbWFjcy1xdWVy eS1mdW5jdGlvbnMgcmVzdGFydCkKICAgICAgKG9yIChudWxsIGNvbmZpcm0pCiAgICAgICAgICAo ZnVuY2FsbCBjb25maXJtICJSZWFsbHkgZXhpdCBFbWFjcz8gIikpCiAgICAgIChraWxsLWVtYWNz IG5pbCByZXN0YXJ0KSkpKQotLSAKMi40MS4wCgo= --=_69c6835b0749f6a7ab6541f194863d1c-- ------------=_1738411562-23705-1--