GNU bug report logs - #65717
[PATCH] gnu: Add emacs-latex-extra.

Previous Next

Full log

Message #8 received at 65717 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 65717 <at> debbugs.gnu.org
Subject: Re: [bug#65717] [PATCH] gnu: Add emacs-latex-extra.
Date: Sun, 03 Sep 2023 21:44:49 +0200

Hello,

Sergiu Ivanov <sivanov <at> colimite.fr> writes:

> Subject: [PATCH] gnu: Add emacs-latex-extra.

Thank you.

Some comments follow.

> +      (build-system emacs-build-system)
> +      (arguments
> +       `(#:phases (modify-phases %standard-phases
> +                    (add-before 'build 'set-home
> +                      (lambda _
> +                        (setenv "HOME"
> +                                (getcwd)))))))

Why is it needed ?

Also, upstream provides tests. Could you run them?

> +      (inputs (list emacs-auctex))

Usually, inputs are propagated, although it doesn't make a difference
for Emacs.

> +      (home-page "https://github.com/Malabarba/latex-extra")
> +      (synopsis "Usability improvements for latex-mode")

Nitpick: "latex-mode" -> "LaTeX mode"

> +      (description
> +       "Latex-extra defines extra commands and keys for LaTeX-mode, as well
> +as brings user experience improvements.")

Nitpick: "LaTeX-mode" -> "LaTeX mode"

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.