From unknown Wed Jun 18 23:04:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65708 <65708@debbugs.gnu.org> To: bug#65708 <65708@debbugs.gnu.org> Subject: Status: 30.0.50; Wrong default value for functions in filesets.el Reply-To: bug#65708 <65708@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:04:26 +0000 retitle 65708 30.0.50; Wrong default value for functions in filesets.el reassign 65708 emacs submitter 65708 Mauro Aranda severity 65708 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 18:21:56 2023 Received: (at submit) by debbugs.gnu.org; 2 Sep 2023 22:21:56 +0000 Received: from localhost ([127.0.0.1]:38847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcZ08-0004C3-AI for submit@debbugs.gnu.org; Sat, 02 Sep 2023 18:21:56 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcZ01-0004Bl-J8 for submit@debbugs.gnu.org; Sat, 02 Sep 2023 18:21:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcYzm-0005ZR-8P for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 18:21:34 -0400 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcYzk-0007FR-5w for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 18:21:34 -0400 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-1d4c9494b42so39314fac.0 for ; Sat, 02 Sep 2023 15:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693693290; x=1694298090; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=18+ZhNZulBlsTlSvb1/kP0yNe9NZ5C913pT2674Nwbs=; b=ml4YZ+v3hNrnR2sXvZE28zL6Uhs3pG5y3If4Bg4fKcQMVt2vxRp5iZZFdZEdxYHJwo RbVFqakEI1fmSh4lKx2TyBe/dB+b0wfeVDSu5neifyt15pI1mb1O0GT/BEvfxGWQjMBd FoIHjgoR8ZZwApDbo56fWE4N1yKwKnSZtLVHl9sR/j6wbRpT15eggWqcQRoByFQFWF/2 L5dv+ARpD6h5uFzWVxvFc+U5sDG9Lhgd/PZolRJhcXMKfta3oPCtAu/ld/DC1RvJ7pw2 WAgGL0COJEJXJDNRZz/f/Zxx1Y3eIsQkOvrrjGX7uin2mos9pYBf6845tNZtDZjFffqD mszw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693693290; x=1694298090; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=18+ZhNZulBlsTlSvb1/kP0yNe9NZ5C913pT2674Nwbs=; b=WlDnGg+e19x9Y7enBeuwQNqyxdhc/Jpy58lt1yVSKi3t4Gt4fbl2ppeIKT9QH8FuYB 2RHekeKFBzBcnpPaKK2msmjPDSfESK9JAQ8IJigBLRBQPhzWPFN/3YnIseAD9s4cimI+ v5DUdwTiFa39BFBUKt3wDs6+oUdQgni0rsphtEx9lqeUW9C6EyQOfaY8DSub8R8jAYAo Way/2fsfYqQnmQo+JwK99H9Ssilmi1zRnk5m7CF3VnhY5XuIsC1BPxoDOc04hSE7g30V jGEBDHf+dsBTeuQNS6iDJOuDg7fqms1Dz2aaAaFJ8/znGnXvMWRXD37jiDdQCp98PKSR im6Q== X-Gm-Message-State: AOJu0Yx0gi48SprNCHsCqVCtztUwByOZdzX1HYZUtyPvOaT8s5S45oWv Zmglmb6Jd2j8m+YOammalfl0SC8Nalt4pA== X-Google-Smtp-Source: AGHT+IHlVdhRgJWvhelwJtb8DawLwVWcqtDuf6iuPUZxzt/rZAiQ6vxjAC0WiT5DB29K6twv5O/nKQ== X-Received: by 2002:a05:6870:1702:b0:1c8:cb3c:8867 with SMTP id h2-20020a056870170200b001c8cb3c8867mr8616781oae.41.1693693290287; Sat, 02 Sep 2023 15:21:30 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id dx11-20020a056870768b00b001beeaa10924sm3773737oab.0.2023.09.02.15.21.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Sep 2023 15:21:29 -0700 (PDT) Message-ID: <9c42d2b1-1e89-2334-fb87-9ee10d1e05ee@gmail.com> Date: Sat, 2 Sep 2023 19:21:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: 30.0.50; Wrong default value for functions in filesets.el Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:4860:4864:20::36; envelope-from=maurooaranda@gmail.com; helo=mail-oa1-x36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The following user options: filesets-browse-dir-function filesets-open-file-function filesets-save-buffer-function filesets-commands filesets-external-viewers have overridden the default value of the function widget to the value nil.  That's an invalid default value.  It'd be better to just remove that. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 18:42:29 2023 Received: (at 65708) by debbugs.gnu.org; 2 Sep 2023 22:42:29 +0000 Received: from localhost ([127.0.0.1]:38866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcZK1-0004hu-Dt for submit@debbugs.gnu.org; Sat, 02 Sep 2023 18:42:29 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:56491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcZJw-0004he-Qq for 65708@debbugs.gnu.org; Sat, 02 Sep 2023 18:42:27 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-500a8b2b73eso489449e87.0 for <65708@debbugs.gnu.org>; Sat, 02 Sep 2023 15:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693694528; x=1694299328; darn=debbugs.gnu.org; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=CuCQzTLCk9tcS2982O7rFUm7fBJ7U53mwN6E+DcGERg=; b=gVZZ9cB4qEH10wHlROl7JoreV3slU3q3mNLsJuRtepeC77P8weyjeKynrmqDatT8iI bmBZ2HaQhpHSCbtSamYqK518/jRrHrLwmwM8IOLfP7ImSP68+nUWy2zs6tOTyT/PesxC sYnWYJ4tky3bHhXl7BOKPdz1McG/M+2uSLb/8iw7WwpczrDIwcfSxFt2hVtJFTWAoDkV kyUbu+B2IhEwlrTh4MmgkymBHpRqP3InLxxeHKa+5mSpzRF0UKcavMPqimAiFZ97vnu5 9vHJn0Ng+3gu+te8QXECJauUfHxVTHyleTuf7AaTmcyp1zZuPtdiA4vNBGIkSEjSrnjB U+Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693694528; x=1694299328; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CuCQzTLCk9tcS2982O7rFUm7fBJ7U53mwN6E+DcGERg=; b=ROuikxnE9uVl4x1pDeM0hTr9IZLEdZ1ZRQZaKgvx8+/6SusxlrOCpdB4FcmokQfeU3 c8iDr6u0Sn4wWt6mmqAbkOCr2YQX/83L3488Huskj1ACejp8mGFsm0EnRNxyogQklvZC bSpkv7N6OVmyno+mGoxTm4MD0z1x2jib9qFjai0UDAWIXou5XkLC1f93VXPu2k5SXS6r Ss6Po7ULylC6kT5c/hQ5uKgeJedVUiod5k3VfQV6pIkZ4RlVHWxs4KrOOrlYODzMMJNo YAlHDLBmtG73EWmx/wgQs+xk7y9fmgkQ0XsaFiSIOwZe1AfNsPpc7VGnFCgKENsd1RFb e0IA== X-Gm-Message-State: AOJu0Yx/H31YBial2bV4JFub44tfdoCkzvl/pJJiG5oz6MmDhazjWK+E 6v6G05ULSvgR+XDQQnT+XQYV5qUTr/afN3PRk5c= X-Google-Smtp-Source: AGHT+IHg9lYjEbT/5yAPLImjb0Zz2dNdumdzLCWlSrQv9s8vudoBKPPuYAQAgw+AATmmSta+D4hlyY2M31Oy0p+OzzU= X-Received: by 2002:a19:4f0e:0:b0:4fe:2d93:2b50 with SMTP id d14-20020a194f0e000000b004fe2d932b50mr3649573lfb.31.1693694528372; Sat, 02 Sep 2023 15:42:08 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 2 Sep 2023 15:42:07 -0700 From: Stefan Kangas In-Reply-To: <9c42d2b1-1e89-2334-fb87-9ee10d1e05ee@gmail.com> References: <9c42d2b1-1e89-2334-fb87-9ee10d1e05ee@gmail.com> MIME-Version: 1.0 Date: Sat, 2 Sep 2023 15:42:07 -0700 Message-ID: Subject: Re: bug#65708: 30.0.50; Wrong default value for functions in filesets.el To: Mauro Aranda , 65708@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65708 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > The following user options: > filesets-browse-dir-function > filesets-open-file-function > filesets-save-buffer-function > filesets-commands > filesets-external-viewers > > have overridden the default value of the function widget to the value > nil.=C2=A0 That's an invalid default value.=C2=A0 It'd be better to just = remove > that. Makes sense, but you forgot to attach the patch. ;-) From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 18:47:20 2023 Received: (at 65708) by debbugs.gnu.org; 2 Sep 2023 22:47:20 +0000 Received: from localhost ([127.0.0.1]:38877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcZOi-0004qM-FB for submit@debbugs.gnu.org; Sat, 02 Sep 2023 18:47:20 -0400 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]:60796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcZOe-0004q7-Pr for 65708@debbugs.gnu.org; Sat, 02 Sep 2023 18:47:19 -0400 Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-5734b893a11so191252eaf.1 for <65708@debbugs.gnu.org>; Sat, 02 Sep 2023 15:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693694821; x=1694299621; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DkWTw7s2UJ8f1+WsuAJKApF3MaQNVBwJBbT87ifT4IQ=; b=BBL6jesdsizTVH7l61DUfkWtrHXNl3ut5gP4s6nhfOr0nkumPcl5khiPy3b9aPwWGO pfw9JF/ua/xeiCBMPIlOjrXU9LVvi+o4ZEeTaVsDkQCsXk0qW8OjcFX/wSRRepogcWW3 ZFui0+V7OeQb53KuSSo82Vqao3sA6k1TZs1CIUDGEBqLHd7HCVIrlsVKofuHdIVVJ35X ljxGUy0gHYlk8NG6n3zbNZH3hhQGy8ixo4wZ3GzUISMmAyCkGLy8LR3X4jp4+45tkGgU m+iOB0rhZb47C4gY9/66P5u/WhNhTj/aCZ8sy0FEP1jOXfHGaNlyTYEH/YCvEvSL9b4R HPxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693694821; x=1694299621; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DkWTw7s2UJ8f1+WsuAJKApF3MaQNVBwJBbT87ifT4IQ=; b=GhKR3u1U5x+AVOqzN5FgMkRHsGl5uLbldToIfHEsVk4ZEgpmfybzz3jbcEJguK5sm0 5g6HVNvHWh5FB2YytyD6OfEhLnk0Wahv8bZrtnGDxRi9jQS5y25a+Dv798p7lY6EiFqA i7gpIuDqChwQvoh4epsF6vcgGgykfoZWqoQZHR7fCiSK0UJ3kQMPok5LH1uCGkTvogcl NIbkQLXmhGQ9PPHtrPS6wlEj//B9DtidX+rR4tojB55ziOabqhPRAJwiN5ohInNOcyGA DXJXxEt1vH/1GwMABVXkGYpw3KXcZYxe95hXaLo/F+tB/XXZLX/lqkjxFWbZNJgyrdlI AASw== X-Gm-Message-State: AOJu0YyNSxh8zpRiHFwidH2cyX5POJnWPREzTOzrTXvFgz+ml6TjOLxC ei7+QIYZA/CiVVbcsiqrvAY= X-Google-Smtp-Source: AGHT+IHAwWrE2ZeiTblscC683arvUH+RYo1iv3oxEDAiNIw6BZ/kTiZrkwgFXTF1bBEVdgwVx6gdZw== X-Received: by 2002:a4a:840f:0:b0:571:28d5:2c71 with SMTP id l15-20020a4a840f000000b0057128d52c71mr4416275oog.2.1693694821190; Sat, 02 Sep 2023 15:47:01 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id d83-20020a4a5256000000b00570cb3e8a6dsm3436399oob.7.2023.09.02.15.46.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Sep 2023 15:47:00 -0700 (PDT) Message-ID: <411b4bbe-9ccb-eb58-907d-48699b25c59d@gmail.com> Date: Sat, 2 Sep 2023 19:46:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65708: 30.0.50; Wrong default value for functions in filesets.el Content-Language: en-US To: Stefan Kangas , 65708@debbugs.gnu.org References: <9c42d2b1-1e89-2334-fb87-9ee10d1e05ee@gmail.com> From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 65708 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) On 2/9/23 19:42, Stefan Kangas wrote: > Mauro Aranda writes: > >> The following user options: >> filesets-browse-dir-function >> filesets-open-file-function >> filesets-save-buffer-function >> filesets-commands >> filesets-external-viewers >> >> have overridden the default value of the function widget to the value >> nil.  That's an invalid default value.  It'd be better to just remove >> that. > > Makes sense, but you forgot to attach the patch.  ;-) I was writing it but then I found some other problems with the defcustoms in filesets.el :-( I'll attach the patch trying to fix all of them (with a description of the problems, of course). From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 19:19:23 2023 Received: (at 65708) by debbugs.gnu.org; 2 Sep 2023 23:19:23 +0000 Received: from localhost ([127.0.0.1]:38885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcZti-0005hH-Cu for submit@debbugs.gnu.org; Sat, 02 Sep 2023 19:19:22 -0400 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]:49483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcZtg-0005h4-89 for 65708@debbugs.gnu.org; Sat, 02 Sep 2023 19:19:21 -0400 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6beff322a97so265841a34.3 for <65708@debbugs.gnu.org>; Sat, 02 Sep 2023 16:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693696744; x=1694301544; darn=debbugs.gnu.org; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=uWR12/cisKGqdxmTAz9+iLPZT6uywz7mK8nM/3PlMII=; b=YuSgZqyoozVfZg9Vk09z90CLZjCEVY8oh3Yb5oF6RqFSEZxqr/7Plj8gVSqf4ISSOW ByIlQ9iSLOXdvNqji0xQAZTbxLEcYxX5rOJgIDCLAbePy84U2L+BPP1ktLtWMjWw8HG9 zbeUu4svOuzMygTsluOe5vPjhlmwTyVqAt2Jr1XjiiTKb9bTsIKvBKCJBUPG9FMo2hX2 wdgSoKXYXv8InsVu4Vtkq39QAbj3YFUPoaEHedCmUbXxgRrmC+GcqxtZqZnOhAt/6p/p gCmQcnyGEy28dzkfURvNfXCDn6OAz/PDXzG9xA3b1Tnc6018fvTe8CcGcQAVW1Ewi/5K ka6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693696744; x=1694301544; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uWR12/cisKGqdxmTAz9+iLPZT6uywz7mK8nM/3PlMII=; b=Xm2jJK8kqJchQpvDjg/tLXQgkUD5lqfuiI0OT/A8UqX3OUfCDSede1Dt61jH+S0QRh uG5F74BRURmCAHcvJ+QqzLhUX6amlueNmCrfFGjd6qDCnJc3WDOP3IlQtbjp4l/xxSB1 9VRntWWaZdwvKsqs/cx4lghwAsnDfjXtbrqvT2lm3T0q0dyW9VuORR3l5040psdaoKb1 LQSwZAMbhyFUkImAc9lZAM0CetVw/+kgO/OFZ1CR5muELu985xhng064qb2F7K4uhsZc qGtR3RrZMD/nGC5Tjd5OnBljQsaMcMG/9Z1R9yHCV3l9Kbl/XBvblJkRiU2F8NL1uuSA 78xA== X-Gm-Message-State: AOJu0Yws9nB2bnbApC4QZgoteDm2qXAIgSlUC5ZBJbD3U+tlPBwOfjC5 lPetaXSWqIGGXrKR/iu+UUs= X-Google-Smtp-Source: AGHT+IEXZo5lB2wZJhuTFTszasWK+rJ+8Lr/Z1ztH2yBE285QetIUBuFNR1IZZAoI7ZN30cxrkBMgQ== X-Received: by 2002:a05:6830:1403:b0:6bd:708:c1f2 with SMTP id v3-20020a056830140300b006bd0708c1f2mr5524934otp.14.1693696744369; Sat, 02 Sep 2023 16:19:04 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id p22-20020a9d6956000000b006b8a959ac32sm3291637oto.48.2023.09.02.16.19.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Sep 2023 16:19:03 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------08YfCW9OkMvy1B8PtAWPKdm5" Message-ID: Date: Sat, 2 Sep 2023 20:19:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65708: 30.0.50; Wrong default value for functions in filesets.el Content-Language: en-US From: Mauro Aranda To: Stefan Kangas , 65708@debbugs.gnu.org References: <9c42d2b1-1e89-2334-fb87-9ee10d1e05ee@gmail.com> <411b4bbe-9ccb-eb58-907d-48699b25c59d@gmail.com> In-Reply-To: <411b4bbe-9ccb-eb58-907d-48699b25c59d@gmail.com> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 65708 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) This is a multi-part message in MIME format. --------------08YfCW9OkMvy1B8PtAWPKdm5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/9/23 19:46, Mauro Aranda wrote: > On 2/9/23 19:42, Stefan Kangas wrote: > > Mauro Aranda writes: > > > >> The following user options: > >> filesets-browse-dir-function > >> filesets-open-file-function > >> filesets-save-buffer-function > >> filesets-commands > >> filesets-external-viewers > >> > >> have overridden the default value of the function widget to the value > >> nil. That's an invalid default value. It'd be better to just remove > >> that. > > > > Makes sense, but you forgot to attach the patch. ;-) > > I was writing it but then I found some other problems with the > defcustoms in filesets.el :-( > > I'll attach the patch trying to fix all of them (with a description of > the problems, of course). OK, I found a couple of bugs. To reproduce, with emacs -Q (require 'filesets) M-x customize-option RET filesets-commands Move to the last INS button, the one that inserts a brand new command. Hit RET: INS DEL Definition: String: Command: Value Menu invalid (nil) Argument List: INS invalid (nil) indicates a bad default value for the choice widget. I fixed that. M-x customize-option RET filesets-external-viewers Move to the INS button that inserts a Property for the last Definition. Hit RET INS DEL Definition: Pattern: .\.\(tiff\|xpm\|gif\|pgn\)\' Viewer: Value Menu Program: gqview Properties: INS DEL Choice: Value Menu :ignore-on-open-all: Boolean: Toggle on (non-nil) INS DEL Choice: Value Menu :ignore-on-read-text: Boolean: Toggle on (non-nil) INS DEL Choice: Value Menu invalid ((:constraintp)) INS invalid ((:constraintp)) indicates another bad default value. I fixed that, and other default values for the list widgets in this option. One thing I observed is that there are lot of redundant tags in this file, like (function :tag "Function"). But anyway, those aren't bugs, so I didn't bothered. I attach a patch for the emacs-29 branch. --------------08YfCW9OkMvy1B8PtAWPKdm5 Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-defcustoms-in-filesets.el-Bug-65708.patch" Content-Disposition: attachment; filename="0001-Fix-defcustoms-in-filesets.el-Bug-65708.patch" Content-Transfer-Encoding: base64 RnJvbSBmMmEyZDRmMTdjMWU3ZTkzYzhmYzM5MDA0Y2I0YjAyNDZkYWU1ZTc0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFNhdCwgMiBTZXAgMjAyMyAyMDoxNjozMCAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIEZpeCBkZWZjdXN0b21zIGluIGZpbGVzZXRzLmVsIChCdWcjNjU3MDgpCgoqIGxp c3AvZmlsZXNldHMuZWwgKGZpbGVzZXRzLWJyb3dzZS1kaXItZnVuY3Rpb24pCihmaWxlc2V0 cy1vcGVuLWZpbGUtZnVuY3Rpb24gZmlsZXNldHMtc2F2ZS1idWZmZXItZnVuY3Rpb24pCihm aWxlc2V0cy1jb21tYW5kcyBmaWxlc2V0cy1leHRlcm5hbC12aWV3ZXJzKTogRG9uJ3Qgb3Zl cnJpZGUgZGVmYXVsdAp2YWx1ZSBmb3IgdGhlIGZ1bmN0aW9uIHdpZGdldCB3aXRoIGFuIGlu dmFsaWQgZGVmYXVsdCB2YWx1ZS4KUmVtb3ZlIHJlZHVuZGFudCAiOiIgaW4gdGFnLgpGaXgg ZGVmYXVsdCB2YWx1ZXMgZm9yIGNob2ljZSBhbmQgbGlzdCB3aWRnZXRzLgotLS0KIGxpc3Av ZmlsZXNldHMuZWwgfCAzMSArKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvbGlzcC9maWxlc2V0cy5lbCBiL2xpc3AvZmlsZXNldHMuZWwKaW5kZXggMWI3ZTZm ZmE4MWYuLmMwZmYxYTNiNmE5IDEwMDY0NAotLS0gYS9saXNwL2ZpbGVzZXRzLmVsCisrKyBi L2xpc3AvZmlsZXNldHMuZWwKQEAgLTQxMywxNSArNDEzLDE0IEBAIGZpbGVzZXRzLWJyb3dz ZS1kaXItZnVuY3Rpb24KIAogTm90ZTogWW91IGhhdmUgdG8gbWFudWFsbHkgcmVidWlsZCB0 aGUgbWVudSBpZiB5b3UgY2hhbmdlIHRoaXMgdmFsdWUuIgogICA6c2V0ICMnZmlsZXNldHMt c2V0LWRlZmF1bHQKLSAgOnR5cGUgJyhjaG9pY2UgOnRhZyAiRnVuY3Rpb246IgorICA6dHlw ZSAnKGNob2ljZSA6dGFnICJGdW5jdGlvbiIKIAkJIChjb25zdCA6dGFnICJkaXJlZCIKIAkJ CTp2YWx1ZSBkaXJlZCkKIAkJIChsaXN0IDp0YWcgIkNvbW1hbmQiCiAJCSAgICAgICA6dmFs dWUgKCIiICIlcyIpCiAJCSAgICAgICAoc3RyaW5nIDp0YWcgIk5hbWUiKQogCQkgICAgICAg KHN0cmluZyA6dGFnICJBcmd1bWVudHMiKSkKLQkJIChmdW5jdGlvbiA6dGFnICJGdW5jdGlv biIKLQkJCSAgIDp2YWx1ZSBuaWwpKSkKKyAgICAgICAgICAgICAgICAgKGZ1bmN0aW9uIDp0 YWcgIkZ1bmN0aW9uIikpKQogCiAoZGVmY3VzdG9tIGZpbGVzZXRzLW9wZW4tZmlsZS1mdW5j dGlvbiAjJ2ZpbGVzZXRzLWZpbmQtb3ItZGlzcGxheS1maWxlCiAgICJUaGUgZnVuY3Rpb24g dXNlZCBmb3Igb3BlbmluZyBmaWxlcy4KQEAgLTQzNywyMyArNDM2LDIxIEBAIGZpbGVzZXRz LW9wZW4tZmlsZS1mdW5jdGlvbgogCiBDYXZlYXQ6IENoYW5nZXMgd2lsbCB0YWtlIGVmZmVj dCBvbmx5IGFmdGVyIHJlYnVpbGRpbmcgdGhlIG1lbnUuIgogICA6c2V0ICMnZmlsZXNldHMt c2V0LWRlZmF1bHQKLSAgOnR5cGUgJyhjaG9pY2UgOnRhZyAiRnVuY3Rpb246IgorICA6dHlw ZSAnKGNob2ljZSA6dGFnICJGdW5jdGlvbiIKIAkJIChjb25zdCA6dGFnICJmaWxlc2V0cy1m aW5kLW9yLWRpc3BsYXktZmlsZSIKIAkJCTp2YWx1ZSBmaWxlc2V0cy1maW5kLW9yLWRpc3Bs YXktZmlsZSkKIAkJIChjb25zdCA6dGFnICJmaWxlc2V0cy1maW5kLWZpbGUiCiAJCQk6dmFs dWUgZmlsZXNldHMtZmluZC1maWxlKQotCQkgKGZ1bmN0aW9uIDp0YWcgIkZ1bmN0aW9uIgot CQkJICAgOnZhbHVlIG5pbCkpKQorICAgICAgICAgICAgICAgICAoZnVuY3Rpb24gOnRhZyAi RnVuY3Rpb24iKSkpCiAKIChkZWZjdXN0b20gZmlsZXNldHMtc2F2ZS1idWZmZXItZnVuY3Rp b24gIydzYXZlLWJ1ZmZlcgogICAiVGhlIGZ1bmN0aW9uIHVzZWQgdG8gc2F2ZSBhIGJ1ZmZl ci4KIENhdmVhdDogQ2hhbmdlcyB3aWxsIHRha2UgZWZmZWN0IGFmdGVyIHJlYnVpbGRpbmcg dGhlIG1lbnUuIgogICA6c2V0ICMnZmlsZXNldHMtc2V0LWRlZmF1bHQKLSAgOnR5cGUgJyhj aG9pY2UgOnRhZyAiRnVuY3Rpb246IgorICA6dHlwZSAnKGNob2ljZSA6dGFnICJGdW5jdGlv biIKIAkJIChjb25zdCA6dGFnICJzYXZlLWJ1ZmZlciIKIAkJCTp2YWx1ZSBzYXZlLWJ1ZmZl cikKLQkJIChmdW5jdGlvbiA6dGFnICJGdW5jdGlvbiIKLQkJCSAgIDp2YWx1ZSBuaWwpKSkK KyAgICAgICAgICAgICAgICAgKGZ1bmN0aW9uIDp0YWcgIkZ1bmN0aW9uIikpKQogCiAoZGVm Y3VzdG9tIGZpbGVzZXRzLWZpbmQtZmlsZS1kZWxheQogICAoaWYgKGFuZCAoZmVhdHVyZXAg J3hlbWFjcykgZ3V0dGVyLWJ1ZmZlcnMtdGFiLXZpc2libGUtcCkKQEAgLTUzNSw3ICs1MzIs NyBAQCBmaWxlc2V0cy1jb21tYW5kcwogICA6dHlwZSAnKHJlcGVhdCA6dGFnICJDb21tYW5k cyIKIAkJIChsaXN0IDp0YWcgIkRlZmluaXRpb24iIDp2YWx1ZSAoIiIpCiAJCSAgICAgICAo c3RyaW5nICJOYW1lIikKLQkJICAgICAgIChjaG9pY2UgOnRhZyAiQ29tbWFuZCIKKyAgICAg ICAgICAgICAgICAgICAgICAgKGNob2ljZSA6dGFnICJDb21tYW5kIiA6dmFsdWUgIiIKIAkJ CSAgICAgICAoc3RyaW5nIDp0YWcgIlN0cmluZyIpCiAJCQkgICAgICAgKGZ1bmN0aW9uIDp0 YWcgIkZ1bmN0aW9uIikpCiAJCSAgICAgICAocmVwZWF0IDp0YWcgIkFyZ3VtZW50IExpc3Qi CkBAIC01NDYsOCArNTQzLDcgQEAgZmlsZXNldHMtY29tbWFuZHMKIAkJCQkJICAgICAgIDp2 YWx1ZSAiPGZpbGUtbmFtZT4iKQogCQkJCSAgICAgICAoc3RyaW5nIDp0YWcgIlF1b3RlZCBG aWxlIE5hbWUiCiAJCQkJCSAgICAgICA6dmFsdWUgIjw8ZmlsZS1uYW1lPj4iKQotCQkJCSAg ICAgICAoZnVuY3Rpb24gOnRhZyAiRnVuY3Rpb24iCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgOnZhbHVlIG5pbCkpKSkpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZ1bmN0aW9uIDp0YWcgIkZ1bmN0aW9u IikpKSkpKQogCiAoZGVmY3VzdG9tIGZpbGVzZXRzLWV4dGVybmFsLXZpZXdlcnMKICAgKGxl dApAQCAtNjQ3LDEyICs2NDMsMTIgQEAgZmlsZXNldHMtZXh0ZXJuYWwtdmlld2VycwogCQkg ICAgICAgKHJlcGVhdCA6dGFnICJQcm9wZXJ0aWVzIgogCQkJICAgICAgIChjaG9pY2UKIAkJ CQkobGlzdCA6dGFnICI6Y29uc3RyYWludHAiCi0JCQkJICAgICAgOnZhbHVlICg6Y29uc3Ry YWludHApCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDp2YWx1ZSAo OmNvbnN0cmFpbnRwIGlnbm9yZSkKIAkJCQkgICAgICAoY29uc3QgOmZvcm1hdCAiIgogCQkJ CQkgICAgIDp2YWx1ZSA6Y29uc3RyYWludHApCiAJCQkJICAgICAgKGZ1bmN0aW9uIDp0YWcg IkZ1bmN0aW9uIikpCiAJCQkJKGxpc3QgOnRhZyAiOmNvbnN0cmFpbnQtZmxhZyAob2Jzb2xl dGUpIgotCQkJCSAgICAgIDp2YWx1ZSAoOmNvbnN0cmFpbnQtZmxhZykKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgOnZhbHVlICg6Y29uc3RyYWludC1mbGFnIG5p bCkKIAkJCQkgICAgICAoY29uc3QgOmZvcm1hdCAiIgogCQkJCQkgICAgIDp2YWx1ZSA6Y29u c3RyYWludC1mbGFnKQogCQkJCSAgICAgIChzZXhwIDp0YWcgIlN5bWJvbCIpKQpAQCAtNjY3 LDcgKzY2Myw3IEBAIGZpbGVzZXRzLWV4dGVybmFsLXZpZXdlcnMKIAkJCQkJICAgICAgOnZh bHVlIDppZ25vcmUtb24tcmVhZC10ZXh0KQogCQkJCSAgICAgIChib29sZWFuIDp0YWcgIkJv b2xlYW4iKSkKIAkJCQkobGlzdCA6dGFnICI6YXJncyIKLQkJCQkgICAgICA6dmFsdWUgKDph cmdzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6dmFsdWUgKDph cmdzIG5pbCkKIAkJCQkgICAgICAoY29uc3QgOmZvcm1hdCAiIgogCQkJCQkgICAgIDp2YWx1 ZSA6YXJncykKIAkJCQkgICAgICAocmVwZWF0IDp0YWcgIkxpc3QiCkBAIC02NzYsMTAgKzY3 Miw5IEBAIGZpbGVzZXRzLWV4dGVybmFsLXZpZXdlcnMKIAkJCQkJCQkgICAgICA6dmFsdWUg IiIpCiAJCQkJCQkgICAgICAoc3ltYm9sIDp0YWcgIlN5bWJvbCIKIAkJCQkJCQkgICAgICA6 dmFsdWUgbmlsKQotCQkJCQkJICAgICAgKGZ1bmN0aW9uIDp0YWcgIkZ1bmN0aW9uIgotCQkJ CQkJCQk6dmFsdWUgbmlsKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGZ1bmN0aW9uIDp0YWcgIkZ1bmN0aW9uIikpKSkKIAkJ CQkobGlzdCA6dGFnICI6b3Blbi1ob29rIgotCQkJCSAgICAgIDp2YWx1ZSAoOm9wZW4taG9v aykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnZhbHVlICg6b3Bl bi1ob29rIG5pbCkKIAkJCQkgICAgICAoY29uc3QgOmZvcm1hdCAiIgogCQkJCQkgICAgIDp2 YWx1ZSA6b3Blbi1ob29rKQogCQkJCSAgICAgIChob29rIDp0YWcgIkhvb2siKSkKLS0gCjIu MzQuMQoK --------------08YfCW9OkMvy1B8PtAWPKdm5-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 07:00:04 2023 Received: (at 65708-done) by debbugs.gnu.org; 3 Sep 2023 11:00:04 +0000 Received: from localhost ([127.0.0.1]:39749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qckpn-0003qo-Lu for submit@debbugs.gnu.org; Sun, 03 Sep 2023 07:00:04 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:42149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qckpl-0003o7-3K for 65708-done@debbugs.gnu.org; Sun, 03 Sep 2023 07:00:01 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-500760b296aso641404e87.0 for <65708-done@debbugs.gnu.org>; Sun, 03 Sep 2023 03:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693738785; x=1694343585; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=gTFU7msYscQdtJs9fO7DY6jYYbMc9pr0mBUq3BTyn70=; b=rV6NDE3/tBBys58JAovtYU723Tjk5cm7/w07osd5tKHOb2aI8g4S8JpUVcg7UnP7mp 3KPz5Gbhx7qAMj3pOWWTH/yN1e7n+oR2cie7p5mmN7ZoxsyoCsqMI4zSU3cYjON7P9Ri Xli2FePDb1uDHkK25FJy4FOd3zk17Btk9gBcpHwrvqm1UyxZo3TRo31eSTlf1qm/sF8K 8/nZ7SW7WiNiMqPiaCjNXZ9//tBTaQxbzGaHkhw6rPfQDfI27rhwDYOxjpC3eHV2K50y sFrAZLVVMDb4/5mCZ1C4+BAeiMqCHeZOBx9PMtvnX7TMTKkwhH8W3CN9oQGpInx/OD9z yHBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693738785; x=1694343585; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gTFU7msYscQdtJs9fO7DY6jYYbMc9pr0mBUq3BTyn70=; b=lgbdpvx3TqRtFhQ2Fh4/cpsEU26WNmCFzOibkvU99syA4PcUWcFyid+gBfTqdNX4G+ evRYfjtRo6R6t7NQpFkOgFhBtDzDeQVfeEH2218G7kh+d9odVBrGKeDPbf2wVBjhalcQ OGO4RARfsdqHgsyDITXb5t9DJkiwuLYTFiiau4CWlC3rSNUxaQGE6186EnZMOBuX+3x7 CwgAMvYSA7pzJcHis6hgKSEh4hSA04ubJXk2SpKe42s7uYEdLatUfGBeHUBacqa5CNQV IHS6orA/LJbGDSUylu69F58kzZDQiWIbgqwwy72Z+e2khyrEDtkkbO9cNRfs7Z8oWplK 6KSA== X-Gm-Message-State: AOJu0YzB3vx3Mfz2vrYoyysrYzd3iUgJT3CemN7ITN2LBFqHuKEdTJuY nTp3/wtQACZ+rtPU07dN88WZkySsavU2hWpo8TY= X-Google-Smtp-Source: AGHT+IGPvqyU60j3zStwEghhhr+NPFiQy/zRo7jFekFMEYHF3D7/o5fcVi3kLV7bGVbUXyF9qjVqTykRGGPzhsC3Qxw= X-Received: by 2002:a05:6512:3988:b0:500:af82:7ddc with SMTP id j8-20020a056512398800b00500af827ddcmr3008578lfu.28.1693738784773; Sun, 03 Sep 2023 03:59:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 03:59:44 -0700 From: Stefan Kangas In-Reply-To: (Mauro Aranda's message of "Sat, 2 Sep 2023 20:19:01 -0300") References: <9c42d2b1-1e89-2334-fb87-9ee10d1e05ee@gmail.com> <411b4bbe-9ccb-eb58-907d-48699b25c59d@gmail.com> MIME-Version: 1.0 Date: Sun, 3 Sep 2023 03:59:44 -0700 Message-ID: Subject: Re: bug#65708: 30.0.50; Wrong default value for functions in filesets.el To: Mauro Aranda Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65708-done Cc: 65708-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Mauro Aranda writes: > One thing I observed is that there are lot of redundant tags in this > file, like (function :tag "Function"). But anyway, those aren't bugs, > so I didn't bothered. I attach a patch for the emacs-29 branch. Thanks, installed on master. I didn't put it on the release branch, as these are not really regressions, and have been there for a long time. From unknown Wed Jun 18 23:04:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 01 Oct 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator