GNU bug report logs - #65704
29.1; Most code of `project-ignores' seems to be dead code

Previous Next

Full log

View this message in rfc822 format

From: Damien Cassou <damien <at> cassou.me>
To: Dmitry Gutov <dmitry <at> gutov.dev>, 65704 <at> debbugs.gnu.org
Subject: bug#65704: 29.1; Most code of `project-ignores' seems to be dead code
Date: Wed, 06 Sep 2023 21:12:59 +0200

Dmitry Gutov <dmitry <at> gutov.dev> writes:
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index 29a81c7e151..2eea0ef72e0 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -566,6 +566,12 @@ project-try-vc
>                  (project--submodule-p root))
>             (let* ((parent (file-name-directory (directory-file-name 
> root))))
>               (setq root (vc-call-backend 'Git 'root parent))))
> +        (when (not backend)

it seems that `root' is sometimes nil at this point so I would change
this line to

  (when (and (not backend) root)

I've used this for the day and it seems to work fine.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.