From unknown Mon Jul 21 02:26:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65700 <65700@debbugs.gnu.org> To: bug#65700 <65700@debbugs.gnu.org> Subject: Status: time when gcs-done is updated needs to be clarified Reply-To: bug#65700 <65700@debbugs.gnu.org> Date: Mon, 21 Jul 2025 09:26:27 +0000 retitle 65700 time when gcs-done is updated needs to be clarified reassign 65700 emacs submitter 65700 Shynur Xie severity 65700 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 09:02:18 2023 Received: (at submit) by debbugs.gnu.org; 2 Sep 2023 13:02:18 +0000 Received: from localhost ([127.0.0.1]:35423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcQGW-0006lb-9K for submit@debbugs.gnu.org; Sat, 02 Sep 2023 09:02:18 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcQGQ-0006ku-7j for submit@debbugs.gnu.org; Sat, 02 Sep 2023 09:02:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcQFS-00023H-Fr for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 09:01:14 -0400 Received: from mail-co1nam11olkn2011.outbound.protection.outlook.com ([40.92.18.11] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcQFO-0002FD-65 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 09:01:10 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oK1BBLUAF2w43ZGtBzvcwNPZ1Umw65AUWGFwzJkThrbuqV0B4Um80zKkeTts/sfYhSeoGTtSHAipKeEXOirJ/qpI4DYBar1cm7w2CAFEvT5Tv2b/Iq32qcciYjlQZJ3MavNfwXl1+7KBnd3KkCd4U+rn9nKpfmkPBZk6kGoctQ/B56h7fFkYuRA5VYgi+/nofFk1Id7NCo5YD+hn8oISlCgofpV1pUgHjnxAQK34sCxSyPeGv5lw3RgwTMtTI80UlVYpM6pvpqoNVKYf0XQm3ACODkAxQjmhWb0PJrjlHMmcTrmu3/gI8zdDV8Sla0mX6IVPkuPWLKsGZy1c1raEeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TXnPjnhy3juRMkRJTZ7MIqN0yo9jsJN8/koI/vvAQ1c=; b=nnt+h9h+kjZ0RWxTVaxcHMywLpeDx+eeS4367DammMg1lw/MO+utmEt6bsjvl6G7bA+JUNynFajfCm+GudPzgW1Tb7esJQs8fG+9dBNCtaE4KjEMW4T3teEOFf+dEQQKOiJzK6hMu1h1MRH0LQhDodMP2qx8D9X+H0Ypta5mI2ORgMKtwntvmVtPVl0ziEIh70l/lSZQZ2PMAnh4Rcx9BB4W+cwEiOtOsvkt0U5Fc2NM9ifi6CFPZHG4F0FTmU3e5MmLqwNcdG7TGeawDcYLa2cmgaJLU6pP7Ym/NrHT1oq975+wAUU2cb/NErStWAXLA/HNMclgUHkL8nLMAdQvEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TXnPjnhy3juRMkRJTZ7MIqN0yo9jsJN8/koI/vvAQ1c=; b=o5oIapvPNMxqh6/8Z6iZ83e/WGlokf7eAl2sOL8zwE7Z76BUry7qpStFaSpg8AcX1OxiTIEB3ObMM8L31AEg/R4ujtpF5FlfXFbehClfmubCy9+KhZ41sjr7zapJMfgoymj+neUM3gwdyqOV4ZmXzT3iTBpNVALus7iNkgDpldY+tJV+h6uIkzECZ5Ffij0Bjg4vWnp/EfW0bsZXRENRUelpxcFlvwWASnAsr0Li013FlKPGSCxBu8rK5Nxsxbol+0UoXuZ0m3DwhOsIrVhRHfnzkyo8rf7vNDf43bAucKUQwseEP7RFzcQyLv0/GzsXJYcrxxkj4SnmefvxbwalIA== Received: from PH0PR11MB7470.namprd11.prod.outlook.com (2603:10b6:510:288::7) by SJ1PR11MB6249.namprd11.prod.outlook.com (2603:10b6:a03:45a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.28; Sat, 2 Sep 2023 13:01:01 +0000 Received: from PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983]) by PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983%5]) with mapi id 15.20.6745.028; Sat, 2 Sep 2023 13:00:59 +0000 From: Shynur Xie To: "bug-gnu-emacs@gnu.org" Subject: time when gcs-done is updated needs to be clarified Thread-Topic: time when gcs-done is updated needs to be clarified Thread-Index: AQHZ3Z0HPeRk2UPAv0C1corkC0IZQg== Date: Sat, 2 Sep 2023 13:00:59 +0000 Message-ID: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [JHJjmzS7S3NQ3j4xhLsOFtGqncSp5X+O] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB7470:EE_|SJ1PR11MB6249:EE_ x-ms-office365-filtering-correlation-id: 8059d537-4c81-415b-69a9-08dbabb4a7a4 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HH359bie90rUIunudEVCThcLKRHdW696JFNeojCm9J4gcTBeh/Kf0uocaW01kx2l08wNbkAqWlXXz2DGjFValia0iD3V7DR25R50xh0XCw9/W/+Wt20fkG5erqfzWfj21HPXEumpYOWLohd0XgTUPw2iCE+KjEoZIgD4tyF4yOUcH9ew/4N+sWXtkCfT9x2qgw6FWMHhg5ePb/2xKFQPzTwsVMSbJlrXBlGHfmjWrNIZegguqtvyihzXqA9IRtgnHw5F8Bd59xlJMmWy2Mih5Yk9YTyqX++R/rYi/1ZRlIBwXTTbcKcb+ufqRfalJtX9vp83/bwRqlE/t741uJNq+mQt01t1P7e2YbUFFDu53flDNBffdgLcadGl+WjJ/8KydTOa1fv++2JlwV3EyUL5sldk/tSV+I8dgmWp2+0jfZPvL6DhkWePxKJzueWkRhUbtivgNKpcBsmUOP0cYYeRUAnwYCvjSqFPw2r87Hv8cSi/XpWR9AHPWBH6dyBM2UTlTLDwuSMRKtoeKTp57gkqjwR4LT0BbZcDWexBynvrGyQHtW/iEkgeQ/emE/hnQ1XU x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?nvDY8ESNdM+2wPwSnW91oLDMa4Exys/4qDCWK7eiOido8/nFl0KEJzVogK?= =?iso-8859-1?Q?9jr1FEDLGyXepCGl9WueJ8yMDLkUt+CILKzjrYnTRTecwQ0W5gQeBCGFwW?= =?iso-8859-1?Q?qVNYU97XY7e7EWp0NkEurFWyooT7sumWfsQzfMEu0n5xvU0bSWuZvirLXf?= =?iso-8859-1?Q?BfUgDBv1p83VRFArZRAWbsTqKZiBSNKaQjzyEMxcjkU9pfKiDeP+3ez+l2?= =?iso-8859-1?Q?/tdf7O8+jxiwbNIwHHvSNmvxluXo7dqp3GwUscXHugsmCsI0n8rigY3y6Q?= =?iso-8859-1?Q?cnNnPoD96qA1zzsFwtm0YfNNAHIETvDyvNvnvtm4FzXIvdH0RC94zrf4/M?= =?iso-8859-1?Q?0skcwk8bMp/2pHaZQH+N0An+jPUPKIspj61+EkoA3EpQiDZVrIThTkBPTC?= =?iso-8859-1?Q?/xStOcNbnPVLQ5nEDX9yVodFBVTVbilTKMDUigCgWYNatEmpfZks2m4wfk?= =?iso-8859-1?Q?hOfSUXotAqKymcmDGF1ESArvdztr5yOiJH0jK33UZPhOXqoQmPCk7V9idX?= =?iso-8859-1?Q?wFmbR/Cdza/ICXOsAapEo8mxR3Bh3M/PWEG2o6PxzInCk9cCFhuAFSu85H?= =?iso-8859-1?Q?vnxJ9EU2n5N5rtI92cMNaYr2u3ddhpQ3Ii9gnO+lwT5dhIYMJFBzuGRJTh?= =?iso-8859-1?Q?479HhbK9Tmwnn6uLTZwQy+CSTfcmndX5syg+zqQESJM9LG7+rTP0H+NsyS?= =?iso-8859-1?Q?FY2iE0M0WUNvS8Q0iMYtNGNapKhOByC6xWGQ7JfKjjUEitdcn5NWDTlDuS?= =?iso-8859-1?Q?hRUqifw6/R2/x0DiW0saxw54hvfPAl8zr8hVbKD0018EhaaB524hii5/cf?= =?iso-8859-1?Q?lqkrG1R2kr3eGytXd2VhFYB0J9/MgizJhgH6OvtVaAl4AL52M/ZzO4qOuc?= =?iso-8859-1?Q?z1qU4pfjMvUL4IxdO5ElKZKrknsPVB5HCKZYqz2s4fsoLMVqurLaiUk6Op?= =?iso-8859-1?Q?YuJgoMbrpZd/TDF/lLS2N4d4Q54uktSBsuVYoEcQk22hiPBLEeaZW5J+oA?= =?iso-8859-1?Q?aocAR93gnBk4EJh/eEYjBC5A2n7ZIlrmBf9a5tlf5P+InAKgmYSf07uRcT?= =?iso-8859-1?Q?DFlPTic+cdNqVWUicGNkWjlWLZ0a2CcSZHckhzcibvsjPPBlsSsRn676CP?= =?iso-8859-1?Q?g5sDjk7XuOkSFJQDk8aM/eJo+7Ao0Nxz/nsSWSVZltfzXc1Eg/tRiee7Ml?= =?iso-8859-1?Q?EeaZ9gLwt12QbdKy8EBdW1O1RUGuhe/T8L7HD/LtIGQNdQKJwz1XK7jR?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7470.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8059d537-4c81-415b-69a9-08dbabb4a7a4 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2023 13:00:59.7968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6249 Received-SPF: pass client-ip=40.92.18.11; envelope-from=one.last.kiss@outlook.com; helo=NAM11-CO1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I wrote a function which runs each time Emacs collects garbage, so I=0A= added it to `post-gc-hook'.=0A= =0A= That function cares about the value of `gcs-done' and the value of=0A= `gc-elapsed'.=0A= But it seems that `gcs-done' is updated after `post-gc-hook' is=0A= executed?=0A= =0A= Is this an intended behavior? If so, I think the docstring of these=0A= variables (such as `gcs-done', `gc-elapsed', ...) need to clarify when=0A= the variable is updated.=0A= =0A= =0A= v29.1= From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 07:01:17 2023 Received: (at control) by debbugs.gnu.org; 3 Sep 2023 11:01:17 +0000 Received: from localhost ([127.0.0.1]:39761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qckqz-0006WZ-Ix for submit@debbugs.gnu.org; Sun, 03 Sep 2023 07:01:17 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:51296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qckqx-0006WK-OL for control@debbugs.gnu.org; Sun, 03 Sep 2023 07:01:16 -0400 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-5008d16cc36so928330e87.2 for ; Sun, 03 Sep 2023 04:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693738859; x=1694343659; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=FRfFn0cW9BtpehyWXd96jM6it7p8S4JRo5dN8fUQeB8=; b=iGLsFWcEONZq/EhDBS9klus44w7POMheTGlLemTwQjuUgCUwNTEYdgI/vs9lughr5k rJFdxxFlFrfSx33L5r0bb4hQwGcyJ2OcGG2tqQxKeu0isnArz6qWieKXe1QE0/rcLmZs qfwir3MXJHPf0xziUogjOg439TtD1EUVaptlmYoAFQ/kSRo647cRsC4KbEVziBnjVqQH /HM+NxOvSnjiP1wfwlnJv62TmfOpEgJxDHf2XlZq+iEJRfEzHcyB1y2ZQD9NC96S0M3i Sng6AF5eJ/aaw7H4niou1c6Uviq/TF6iLkUm3rnb9X98rvdQxyKAMXwT2lia13pLBP2B JaYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693738859; x=1694343659; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FRfFn0cW9BtpehyWXd96jM6it7p8S4JRo5dN8fUQeB8=; b=EL39RN53CEcrJ5iId4Pgb2z2ut7weEkbztx23o+Qh7uAab9M/vekv1NVANb+f6k2XO QQBaNeguc9MlD/ItoLWJJaf1ZEMY9Dod3R7uoeHH2wl0j/S7Yvu7flhD9nlwrdhL098X 8SIlNSqiArs5cM5WLK5Rv26NaM+VanVXFOAox9vyw77Iu4nVDKYwjQ6z9zbINN1OKeoc xq3PpeDXvJGrngWBFOgxGViBiThvVnB30fR862ct3CS8pAxtkn5V1JypI7ouwK3iAiTg 3dNCmhu0igw5ZJod4PXEsHWeBBNq0WFnSofTw2U9s8U2t5BNmg37PyPxZeoP/3lOkd68 9vtg== X-Gm-Message-State: AOJu0YypX3JEBhizdfAdDbgjt87ObxDcqhKfdZJDnJKGYgK5jmIBtga3 Mv/ex04ZdeK9cbuYH8z8bBX/G+d+rHoD0ADKhj2BR0vspSc= X-Google-Smtp-Source: AGHT+IGGJBtP8kFWEceaCjHikMXH9zAFFai6e1P/ie3UFnLaZdTYI9HlvUIKv/UkUlGSfoeZK5xdH59WWGafnpdYPKQ= X-Received: by 2002:a05:6512:3990:b0:500:9734:b415 with SMTP id j16-20020a056512399000b005009734b415mr5242897lfu.30.1693738859421; Sun, 03 Sep 2023 04:00:59 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 04:00:59 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 3 Sep 2023 04:00:59 -0700 Message-ID: Subject: control message for bug #65700 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 65700 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 05:15:10 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 09:15:10 +0000 Received: from localhost ([127.0.0.1]:38578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeB6P-0003Wt-Kj for submit@debbugs.gnu.org; Thu, 07 Sep 2023 05:15:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeB6N-0003W3-Fb for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 05:15:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeB6G-0003lh-Gf; Thu, 07 Sep 2023 05:14:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0PlYcWN4bdw6NCWJnwgf+ljmO2jWJA/smxrsKWFod6s=; b=jG4gNJNymyaX WPKnPuv+9naLbAdP11H0RL1SnYBxRnJheCo+S81MeS8x5s6ex7xdZ/r5egJXhcYvZlSPkCsWmtBBb 4u7KXunYeFf35DaNrLk1GSNE5od98JRZq0LuiOdIT3Znjuyhb2JTM6fpe+B94KkwL+cxTqF4Q2uTX 0n3f6g9FEgYdKxH0A9Lin/TTBLIyJEKOiop+AsrIQO4lJapjOnKHsaeINk+o5micue1czRmJQJDmD oAyCYgicfW/zTm4etGHS0C4tPdK2WabO7Abaix+wI5fa8ZxK3gHRPixqf7xpARyxXPQ0z3NIQlK25 bj5/jVFN8oBvwQAIRXAB9A==; Date: Thu, 07 Sep 2023 12:14:44 +0300 Message-Id: <83pm2uz6nv.fsf@gnu.org> From: Eli Zaretskii To: Shynur Xie , Stefan Monnier In-Reply-To: (message from Shynur Xie on Sat, 2 Sep 2023 13:00:59 +0000) Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65700 Cc: 65700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Shynur Xie > Date: Sat, 2 Sep 2023 13:00:59 +0000 > msip_labels: > > I wrote a function which runs each time Emacs collects garbage, so I > added it to `post-gc-hook'. > > That function cares about the value of `gcs-done' and the value of > `gc-elapsed'. > But it seems that `gcs-done' is updated after `post-gc-hook' is > executed? > > Is this an intended behavior? If so, I think the docstring of these > variables (such as `gcs-done', `gc-elapsed', ...) need to clarify when > the variable is updated. Stefan, any comments? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 09:38:51 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 13:38:51 +0000 Received: from localhost ([127.0.0.1]:38894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeFDe-0007G1-La for submit@debbugs.gnu.org; Thu, 07 Sep 2023 09:38:50 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeFDZ-0007Fg-6a for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 09:38:48 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 73FB910006B; Thu, 7 Sep 2023 09:38:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694093916; bh=xVIjIHvDsjomD3TTEGM3/Lgne3vhoQXJ9mVjudAu7IM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ObAL0S5pv5Uxmnvt9svj+nByGIVmLIxmLtHga2rWGVG/NnYLwKMFRb1ONpg64tYiN FDmzxPmI9B22lKdcJqnoXkQ6ru6Oj1dayLc2VU26687xPx6KlG/DQksCDZa9aHB8y6 kBhymOUDrOt3wBZ9xJRtMI1E+rUXZ48VoQ8SmOtYNi5UojFkQ8dCKEJ0pp4nU4iWF4 xCovNIaaEctcLyyzFYlak+Gmk5VI7M3BsVT8eib/4EEZ5QtM5iN/3eNrHjW0+R40jU z0x3MOH+N1hgvo+aPiNeWTqssLcBO8Zh8EXnfibRJh5r97kHtVcBo5M1Ex/foLnjRh Pv+08THe7EIsA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 768C0100046; Thu, 7 Sep 2023 09:38:36 -0400 (EDT) Received: from pastel (69-165-136-223.dsl.teksavvy.com [69.165.136.223]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2D3C212030B; Thu, 7 Sep 2023 09:38:36 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified In-Reply-To: <83pm2uz6nv.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Sep 2023 12:14:44 +0300") Message-ID: References: <83pm2uz6nv.fsf@gnu.org> Date: Thu, 07 Sep 2023 09:38:35 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65700 Cc: Shynur Xie , 65700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I wrote a function which runs each time Emacs collects garbage, so I >> added it to `post-gc-hook'. >> >> That function cares about the value of `gcs-done' and the value of >> `gc-elapsed'. But it seems that `gcs-done' is updated after >> `post-gc-hook' is executed? Indeed, from what I see in the code, `gc-elapsed` and `gcs-done` are updated *after* running `post-gc-hook`. This means for example that the time to run `post-gc-hook` is included in the `gc-elapsed` time. >> Is this an intended behavior? Good question. AFAICT this was added by the following commit: commit 2c5bd60800ce4f2702f263eda2145be342208ffe Author: Dave Love Date: Thu Jan 30 14:15:58 2003 +0000 (Vgc_elapsed, gcs_done): New variables. (Fgarbage_collect): Use them. (init_alloc, syms_of_alloc): Set them up. diff --git a/src/alloc.c b/src/alloc.c --- a/src/alloc.c +++ b/src/alloc.c @@ -4367,7 +4373,15 @@ if (!NILP (Vpost_gc_hook)) { int count = inhibit_garbage_collection (); safe_run_hooks (Qpost_gc_hook); unbind_to (count, Qnil); } - + + /* Accumulate statistics. */ + EMACS_GET_TIME (t2); + EMACS_SUB_TIME (t3, t2, t1); + if (FLOATP (Vgc_elapsed)) + XSETFLOAT (Vgc_elapsed, make_float (XFLOAT_DATA (Vgc_elapsed) + + EMACS_SECS (t3) + + EMACS_USECS (t3) * 1.0e-6)); + gcs_done++; The only related commit I see around that time is the associated NEWS message: ** New variables `gc-elapsed' and `gcs-done' provide extra information on garbage collection. So I strongly suspect that it was largely accidental. "Philosophically", both choices make sense (either consider `post-gc-hook` as being part of the GC or consider it as external to the GC). I'd be curious to know how it affects your code. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 10:35:47 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 14:35:47 +0000 Received: from localhost ([127.0.0.1]:40856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeG6l-0000nk-4s for submit@debbugs.gnu.org; Thu, 07 Sep 2023 10:35:47 -0400 Received: from mail-dm6nam10olkn2097.outbound.protection.outlook.com ([40.92.41.97]:34048 helo=NAM10-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeG6f-0000nS-EG for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 10:35:45 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YdjXL9VxXY7O64DtNUW//FCasdJ/QYw0LEdq+1T1dzmqkQEhoeYTEJOR72Clohu/PzUL7kyk8MrzHyaIsapEoOIO/wpbuE/1i5wQpTf0I+8e5d0Rck9vWdgPIFPYDY3TVrJA+PWvQjP1KdYan2re6dFEILy7CSOck3Mx4JwAcX0fSp+Hw7yRaqWFn5JnLfqsO27corDiBA2cnM/lA/jc3zBL/40jZjLbLwM22g/gcXiS/dLyt/+xKWdo+aRFjCwySyKG9ahgAIXzYikjua6EY3gCX1AX+X3Sujkt94L22GmyGl2jnFumSfD6OWyymtr5XgwqhF+xG8aGzTt2bbhI/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wMWyk1rWVYkG7nm4XDJJVpWsbNHU86skP1VdEo0C2Oc=; b=eVxROe27hB95LXuAEv3aZ7yWPdHOGxDFSuoKP6P0JrJsva5VqaX9Rp4//eDNNOg1w4tZZ4u4lSnfnGzqrZ9swZ3jmW6hX+BtOvGIBG9VXFi0ET/Ltlkrx9qmByv/j1l1wTz0uwF9koAu2nu0/Ad8IWGTFqqjjnfYnpCHxld0FNR6Ka6IQ3CTJRjndbNAjUlH6kORKyPvvUrddcIHsVM0AJ+FvS4qTp/QYQ+Oq3KNnN58xBmGnI/dWcDWlL4be7tMs7O4eoxUUApEtyTZJb0Y3kDCjcr+6Iv3C2Seeoh9snrOL2qqe2L/5I0e3XU2PwYzAwmSBvY+ZSSvDdfKwErKAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wMWyk1rWVYkG7nm4XDJJVpWsbNHU86skP1VdEo0C2Oc=; b=uzh9IuUCAVfTRmHVzmc1qw9ETUv1L7NklB1NwSIN89i0QEMnq2pPUR8KjvcJqIMA2ixVWlv4hBhOS0Q3exN17udtxxEKot1snDLMW1yFwPhQa+1PqaDmPxP29LS7W2MVOBMoNu2vPNgQHNidEDY0jsnbTj9L4RYhVbKNOyGYhGYdBKhp2z47bg0jgoAuZMLrEWehypV3usif7r0aSicM5NCWHekH31xNf4jr/67TZNbPG4DPXritTLRb9UlseDvXG/lPCd2XE4V/CS04uPsBhfHriknMDmD7vq5owYd42429YDvjNeUADxDO2rt1JYzY1+JiWPJWCHdfmQQ6/0FCRg== Received: from PH0PR11MB7470.namprd11.prod.outlook.com (2603:10b6:510:288::7) by SJ2PR11MB7598.namprd11.prod.outlook.com (2603:10b6:a03:4c6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.28; Thu, 7 Sep 2023 14:35:32 +0000 Received: from PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983]) by PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983%5]) with mapi id 15.20.6745.034; Thu, 7 Sep 2023 14:35:32 +0000 From: Shynur Xie To: Stefan Monnier , Eli Zaretskii Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified Thread-Topic: bug#65700: time when gcs-done is updated needs to be clarified Thread-Index: AQHZ3Z0HPeRk2UPAv0C1corkC0IZQrAPHFJWgABJrsGAAAeILQ== Date: Thu, 7 Sep 2023 14:35:32 +0000 Message-ID: References: <83pm2uz6nv.fsf@gnu.org> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [FBmxVDFDeKyYmX4dIjKaFhWF1t5odcwd] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB7470:EE_|SJ2PR11MB7598:EE_ x-ms-office365-filtering-correlation-id: 363a8e97-9b23-4357-9638-08dbafafb102 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6Xg8TeSddoadOdq82CNfwjlAk6iNQ/eNbq6ISj3CYxCEyFcyUZlLXnnJxd9Z15RPfyBzBjNl3cZcZ8chadRoMoDUcqUv3gyGeJ+yGkyPXK2LHMS01q/uHfvejGPZiGK+0jJH2TDmv2OPNg8C6FmkZrPrl1ht518OE9qzI+Q4Aj4HH7pxZ4Zg5RqpeweJpVH7s8bnGeMNx/m36wwfmdZus4fuJN8fKc7rkfVZKk2WYX8nsQ3ALzN8fzhs77q5BvHUWJSOIM47SUAxG8ldroSddggd068hmvE6tNPKRELDewUJzfjLj0HkqMo7QXP9C2My/4oHnqBDZELIj6qjiXTWZiqOZWkZK7WCfpvSMGXoxBjLC+KSsrMVd0tcBZMuLOCNBlBmDEt8vRavj8iYuW2G58HqQP2lPpDxb7BDBjm2gamHNpziyQHz4Yzr6mowMLKs39uvpfabDK838TBT5/37LSdJ6ra8xB58aCpOh2UAmELrHZFTwYX+U9gcjSEjPYbWXdbqqdvxMYjzmzRnvSlRrXKtNcKHRbjyfTkdnVsIY+Y1AG+9Ktf7+WdMjXrXqa05 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?CLZS+281W/F/uWmIW2jPOlmzNxN+Te7P1rypsUnDu/ql6AFqK9+pDLiy85?= =?iso-8859-1?Q?fueCKMIhy7vguTY9fxm8JJiiz7mKFabE1iktSCyjKHV5ZROsooaMW2StNf?= =?iso-8859-1?Q?hPpnZKFPEI+10D4Kpgd9q40S5SLwUct9aP71ifBA/2aPvICe4HKXRgugWS?= =?iso-8859-1?Q?AgJ1pf6aGP19vhNPYZc0B5BJ/YlpiGl2FU0hHK8CPb8yr+Qwhi/rcgWxcA?= =?iso-8859-1?Q?G2Zxxd9fx24Sbkc45kcWGCjgypElXXfgpK5hqnIer1XN0PDSTvDo/SycIr?= =?iso-8859-1?Q?PIdqgEu3nUyTsHaMr46YUGGMstRrCfUQuphazO7sen3AZg3+UgZWKJMmmJ?= =?iso-8859-1?Q?JoLR67BizFNRu2CxOGKzN3VyJfSGVDA2m8OGKI1zmJIo3k0aXa+psdXoyY?= =?iso-8859-1?Q?026BF2WwE5K/cnoNkZIz+CiB4Xc9Fj6u7RCJgqy99NY5jZEGD3VjfYYOOG?= =?iso-8859-1?Q?N3kSCvBeNcxpJCJ1yAWe/kq9XFm45zWYd7LkVWRo93G1+LVWI5uZbwfVrn?= =?iso-8859-1?Q?Ozqnr+wcGZjW4AigVmv7JJCoguKgL8ZlHVd39BWAlzZfzr64IPa1LDMj7S?= =?iso-8859-1?Q?FKZg2Hgw4kcA9k8PIqrwLPJTaD5CipvP9XrXjeUOHzbCizxYp5nawnwx4Y?= =?iso-8859-1?Q?t49posqj37qsX/pnQNdBhPi1n41AY5pFWAS03z0GwD5ZzjJgTlPmrfx1uO?= =?iso-8859-1?Q?/6VtuRJ/kQt3UjMo2ScVPFbR+o0dHC9dUMlOZcJjjwXxND5ig4ovq2jOyL?= =?iso-8859-1?Q?z6IYRdsz6Yv2Oo0U4aNx/sP7KhszLYCx6hKyVQTVjt7yd07I9xoVLJDOH/?= =?iso-8859-1?Q?EVqzaTii/kvKkUhdVIOX2W2CKdyNdz17r/fKew1N97fyc54DzaKChfwBW3?= =?iso-8859-1?Q?QxnVoc7JZM1Yezn3aUUcJzDez1HcI9W+p6m4+tcF/nFEMtlQbzaRL0Of4K?= =?iso-8859-1?Q?lKGvOWtnsd/j7bqdIg/se+xEov0KEv0pby5CgJK6M1gPsSnzrZ1s5DXbbP?= =?iso-8859-1?Q?iPbk/lOq6CbuA00a0pLPGQ7WTCVe2pAUZ886QuAp+YeVICFZZn0bG27UOK?= =?iso-8859-1?Q?qCne49Te7BomWuPK8GhUKJd5n3sjVTkHTlbMsjx7CO7k8h7Q7iyUoOlSOl?= =?iso-8859-1?Q?02pbAUEBXC8qO6jthU2htKFG3mzrgv2nOIzEAc8xbt5pW0GMp4BhyL6XLe?= =?iso-8859-1?Q?zty0NwYqdXj1xmwT0aLhk9l/BGRFoUpWnO3VNfnO+kBIw19R9IxI4kPw?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7470.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 363a8e97-9b23-4357-9638-08dbafafb102 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 14:35:32.6403 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7598 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65700 Cc: "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Stefan:=0A= > I'd be curious to know how it affects your code.=0A= =0A= My Emacs displays its runtime information like this:=0A= =0A= Since it's mainly related to GC, I have it updated after each GC.=0A= =0A= I believe I'm not the first person to do this; why others didn't=0A= report the bug may be that they don't care whether the number of GCs=0A= is exactly the same as they expect or one less, so they didn't really=0A= check when `gcs-done' is updated.=0A= IOW, if the update time of `gcs-done' is changed, I think most people=0A= won't notice this change at all.=0A= =0A= > Stefan:=0A= > "Philosophically", both choices make sense (either consider=0A= > `post-gc-hook` as being part of the GC or consider it as external to=0A= > the GC).=0A= =0A= I'm not a native English speaker. Does the POST in `post-gc-hook'=0A= mean the functions will run when GC is DONE?=0A= =0A= > shynur:=0A= > Is this an intended behavior? If so, I think the docstring of these=0A= > variables (such as `gcs-done', `gc-elapsed', ...) need to clarify=0A= > when the variable is updated.=0A= =0A= And `garbage-collection-messages'.= From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 10:47:44 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 14:47:44 +0000 Received: from localhost ([127.0.0.1]:40866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGIJ-00015g-NA for submit@debbugs.gnu.org; Thu, 07 Sep 2023 10:47:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGIE-00014g-Jy for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 10:47:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeGI6-00011N-OD; Thu, 07 Sep 2023 10:47:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jTQQEUGmZ87me1VliKK+PdpYPkHDubfcmof8sxDHTWs=; b=ozuGDwUbjPuE 6rTnVbiN33nvZj5dKW6a6GY8w99nWYLcTW9JawMbgSH+CnUWMtBwkkUIlxmSHgwCBCBbgazMuAajO Orp58XyCKpu9xYWABH3wTwa81CxdTmV5pdPzyHw2hryImgxpOgBJYCLTZO4y8YQ0B2VpsN7X9fG0N /ZV6JyslT/fvEY2pzzaix3hSfJnEQVlopAOgOu7zb+nV4c/nmOchbeFwe0lenXxGfpOpymF+zKTCw SxlBrtemkOmrt1rGwFEHChR0qhDL20Bnuh/i3KKjFEwpNx9DTFwKZ7FdTMUA+pzI0RFkANEb8oPwN hdEzd3kzgQY4uoZsfKSZhg==; Date: Thu, 07 Sep 2023 17:47:18 +0300 Message-Id: <837cp2yr9l.fsf@gnu.org> From: Eli Zaretskii To: Shynur Xie In-Reply-To: (message from Shynur Xie on Thu, 7 Sep 2023 14:35:32 +0000) Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified References: <83pm2uz6nv.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65700 Cc: monnier@iro.umontreal.ca, 65700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Shynur Xie > CC: "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> > Date: Thu, 7 Sep 2023 14:35:32 +0000 > msip_labels: > > > Stefan: > > I'd be curious to know how it affects your code. > > My Emacs displays its runtime information like this: > > Since it's mainly related to GC, I have it updated after each GC. That's just causes off-by-one count of GC cycles, no? Easy enough to fix. > > Stefan: > > "Philosophically", both choices make sense (either consider > > `post-gc-hook` as being part of the GC or consider it as external to > > the GC). > > I'm not a native English speaker. Does the POST in `post-gc-hook' > mean the functions will run when GC is DONE? Its being "done" doesn't necessarily have to include updating the count of GCs. The main job of GC is already done by the time the hook is called. This is what Stefan meant when he said that philosophically it is not clear-cut whether updating the count should be done before or after calling the hook. > > shynur: > > Is this an intended behavior? If so, I think the docstring of these > > variables (such as `gcs-done', `gc-elapsed', ...) need to clarify > > when the variable is updated. > > And `garbage-collection-messages'. What about it? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 10:58:58 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 14:58:58 +0000 Received: from localhost ([127.0.0.1]:40892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGTB-0001SZ-RC for submit@debbugs.gnu.org; Thu, 07 Sep 2023 10:58:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGTA-0001SH-10 for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 10:58:57 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B5404807A7; Thu, 7 Sep 2023 10:58:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694098727; bh=RfqXyjGDTGfljOFjWvIMq+F9tGTIWi7kWetL3WhBybc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Nnz5723Sl5NC7CD5J8op/dghziW1yby2G20DXpVK6GB8oIZWLJIiVTJuLpt58lCQ0 Ho4QzX6y8+4jCY+vkfU+hhrZ8Hes/mYwsrqGad69dBgTbJF2e7v8SxSoYBRNGk8FGi R+HhJa134cEnvi079TpapZlrAiEdyimFVTaKqaF1q9ZhjKWfOKa5nC6ag/iOXr7Ps5 +qllGHfth4kD6a/G91TozB/rNYhNZknuAOEfE/gpz+fjvfObxeeB4WQ4xSNxAqD9yl t2hzLGeqLhdd7yL1sB8hC7Kg72kOVFY6sw732vbxkEtK4rJzaAByby4AGhbz8fMzRV ScDamDK8LB1WQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 48ECB803E0; Thu, 7 Sep 2023 10:58:47 -0400 (EDT) Received: from pastel (69-165-136-223.dsl.teksavvy.com [69.165.136.223]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1E015120263; Thu, 7 Sep 2023 10:58:47 -0400 (EDT) From: Stefan Monnier To: Shynur Xie Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified In-Reply-To: (Shynur Xie's message of "Thu, 7 Sep 2023 14:35:32 +0000") Message-ID: References: <83pm2uz6nv.fsf@gnu.org> Date: Thu, 07 Sep 2023 10:58:46 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65700 Cc: Eli Zaretskii , "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I'd be curious to know how it affects your code. > My Emacs displays its runtime information like this: > > Since it's mainly related to GC, I have it updated after each GC. Hmm... that doesn't really explain in which way this affects your code. If you only ever run that from `post-gc-hook` the only difference is that `gcs-done` will be always smaller by 1 and since it doesn't start at 0 anyway it's not really relevant: it will still increase by 1 every time `post-gc-hook` is run. FWIW, I tend to agree that it would be more useful to run `post-gc-hook` after those values have been updated. So that `post-gc-hook` can know the exact duration of the GC that we just finished, rather than the one before that. Any objection to the patch below? Stefan diff --git a/src/alloc.c b/src/alloc.c index c77bdc6372d..cee43783387 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -6595,13 +6595,6 @@ garbage_collect (void) image_prune_animation_caches (false); #endif - if (!NILP (Vpost_gc_hook)) - { - specpdl_ref gc_count = inhibit_garbage_collection (); - safe_run_hooks (Qpost_gc_hook); - unbind_to (gc_count, Qnil); - } - /* Accumulate statistics. */ if (FLOATP (Vgc_elapsed)) { @@ -6620,6 +6613,13 @@ garbage_collect (void) if (tot_after < tot_before) malloc_probe (min (tot_before - tot_after, SIZE_MAX)); } + + if (!NILP (Vpost_gc_hook)) + { + specpdl_ref gc_count = inhibit_garbage_collection (); + safe_run_hooks (Qpost_gc_hook); + unbind_to (gc_count, Qnil); + } } DEFUN ("garbage-collect", Fgarbage_collect, Sgarbage_collect, 0, 0, "", From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 11:09:26 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 15:09:26 +0000 Received: from localhost ([127.0.0.1]:40931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGdK-0001qx-5R for submit@debbugs.gnu.org; Thu, 07 Sep 2023 11:09:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGdH-0001qj-WF for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 11:09:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeGdA-0003Cx-Pd; Thu, 07 Sep 2023 11:09:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2XyONLMS5STQaAP6/Jh6mGJlovl+Qo4BZCXr7+R8YFk=; b=D0UJJbBdMXpk I3tHeOyWcdX1AqpF5a/ue8ixoGkjqSmyAhPUdEJNsF7trz+zwApUZqCSSdDE1LH6poTgYz4W97fXN ci4rTwacjOEa6bYX2oN5rtC+zY3AzcOGlZFhjiALD/zN+VbDvY3bnJl2kRaYcgMn36yFQLRJUH+Xc 0H5tVYspcA96xKdOmFEXh0AviJKjS41x252mnpWpkoyjd5td49KIqLpzLkyKqdrwxPGiFbetCDHLB 50n5CfNfcPEWIoOIXxkm82LjXJ7yob4TTnLZs2sLLXCIpDhyF0M97Um2xp024yXQb5TXKWZkrNYxc 9ykwgXmfIF4D/85YdLSuXw==; Date: Thu, 07 Sep 2023 18:08:56 +0300 Message-Id: <8334zqyq9j.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 07 Sep 2023 10:58:46 -0400) Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified References: <83pm2uz6nv.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65700 Cc: one.last.kiss@outlook.com, 65700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , "65700@debbugs.gnu.org" > <65700@debbugs.gnu.org> > Date: Thu, 07 Sep 2023 10:58:46 -0400 > > FWIW, I tend to agree that it would be more useful to run `post-gc-hook` > after those values have been updated. So that `post-gc-hook` can know > the exact duration of the GC that we just finished, rather than the one > before that. > > Any objection to the patch below? None here, but please call out this incompatible change in NEWS. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 11:23:21 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 15:23:21 +0000 Received: from localhost ([127.0.0.1]:41029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGqm-0002L5-R9 for submit@debbugs.gnu.org; Thu, 07 Sep 2023 11:23:21 -0400 Received: from mail-dm6nam11olkn2049.outbound.protection.outlook.com ([40.92.19.49]:47201 helo=NAM11-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGqj-0002Kl-Cq for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 11:23:18 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BCpqy2bSzxInp9+OOuN5Q7BbCyTPFk3hifPU2IxON+A+LwelxoFf7oGIf5RUGqULNJyqzehA54yXT3eoXH+fLXKpDyCvnbwGKAJdtYrzaEpUIfYBMMRK9NOpfmfm29QfT+2tfjLgBoRNYySSv9fbXcxcFWCLWyD4W7/HgLEGVuqy1GQ6IlFny/DmKrdfN/vjLfVR92LqucuZGEjQ05mFvp1YEr41yWWw9XrHkAfohfVjQzSSw+68n49uZzQNE6KhDVqA4IiZvcAfG0h61r7oC++YXWHYUBaE9xmkp0UeO5Xe7Fkpa47BJ42s+frP6wdASmv2/FtxA95J7vYccNEKNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WqKFQjwoZ+VIXEkoefb6pj/IMizcR+fyxGC+NiMt+po=; b=ZHJnIeZbKH4LJMBvL493ZsPaLlEfUl3UZ9/RZiJcrTYm7vQYKm0Ay/cYywXqwoXKWWNhNCZAKBWxP5nT4gIp595HjTLfZ2Or+KwmugAHFYFhC08WaPuF4c/fj95uZHyh0lJYPM3TQIS/yvZkQNvJ++3ih1SWCtFdnUOg2iZaX1QxagLsCyxJXHqVeKcp87JuWs4HcwbYFP45ArwXToCt78PVpUPmy0tZmwjkTPDLeOpfHucKdWUnP3WGSjMJOK2Ys2USNWx3Q+w7OeQ29Rg/cj2QBofMvaijvOQaGNWLS5YB13Ebpk7Z3duTLTE7jNhdIxeD3tyneQ+56Wkp5F0dpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WqKFQjwoZ+VIXEkoefb6pj/IMizcR+fyxGC+NiMt+po=; b=qicFSyWmwidDjbMHyLytgjn9gvRHYZSgKeAXIc6ads8D0x0D4tYo+52d9pBcvD2S0ghJ+t0gNoVqWIyJFBOgxZsq+QpHKslBkbcJ7Merm8biYUkH+/afJ7RbOiJo94GtW0pgOXNqtvMPrjwPZyDMYmje00Rj/0Ciur1EIzLa87xox4f96MYXIWHOFEw6CxbFEv2AdJEm1vJ7qly8x0NARx/UXwerJnA/jRgb5UvC3nOciUX+XrBc7/zMT5Vw2yjUFIadFM77wu9SYMqaZIlwLgZD2WmRA9f/Ls/3uzx7D9qqNuHUEJeowORYhqy0ATMCx4m/VSzPCndVGyDFN1t2iA== Received: from PH0PR11MB7470.namprd11.prod.outlook.com (2603:10b6:510:288::7) by SA1PR11MB6613.namprd11.prod.outlook.com (2603:10b6:806:254::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.34; Thu, 7 Sep 2023 15:23:08 +0000 Received: from PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983]) by PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983%5]) with mapi id 15.20.6745.034; Thu, 7 Sep 2023 15:23:08 +0000 From: Shynur Xie To: Eli Zaretskii , Stefan Monnier Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified Thread-Topic: bug#65700: time when gcs-done is updated needs to be clarified Thread-Index: AQHZ3Z0HPeRk2UPAv0C1corkC0IZQrAPHFJWgABJrsGAAAeILYAAC7lHgAAJyv0= Date: Thu, 7 Sep 2023 15:23:08 +0000 Message-ID: References: <83pm2uz6nv.fsf@gnu.org> <837cp2yr9l.fsf@gnu.org> In-Reply-To: <837cp2yr9l.fsf@gnu.org> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [iI/6Pgwmx3pWu+TaRb9mXlkT8/8HPPBr] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB7470:EE_|SA1PR11MB6613:EE_ x-ms-office365-filtering-correlation-id: 8f3b4ab7-174a-4461-17d6-08dbafb6571c x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kVRh4y27YdfufZpqLjMA4g0vaj78dIo0XEeVIA3dCk22BBkXvZoUTYPlbrGTXG8BE2T0Dd16F8TFvHeSuxF7IccjRzbEq8SlQr728YD7iaIWlhnggDsJo5abUN159lYiM8OF4BeILqQ/E7TkbZo1f6eKOyLd1aWe+EOzAGmVADjX3Mt70J7WTt5I+yl4SCyY42mTHz9mRki51hyqJqyOR0FBo2Bo5hp8XOZ3jQK4o7cROlA1PZOjm1GsfykwHWNoc8S2jIXWR0Azm5mncr6Hl9FbeIEpqd/2MMxH2x5yM0AxQSRyLMq9NwCgEvzueVAe7bkW9AZyObXMTUq10s0vrvvGTI6APZd7w/BIZcT6NRZfAKS901RHS+/JOCj1CI5tYiK8Au6xKGkFzBKzqEM99jlWOZVeb3Czmygqk9qQV78NdRV//ZpKg+GOEGrmN7bIXIAWQcr1LJUgtV37QPc7NMDakPt9e/Wk9GOwrmeB1yZj+CGbXbviBDvxMo+Wrv0kIuF+rPAlqSk2KTK6+uAVu7QHPLXys/u8OTM+8duaByr6qAnAyoLq+9lAoMXWKR9J x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?0e2o0jx48z5SDlBySffU+tnIMy3FbD6tIIky3yxsOvVLZw385CIOinmNpF?= =?iso-8859-1?Q?UE8bYjZ5QpBO/y+5tzBe60Y6UqY4IZaSfgsMw1oBueY/PGJsNMyVUtCg49?= =?iso-8859-1?Q?EF+eM4w4oQu3kqxA0h5JIEl9pf8H1xoIKjm85s/eeyO0SQAbQpLriS2oeS?= =?iso-8859-1?Q?wxKakA6nyS8xNuDm4CckHHlgENODokhRJY3HNeI4quimYEwTR1NmnEWeGd?= =?iso-8859-1?Q?QkHpwpy3zmFcWerJjaTjoaQXVftiESjaxz6EqKcYhrs6xFMr13Myqv7RuC?= =?iso-8859-1?Q?nHYCwmYtv5G68cDzC7cJppl0tUG85mqTqXaTZx3uJchuqG4b7nLnb5uGPA?= =?iso-8859-1?Q?co3djR4QsNU5FW0/J7JG17woBDCfxcqCuVrn8JHhnZRSItjxLRl0zJoMuq?= =?iso-8859-1?Q?vu4i0BfXpYrTY4z8wnVvTbbXJQ/c5DtgMVRKJ2MYSEKEiWp1rZcw5xZchW?= =?iso-8859-1?Q?m4yC/dZsqXYB4Ww/x647EW9J5gv/pJAc/pEsZjlhKmX+uxR5qoNKVkwyik?= =?iso-8859-1?Q?aAC4a2Ojowev/ZOGXoW4rFud9OyV9Vs7rSfNYpmCVr+nVoAxRVpv8aCq8m?= =?iso-8859-1?Q?OloRoqxVY1ANtbk/X5vSj/FbMXdjWUtgF3Gs++Vl5iXPvrdhuAfqwO1F8A?= =?iso-8859-1?Q?QrgZjE3rbrcmwoWFGMyTD9t2//+pV0pr+/261nDGFrGR7rDGJbbDiEV+8n?= =?iso-8859-1?Q?aPd/UMhfrVUKEhydZWCnFL7IrpqxVZAXnaBMCsg28lIP3qytuXQO3co39P?= =?iso-8859-1?Q?15GGDTiUvI5vZffqZLr/C2s9Hxb6H4+/JQi0W0MJUJUzkdgHpqjkWTvGs2?= =?iso-8859-1?Q?KojEhgWaF4nc/CpMsPPEjf3IrlJdkmsTnQ9DBKm2Ot4JWVsrTwgX9GeZxF?= =?iso-8859-1?Q?g/piUsQCPuHj0xCFSb0sI5qd+4LS6sohtLnnSlNhUTEy0ULH1nDN0GhZrU?= =?iso-8859-1?Q?ocmbDe0kqI8bhQuCJuIqLEfp5OAyusOvtREj46N0FY4cCoQbMvm/64Dr2P?= =?iso-8859-1?Q?uCxAj9sjIUvU8/iLV1kSvCpvkYgF9TE7nGjumijAtCm+/U1StcLlOfyZJ9?= =?iso-8859-1?Q?+TAehlkmoVunhn0SisT32ywumfBPTLhFHd23HDiQcyBrXYmMZvLv1DXFkY?= =?iso-8859-1?Q?Jt5WsKA/l/J6YjD44z0P4j8lR6H3qcnTBqUSv5otKdSLsnj/cnklxhhVSy?= =?iso-8859-1?Q?pKWvhAD6+OqOjaZPu9SycAKIV8UWhtLFNC4ksyCInoOZ+jie5QLOgTVc?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7470.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8f3b4ab7-174a-4461-17d6-08dbafb6571c X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 15:23:08.2980 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6613 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65700 Cc: "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Eli:=0A= >=0A= > > I'm not a native English speaker. Does the POST in `post-gc-hook'=0A= > > mean the functions will run when GC is DONE?=0A= >=0A= > Its being "done" doesn't necessarily have to include updating the=0A= > count of GCs. The main job of GC is already done by the time the=0A= > hook is called.=0A= =0A= Thanks for explaining. Yes, "Its being 'done' doesn't necessarily=0A= have to include updating the count of GCs."=0A= =0A= My point is, IF "the functions will run when GC is DONE" THEN when=0A= these functions are being executed, the `gcs-DONE' should have been=0A= updated.=0A= =0A= > Eli:=0A= >=0A= > > > Is this an intended behavior? If so, I think the docstring of=0A= > > > these variables (such as `gcs-done', `gc-elapsed', ...) need to=0A= > > > clarify when the variable is updated.=0A= > =0A= > > And `garbage-collection-messages'.=0A= >=0A= > What about it?=0A= =0A= Mentioning it here is just for reference. Maybe you want clarify when=0A= the variable/message is updated/generated in the docstring.=0A= =0A= =0A= > Stefan:=0A= > Hmm... that doesn't really explain in which way this affects your=0A= > code.=0A= =0A= It does.=0A= =0A= > `gcs-done` will be always smaller by 1=0A= =0A= That's it.= From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 12:53:03 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 16:53:03 +0000 Received: from localhost ([127.0.0.1]:41263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeIFb-0004Ll-Cp for submit@debbugs.gnu.org; Thu, 07 Sep 2023 12:53:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeIFX-0004LE-T0 for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 12:53:02 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7B5E8807A7; Thu, 7 Sep 2023 12:52:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694105571; bh=mNdDKYxPiRFlpRK0LuDAbB2ItOgh33wC9dt7wwyblRs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=K7VYXTlOcWI0+T+CSb5lRC+FSewmlgKGyDMDdZWQ/MFTf0ZvfUIRzJwZd3So1lyyc DRwcOE1Fg/0A7P78XfNc7VpmaJ3tqSgt7OXtYne6Q2KCf0ui9G1bNnI09pHSkbUxZK ICl6r3AREv4w8Kyf3rCTDRy05j07VjCX4S+0ltJY8PtWwgx3Q5eTnkXv9+t/XqFVwm VDjrwrfCdMR6B8nHFnjExCpXnJnuik2fCgFhRtx3Tfp03Yjgn/EspZuCWw13WDBB6I gCUuQbrVAp255QZJxxOz/YfYJh8T36z09iNUp7uV3ufaCSuScJclA+cWAUAsqYy0eZ UiecrBroN7rjA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3E74A80250; Thu, 7 Sep 2023 12:52:51 -0400 (EDT) Received: from pastel (69-165-136-223.dsl.teksavvy.com [69.165.136.223]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 15129120235; Thu, 7 Sep 2023 12:52:51 -0400 (EDT) From: Stefan Monnier To: Shynur Xie Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified In-Reply-To: (Shynur Xie's message of "Thu, 7 Sep 2023 15:23:08 +0000") Message-ID: References: <83pm2uz6nv.fsf@gnu.org> <837cp2yr9l.fsf@gnu.org> Date: Thu, 07 Sep 2023 12:52:50 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65700 Cc: Eli Zaretskii , "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Hmm... that doesn't really explain in which way this affects your >> code. > It does. At least not in a way that I understand, then :-( >> `gcs-done` will be always smaller by 1 > That's it. Why do you care if it starts at 4 rather than at 5? Maybe we should make it start at some random number instead, to make it clear that 0 is meaningless :-) Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 13:20:00 2023 Received: (at 65700) by debbugs.gnu.org; 7 Sep 2023 17:20:00 +0000 Received: from localhost ([127.0.0.1]:41294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeIff-00051N-QV for submit@debbugs.gnu.org; Thu, 07 Sep 2023 13:20:00 -0400 Received: from mail-bn8nam12olkn2039.outbound.protection.outlook.com ([40.92.21.39]:38368 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeIfc-000515-Rt for 65700@debbugs.gnu.org; Thu, 07 Sep 2023 13:19:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nfSwXt6cbUywyu3m7CILANVYqFBeylhx1OzunJS/MKEg39orp1LsaQvvxw+OuxYMuz/36lX2TDBAN7TSSBQlLHPGEMV/TRgZw9tjpam6uCp/9MZiEWKz6dptZZTA7YxyPcSO1oLnmKlfecTmBT1mwNoR/1DxNmPMhKkiNO4UIjaViGvfY05tfIIjfsVHSYE5hqn98rggMI4vBTXWc80oysJcg5UD6Fv2o+Kh4ARlHVHju46u2/Veuf8zyV+ul1079xYNksz80pLhtwLl71XrOwligBNyTND+vRn98STovZLZ7TDSSMd3ATs+yOT4EHy569liYKK3Ak5rIxg0z2ERzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFamT6XyuycmcEdW+xNmExv6jEY+RUmeCamx9fCl6KE=; b=IjKF0lHjmE+bUDzhz9QQLB0bDhS3r+C1rFGzmtkG8QaBHsxdN4H9BIYwb2WwZVGx1aHyM3ky3IlEXNkTXqjYK4g5ShoxSO7ZmQxUm6h/YyYZjgXxoyakCVGIsBn6LRXq/iGQoIujq9B6NKL1QsQdwlfG0hOLG4jPuAMznEEmRqVwvTfFI+6o8ofFnN/OvSbWP17btrLKmli7pn/GCGBK5FxDCV8fECJO7Npra7Z1kinQvozoM+BGKBDc1dU9L24NjeBkVtJkWcV9c0tW/PWTaoSdQU8Jtz/hjpgY23iV5Cpp7OR+GXqkTSNYXPQVy0+0cEZapABdNoisG0Sjxqu+2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UFamT6XyuycmcEdW+xNmExv6jEY+RUmeCamx9fCl6KE=; b=JcPBzswEtqIZMAlyk0PxUZuz2TIw/xO4GQHySD9aMy9Z3RsM2swtKzxYfL4GNw9siTE8OKLFWzJRifhNoHuWEw/QuFCa2YdQNnPGK0ufYcuJnUjfFBgqeiDI613siwaF/KhPnC4cRWDYEfLcqYzI5k4iXWccmXugdjVNxOx+f4w8EoIQqOSf9c/zOCuTBY/AyPu5sYF8gN2aZamaLD/zjUMXVAagPlGvDh5xGbKQ7bbFikQcUvCMT699xzLMbT3OjdexPOH5+2h60LN803in0AWMMS1SORUD4FsdVNcS3n5dYcwKIqkL0FSDwWmJYgxD9OCLkUasXoTFBin2X0ijXQ== Received: from PH0PR11MB7470.namprd11.prod.outlook.com (2603:10b6:510:288::7) by CH3PR11MB8706.namprd11.prod.outlook.com (2603:10b6:610:1d1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.36; Thu, 7 Sep 2023 17:19:48 +0000 Received: from PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983]) by PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983%5]) with mapi id 15.20.6745.034; Thu, 7 Sep 2023 17:19:48 +0000 From: Shynur Xie To: Stefan Monnier Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified Thread-Topic: bug#65700: time when gcs-done is updated needs to be clarified Thread-Index: AQHZ3Z0HPeRk2UPAv0C1corkC0IZQrAPHFJWgABJrsGAAAeILYAAC7lHgAAJyv2AABk6cYAABuMr Date: Thu, 7 Sep 2023 17:19:48 +0000 Message-ID: References: <83pm2uz6nv.fsf@gnu.org> <837cp2yr9l.fsf@gnu.org> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [r8FoE0+dleuMOhDGoYZeaRf9hERKgRPJ] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB7470:EE_|CH3PR11MB8706:EE_ x-ms-office365-filtering-correlation-id: c0c88a3b-ccd5-4d57-5728-08dbafc6a394 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SRSFs0LNj28neXUldyFiXWVPQmgyrR4dUVPspcd9vNgoqzTE5Q0EPLSzsRRpKyTfp7QFerYxiLNMTdX8ncpJcGl4Wth5Y4rujum2CsidTMrTx7sLftklMKBGPcdQ/A679330rirtZlhxKpCxFFR3895XI8VBtZzusaq3c4mogXpjwQMOjnrjKHd9hw9rtUW6Y7Hn6Un0ZXARpeB2ohj43FpUZZRGXcL/AHT1wHqqUcaNNsw2P+J68aN3SI1jJI7xAuzMaZnR8sVsSgAEun3TUsDqL/oka/aGZReBD2S419IEjat3N1zu0/dTWWHKd2o/jxc7wy2ddmYVM0NRlPA92M7bDuDh7rsvWWW2ORWLw1JPsdljaHib4A3QK42mX57z0ZFyTxX8jubFWVXmmUcFZbclSZqQyeeXzYAn2PqQDoG40jc5PlDnlMLe8D9rfzNzQ11qrUhmbNCNryFgyZJIoo8Dq27mh8LdAhcNOtVhXRWoIsXnQei74O+/nX5iAxN7HEbsSHI4yMBfNfRIrfbbNuXDoSslIB1GC7y2t+RmCyKOmYNa2nzf3vSTBOS2JhAt x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ygfddVNVAXODU7LnZDnETEgp5GX61b8m4lCHGU37gEudwMj0woAI6TLWtb?= =?iso-8859-1?Q?7goTdlg84SkemQo05VVUK5lMsbwFgobdQvyYPL21rbwwlw/XzptPt8OJPq?= =?iso-8859-1?Q?ZEUT7cFzZS7Dr7NPFHOWUvEUdlWEX0aoRerEspN6C1KFuACXnwKCrSAoU0?= =?iso-8859-1?Q?ro5D3OknO3mAdyvVTY4DEb2Kp6/mujB5WbnxRKoHop+jf3Li4rIN3FZ91C?= =?iso-8859-1?Q?stMT2tDUpBM3qw9bXSoNfDm9kLX7Z35bu/ehtyliGJg1DWea0zdw68uHTb?= =?iso-8859-1?Q?th++o9vH08QGtkqZ5AfTTgxWp8ywnmWBMqmK4TOcHRUCm2uOaUdTFjyPDq?= =?iso-8859-1?Q?ru7if9ZE32jy8DwNzwAIf4pIO58zbduKiK1v/Rr5yefmzXQpr/d8R6jI66?= =?iso-8859-1?Q?Frs95UalxuawK96/xXE1vAGZjchiwocV3Bh/RYd+bMaZgEd4vrhroyd7aB?= =?iso-8859-1?Q?wRUuqYgrLp6sE5l4p4T83YRD2lb0MaC8fz67+ctwJxNvHWlGRKc1SzB+zH?= =?iso-8859-1?Q?swESSme98Smecf5SVlIFFF6Zr+jMCj+r09HVjD/nXSG3+ywJ/Zc6atDvml?= =?iso-8859-1?Q?tKoEHYmkwAsjF7IrAx1mABTOFeeeklPBlHxor1pEhS1NJW03PxbyPVhL4n?= =?iso-8859-1?Q?Ze2OdXpli4qKP6xpoL8tQK3AO6VYyRFxCCPPflLwCBOwhNPhIeoX9xycIX?= =?iso-8859-1?Q?eqAxC2in/cRZrKH+ntCyRdloS/Ar65y+BWdAc/6d+m8x0mftBFFNszlAvy?= =?iso-8859-1?Q?alXPC6YrNpR7MS62G9S7auLJWl+PjL1B4EzDtPFRm3F68k+G90VBdnc4Zw?= =?iso-8859-1?Q?bpL5+m7r7D2YL0Tbh2HpfNvP92la1myOiuqbrMZ/IJcVRJBTcqB/bAFQ9h?= =?iso-8859-1?Q?rx1pzicgx/h3R0VuODzivCwr9I0X+0JMcJXGyd9eAWZ+hVxj8daZB7hOdR?= =?iso-8859-1?Q?MKHSNcqqbyELYSTFcqfaSj7EZKxSmlIJVDB8GkbURRh2CCsMasSGHYzsrD?= =?iso-8859-1?Q?7GzUD1+/d3bsVbiuDrF0PBxg1qMdsOuND5Xfu+ZA92cR/bDVEA9PTv47zL?= =?iso-8859-1?Q?0+A1dQ+JDw6wqLujLcEO0fDSOpPlY4GGBeOQ2b1wnU3JVXSLYeL9QVteMl?= =?iso-8859-1?Q?M04NizGSg9zoZhL/Bzn+zLElpxWh6VUm5+5mKiUOLpHTt8/CBbYUqBDoen?= =?iso-8859-1?Q?fc2CSDjBvbmbmFCQyrgd0eW+Y7VNSi1f29UWxk7nl0xp34fOx1bIXxv1?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7470.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c0c88a3b-ccd5-4d57-5728-08dbafc6a394 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 17:19:48.5512 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8706 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65700 Cc: "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Stefan:=0A= > Why do you care if it starts at 4 rather than at 5?=0A= =0A= To be honest, I don't really care; it's quite easy for me to fix this=0A= in my function (although I'm a little freaked out that the behavior=0A= doesn't match the docstring: "accumulated number of garbage=0A= collections done."). Even if I just leave it there, it's only one=0A= less than it actually is.=0A= =0A= But at least I should let Emacs developers know this. If this is not=0A= an intended behavior, they can fix it; if it is, they may make it=0A= clear in docstring.=0A= =0A= So the question is: do you care? or, do you think users care?=0A= =0A= If the answer is no, then there's no need to change it, just clarify=0A= this behavior in the docstring of `post-gc-hook'.= From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 12 06:14:33 2023 Received: (at 65700) by debbugs.gnu.org; 12 Sep 2023 10:14:33 +0000 Received: from localhost ([127.0.0.1]:56224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg0Ph-0002Ne-8r for submit@debbugs.gnu.org; Tue, 12 Sep 2023 06:14:33 -0400 Received: from mail-co1nam11olkn2073.outbound.protection.outlook.com ([40.92.18.73]:28865 helo=outbound.mail.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg0Pc-0002NO-SP for 65700@debbugs.gnu.org; Tue, 12 Sep 2023 06:14:31 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7SMg4Z+9mulca1US5YzZhXCJibrXXCmTLrXoUbyUGtXMCfLS5SU4cUmNu1uAlpN2YoGYIT+PYza6vS7rckDG0qpIHFUlezHWmLbhj0bxc+XOnDR5d5g3/j6ZQDOcHcc6XTAwbMh8UipjXGENrLPqIVQ+N2M08khL1Mi2lyqbKPUDkEFdcVcQU4wQCdW9t3Zch1em76anYQtpmr9Dneab3EVBBRZ6Go3w8lq94tScQz2sfttrd+2TqPHzAkqoBSmhGvhHKrSdXDQkL+80S+mIVU069wAB2BVqfazT2Tkr968D9webZK42xEdxl+fR9hUMq8jgEgDC+yqmarQK/7gmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pLN8xNrmfd1ydrQTEL25vvfnPnj3IL2XPlbZclOTsOY=; b=P19zjTK2MMio4f7J0eR8AZNesdlt/xWAJG4kg8KdWtjT/xM8qeZNNX+qPm3mcCGpqfeztYYZ3gAtQK/BEayPwRvL8Qd/xTM1ODmfALcmJ6zyw9GdLvN+TFoTwD0hOksZ/xM/V+wBYJcKtfhiyFUyliN0KX5BaQsDVDIdQxMHGNOLJPVMTGxlWTOHCv0gp2NlEkyvA2kdQlLLjj19LsdM5piVDEMup7GUD+nGP36OBy5UiY11skqkJpeOiOWMqQKqY5k1LOEuvfn09GRpky/+unBU3Pmt0lxJ05fm1qHaR7vs58oP93cad7BS176gQRBJAZM9oDoVykpULILolvuPZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pLN8xNrmfd1ydrQTEL25vvfnPnj3IL2XPlbZclOTsOY=; b=ndFJWAdUCy/k3sddEOvcgiZql3efipWUlW23/33ubgeuVs1u1cycM2RIOtRz9vA1CC9KmzwgDJ2O71ljIPmkrrg7El3+gC3Eko9BmUuT1M0rRCFD+K8HgIPNcD7KT+Mio2V/ttZB4B7A1HVPjsaZuNCSWBHdKgmpA65HEcube9dz3MLuP/PXHkb40Jb37V/ftQEgqMCyu2OR46tLuV5U3ZXE9fhMCtFs4bRR6nruoNNv0y7yHdMfqFkwNHR45pQGgXQS2+WBYDFeBwYZPsnmowkCgK0oveNVFqbncHeF9/Og1WgSUIIva9z8jEaXmSZW99XmN/LTy0skzGcDiBValQ== Received: from PH0PR11MB7470.namprd11.prod.outlook.com (2603:10b6:510:288::7) by SN7PR11MB7973.namprd11.prod.outlook.com (2603:10b6:806:2e6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.38; Tue, 12 Sep 2023 10:14:16 +0000 Received: from PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983]) by PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983%5]) with mapi id 15.20.6768.029; Tue, 12 Sep 2023 10:14:16 +0000 From: Shynur Xie To: Eli Zaretskii , Stefan Monnier Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified Thread-Topic: bug#65700: time when gcs-done is updated needs to be clarified Thread-Index: AQHZ3Z0HPeRk2UPAv0C1corkC0IZQrAPHFJWgABJrsGAAAeILYAAC7lHgAePFlY= Date: Tue, 12 Sep 2023 10:14:16 +0000 Message-ID: References: <83pm2uz6nv.fsf@gnu.org> <837cp2yr9l.fsf@gnu.org> In-Reply-To: <837cp2yr9l.fsf@gnu.org> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [ogkXho26Tt6KhLIqA231qBl51pqirgF1] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB7470:EE_|SN7PR11MB7973:EE_ x-ms-office365-filtering-correlation-id: 20cf4795-9e34-40aa-ea69-08dbb3790563 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jNtG2Al5PLy20QhDoMaDsTddn4fdJGRIR3B6IOpISu646NFFi3ndnnuHx8upQW9p99aE2hh+kvMofJljkj3izOIoN5EYw1kFBxXiOszfXoGFdXuSKZPB8YOWfdJEQWWXvM8GokljRz+grQJCdcxjlRHkZV6XZmRWnJRBN8rE+Ead4+xapQXd2q1/uQcJ1K97tWX9g/kl0avWcAevIrekmMPzk+W57pdEa1mRiCGbA9t6Vfmqd4X9cjt+R82t4A/XYrXHFgcghRGvNLyz3+K1y3BnYU9OHmclUIi5RfEwGHFsFioy/FraX/ycBKYqUOMxRZQ4pm07wMuwTA6pn4o9UCcxCwqoaJTCUCmRgmR9ydtaC9KLA7coWojG7vI24Awpthy/ObTnQx6vbI7VzXjSV9d+YVd/xAufTIE6500C/x499/7oF6ejgBmIR7krxPMugTwhxS1Rgn3oxbEJ0s0XDfoH2z4gtd3fhN/Glax6LWsGDvghgAuO8RoMSKhopEuqjm4nA0W26znLIOpq2FuCZXtVdxj87w72Cyy5v9Gm9v6N+8BcwrLfrkgJmxQWvBp7 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?MOhplam0Z++jpSjNsB3ttaLuw/6UPJ9KdEDZ64QBpwLJvz4rGuH0bzA66b?= =?iso-8859-1?Q?BUV58o8UsI+n9m+iE9kM48sAVrvIoW9vMTUEbKKYVguNe48fJOWauZ+zsu?= =?iso-8859-1?Q?bWIiOTYhYDsgskLKv5K2wEKw53XPH8La7EGvFG5CGLaQUvEcIXKtAY325x?= =?iso-8859-1?Q?VbcJ0EHLvHllK41lS84sqDntEgdMUBW4auTTTToGqEPoDdb2454yIMNnrB?= =?iso-8859-1?Q?M8ALe1dfWlbE/70tpVJVj7DWzyEEp65dZM/MJPz7fhcDP8wm1591iIQMmr?= =?iso-8859-1?Q?ZSGVjIX1MEpUwVefMbQd1g+6Qtm0UxYP2VUxOhZVOektrtz3nU3tc7M1Pl?= =?iso-8859-1?Q?xbE40tXHxN/kRQP3cWsqZRM3OGGCZNVY+A9BrjcFd0HILPuX7gzOOR9WyD?= =?iso-8859-1?Q?Jg1eXS95lHVllKynAhqdfAa7fwluBPk8tCmibeZoL4eKhDcQjo3mzSE0zp?= =?iso-8859-1?Q?hvnB4YnIAAemCtrQ3PHIYLGbWyb65vv/mW8DIWLP+OZdjs8Xs6EN/ftGvr?= =?iso-8859-1?Q?M3qkl6tkfU01nLioGh3P4KEfeKOIcoZ/HyWCMposMLTbCbpIQj9SR5+H4n?= =?iso-8859-1?Q?amPaNiFe+mrwpWg65V52VF6A+DK7cPPEVpd0aA+czPU1pPZ/JoWT2t+SaK?= =?iso-8859-1?Q?x1d3hfq3UpSzOJL8mry1tuFafXO+UBcoOuGYNK+GFnXPVf3qOjJNai/I7h?= =?iso-8859-1?Q?OCAyLtugnY1vnzadiCVJet4mHa7RGMEPXgpUagRqYuaOvMdFP/YVZTJqbm?= =?iso-8859-1?Q?R+CpTemXwtSKVhytqOXB0QoLZR+4GBHccVQXXcx4NQfn3a0z70JU40d61z?= =?iso-8859-1?Q?kyjRdiY9SkS/w/+McMXI7ZbDVdd0LJk3O8NP/2pUW03ZPNy6ctY42l9xs4?= =?iso-8859-1?Q?hI1Uk2/MDXQrlssOHlaWjfP7wz1vFq7ErFs7MqHRfyv6vOhheh6rvTwVYL?= =?iso-8859-1?Q?LQ5XUpZCyhK8qGLn2yasg3/PtQ7KCyfRQftvLEbEa91FRbRD5VIegIGSGW?= =?iso-8859-1?Q?Pd/lYVAlg/Q3BFFumFzcND83ciun6RnxmlLKpZ5/K5uBl7FTVsFgbwR36y?= =?iso-8859-1?Q?HhXUMduow6P12di1ruJDddKHTpyaDt28eEdT+ZF34wIV6c4x0DPIpUa+/p?= =?iso-8859-1?Q?aSU9LDXCgCnvrJGyZbWxrgROSo7vGJzOciKruOHDJHj7ScthxKhpIWH5GE?= =?iso-8859-1?Q?NYZ9XsRqLZpB9NEyU098a8qIYoGGSB5ZiZvdXkIsiP97aSaxf2MTVZiE?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7470.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 20cf4795-9e34-40aa-ea69-08dbb3790563 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2023 10:14:16.5883 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7973 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65700 Cc: "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > shynur:=0A= > My Emacs displays its runtime information like this:=0A= > =0A= > Since it's mainly related to GC, I have it updated after each GC.=0A= =0A= > Eli:=0A= > That's just causes off-by-one count of GC cycles, no? Easy enough=0A= > to fix.=0A= =0A= > Stefan:=0A= > the only difference is that `gcs-done` will be always smaller by 1=0A= =0A= We forgot the `gc-elapsed'. It's a little hard to fix (dirty work is=0A= needed).= From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 12 08:54:00 2023 Received: (at 65700) by debbugs.gnu.org; 12 Sep 2023 12:54:00 +0000 Received: from localhost ([127.0.0.1]:56445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg2u0-0003uw-C9 for submit@debbugs.gnu.org; Tue, 12 Sep 2023 08:54:00 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg2tv-0003uh-V8 for 65700@debbugs.gnu.org; Tue, 12 Sep 2023 08:53:58 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CBC4E8072D; Tue, 12 Sep 2023 08:53:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694523224; bh=U7lO1vD+eQJMPF2Zf9EIrb3cEtguikpxmB0v0gq4o+U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MF0S7mRVjs/lcDV48TndpRRYkImmJtsEE/lc2ZJvZ8CL4Kb4hneTz1OT5Gjp0YcT2 qOhA6ZXKU6EBjgolEHv/fT+GdydDxd6v2Q/5IUP6YWPD6P2lBYEOBsny78/skfWxAC 0ufaLz3RiH7X6pyXyFU5bmEKMSTiDPZ+40fesoVEOUdwmV3IXi8dL5EJHXIIVLycAi BHmkXf/ZTIGnX1WIYC6Bgb+fcgeiJkHAib7SLDf5OtVmtC+wzsXuSEfz5iextY8GZL REBDCJOD2Dkky5CUKLs2zlzOuUzWlYXgsx8ftjiN0R4m+ANSVwJfQZ5kuUXagNoVWg OLCeMYTK1/4lA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9018E804CF; Tue, 12 Sep 2023 08:53:44 -0400 (EDT) Received: from pastel (unknown [104.247.229.91]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 69C4512031C; Tue, 12 Sep 2023 08:53:44 -0400 (EDT) From: Stefan Monnier To: Shynur Xie Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified In-Reply-To: (Shynur Xie's message of "Tue, 12 Sep 2023 10:14:16 +0000") Message-ID: References: <83pm2uz6nv.fsf@gnu.org> <837cp2yr9l.fsf@gnu.org> Date: Tue, 12 Sep 2023 08:53:43 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.153 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65700 Cc: Eli Zaretskii , "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> My Emacs displays its runtime information like this: >> >> Since it's mainly related to GC, I have it updated after each GC. > >> Eli: >> That's just causes off-by-one count of GC cycles, no? Easy enough >> to fix. > >> Stefan: >> the only difference is that `gcs-done` will be always smaller by 1 > > We forgot the `gc-elapsed'. It's a little hard to fix (dirty work is > needed). Yup, for `gcs-done`, it doesn't matter very much, but with the current code `post-gc-hook` simply can't know how much time the last GC took, which can be a useful information there. I'll push my patch to `master` soon, I just need to clean it up first. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 12 14:07:39 2023 Received: (at 65700) by debbugs.gnu.org; 12 Sep 2023 18:07:39 +0000 Received: from localhost ([127.0.0.1]:59988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg7nX-0007cP-C7 for submit@debbugs.gnu.org; Tue, 12 Sep 2023 14:07:39 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg7nP-0007c0-UJ for 65700@debbugs.gnu.org; Tue, 12 Sep 2023 14:07:37 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 646C78072D; Tue, 12 Sep 2023 14:07:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694542040; bh=KUhNKe+B3/57aDjFmVMNLrnVpSmGRvuZwn6Kt67TZMg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Un9XACayFrhbGykGAptnm6kkHw+rQTQpl5LTG9Y98WUdxdfpZFW/WSMZ1Vn0+MdR4 UggT2Zk5ABFt7JUduDI1T6T2nd7g5dYSmdyC0wVN/4p5U3Lsug3P63gaF3LsL2PSt1 68fMyk1HEnYBQEoAcdj2/5oK+VX3Uo+tCIwHAdXlefJmqfAloxF34OrhDwX7qYogTH lb2aiIhqRdoJKTSdc6zwIsD0wLHP1qKgQAMwbaz2PLkWQIlguV4xfQ1qCetmK9Obg3 aRaIekgiI0CyRBHMSGt1brBXQaHjD0oePnFCBKGTElVERxiqH7KBpI79kN7vbDPn5F jXKBa7rNBwsyg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 43CAB804CF; Tue, 12 Sep 2023 14:07:20 -0400 (EDT) Received: from pastel (unknown [104.247.229.91]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1AE7C1201C6; Tue, 12 Sep 2023 14:07:20 -0400 (EDT) From: Stefan Monnier To: Shynur Xie Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified In-Reply-To: (Stefan Monnier's message of "Tue, 12 Sep 2023 08:53:43 -0400") Message-ID: References: <83pm2uz6nv.fsf@gnu.org> <837cp2yr9l.fsf@gnu.org> Date: Tue, 12 Sep 2023 14:07:19 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.143 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65700 Cc: Eli Zaretskii , "65700@debbugs.gnu.org" <65700@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I'll push my patch to `master` soon, I just need to clean it up first. Done, closing, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 12 14:08:01 2023 Received: (at control) by debbugs.gnu.org; 12 Sep 2023 18:08:01 +0000 Received: from localhost ([127.0.0.1]:59992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg7ns-0007cx-Nl for submit@debbugs.gnu.org; Tue, 12 Sep 2023 14:08:00 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg7nr-0007cl-Sd for control@debbugs.gnu.org; Tue, 12 Sep 2023 14:08:00 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BAA0C100106; Tue, 12 Sep 2023 14:07:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694542068; bh=mjuZnu8AwcuZl4ebS0ieASXB1jyPI9QtdQS8EuGp/Rg=; h=From:To:Subject:In-Reply-To:References:Date:From; b=VsTEhSNj7l3B3b9NvIwOg+QV5U/swdCOc14s1WLuCLMo5vsLvCV5bDLXV9t5trX7V G5RHx5/lbw9MEes7cQwelYkmkvXtbdgILA9ari2ao7GIknYFqQn/zCJxoZcRk2zYpf 2heB261WqSKg43MICH/QU5x42snxlQ4zX/elSzzTVUwp9FmdnWgK6WLEuc59X3kjC8 I+ITMY5dbA0KvTcHAYrpgHccmzKvSNcnOTik/Dc07MuK4zMm+KjbN0h3NWXjrA63PP nf7RXaV9O+j5W366fWjh/B9J2GniH5Z9o03udDGKMFHejdwtt1ORDkJs9jfKCo1Wp0 +25uQZrmWiFUA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CA45F1000A3; Tue, 12 Sep 2023 14:07:48 -0400 (EDT) Received: from pastel (unknown [104.247.229.91]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A93DD12022C; Tue, 12 Sep 2023 14:07:48 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#65700: time when gcs-done is updated needs to be clarified In-Reply-To: (Stefan Monnier's message of "Tue, 12 Sep 2023 08:53:43 -0400") Message-ID: References: <83pm2uz6nv.fsf@gnu.org> <837cp2yr9l.fsf@gnu.org> Date: Tue, 12 Sep 2023 14:07:48 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 65700 thanks From unknown Mon Jul 21 02:26:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 Oct 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator