GNU bug report logs - #65699
[PATCH gnome-team 0/7] Update Nautilus and Console

Previous Next

Package: guix-patches;

Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Date: Sat, 2 Sep 2023 12:04:02 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: rg <at> raghavgururajan.name, 65699 <at> debbugs.gnu.org
Subject: [bug#65699] [PATCH gnome-team 5/7] gnu: nautilus: Update to 44.2.
Date: Tue, 05 Sep 2023 21:06:10 -0400

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

[...]

>> The leading slash in search-input-file is unnecessary.
> I prefer it and search-input-file is explicitly coded to go both ways.

I value consistency, but no big deal.

>>   You can also use
>> '(format #f "~s" (search-input-file inputs "bin/tracker3"))', which
>> is shorter / more readable (?).
> I see string-append preferred in the code base, but I can do either. 
> How strongly do you feel I ought to use format?

I don't mind, both are easy to understand :-).

-- 
Thanks,
Maxim
This bug report was last modified 1 year and 289 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.