GNU bug report logs - #65673
[PATCH emacs 0/1] Add lua-ts-mode

Previous Next

Full log

Message #27 received at 65673 <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: john muhl <jm <at> pub.pink>, maurooaranda <at> gmail.com, 65673 <at> debbugs.gnu.org,
 ~emacs/emacs-devel <at> lists.sr.ht
Subject: Re: [PATCH] Add lua-ts-mode
Date: Sun, 10 Sep 2023 14:57:30 +0200

On Sun, 10 Sep 2023 at 11:12, Philip Kaludercic wrote:

> john muhl <jm <at> pub.pink> writes:
>> +(defcustom lua-ts-luacheck-program (executable-find "luacheck")
>
> It is better not to hard-code the path to lua during loading, in case
> the executable is moved around, since you will basically always still be
> querying PATH when starting a new process.
>
>> +  "Location of the Luacheck program."
>> +  :type '(choice (const nil) (file :must-match t))
>
> Which is why I think that this shouldn't be a file.
>> +(defcustom lua-ts-inferior-program (executable-find "lua")
>> +  "Program to run in the inferior Lua process."
>> +  :type '(choice (const nil) (file :must-match t))
>> +  :group 'lua
>> +  :version "30.1")
> Same here.

Good point, calling `executable-find' at this stage will also preclude
working over Tramp, among other potential issues.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.