From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 17:53:12 2023 Received: (at submit) by debbugs.gnu.org; 31 Aug 2023 21:53:12 +0000 Received: from localhost ([127.0.0.1]:59401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpbD-0007iz-ST for submit@debbugs.gnu.org; Thu, 31 Aug 2023 17:53:12 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpbB-0007iD-FH for submit@debbugs.gnu.org; Thu, 31 Aug 2023 17:53:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbpau-0001sY-0J for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 17:52:52 -0400 Received: from out-233.mta0.migadu.com ([2001:41d0:1004:224b::e9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbpaq-0003TA-Pc for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 17:52:51 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693518763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=inPsXs1WefkPJf9aoCpb+MxHAtkBVlxtSnx/ZU0ADJs=; b=epPXgZPFhPQj1ipDO0fXRrml/tCaGw+faPcgAqW7WLUeWWsUJvdiO9Oga/4C7iFlyUFNo+ KDxTtYBqaintqr60QKhNoa2IEPIzk96QsERp+WQkur3H4vDNqYowupdfnfeHaH99PfX5Xr cC6kD7WRxChOZ0pqZ1iAWshAX4MSprI= From: Joseph Turner To: Emacs Bugs Mailing List Subject: Lockfiles break package-vc-install-from-checkout Date: Thu, 31 Aug 2023 14:47:48 -0700 X-Debbugs-CC: Philip Kaludercic , Adam Porter Message-ID: <87edjiop5o.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::e9; envelope-from=joseph@breatheoutbreathe.in; helo=out-233.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) To reproduce: clone a repo, ensure that create-lockfiles is non-nil, edit a source file in the repo but do not save it, run package-vc-install-from-checkout on the repo. Backtrace: Debugger entered--Lisp error: (file-missing "/home/joseph/.emacs.d/elpa/hyperdrive/.#hyperdrive.el") comp-el-to-eln-filename("/home/joseph/.emacs.d/elpa/hyperdrive/.#hyperdrive.el") (comp-clean-up-stale-eln (comp-el-to-eln-filename file)) (while (consp --cl-var--) (setq file (car --cl-var--)) (comp-clean-up-stale-eln (comp-el-to-eln-filename file)) (setq --cl-var-- (cdr --cl-var--))) (let* ((--cl-var-- (directory-files-recursively dir "\\.el\\'")) (file nil)) (while (consp --cl-var--) (setq file (car --cl-var--)) (comp-clean-up-stale-eln (comp-el-to-eln-filename file)) (setq --cl-var-- (cdr --cl-var--))) nil) (progn (let* ((--cl-var-- (directory-files-recursively dir "\\.el\\'")) (file nil)) (while (consp --cl-var--) (setq file (car --cl-var--)) (comp-clean-up-stale-eln (comp-el-to-eln-filename file)) (setq --cl-var-- (cdr --cl-var--))) nil)) (if (featurep 'native-compile) (progn (let* ((--cl-var-- (directory-files-recursively dir "\\.el\\'")) (file nil)) (while (consp --cl-var--) (setq file (car --cl-var--)) (comp-clean-up-stale-eln (comp-el-to-eln-filename file)) (setq --cl-var-- (cdr --cl-var--))) nil))) package--delete-directory("/home/joseph/.emacs.d/elpa/hyperdrive") package-vc-install-from-checkout("~/.local/src/hyperdrive.el/" "hyperdrive") funcall-interactively(package-vc-install-from-checkout "~/.local/src/hyperdrive.el/" "hyperdrive") command-execute(package-vc-install-from-checkout record) execute-extended-command(nil "package-vc-install-from-checkout" nil) funcall-interactively(execute-extended-command nil "package-vc-install-from-checkout" nil) command-execute(execute-extended-command) From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 01:50:49 2023 Received: (at 65666) by debbugs.gnu.org; 1 Sep 2023 05:50:49 +0000 Received: from localhost ([127.0.0.1]:59705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbx3Q-0002nW-NH for submit@debbugs.gnu.org; Fri, 01 Sep 2023 01:50:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbx3M-0002nH-43 for 65666@debbugs.gnu.org; Fri, 01 Sep 2023 01:50:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbx36-000227-11; Fri, 01 Sep 2023 01:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ODo55iCf9VclqVRMqYtruMABs7LAK6YA9OgP+ztPS24=; b=XZ3FW0Iq5qpaOsUYe6/V yrecwq1G/6wFXaQO9qU3vWWubxYZqHZ1QMI9arfbt01zDI4lacgFxaoy/U4OZkb82ExAX2kZgTU0v loLZahsHih7YQle09NglJns75MQSf8ywadtKX6vMw2l/Mcl1vc/STRDFCf1IV2Z0UZ2MRGy6E7S2n 9qayFLFtm03kVXHwh14lVV0NY3EeTyxucU6wiPxcOqY7vaCzUleUYP56PJDFFN/FGx9/FOhhpLOXU 6AXlVPvJAZjgDhrhe5IpJqNZP5wvGJjnCmIJOSCljtiQ9ReXkCJFbA3quaqi3ndHq0kVg10XwcNq1 DYci2pWfo2VNpQ==; Date: Fri, 01 Sep 2023 08:50:07 +0300 Message-Id: <83edjicui8.fsf@gnu.org> From: Eli Zaretskii To: Joseph Turner In-Reply-To: <87edjiop5o.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org) Subject: Re: bug#65666: Lockfiles break package-vc-install-from-checkout References: <87edjiop5o.fsf@breatheoutbreathe.in> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65666 Cc: adam.porter@47ap.net, philipk@posteo.net, 65666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Philip Kaludercic , Adam Porter > Date: Thu, 31 Aug 2023 14:47:48 -0700 > From: Joseph Turner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > To reproduce: clone a repo, ensure that create-lockfiles is non-nil, > edit a source file in the repo but do not save it, run > package-vc-install-from-checkout on the repo. > > Backtrace: > > Debugger entered--Lisp error: (file-missing "/home/joseph/.emacs.d/elpa/hyperdrive/.#hyperdrive.el") > comp-el-to-eln-filename("/home/joseph/.emacs.d/elpa/hyperdrive/.#hyperdrive.el") We should not try to native-compile lock files, obviously. Some code naïvely uses "*.el" to find all the Lisp files; it should filter out lock files. P.S. Please always say in what version of Emacs you see the problem you report. Bonus points for including all of the information collected by report-emacs-bug about your system and Emacs configurations. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 02:19:02 2023 Received: (at 65666) by debbugs.gnu.org; 1 Sep 2023 06:19:02 +0000 Received: from localhost ([127.0.0.1]:59719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbxUk-0003Sk-6V for submit@debbugs.gnu.org; Fri, 01 Sep 2023 02:19:02 -0400 Received: from out-240.mta1.migadu.com ([95.215.58.240]:16703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbxUh-0003SU-PD for 65666@debbugs.gnu.org; Fri, 01 Sep 2023 02:19:01 -0400 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693549129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+eVWNBdZuwAAI8AcV7jTIEf6MfWVWOyvNGfXFGRLvz8=; b=NwLKEpslwPdnkJRp/VLdKYjJwdvSqSL1Jx6Caml6UeaOq/WVUqDMspi7xv47u0BEDGELBM hcED37c4Sl69IQI7IJhPE/2mMga2mRI1mKh0+gH9P/np1pNnYFGTIqxTdeEpR69HeLPjNk +dddVp/a7QX13yrIA7BliXmC3ziLIXc= Date: Fri, 01 Sep 2023 06:18:39 +0000 Content-Type: multipart/mixed; boundary="9f4866e4-6b49-4483-9da2-9a021ca57cfd-1" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: joseph@breatheoutbreathe.in Message-ID: TLS-Required: No Subject: Re: bug#65666: Lockfiles break package-vc-install-from-checkout To: "Eli Zaretskii" In-Reply-To: <83edjicui8.fsf@gnu.org> References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65666 Cc: adam.porter@47ap.net, philipk@posteo.net, 65666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --9f4866e4-6b49-4483-9da2-9a021ca57cfd-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: > We should not try to native-compile lock files, obviously. Some code > na=C3=AFvely uses "*.el" to find all the Lisp files; it should filter o= ut > lock files. Please see attached patch. > P.S. Please always say in what version of Emacs you see the problem > you report. Bonus points for including all of the information > collected by report-emacs-bug about your system and Emacs > configurations. Thanks - I'm on 29.0.92. I'll include that information next time. --9f4866e4-6b49-4483-9da2-9a021ca57cfd-1 Content-Type: text/x-diff; name="0001-Don-t-native-compile-lock-files.patch" Content-Disposition: attachment; filename="0001-Don-t-native-compile-lock-files.patch" Content-Transfer-Encoding: base64 RnJvbSA3YjM4YjBiZmQ4YzlkYTA4ZGFmNzM0ZjZkMDA2MmQzMWRkNTRiOTQ3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb3NlcGggVHVybmVyIDxqb3NlcGhAYnJlYXRoZW91 dGJyZWF0aGUuaW4+CkRhdGU6IFRodSwgMzEgQXVnIDIwMjMgMjM6MTE6NTMgLTA3MDAKU3Vi amVjdDogW1BBVENIXSBEb24ndCBuYXRpdmUgY29tcGlsZSBsb2NrIGZpbGVzCgoqIGxpc3Av ZW1hY3MtbGlzcC9wYWNrYWdlLmVsIChwYWNrYWdlLS1kZWxldGUtZGlyZWN0b3J5KToKQ2hl Y2sgdGhhdCBlYWNoIGZpbGUgZXhpc3RzIGJlZm9yZSBjb21waWxpbmcuCi0tLQogbGlzcC9l bWFjcy1saXNwL3BhY2thZ2UuZWwgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9l bWFjcy1saXNwL3BhY2thZ2UuZWwKaW5kZXggZTExNzJkNjliZjAuLjUyYTUzOGUwNjI3IDEw MDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbAorKysgYi9saXNwL2VtYWNz LWxpc3AvcGFja2FnZS5lbApAQCAtMjQ4NSw2ICsyNDg1LDcgQEAgY29tcGlsZWQuIgogICAo d2hlbiAoZmVhdHVyZXAgJ25hdGl2ZS1jb21waWxlKQogICAgIChjbC1sb29wCiAgICAgIGZv ciBmaWxlIGluIChkaXJlY3RvcnktZmlsZXMtcmVjdXJzaXZlbHkgZGlyICJcXC5lbFxcJyIp CisgICAgIHdoZW4gKGZpbGUtZXhpc3RzLXAgZmlsZSkKICAgICAgZG8gKGNvbXAtY2xlYW4t dXAtc3RhbGUtZWxuIChjb21wLWVsLXRvLWVsbi1maWxlbmFtZSBmaWxlKSkpKQogICAoaWYg KGZpbGUtc3ltbGluay1wIChkaXJlY3RvcnktZmlsZS1uYW1lIGRpcikpCiAgICAgICAoZGVs ZXRlLWZpbGUgKGRpcmVjdG9yeS1maWxlLW5hbWUgZGlyKSkKLS0gCjIuNDEuMAoK --9f4866e4-6b49-4483-9da2-9a021ca57cfd-1-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 08:52:44 2023 Received: (at 65666) by debbugs.gnu.org; 1 Sep 2023 12:52:44 +0000 Received: from localhost ([127.0.0.1]:60045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3dk-00027N-HB for submit@debbugs.gnu.org; Fri, 01 Sep 2023 08:52:44 -0400 Received: from mout01.posteo.de ([185.67.36.65]:60123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3di-00027A-CS for 65666@debbugs.gnu.org; Fri, 01 Sep 2023 08:52:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4F655240027 for <65666@debbugs.gnu.org>; Fri, 1 Sep 2023 14:52:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693572747; bh=Z7RrZ90d0OK8ACNxeEub438ccc1RYu031Kdu8qMwyeQ=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=cKeZfQdVHxXP8h0isMdTZ/Twl1m+VYvTgLpZ+5XaZ9iM0YVGSVSowRjkin9s+/Ova RSQBQOAk16xPb8sqTFxXj11KdpNHA63zyRyoaXB2R8+h3lXWURDYg6mZvcVo76799a oKyKMp+1DyNParagykU0TEVTed89sRMaP2o52yEi6+RAF58qYR07vPDZu3EKwWscmK h+FAyiKr47ddbw9ewe5YM8Nn/ae7mg/wZaAmXM7MEdoPqGmzz9I9yvu08lme5dfelr /7b65y4ahMqrgBBkIkijLABNowYqK7eFVM81umP/GZGcOW42G7j6qn53veKX7zB2+S uQdIeCp6JnmSw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RcdGf3f7dz9rxR; Fri, 1 Sep 2023 14:52:26 +0200 (CEST) From: Philip Kaludercic To: joseph@breatheoutbreathe.in Subject: Re: bug#65666: Lockfiles break package-vc-install-from-checkout In-Reply-To: (joseph@breatheoutbreathe.in's message of "Fri, 01 Sep 2023 06:18:39 +0000") References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 01 Sep 2023 12:52:24 +0000 Message-ID: <87o7imvywn.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65666 Cc: adam.porter@47ap.net, Eli Zaretskii , 65666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) joseph@breatheoutbreathe.in writes: > Eli Zaretskii writes: >> We should not try to native-compile lock files, obviously. Some code >> na=C3=AFvely uses "*.el" to find all the Lisp files; it should filter out >> lock files. > > Please see attached patch. > >> P.S. Please always say in what version of Emacs you see the problem >> you report. Bonus points for including all of the information >> collected by report-emacs-bug about your system and Emacs >> configurations. > > Thanks - I'm on 29.0.92. I'll include that information next time. > > From 7b38b0bfd8c9da08daf734f6d0062d31dd54b947 Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Thu, 31 Aug 2023 23:11:53 -0700 > Subject: [PATCH] Don't native compile lock files > > * lisp/emacs-lisp/package.el (package--delete-directory): > Check that each file exists before compiling. > --- > lisp/emacs-lisp/package.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index e1172d69bf0..52a538e0627 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -2485,6 +2485,7 @@ compiled." > (when (featurep 'native-compile) > (cl-loop > for file in (directory-files-recursively dir "\\.el\\'") > + when (file-exists-p file) > do (comp-clean-up-stale-eln (comp-el-to-eln-filename file)))) > (if (file-symlink-p (directory-file-name dir)) > (delete-file (directory-file-name dir)) LGTM, but I wonder if there is a better way to detect lockfiles specifically? If not, I can imagine that just using `file-exists-p' would a too broad check, in the sense that it could make it difficult to find other issues? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 19:46:32 2023 Received: (at 65666) by debbugs.gnu.org; 1 Sep 2023 23:46:32 +0000 Received: from localhost ([127.0.0.1]:34493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcDqR-00074p-Un for submit@debbugs.gnu.org; Fri, 01 Sep 2023 19:46:32 -0400 Received: from out-235.mta0.migadu.com ([2001:41d0:1004:224b::eb]:34095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcDqP-00074e-Un for 65666@debbugs.gnu.org; Fri, 01 Sep 2023 19:46:30 -0400 References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> <87o7imvywn.fsf@posteo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693611977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VooA+e3VoCumsY+Ac+mGm89OfYTv5lvjaQOZspcoZ7k=; b=g0Kd3lDYNM1nuKCLbNJR6Lz8+UUNZYMmBpeCVtpphGq3e0qrIcKgR3GmGAbmcoS5N/sjEV e7YISISkSkwcZZPpiKZkf5rSqc0cBBsBiIV0py8pVVIunHYWHahRm6WafxHEu4dS0UVkSA z4d5MkvJJgFz4js9VSg3892BA/RSJaw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Philip Kaludercic Subject: Re: bug#65666: Lockfiles break package-vc-install-from-checkout Date: Fri, 01 Sep 2023 16:43:27 -0700 In-reply-to: <87o7imvywn.fsf@posteo.net> Message-ID: <87ledpmp8f.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65666 Cc: adam.porter@47ap.net, Eli Zaretskii , 65666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > LGTM, but I wonder if there is a better way to detect lockfiles > specifically? If not, I can imagine that just using `file-exists-p' > would a too broad check, in the sense that it could make it difficult to > find other issues? We could use a regex like (unless (string-match-p (rx string-start ".#") file)) From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 03:50:09 2023 Received: (at 65666) by debbugs.gnu.org; 2 Sep 2023 07:50:09 +0000 Received: from localhost ([127.0.0.1]:35064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLOT-0004F3-0N for submit@debbugs.gnu.org; Sat, 02 Sep 2023 03:50:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLOQ-0004EN-Iu for 65666@debbugs.gnu.org; Sat, 02 Sep 2023 03:50:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcLOB-0004zP-26; Sat, 02 Sep 2023 03:49:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GfSBIsb5WlT9P6MAw6gXTBolSVPex/s0zH/YbfTqj4k=; b=TVSsUuOydGLq 29G/YoK8X4vvkNcyserDN7nLRIlHjh+GUnqgAc7+VaO/hlQChpdrrQ5ewTx+MLfw3SAzwtXzqStPq h/C82FTlEfcxCu84LvhWh+taZc9CwibMN0gN+VD9xtyKNiOa4dFKSuthsSUrdzgUXApTZ9okXPm9r S6dmDa/oQzDB2yiKA+cb/PvZo4oBOrOatCa8wUH3xDOBifzqVu6058rLQu9R4DI+c+2gwEdxCTAdE XSXDH1wdvSRlUd7H6GefJ6AlWm6FcaXBnAWCzEMFY1lhsQ07v//OvI+d+tjVFUyJjUU4W65vXJhrk ImWPda/2Wl8IL9TNxUSUiw==; Date: Sat, 02 Sep 2023 10:49:38 +0300 Message-Id: <83msy59fql.fsf@gnu.org> From: Eli Zaretskii To: Joseph Turner In-Reply-To: <87ledpmp8f.fsf@breatheoutbreathe.in> (message from Joseph Turner on Fri, 01 Sep 2023 16:43:27 -0700) Subject: Re: bug#65666: Lockfiles break package-vc-install-from-checkout References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> <87o7imvywn.fsf@posteo.net> <87ledpmp8f.fsf@breatheoutbreathe.in> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65666 Cc: adam.porter@47ap.net, philipk@posteo.net, 65666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Joseph Turner > Cc: Eli Zaretskii , 65666@debbugs.gnu.org, adam.porter@47ap.net > Date: Fri, 01 Sep 2023 16:43:27 -0700 > > > Philip Kaludercic writes: > > > LGTM, but I wonder if there is a better way to detect lockfiles > > specifically? If not, I can imagine that just using `file-exists-p' > > would a too broad check, in the sense that it could make it difficult to > > find other issues? > > We could use a regex like > > (unless (string-match-p (rx string-start ".#") file)) Or make the REGEXP argument to directory-files-recursively more specific, to reject lock files. But yes, the use of file-exists-p is not TRT, IMO. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 13:16:54 2023 Received: (at 65666) by debbugs.gnu.org; 2 Sep 2023 17:16:54 +0000 Received: from localhost ([127.0.0.1]:38532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcUEv-0005LS-Pu for submit@debbugs.gnu.org; Sat, 02 Sep 2023 13:16:54 -0400 Received: from out-239.mta1.migadu.com ([95.215.58.239]:52051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcUEp-0005LF-PS for 65666@debbugs.gnu.org; Sat, 02 Sep 2023 13:16:52 -0400 References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> <87o7imvywn.fsf@posteo.net> <87ledpmp8f.fsf@breatheoutbreathe.in> <83msy59fql.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693674996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8CQq47QCtvG1gskNMcWLV0FIFlk3bGq68iCiHh7ibks=; b=jJ7gAbRE2wIdQUd6o1ERrH+iTY0T/t1PDKss1ObzZr8TeavrwemVgtT725YyCucmxV8vN7 Ie+S01fCHt0ZAMOrY+FcVGr7dlrddBWFqxS24oWDwn1RxlqDQQO4J3OmlKV92qRZgPx/b2 VqoCNQaflJT09sWmaVtqRWh36Wlkag8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Eli Zaretskii Subject: Re: bug#65666: Lockfiles break package-vc-install-from-checkout Date: Sat, 02 Sep 2023 10:15:48 -0700 In-reply-to: <83msy59fql.fsf@gnu.org> Message-ID: <87cyz0mr6c.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65666 Cc: adam.porter@47ap.net, philipk@posteo.net, 65666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Or make the REGEXP argument to directory-files-recursively more > specific, to reject lock files. > > But yes, the use of file-exists-p is not TRT, IMO. See patch. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Don-t-native-compile-lock-files.patch >From 31ea77e547e333c8e216d759c1c26ad1fe6c4df0 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Sat, 2 Sep 2023 10:14:22 -0700 Subject: [PATCH] Don't native compile lock files * lisp/emacs-lisp/package.el (package--delete-directory): Exclude lock files in regex. --- lisp/emacs-lisp/package.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index e1172d69bf0..8bc7936a5bf 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2484,7 +2484,9 @@ Clean-up the corresponding .eln files if Emacs is native compiled." (when (featurep 'native-compile) (cl-loop - for file in (directory-files-recursively dir "\\.el\\'") + for file in (directory-files-recursively dir + ;; Exclude lockfiles + (rx bos (or (and "." (not "#")) (not ".")) (* nonl) ".el" eos)) do (comp-clean-up-stale-eln (comp-el-to-eln-filename file)))) (if (file-symlink-p (directory-file-name dir)) (delete-file (directory-file-name dir)) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 13:22:26 2023 Received: (at 65666) by debbugs.gnu.org; 2 Sep 2023 17:22:26 +0000 Received: from localhost ([127.0.0.1]:38558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcUKH-0005Uu-R4 for submit@debbugs.gnu.org; Sat, 02 Sep 2023 13:22:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcUKF-0005Uh-8z for 65666@debbugs.gnu.org; Sat, 02 Sep 2023 13:22:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcUK0-0005DY-03; Sat, 02 Sep 2023 13:22:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mVlXTRlXGbQ9Mi+p3o+vz0TmkQl8YwIJLP1dM5qS9HE=; b=I5kS+LRmR9MC /mHd4n73qx59ToDZL6in0nSyKqQOVMjfwnJ0QtMZV7mIigzn651OYEwKDBT71WtHO3QQdsNErNnv/ y0xcEXC2nE9Q0hoWY7KDppQtQezcgr/3ut1Ign7m55q1CnRlA9xSk77HtGScq1CFQBQVgGfKCyyny BSG9xL60eKFhmg22d6Tvz0Fw63HhnbuYbaB+F6KISzI3SpMmWHm3amyuFeKTRwVYH6fvnIYhiCAZ2 sMzCIHwd815ZT6WFi2hM2Eqr3QIfN525F7nQi4oVLujZu57YHevFGgWpRe4E383nPLvdOHQhXJL6G XitpGGEzAX1lgPJ1GNxwJA==; Date: Sat, 02 Sep 2023 20:21:56 +0300 Message-Id: <83zg248p8r.fsf@gnu.org> From: Eli Zaretskii To: Joseph Turner In-Reply-To: <87cyz0mr6c.fsf@breatheoutbreathe.in> (message from Joseph Turner on Sat, 02 Sep 2023 10:15:48 -0700) Subject: Re: bug#65666: Lockfiles break package-vc-install-from-checkout References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> <87o7imvywn.fsf@posteo.net> <87ledpmp8f.fsf@breatheoutbreathe.in> <83msy59fql.fsf@gnu.org> <87cyz0mr6c.fsf@breatheoutbreathe.in> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65666 Cc: adam.porter@47ap.net, philipk@posteo.net, 65666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Joseph Turner > Cc: philipk@posteo.net, 65666@debbugs.gnu.org, adam.porter@47ap.net > Date: Sat, 02 Sep 2023 10:15:48 -0700 > > Eli Zaretskii writes: > > Or make the REGEXP argument to directory-files-recursively more > > specific, to reject lock files. > > > > But yes, the use of file-exists-p is not TRT, IMO. > > See patch. Thanks, this LGTM. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 03:03:31 2023 Received: (at 65666-done) by debbugs.gnu.org; 3 Sep 2023 07:03:31 +0000 Received: from localhost ([127.0.0.1]:39135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qch8s-0000gs-VQ for submit@debbugs.gnu.org; Sun, 03 Sep 2023 03:03:31 -0400 Received: from mout01.posteo.de ([185.67.36.65]:49501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qch8p-0000gc-DQ for 65666-done@debbugs.gnu.org; Sun, 03 Sep 2023 03:03:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 50257240028 for <65666-done@debbugs.gnu.org>; Sun, 3 Sep 2023 09:03:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693724591; bh=TGhlOrlH56N7EkyiDe2/De9SPR+FvUVyeSE7ixTLcYs=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=BR6T3+gfTHI2JbHbvXuRM0rSqjqVM924dyAm9+ZUfsOp8qUoh/yDTTJQ0pcEbPckX k+PCTo1LtEHJGlIO4yl/HpADkGfcn9FGFjKkt0oQCVbn/OZOJIt7T151E9H4Rp8QdH zb5UonnOMa0813MwFGCYORwrGUp1qoo0m6+1ePsINOVFYdckxXO7foqMf+6PiWVKNM PVuhF7NZBzieILrDeTYp/Afecu/3Ze0PSVI/JjQfDeZsylUVBrzls7KlWY2Sfh8VqG ZJyqRUTaO8q/OR8LwKDN2RA5LnMXxJoCt9qlDsAD8N/hOeK8BxnaPgSYQhvrsN/LZB JYebspcGmJzwQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RdjQk5LnNz9rxD; Sun, 3 Sep 2023 09:03:10 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#65666: Lockfiles break package-vc-install-from-checkout In-Reply-To: <83zg248p8r.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Sep 2023 20:21:56 +0300") References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> <87o7imvywn.fsf@posteo.net> <87ledpmp8f.fsf@breatheoutbreathe.in> <83msy59fql.fsf@gnu.org> <87cyz0mr6c.fsf@breatheoutbreathe.in> <83zg248p8r.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 03 Sep 2023 07:03:09 +0000 Message-ID: <8734zv20ya.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65666-done Cc: adam.porter@47ap.net, 65666-done@debbugs.gnu.org, Joseph Turner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Joseph Turner >> Cc: philipk@posteo.net, 65666@debbugs.gnu.org, adam.porter@47ap.net >> Date: Sat, 02 Sep 2023 10:15:48 -0700 >> >> Eli Zaretskii writes: >> > Or make the REGEXP argument to directory-files-recursively more >> > specific, to reject lock files. >> > >> > But yes, the use of file-exists-p is not TRT, IMO. >> >> See patch. > > Thanks, this LGTM. Agree, I have pushed the change to master. From unknown Sat Aug 16 18:39:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 01 Oct 2023 11:24:25 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator