GNU bug report logs - #65661
[PATCH] gnu: ungoogle-chromium-wayland: Use gexp.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65661: closed ([PATCH] gnu: ungoogle-chromium-wayland: Use gexp.)
Date: Wed, 06 Sep 2023 00:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 05 Sep 2023 20:53:47 -0400
with message-id <875y4of7fo.fsf <at> gmail.com>
and subject line Re: bug#65661: [PATCH] gnu: ungoogle-chromium-wayland: Use gexp.
has caused the debbugs.gnu.org bug report #65661,
regarding [PATCH] gnu: ungoogle-chromium-wayland: Use gexp.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65661: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65661
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH] gnu: ungoogle-chromium-wayland: Use gexp.
Date: Thu, 31 Aug 2023 19:23:54 +0200

* gnu/packages/chromium.scm (ungoogle-chromium-wayland): Use gexp.
[arguments](builder): Use gexp.
[inputs]: Rewrite inputs.
---
 gnu/packages/chromium.scm | 60 +++++++++++++++++++--------------------
 1 file changed, 29 insertions(+), 31 deletions(-)

diff --git a/gnu/packages/chromium.scm b/gnu/packages/chromium.scm
index 6a9f113831..513e545938 100644
--- a/gnu/packages/chromium.scm
+++ b/gnu/packages/chromium.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2019-2023 Marius Bakke <marius <at> gnu.org>
 ;;; Copyright © 2019 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2023 Andreas Enge <andreas <at> enge.fr>
+;;; Copyright © 2023 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -966,42 +967,39 @@ (define-public ungoogled-chromium/wayland
     (name "ungoogled-chromium-wayland")
     (native-inputs '())
     (inputs
-     `(("bash" ,bash-minimal)
-       ("glibc-locales" ,glibc-utf8-locales)
-       ("ungoogled-chromium" ,ungoogled-chromium)))
+     (list bash-minimal glibc-utf8-locales ungoogled-chromium))
     (build-system trivial-build-system)
     (arguments
-     '(#:modules ((guix build utils))
-       #:builder
-       (begin
-         (use-modules (guix build utils))
-         (let* ((bash (assoc-ref %build-inputs "bash"))
-                (chromium (assoc-ref %build-inputs "ungoogled-chromium"))
-                (locales (assoc-ref %build-inputs "glibc-locales"))
-                (out (assoc-ref %outputs "out"))
-                (exe (string-append out "/bin/chromium")))
+     (list
+      #:modules '((guix build utils))
+      #:builder
+      #~(begin
+          (use-modules (guix build utils))
+          (let* ((bash #$(this-package-input "bash-minimal"))
+                 (chromium #$(this-package-input "ungoogled-chromium"))
+                 (locales #$(this-package-input "glibc-utf8-locales"))
+                 (exe (string-append #$output "/bin/chromium")))
 
-           ;; Use a Unicode locale so we can substitute the file below.
-           (setenv "GUIX_LOCPATH" (string-append locales "/lib/locale"))
-           (setlocale LC_ALL "en_US.utf8")
+            ;; Use a Unicode locale so we can substitute the file below.
+            (setenv "GUIX_LOCPATH" (string-append locales "/lib/locale"))
+            (setlocale LC_ALL "en_US.utf8")
 
-           (mkdir-p (dirname exe))
-           (symlink (string-append chromium "/bin/chromedriver")
-                    (string-append out "/bin/chromedriver"))
+            (mkdir-p (dirname exe))
+            (symlink (string-append chromium "/bin/chromedriver")
+                     (string-append #$output "/bin/chromedriver"))
 
-           (call-with-output-file exe
-             (lambda (port)
-               (format port "#!~a
+            (call-with-output-file exe
+              (lambda (port)
+                (format port "#!~a
 exec ~a --enable-features=UseOzonePlatform --ozone-platform=wayland \
 --enable-features=WebRTCPipeWireCapturer $@"
-                       (string-append bash "/bin/bash")
-                       (string-append chromium "/bin/chromium"))))
-           (chmod exe #o555)
+                        (string-append bash "/bin/bash")
+                        (string-append chromium "/bin/chromium"))))
+            (chmod exe #o555)
 
-           ;; Provide the manual and .desktop file.
-           (copy-recursively (string-append chromium "/share")
-                             (string-append out "/share"))
-           (substitute* (string-append
-                         out "/share/applications/chromium.desktop")
-             ((chromium) out))
-           #t))))))
+            ;; Provide the manual and .desktop file.
+            (copy-recursively (string-append chromium "/share")
+                              (string-append #$output "/share"))
+            (substitute* (string-append
+                          #$output "/share/applications/chromium.desktop")
+              ((chromium) #$output))))))))

base-commit: cf6abf50dbbbd95fef465ab4bb3b608843ac47e1
prerequisite-patch-id: cccdad83975cbf04d7bd618c2c1a4b4de6fa7fd2
prerequisite-patch-id: 6f28833d2efa054d55126980f87ba4d2fdd13c6d
prerequisite-patch-id: afc6cadece838372370f7093f863ce8eaae7bc55
prerequisite-patch-id: b9330c12700355319c104aa3b493eafe03cbb619
prerequisite-patch-id: 46fa9c5a48fcc5b13409049b14b6e7314a6d6956
prerequisite-patch-id: 846f8b50b8de749caaa459b874087d06e15e0a80
prerequisite-patch-id: 023101e5a315951ce9786fb8230955c97001dac9
prerequisite-patch-id: d4b0193f128d8236026e079e746ea0cf6c4c0af0
prerequisite-patch-id: d73442d6d7c88e7375e9de0a9cd655cacb7766f9
prerequisite-patch-id: d8a56dd7bc6c1c3ba3ac0f77b2402b9c6469cfb2
prerequisite-patch-id: 3bc2b2eecd799be8d8b0f96b850ef83a6306dab7
prerequisite-patch-id: 798d4a277eff03a59339af4ebe19406682f361ab
prerequisite-patch-id: 3f65e9cdab64edeacfeb5748cd4fb130839b2b30
prerequisite-patch-id: 6f8225b63a1dd1866b05bb91544e49d7c096601c
prerequisite-patch-id: ff71ec9bdf6337390a720db4535268af271e32df
prerequisite-patch-id: c6b40cc38f5bdfab229ac3d7ed4346c5d9f1b2f7
prerequisite-patch-id: 9ab6dade9e641d5e667ba6a61dbfbb3d32c943a6
prerequisite-patch-id: 4fcae29a8f6dd95716669680141da315acaf6e59
prerequisite-patch-id: 0a5a6da0061188dc9be59bc9829db53288307c58
prerequisite-patch-id: 83c4b7d9d831990e4d37ba89c584d773c872ba6b
prerequisite-patch-id: 1c8dddf99041cf399b8836e3ad6721d7bbcebb7c
prerequisite-patch-id: 773df13cc85606b205d1d914e59525b7a6820a1d
prerequisite-patch-id: 6f8974ce8c0a3a25721a41781f9b0dfd61e96cf4
prerequisite-patch-id: d219948d28923c5ccd34b63f988032df33f2f336
prerequisite-patch-id: 0bd75bb28df9ccf3405caf8217d708afc978047d
prerequisite-patch-id: 26476dd782cf8f5e427d4bd36ac85957538a0aa3
prerequisite-patch-id: b5f87c460fd984c41fbb52e7e0dc305c20c46f22
prerequisite-patch-id: 5502b9c6a64abaca6a9921f25cd324869d26aa1e
prerequisite-patch-id: a7e84bb368349566e9a6fdbe49a371fdb464bb1e
prerequisite-patch-id: a84a766ceef6bedd5da3f9512c87a2c2a11ff33f
prerequisite-patch-id: 0175b2b1cbbc15c1c775147821715bca9e3303a3
prerequisite-patch-id: 9c20b408ac8aa275ecba58383d83be5cef7647df
prerequisite-patch-id: 836749cd3bd3b86f64de637c3c2df48a3608f09f
prerequisite-patch-id: 28ea1ddbef32a1bc9e908f3f9c7466953c60f13d
prerequisite-patch-id: 52a78e387e36e6408d7147950195d552e4e41528
prerequisite-patch-id: 87fee01a70d4b8cbfca44cc0a9c9f54471a92d18
prerequisite-patch-id: 8c8cdb345e815fc3332805ca224103f185d4a568
prerequisite-patch-id: 3434c5caf1eba9e9a64c673681e5911d2c1d9232
prerequisite-patch-id: c45bf303726fb3dacee01a66c0ff75105a81164d
prerequisite-patch-id: d44a1adb0404f23522aac21fa8a7f26be7ddabdc
prerequisite-patch-id: e422fe29bbcef80260b190637faa1a4953c3f1cb
prerequisite-patch-id: 285479a1a1e46e6f0f8aba5429edfa400c81b32b
prerequisite-patch-id: 30fcff6f8c9328c71d3fca609cddde0b56973bb7
prerequisite-patch-id: 70bb47ccac3375de893e4e640ce7c59369a05a39
prerequisite-patch-id: cc3d79386ca4a93146dc195cd5732764f1ac447f
prerequisite-patch-id: 2686866ec4bf08c7faa05b17cb84d9e0c13ec12c
prerequisite-patch-id: 369b61e07e3c90151a5414b784513b9ae3d3e978
prerequisite-patch-id: 065651c3a8cee63b725d7f86c080c274b494627e
prerequisite-patch-id: 1ee71844f0c9a0112a456e5b76079239906a7fb8
prerequisite-patch-id: c7b3d9c5bff04c16576781eff50ce37f7c49131c
prerequisite-patch-id: c8b8fe8dc51fea0b8a2626cf7031f01b6000e023
prerequisite-patch-id: 182e25335d4c357001f4f8bed2b3f89b91d9cae5
prerequisite-patch-id: c0ea00d5f4c6a83642a92c9341f0288fbfe3095a
prerequisite-patch-id: 795d31cc33a24a6a57e67af31b65acd8faa8187c
prerequisite-patch-id: 358af8aa7fa71b5cb8fbe6dde29d141bb7c57f1e
prerequisite-patch-id: b9ab3ee98a9d4ca518a4d99042982d64fbce5d05
prerequisite-patch-id: eb618ab7b10483d917c308a38792af98baa517e2
prerequisite-patch-id: 40b6c9f09f27833367a71ec25d77afae4d2a835e
prerequisite-patch-id: 45e65ea00ece53f3496251401acd464081f8ca7a
prerequisite-patch-id: c12968d02d99c253f858586a86b16fa32d41f1c1
prerequisite-patch-id: 09d995d48139f8e61183d5634cda13a01cdb50f7
prerequisite-patch-id: 86baa45ec2aad977c8c8135f7613aa391155de6d
prerequisite-patch-id: 3425fbbff6a603d60b4e143ea2141aabf4ddc92c
prerequisite-patch-id: c373c01aab5dcba3503a97d51c62a595147a041c
prerequisite-patch-id: cda857c790b88c681c4e713c5f71e40291970daf
prerequisite-patch-id: c786776c23138d1f9b29aea86c3ba266a8fd61a3
prerequisite-patch-id: 48eda92adef9c867b3eda7e7209615f9721a65c1
prerequisite-patch-id: a0eca3c5fbca32478f478f784f0746eb34e7db77
prerequisite-patch-id: 8e234d0f4d93d2aad499eec8842be3d28da98707
prerequisite-patch-id: 5f664cb2fd995a53765c5ffc19a708ac795cc0c4
prerequisite-patch-id: ed447cba9cf9b7e1a1b47aa27acb14f8f2da0a8e
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 65661-done <at> debbugs.gnu.org
Subject: Re: bug#65661: [PATCH] gnu: ungoogle-chromium-wayland: Use gexp.
Date: Tue, 05 Sep 2023 20:53:47 -0400

Hi Nicolas,

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> * gnu/packages/chromium.scm (ungoogle-chromium-wayland): Use gexp.
> [arguments](builder): Use gexp.
> [inputs]: Rewrite inputs.

QA is happy; LGTM!

Installed.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.