GNU bug report logs - #65655
30.0.50; Minor oversights in integer->natnum :type change

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mauro Aranda <maurooaranda <at> gmail.com>
Subject: bug#65655: closed (Re: bug#65655: 30.0.50; Minor oversights in
 integer->natnum :type change)
Date: Fri, 01 Sep 2023 20:21:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65655: 30.0.50; Minor oversights in integer->natnum :type change

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65655 <at> debbugs.gnu.org.

-- 
65655: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65655
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 65655-done <at> debbugs.gnu.org
Subject: Re: bug#65655: 30.0.50;
 Minor oversights in integer->natnum :type change
Date: Fri, 1 Sep 2023 22:20:12 +0200

Version: 29.2

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> But the docstring of blink-cursor-blinks says:
> "Use 0 or negative value to blink forever."
> Now a negative value can't be used, so it would be good to adapt the
> docstring, at least.
>
> And the docstring of url-max-redirections says:
> "A negative number means to honor an unlimited number of redirection
> requests."
> I suggest to change its type back to integer.

Thanks for spotting these issues.

Fixed on emacs-29 in commit 60dcea7658a.

[Message part 3 (message/rfc822, inline)]

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Minor oversights in integer->natnum :type change
Date: Thu, 31 Aug 2023 07:52:01 -0300

The type of the following two options was changed from integer to natnum:
blink-cursor-blinks and url-max-redirections
as part of this commit:

commit 9d866a1f8da870dcf82f87d5ed9d5ca932d5477b
Author: Stefan Kangas <stefankangas <at> gmail.com>
Date:   Tue Jul 5 16:26:45 2022 +0200

    Make some defcustom types more restrictive


But the docstring of blink-cursor-blinks says:
"Use 0 or negative value to blink forever."
Now a negative value can't be used, so it would be good to adapt the
docstring, at least.

And the docstring of url-max-redirections says:
"A negative number means to honor an unlimited number of redirection
requests."
I suggest to change its type back to integer.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.