Subject: bug#65655: closed (Re: bug#65655: 30.0.50; Minor oversights in integer->natnum :type change)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 01 Sep 2023 20:21:01 +0000

Your bug report

#65655: 30.0.50; Minor oversights in integer->natnum :type change

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
65655: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65655
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#65655: 30.0.50; Minor oversights in integer->natnum :type change
From: Stefan Kangas <[email-masked]>
To: Mauro Aranda <[email-masked]>
Cc: [email-masked]
Date: Fri, 1 Sep 2023 22:20:12 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 29.2

Mauro Aranda <[email-masked]> writes:

> But the docstring of blink-cursor-blinks says:
> "Use 0 or negative value to blink forever."
> Now a negative value can't be used, so it would be good to adapt the
> docstring, at least.
>
> And the docstring of url-max-redirections says:
> "A negative number means to honor an unlimited number of redirection
> requests."
> I suggest to change its type back to integer.

Thanks for spotting these issues.

Fixed on emacs-29 in commit 60dcea7658a.

Subject: 30.0.50; Minor oversights in integer->natnum :type change
From: Mauro Aranda <[email-masked]>
To: [email-masked]
Date: Thu, 31 Aug 2023 07:52:01 -0300
List-Id: <debbugs-submit.debbugs.gnu.org>

The type of the following two options was changed from integer to natnum:
blink-cursor-blinks and url-max-redirections
as part of this commit:

commit 9d866a1f8da870dcf82f87d5ed9d5ca932d5477b
Author: Stefan Kangas <[email-masked]>
Date:   Tue Jul 5 16:26:45 2022 +0200

     Make some defcustom types more restrictive

But the docstring of blink-cursor-blinks says:
"Use 0 or negative value to blink forever."
Now a negative value can't be used, so it would be good to adapt the
docstring, at least.

And the docstring of url-max-redirections says:
"A negative number means to honor an unlimited number of redirection
requests."
I suggest to change its type back to integer.