GNU bug report logs - #65649
[PATCH] package-vc: Continue installing package when documentation build fails

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Subject: bug#65649: closed (Re: bug#65649: [PATCH] package-vc: Continue
 installing package when documentation build fails)
Date: Sun, 03 Sep 2023 07:01:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65649: [PATCH] package-vc: Continue installing package when documentation build fails

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65649 <at> debbugs.gnu.org.

-- 
65649: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65649
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: 65649-done <at> debbugs.gnu.org
Subject: Re: bug#65649: [PATCH] package-vc: Continue installing package when
 documentation build fails
Date: Sun, 03 Sep 2023 07:00:22 +0000

Joseph Turner <joseph <at> breatheoutbreathe.in> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> I think it would be better to wrap only the org code in the
>> `condition-case' body, ideally with a more specific error type (if that
>> doesn't exist, that is something we could mention to the Org
>> maintainers).
>
> The reason I wrapped both the org-export and makeinfo logic in
> condition-case is so that the makeinfo logic does not run when the
> org-export logic fails. Is there a better way?
>
> We could let-bind a flag like failed-org-export-p, then set it to t in
> the condition case handler, then only run makeinfo when
> failed-org-export-p is nil. Seems a bit ugly.

Oh right, never-mind then, I guess this is the simplest solution.

> The only define-error in org-mode that's relevant to org-export is not
> general enough:
>
> (define-error 'org-link-broken "Unable to resolve link; aborting")

Then this should be fine.  I'll apply the changes the master.  Thanks.

[Message part 3 (message/rfc822, inline)]

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: bug-gnu-emacs <at> gnu.org
Cc: Philip Kaludercic <philipk <at> posteo.net>
Subject: [PATCH] package-vc: Continue installing package when documentation
 build fails
Date: Wed, 30 Aug 2023 23:26:35 -0700

[Message part 4 (text/plain, inline)]

In light of the recent fix regarding building documentation from
org-mode files, I think it makes sense to ensure that installation
continues even without documentation.

Joseph

[0001-Continue-installing-package-when-documentation-build.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.