From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 06:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 65649@debbugs.gnu.org Cc: Philip Kaludercic X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169346337314808 (code B ref -1); Thu, 31 Aug 2023 06:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 Aug 2023 06:29:33 +0000 Received: from localhost ([127.0.0.1]:54674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbBM-0003qm-Cp for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:29:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbBK-0003qX-MG for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbB5-0005ex-MN for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 02:29:15 -0400 Received: from out-251.mta0.migadu.com ([91.218.175.251]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbB1-0000hF-1e for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 02:29:15 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693463348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=51NWULcRjBrXXXnIDByi3nlsQ2QsS5FGB6ONzjBWZLQ=; b=gHH5sGs+WiNBg464WDqc67NX6qNMEaMOyhoJuqoH7qzSJWjMER8OXXlzQTqvk6cpV04Wuy ZN6ISXuN+J2YzoTqRGEeXaaxrNvK5xtfE2MlRHttNv8xprd95s6BFk7TA4FzCK3Zn9PSgT Jkdr4tYUJlOsXFOrVRNXTriudyl/aVQ= From: Joseph Turner Date: Wed, 30 Aug 2023 23:26:35 -0700 Message-ID: <87v8cvvi6r.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.251; envelope-from=joseph@breatheoutbreathe.in; helo=out-251.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain In light of the recent fix regarding building documentation from org-mode files, I think it makes sense to ensure that installation continues even without documentation. Joseph --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Continue-installing-package-when-documentation-build.patch >From 83c62d80b5199cee911e30c1f3bb03c5a585b689 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Wed, 30 Aug 2023 23:24:16 -0700 Subject: [PATCH] Continue installing package when documentation building fails * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): Demote errors to messages. --- lisp/emacs-lisp/package-vc.el | 61 ++++++++++++++++++----------------- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 747fe696204..bc1200c583f 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -409,36 +409,37 @@ prepared." "Build documentation for package PKG-DESC from documentation source in FILE. FILE can be an Org file, indicated by its \".org\" extension, otherwise it's assumed to be an Info file." - (let* ((pkg-name (package-desc-name pkg-desc)) - (default-directory (package-desc-dir pkg-desc)) - (docs-directory (file-name-directory (expand-file-name file))) - (output (expand-file-name (format "%s.info" pkg-name))) - clean-up) - (when (string-match-p "\\.org\\'" file) - (require 'ox) - (require 'ox-texinfo) - (with-temp-buffer - (insert-file-contents file) - (setq file (make-temp-file "ox-texinfo-")) - (let ((default-directory docs-directory)) - (org-export-to-file 'texinfo file)) - (setq clean-up t))) - (with-current-buffer (get-buffer-create " *package-vc doc*") - (erase-buffer) - (cond - ((/= 0 (call-process "makeinfo" nil t nil - "-I" docs-directory - "--no-split" file - "-o" output)) - (message "Failed to build manual %s, see buffer %S" - file (buffer-name))) - ((/= 0 (call-process "install-info" nil t nil - output (expand-file-name "dir"))) - (message "Failed to install manual %s, see buffer %S" - output (buffer-name))) - ((kill-buffer)))) - (when clean-up - (delete-file file)))) + (with-demoted-errors "package-vc: Could not build documentation: %s" + (let* ((pkg-name (package-desc-name pkg-desc)) + (default-directory (package-desc-dir pkg-desc)) + (docs-directory (file-name-directory (expand-file-name file))) + (output (expand-file-name (format "%s.info" pkg-name))) + clean-up) + (when (string-match-p "\\.org\\'" file) + (require 'ox) + (require 'ox-texinfo) + (with-temp-buffer + (insert-file-contents file) + (setq file (make-temp-file "ox-texinfo-")) + (let ((default-directory docs-directory)) + (org-export-to-file 'texinfo file)) + (setq clean-up t))) + (with-current-buffer (get-buffer-create " *package-vc doc*") + (erase-buffer) + (cond + ((/= 0 (call-process "makeinfo" nil t nil + "-I" docs-directory + "--no-split" file + "-o" output)) + (message "Failed to build manual %s, see buffer %S" + file (buffer-name))) + ((/= 0 (call-process "install-info" nil t nil + output (expand-file-name "dir"))) + (message "Failed to install manual %s, see buffer %S" + output (buffer-name))) + ((kill-buffer)))) + (when clean-up + (delete-file file))))) (defun package-vc-install-dependencies (deps) "Install missing dependencies according to DEPS. -- 2.41.0 --=-=-=-- From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 06:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 65649@debbugs.gnu.org, philipk@posteo.net X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Philip Kaludercic Received: via spool by submit@debbugs.gnu.org id=B.169346365915386 (code B ref -1); Thu, 31 Aug 2023 06:35:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Aug 2023 06:34:19 +0000 Received: from localhost ([127.0.0.1]:54684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbFy-000405-Ot for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:34:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbFu-0003zq-3f for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:34:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbFg-0000mY-Js for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 02:34:00 -0400 Received: from out-244.mta0.migadu.com ([2001:41d0:1004:224b::f4]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbFe-0001xA-1r for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 02:34:00 -0400 References: <87v8cvvi6r.fsf@breatheoutbreathe.in> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693463635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J7pEvZMFg0SHjX/bOXopgt6Dzt3jyXkR4S2VyETb5QA=; b=U5OXhOwC8rIe7isN/oUu2NDzc8TTu7zlqBiU4VKcknq2et+B4CIpZEOhlkE+eVMGj4ujf5 jWS7JWg6jxyyxkyyxxQvtwcfW3VY5G/iI4WF7YYoMDc943stKMu9+GHLEnCjeF1z3oP/kZ CYIqSv8mtue+1Fw3/mGAYgnjDONr89s= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner Date: Wed, 30 Aug 2023 23:32:42 -0700 In-reply-to: <87v8cvvi6r.fsf@breatheoutbreathe.in> Message-ID: <87r0njvhyo.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::f4; envelope-from=joseph@breatheoutbreathe.in; helo=out-244.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Oops, the format string should be %S, not %s. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Continue-installing-package-when-documentation-build.patch >From 83c62d80b5199cee911e30c1f3bb03c5a585b689 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Wed, 30 Aug 2023 23:24:16 -0700 Subject: [PATCH] Continue installing package when documentation building fails * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): Demote errors to messages. --- lisp/emacs-lisp/package-vc.el | 61 ++++++++++++++++++----------------- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 747fe696204..bc1200c583f 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -409,36 +409,37 @@ prepared." "Build documentation for package PKG-DESC from documentation source in FILE. FILE can be an Org file, indicated by its \".org\" extension, otherwise it's assumed to be an Info file." - (let* ((pkg-name (package-desc-name pkg-desc)) - (default-directory (package-desc-dir pkg-desc)) - (docs-directory (file-name-directory (expand-file-name file))) - (output (expand-file-name (format "%s.info" pkg-name))) - clean-up) - (when (string-match-p "\\.org\\'" file) - (require 'ox) - (require 'ox-texinfo) - (with-temp-buffer - (insert-file-contents file) - (setq file (make-temp-file "ox-texinfo-")) - (let ((default-directory docs-directory)) - (org-export-to-file 'texinfo file)) - (setq clean-up t))) - (with-current-buffer (get-buffer-create " *package-vc doc*") - (erase-buffer) - (cond - ((/= 0 (call-process "makeinfo" nil t nil - "-I" docs-directory - "--no-split" file - "-o" output)) - (message "Failed to build manual %s, see buffer %S" - file (buffer-name))) - ((/= 0 (call-process "install-info" nil t nil - output (expand-file-name "dir"))) - (message "Failed to install manual %s, see buffer %S" - output (buffer-name))) - ((kill-buffer)))) - (when clean-up - (delete-file file)))) + (with-demoted-errors "package-vc: Could not build documentation: %S" + (let* ((pkg-name (package-desc-name pkg-desc)) + (default-directory (package-desc-dir pkg-desc)) + (docs-directory (file-name-directory (expand-file-name file))) + (output (expand-file-name (format "%s.info" pkg-name))) + clean-up) + (when (string-match-p "\\.org\\'" file) + (require 'ox) + (require 'ox-texinfo) + (with-temp-buffer + (insert-file-contents file) + (setq file (make-temp-file "ox-texinfo-")) + (let ((default-directory docs-directory)) + (org-export-to-file 'texinfo file)) + (setq clean-up t))) + (with-current-buffer (get-buffer-create " *package-vc doc*") + (erase-buffer) + (cond + ((/= 0 (call-process "makeinfo" nil t nil + "-I" docs-directory + "--no-split" file + "-o" output)) + (message "Failed to build manual %s, see buffer %S" + file (buffer-name))) + ((/= 0 (call-process "install-info" nil t nil + output (expand-file-name "dir"))) + (message "Failed to install manual %s, see buffer %S" + output (buffer-name))) + ((kill-buffer)))) + (when clean-up + (delete-file file))))) (defun package-vc-install-dependencies (deps) "Install missing dependencies according to DEPS. -- 2.41.0 --=-=-=-- From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 65649@debbugs.gnu.org, philipk@posteo.net X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Philip Kaludercic Received: via spool by submit@debbugs.gnu.org id=B.169346380515620 (code B ref -1); Thu, 31 Aug 2023 06:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 Aug 2023 06:36:45 +0000 Received: from localhost ([127.0.0.1]:54694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbIL-00043s-7Y for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:36:45 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbII-00043d-V6 for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:36:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbI4-00010u-O8 for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 02:36:28 -0400 Received: from out-248.mta0.migadu.com ([91.218.175.248]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbI2-0002Wt-2K for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 02:36:28 -0400 References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693463783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mcAf8GwcyQ7VVjQcZrAD7ukrARPNhyaLSUpzujIN/w4=; b=eV14KKjP4B447wrE+3kgGamCAVrYeEeGMn0KV3H9d7e0pXkWb/R9Z2mvS4+rL67Bbz6F/m UMt3Py8fOZQu/5/ebH222wl3w8jo+/sJ1maDXl/fg7u65OTQ/0+zcnr1imFiTgu0oTuYbr POHRDkQ4pH+XOB+Jdf6s94eI59V7bmc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner Date: Wed, 30 Aug 2023 23:34:29 -0700 In-reply-to: <87r0njvhyo.fsf@breatheoutbreathe.in> Message-ID: <87msy7vhum.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.248; envelope-from=joseph@breatheoutbreathe.in; helo=out-248.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) It would be nice to report more information about the package with failed documentation, but AFAICT with-demoted-errors does not allow its FORMAT string to be a symbol whose value is a string. Joseph Turner writes: > Oops, the format string should be %S, not %s. > > [2. text/x-diff; 0001-Continue-installing-package-when-documentation-build.patch] > From 83c62d80b5199cee911e30c1f3bb03c5a585b689 Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Wed, 30 Aug 2023 23:24:16 -0700 > Subject: [PATCH] Continue installing package when documentation building fails > > * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): > Demote errors to messages. > --- > lisp/emacs-lisp/package-vc.el | 61 ++++++++++++++++++----------------- > 1 file changed, 31 insertions(+), 30 deletions(-) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index 747fe696204..bc1200c583f 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -409,36 +409,37 @@ prepared." > "Build documentation for package PKG-DESC from documentation source in FILE. > FILE can be an Org file, indicated by its \".org\" extension, > otherwise it's assumed to be an Info file." > - (let* ((pkg-name (package-desc-name pkg-desc)) > - (default-directory (package-desc-dir pkg-desc)) > - (docs-directory (file-name-directory (expand-file-name file))) > - (output (expand-file-name (format "%s.info" pkg-name))) > - clean-up) > - (when (string-match-p "\\.org\\'" file) > - (require 'ox) > - (require 'ox-texinfo) > - (with-temp-buffer > - (insert-file-contents file) > - (setq file (make-temp-file "ox-texinfo-")) > - (let ((default-directory docs-directory)) > - (org-export-to-file 'texinfo file)) > - (setq clean-up t))) > - (with-current-buffer (get-buffer-create " *package-vc doc*") > - (erase-buffer) > - (cond > - ((/= 0 (call-process "makeinfo" nil t nil > - "-I" docs-directory > - "--no-split" file > - "-o" output)) > - (message "Failed to build manual %s, see buffer %S" > - file (buffer-name))) > - ((/= 0 (call-process "install-info" nil t nil > - output (expand-file-name "dir"))) > - (message "Failed to install manual %s, see buffer %S" > - output (buffer-name))) > - ((kill-buffer)))) > - (when clean-up > - (delete-file file)))) > + (with-demoted-errors "package-vc: Could not build documentation: %S" > + (let* ((pkg-name (package-desc-name pkg-desc)) > + (default-directory (package-desc-dir pkg-desc)) > + (docs-directory (file-name-directory (expand-file-name file))) > + (output (expand-file-name (format "%s.info" pkg-name))) > + clean-up) > + (when (string-match-p "\\.org\\'" file) > + (require 'ox) > + (require 'ox-texinfo) > + (with-temp-buffer > + (insert-file-contents file) > + (setq file (make-temp-file "ox-texinfo-")) > + (let ((default-directory docs-directory)) > + (org-export-to-file 'texinfo file)) > + (setq clean-up t))) > + (with-current-buffer (get-buffer-create " *package-vc doc*") > + (erase-buffer) > + (cond > + ((/= 0 (call-process "makeinfo" nil t nil > + "-I" docs-directory > + "--no-split" file > + "-o" output)) > + (message "Failed to build manual %s, see buffer %S" > + file (buffer-name))) > + ((/= 0 (call-process "install-info" nil t nil > + output (expand-file-name "dir"))) > + (message "Failed to install manual %s, see buffer %S" > + output (buffer-name))) > + ((kill-buffer)))) > + (when clean-up > + (delete-file file))))) > > (defun package-vc-install-dependencies (deps) > "Install missing dependencies according to DEPS. From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Joseph Turner Cc: 65649@debbugs.gnu.org, philipk@posteo.net Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169346466717309 (code B ref 65649); Thu, 31 Aug 2023 06:52:02 +0000 Received: (at 65649) by debbugs.gnu.org; 31 Aug 2023 06:51:07 +0000 Received: from localhost ([127.0.0.1]:54721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbWF-0004V7-1O for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:51:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbWC-0004Ub-6V for 65649@debbugs.gnu.org; Thu, 31 Aug 2023 02:51:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbVw-0005PZ-UU; Thu, 31 Aug 2023 02:50:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XejmKvD9TMLABIyFoN4SQtig628J5QcYCHHnsP3qR0s=; b=adiOn7A5Mkht DnRiJ1rCz9KFxdqnBG481R4dZvxW0Ojpv9iT9sdtui17OFNBLjEZRWPR2HAr7VOKZpNZs/8UvEXFQ fE/z6Q5EWp4t7Xro8xv/gHUVqRicxb72YDBM11ifBlq4YEChTeLBO8gMCSNSCKD0mmlcpIS+2D9AV WiGhpia1Rfv2TzI7oRwtjthTwo7TrT7w5b1L9DN6e8kjjB8GEJCj27caJMNViZZsA5mAOjcXSCeDb wpShSitWMZnjq4OWii9NS9w3Bq2B6sbTt09exYg8B+PuZY8sJci1eat60dTdopa/k9ta4X8viaWXI PvPFduSGF9IFuaaWVHrB5A==; Date: Thu, 31 Aug 2023 09:50:31 +0300 Message-Id: <83y1hremdk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87v8cvvi6r.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org) References: <87v8cvvi6r.fsf@breatheoutbreathe.in> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Philip Kaludercic > Date: Wed, 30 Aug 2023 23:26:35 -0700 > From: Joseph Turner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > In light of the recent fix regarding building documentation from > org-mode files, I think it makes sense to ensure that installation > continues even without documentation. I don't think we should do this silently. The user should be asked to confirm, at the very least. From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 07:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Joseph Turner Cc: 65649@debbugs.gnu.org Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169346630029958 (code B ref 65649); Thu, 31 Aug 2023 07:19:02 +0000 Received: (at 65649) by debbugs.gnu.org; 31 Aug 2023 07:18:20 +0000 Received: from localhost ([127.0.0.1]:54756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbwZ-0007n7-Vy for submit@debbugs.gnu.org; Thu, 31 Aug 2023 03:18:20 -0400 Received: from mout01.posteo.de ([185.67.36.65]:45127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbwW-0007mt-UK for 65649@debbugs.gnu.org; Thu, 31 Aug 2023 03:18:18 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 54B55240027 for <65649@debbugs.gnu.org>; Thu, 31 Aug 2023 09:18:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693466282; bh=DD6fHDGiDPC1U3ZBU8BTc43gR2yTXKAHa7SviVXYjkU=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=r0CpspR/VLKsIKFdaoN9O96iPP3irNxvalebyQruIN4PUJvcQmE1rneont6sR+erm Xt00Ok7sxbHYvILOzUGAXkpBCBwLOmI0Gn53XrrZ+/UQ84ak34AR/lSD46XVxj4X6R 74LnScAB8na0cFJaj/g5iVdaI8BoEZls5JzIOK8uCHMfA+YHXvNEpoBlaO0YeIDuLE vYdsHo4iCMnmlsQRKR2E3QQcbREfZp/K5aUB6BDCNib/hrN3VXkhjAEaJmRWECaC3l BnHt2iWc//odCLnJVLP9QlsU4tDH8Mlbthdu7f0q6/FMlYlyCu/An7WCHZ1Q9pbNgD K/OEM65e5AisA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RbsvF4mvWz9rxT; Thu, 31 Aug 2023 09:18:01 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <87msy7vhum.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Wed, 30 Aug 2023 23:34:29 -0700") References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Thu, 31 Aug 2023 07:18:01 +0000 Message-ID: <87pm33r87q.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Btw, watch out when reporting a bug, you shouldn't CC people directly, but add a X-Debbugs-CC header (https://debbugs.gnu.org/Reporting.html#xcc), as otherwise I'd be creating a new bug report when responding to your message. Joseph Turner writes: > It would be nice to report more information about the package with failed > documentation, but AFAICT with-demoted-errors does not allow its FORMAT > string to be a symbol whose value is a string. What are the main errors we are concerned with? I am a bit concerned that `with-demoted-errors' is a too coarse approach and might be applied to widely in your current patch. It might be better to use a classical condition-case and handle the right errors in the right place, or if practicable try to detect if an error would occur before doing anything. Also, the buffer *package-vc doc* should stay persistent and would include error messages, that could also be used here. > Joseph Turner writes: > >> Oops, the format string should be %S, not %s. >> >> [2. text/x-diff; 0001-Continue-installing-package-when-documentation-build.patch] >> From 83c62d80b5199cee911e30c1f3bb03c5a585b689 Mon Sep 17 00:00:00 2001 >> From: Joseph Turner >> Date: Wed, 30 Aug 2023 23:24:16 -0700 >> Subject: [PATCH] Continue installing package when documentation building fails >> >> * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): >> Demote errors to messages. >> --- >> lisp/emacs-lisp/package-vc.el | 61 ++++++++++++++++++----------------- >> 1 file changed, 31 insertions(+), 30 deletions(-) >> >> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >> index 747fe696204..bc1200c583f 100644 >> --- a/lisp/emacs-lisp/package-vc.el >> +++ b/lisp/emacs-lisp/package-vc.el >> @@ -409,36 +409,37 @@ prepared." >> "Build documentation for package PKG-DESC from documentation source in FILE. >> FILE can be an Org file, indicated by its \".org\" extension, >> otherwise it's assumed to be an Info file." >> - (let* ((pkg-name (package-desc-name pkg-desc)) >> - (default-directory (package-desc-dir pkg-desc)) >> - (docs-directory (file-name-directory (expand-file-name file))) >> - (output (expand-file-name (format "%s.info" pkg-name))) >> - clean-up) >> - (when (string-match-p "\\.org\\'" file) >> - (require 'ox) >> - (require 'ox-texinfo) >> - (with-temp-buffer >> - (insert-file-contents file) >> - (setq file (make-temp-file "ox-texinfo-")) >> - (let ((default-directory docs-directory)) >> - (org-export-to-file 'texinfo file)) >> - (setq clean-up t))) >> - (with-current-buffer (get-buffer-create " *package-vc doc*") >> - (erase-buffer) >> - (cond >> - ((/= 0 (call-process "makeinfo" nil t nil >> - "-I" docs-directory >> - "--no-split" file >> - "-o" output)) >> - (message "Failed to build manual %s, see buffer %S" >> - file (buffer-name))) >> - ((/= 0 (call-process "install-info" nil t nil >> - output (expand-file-name "dir"))) >> - (message "Failed to install manual %s, see buffer %S" >> - output (buffer-name))) >> - ((kill-buffer)))) >> - (when clean-up >> - (delete-file file)))) >> + (with-demoted-errors "package-vc: Could not build documentation: %S" >> + (let* ((pkg-name (package-desc-name pkg-desc)) >> + (default-directory (package-desc-dir pkg-desc)) >> + (docs-directory (file-name-directory (expand-file-name file))) >> + (output (expand-file-name (format "%s.info" pkg-name))) >> + clean-up) >> + (when (string-match-p "\\.org\\'" file) >> + (require 'ox) >> + (require 'ox-texinfo) >> + (with-temp-buffer >> + (insert-file-contents file) >> + (setq file (make-temp-file "ox-texinfo-")) >> + (let ((default-directory docs-directory)) >> + (org-export-to-file 'texinfo file)) >> + (setq clean-up t))) >> + (with-current-buffer (get-buffer-create " *package-vc doc*") >> + (erase-buffer) >> + (cond >> + ((/= 0 (call-process "makeinfo" nil t nil >> + "-I" docs-directory >> + "--no-split" file >> + "-o" output)) >> + (message "Failed to build manual %s, see buffer %S" >> + file (buffer-name))) >> + ((/= 0 (call-process "install-info" nil t nil >> + output (expand-file-name "dir"))) >> + (message "Failed to install manual %s, see buffer %S" >> + output (buffer-name))) >> + ((kill-buffer)))) >> + (when clean-up >> + (delete-file file))))) >> >> (defun package-vc-install-dependencies (deps) >> "Install missing dependencies according to DEPS. From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 21:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 65649@debbugs.gnu.org Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169351733426803 (code B ref 65649); Thu, 31 Aug 2023 21:29:02 +0000 Received: (at 65649) by debbugs.gnu.org; 31 Aug 2023 21:28:54 +0000 Received: from localhost ([127.0.0.1]:59375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpDi-0006yF-2m for submit@debbugs.gnu.org; Thu, 31 Aug 2023 17:28:54 -0400 Received: from out-239.mta1.migadu.com ([2001:41d0:203:375::ef]:58116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpDf-0006y5-B2 for 65649@debbugs.gnu.org; Thu, 31 Aug 2023 17:28:52 -0400 References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693517320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ug0MTXUKtMvPXGjOi1KvJH78/0224Ngm6G8VIknQ//M=; b=jtYbKl/2ZnR6zwNDxa0RJ3p7DpdwhUDpBMOQqQQnQIK4e0WMQr3GWczskqlfZwLM27hd2d pZzj8dr9f+OHcg2n909+w39faAOc8IEiw1QtdUD6Klltkap0HfBp7ck3W0hMC4efcCuHnU +jG4VhPHS/cpquBjd3uVBD4hSKW99ek= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner Date: Thu, 31 Aug 2023 14:19:11 -0700 In-reply-to: <87pm33r87q.fsf@posteo.net> Message-ID: <87sf7yoq9p.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > Btw, watch out when reporting a bug, you shouldn't CC people directly, > but add a X-Debbugs-CC header > (https://debbugs.gnu.org/Reporting.html#xcc), as otherwise I'd be > creating a new bug report when responding to your message. Good to know! Thank you! Is it okay to CC people when responding to a bug report email (e.g. if I CC'd Eli in this email)? > Joseph Turner writes: > >> It would be nice to report more information about the package with failed >> documentation, but AFAICT with-demoted-errors does not allow its FORMAT >> string to be a symbol whose value is a string. > > What are the main errors we are concerned with? I am a bit concerned > that `with-demoted-errors' is a too coarse approach and might be applied > to widely in your current patch. It might be better to use a classical > condition-case and handle the right errors in the right place, or if > practicable try to detect if an error would occur before doing anything. I don't know what kinds of errors to expect, which is why I went with the coarse approach. Under what circumstances would we want to stop package installation entirely when documentation can't be built? > Also, the buffer *package-vc doc* should stay persistent and would > include error messages, that could also be used here. Like this? (with-demoted-errors "package-vc: Could not build documentation. See *package-vc doc* for details" ... ) From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 21:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic , 65649@debbugs.gnu.org Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169351807928218 (code B ref 65649); Thu, 31 Aug 2023 21:42:01 +0000 Received: (at 65649) by debbugs.gnu.org; 31 Aug 2023 21:41:19 +0000 Received: from localhost ([127.0.0.1]:59388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpPj-0007L4-3t for submit@debbugs.gnu.org; Thu, 31 Aug 2023 17:41:19 -0400 Received: from out-239.mta1.migadu.com ([95.215.58.239]:32770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpPf-0007Ks-LS for 65649@debbugs.gnu.org; Thu, 31 Aug 2023 17:41:17 -0400 References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693518065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pNBQN4YsDxeYzxi2/5itQC06vSYP+OwmtF8PibkFRuY=; b=UzYebgh2Rfuzdy/DcUeHpHDO7rEULPZYng1AIEJD/+vAdtHZakePj5ETak/Ms8oE++f6fC dyhfgIxYnXc5Bf1IH3d12i5XsmapCwIH/NjJ+LIYVj35XFSQzdIOUc08mmMi9B1mrFerAK vxflPBD2UGMq5Gut5FjgXHGG8ymwqsA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner Date: Thu, 31 Aug 2023 14:39:22 -0700 In-reply-to: <87sf7yoq9p.fsf@breatheoutbreathe.in> Message-ID: <87o7imopp0.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Joseph Turner writes: > Philip Kaludercic writes: > >> Also, the buffer *package-vc doc* should stay persistent and would >> include error messages, that could also be used here. > > Like this? > > (with-demoted-errors "package-vc: Could not build documentation. See *package-vc doc* for details" ... ) Actually, that would not have handled the error related to relative org #+include statements, since that error happened above this line: (with-current-buffer (get-buffer-create " *package-vc doc*") From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2023 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Joseph Turner Cc: 65649@debbugs.gnu.org Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169357410420391 (code B ref 65649); Fri, 01 Sep 2023 13:16:02 +0000 Received: (at 65649) by debbugs.gnu.org; 1 Sep 2023 13:15:04 +0000 Received: from localhost ([127.0.0.1]:60068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3zL-0005Ip-Ro for submit@debbugs.gnu.org; Fri, 01 Sep 2023 09:15:04 -0400 Received: from mout01.posteo.de ([185.67.36.65]:39013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3zJ-0005I2-Ox for 65649@debbugs.gnu.org; Fri, 01 Sep 2023 09:15:03 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 79CBE240027 for <65649@debbugs.gnu.org>; Fri, 1 Sep 2023 15:14:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693574086; bh=dzOWAlhLhWNJ7AuF0FaXqjJiNOwC5Omop/bl+NAfF3c=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=l+e0nVnzMpmrKAXj/3IwimneBB3DDAdWNb4O8UM5WRuLpyCHciRcKcXQUHUIXDwkb tFv7wqhzJzlzJilVeDJLnaW71srwSTfbMDoc0kowHvu2TWaz/34GKblQVSmhEXFIdk Hi8fYWlsA4DqP1ZGpC1Dc8U53QLQqkjiRhF7bZKeMogtOhNSK5CJgN/zpOGQ2Clk9T nPYm2TO7Z+fibXOpwzFGyyV1a/Y0CYj6EWRKNqYDPSiTm50LVNA0moZtJG4Y0E4FlF UoTUwIRfEELSmlB3JxnJSMOfQNq+JI58xQR+JXE5dC/jn1GzzimBN9s3fcfXXlHWRw 8BD0AVLh8PH1A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RcdmQ0phJz9rxK; Fri, 1 Sep 2023 15:14:46 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <87sf7yoq9p.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Thu, 31 Aug 2023 14:19:11 -0700") References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 01 Sep 2023 13:14:45 +0000 Message-ID: <87fs3yvxve.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Joseph Turner writes: > Philip Kaludercic writes: > >> Btw, watch out when reporting a bug, you shouldn't CC people directly, >> but add a X-Debbugs-CC header >> (https://debbugs.gnu.org/Reporting.html#xcc), as otherwise I'd be >> creating a new bug report when responding to your message. > > Good to know! Thank you! Is it okay to CC people when responding to a > bug report email (e.g. if I CC'd Eli in this email)? Yes, as soon as one is sending a message to [bugnumber]@debbugs.gnu.org, everything is fine. The issue if you Cc me directly, is that if I don't watch out, I'll send my response to bug-gnu-emacs@gnu.org, and thus create a new bug. >> Joseph Turner writes: >> >>> It would be nice to report more information about the package with failed >>> documentation, but AFAICT with-demoted-errors does not allow its FORMAT >>> string to be a symbol whose value is a string. >> >> What are the main errors we are concerned with? I am a bit concerned >> that `with-demoted-errors' is a too coarse approach and might be applied >> to widely in your current patch. It might be better to use a classical >> condition-case and handle the right errors in the right place, or if >> practicable try to detect if an error would occur before doing anything. > > I don't know what kinds of errors to expect, which is why I went with > the coarse approach. Under what circumstances would we want to stop > package installation entirely when documentation can't be built? I am not sure we want that behaviour at all actually. Just because there is a typo in the documentation, doesn't mean the package is unusable. The user should be able to install the package, be notified about the error -- if the have the time, they can fix it and send the maintainer a patch resolving the issue for everyone. Likewise, if the user updates a package, it wouldn't make sense to ignore everything or worse still revert the update due to a small mistake in the documentation file. >> Also, the buffer *package-vc doc* should stay persistent and would >> include error messages, that could also be used here. > > Like this? > > (with-demoted-errors "package-vc: Could not build documentation. See *package-vc doc* for details" ... ) Yes, that is what I had in mind. Joseph Turner writes: > Joseph Turner writes: > >> Philip Kaludercic writes: >> >>> Also, the buffer *package-vc doc* should stay persistent and would >>> include error messages, that could also be used here. >> >> Like this? >> >> (with-demoted-errors "package-vc: Could not build documentation. See *package-vc doc* for details" ... ) > > Actually, that would not have handled the error related to relative org > #+include statements, since that error happened above this line: > > (with-current-buffer (get-buffer-create " *package-vc doc*") There is no reason why we cannot already create and use the buffer earlier, to log org-related bugs. One has to be careful when emptying the buffer, but it might make sense to have a separate buffer for each package, especially when updating multiple packages at once... From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2023 23:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 65649@debbugs.gnu.org Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169361111725784 (code B ref 65649); Fri, 01 Sep 2023 23:32:02 +0000 Received: (at 65649) by debbugs.gnu.org; 1 Sep 2023 23:31:57 +0000 Received: from localhost ([127.0.0.1]:34467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcDcL-0006ho-8z for submit@debbugs.gnu.org; Fri, 01 Sep 2023 19:31:57 -0400 Received: from out-239.mta0.migadu.com ([91.218.175.239]:60787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcDcI-0006hc-7R for 65649@debbugs.gnu.org; Fri, 01 Sep 2023 19:31:55 -0400 References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> <87fs3yvxve.fsf@posteo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693611103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q/ZhmdLHHbUQw2AE+nXCRNIJSRCuuEN8O7Bd8q6+CyY=; b=fQH9Hcx8aGr4j5W3d1O0JwJ8oMhk4l6dmXM59Ka6yroT3LH5LikKau+tKbyqlgb9GlRCjh m0kcRUfEHpKY7EpOOa2sCoHRnCOfRDo73pAvNZMuxvntuZISitV19EpdRdkMkTHIX0fS3f NTUDCBt4bsylNbPjTW1/NmbSs+SGJkc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner Date: Fri, 01 Sep 2023 16:28:59 -0700 In-reply-to: <87fs3yvxve.fsf@posteo.net> Message-ID: <87ttsdmpwm.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Philip Kaludercic writes: > Yes, as soon as one is sending a message to [bugnumber]@debbugs.gnu.org, > everything is fine. The issue if you Cc me directly, is that if I don't > watch out, I'll send my response to bug-gnu-emacs@gnu.org, and thus > create a new bug. Thanks, that's clear now. > I am not sure we want that behaviour at all actually. Just because > there is a typo in the documentation, doesn't mean the package is > unusable. The user should be able to install the package, be notified > about the error -- if the have the time, they can fix it and send the > maintainer a patch resolving the issue for everyone. Likewise, if the > user updates a package, it wouldn't make sense to ignore everything or > worse still revert the update due to a small mistake in the > documentation file. > > ... > > There is no reason why we cannot already create and use the buffer > earlier, to log org-related bugs. One has to be careful when emptying > the buffer, but it might make sense to have a separate buffer for each > package, especially when updating multiple packages at once... Please see attached patches. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Include-package-name-in-package-vc-documentation-log.patch >From aa356f561ab7861f463d3024f574fc71d45cb00b Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Wed, 30 Aug 2023 23:24:16 -0700 Subject: [PATCH 1/2] Include package name in package-vc documentation log buffer name * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): --- lisp/emacs-lisp/package-vc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 747fe696204..ea8d9ecf488 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -423,7 +423,7 @@ otherwise it's assumed to be an Info file." (let ((default-directory docs-directory)) (org-export-to-file 'texinfo file)) (setq clean-up t))) - (with-current-buffer (get-buffer-create " *package-vc doc*") + (with-current-buffer (get-buffer-create (format " *package-vc doc: %s*" pkg-name)) (erase-buffer) (cond ((/= 0 (call-process "makeinfo" nil t nil -- 2.41.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-Log-org-export-errors-to-package-vc-doc-buffer.patch >From 010dabfbba8ebeb7f7193482ae2ffc7ec5b694e3 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Fri, 1 Sep 2023 16:22:45 -0700 Subject: [PATCH 2/2] Log org export errors to package-vc doc buffer * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): Wrap the org-export logic in condition-case, allowing package installation to continue while preserving error messages. --- lisp/emacs-lisp/package-vc.el | 52 +++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index ea8d9ecf488..a8393cb7e75 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -413,30 +413,36 @@ otherwise it's assumed to be an Info file." (default-directory (package-desc-dir pkg-desc)) (docs-directory (file-name-directory (expand-file-name file))) (output (expand-file-name (format "%s.info" pkg-name))) + (log-buffer (get-buffer-create (format " *package-vc doc: %s*" pkg-name))) clean-up) - (when (string-match-p "\\.org\\'" file) - (require 'ox) - (require 'ox-texinfo) - (with-temp-buffer - (insert-file-contents file) - (setq file (make-temp-file "ox-texinfo-")) - (let ((default-directory docs-directory)) - (org-export-to-file 'texinfo file)) - (setq clean-up t))) - (with-current-buffer (get-buffer-create (format " *package-vc doc: %s*" pkg-name)) - (erase-buffer) - (cond - ((/= 0 (call-process "makeinfo" nil t nil - "-I" docs-directory - "--no-split" file - "-o" output)) - (message "Failed to build manual %s, see buffer %S" - file (buffer-name))) - ((/= 0 (call-process "install-info" nil t nil - output (expand-file-name "dir"))) - (message "Failed to install manual %s, see buffer %S" - output (buffer-name))) - ((kill-buffer)))) + (with-current-buffer log-buffer + (erase-buffer)) + (condition-case err + (progn + (when (string-match-p "\\.org\\'" file) + (require 'ox) + (require 'ox-texinfo) + (with-temp-buffer + (insert-file-contents file) + (setq file (make-temp-file "ox-texinfo-")) + (let ((default-directory docs-directory)) + (org-export-to-file 'texinfo file)) + (setq clean-up t))) + (cond + ((/= 0 (call-process "makeinfo" nil log-buffer nil + "-I" docs-directory + "--no-split" file + "-o" output)) + (message "Failed to build manual %s, see buffer %S" + file (buffer-name))) + ((/= 0 (call-process "install-info" nil log-buffer nil + output (expand-file-name "dir"))) + (message "Failed to install manual %s, see buffer %S" + output (buffer-name))) + ((kill-buffer log-buffer)))) + (error (with-current-buffer log-buffer + (insert (error-message-string err))) + (message "Failed to export org manual for %s, see buffer %S" pkg-name log-buffer))) (when clean-up (delete-file file)))) -- 2.41.0 --=-=-=-- From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Joseph Turner Cc: 65649@debbugs.gnu.org Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169365625820154 (code B ref 65649); Sat, 02 Sep 2023 12:05:02 +0000 Received: (at 65649) by debbugs.gnu.org; 2 Sep 2023 12:04:18 +0000 Received: from localhost ([127.0.0.1]:35368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcPMP-0005Ey-DJ for submit@debbugs.gnu.org; Sat, 02 Sep 2023 08:04:17 -0400 Received: from mout01.posteo.de ([185.67.36.65]:46093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcPMN-0005Ef-6B for 65649@debbugs.gnu.org; Sat, 02 Sep 2023 08:04:16 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 297A9240029 for <65649@debbugs.gnu.org>; Sat, 2 Sep 2023 14:03:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693656239; bh=5QX4fZ+scqSqLc68eVum5zdm6g2GugoOSTRXzcK+dyo=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=jDumfN49U2xp9aOQwvw0UV+/U0BJfhpKtbF9AKfDumjhmsTadVlF8M2jBxEPfx9hc rXEdQeJkF/NfWUiC7AECJaZItIPZscpC5NePRUZ4Mfuv5+IFrBKe46C5Vcn5xralbS hr7iIY4GV5qWMnh7A6Tp4ehKqD33wcqkbN3mGVXZlzJwaF7s19TlDHq9z8NcPYtsk8 iCPIg9efw0EGhHv+m0Tw37mPb5KRHEFbbnR/bB9HLLGzqsKkvkjX1z/ljJrJTTf2OQ qKoNlq7ru4T++9WfWcz8Owm+Dw1ePKmJvK6+hveIgpmwprkPblZ21Gt91w6DV0JXS+ QkaIZNcYARv8A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RdD8G2RYgz9rxD; Sat, 2 Sep 2023 14:03:58 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <87ttsdmpwm.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Fri, 01 Sep 2023 16:28:59 -0700") References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> <87fs3yvxve.fsf@posteo.net> <87ttsdmpwm.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 02 Sep 2023 12:03:57 +0000 Message-ID: <877cp8g4sy.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Joseph Turner writes: > Philip Kaludercic writes: > >> Yes, as soon as one is sending a message to [bugnumber]@debbugs.gnu.org, >> everything is fine. The issue if you Cc me directly, is that if I don't >> watch out, I'll send my response to bug-gnu-emacs@gnu.org, and thus >> create a new bug. > > Thanks, that's clear now. > >> I am not sure we want that behaviour at all actually. Just because >> there is a typo in the documentation, doesn't mean the package is >> unusable. The user should be able to install the package, be notified >> about the error -- if the have the time, they can fix it and send the >> maintainer a patch resolving the issue for everyone. Likewise, if the >> user updates a package, it wouldn't make sense to ignore everything or >> worse still revert the update due to a small mistake in the >> documentation file. >> >> ... >> >> There is no reason why we cannot already create and use the buffer >> earlier, to log org-related bugs. One has to be careful when emptying >> the buffer, but it might make sense to have a separate buffer for each >> package, especially when updating multiple packages at once... > > Please see attached patches. > >>>From aa356f561ab7861f463d3024f574fc71d45cb00b Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Wed, 30 Aug 2023 23:24:16 -0700 > Subject: [PATCH 1/2] Include package name in package-vc documentation log > buffer name > > * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): > --- > lisp/emacs-lisp/package-vc.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index 747fe696204..ea8d9ecf488 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -423,7 +423,7 @@ otherwise it's assumed to be an Info file." > (let ((default-directory docs-directory)) > (org-export-to-file 'texinfo file)) > (setq clean-up t))) > - (with-current-buffer (get-buffer-create " *package-vc doc*") > + (with-current-buffer (get-buffer-create (format " *package-vc doc: %s*" pkg-name)) > (erase-buffer) > (cond > ((/= 0 (call-process "makeinfo" nil t nil > -- > 2.41.0 This looks good, thanks! > >>>From 010dabfbba8ebeb7f7193482ae2ffc7ec5b694e3 Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Fri, 1 Sep 2023 16:22:45 -0700 > Subject: [PATCH 2/2] Log org export errors to package-vc doc buffer > > * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): > Wrap the org-export logic in condition-case, allowing package > installation to continue while preserving error messages. > --- > lisp/emacs-lisp/package-vc.el | 52 +++++++++++++++++++---------------- > 1 file changed, 29 insertions(+), 23 deletions(-) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index ea8d9ecf488..a8393cb7e75 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -413,30 +413,36 @@ otherwise it's assumed to be an Info file." > (default-directory (package-desc-dir pkg-desc)) > (docs-directory (file-name-directory (expand-file-name file))) > (output (expand-file-name (format "%s.info" pkg-name))) > + (log-buffer (get-buffer-create (format " *package-vc doc: %s*" pkg-name))) > clean-up) > - (when (string-match-p "\\.org\\'" file) > - (require 'ox) > - (require 'ox-texinfo) > - (with-temp-buffer > - (insert-file-contents file) > - (setq file (make-temp-file "ox-texinfo-")) > - (let ((default-directory docs-directory)) > - (org-export-to-file 'texinfo file)) > - (setq clean-up t))) > - (with-current-buffer (get-buffer-create (format " *package-vc doc: %s*" pkg-name)) > - (erase-buffer) > - (cond > - ((/= 0 (call-process "makeinfo" nil t nil > - "-I" docs-directory > - "--no-split" file > - "-o" output)) > - (message "Failed to build manual %s, see buffer %S" > - file (buffer-name))) > - ((/= 0 (call-process "install-info" nil t nil > - output (expand-file-name "dir"))) > - (message "Failed to install manual %s, see buffer %S" > - output (buffer-name))) > - ((kill-buffer)))) > + (with-current-buffer log-buffer > + (erase-buffer)) > + (condition-case err > + (progn > + (when (string-match-p "\\.org\\'" file) > + (require 'ox) > + (require 'ox-texinfo) > + (with-temp-buffer > + (insert-file-contents file) > + (setq file (make-temp-file "ox-texinfo-")) > + (let ((default-directory docs-directory)) > + (org-export-to-file 'texinfo file)) > + (setq clean-up t))) > + (cond > + ((/= 0 (call-process "makeinfo" nil log-buffer nil > + "-I" docs-directory > + "--no-split" file > + "-o" output)) > + (message "Failed to build manual %s, see buffer %S" > + file (buffer-name))) > + ((/= 0 (call-process "install-info" nil log-buffer nil > + output (expand-file-name "dir"))) > + (message "Failed to install manual %s, see buffer %S" > + output (buffer-name))) > + ((kill-buffer log-buffer)))) > + (error (with-current-buffer log-buffer > + (insert (error-message-string err))) > + (message "Failed to export org manual for %s, see buffer %S" pkg-name log-buffer))) I think it would be better to wrap only the org code in the `condition-case' body, ideally with a more specific error type (if that doesn't exist, that is something we could mention to the Org maintainers). > (when clean-up > (delete-file file)))) From unknown Sun Jun 22 07:49:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 65649@debbugs.gnu.org Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169367368118447 (code B ref 65649); Sat, 02 Sep 2023 16:55:02 +0000 Received: (at 65649) by debbugs.gnu.org; 2 Sep 2023 16:54:41 +0000 Received: from localhost ([127.0.0.1]:38508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTtR-0004nS-6U for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:54:41 -0400 Received: from out-233.mta0.migadu.com ([91.218.175.233]:34322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTtO-0004nK-Mh for 65649@debbugs.gnu.org; Sat, 02 Sep 2023 12:54:40 -0400 References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> <87fs3yvxve.fsf@posteo.net> <87ttsdmpwm.fsf@breatheoutbreathe.in> <877cp8g4sy.fsf@posteo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693673668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XTFHkRdNo01f+yFo3vwByDz6N4GtAQsxM9fyZ08Sv4c=; b=H+prYcL+28Pfsts2yi+i43a4Q8CIw7nggZuyslDuOd8gNnT/nobBAtljnjNrNBBSOTuPIV BhqD8Le+WluMWl5w1ROUPgo8vXnPwVo+qq+QIVdufpCiYs4dNeY/5idU85z88ZkdPVNWrb ulZgSyRErd82kTbsqvMXzB9y6mbRnlU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner Date: Sat, 02 Sep 2023 09:49:24 -0700 In-reply-to: <877cp8g4sy.fsf@posteo.net> Message-ID: <87h6ocms72.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > I think it would be better to wrap only the org code in the > `condition-case' body, ideally with a more specific error type (if that > doesn't exist, that is something we could mention to the Org > maintainers). The reason I wrapped both the org-export and makeinfo logic in condition-case is so that the makeinfo logic does not run when the org-export logic fails. Is there a better way? We could let-bind a flag like failed-org-export-p, then set it to t in the condition case handler, then only run makeinfo when failed-org-export-p is nil. Seems a bit ugly. The only define-error in org-mode that's relevant to org-export is not general enough: (define-error 'org-link-broken "Unable to resolve link; aborting") From unknown Sun Jun 22 07:49:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Joseph Turner Subject: bug#65649: closed (Re: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails) Message-ID: References: <877cp7212x.fsf@posteo.net> <87v8cvvi6r.fsf@breatheoutbreathe.in> X-Gnu-PR-Message: they-closed 65649 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 65649@debbugs.gnu.org Date: Sun, 03 Sep 2023 07:01:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1693724462-2410-1" This is a multi-part message in MIME format... ------------=_1693724462-2410-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #65649: [PATCH] package-vc: Continue installing package when documentation = build fails which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 65649@debbugs.gnu.org. --=20 65649: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65649 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1693724462-2410-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 65649-done) by debbugs.gnu.org; 3 Sep 2023 07:00:46 +0000 Received: from localhost ([127.0.0.1]:39123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qch6E-0000cI-Bi for submit@debbugs.gnu.org; Sun, 03 Sep 2023 03:00:46 -0400 Received: from mout02.posteo.de ([185.67.36.66]:34263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qch69-0000c2-7P for 65649-done@debbugs.gnu.org; Sun, 03 Sep 2023 03:00:45 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1C832240101 for <65649-done@debbugs.gnu.org>; Sun, 3 Sep 2023 09:00:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693724424; bh=QIvh8c+1Jv1jkMeGh28Mm5yu8bO6y9h0NmJdg9ONfuQ=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=VlhmtIInhk6nfdvrKJ6LS4/xyggi/lAFCUuR50lx5f28TirZO6d8Th1vz9bL3lBUB uPraltUyZH++AcRjDpdgcsN4tkyBTGofhamMsbrqO7YY61BlsHFcfgR3Wh++6GIlKO XMlDlcBQUoJUSQsVlkts3x9VH76EeZt5Al24PNI9dx+S1jMiVA/EhuNV7qWP4ge/Oj l2ozJkrGJPD5fs6016v6QytAat+Jdu6rsCUi5U8tivwcnWpMOaqh2EiX/aQCMKthPL gkGAZTZGHGYmlysTfEK83W8jYHD8SPALlQYNZTkqfE1tobTZrpt//+7FguddqkE2JF BsoL7ess9bzLg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RdjMW3V2bz9rxD; Sun, 3 Sep 2023 09:00:23 +0200 (CEST) From: Philip Kaludercic To: Joseph Turner Subject: Re: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails In-Reply-To: <87h6ocms72.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 02 Sep 2023 09:49:24 -0700") References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> <87fs3yvxve.fsf@posteo.net> <87ttsdmpwm.fsf@breatheoutbreathe.in> <877cp8g4sy.fsf@posteo.net> <87h6ocms72.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 03 Sep 2023 07:00:22 +0000 Message-ID: <877cp7212x.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65649-done Cc: 65649-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Joseph Turner writes: > Philip Kaludercic writes: > >> I think it would be better to wrap only the org code in the >> `condition-case' body, ideally with a more specific error type (if that >> doesn't exist, that is something we could mention to the Org >> maintainers). > > The reason I wrapped both the org-export and makeinfo logic in > condition-case is so that the makeinfo logic does not run when the > org-export logic fails. Is there a better way? > > We could let-bind a flag like failed-org-export-p, then set it to t in > the condition case handler, then only run makeinfo when > failed-org-export-p is nil. Seems a bit ugly. Oh right, never-mind then, I guess this is the simplest solution. > The only define-error in org-mode that's relevant to org-export is not > general enough: > > (define-error 'org-link-broken "Unable to resolve link; aborting") Then this should be fine. I'll apply the changes the master. Thanks. ------------=_1693724462-2410-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 Aug 2023 06:29:33 +0000 Received: from localhost ([127.0.0.1]:54674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbBM-0003qm-Cp for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:29:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbbBK-0003qX-MG for submit@debbugs.gnu.org; Thu, 31 Aug 2023 02:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbB5-0005ex-MN for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 02:29:15 -0400 Received: from out-251.mta0.migadu.com ([91.218.175.251]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbB1-0000hF-1e for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 02:29:15 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693463348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=51NWULcRjBrXXXnIDByi3nlsQ2QsS5FGB6ONzjBWZLQ=; b=gHH5sGs+WiNBg464WDqc67NX6qNMEaMOyhoJuqoH7qzSJWjMER8OXXlzQTqvk6cpV04Wuy ZN6ISXuN+J2YzoTqRGEeXaaxrNvK5xtfE2MlRHttNv8xprd95s6BFk7TA4FzCK3Zn9PSgT Jkdr4tYUJlOsXFOrVRNXTriudyl/aVQ= From: Joseph Turner To: bug-gnu-emacs@gnu.org Subject: [PATCH] package-vc: Continue installing package when documentation build fails Date: Wed, 30 Aug 2023 23:26:35 -0700 Message-ID: <87v8cvvi6r.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.251; envelope-from=joseph@breatheoutbreathe.in; helo=out-251.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain In light of the recent fix regarding building documentation from org-mode files, I think it makes sense to ensure that installation continues even without documentation. Joseph --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Continue-installing-package-when-documentation-build.patch >From 83c62d80b5199cee911e30c1f3bb03c5a585b689 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Wed, 30 Aug 2023 23:24:16 -0700 Subject: [PATCH] Continue installing package when documentation building fails * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): Demote errors to messages. --- lisp/emacs-lisp/package-vc.el | 61 ++++++++++++++++++----------------- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 747fe696204..bc1200c583f 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -409,36 +409,37 @@ prepared." "Build documentation for package PKG-DESC from documentation source in FILE. FILE can be an Org file, indicated by its \".org\" extension, otherwise it's assumed to be an Info file." - (let* ((pkg-name (package-desc-name pkg-desc)) - (default-directory (package-desc-dir pkg-desc)) - (docs-directory (file-name-directory (expand-file-name file))) - (output (expand-file-name (format "%s.info" pkg-name))) - clean-up) - (when (string-match-p "\\.org\\'" file) - (require 'ox) - (require 'ox-texinfo) - (with-temp-buffer - (insert-file-contents file) - (setq file (make-temp-file "ox-texinfo-")) - (let ((default-directory docs-directory)) - (org-export-to-file 'texinfo file)) - (setq clean-up t))) - (with-current-buffer (get-buffer-create " *package-vc doc*") - (erase-buffer) - (cond - ((/= 0 (call-process "makeinfo" nil t nil - "-I" docs-directory - "--no-split" file - "-o" output)) - (message "Failed to build manual %s, see buffer %S" - file (buffer-name))) - ((/= 0 (call-process "install-info" nil t nil - output (expand-file-name "dir"))) - (message "Failed to install manual %s, see buffer %S" - output (buffer-name))) - ((kill-buffer)))) - (when clean-up - (delete-file file)))) + (with-demoted-errors "package-vc: Could not build documentation: %s" + (let* ((pkg-name (package-desc-name pkg-desc)) + (default-directory (package-desc-dir pkg-desc)) + (docs-directory (file-name-directory (expand-file-name file))) + (output (expand-file-name (format "%s.info" pkg-name))) + clean-up) + (when (string-match-p "\\.org\\'" file) + (require 'ox) + (require 'ox-texinfo) + (with-temp-buffer + (insert-file-contents file) + (setq file (make-temp-file "ox-texinfo-")) + (let ((default-directory docs-directory)) + (org-export-to-file 'texinfo file)) + (setq clean-up t))) + (with-current-buffer (get-buffer-create " *package-vc doc*") + (erase-buffer) + (cond + ((/= 0 (call-process "makeinfo" nil t nil + "-I" docs-directory + "--no-split" file + "-o" output)) + (message "Failed to build manual %s, see buffer %S" + file (buffer-name))) + ((/= 0 (call-process "install-info" nil t nil + output (expand-file-name "dir"))) + (message "Failed to install manual %s, see buffer %S" + output (buffer-name))) + ((kill-buffer)))) + (when clean-up + (delete-file file))))) (defun package-vc-install-dependencies (deps) "Install missing dependencies according to DEPS. -- 2.41.0 --=-=-=-- ------------=_1693724462-2410-1--