GNU bug report logs - #65644
[PATCH gnome-team 0/9] Update GNOME Shell to 44

Previous Next

Full log

Message #44 received at 65644 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: rg <at> raghavgururajan.name, 65644 <at> debbugs.gnu.org
Subject: Re: [bug#65644] [PATCH gnome-team 9/9] gnu: gnome-shell: Update to
 44.3.
Date: Mon, 04 Sep 2023 22:59:01 -0400

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/gnome.scm (gnome-shell): Update to 44.3.
> [arguments]<#:phases>: Add ‘unbreak-perf-tests’.
> Adjust ‘pre-check’ accordingly.
> [native-inputs]: Add python-dbus and python-dbusmock.
> [inputs]: Remove caribou.  Replace gcr with gcr-4.
> ---
>  gnu/packages/gnome.scm | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 5e6a6df44c..d4e78bb08d 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -9114,7 +9114,7 @@ (define-public gnome-control-center
>  (define-public gnome-shell
>    (package
>      (name "gnome-shell")
> -    (version "42.4")
> +    (version "44.3")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "mirror://gnome/sources/" name "/"
> @@ -9122,7 +9122,7 @@ (define-public gnome-shell
>                                    name "-" version ".tar.xz"))
>                (sha256
>                 (base32
> -                "0kn5fclciybp2fs38wd39hdz85y91pas0ckfa02pmyx91sbz4pw7"))))
> +                "1grizh3fbks5dgizaj38300cz97ay81q0hlk1pvawkpfq9qlnsam"))))
>      (build-system meson-build-system)
>      (arguments
>       (let ((disallowed-references
> @@ -9160,6 +9160,12 @@ (define-public gnome-shell
>                  (substitute* "meson.build"
>                    (("gtk_update_icon_cache: true")
>                     "gtk_update_icon_cache: false"))))
> +            (add-after 'unpack 'unbreak-perf-tests
> +              (lambda _
> +                ;; non-fatal dbus warning otherwise causes shell to crash

Please punctuate stand-alone comments (capitalization, periods).

Otherwise LGTM.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.