From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 30 14:05:19 2023 Received: (at submit) by debbugs.gnu.org; 30 Aug 2023 18:05:19 +0000 Received: from localhost ([127.0.0.1]:53936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbPZ9-0001Kj-3y for submit@debbugs.gnu.org; Wed, 30 Aug 2023 14:05:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbPZ5-0001KP-2e for submit@debbugs.gnu.org; Wed, 30 Aug 2023 14:05:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbPYn-0001qi-Nz for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 14:04:58 -0400 Received: from smtp-15.smtpout.orange.fr ([80.12.242.15] helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbPYk-0003HL-Eb for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 14:04:57 -0400 Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id bPYfq3D0UxiGYbPYfqXohZ; Wed, 30 Aug 2023 20:04:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1693418690; bh=e1WI9s8sZKL9RjwY1WsxzYmeYiApWFQGEhpkI6wA2rk=; h=Date:To:From:Subject; b=jmp4a+mn3vozSXSWOjD2dk9bJqODAgJHZ2GSGeEd0RZpYo9Ss6VccdIG9B8IeMY9C JdOet6IWOAJp3T1Wyan2YIu916krs7GVAiMjL+wD6Sy1iH2yOU6aeWbwAok2fCE4uq UREe7D0weBITkB7U8GbPvM+T5EJ/tEDzY5BkRi3H7AIswGxZcpukanWA6mfbW/rQM4 l3E02jC6uxnOO/FtuUULeWgm8K+eiIEXCOvg/woWgC2fwSqTVDuvr6cqSSPhIEk5fe H07XO/+XhlUVCj6QCLUf4wIE2Jx8EXDbZ4d368TZl0kDOAdzxFiwU55PSZCWIzwuV4 JNnNYaDq7g8hw== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Wed, 30 Aug 2023 20:04:50 +0200 X-ME-IP: 2.7.71.181 Content-Type: multipart/mixed; boundary="------------JJEk5aKF1BTWenVZT0IQreZv" Message-ID: Date: Wed, 30 Aug 2023 20:04:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 To: bug-gnu-emacs@gnu.org Content-Language: fr, en-US From: David Ponce Subject: 30.0.50; Proposal to improve `faces--attribute-at-point'. Received-SPF: pass client-ip=80.12.242.15; envelope-from=da_vid@orange.fr; helo=smtp.smtpout.orange.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) This is a multi-part message in MIME format. --------------JJEk5aKF1BTWenVZT0IQreZv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, I noticed that the functions `foreground-color-at-point' and `background-color-at-point' don't return expected values when the face at point includes anonymous face or is a nested list of face, for example. Here is a simple recipe that demonstrates the issue (emacs -Q): In scratch buffer eval: ----------------------- ;; Display "TEST" in red, bold, italic on yellow background. (insert (propertize "TEST" 'font-lock-face '(bold ((:background "yellow") "italic" ((foreground-color . "red") underline))))) TESTnil ;; Then click to move point somewhere on TEST and run M-: (foreground-color-at-point) RET >>> result is "black" instead of "red" M-: (background-color-at-point) RET >>> result is "white" instead of "yellow" I propose the attached patch to faces.el to improve things. The patch introduce a new function `face-attribute-lookup' to lookup face attribute, that works when face specification is complex like in above example. The function `faces--attribute-at-point' is simplified to use it. Here is a possible changelog: * faces.el: Improve attribute lookup of face at point. (face--unnamed-attributes): New constant. (face--attribute-unspecified-p) (face-attribute-lookup): New functions. (faces--attribute-at-point): Use it. Remove useless argument. (foreground-color-at-point) (background-color-at-point): Update accordingly. Thanks --------------JJEk5aKF1BTWenVZT0IQreZv Content-Type: text/x-patch; charset=UTF-8; name="faces-attribute-lookup-V0.patch" Content-Disposition: attachment; filename="faces-attribute-lookup-V0.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZmFjZXMuZWwgYi9saXNwL2ZhY2VzLmVsCmluZGV4IDhmOTNm OWIyYzBjLi5kZDFkNjA0MDdjZCAxMDA2NDQKLS0tIGEvbGlzcC9mYWNlcy5lbAorKysgYi9s aXNwL2ZhY2VzLmVsCkBAIC0yMTA5LDUwICsyMTA5LDEwNyBAQCBmYWNlLWF0LXBvaW50CiAg ICAgICAgIChkZWxldGUtZHVwcyAobnJldmVyc2UgZmFjZXMpKQogICAgICAgKGNhciAobGFz dCBmYWNlcykpKSkpCiAKLShkZWZ1biBmYWNlcy0tYXR0cmlidXRlLWF0LXBvaW50IChhdHRy aWJ1dGUgJm9wdGlvbmFsIGF0dHJpYnV0ZS11bm5hbWVkKQorKGRlZmNvbnN0IGZhY2UtLXVu bmFtZWQtYXR0cmlidXRlcworICAnKChmb3JlZ3JvdW5kLWNvbG9yIC4gOmZvcmVncm91bmQp CisgICAgKGJhY2tncm91bmQtY29sb3IgLiA6YmFja2dyb3VuZCkpCisgICJBbGlzdCBvZiB1 bm5hbWVkIGZhY2UgYXR0cmlidXRlIHdpdGgga2V5d29yZCBlcXVpdmFsZW50LgorVXNlZCBm b3IgYmFja3dhcmQgY29tcGF0aWJpbGl0eS4iKQorCisoZGVmc3Vic3QgZmFjZS0tYXR0cmli dXRlLXVuc3BlY2lmaWVkLXAgKHZhbHVlKQorICAiUmV0dXJuIG5vbi1uaWwgaWYgZmFjZSBh dHRyaWJ1dGUgVkFMVUUgbWVhbnMgdW5zcGVjaWZpZWQuIgorICAobWVtYmVyIHZhbHVlICco bmlsIHVuc3BlY2lmaWVkICJ1bnNwZWNpZmllZC1mZyIgInVuc3BlY2lmaWVkLWJnIikpKQor CisoZGVmdW4gZmFjZS1hdHRyaWJ1dGUtbG9va3VwIChmYWNlIGF0dHJpYnV0ZSAmb3B0aW9u YWwgZnJhbWUgZGVmYXVsdCkKKyAgIkxvb2t1cCB0aGUgdmFsdWUgb2YgRkFDRSdzIEFUVFJJ QlVURSBvbiBGUkFNRS4KK0ZBQ0UgaXMgYSB2YWxpZCBmYWNlIHNwZWNpZmljYXRpb246CisK K0ZBQ0UtU1BFQyAgIDo9IEZBQ0UtTkFNRSB8IEFOT05ZTS1GQUNFIHwgQ09MT1IgfCBGQUNF LUxJU1QKK0ZBQ0UtTkFNRSAgIDo9IFNZTUJPTCB8IFNUUklORworQU5PTllNLUZBQ0UgOj0g KEFUVFJJQlVURS0xIFZBTFVFLTEgLi4uIEFUVFJJQlVURS1OIFZBTFVFLU4pCitDT0xPUiAg ICAgICA6PSBGT1JFR1JPVU5EIHwgQkFDS0dST1VORAorRk9SRUdST1VORCAgOj0gKGBmb3Jl Z3JvdW5kLWNvbG9yJyAuIENPTE9SLU5BTUUpCitCQUNLR1JPVU5EICA6PSAoYGJhY2tncm91 bmQtY29sb3InIC4gQ09MT1ItTkFNRSkKK0ZBQ0UtTElTVCAgIDo9IChGQUNFLVNQRUMtMSAu Li4gRkFDRS1TUEVDLU4pCisKK0lmIHRoZSBvcHRpb25hbCBhcmd1bWVudCBGUkFNRSBpcyBn aXZlbiwgcmVwb3J0IG9uIEZBQ0UgaW4gdGhhdCBmcmFtZS4KK0lmIEZSQU1FIGlzIHQsIHJl cG9ydCBvbiB0aGUgZGVmYXVsdHMgZm9yIEZBQ0UgKGZvciBuZXcgZnJhbWVzKS4KK0lmIEZS QU1FIGlzIG9taXR0ZWQgb3IgbmlsLCB1c2UgdGhlIHNlbGVjdGVkIGZyYW1lLgorCitPcHRp b25hbCBhcmd1bWVudCBERUZBVUxUIGlzIGEgZmFjZSBzcGVjaWZpY2F0aW9uIGFwcGVuZGVk IHRvIEZBQ0UuCitJZiBERUZBVUxUIGluY2x1ZGVzIHRoZSBgZGVmYXVsdCcgZmFjZSwgdGhl IHJldHVybiB2YWx1ZSBpcyBhbHdheXMKK3NwZWNpZmllZCBhbmQgYWJzb2x1dGUuCisKK1Jl dHVybiB0aGUgZmlyc3Qgc3BlY2lmaWVkIHZhbHVlIGZvdW5kIGZvciBBVFRSSUJVVEUsIG9y IG5pbCBpZgorQVRUUklCVVRFIGlzIHVuc3BlY2lmaWVkLiIKKyAgKGNhdGNoICdmb3VuZAor ICAgIChsZXQgKChmYWNlcyAoYXBwZW5kIChlbnN1cmUtbGlzdCBmYWNlKSAoZW5zdXJlLWxp c3QgZGVmYXVsdCkpKQorICAgICAgICAgIChyZXN0IG5pbCkpCisgICAgICAod2hpbGUgdAor ICAgICAgICAoY29uZAorICAgICAgICAgOzsgRW5kIG9mIGEgZmFjZS1zcGVjLgorICAgICAg ICAgKChudWxsIGZhY2VzKQorICAgICAgICAgIChpZiByZXN0CisgICAgICAgICAgICAgIChz ZXRxIGZhY2VzIChjYXIgcmVzdCkgcmVzdCAoY2RyIHJlc3QpKQorICAgICAgICAgICAgKHRo cm93ICdmb3VuZCBuaWwpKSkKKyAgICAgICAgIDs7IE1hbGZvcm1lZCBmYWNlLXNwZWMuCisg ICAgICAgICAoKGF0b20gZmFjZXMpCisgICAgICAgICAgKHRocm93ICdmb3VuZCBuaWwpKQor ICAgICAgICAgOzsgRmFjZSBuYW1lLgorICAgICAgICAgKChmYWNlcCAoY2FyIGZhY2VzKSkK KyAgICAgICAgICAobGV0KiAoKGZhY2UgKGNhciBmYWNlcykpCisgICAgICAgICAgICAgICAg IChhdHRyIChmYWNlLWF0dHJpYnV0ZSAoaWYgKHN0cmluZ3AgZmFjZSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaW50ZXJuIGZhY2UpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhY2UpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgZnJhbWUgdCkpKQorICAgICAg ICAgICAgKGlmIChmYWNlLS1hdHRyaWJ1dGUtdW5zcGVjaWZpZWQtcCBhdHRyKQorICAgICAg ICAgICAgICAgIChzZXRxIGZhY2VzIChjZHIgZmFjZXMpKQorICAgICAgICAgICAgICAodGhy b3cgJ2ZvdW5kIGF0dHIpKSkpCisgICAgICAgICA7OyBBbm9ueW1vdXMgZmFjZSAocGxpc3Qp LgorICAgICAgICAgKChrZXl3b3JkcCAoY2FyIGZhY2VzKSkKKyAgICAgICAgICAobGV0ICgo YXR0ciAocGxpc3QtZ2V0IGZhY2VzIGF0dHJpYnV0ZSkpKQorICAgICAgICAgICAgKGlmIChm YWNlLS1hdHRyaWJ1dGUtdW5zcGVjaWZpZWQtcCBhdHRyKQorICAgICAgICAgICAgICAgIChz ZXRxIGZhY2VzIG5pbCkKKyAgICAgICAgICAgICAgKHRocm93ICdmb3VuZCBhdHRyKSkpKQor ICAgICAgICAgOzsgQ29sb3IuCisgICAgICAgICAoKHdoZW4tbGV0ICgoc3ltIChhc3NxIChj YXIgZmFjZXMpIGZhY2UtLXVubmFtZWQtYXR0cmlidXRlcykpKQorICAgICAgICAgICAgKGlm IChvciAobm90IChlcSBhdHRyaWJ1dGUgKGNkciBzeW0pKSkKKyAgICAgICAgICAgICAgICAg ICAgKGZhY2UtLWF0dHJpYnV0ZS11bnNwZWNpZmllZC1wIChjZHIgZmFjZXMpKSkKKyAgICAg ICAgICAgICAgICAoc2V0cSBmYWNlcyBuaWwpCisgICAgICAgICAgICAgICh0aHJvdyAnZm91 bmQgKGNkciBmYWNlcykpKSkpCisgICAgICAgICA7OyBOZXN0ZWQgZmFjZS1saXN0LgorICAg ICAgICAgKChjb25zcCAoY2FyIGZhY2VzKSkKKyAgICAgICAgICAoc2V0cSByZXN0IChjb25z IChjZHIgZmFjZXMpIChpZiAoY2RyIGZhY2VzKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChjb25zIChjZHIgZmFjZXMpIHJlc3QpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlc3QpKQorICAgICAgICAgICAgICAg IGZhY2VzIChjYXIgZmFjZXMpKSkKKyAgICAgICAgIDs7IFNraXAgdW5rbm93IHZhbHVlLgor ICAgICAgICAgKChzZXRxIGZhY2VzIChjZHIgZmFjZXMpKSkpKSkpKQorCisoZGVmdW4gZmFj ZXMtLWF0dHJpYnV0ZS1hdC1wb2ludCAoYXR0cmlidXRlKQogICAiUmV0dXJuIHRoZSBmYWNl IEFUVFJJQlVURSBhdCBwb2ludC4KLUFUVFJJQlVURSBpcyBhIGtleXdvcmQuCi1JZiBBVFRS SUJVVEUtVU5OQU1FRCBpcyBub24tbmlsLCBpdCBpcyBhIHN5bWJvbCB0byBsb29rIGZvciBp bgotdW5uYW1lZCBmYWNlcyAoZS5nLCBgZm9yZWdyb3VuZC1jb2xvcicpLiIKK0FUVFJJQlVU RSBpcyBhIGtleXdvcmQuIgogICA7OyBgZmFjZS1hdC1wb2ludCcgYWxvbmUgaXMgbm90IHN1 ZmZpY2llbnQuICBJdCBvbmx5IGdldHMgbmFtZWQgZmFjZXMuCiAgIDs7IE5lZWQgYWxzbyBw aWNrIHVwIGFueSBmYWNlIHByb3BlcnRpZXMgdGhhdCBhcmUgbm90IGFzc29jaWF0ZWQgd2l0 aCBuYW1lZCBmYWNlcy4KICAgKGxldCAoKGZhY2VzIChvciAoZ2V0LWNoYXItcHJvcGVydHkg KHBvaW50KSAncmVhZC1mYWNlLW5hbWUpCiAgICAgICAgICAgICAgICAgICAgOzsgSWYgYGZv bnQtbG9jay1tb2RlJyBpcyBvbiwgYGZvbnQtbG9jay1mYWNlJyB0YWtlcyBwcmVjZWRlbmNl LgogICAgICAgICAgICAgICAgICAgIChhbmQgZm9udC1sb2NrLW1vZGUKICAgICAgICAgICAg ICAgICAgICAgICAgIChnZXQtY2hhci1wcm9wZXJ0eSAocG9pbnQpICdmb250LWxvY2stZmFj ZSkpCi0gICAgICAgICAgICAgICAgICAgKGdldC1jaGFyLXByb3BlcnR5IChwb2ludCkgJ2Zh Y2UpKSkKLSAgICAgICAgKGZvdW5kIG5pbCkpCi0gICAgKGRvbGlzdCAoZmFjZSAoaWYgKGZh Y2UtbGlzdC1wIGZhY2VzKQotICAgICAgICAgICAgICAgICAgICAgIGZhY2VzCi0gICAgICAg ICAgICAgICAgICAgIChsaXN0IGZhY2VzKSkpCi0gICAgICAoY29uZCAoZm91bmQpCi0gICAg ICAgICAgICAoKGFuZCBmYWNlIChzeW1ib2xwIGZhY2UpKQotICAgICAgICAgICAgIChsZXQg KCh2YWx1ZSAoZmFjZS1hdHRyaWJ1dGUtc3BlY2lmaWVkLW9yCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAoZmFjZS1hdHRyaWJ1dGUgZmFjZSBhdHRyaWJ1dGUgbmlsIHQpCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICBuaWwpKSkKLSAgICAgICAgICAgICAgICh1bmxlc3Mg KG1lbWJlciB2YWx1ZSAnKG5pbCAidW5zcGVjaWZpZWQtZmciICJ1bnNwZWNpZmllZC1iZyIp KQotICAgICAgICAgICAgICAgICAoc2V0cSBmb3VuZCB2YWx1ZSkpKSkKLSAgICAgICAgICAg ICgoY29uc3AgZmFjZSkKLSAgICAgICAgICAgICAoc2V0cSBmb3VuZCAoY29uZCAoKGFuZCBh dHRyaWJ1dGUtdW5uYW1lZAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChtZW1xIGF0dHJpYnV0ZS11bm5hbWVkIGZhY2UpKQotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoY2RyIChtZW1xIGF0dHJpYnV0ZS11bm5hbWVkIGZhY2UpKSkKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoKG1lbXEgYXR0cmlidXRlIGZhY2UpIChjYWRy IChtZW1xIGF0dHJpYnV0ZSBmYWNlKSkpKSkpKSkKLSAgICAob3IgZm91bmQKLSAgICAgICAg KGZhY2UtYXR0cmlidXRlICdkZWZhdWx0IGF0dHJpYnV0ZSkpKSkKKyAgICAgICAgICAgICAg ICAgICAoZ2V0LWNoYXItcHJvcGVydHkgKHBvaW50KSAnZmFjZSkpKSkKKyAgICAoZmFjZS1h dHRyaWJ1dGUtbG9va3VwIGZhY2VzIGF0dHJpYnV0ZSBuaWwgJ2RlZmF1bHQpKSkKIAogKGRl ZnVuIGZvcmVncm91bmQtY29sb3ItYXQtcG9pbnQgKCkKICAgIlJldHVybiB0aGUgZm9yZWdy b3VuZCBjb2xvciBvZiB0aGUgY2hhcmFjdGVyIGFmdGVyIHBvaW50LgogT24gVFRZIGZyYW1l cywgdGhlIHJldHVybmVkIGNvbG9yIG5hbWUgY2FuIGJlIFwidW5zcGVjaWZpZWQtZmdcIiwK IHdoaWNoIHN0YW5kcyBmb3IgdGhlIHVua25vd24gZGVmYXVsdCBmb3JlZ3JvdW5kIGNvbG9y IG9mIHRoZQogZGlzcGxheSB3aGVyZSB0aGUgZnJhbWUgaXMgZGlzcGxheWVkLiIKLSAgKGZh Y2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgOmZvcmVncm91bmQgJ2ZvcmVncm91bmQtY29sb3Ip KQorICAoZmFjZXMtLWF0dHJpYnV0ZS1hdC1wb2ludCA6Zm9yZWdyb3VuZCkpCiAKIChkZWZ1 biBiYWNrZ3JvdW5kLWNvbG9yLWF0LXBvaW50ICgpCiAgICJSZXR1cm4gdGhlIGJhY2tncm91 bmQgY29sb3Igb2YgdGhlIGNoYXJhY3RlciBhZnRlciBwb2ludC4KIE9uIFRUWSBmcmFtZXMs IHRoZSByZXR1cm5lZCBjb2xvciBuYW1lIGNhbiBiZSBcInVuc3BlY2lmaWVkLWJnXCIsCiB3 aGljaCBzdGFuZHMgZm9yIHRoZSB1bmtub3duIGRlZmF1bHQgYmFja2dyb3VuZCBjb2xvciBv ZiB0aGUKIGRpc3BsYXkgd2hlcmUgdGhlIGZyYW1lIGlzIGRpc3BsYXllZC4iCi0gIChmYWNl cy0tYXR0cmlidXRlLWF0LXBvaW50IDpiYWNrZ3JvdW5kICdiYWNrZ3JvdW5kLWNvbG9yKSkK KyAgKGZhY2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgOmJhY2tncm91bmQpKQogCiAMCiA7Ozs7 Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7 Ozs7Ozs7Ozs7Ozs7OzsK --------------JJEk5aKF1BTWenVZT0IQreZv-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 30 14:35:51 2023 Received: (at 65632) by debbugs.gnu.org; 30 Aug 2023 18:35:51 +0000 Received: from localhost ([127.0.0.1]:53960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbQ2h-000256-E3 for submit@debbugs.gnu.org; Wed, 30 Aug 2023 14:35:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbQ2a-00024o-UB for 65632@debbugs.gnu.org; Wed, 30 Aug 2023 14:35:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbQ2N-0001Nh-IU; Wed, 30 Aug 2023 14:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WTSkyoBIiNf8h8p/h465DecK0MzovwuzbLGGeHCFb9g=; b=qGtoMpNf62mf fFGq1P7VlLEF3Kr47VBOQkcVAT1NyALABguO1ZgsxloW4OKh1zwInOn0bTI8YPyxjjbeGvTUiVPSD Wdra5z3BtHti4EJVwEGKe8q+Vjl9/8Yy00KI84cJMZ1Abf/D+8PYnu/WYFEWY2Mxu7xO5WlwmCpAT bK1Ue73RUeR1o/g1Ch7oBqgCL8W4LVrRHj6G1nfWtNOtvUrVwjCd4rVvo144cVs7f9HKid2uTv6ah qRyssX3CsNX2JKJdgg062WuiQu6ooqXNOyLxJkbiIF1I0mJfg/o7N0KVg/x3BKGKAZMqJHe8HNiV6 SuliIVyn5gJRkh/A7ya6+w==; Date: Wed, 30 Aug 2023 21:35:11 +0300 Message-Id: <83jztcfkf4.fsf@gnu.org> From: Eli Zaretskii To: David Ponce In-Reply-To: (message from David Ponce on Wed, 30 Aug 2023 20:04:49 +0200) Subject: Re: bug#65632: 30.0.50; Proposal to improve `faces--attribute-at-point'. References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65632 Cc: 65632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 30 Aug 2023 20:04:49 +0200 > From: David Ponce > > I noticed that the functions `foreground-color-at-point' and > `background-color-at-point' don't return expected values when the face > at point includes anonymous face or is a nested list of face, for > example. > > Here is a simple recipe that demonstrates the issue (emacs -Q): > > In scratch buffer eval: > ----------------------- > > ;; Display "TEST" in red, bold, italic on yellow background. > (insert > (propertize > "TEST" 'font-lock-face > '(bold ((:background "yellow") "italic" > ((foreground-color . "red") underline))))) This is not a valid face, AFAIU. That it works is sheer luck (because Emacs is very lenient with this stuff). The correct face definition for what you want is this (see 'set-face-attribute's doc string): (insert (propertize "TEST" 'font-lock-face '(:weight bold :background "yellow" :slant italic :foreground "red" :underline t))) If you use the above, foreground-color-at-point etc. will work as expected. I'm not sure we want to go out of our way to support the kind of face specifications that you used. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 30 15:23:25 2023 Received: (at 65632) by debbugs.gnu.org; 30 Aug 2023 19:23:25 +0000 Received: from localhost ([127.0.0.1]:54087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbQmj-0003T0-0K for submit@debbugs.gnu.org; Wed, 30 Aug 2023 15:23:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbQmh-0003Sd-8L for 65632@debbugs.gnu.org; Wed, 30 Aug 2023 15:23:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbQmT-0003S2-T9; Wed, 30 Aug 2023 15:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZOV6bjMRgoQLWbPoVCgfQXD0KgavJaPGeqxVmWD6PvM=; b=iAnSVdxFd711 BXg9ANah8ugpSdmeW0LFhFAdtsDSsD0V7G4o0NHq6sI6wy/SZR+2+AtW/3157htWAI4UI/G+kXWzz ljp8xstQXU602Hld0qjyx5p3vX3p2DSaNlUEd7GVt8Bqy+smxCBsc45Bnf8S58KhMm+wCIwUy1gpp c+Q+LxfHga6W0lK9EPFhEYqFwc/S931b6O7BERD0pFltar0N9K923v6upIyWoYCt2J9rw7K6n0WGI w2favXNz9XIIFHWezcWfs2eO1LMCoYuim3jxSB5hF+o8aAp0Zv05QzhKjUg26ErIdC6ufHvpFqcek e2sB9NOXMn082drRMfmU9A==; Date: Wed, 30 Aug 2023 22:22:50 +0300 Message-Id: <83h6ogfi7p.fsf@gnu.org> From: Eli Zaretskii To: da_vid@orange.fr In-Reply-To: <83jztcfkf4.fsf@gnu.org> (message from Eli Zaretskii on Wed, 30 Aug 2023 21:35:11 +0300) Subject: Re: bug#65632: 30.0.50; Proposal to improve `faces--attribute-at-point'. References: <83jztcfkf4.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65632 Cc: 65632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 65632@debbugs.gnu.org > Date: Wed, 30 Aug 2023 21:35:11 +0300 > From: Eli Zaretskii > > > ;; Display "TEST" in red, bold, italic on yellow background. > > (insert > > (propertize > > "TEST" 'font-lock-face > > '(bold ((:background "yellow") "italic" > > ((foreground-color . "red") underline))))) > > This is not a valid face, AFAIU. That it works is sheer luck (because > Emacs is very lenient with this stuff). The correct face definition > for what you want is this (see 'set-face-attribute's doc string): > > (insert > (propertize > "TEST" 'font-lock-face > '(:weight bold :background "yellow" :slant italic > :foreground "red" :underline t))) > > If you use the above, foreground-color-at-point etc. will work as > expected. > > I'm not sure we want to go out of our way to support the kind of face > specifications that you used. However, if we do want that, we already have the technology: (face-attributes-as-vector (get-char-property (point) 'font-lock-face)) This will return a vector of face attribute values, where you can find the value of any attribute you like. For example, to get the foreground color, evaluate: (aref 9 (face-attributes-as-vector (get-char-property (point) 'font-lock-face))) From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 30 18:31:01 2023 Received: (at 65632) by debbugs.gnu.org; 30 Aug 2023 22:31:01 +0000 Received: from localhost ([127.0.0.1]:54242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbTiG-00089o-Pu for submit@debbugs.gnu.org; Wed, 30 Aug 2023 18:31:01 -0400 Received: from smtp-24.smtpout.orange.fr ([80.12.242.24]:63760 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbTiB-00089b-Ca for 65632@debbugs.gnu.org; Wed, 30 Aug 2023 18:30:59 -0400 Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id bThzqmuAtuWDMbTi0qqRnC; Thu, 31 Aug 2023 00:30:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1693434645; bh=LxPe8KtfY3CzAtW2bk4T2Wd7Mxhf8bsaVrn+gPSRdrU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=nrVYSZrYP9WZajtuj3Za8fWDkSzax7gGEh39kHj6WxGnW81A7F/d3BdxgYm7m10Ea NnAiGeMHWz9iv4DTbLzoUDSjGicVO+9VlKGit+LophtfLyNHvjgmllC4qTz8yOavtU Q8HT4uoX3hCzM+0MSAtQdd5XlSeORoTen+CERf+fnGJ8KObnU4lUGq78fuoAfBD19C KYTkeQEEwGjKBS0WSZux8XhO4Ox82HF8UJW7ZYtL4lG/nfqRLANBne2q7fenuf9FSS 9yRsV3VirYS4K4vid5X1Mg1O/rfDUdxp83Axie+Yuif+ZNNmd535D9q97Iktx8iJzc NsvD9meF4epQg== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Thu, 31 Aug 2023 00:30:45 +0200 X-ME-IP: 2.7.71.181 Content-Type: multipart/mixed; boundary="------------jc9jmD4ZSu4eEvrewgb9RJsw" Message-ID: Date: Thu, 31 Aug 2023 00:30:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: bug#65632: 30.0.50; Proposal to improve `faces--attribute-at-point'. To: Eli Zaretskii References: <83jztcfkf4.fsf@gnu.org> <83h6ogfi7p.fsf@gnu.org> Content-Language: fr, en-US From: David Ponce In-Reply-To: <83h6ogfi7p.fsf@gnu.org> X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65632 Cc: 65632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) This is a multi-part message in MIME format. --------------jc9jmD4ZSu4eEvrewgb9RJsw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/08/2023 21:22, Eli Zaretskii wrote: >> Cc: 65632@debbugs.gnu.org >> Date: Wed, 30 Aug 2023 21:35:11 +0300 >> From: Eli Zaretskii >> >>> ;; Display "TEST" in red, bold, italic on yellow background. >>> (insert >>> (propertize >>> "TEST" 'font-lock-face >>> '(bold ((:background "yellow") "italic" >>> ((foreground-color . "red") underline))))) >> >> This is not a valid face, AFAIU. That it works is sheer luck (because >> Emacs is very lenient with this stuff). The correct face definition >> for what you want is this (see 'set-face-attribute's doc string): >> >> (insert >> (propertize >> "TEST" 'font-lock-face >> '(:weight bold :background "yellow" :slant italic >> :foreground "red" :underline t))) >> >> If you use the above, foreground-color-at-point etc. will work as >> expected. >> >> I'm not sure we want to go out of our way to support the kind of face >> specifications that you used. > > However, if we do want that, we already have the technology: > > (face-attributes-as-vector (get-char-property (point) 'font-lock-face)) > > This will return a vector of face attribute values, where you can find > the value of any attribute you like. For example, to get the > foreground color, evaluate: > > (aref 9 > (face-attributes-as-vector (get-char-property (point) 'font-lock-face))) Hi Eli, Thank you very much for letting me know about `face-attributes-as-vector' (maybe its doc string could be improved?). It is exactly the function I need :-) In case you are interested, I attached an updated patch to faces.el that use this function to lookup face attribute, which improves and simplify the functions `faces--attribute-at-point', `foreground-color-at-point' and `background-color-at-point'. Regards --------------jc9jmD4ZSu4eEvrewgb9RJsw Content-Type: text/x-patch; charset=UTF-8; name="faces-attribute-lookup-V1.patch" Content-Disposition: attachment; filename="faces-attribute-lookup-V1.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZmFjZXMuZWwgYi9saXNwL2ZhY2VzLmVsCmluZGV4IDhmOTNm OWIyYzBjLi5lNjRkMzNjZjFkNiAxMDA2NDQKLS0tIGEvbGlzcC9mYWNlcy5lbAorKysgYi9s aXNwL2ZhY2VzLmVsCkBAIC0yMTA5LDUwICsyMTA5LDc0IEBAIGZhY2UtYXQtcG9pbnQKICAg ICAgICAgKGRlbGV0ZS1kdXBzIChucmV2ZXJzZSBmYWNlcykpCiAgICAgICAoY2FyIChsYXN0 IGZhY2VzKSkpKSkKIAotKGRlZnVuIGZhY2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgKGF0dHJp YnV0ZSAmb3B0aW9uYWwgYXR0cmlidXRlLXVubmFtZWQpCisoZGVmY29uc3QgZmFjZS0tYXR0 cmlidXRlLWluZGV4CisgIDs7IEZyb20gbGZhY2VfYXR0cmlidXRlX2luZGV4IGluIHNyYy9k aXNwZXh0ZXJuLmguCisgICcoKDpmYW1pbHkgICAgICAgICAgICAgLiAxKQorICAgICg6Zm91 bmRyeSAgICAgICAgICAgIC4gMikKKyAgICAoOndpZHRoICAgICAgICAgICAgICAuIDMpCisg ICAgKDpoZWlnaHQgICAgICAgICAgICAgLiA0KQorICAgICg6d2VpZ2h0ICAgICAgICAgICAg IC4gNSkKKyAgICAoOnNsYW50ICAgICAgICAgICAgICAuIDYpCisgICAgKDp1bmRlcmxpbmUg ICAgICAgICAgLiA3KQorICAgICg6aW52ZXJzZS12aWRlbyAgICAgIC4gOCkKKyAgICAoOnJl dmVyc2UtdmlkZW8gICAgICAuIDgpCisgICAgKDpmb3JlZ3JvdW5kICAgICAgICAgLiA5KQor ICAgICg6YmFja2dyb3VuZCAgICAgICAgIC4gMTApCisgICAgKDpzdGlwcGxlICAgICAgICAg ICAgLiAxMSkKKyAgICAoOm92ZXJsaW5lICAgICAgICAgICAuIDEyKQorICAgICg6c3RyaWtl LXRocm91Z2ggICAgIC4gMTMpCisgICAgKDpib3ggICAgICAgICAgICAgICAgLiAxNCkKKyAg ICAoOmZvbnQgICAgICAgICAgICAgICAuIDE1KQorICAgICg6aW5oZXJpdCAgICAgICAgICAg IC4gMTYpCisgICAgKDpmb250c2V0ICAgICAgICAgICAgLiAxNykKKyAgICAoOmRpc3RhbnQt Zm9yZWdyb3VuZCAuIDE4KQorICAgICg6ZXh0ZW5kICAgICAgICAgICAgIC4gMTkpCisgICAg KQorICAiSW5kaWNlcyBvZiBmYWNlIGF0dHJpYnV0ZXMgaW4gTGlzcCBmYWNlIHZlY3RvcnMu IikKKworKGRlZnN1YnN0IGZhY2UtLWF0dHJpYnV0ZS11bnNwZWNpZmllZC1wICh2YWx1ZSkK KyAgIlJldHVybiBub24tbmlsIGlmIGZhY2UgYXR0cmlidXRlIFZBTFVFIG1lYW5zIHVuc3Bl Y2lmaWVkLiIKKyAgKG1lbWJlciB2YWx1ZSAnKHVuc3BlY2lmaWVkICJ1bnNwZWNpZmllZC1m ZyIgInVuc3BlY2lmaWVkLWJnIikpKQorCisoZGVmdW4gZmFjZS1hdHRyaWJ1dGUtbG9va3Vw IChmYWNlIGF0dHJpYnV0ZSAmb3B0aW9uYWwgZGVmYXVsdCkKKyAgIlJldHVybiB0aGUgdmFs dWUgb2YgRkFDRSdzIEFUVFJJQlVURSBvciBuaWwgaWYgdW5zcGVjaWZpZWQuCitGQUNFIGlz IGEgdmFsaWQgZmFjZSBzcGVjaWZpY2F0aW9uLgorT3B0aW9uYWwgYXJndW1lbnQgREVGQVVM VCBpcyBhIGZhY2Ugc3BlY2lmaWNhdGlvbiBhcHBlbmRlZCB0byBGQUNFLgorSWYgREVGQVVM VCBpbmNsdWRlcyB0aGUgYGRlZmF1bHQnIGZhY2UsIHRoZSByZXR1cm4gdmFsdWUgaXMgYWx3 YXlzCitzcGVjaWZpZWQgYW5kIGFic29sdXRlLiIKKyAgKHdoZW4tbGV0ICgoaW5kZXggKGNk ciAoYXNzcSBhdHRyaWJ1dGUgZmFjZS0tYXR0cmlidXRlLWluZGV4KSkpCisgICAgICAgICAg ICAgKHZhbHVlIChhcmVmIChmYWNlLWF0dHJpYnV0ZXMtYXMtdmVjdG9yCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAoYXBwZW5kIChlbnN1cmUtbGlzdCBmYWNlKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoZW5zdXJlLWxpc3QgZGVmYXVsdCkpKQorICAg ICAgICAgICAgICAgICAgICAgICAgICBpbmRleCkpKQorICAgICh1bmxlc3MgKGZhY2UtLWF0 dHJpYnV0ZS11bnNwZWNpZmllZC1wIHZhbHVlKQorICAgICAgdmFsdWUpKSkKKworKGRlZnVu IGZhY2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgKGF0dHJpYnV0ZSkKICAgIlJldHVybiB0aGUg ZmFjZSBBVFRSSUJVVEUgYXQgcG9pbnQuCi1BVFRSSUJVVEUgaXMgYSBrZXl3b3JkLgotSWYg QVRUUklCVVRFLVVOTkFNRUQgaXMgbm9uLW5pbCwgaXQgaXMgYSBzeW1ib2wgdG8gbG9vayBm b3IgaW4KLXVubmFtZWQgZmFjZXMgKGUuZywgYGZvcmVncm91bmQtY29sb3InKS4iCitBVFRS SUJVVEUgaXMgYSBrZXl3b3JkLiIKICAgOzsgYGZhY2UtYXQtcG9pbnQnIGFsb25lIGlzIG5v dCBzdWZmaWNpZW50LiAgSXQgb25seSBnZXRzIG5hbWVkIGZhY2VzLgogICA7OyBOZWVkIGFs c28gcGljayB1cCBhbnkgZmFjZSBwcm9wZXJ0aWVzIHRoYXQgYXJlIG5vdCBhc3NvY2lhdGVk IHdpdGggbmFtZWQgZmFjZXMuCiAgIChsZXQgKChmYWNlcyAob3IgKGdldC1jaGFyLXByb3Bl cnR5IChwb2ludCkgJ3JlYWQtZmFjZS1uYW1lKQogICAgICAgICAgICAgICAgICAgIDs7IElm IGBmb250LWxvY2stbW9kZScgaXMgb24sIGBmb250LWxvY2stZmFjZScgdGFrZXMgcHJlY2Vk ZW5jZS4KICAgICAgICAgICAgICAgICAgICAoYW5kIGZvbnQtbG9jay1tb2RlCiAgICAgICAg ICAgICAgICAgICAgICAgICAoZ2V0LWNoYXItcHJvcGVydHkgKHBvaW50KSAnZm9udC1sb2Nr LWZhY2UpKQotICAgICAgICAgICAgICAgICAgIChnZXQtY2hhci1wcm9wZXJ0eSAocG9pbnQp ICdmYWNlKSkpCi0gICAgICAgIChmb3VuZCBuaWwpKQotICAgIChkb2xpc3QgKGZhY2UgKGlm IChmYWNlLWxpc3QtcCBmYWNlcykKLSAgICAgICAgICAgICAgICAgICAgICBmYWNlcwotICAg ICAgICAgICAgICAgICAgICAobGlzdCBmYWNlcykpKQotICAgICAgKGNvbmQgKGZvdW5kKQot ICAgICAgICAgICAgKChhbmQgZmFjZSAoc3ltYm9scCBmYWNlKSkKLSAgICAgICAgICAgICAo bGV0ICgodmFsdWUgKGZhY2UtYXR0cmlidXRlLXNwZWNpZmllZC1vcgotICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGZhY2UtYXR0cmlidXRlIGZhY2UgYXR0cmlidXRlIG5pbCB0KQot ICAgICAgICAgICAgICAgICAgICAgICAgICAgbmlsKSkpCi0gICAgICAgICAgICAgICAodW5s ZXNzIChtZW1iZXIgdmFsdWUgJyhuaWwgInVuc3BlY2lmaWVkLWZnIiAidW5zcGVjaWZpZWQt YmciKSkKLSAgICAgICAgICAgICAgICAgKHNldHEgZm91bmQgdmFsdWUpKSkpCi0gICAgICAg ICAgICAoKGNvbnNwIGZhY2UpCi0gICAgICAgICAgICAgKHNldHEgZm91bmQgKGNvbmQgKChh bmQgYXR0cmlidXRlLXVubmFtZWQKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAobWVtcSBhdHRyaWJ1dGUtdW5uYW1lZCBmYWNlKSkKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGNkciAobWVtcSBhdHRyaWJ1dGUtdW5uYW1lZCBmYWNlKSkpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChtZW1xIGF0dHJpYnV0ZSBmYWNlKSAo Y2FkciAobWVtcSBhdHRyaWJ1dGUgZmFjZSkpKSkpKSkpCi0gICAgKG9yIGZvdW5kCi0gICAg ICAgIChmYWNlLWF0dHJpYnV0ZSAnZGVmYXVsdCBhdHRyaWJ1dGUpKSkpCisgICAgICAgICAg ICAgICAgICAgKGdldC1jaGFyLXByb3BlcnR5IChwb2ludCkgJ2ZhY2UpKSkpCisgICAgKGZh Y2UtYXR0cmlidXRlLWxvb2t1cCBmYWNlcyBhdHRyaWJ1dGUgJ2RlZmF1bHQpKSkKIAogKGRl ZnVuIGZvcmVncm91bmQtY29sb3ItYXQtcG9pbnQgKCkKICAgIlJldHVybiB0aGUgZm9yZWdy b3VuZCBjb2xvciBvZiB0aGUgY2hhcmFjdGVyIGFmdGVyIHBvaW50LgogT24gVFRZIGZyYW1l cywgdGhlIHJldHVybmVkIGNvbG9yIG5hbWUgY2FuIGJlIFwidW5zcGVjaWZpZWQtZmdcIiwK IHdoaWNoIHN0YW5kcyBmb3IgdGhlIHVua25vd24gZGVmYXVsdCBmb3JlZ3JvdW5kIGNvbG9y IG9mIHRoZQogZGlzcGxheSB3aGVyZSB0aGUgZnJhbWUgaXMgZGlzcGxheWVkLiIKLSAgKGZh Y2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgOmZvcmVncm91bmQgJ2ZvcmVncm91bmQtY29sb3Ip KQorICAoZmFjZXMtLWF0dHJpYnV0ZS1hdC1wb2ludCA6Zm9yZWdyb3VuZCkpCiAKIChkZWZ1 biBiYWNrZ3JvdW5kLWNvbG9yLWF0LXBvaW50ICgpCiAgICJSZXR1cm4gdGhlIGJhY2tncm91 bmQgY29sb3Igb2YgdGhlIGNoYXJhY3RlciBhZnRlciBwb2ludC4KIE9uIFRUWSBmcmFtZXMs IHRoZSByZXR1cm5lZCBjb2xvciBuYW1lIGNhbiBiZSBcInVuc3BlY2lmaWVkLWJnXCIsCiB3 aGljaCBzdGFuZHMgZm9yIHRoZSB1bmtub3duIGRlZmF1bHQgYmFja2dyb3VuZCBjb2xvciBv ZiB0aGUKIGRpc3BsYXkgd2hlcmUgdGhlIGZyYW1lIGlzIGRpc3BsYXllZC4iCi0gIChmYWNl cy0tYXR0cmlidXRlLWF0LXBvaW50IDpiYWNrZ3JvdW5kICdiYWNrZ3JvdW5kLWNvbG9yKSkK KyAgKGZhY2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgOmJhY2tncm91bmQpKQogCiAMCiA7Ozs7 Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7 Ozs7Ozs7Ozs7Ozs7OzsK --------------jc9jmD4ZSu4eEvrewgb9RJsw-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 04:18:59 2023 Received: (at 65632) by debbugs.gnu.org; 31 Aug 2023 08:18:59 +0000 Received: from localhost ([127.0.0.1]:54814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbctG-0000wB-Uc for submit@debbugs.gnu.org; Thu, 31 Aug 2023 04:18:59 -0400 Received: from smtp-25.smtpout.orange.fr ([80.12.242.25]:51672 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbctC-0000vy-R2 for 65632@debbugs.gnu.org; Thu, 31 Aug 2023 04:18:58 -0400 Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id bct2qyXTdyd7jbct2qHLNh; Thu, 31 Aug 2023 10:18:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1693469925; bh=H0VL7uvDuyvw6Ab2v2QOFKeX/eU3iajvP3H9Z3QfyHA=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=EdsuTEWVDrRF8TGkMciwAr523kKwXbsVhNNxbzyEy36UE7I/L0IwWjB/L2bbTILKU yFOzEzkJ29/DTHZLlx15emRblpWS/yV/EYGuZTYNpROzHCml6PNEGZaptE+eJZ5LIB IEo4Gzjih00dc4uDm2qsRrb1iN1BK6M331QIu4QuRFkr1egcF0ATtx2rkfhKofkbtP +NUBrdRw+kZUKksKY31hDTFb7Wt9kJIASNQrGzl4h8NMEYCJu2V6oP2/B3hE6bbx1i UWKSZCcl1SVwlxDnYM7aAOQ65j7WTYZED6hIcKLCpWGfjbe7hgAZbg1ZQlcxHHYPAt FxZcn25yZmW/w== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Thu, 31 Aug 2023 10:18:45 +0200 X-ME-IP: 2.7.71.181 Content-Type: multipart/mixed; boundary="------------Y7y0fzqLt87nGn0iEFJ4ZZIP" Message-ID: Date: Thu, 31 Aug 2023 10:18:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: bug#65632: 30.0.50; Proposal to improve `faces--attribute-at-point'. From: David Ponce To: Eli Zaretskii References: <83jztcfkf4.fsf@gnu.org> <83h6ogfi7p.fsf@gnu.org> Content-Language: fr, en-US In-Reply-To: X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65632 Cc: 65632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) This is a multi-part message in MIME format. --------------Y7y0fzqLt87nGn0iEFJ4ZZIP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 31/08/2023 00:30, David Ponce wrote: > On 30/08/2023 21:22, Eli Zaretskii wrote: >>> Cc: 65632@debbugs.gnu.org >>> Date: Wed, 30 Aug 2023 21:35:11 +0300 >>> From: Eli Zaretskii >>> >>>> ;; Display "TEST" in red, bold, italic on yellow background. >>>> (insert >>>>    (propertize >>>>     "TEST" 'font-lock-face >>>>     '(bold ((:background "yellow") "italic" >>>>             ((foreground-color . "red") underline))))) >>> >>> This is not a valid face, AFAIU.  That it works is sheer luck (because >>> Emacs is very lenient with this stuff).  The correct face definition >>> for what you want is this (see 'set-face-attribute's doc string): >>> >>>    (insert >>>      (propertize >>>       "TEST" 'font-lock-face >>>       '(:weight bold :background "yellow" :slant italic >>>          :foreground "red" :underline t))) >>> >>> If you use the above, foreground-color-at-point etc. will work as >>> expected. >>> >>> I'm not sure we want to go out of our way to support the kind of face >>> specifications that you used. >> >> However, if we do want that, we already have the technology: >> >>    (face-attributes-as-vector (get-char-property (point) 'font-lock-face)) >> >> This will return a vector of face attribute values, where you can find >> the value of any attribute you like.  For example, to get the >> foreground color, evaluate: >> >>    (aref 9 >>      (face-attributes-as-vector (get-char-property (point) 'font-lock-face))) > > Hi Eli, > > Thank you very much for letting me know about `face-attributes-as-vector' > (maybe its doc string could be improved?).  It is exactly the function I need :-) > > In case you are interested, I attached an updated patch to faces.el that use > this function to lookup face attribute, which improves and simplify  the > functions `faces--attribute-at-point', `foreground-color-at-point' and > `background-color-at-point'. > > Regards Please find attached a revised patch. I used the name `faces-attribute' instead of `face-attribute-lookup' for consistency with `faces--attribute-at-point'. I simplified this new function because `face-attributes-as-vector' always returns the symbol `unspecified' when an attribute is not specified (according to what I understand of the implementation in xfaces.c). I also improved the doc string to include a link to the Elisp manual regarding the meaning of face specification. Here is an updated changelog: * faces.el: Improve attribute lookup of face at point. (face--attribute-index): New constant. (faces-attribute): New function. (faces--attribute-at-point): Use it. Remove unused argument. (foreground-color-at-point) (background-color-at-point): Call accordingly. Regards --------------Y7y0fzqLt87nGn0iEFJ4ZZIP Content-Type: text/x-patch; charset=UTF-8; name="faces-attribute-lookup-V2.patch" Content-Disposition: attachment; filename="faces-attribute-lookup-V2.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZmFjZXMuZWwgYi9saXNwL2ZhY2VzLmVsCmluZGV4IDhmOTNm OWIyYzBjLi4xZGIwYmJjY2YxZSAxMDA2NDQKLS0tIGEvbGlzcC9mYWNlcy5lbAorKysgYi9s aXNwL2ZhY2VzLmVsCkBAIC0yMTA5LDUwICsyMTA5LDcwIEBAIGZhY2UtYXQtcG9pbnQKICAg ICAgICAgKGRlbGV0ZS1kdXBzIChucmV2ZXJzZSBmYWNlcykpCiAgICAgICAoY2FyIChsYXN0 IGZhY2VzKSkpKSkKIAotKGRlZnVuIGZhY2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgKGF0dHJp YnV0ZSAmb3B0aW9uYWwgYXR0cmlidXRlLXVubmFtZWQpCisoZGVmY29uc3QgZmFjZS0tYXR0 cmlidXRlLWluZGV4CisgIDs7IEZyb20gbGZhY2VfYXR0cmlidXRlX2luZGV4IGluIHNyYy9k aXNwZXh0ZXJuLmguCisgICcoKDpmYW1pbHkgICAgICAgICAgICAgLiAxKQorICAgICg6Zm91 bmRyeSAgICAgICAgICAgIC4gMikKKyAgICAoOndpZHRoICAgICAgICAgICAgICAuIDMpCisg ICAgKDpoZWlnaHQgICAgICAgICAgICAgLiA0KQorICAgICg6d2VpZ2h0ICAgICAgICAgICAg IC4gNSkKKyAgICAoOnNsYW50ICAgICAgICAgICAgICAuIDYpCisgICAgKDp1bmRlcmxpbmUg ICAgICAgICAgLiA3KQorICAgICg6aW52ZXJzZS12aWRlbyAgICAgIC4gOCkKKyAgICAoOmZv cmVncm91bmQgICAgICAgICAuIDkpCisgICAgKDpiYWNrZ3JvdW5kICAgICAgICAgLiAxMCkK KyAgICAoOnN0aXBwbGUgICAgICAgICAgICAuIDExKQorICAgICg6b3ZlcmxpbmUgICAgICAg ICAgIC4gMTIpCisgICAgKDpzdHJpa2UtdGhyb3VnaCAgICAgLiAxMykKKyAgICAoOmJveCAg ICAgICAgICAgICAgICAuIDE0KQorICAgICg6Zm9udCAgICAgICAgICAgICAgIC4gMTUpCisg ICAgKDppbmhlcml0ICAgICAgICAgICAgLiAxNikKKyAgICAoOmZvbnRzZXQgICAgICAgICAg ICAuIDE3KQorICAgICg6ZGlzdGFudC1mb3JlZ3JvdW5kIC4gMTgpCisgICAgKDpleHRlbmQg ICAgICAgICAgICAgLiAxOSkKKyAgICApCisgICJJbmRpY2VzIG9mIGZhY2UgYXR0cmlidXRl cyBpbiBMaXNwIGZhY2UgdmVjdG9ycy4iKQorCisoZGVmdW4gZmFjZXMtYXR0cmlidXRlIChm YWNlIGF0dHJpYnV0ZSAmb3B0aW9uYWwgZGVmYXVsdCkKKyAgIlJldHVybiB0aGUgdmFsdWUg b2YgRkFDRSdzIEFUVFJJQlVURSBvciBuaWwgaWYgdW5zcGVjaWZpZWQuCitGQUNFIGlzIGEg dmFsaWQgZmFjZSBzcGVjaWZpY2F0aW9uIChzZWUgZGVzY3JpcHRpb24gb2YgdGhlIGBmYWNl JwordGV4dCBwcm9wZXJ0eSBpbiBJbmZvIG5vZGUgYChlbGlzcCkgU3BlY2lhbCBQcm9wZXJ0 aWVzJykuCitERUZBVUxUIGlzIGFuIG9wdGlvbmFsIGZhY2Ugc3BlY2lmaWNhdGlvbiBhcHBl bmRlZCB0byBGQUNFLiAgSWYKK0RFRkFVTFQgaW5jbHVkZXMgdGhlIGBkZWZhdWx0JyBmYWNl LCB0aGUgcmV0dXJuIHZhbHVlIGlzIGFsd2F5cworc3BlY2lmaWVkIGFuZCBhYnNvbHV0ZS4i CisgICh3aGVuLWxldCAoKGluZGV4IChjZHIgKGFzc3EgYXR0cmlidXRlIGZhY2UtLWF0dHJp YnV0ZS1pbmRleCkpKQorICAgICAgICAgICAgICh2YWx1ZSAoYXJlZiAoZmFjZS1hdHRyaWJ1 dGVzLWFzLXZlY3RvcgorICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFwcGVuZCAoZW5z dXJlLWxpc3QgZmFjZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVu c3VyZS1saXN0IGRlZmF1bHQpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgaW5kZXgp KSkKKyAgICAodW5sZXNzIChlcSB2YWx1ZSAndW5zcGVjaWZpZWQpCisgICAgICB2YWx1ZSkp KQorCisoZGVmdW4gZmFjZXMtLWF0dHJpYnV0ZS1hdC1wb2ludCAoYXR0cmlidXRlKQogICAi UmV0dXJuIHRoZSBmYWNlIEFUVFJJQlVURSBhdCBwb2ludC4KLUFUVFJJQlVURSBpcyBhIGtl eXdvcmQuCi1JZiBBVFRSSUJVVEUtVU5OQU1FRCBpcyBub24tbmlsLCBpdCBpcyBhIHN5bWJv bCB0byBsb29rIGZvciBpbgotdW5uYW1lZCBmYWNlcyAoZS5nLCBgZm9yZWdyb3VuZC1jb2xv cicpLiIKK0FUVFJJQlVURSBpcyBhIGtleXdvcmQuIgogICA7OyBgZmFjZS1hdC1wb2ludCcg YWxvbmUgaXMgbm90IHN1ZmZpY2llbnQuICBJdCBvbmx5IGdldHMgbmFtZWQgZmFjZXMuCiAg IDs7IE5lZWQgYWxzbyBwaWNrIHVwIGFueSBmYWNlIHByb3BlcnRpZXMgdGhhdCBhcmUgbm90 IGFzc29jaWF0ZWQgd2l0aCBuYW1lZCBmYWNlcy4KICAgKGxldCAoKGZhY2VzIChvciAoZ2V0 LWNoYXItcHJvcGVydHkgKHBvaW50KSAncmVhZC1mYWNlLW5hbWUpCiAgICAgICAgICAgICAg ICAgICAgOzsgSWYgYGZvbnQtbG9jay1tb2RlJyBpcyBvbiwgYGZvbnQtbG9jay1mYWNlJyB0 YWtlcyBwcmVjZWRlbmNlLgogICAgICAgICAgICAgICAgICAgIChhbmQgZm9udC1sb2NrLW1v ZGUKICAgICAgICAgICAgICAgICAgICAgICAgIChnZXQtY2hhci1wcm9wZXJ0eSAocG9pbnQp ICdmb250LWxvY2stZmFjZSkpCi0gICAgICAgICAgICAgICAgICAgKGdldC1jaGFyLXByb3Bl cnR5IChwb2ludCkgJ2ZhY2UpKSkKLSAgICAgICAgKGZvdW5kIG5pbCkpCi0gICAgKGRvbGlz dCAoZmFjZSAoaWYgKGZhY2UtbGlzdC1wIGZhY2VzKQotICAgICAgICAgICAgICAgICAgICAg IGZhY2VzCi0gICAgICAgICAgICAgICAgICAgIChsaXN0IGZhY2VzKSkpCi0gICAgICAoY29u ZCAoZm91bmQpCi0gICAgICAgICAgICAoKGFuZCBmYWNlIChzeW1ib2xwIGZhY2UpKQotICAg ICAgICAgICAgIChsZXQgKCh2YWx1ZSAoZmFjZS1hdHRyaWJ1dGUtc3BlY2lmaWVkLW9yCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAoZmFjZS1hdHRyaWJ1dGUgZmFjZSBhdHRyaWJ1 dGUgbmlsIHQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBuaWwpKSkKLSAgICAgICAg ICAgICAgICh1bmxlc3MgKG1lbWJlciB2YWx1ZSAnKG5pbCAidW5zcGVjaWZpZWQtZmciICJ1 bnNwZWNpZmllZC1iZyIpKQotICAgICAgICAgICAgICAgICAoc2V0cSBmb3VuZCB2YWx1ZSkp KSkKLSAgICAgICAgICAgICgoY29uc3AgZmFjZSkKLSAgICAgICAgICAgICAoc2V0cSBmb3Vu ZCAoY29uZCAoKGFuZCBhdHRyaWJ1dGUtdW5uYW1lZAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChtZW1xIGF0dHJpYnV0ZS11bm5hbWVkIGZhY2UpKQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoY2RyIChtZW1xIGF0dHJpYnV0ZS11bm5hbWVk IGZhY2UpKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKG1lbXEgYXR0cmli dXRlIGZhY2UpIChjYWRyIChtZW1xIGF0dHJpYnV0ZSBmYWNlKSkpKSkpKSkKLSAgICAob3Ig Zm91bmQKLSAgICAgICAgKGZhY2UtYXR0cmlidXRlICdkZWZhdWx0IGF0dHJpYnV0ZSkpKSkK KyAgICAgICAgICAgICAgICAgICAoZ2V0LWNoYXItcHJvcGVydHkgKHBvaW50KSAnZmFjZSkp KSkKKyAgICAoZmFjZXMtYXR0cmlidXRlIGZhY2VzIGF0dHJpYnV0ZSAnZGVmYXVsdCkpKQog CiAoZGVmdW4gZm9yZWdyb3VuZC1jb2xvci1hdC1wb2ludCAoKQogICAiUmV0dXJuIHRoZSBm b3JlZ3JvdW5kIGNvbG9yIG9mIHRoZSBjaGFyYWN0ZXIgYWZ0ZXIgcG9pbnQuCiBPbiBUVFkg ZnJhbWVzLCB0aGUgcmV0dXJuZWQgY29sb3IgbmFtZSBjYW4gYmUgXCJ1bnNwZWNpZmllZC1m Z1wiLAogd2hpY2ggc3RhbmRzIGZvciB0aGUgdW5rbm93biBkZWZhdWx0IGZvcmVncm91bmQg Y29sb3Igb2YgdGhlCiBkaXNwbGF5IHdoZXJlIHRoZSBmcmFtZSBpcyBkaXNwbGF5ZWQuIgot ICAoZmFjZXMtLWF0dHJpYnV0ZS1hdC1wb2ludCA6Zm9yZWdyb3VuZCAnZm9yZWdyb3VuZC1j b2xvcikpCisgIChmYWNlcy0tYXR0cmlidXRlLWF0LXBvaW50IDpmb3JlZ3JvdW5kKSkKIAog KGRlZnVuIGJhY2tncm91bmQtY29sb3ItYXQtcG9pbnQgKCkKICAgIlJldHVybiB0aGUgYmFj a2dyb3VuZCBjb2xvciBvZiB0aGUgY2hhcmFjdGVyIGFmdGVyIHBvaW50LgogT24gVFRZIGZy YW1lcywgdGhlIHJldHVybmVkIGNvbG9yIG5hbWUgY2FuIGJlIFwidW5zcGVjaWZpZWQtYmdc IiwKIHdoaWNoIHN0YW5kcyBmb3IgdGhlIHVua25vd24gZGVmYXVsdCBiYWNrZ3JvdW5kIGNv bG9yIG9mIHRoZQogZGlzcGxheSB3aGVyZSB0aGUgZnJhbWUgaXMgZGlzcGxheWVkLiIKLSAg KGZhY2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgOmJhY2tncm91bmQgJ2JhY2tncm91bmQtY29s b3IpKQorICAoZmFjZXMtLWF0dHJpYnV0ZS1hdC1wb2ludCA6YmFja2dyb3VuZCkpCiAKIAwK IDs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7 Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Owo= --------------Y7y0fzqLt87nGn0iEFJ4ZZIP-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 07:23:14 2023 Received: (at control) by debbugs.gnu.org; 31 Aug 2023 11:23:14 +0000 Received: from localhost ([127.0.0.1]:55073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbfla-0008Um-3J for submit@debbugs.gnu.org; Thu, 31 Aug 2023 07:23:14 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:50431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbflY-0008UQ-VE for control@debbugs.gnu.org; Thu, 31 Aug 2023 07:23:13 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5007abb15e9so1412117e87.0 for ; Thu, 31 Aug 2023 04:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693480979; x=1694085779; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=JwxCYlAp25t6C5GhrVRWlprVEv4DKoKjqCmygA9MfHw=; b=BHbZpBbHPd45ntHceByAZBnYDppOjZqIJe+y8x+0MerHpjzh99o7Z+vC4quvE6mxrW ovFXBvP3McJMt2I/O67SN4zfmbAywVmqtvlfESftLNIAaB4BDxynHyoNnpnivYzJbAGH KGutEE4PmKm5F6u+Wv3fafTa9bWW6D0vyj9mBH8rMER2uPSWgZm9JArpNqv1LGfZUSTs H+iZrTAvRbJdfuW7O2K102ccMdQBnn1Ueu6nI7eW4FKIG6/tYdMOzTGmXKkyH60OP74x ldGWEpQ/gzGbB+YXvA4irqXwQ/18fgte6kmnDqYnOH8olpdxTzJr2MkSwaFUQWT5RhI+ 0mUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693480979; x=1694085779; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JwxCYlAp25t6C5GhrVRWlprVEv4DKoKjqCmygA9MfHw=; b=exb2HzZ5mP0inm0OdW0xeRwKNLqhRxA52aBFe7J1gT1Gntbr5F+Vgky1eocVO3hB0n LsJcfz037YTQBRwaDcZddAJc63QKXUXWYI6SBtY5gq8p2b4UuttEGIWUDVDZUaDGhR9h 2FXEKk4HqIM0ctdn0dUoy4NnLsyyxU4NAq6BjaWQTHIa3PDiJ53l6YRQ5ZRSULV5CoR6 AYv99XRjCBerbp8lOsGnPsuwwuxvBsuXvymjn0iXoooRUU/nnax6ve4lM5RUX5AnBHWn tPhE1ZTcwXZs2MRNSwrfZJSoeA71fiz+sdzi77/ct3wsqqpuAbEdB0HVIymq+3n9Acue SfIw== X-Gm-Message-State: AOJu0YwKTsEdKSMLuM7zzlIulmb7e09RWPHpcVXh80OBFU8URT6vKbxi C0EMKObZ32zeYy1hFX+g8mnNWod5jFbSQ1JwTvV1WZnF4sc= X-Google-Smtp-Source: AGHT+IHARa49zQQ4SUxRsh2vy5zYIdPk8yVbcCpeFepUEExasHtc0i6tjCoa9ngoLnAudEOLQPT+1L5Vi2KOHE+a4bY= X-Received: by 2002:a05:6512:704:b0:500:b553:c09e with SMTP id b4-20020a056512070400b00500b553c09emr3342113lfs.32.1693480978843; Thu, 31 Aug 2023 04:22:58 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Thu, 31 Aug 2023 13:22:47 +0200 Message-ID: Subject: To: control Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 65632 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:132 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 65632 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 08:08:20 2023 Received: (at 65632) by debbugs.gnu.org; 31 Aug 2023 12:08:20 +0000 Received: from localhost ([127.0.0.1]:55107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbgTD-0003pt-T3 for submit@debbugs.gnu.org; Thu, 31 Aug 2023 08:08:20 -0400 Received: from smtp-16.smtpout.orange.fr ([80.12.242.16]:50035 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbgT8-0003ph-GF for 65632@debbugs.gnu.org; Thu, 31 Aug 2023 08:08:19 -0400 Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id bgSyqa9RMeQZhbgSyqorou; Thu, 31 Aug 2023 14:08:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1693483684; bh=949FSHfz1D2tZZa0hjqEYAmC90CeuPj3yAIxbAaUenM=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=CJqMNY47/5NC33QUWoP5+ov2gsMkAzfrvhdDkKOucpQB8n1lPWbpG0vSMGxWm7SHc 0E4buS1GYZE0R9AUEne51uAv4dpXcmfzDEgNLf5biqK8X69yIYY9EnItdJvqKFfIts ukl530B4jhG67+5LT09eosWpCt2jRA7kQbiS+ENWsrEgilULc7gRd1pcBp1AnsIkWu K6+jGsxgCDGMnkcoQblPQy68YyydiAi2CQtsXCjuBRh3akN4MYREK8m8zY7DyYUacW IlfprcwLWOWCEtAzXZNSy59B27y9/ppyP6ChtsVSiPuyBwMwFS9SO5bG3f6Ymv5KFz kl5qqqIqBwnTA== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Thu, 31 Aug 2023 14:08:04 +0200 X-ME-IP: 2.7.71.181 Content-Type: multipart/mixed; boundary="------------29SiAPRQ0xUJPOtDHKZq7JyT" Message-ID: <38a50cbe-14aa-dd11-9bbd-351db91729d4@orange.fr> Date: Thu, 31 Aug 2023 14:08:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: bug#65632: 30.0.50; Proposal to improve `faces--attribute-at-point'. From: David Ponce To: Eli Zaretskii References: <83jztcfkf4.fsf@gnu.org> <83h6ogfi7p.fsf@gnu.org> Content-Language: fr, en-US In-Reply-To: X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65632 Cc: 65632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) This is a multi-part message in MIME format. --------------29SiAPRQ0xUJPOtDHKZq7JyT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 31/08/2023 10:18, David Ponce wrote: > On 31/08/2023 00:30, David Ponce wrote: >> On 30/08/2023 21:22, Eli Zaretskii wrote: >>>> Cc: 65632@debbugs.gnu.org >>>> Date: Wed, 30 Aug 2023 21:35:11 +0300 >>>> From: Eli Zaretskii >>>> >>>>> ;; Display "TEST" in red, bold, italic on yellow background. >>>>> (insert >>>>>    (propertize >>>>>     "TEST" 'font-lock-face >>>>>     '(bold ((:background "yellow") "italic" >>>>>             ((foreground-color . "red") underline))))) >>>> >>>> This is not a valid face, AFAIU.  That it works is sheer luck (because >>>> Emacs is very lenient with this stuff).  The correct face definition >>>> for what you want is this (see 'set-face-attribute's doc string): >>>> >>>>    (insert >>>>      (propertize >>>>       "TEST" 'font-lock-face >>>>       '(:weight bold :background "yellow" :slant italic >>>>          :foreground "red" :underline t))) >>>> >>>> If you use the above, foreground-color-at-point etc. will work as >>>> expected. >>>> >>>> I'm not sure we want to go out of our way to support the kind of face >>>> specifications that you used. >>> >>> However, if we do want that, we already have the technology: >>> >>>    (face-attributes-as-vector (get-char-property (point) 'font-lock-face)) >>> >>> This will return a vector of face attribute values, where you can find >>> the value of any attribute you like.  For example, to get the >>> foreground color, evaluate: >>> >>>    (aref 9 >>>      (face-attributes-as-vector (get-char-property (point) 'font-lock-face))) >> >> Hi Eli, >> >> Thank you very much for letting me know about `face-attributes-as-vector' >> (maybe its doc string could be improved?).  It is exactly the function I need :-) >> >> In case you are interested, I attached an updated patch to faces.el that use >> this function to lookup face attribute, which improves and simplify  the >> functions `faces--attribute-at-point', `foreground-color-at-point' and >> `background-color-at-point'. >> >> Regards > > Please find attached a revised patch.  I used the name > `faces-attribute' instead of `face-attribute-lookup' for consistency > with `faces--attribute-at-point'.  I simplified this new function > because `face-attributes-as-vector' always returns the symbol > `unspecified' when an attribute is not specified (according to what I > understand of the implementation in xfaces.c).  I also improved the > doc string to include a link to the Elisp manual regarding the meaning > of face specification. > > Here is an updated changelog: > >     * faces.el: Improve attribute lookup of face at point. >     (face--attribute-index): New constant. >     (faces-attribute): New function. >     (faces--attribute-at-point): Use it.  Remove unused argument. >     (foreground-color-at-point) >     (background-color-at-point): Call accordingly. > > > > Regards Sorry, my previous patch was buggy. Here is the correct one. --------------29SiAPRQ0xUJPOtDHKZq7JyT Content-Type: text/x-patch; charset=UTF-8; name="faces-attribute-lookup-V3.patch" Content-Disposition: attachment; filename="faces-attribute-lookup-V3.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZmFjZXMuZWwgYi9saXNwL2ZhY2VzLmVsCmluZGV4IDhmOTNm OWIyYzBjLi42ZDdiZjJmNDEwZSAxMDA2NDQKLS0tIGEvbGlzcC9mYWNlcy5lbAorKysgYi9s aXNwL2ZhY2VzLmVsCkBAIC0yMTA5LDUwICsyMTA5LDY5IEBAIGZhY2UtYXQtcG9pbnQKICAg ICAgICAgKGRlbGV0ZS1kdXBzIChucmV2ZXJzZSBmYWNlcykpCiAgICAgICAoY2FyIChsYXN0 IGZhY2VzKSkpKSkKIAotKGRlZnVuIGZhY2VzLS1hdHRyaWJ1dGUtYXQtcG9pbnQgKGF0dHJp YnV0ZSAmb3B0aW9uYWwgYXR0cmlidXRlLXVubmFtZWQpCisoZGVmY29uc3QgZmFjZS0tYXR0 cmlidXRlLWluZGV4CisgIDs7IEZyb20gbGZhY2VfYXR0cmlidXRlX2luZGV4IGluIHNyYy9k aXNwZXh0ZXJuLmguCisgICcoKDpmYW1pbHkgICAgICAgICAgICAgLiAxKQorICAgICg6Zm91 bmRyeSAgICAgICAgICAgIC4gMikKKyAgICAoOndpZHRoICAgICAgICAgICAgICAuIDMpCisg ICAgKDpoZWlnaHQgICAgICAgICAgICAgLiA0KQorICAgICg6d2VpZ2h0ICAgICAgICAgICAg IC4gNSkKKyAgICAoOnNsYW50ICAgICAgICAgICAgICAuIDYpCisgICAgKDp1bmRlcmxpbmUg ICAgICAgICAgLiA3KQorICAgICg6aW52ZXJzZS12aWRlbyAgICAgIC4gOCkKKyAgICAoOmZv cmVncm91bmQgICAgICAgICAuIDkpCisgICAgKDpiYWNrZ3JvdW5kICAgICAgICAgLiAxMCkK KyAgICAoOnN0aXBwbGUgICAgICAgICAgICAuIDExKQorICAgICg6b3ZlcmxpbmUgICAgICAg ICAgIC4gMTIpCisgICAgKDpzdHJpa2UtdGhyb3VnaCAgICAgLiAxMykKKyAgICAoOmJveCAg ICAgICAgICAgICAgICAuIDE0KQorICAgICg6Zm9udCAgICAgICAgICAgICAgIC4gMTUpCisg ICAgKDppbmhlcml0ICAgICAgICAgICAgLiAxNikKKyAgICAoOmZvbnRzZXQgICAgICAgICAg ICAuIDE3KQorICAgICg6ZGlzdGFudC1mb3JlZ3JvdW5kIC4gMTgpCisgICAgKDpleHRlbmQg ICAgICAgICAgICAgLiAxOSkKKyAgICApCisgICJJbmRpY2VzIG9mIGZhY2UgYXR0cmlidXRl cyBpbiBMaXNwIGZhY2UgdmVjdG9ycy4iKQorCisoZGVmdW4gZmFjZXMtYXR0cmlidXRlIChm YWNlIGF0dHJpYnV0ZSAmb3B0aW9uYWwgZGVmYXVsdCkKKyAgIlJldHVybiB0aGUgdmFsdWUg b2YgRkFDRSdzIEFUVFJJQlVURSBvciBuaWwgaWYgdW5zcGVjaWZpZWQuCitGQUNFIGlzIGEg dmFsaWQgZmFjZSBzcGVjaWZpY2F0aW9uIChzZWUgZGVzY3JpcHRpb24gb2YgdGhlIGBmYWNl JwordGV4dCBwcm9wZXJ0eSBpbiBJbmZvIG5vZGUgYChlbGlzcCkgU3BlY2lhbCBQcm9wZXJ0 aWVzJykuCitERUZBVUxUIGlzIGFuIG9wdGlvbmFsIGZhY2Ugc3BlY2lmaWNhdGlvbiBhcHBl bmRlZCB0byBGQUNFLiAgSWYKK0RFRkFVTFQgaW5jbHVkZXMgdGhlIGBkZWZhdWx0JyBmYWNl LCB0aGUgcmV0dXJuIHZhbHVlIGlzIGFsd2F5cworc3BlY2lmaWVkIGFuZCBhYnNvbHV0ZS4i CisgICh3aGVuLWxldCAoKGluZGV4IChjZHIgKGFzc3EgYXR0cmlidXRlIGZhY2UtLWF0dHJp YnV0ZS1pbmRleCkpKQorICAgICAgICAgICAgICh2YWx1ZSAoYXJlZiAoZmFjZS1hdHRyaWJ1 dGVzLWFzLXZlY3RvcgorICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgZmFjZSBk ZWZhdWx0KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgaW5kZXgpKSkKKyAgICAodW5s ZXNzIChlcSB2YWx1ZSAndW5zcGVjaWZpZWQpCisgICAgICB2YWx1ZSkpKQorCisoZGVmdW4g ZmFjZXMtLWF0dHJpYnV0ZS1hdC1wb2ludCAoYXR0cmlidXRlKQogICAiUmV0dXJuIHRoZSBm YWNlIEFUVFJJQlVURSBhdCBwb2ludC4KLUFUVFJJQlVURSBpcyBhIGtleXdvcmQuCi1JZiBB VFRSSUJVVEUtVU5OQU1FRCBpcyBub24tbmlsLCBpdCBpcyBhIHN5bWJvbCB0byBsb29rIGZv ciBpbgotdW5uYW1lZCBmYWNlcyAoZS5nLCBgZm9yZWdyb3VuZC1jb2xvcicpLiIKK0FUVFJJ QlVURSBpcyBhIGtleXdvcmQuIgogICA7OyBgZmFjZS1hdC1wb2ludCcgYWxvbmUgaXMgbm90 IHN1ZmZpY2llbnQuICBJdCBvbmx5IGdldHMgbmFtZWQgZmFjZXMuCiAgIDs7IE5lZWQgYWxz byBwaWNrIHVwIGFueSBmYWNlIHByb3BlcnRpZXMgdGhhdCBhcmUgbm90IGFzc29jaWF0ZWQg d2l0aCBuYW1lZCBmYWNlcy4KICAgKGxldCAoKGZhY2VzIChvciAoZ2V0LWNoYXItcHJvcGVy dHkgKHBvaW50KSAncmVhZC1mYWNlLW5hbWUpCiAgICAgICAgICAgICAgICAgICAgOzsgSWYg YGZvbnQtbG9jay1tb2RlJyBpcyBvbiwgYGZvbnQtbG9jay1mYWNlJyB0YWtlcyBwcmVjZWRl bmNlLgogICAgICAgICAgICAgICAgICAgIChhbmQgZm9udC1sb2NrLW1vZGUKICAgICAgICAg ICAgICAgICAgICAgICAgIChnZXQtY2hhci1wcm9wZXJ0eSAocG9pbnQpICdmb250LWxvY2st ZmFjZSkpCi0gICAgICAgICAgICAgICAgICAgKGdldC1jaGFyLXByb3BlcnR5IChwb2ludCkg J2ZhY2UpKSkKLSAgICAgICAgKGZvdW5kIG5pbCkpCi0gICAgKGRvbGlzdCAoZmFjZSAoaWYg KGZhY2UtbGlzdC1wIGZhY2VzKQotICAgICAgICAgICAgICAgICAgICAgIGZhY2VzCi0gICAg ICAgICAgICAgICAgICAgIChsaXN0IGZhY2VzKSkpCi0gICAgICAoY29uZCAoZm91bmQpCi0g ICAgICAgICAgICAoKGFuZCBmYWNlIChzeW1ib2xwIGZhY2UpKQotICAgICAgICAgICAgIChs ZXQgKCh2YWx1ZSAoZmFjZS1hdHRyaWJ1dGUtc3BlY2lmaWVkLW9yCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAoZmFjZS1hdHRyaWJ1dGUgZmFjZSBhdHRyaWJ1dGUgbmlsIHQpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICBuaWwpKSkKLSAgICAgICAgICAgICAgICh1bmxl c3MgKG1lbWJlciB2YWx1ZSAnKG5pbCAidW5zcGVjaWZpZWQtZmciICJ1bnNwZWNpZmllZC1i ZyIpKQotICAgICAgICAgICAgICAgICAoc2V0cSBmb3VuZCB2YWx1ZSkpKSkKLSAgICAgICAg ICAgICgoY29uc3AgZmFjZSkKLSAgICAgICAgICAgICAoc2V0cSBmb3VuZCAoY29uZCAoKGFu ZCBhdHRyaWJ1dGUtdW5uYW1lZAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChtZW1xIGF0dHJpYnV0ZS11bm5hbWVkIGZhY2UpKQotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoY2RyIChtZW1xIGF0dHJpYnV0ZS11bm5hbWVkIGZhY2UpKSkKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKG1lbXEgYXR0cmlidXRlIGZhY2UpIChj YWRyIChtZW1xIGF0dHJpYnV0ZSBmYWNlKSkpKSkpKSkKLSAgICAob3IgZm91bmQKLSAgICAg ICAgKGZhY2UtYXR0cmlidXRlICdkZWZhdWx0IGF0dHJpYnV0ZSkpKSkKKyAgICAgICAgICAg ICAgICAgICAoZ2V0LWNoYXItcHJvcGVydHkgKHBvaW50KSAnZmFjZSkpKSkKKyAgICAoZmFj ZXMtYXR0cmlidXRlIGZhY2VzIGF0dHJpYnV0ZSAnZGVmYXVsdCkpKQogCiAoZGVmdW4gZm9y ZWdyb3VuZC1jb2xvci1hdC1wb2ludCAoKQogICAiUmV0dXJuIHRoZSBmb3JlZ3JvdW5kIGNv bG9yIG9mIHRoZSBjaGFyYWN0ZXIgYWZ0ZXIgcG9pbnQuCiBPbiBUVFkgZnJhbWVzLCB0aGUg cmV0dXJuZWQgY29sb3IgbmFtZSBjYW4gYmUgXCJ1bnNwZWNpZmllZC1mZ1wiLAogd2hpY2gg c3RhbmRzIGZvciB0aGUgdW5rbm93biBkZWZhdWx0IGZvcmVncm91bmQgY29sb3Igb2YgdGhl CiBkaXNwbGF5IHdoZXJlIHRoZSBmcmFtZSBpcyBkaXNwbGF5ZWQuIgotICAoZmFjZXMtLWF0 dHJpYnV0ZS1hdC1wb2ludCA6Zm9yZWdyb3VuZCAnZm9yZWdyb3VuZC1jb2xvcikpCisgIChm YWNlcy0tYXR0cmlidXRlLWF0LXBvaW50IDpmb3JlZ3JvdW5kKSkKIAogKGRlZnVuIGJhY2tn cm91bmQtY29sb3ItYXQtcG9pbnQgKCkKICAgIlJldHVybiB0aGUgYmFja2dyb3VuZCBjb2xv ciBvZiB0aGUgY2hhcmFjdGVyIGFmdGVyIHBvaW50LgogT24gVFRZIGZyYW1lcywgdGhlIHJl dHVybmVkIGNvbG9yIG5hbWUgY2FuIGJlIFwidW5zcGVjaWZpZWQtYmdcIiwKIHdoaWNoIHN0 YW5kcyBmb3IgdGhlIHVua25vd24gZGVmYXVsdCBiYWNrZ3JvdW5kIGNvbG9yIG9mIHRoZQog ZGlzcGxheSB3aGVyZSB0aGUgZnJhbWUgaXMgZGlzcGxheWVkLiIKLSAgKGZhY2VzLS1hdHRy aWJ1dGUtYXQtcG9pbnQgOmJhY2tncm91bmQgJ2JhY2tncm91bmQtY29sb3IpKQorICAoZmFj ZXMtLWF0dHJpYnV0ZS1hdC1wb2ludCA6YmFja2dyb3VuZCkpCiAKIAwKIDs7Ozs7Ozs7Ozs7 Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7 Ozs7Ozs7Owo= --------------29SiAPRQ0xUJPOtDHKZq7JyT-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 20:27:41 2025 Received: (at 65632) by debbugs.gnu.org; 23 Feb 2025 01:27:41 +0000 Received: from localhost ([127.0.0.1]:58167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tm0mT-0008Jv-5B for submit@debbugs.gnu.org; Sat, 22 Feb 2025 20:27:41 -0500 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:49394) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tm0mQ-0008Jc-6V for 65632@debbugs.gnu.org; Sat, 22 Feb 2025 20:27:39 -0500 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5deb1266031so6071583a12.2 for <65632@debbugs.gnu.org>; Sat, 22 Feb 2025 17:27:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740274052; x=1740878852; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=vlV5dYVh08kxQ8h5qNSLu2qzjFwpwltGP9ceWrKsoY8=; b=Qidip6xDm5rWBVHvWqIcsTZyhQmL/pQN1LxssvMlUHsRGrX0hz/VPaCaDyRaQxw4kE Ti1l9nkacLG3QX++x0cATIKg1/f3hKBicqWK0FNRJMkfW+vG12gwLdKrTE8elgEo1tUt cgFd5ES7M5+el1s6KOMEncmn/J5ajYYHltfbt9bYgsjM6eyKQTBSHMU7vnA2iIT3IaEU mbLNAXlmoa4WEIH+GpR44Zts47BjuTAmK1Cn8fMFgaIMqc3/hK0qGW95muAAtVb/Lro0 0FKjI9pQN4T9ZEZ8x+33BTCjiROLkZvTx9YwzteuoSmXhpKovjJHYdVQm/U91LKNFZBa fguA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740274052; x=1740878852; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vlV5dYVh08kxQ8h5qNSLu2qzjFwpwltGP9ceWrKsoY8=; b=jNsVGX8vRYTdXxJzqp3NYjqEKtb85NGXz58j/1brSeOGSMBg+pNcaI1mWKy8smo+lq aW5r19hIkGU34pJ0zMMgPk6UQR6O0QkbTaR///0nhwT3bGDTINMxk4Umixrz8p0riEKZ ZF1tKA5DLRFzP02YeoYi9k7233IaGduYmnNUOaImBaKnvzbg2BSDicaWDlsZAShvtqj/ Bs4SVNKbEWDs3fLDm/Hi/8lmZDeTEEpLI898Q0VitCOYXYkRF4/oRsDrBcfsZXuH3DXC sGpzmlk5tdc0tWZz2NHoWPp3qC+EYbnhxpiv3DMbKB4D8/YuvnmWRoTtUljradj0YVyt Oz0w== X-Forwarded-Encrypted: i=1; AJvYcCWgf/tOemQDm4/buWv0dgP4ZMoABC3Y1PzZ++5Fb16KiLW7I3m6FZhHm+vK47HkE4jZAtIYgg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy7To7R2MYyCPO5MoxXsx2Y5iuN8+jSpn04r/NiCnqd+2tfjRGB NSaEY50gplwk5hmv1j0XqOrJnV63F1mShw59CKc7tdUiFE1tECNOzYoGpTRRxPpxk+ygzoHLZf7 kvAVs3HfdxGvCQnNf6uLNYKg8VG0= X-Gm-Gg: ASbGnctB3fJZvA6B4cKQAb3420PcxQn1QTYN5Apww4YMh0nUh/AiERznFAJi9W7/9B3 TIbryE3rjynVWG0hGAABRsFdSKqMpT5RHHysPW9OUvz6bWjgtPJ1bCy15XWA7//GAIyOr0NXSGl u3azg0mDbJ X-Google-Smtp-Source: AGHT+IHP3a9BPDqfbu12hK37oODGWsYNVNqQcN1mctcy/sbYC00nEs62f9vT0zVHqXRKXP9H+He2Xp6h2LPLIzVXn0s= X-Received: by 2002:a05:6402:3707:b0:5e0:8937:6ef2 with SMTP id 4fb4d7f45d1cf-5e0b70e8747mr6779058a12.8.1740274051789; Sat, 22 Feb 2025 17:27:31 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 23 Feb 2025 01:27:31 +0000 From: Stefan Kangas In-Reply-To: <38a50cbe-14aa-dd11-9bbd-351db91729d4@orange.fr> References: <83jztcfkf4.fsf@gnu.org> <83h6ogfi7p.fsf@gnu.org> <38a50cbe-14aa-dd11-9bbd-351db91729d4@orange.fr> MIME-Version: 1.0 Date: Sun, 23 Feb 2025 01:27:31 +0000 X-Gm-Features: AWEUYZktEZvNsFZiPVq76fnRT9-XMVi9xdM3S0AMmSszF0vrOdhh03FkW4lQvS4 Message-ID: Subject: Re: bug#65632: 30.0.50; Proposal to improve `faces--attribute-at-point'. To: David Ponce Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65632 Cc: Eli Zaretskii , 65632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) David Ponce writes: > Sorry, my previous patch was buggy. Here is the correct one. (Sorry for the lack of a response for a long time here.) Could you please provide a rationale for these changes? IOW, what are they trying to achieve? Thanks in advance. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 20:27:46 2025 Received: (at control) by debbugs.gnu.org; 23 Feb 2025 01:27:47 +0000 Received: from localhost ([127.0.0.1]:58170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tm0mY-0008KF-KM for submit@debbugs.gnu.org; Sat, 22 Feb 2025 20:27:46 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:42347) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tm0mU-0008Ji-LS for control@debbugs.gnu.org; Sat, 22 Feb 2025 20:27:43 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5debbced002so6121026a12.1 for ; Sat, 22 Feb 2025 17:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740274056; x=1740878856; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=iBhFDkjtxCS7f0KiYYTZ0l2LgF/F+hcVIsg94xwrvIM=; b=UaJJDbKzl2P6k8oqQIbgDdh+vdldoEQNr0UiCkznsbusAz53q0x6F0yRVOEzB6Q90W k6pmfu5Liqon4MNbQ1tDYo+ozIidKIbwd+qsy+gqEbE2pLrbsUy3RvBZ6pxlx8kjDsEm EioB7K20PADr/0GoygMJUAge+DEIeiXyUnVcLoFCdcJ0ARj8w96K+H3hDmKEx8JXl5Fc kT826BG1nfOYCkikeVk1YUq+tCUJrGNGnMYuBcbYGAKj0XxxehuDSUgjHjaJTVQ9iTl8 yrZ1JUjDA+yjECF6CFnBtS+nqYakjbKODeMpcs4R3/cbY5Seyg1CZsbVRqKFAG76KJVU ESlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740274056; x=1740878856; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iBhFDkjtxCS7f0KiYYTZ0l2LgF/F+hcVIsg94xwrvIM=; b=hG46Fb0eomQocqVJgbQ9i/9Es+ku6nkEjUw0zDRVZJ6/xXhFtaSi/Zn8eQlUDWSVCu NU/RWkOx6445TyCO2nZcl3p/65rPNX0MAtdHX+h71QKSSzD5YYeToMc6oPdQ5TxGwbw1 HMjBExG6PlM+lCOqjW4kawhT8EWdn+3VI8swTiraHTiQ7PCRJwQyb+4qd1qj5nL9ax3A 7VSawBXnjLOGSSIx/VF2qKHEt4fXCWKSY51nzitNH9zK9KRxLqmQZAnBPm7DtRKdbfi9 cOumLbAeVGrD9gsvm1qcjGjLHuY+9QOaXr7cnjVGVaSkgzVFHIeII40bDIoMIq3BlvvM 2WIg== X-Gm-Message-State: AOJu0YxdNs+IkpKQUgV93BNKohecMiiGs7hdWD1y77aDeDIRBJE8gVLd fKhcMhlmNyn4GAPvzQ9RYruXFBAkCRnKkWglEUmHbx9UN12B+9wCgkMgGZOZA0EYL1++bD8+LBw V54M4RmBCC2cEWrL5NojKCXRNi8cSDhRN1jYsGA== X-Gm-Gg: ASbGnctDV/aqfCa8NGLpzGLxw1xMxi1NQmcb3Bz47Jbx1asYAeVxkSuvuhbGMMSgcYI 9pQTNUKUbNXAd2nPt5ajlARZerYQ+7jH+Dqv4DqzApLtXeQAr0gxeic10LMGMWnpTj5WT5tyRrS wlyXJdNHww X-Google-Smtp-Source: AGHT+IEUuCHto3CmQ7yp/diyi7ikkHiiysqUsdbSnsWko+PkBcZzyX27W+hYqeEsWpDJz4YeNxydoxM6kJs+Vm+v68c= X-Received: by 2002:a05:6402:90b:b0:5e0:6e6c:e2b5 with SMTP id 4fb4d7f45d1cf-5e0a1261230mr12013600a12.9.1740274056503; Sat, 22 Feb 2025 17:27:36 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 23 Feb 2025 01:27:36 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 23 Feb 2025 01:27:36 +0000 X-Gm-Features: AWEUYZnnZ2ZhHBa9YZwKMq1ZHRB4wPDfDKdjAgDBLEYLcuU335LBq6VRPxG_1qU Message-ID: Subject: control message for bug #65632 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 65632 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 20:27:52 2025 Received: (at control) by debbugs.gnu.org; 23 Feb 2025 01:27:52 +0000 Received: from localhost ([127.0.0.1]:58173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tm0md-0008Kd-Up for submit@debbugs.gnu.org; Sat, 22 Feb 2025 20:27:52 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:42346) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tm0mZ-0008Jx-4r for control@debbugs.gnu.org; Sat, 22 Feb 2025 20:27:47 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5debbced002so6121072a12.1 for ; Sat, 22 Feb 2025 17:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740274061; x=1740878861; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=W44G3J1Mwr3acYea/nbnIow0ZAmbzds4QvYoRjoq65Y=; b=XdFPHJyxXcPNfyByGS7CuSzGJvOKeD6Vt6Q0e7/makUpjpjRK2AGy/KbtehHasid3C XdJaesNQwu5dvBCDF7g4EGTObc6xPhftHSFAiC4NCes+orwMgsdEnrIGVATqVbbeCf3o JDeQW2fKZgp6TXDFCocVXI1TQDCbwqxtszB+ikdtKADHvagICZoUdkUwxXTlSH7xQFqd 7dhzboxUS38okLuCplErjfsbuDWp9P+oAyvCKQpOD+0OdzGpGkdViEpGsjiH1dhSRW6H R8oMYoDXK6vOvfpAungRJND5aPTbqpIJQ/0TStjWm2J1NnXAItf/tg68GKAcCMVxKcVD R9EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740274061; x=1740878861; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=W44G3J1Mwr3acYea/nbnIow0ZAmbzds4QvYoRjoq65Y=; b=SRjQEKw1mnrVWTnNFodMZjJr0Fh9bXAgjl1hXjPOTt08fTVI7OYi0XVfmb5oD8lTVA EnUYohw5qmYSz71sensVNNKnUHWKR3+iQ1W/L9IxF6z72YGC4MrLvTXjTWuPW0FG2al0 P+SHWrVvVDKw1nD5GDy6REHwEgiU/UZHhXNmN8wDWh7tsXs8n71xhAr+IchjKaK5ccX6 UsI36TahffGzJZfLknh8ofUxrv1qA+iQerkSDLTm4NILq33oICltnPuNtBxnXqWtHEA3 Cqbi+TdK/R6NEWSsbE/FhrO1Szv1z3cB++taNBeBXSdh6gr9Va4TvlkFs6vWOnv/3o+3 NrVQ== X-Gm-Message-State: AOJu0YwifraAQdXvdFNLNd4BW72J1xzR/e2R7wklzWhiSSDUHVqid1Dy vFsLBtNzA0hv3GUn/faqfC+80TVeHwl6K6/WSLNVMFhbChU2Wocdaq7gPv1lJpoNIx1VaJ1I4Ms ppBMKqjjIukuJ/IwK2cNSKGxkMXF93VVeOpRhcw== X-Gm-Gg: ASbGncukL6n5+lZl8QvgU9nqhYjOsTFBgHi2sk4SJUE9fny6icAlHiO/mp9JAOp/8T6 OYyL7XoMcUzFL8yN/bcDeWireHxmt4G2qdYVfZr3753AbxIzFNs+Q+N/4UWPuFxPJtHkKCbD2It J/h8f/MnRZ X-Google-Smtp-Source: AGHT+IFmMR0jT+tRmaK4Re3USJSXA6jlrXs9J41ByXOzVzpcHnns1ED1i3weM2M9Nc1vGn1QIEaV0B6f/aHlp7shUts= X-Received: by 2002:a05:6402:40c1:b0:5de:4f4c:3780 with SMTP id 4fb4d7f45d1cf-5e0a12212afmr10617647a12.5.1740274060867; Sat, 22 Feb 2025 17:27:40 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 23 Feb 2025 01:27:40 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 23 Feb 2025 01:27:40 +0000 X-Gm-Features: AWEUYZlJ-MKHLNeKSMnxBrloqNC9MwWqTT4_JRRIoMIvtKTiOQYdt5V55aIilT0 Message-ID: Subject: control message for bug #65632 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 65632 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 06:01:50 2025 Received: (at 65632) by debbugs.gnu.org; 24 Feb 2025 11:01:50 +0000 Received: from localhost ([127.0.0.1]:38677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tmWDe-0001bX-Gq for submit@debbugs.gnu.org; Mon, 24 Feb 2025 06:01:50 -0500 Received: from smtp-65.smtpout.orange.fr ([80.12.242.65]:50503 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtps (TLS1.2:RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tmWDb-0001bN-7p for 65632@debbugs.gnu.org; Mon, 24 Feb 2025 06:01:48 -0500 Received: from [192.168.1.21] ([90.112.40.65]) by smtp.orange.fr with ESMTPA id mWDVtbDrexgLFmWDYt1E8P; Mon, 24 Feb 2025 12:01:45 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1740394905; bh=sWm+Z9jKslBjf+bJWSdt341nZq3FhuHqHv3y6CJUOoo=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=YrVJeBPCNGvy9oeZhZJiCOAoOO3FCqeZBk9Pknj3FdYYIJIP7MJM4vO7UF2xLCIh3 tawRPlKs0Fgoh7h3zXETYcM1Sh7MIHhwXvRM2O4g2a0oDdvgcCUvF2sYLOOe6rWOvb x2y/M8srsLtHsk6aSSfbNngIlTUWz4k9cOYOUTPX7Oe6SS9K2NuyORKQCMZmpm3oyp pU7xNtPo0uqazb3J0wshcg0wW/3Fc3UAZizIHmhnUGQtJN4cm5uKiUDpI7Bw+oU6fs F0SXczabSqXB0sPYj8yy/qWw22GvsqFKOBwnBlJc0HmCCE/FeNzacKL5z8Ih7nqtdN yegVyDGsSFSpA== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Mon, 24 Feb 2025 12:01:45 +0100 X-ME-IP: 90.112.40.65 Message-ID: Date: Mon, 24 Feb 2025 12:01:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#65632: 30.0.50; Proposal to improve `faces--attribute-at-point'. To: Stefan Kangas References: <83jztcfkf4.fsf@gnu.org> <83h6ogfi7p.fsf@gnu.org> <38a50cbe-14aa-dd11-9bbd-351db91729d4@orange.fr> Content-Language: fr, en-US From: David Ponce In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65632 Cc: Eli Zaretskii , 65632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-02-23 02:27, Stefan Kangas wrote: > David Ponce writes: > >> Sorry, my previous patch was buggy. Here is the correct one. > > (Sorry for the lack of a response for a long time here.) > > Could you please provide a rationale for these changes? IOW, what are > they trying to achieve? Thanks in advance. Hello Stefan, Sincerely, I thought this bug was closed a long time ago. The rationale of this proposal was to handle any possible face spec returned by (get-char-property (point) 'face) in `faces--attribute-at-point' (by using `face-attributes-as-vector'), because in some corner cases the current implementation can return a wrong attribute value, as illustrated by the simple recipe in my initial post. However, if I correctly understand Eli's objection, I agree that the face spec in my recipe can be considered as invalid, and not supported by `faces--attribute-at-point', even if a such face spec is an accepted text property, probably for backward compatibility. Thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 11:35:02 2025 Received: (at 65632-done) by debbugs.gnu.org; 24 Feb 2025 16:35:02 +0000 Received: from localhost ([127.0.0.1]:42239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tmbQ6-0001zS-Am for submit@debbugs.gnu.org; Mon, 24 Feb 2025 11:35:02 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:50474) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tmbQ4-0001ye-BR for 65632-done@debbugs.gnu.org; Mon, 24 Feb 2025 11:35:00 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5e04861e7a6so8707480a12.1 for <65632-done@debbugs.gnu.org>; Mon, 24 Feb 2025 08:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740414894; x=1741019694; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=iEmljvM7ZXxC65KH0q9tAjsQV23Ik9EKY/NSzwZB0M0=; b=GdvLhBarl1xZeZT2kzIut5kddims5YcymSn69X4ZQ4u64E2ZVy5Mb/qETYxX1niKpS BgrOcnPcQIPAcbC2mxWvK3vCNepOFzcS8FWRD9ha+p3GeIdQaF2m4ihVxrEziKliSP+y Ypf9Ose6cdz2bDfDAxgwI06YBoeuva1F+gK7l9nzxKeaKMhuDEW4ETBuNVVfWgyaIvA6 NNR4v934TIdRvcZZdLMeiY6m+d+DKDnokarDmPW1gmFQQ+NNwF+r+onGf0XlWAUc/lDW 8h0kF/3NWRweeVH40adhA2w/bWRUhAuYXIh4WUrPYUiTIW+FMGODweXZPT+TnX4Pmy2M UEgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740414894; x=1741019694; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iEmljvM7ZXxC65KH0q9tAjsQV23Ik9EKY/NSzwZB0M0=; b=xAuhsbXY5LrxTfAIetX3MH8/ho9TgstqGI3AAEivj8al46mTPlITd668oOWPY7tB7S cIDA8ffOVLoaMksx5Ps7htBf0BZTOrQ5AKCEo+SP544q2Oer2dO9z5hAiEx+jo7QAk1o W4rigAW1yo1/Nq6LKWx4E1wiOtXfSb7iE/hYdwTWJPYAs0/wLG/oTcJIhWuiaDvgewnL pfyHwsN4ugwVoUOTWeUk/LhpxPmKbyusczzagWSq+RlhpKchboSRELgQ2FmLajevA5g1 mNpHYSw/5qOi+zimLnPEr/v/Q8+QUypjzhv51enRUEzZzq5WRE25j6ZbyGGbSK0Z/qgY GE5A== X-Forwarded-Encrypted: i=1; AJvYcCVrxSIDlvBRlgRMPnOC7MA8QJp7CeWpzuF0i63M0h5eHWtPdTk/r+EJ4XLXZaOKDS9bEsEW9tamFwh0@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyxj96HFVDTUY35l4GXnP50E7ZD3k4k15Q8W/w29a6ALsw1hpQx 7d7kl7bsMqLyDHzWreo591NphCh55gvHJLw9ouHCNwH03HFUHUUShXCitf7W1HcCOijQlzResJM rgSd/pbgH6zgPFgFWjehFyzJ5w8w= X-Gm-Gg: ASbGncsNS2gl5P52Qvc0KvsXXPUv0JSR/A2uHeti5Fwt+ezCtkh/1O4E5P+ByIC6w2M oa0Q0vMRh1QebXMEIjbUHohnzbNk0434PcQrvpPoYhLTNvuedaPOUJL/ZPcUm1i4pNWg4Eemesv cf4qd9JTQ2 X-Google-Smtp-Source: AGHT+IGe0Ut9Z3xwM4CopLHoXda6qFJI+h/ht7xvsww1tNvP15DGG29vUENYj2X3MzxPN4GP63BJUeV3a7yrqdX6RGM= X-Received: by 2002:a05:6402:2114:b0:5db:f26d:fff1 with SMTP id 4fb4d7f45d1cf-5e0b7246e2amr10799071a12.21.1740414894098; Mon, 24 Feb 2025 08:34:54 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 24 Feb 2025 16:34:53 +0000 From: Stefan Kangas In-Reply-To: References: <83jztcfkf4.fsf@gnu.org> <83h6ogfi7p.fsf@gnu.org> <38a50cbe-14aa-dd11-9bbd-351db91729d4@orange.fr> MIME-Version: 1.0 Date: Mon, 24 Feb 2025 16:34:53 +0000 X-Gm-Features: AWEUYZlGyNkqQ1LUI26bdsRSckN-F3MS1GT_kSwiiUAuC4GpvqmanlbsXfIgNs4 Message-ID: Subject: Re: bug#65632: 30.0.50; Proposal to improve `faces--attribute-at-point'. To: David Ponce Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65632-done Cc: Eli Zaretskii , 65632-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) David Ponce writes: > Sincerely, I thought this bug was closed a long time ago. [...] OK, thanks. I'm therefore closing this bug report now. From unknown Thu Jun 19 14:14:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 25 Mar 2025 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator