GNU bug report logs - #65627
28.2; erc-button-url-regexp does not recognise gophers://

Previous Next

Package: emacs;

Reported by: Troels Henriksen <athas <at> sigkill.dk>

Date: Wed, 30 Aug 2023 16:36:02 UTC

Severity: normal

Found in version 28.2

Fixed in version 29.2

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65627: closed (28.2; erc-button-url-regexp does not recognise
 gophers://)
Date: Wed, 30 Aug 2023 19:03:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 30 Aug 2023 21:01:52 +0200
with message-id <CADwFkmmhb0tWMVqibroSFUzZv9rvLWZ=cZ-nYY6pEfj4z0V_Rg <at> mail.gmail.com>
and subject line Re: bug#65627: 28.2; erc-button-url-regexp does not recognise gophers://
has caused the debbugs.gnu.org bug report #65627,
regarding 28.2; erc-button-url-regexp does not recognise gophers://
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65627: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65627
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Troels Henriksen <athas <at> sigkill.dk>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.2; erc-button-url-regexp does not recognise gophers://
Date: Wed, 30 Aug 2023 13:03:31 +0200
The regex in

  browse-url-button-regexp

does not recognise the gophers:// protocol.  Similarly to https://,
gophers:// is an encrypted variant of the venerable Gopher protocol.
The gophers protocol is supported in curl and other programs that build
on libcurl, and while I can customize `browse-url-button-regexp` myself,
I think it would be useful for all Emacs users if Emacs recognised
gophers:// directly.

A fix is simple: just add 's?' after 'gopher' in the regexp.


[Message part 3 (message/rfc822, inline)]
From: Stefan Kangas <stefankangas <at> gmail.com>
To: Troels Henriksen <athas <at> sigkill.dk>
Cc: 65627-done <at> debbugs.gnu.org
Subject: Re: bug#65627: 28.2;
 erc-button-url-regexp does not recognise gophers://
Date: Wed, 30 Aug 2023 21:01:52 +0200
Version: 29.2

> The regex in
>
>   browse-url-button-regexp
>
> does not recognise the gophers:// protocol.  Similarly to https://,
> gophers:// is an encrypted variant of the venerable Gopher protocol.
> The gophers protocol is supported in curl and other programs that build
> on libcurl, and while I can customize `browse-url-button-regexp` myself,
> I think it would be useful for all Emacs users if Emacs recognised
> gophers:// directly.
>
> A fix is simple: just add 's?' after 'gopher' in the regexp.

Thanks for the bug report.

I see that it is supported by libcurl, here: https://curl.se/libcurl/
There is also FTPS, which we don't have in our regexp.

So I've now fixed this on the master branch (commit 9e2d5a013c9), and
I'm closing this bug.


This bug report was last modified 1 year and 287 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.