GNU bug report logs - #65625
30.0.50; electric-pair-skip-whitespace-chars choice looks wrong

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Wed, 30 Aug 2023 15:36:02 UTC

Severity: normal

Found in version 30.0.50

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mauro Aranda <maurooaranda <at> gmail.com>
Subject: bug#65625: closed (Re: bug#65625: 30.0.50; electric-pair-skip-whitespace-chars
 choice looks wrong)
Date: Thu, 31 Aug 2023 06:26:01 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#65625: 30.0.50; electric-pair-skip-whitespace-chars choice looks wrong

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65625 <at> debbugs.gnu.org.

-- 
65625: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65625
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 65625-done <at> debbugs.gnu.org
Subject: Re: bug#65625: 30.0.50; electric-pair-skip-whitespace-chars choice
 looks wrong
Date: Thu, 31 Aug 2023 08:24:58 +0200
Version: 30.1

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> What's important here is that the 2nd choice lets the user choose only
> one whitespace character, while it seems pretty clear to me
> that the intention was for the user to be able to customize it to a list
> of whitespace characters, not just to a list of one.  And that's what
> the repeat widget is for, so yes, it is a real improvement.

OK, makes sense.

> I attach a patch.

Thanks.  Installed on master as commit 4adedd29961, and I'm closing this bug.

[Message part 3 (message/rfc822, inline)]
From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; electric-pair-skip-whitespace-chars choice looks wrong
Date: Wed, 30 Aug 2023 12:34:43 -0300
Looking at the electric-pair-skip-whitespace-chars defcustom:

(defcustom electric-pair-skip-whitespace-chars (list ?\t ?\s ?\n)
  "Whitespace characters considered by `electric-pair-skip-whitespace'."
  :version "24.4"
  :group 'electricity
  :type '(choice (set (const :tag "Space" ?\s)
                      (const :tag "Tab" ?\t)
                      (const :tag "Newline" ?\n))
                 (list character)))

I think the 2nd choice should be (repeat character) rather than
(list character).




This bug report was last modified 1 year and 322 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.