GNU bug report logs - #65621
[PATCH] `dired-next-line' go to meaningful line

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Shynur Xie <one.last.kiss <at> outlook.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>, "65621 <at> debbugs.gnu.org" <65621 <at> debbugs.gnu.org>
Subject: bug#65621: [PATCH] `dired-next-line' go to meaningful line
Date: Thu, 31 Aug 2023 23:35:26 +0200

Shynur Xie <one.last.kiss <at> outlook.com> writes:

> The final patch is attached.  (See the end for how to test it.)

Thanks.

> There is totally 4 (not 6) kinds of combinations of the 2 new options:
>
>   1. (setq dired-cursor-goto-meaningful-line 'bounded
>            dired-headerline-is-meaningful nil)
>   2. (setq dired-cursor-goto-meaningful-line 'cycle
>            dired-headerline-is-meaningful nil)
>   3. (setq dired-cursor-goto-meaningful-line 'bounded
>            dired-headerline-is-meaningful t)
>   4. (setq dired-cursor-goto-meaningful-line 'cycle
>            dired-headerline-is-meaningful t)

I'll review your patch in detail as soon as I can find some time.
Just two initial comments:

I like the option `dired-cursor-goto-meaningful-line', which seems to
both add wrap-around and make the feature as a whole optional.  But in
Emacs, we say "point" rather than "cursor", so we'd have to change
that.  I suggest naming it `dired-movement-style', or something along
those lines.

But is `dired-headerline-is-meaningful' really needed?  It seems like
an unnecessary complication.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.