GNU bug report logs - #65609
30.0.50; inhibit-eol-conversion breaks revert-buffer

Previous Next

Package: emacs;

Reported by: Andrew Scott <andj.scott <at> gmail.com>

Date: Wed, 30 Aug 2023 07:19:02 UTC

Severity: normal

Found in version 30.0.50

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 65609 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Gerd Möllmann <gerd.moellmann <at> gmail.com>,
 "Herbert J. Skuhra" <herbert <at> gojira.at>, 65609 <at> debbugs.gnu.org,
 Andrew Scott <andj.scott <at> gmail.com>
Subject: Re: bug#65609: 30.0.50; inhibit-eol-conversion breaks revert-buffer
Date: Wed, 30 Aug 2023 21:43:23 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks for an easy test case.  We are reading too much from the file
> on disk when reverting in this case.
>
> Po Lu, I think we need the patch below to fix this.  Gerd, does this
> solve your problem as well, including the abort during bootstrap?
> Herbert, I think this could also be related to the problems you see,
> so please try the patch below.
>
> diff --git a/src/fileio.c b/src/fileio.c
> index 23e1a83..8919e08 100644
> --- a/src/fileio.c
> +++ b/src/fileio.c
> @@ -4805,7 +4805,7 @@ DEFUN ("insert-file-contents", Finsert_file_contents, Sinsert_file_contents,
>  
>  	/* 'try' is reserved in some compilers (Microsoft C).  */
>  	ptrdiff_t trytry = min (gap_size, READ_BUF_SIZE);
> -	if (!NILP (end))
> +	if (seekable || !NILP (end))
>  	  trytry = min (trytry, total - inserted);
>  
>  	if (!seekable && NILP (end))

I don't believe this should incur any difficulties upon the Android
port, so please proceed with installing it if it works.
This bug report was last modified 1 year and 259 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.