Subject: bug#65609: 30.0.50; inhibit-eol-conversion breaks revert-buffer

From: Eli Zaretskii <[email-masked]>
Date: Wed, 30 Aug 2023 17:22:46 +0300

> Date: Wed, 30 Aug 2023 15:42:48 +0200
> Cc: [email-masked]
> From: Gerd Möllmann <[email-masked]>
> 
> On 30.08.23 15:26, Eli Zaretskii wrote:
> > Po Lu, I think we need the patch below to fix this.  Gerd, does this
> > solve your problem as well, including the abort during bootstrap?
> > Herbert, I think this could also be related to the problems you see,
> > so please try the patch below.
> > 
> > diff --git a/src/fileio.c b/src/fileio.c
> > index 23e1a83..8919e08 100644
> > --- a/src/fileio.c
> > +++ b/src/fileio.c
> > @@ -4805,7 +4805,7 @@ DEFUN ("insert-file-contents", Finsert_file_contents, Sinsert_file_contents,
> >   
> >   	/* 'try' is reserved in some compilers (Microsoft C).  */
> >   	ptrdiff_t trytry = min (gap_size, READ_BUF_SIZE);
> > -	if (!NILP (end))
> > +	if (seekable || !NILP (end))
> >   	  trytry = min (trytry, total - inserted);
> >   
> >   	if (!seekable && NILP (end))
> 
> With this patch, the abort during bootstrap no longer happens.

Thanks for testing.

> Thanks!  That was quick ;-).

It was an easy test case and a stunning failure.