From unknown Thu Jun 19 16:21:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65605 <65605@debbugs.gnu.org> To: bug#65605 <65605@debbugs.gnu.org> Subject: Status: [PATCH] Command and option to make Edmacro better for long sequences Reply-To: bug#65605 <65605@debbugs.gnu.org> Date: Thu, 19 Jun 2025 23:21:16 +0000 retitle 65605 [PATCH] Command and option to make Edmacro better for long se= quences reassign 65605 emacs submitter 65605 Okamsn severity 65605 wishlist tag 65605 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 21:18:32 2023 Received: (at submit) by debbugs.gnu.org; 30 Aug 2023 01:18:32 +0000 Received: from localhost ([127.0.0.1]:51830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb9qp-00068K-Dj for submit@debbugs.gnu.org; Tue, 29 Aug 2023 21:18:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:52726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb9ql-000683-Fc for submit@debbugs.gnu.org; Tue, 29 Aug 2023 21:18:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qb9qY-0005Cb-C8 for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2023 21:18:14 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qb9qV-0006F1-0M for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2023 21:18:14 -0400 Date: Wed, 30 Aug 2023 01:17:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1693358286; x=1693617486; bh=eYwyMAY++POc+j8q98iM0OKE76bISparbwuasoff2Wg=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=VkQyITtrXea/fEAA6JNuUDFU/F7VOHfGrcQnJi0Kwf4fA1Jntn9ogGDHjR8TcV+91 f9AldNlb4I+hwTJyyI+2Iocn5CM/s3GfGnlZmWctob0tZMR68zLCc+HrA6BmGSDjUs jfEqmnBO9WscVm+o2mXVr4BjVEvT1ZE4q7Ywhp/c2A5YtgweRi4VfhyueQkrm2j4Nc x7T0O+ROo7ecqy/4n68AIT0sh3jeEsNt6d6j4uaOGo/ynr5cx/7aRumRd5OOxwgMRZ xzw90vCG/BcBph9RSo6rvB42CXUh/RtExBHsYxmnwuRHR86ab1CFPO2HYX1FlpobUy Afjsj1Sq9OQvA== To: bug-gnu-emacs@gnu.org From: Okamsn Subject: [PATCH] Command and option to make Edmacro better for long sequences Message-ID: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> Feedback-ID: 25935600:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_ZswXgGIJOI47EHUlnJ2GKGHeVrWdiuKMSiQXcE7yM" Received-SPF: pass client-ip=185.70.40.133; envelope-from=okamsn@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --b1_ZswXgGIJOI47EHUlnJ2GKGHeVrWdiuKMSiQXcE7yM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, The attached patch adds the command `edmacro-set-macro-to-region-lines`=20 for quickly reducing the presented keys to those in the region, and adds=20 the user option `edmacro-reverse-key-order` for showing the most recent=20 keys first. These two changes are useful for `kmacro-edit-lossage`. My use case is=20 that I would like to quickly create a keyboard macro from some of my=20 recent key presses, but Edmacro is slow to use when the lossage size is=20 large. When it is large, I must jump to the bottom of the buffer, then=20 cut the desired lines, then jump back up, then delete the remaining=20 lines, then paste the cut lines, then press `C-c C-c`. If I use=20 `delete-selection-mode`, I can combine two of the steps. With this new=20 change from the patch, I can move down a few lines, select a few lines,=20 then press `C-c C-r`, then press `C-c C-c`. Thank you. --b1_ZswXgGIJOI47EHUlnJ2GKGHeVrWdiuKMSiQXcE7yM Content-Type: text/x-patch; charset=UTF-8; name=0001-Make-using-Edmacro-better-for-long-sequences-of-keys.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Make-using-Edmacro-better-for-long-sequences-of-keys.patch RnJvbSAzODBiYzY0YWI5YTVhNGFjYWRjZGVlM2RjY2RlNDlhN2QxMDAyZTY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFYXJsIEh5YXR0IDxva2Ftc25AcHJvdG9ubWFpbC5jb20+CkRh dGU6IFNhdCwgMTkgQXVnIDIwMjMgMTg6MjY6NDUgLTA0MDAKU3ViamVjdDogW1BBVENIXSBNYWtl IHVzaW5nIEVkbWFjcm8gYmV0dGVyIGZvciBsb25nIHNlcXVlbmNlcyBvZiBrZXlzLgoKKiBsaXNw L2VkbWFjcm8uZWwgKGVkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lcywKZWRtYWNyby1y ZXZlcnNlLWtleS1vcmRlcik6IE5ldyBjb21tYW5kIGFuZCB1c2VyIG9wdGlvbiB0bwptYWtlIHdv cmtpbmcgd2l0aCBsb25nZXIgbGlzdHMgb2Yga2V5cyAoc3VjaCBhcyAna21hY3JvLWVkaXQtbG9z c2FnZScpCmVhc2llci4KKGVkaXQta2JkLW1hY3JvKTogTW92ZSByZWdleHBzIHVzZWQgdG8gaWRl bnRpZnkgcGFycyBvZiBidWZmZXIKdG8gaW50ZXJuYWwgdmFyaWFibGVzLgooZWRtYWNyby0tbWFj cm8tbGluZXMtcmVnZXhwKTogQWxsb3cgbm90aW5nIHdoZXRoZXIgdGhlIG1vc3QKcmVjZW50IGtl eXMgYXJlIGRpc3BsYXllZCBmaXJzdC4KKGVkbWFjcm8tbW9kZS1mb250LWxvY2sta2V5d29yZHMp OiBBbGxvdyBub3Rpbmcgd2hldGhlciB0aGUgbW9zdApyZWNlbnQga2V5cyBhcmUgZGlzcGxheWVk IGZpcnN0LgotLS0KIGxpc3AvZWRtYWNyby5lbCB8IDEwOCArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA5NyBpbnNlcnRpb25z KCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VkbWFjcm8uZWwgYi9saXNw L2VkbWFjcm8uZWwKaW5kZXggNjlkMjBkMmJhZDMuLmEyNjYyZjlhNjM1IDEwMDY0NAotLS0gYS9s aXNwL2VkbWFjcm8uZWwKKysrIGIvbGlzcC9lZG1hY3JvLmVsCkBAIC03Myw5ICs3MywxOCBAQCBl ZG1hY3JvLWVpZ2h0LWJpdHMKICAgOnR5cGUgJ2Jvb2xlYW4KICAgOmdyb3VwICdrbWFjcm8pCiAK KyhkZWZjdXN0b20gZWRtYWNyby1yZXZlcnNlLWtleS1vcmRlciBuaWwKKyAgIk5vbi1uaWwgaWYg YGVkaXQta2JkLW1hY3JvJyBzaG91bGQgc2hvdyB0aGUgbW9zdCByZWNlbnQga2V5cyBmaXJzdC4K KworVGhpcyBpcyB1c2VmdWwgd2hlbiBkZWFsaW5nIHdpdGggbG9uZyBsaXN0cyBvZiBrZXkgc2Vx dWVuY2VzLCBzdWNoIGFzCitmcm9tIGBrbWFjcm8tZWRpdC1sb3NzYWdlJy4iCisgIDp0eXBlICdi b29sZWFuCisgIDpncm91cCAna21hY3JvKQorCiAoZGVmdmFyLWtleW1hcCBlZG1hY3JvLW1vZGUt bWFwCiAgICJDLWMgQy1jIiAjJ2VkbWFjcm8tZmluaXNoLWVkaXQKLSAgIkMtYyBDLXEiICMnZWRt YWNyby1pbnNlcnQta2V5KQorICAiQy1jIEMtcSIgIydlZG1hY3JvLWluc2VydC1rZXkKKyAgIkMt YyBDLXIiICMnZWRtYWNyby1zZXQtbWFjcm8tdG8tcmVnaW9uLWxpbmVzKQogCiAoZGVmZmFjZSBl ZG1hY3JvLWxhYmVsCiAgICcoKGRlZmF1bHQgOmluaGVyaXQgYm9sZCkKQEAgLTg4LDcgKzk3LDEw IEBAIGVkbWFjcm8tbGFiZWwKICAgOmdyb3VwICdrbWFjcm8pCiAKIChkZWZ2YXIgZWRtYWNyby1t b2RlLWZvbnQtbG9jay1rZXl3b3JkcwotICBgKCgsKHJ4IGJvbCAoZ3JvdXAgKG9yICJDb21tYW5k IiAiS2V5IiAiTWFjcm8iKSAiOiIpKSAwICdlZG1hY3JvLWxhYmVsKQorICBgKCgsKHJ4IGJvbCAo Z3JvdXAgKG9yICJDb21tYW5kIiAiS2V5IgorICAgICAgICAgICAgICAgICAgICAgICAgIChzZXEg Ik1hY3JvIiAoemVyby1vci1vbmUgIiAobW9zdCByZWNlbnQgZmlyc3QpIikpKQorICAgICAgICAg ICAgICAgICAgICAgIjoiKSkKKyAgICAgMCAnZWRtYWNyby1sYWJlbCkKICAgICAoLChyeCBib2wK ICAgICAgICAgICAoZ3JvdXAgIjs7IEtleWJvYXJkIE1hY3JvIEVkaXRvci4gIFByZXNzICIpCiAg ICAgICAgICAgKGdyb3VwICgqPyBub25sKSkKQEAgLTE2Niw3ICsxNzgsMTMgQEAgZWRpdC1rYmQt bWFjcm8KICAgICAgIChsZXQqICgob2xkYnVmIChjdXJyZW50LWJ1ZmZlcikpCiAJICAgICAobW1h YyAoZWRtYWNyby1maXgtbWVudS1jb21tYW5kcyBtYWMpKQogCSAgICAgKGZtdCAoZWRtYWNyby1m b3JtYXQta2V5cyBtbWFjIDEpKQotCSAgICAgKGZtdHYgKGVkbWFjcm8tZm9ybWF0LWtleXMgbW1h YyAobm90IHByZWZpeCkpKQorCSAgICAgKGZtdHYgKGxldCAoKGZtdHYgKGVkbWFjcm8tZm9ybWF0 LWtleXMgbW1hYyAobm90IHByZWZpeCkpKSkKKyAgICAgICAgICAgICAgICAgICAgIChpZiAobm90 IGVkbWFjcm8tcmV2ZXJzZS1rZXktb3JkZXIpCisgICAgICAgICAgICAgICAgICAgICAgICAgZm10 dgorICAgICAgICAgICAgICAgICAgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAgICAg ICAgICAgICAgICAgIChpbnNlcnQgZm10dikKKyAgICAgICAgICAgICAgICAgICAgICAgICAocmV2 ZXJzZS1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkpCisgICAgICAgICAgICAgICAgICAg ICAgICAgKGJ1ZmZlci1zdHJpbmcpKSkpKQogCSAgICAgKGJ1ZiAoZ2V0LWJ1ZmZlci1jcmVhdGUg IipFZGl0IE1hY3JvKiIpKSkKIAkobWVzc2FnZSAiRm9ybWF0dGluZyBrZXlib2FyZCBtYWNyby4u LmRvbmUiKQogCShzd2l0Y2gtdG8tYnVmZmVyIGJ1ZikKQEAgLTE4MSw2ICsxOTksOSBAQCBlZGl0 LWtiZC1tYWNybwogICAgICAgICAoc2V0cS1sb2NhbCBmb250LWxvY2stZGVmYXVsdHMKICAgICAg ICAgICAgICAgICAgICAgJyhlZG1hY3JvLW1vZGUtZm9udC1sb2NrLWtleXdvcmRzIG5pbCBuaWwg bmlsIG5pbCkpCiAgICAgICAgIChzZXRxIGZvbnQtbG9jay1tdWx0aWxpbmUgbmlsKQorICAgICAg ICA7OyBNYWtlIGJ1ZmZlci1sb2NhbCBzbyB0aGF0IHRoZSBjb21tYW5kcyBzdGlsbCB3b3JrCisg ICAgICAgIDs7IGV2ZW4gaWYgdGhlIGRlZmF1bHQgdmFsdWUgY2hhbmdlcy4KKyAgICAgICAgKG1h a2UtbG9jYWwtdmFyaWFibGUgJ2VkbWFjcm8tcmV2ZXJzZS1rZXktb3JkZXIpCiAJKGVyYXNlLWJ1 ZmZlcikKICAgICAgICAgKGluc2VydCAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMKICAgICAgICAg ICAgICAgICAgKGNvbmNhdApAQCAtMjAyLDcgKzIyMywxMSBAQCBlZGl0LWtiZC1tYWNybwogCSAg ICAgIChpbnNlcnQgIktleTogbm9uZVxuIikpKQogCSAgKHdoZW4gKGFuZCBtYWMtY291bnRlciBt YWMtZm9ybWF0KQogCSAgICAoaW5zZXJ0IChmb3JtYXQgIkNvdW50ZXI6ICVkXG5Gb3JtYXQ6IFwi JXNcIlxuIiBtYWMtY291bnRlciBtYWMtZm9ybWF0KSkpKQotCShpbnNlcnQgIlxuTWFjcm86XG5c biIpCisJKGluc2VydCAiXG5NYWNybyIKKyAgICAgICAgICAgICAgICAoaWYgZWRtYWNyby1yZXZl cnNlLWtleS1vcmRlcgorICAgICAgICAgICAgICAgICAgICAiIChtb3N0IHJlY2VudCBmaXJzdCki CisgICAgICAgICAgICAgICAgICAiIikKKyAgICAgICAgICAgICAgICAiOlxuXG4iKQogCShzYXZl LWV4Y3Vyc2lvbgogCSAgKGluc2VydCBmbXR2ICJcbiIpKQogCShyZWNlbnRlciAnKDQpKQpAQCAt MjU1LDYgKzI4MCwzMyBAQCBmb3JtYXQta2JkLW1hY3JvCiAMCiA7OzsgQ29tbWFuZHMgZm9yICpF ZGl0IE1hY3JvKiBidWZmZXIuCiAKKyhkZWZ2YXIgZWRtYWNyby0tc2tpcC1saW5lLXJlZ2V4cAor ICAiWyBcdF0qXFwoJFxcfDs7XFx8UkVNWyBcdFxuXVxcKSIKKyAgIkEgcmVnZXhwIGlkZW50aWZ5 aW5nIGxpbmVzIHRoYXQgc2hvdWxkIGJlIGlnbm9yZWQuIikKKworKGRlZnZhciBlZG1hY3JvLS1j b21tYW5kLWxpbmUtcmVnZXhwCisgICJDb21tYW5kOlsgXHRdKlxcKFteIFx0XG5dKlxcKVsgXHRd KiQiCisgICJBIHJlZ2V4cCBpZGVudGlmeWluZyB0aGUgbGluZSBjb250YWluaW5nIHRoZSBjb21t YW5kIG5hbWUuIikKKworKGRlZnZhciBlZG1hY3JvLS1rZXktbGluZS1yZWdleHAKKyAgIktleTpc XCguKlxcKSQiCisgICJBIHJlZ2V4cCBpZGVudGlmeWluZyB0aGUgbGluZSBjb250YWluaW5nIHRo ZSBib3VuZCBrZXkgc2VxdWVuY2UuIikKKworKGRlZnZhciBlZG1hY3JvLS1jb3VudGVyLWxpbmUt cmVnZXhwCisgICJDb3VudGVyOlsgXHRdKlxcKFteIFx0XG5dKlxcKVsgXHRdKiQiCisgICJBIHJl Z2V4cCBpZGVudGlmeWluZyB0aGUgbGluZSBjb250YWluaW5nIHRoZSBjb3VudGVyIHZhbHVlLiIp CisKKyhkZWZ2YXIgZWRtYWNyby0tZm9ybWF0LWxpbmUtcmVnZXhwCisgICJGb3JtYXQ6WyBcdF0q XCJcXChbXlxuXSpcXClcIlsgXHRdKiQiCisgICJBIHJlZ2V4cCBpZGVudGlmeWluZyB0aGUgbGlu ZSBjb250YWluaW5nIHRoZSBjb3VudGVyIGZvcm1hdC4iKQorCisoZGVmdmFyIGVkbWFjcm8tLW1h Y3JvLWxpbmVzLXJlZ2V4cAorICAocnggIk1hY3JvIgorICAgICAgKHplcm8tb3Itb25lICIgKG1v c3QgcmVjZW50IGZpcnN0KSIpCisgICAgICAiOiIKKyAgICAgICh6ZXJvLW9yLW1vcmUgKGFueSAi IFx0XG4iKSkpCisgICJBIHJlZ2V4cCBpZGVudGlmeWluZyB0aGUgbGluZXMgdGhhdCBwcmVjZWRl IHRoZSBtYWNybydzIGNvbnRlbnRzLiIpCisKIChkZWZ1biBlZG1hY3JvLWZpbmlzaC1lZGl0ICgp CiAgIChpbnRlcmFjdGl2ZSBuaWwgZWRtYWNyby1tb2RlKQogICAodW5sZXNzIChlcSBtYWpvci1t b2RlICdlZG1hY3JvLW1vZGUpCkBAIC0yNjYsOSArMzE4LDkgQEAgZWRtYWNyby1maW5pc2gtZWRp dAogCSh0b3AgKHBvaW50LW1pbikpKQogICAgIChnb3RvLWNoYXIgdG9wKQogICAgIChsZXQgKChj YXNlLWZvbGQtc2VhcmNoIG5pbCkpCi0gICAgICAod2hpbGUgKGNvbmQgKChsb29raW5nLWF0ICJb IFx0XSpcXCgkXFx8OztcXHxSRU1bIFx0XG5dXFwpIikKKyAgICAgICh3aGlsZSAoY29uZCAoKGxv b2tpbmctYXQgZWRtYWNyby0tc2tpcC1saW5lLXJlZ2V4cCkKIAkJICAgIHQpCi0JCSAgICgobG9v a2luZy1hdCAiQ29tbWFuZDpbIFx0XSpcXChbXiBcdFxuXSpcXClbIFx0XSokIikKKwkJICAgKChs b29raW5nLWF0IGVkbWFjcm8tLWNvbW1hbmQtbGluZS1yZWdleHApCiAJCSAgICAod2hlbiBlZG1h Y3JvLXN0b3JlLWhvb2sKIAkJICAgICAgKGVycm9yICJcIkNvbW1hbmRcIiBsaW5lIG5vdCBhbGxv d2VkIGluIHRoaXMgY29udGV4dCIpKQogCQkgICAgKGxldCAoKHN0ciAobWF0Y2gtc3RyaW5nIDEp KSkKQEAgLTI4Myw3ICszMzUsNyBAQCBlZG1hY3JvLWZpbmlzaC1lZGl0CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBjbWQpKSkKIAkJCSAgICAgKGtleWJvYXJkLXF1aXQpKSkp CiAJCSAgICB0KQotCQkgICAoKGxvb2tpbmctYXQgIktleTpcXCguKlxcKSQiKQorCQkgICAoKGxv b2tpbmctYXQgZWRtYWNyby0ta2V5LWxpbmUtcmVnZXhwKQogCQkgICAgKHdoZW4gZWRtYWNyby1z dG9yZS1ob29rCiAJCSAgICAgIChlcnJvciAiXCJLZXlcIiBsaW5lIG5vdCBhbGxvd2VkIGluIHRo aXMgY29udGV4dCIpKQogCQkgICAgKGxldCAoKGtleSAoa2JkIChtYXRjaC1zdHJpbmcgMSkpKSkK QEAgLTMwMywyMSArMzU1LDIxIEBAIGVkbWFjcm8tZmluaXNoLWVkaXQKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoZWRtYWNyby1mb3JtYXQta2V5cyBrZXkgMSkpKSkK IAkJCQkgKGtleWJvYXJkLXF1aXQpKSkpKSkKIAkJICAgIHQpCi0JCSAgICgobG9va2luZy1hdCAi Q291bnRlcjpbIFx0XSpcXChbXiBcdFxuXSpcXClbIFx0XSokIikKKwkJICAgKChsb29raW5nLWF0 IGVkbWFjcm8tLWNvdW50ZXItbGluZS1yZWdleHApCiAJCSAgICAod2hlbiBlZG1hY3JvLXN0b3Jl LWhvb2sKIAkJICAgICAgKGVycm9yICJcIkNvdW50ZXJcIiBsaW5lIG5vdCBhbGxvd2VkIGluIHRo aXMgY29udGV4dCIpKQogCQkgICAgKGxldCAoKHN0ciAobWF0Y2gtc3RyaW5nIDEpKSkKIAkJICAg ICAgKHVubGVzcyAoZXF1YWwgc3RyICIiKQogCQkJKHNldHEgbWFjLWNvdW50ZXIgKHN0cmluZy10 by1udW1iZXIgc3RyKSkpKQogCQkgICAgdCkKLQkJICAgKChsb29raW5nLWF0ICJGb3JtYXQ6WyBc dF0qXCJcXChbXlxuXSpcXClcIlsgXHRdKiQiKQorCQkgICAoKGxvb2tpbmctYXQgZWRtYWNyby0t Zm9ybWF0LWxpbmUtcmVnZXhwKQogCQkgICAgKHdoZW4gZWRtYWNyby1zdG9yZS1ob29rCiAJCSAg ICAgIChlcnJvciAiXCJGb3JtYXRcIiBsaW5lIG5vdCBhbGxvd2VkIGluIHRoaXMgY29udGV4dCIp KQogCQkgICAgKGxldCAoKHN0ciAobWF0Y2gtc3RyaW5nIDEpKSkKIAkJICAgICAgKHVubGVzcyAo ZXF1YWwgc3RyICIiKQogCQkJKHNldHEgbWFjLWZvcm1hdCBzdHIpKSkKIAkJICAgIHQpCi0JCSAg ICgobG9va2luZy1hdCAiTWFjcm86WyBcdFxuXSoiKQorCQkgICAoKGxvb2tpbmctYXQgZWRtYWNy by0tbWFjcm8tbGluZXMtcmVnZXhwKQogCQkgICAgKGdvdG8tY2hhciAobWF0Y2gtZW5kIDApKQog CQkgICAgbmlsKQogCQkgICAoKGVvYnApIG5pbCkKQEAgLTMzNiw3ICszODgsMTMgQEAgZWRtYWNy by1maW5pc2gtZWRpdAogCSh3aGVuIChidWZmZXItbmFtZSBvYnVmKQogCSAgKHNldC1idWZmZXIg b2J1ZikpCiAJKG1lc3NhZ2UgIkNvbXBpbGluZyBrZXlib2FyZCBtYWNyby4uLiIpCi0JKGxldCAo KG1hYyAoZWRtYWNyby1wYXJzZS1rZXlzIHN0cikpKQorCShsZXQgKChtYWMgKGVkbWFjcm8tcGFy c2Uta2V5cyAoaWYgZWRtYWNyby1yZXZlcnNlLWtleS1vcmRlcgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaW5zZXJ0IHN0cikKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZXZlcnNlLXJlZ2lvbiAocG9pbnQt bWluKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChwb2ludC1tYXgpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGJ1ZmZlci1zdHJpbmcpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdHIpKSkpCiAJICAobWVzc2FnZSAiQ29tcGlsaW5nIGtleWJvYXJkIG1h Y3JvLi4uZG9uZSIpCiAJICAoaWYgc3RvcmUtaG9vawogCSAgICAgIChmdW5jYWxsIHN0b3JlLWhv b2sgbWFjKQpAQCAtMzcyLDYgKzQzMCwzNCBAQCBlZG1hY3JvLWluc2VydC1rZXkKICAgICAgIChp bnNlcnQgKGVkbWFjcm8tZm9ybWF0LWtleXMga2V5IHQpICJcbiIpCiAgICAgKGluc2VydCAoZWRt YWNyby1mb3JtYXQta2V5cyBrZXkpICIgIikpKQogCisoZGVmdW4gZWRtYWNyby1zZXQtbWFjcm8t dG8tcmVnaW9uLWxpbmVzIChiZWcgZW5kKQorICAiU2V0IHRoZSBNYWNybyB0ZXh0IHRvIHRoZSBs aW5lcyBvZiB0aGUgcmVnaW9uLgorCitJZiBCRUcgaXMgbm90IGF0IHRoZSBiZWdpbm5pbmcgb2Yg YSBsaW5lLCBpdCBpcyBtb3ZlZCB0byB0aGUKK2JlZ2lubmluZyBvZiB0aGUgbGluZS4gIElmIEVO RCBpcyBhdCB0aGUgYmVnaW5uaW5nIG9mIGEgbGluZSwKK3RoYXQgbGluZSBpcyBleGNsdWRlZC4g IE90aGVyd2lzZSwgaWYgRU5EIGlzIG5vdCBhdCB0aGUKK2VuZCBvZiBhIGxpbmUsIGl0IGlzIG1v dmVkIHRvIHRoZSBlbmQgb2YgdGhlIGxpbmUuIgorICAoaW50ZXJhY3RpdmUgInIiIGVkbWFjcm8t bW9kZSkKKyAgOzsgVXNlIGBzYXZlLWV4Y3Vyc2lvbicgdG8gcmVzdG9yZSByZWdpb24gaWYgdGhl cmUgYXJlIGFueSBlcnJvcnMuCisgIDs7IElmIHRoZXJlIGFyZSBubyBlcnJvcnMsIHVwZGF0ZSBt YWNybyBjb250ZW50cywgdGhlbiBnbyB0byB0aGUKKyAgOzsgYmVnaW5uaW5nIG9mIHRoZSBtYWNy byBjb250ZW50cy4KKyAgKGxldCAoKGZpbmFsLXBvc2l0aW9uKSkKKyAgICAoc2F2ZS1leGN1cnNp b24KKyAgICAgIChnb3RvLWNoYXIgYmVnKQorICAgICAgKHVubGVzcyAoYm9scCkgKHNldHEgYmVn IChwb3MtYm9sKSkpCisgICAgICAoZ290by1jaGFyIGVuZCkKKyAgICAgICh1bmxlc3MgKG9yIChi b2xwKSAoZW9scCkpIChzZXRxIGVuZCAocG9zLWVvbCkpKQorICAgICAgKGxldCAoKHRleHQgKGJ1 ZmZlci1zdWJzdHJpbmcgYmVnIGVuZCkpKQorICAgICAgICAoZ290by1jaGFyIChwb2ludC1taW4p KQorICAgICAgICAoaWYgKG5vdCAobGV0ICgoY2FzZS1mb2xkLXNlYXJjaCBuaWwpKQorICAgICAg ICAgICAgICAgICAgIChyZS1zZWFyY2gtZm9yd2FyZCBlZG1hY3JvLS1tYWNyby1saW5lcy1yZWdl eHAgbmlsIHQpKSkKKyAgICAgICAgICAgICh1c2VyLWVycm9yICJcIk1hY3JvOlwiIGxpbmUgbm90 IGZvdW5kIikKKyAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAobWF0Y2gtZW5kIDApCisgICAgICAg ICAgICAgICAgICAgICAgICAgKHBvaW50LW1heCkpCisgICAgICAgICAgKGluc2VydCB0ZXh0KQor ICAgICAgICAgIChzZXRxIGZpbmFsLXBvc2l0aW9uIChtYXRjaC1iZWdpbm5pbmcgMCkpKSkpCisg ICAgKGdvdG8tY2hhciBmaW5hbC1wb3NpdGlvbikpKQorCiAoZGVmdW4gZWRtYWNyby1tb2RlICgp CiAgICJcXDxlZG1hY3JvLW1vZGUtbWFwPktleWJvYXJkIE1hY3JvIEVkaXRpbmcgbW9kZS4gIFBy ZXNzIFwKIFxcW2VkbWFjcm8tZmluaXNoLWVkaXRdIHRvIHNhdmUgYW5kIGV4aXQuCi0tIAoyLjM0 LjEKCg== --b1_ZswXgGIJOI47EHUlnJ2GKGHeVrWdiuKMSiQXcE7yM-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 21:21:55 2023 Received: (at 65605) by debbugs.gnu.org; 30 Aug 2023 01:21:55 +0000 Received: from localhost ([127.0.0.1]:51839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb9u6-0006E9-KH for submit@debbugs.gnu.org; Tue, 29 Aug 2023 21:21:55 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:38179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb9u4-0006Du-4s for 65605@debbugs.gnu.org; Tue, 29 Aug 2023 21:21:53 -0400 Date: Wed, 30 Aug 2023 01:21:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1693358498; x=1693617698; bh=CslwMFQGyP+403sMfdSIJy7zKubsLHH+cA/Ml+md7MA=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ms7akqtjsKLLaWxSbkR8PSN7YtQa/2ZqIzHmLG+EqYfX8jFy8Cu6uTI5hQPFf9MQ3 LzcSfTnJRjLODouP1ANv8RR5YVaRGDndWdj7ghw9vC/bSbL2duoQ9imeVeljqwq3a7 Xl18blklOHX2W7I+aMEPgo9pPtWsmD7VRAK/OkN4v51KQqVuT0jKQ/mbev1znHngnn pwitxcZgCJodE9skiJ7tvBVGOoVRQ55qjzNJ7NfMpjd0bhjJP9L9ZIv18fwWu295Il +72VBfbnhxDSSCCm6/fvm9+B7iiBujhAPveoUEmWAogMAbz4wWp9I5dZkF91GjXCjS nROmSd/YSzPsw== To: 65605@debbugs.gnu.org From: Okamsn Subject: Re: bug#65605: [PATCH] Command and option to make Edmacro better for long sequences Message-ID: <076354fd-0a8b-b5c7-9e78-4b6842746460@protonmail.com> In-Reply-To: References: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> Feedback-ID: 25935600:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_5bPOUWVQ5QxjWN6gBGkeXB3LQhZ1dShm1HaJrZfo6gw" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65605 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_5bPOUWVQ5QxjWN6gBGkeXB3LQhZ1dShm1HaJrZfo6gw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable There was a typo in the commit message of the previous attached file.=20 This new attached file fixes the typo. --b1_5bPOUWVQ5QxjWN6gBGkeXB3LQhZ1dShm1HaJrZfo6gw Content-Type: text/x-patch; charset=UTF-8; name=v2-0001-Make-using-Edmacro-better-for-long-sequences-of-k.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v2-0001-Make-using-Edmacro-better-for-long-sequences-of-k.patch RnJvbSBiMzNkNzY2NzAyYzUxODgxY2JhZmNjNjQ5ZGM2M2MzMDE5ZjM0MDA3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFYXJsIEh5YXR0IDxva2Ftc25AcHJvdG9ubWFpbC5jb20+CkRh dGU6IFNhdCwgMTkgQXVnIDIwMjMgMTg6MjY6NDUgLTA0MDAKU3ViamVjdDogW1BBVENIIHYyXSBN YWtlIHVzaW5nIEVkbWFjcm8gYmV0dGVyIGZvciBsb25nIHNlcXVlbmNlcyBvZiBrZXlzLgoKKiBs aXNwL2VkbWFjcm8uZWwgKGVkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lcywKZWRtYWNy by1yZXZlcnNlLWtleS1vcmRlcik6IE5ldyBjb21tYW5kIGFuZCB1c2VyIG9wdGlvbiB0bwptYWtl IHdvcmtpbmcgd2l0aCBsb25nZXIgbGlzdHMgb2Yga2V5cyAoc3VjaCBhcyAna21hY3JvLWVkaXQt bG9zc2FnZScpCmVhc2llci4KKGVkaXQta2JkLW1hY3JvKTogTW92ZSByZWdleHBzIHVzZWQgdG8g aWRlbnRpZnkgcGFydHMgb2YgYnVmZmVyCnRvIGludGVybmFsIHZhcmlhYmxlcy4KKGVkbWFjcm8t LW1hY3JvLWxpbmVzLXJlZ2V4cCwgZWRtYWNyby1tb2RlLWZvbnQtbG9jay1rZXl3b3Jkcyk6IEFs bG93Cm5vdGluZyB3aGV0aGVyIHRoZSBtb3N0IHJlY2VudCBrZXlzIGFyZSBkaXNwbGF5ZWQgZmly c3QuCi0tLQogbGlzcC9lZG1hY3JvLmVsIHwgMTA4ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDk3IGluc2VydGlvbnMoKyks IDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZWRtYWNyby5lbCBiL2xpc3AvZWRt YWNyby5lbAppbmRleCA2OWQyMGQyYmFkMy4uYTI2NjJmOWE2MzUgMTAwNjQ0Ci0tLSBhL2xpc3Av ZWRtYWNyby5lbAorKysgYi9saXNwL2VkbWFjcm8uZWwKQEAgLTczLDkgKzczLDE4IEBAIGVkbWFj cm8tZWlnaHQtYml0cwogICA6dHlwZSAnYm9vbGVhbgogICA6Z3JvdXAgJ2ttYWNybykKIAorKGRl ZmN1c3RvbSBlZG1hY3JvLXJldmVyc2Uta2V5LW9yZGVyIG5pbAorICAiTm9uLW5pbCBpZiBgZWRp dC1rYmQtbWFjcm8nIHNob3VsZCBzaG93IHRoZSBtb3N0IHJlY2VudCBrZXlzIGZpcnN0LgorCitU aGlzIGlzIHVzZWZ1bCB3aGVuIGRlYWxpbmcgd2l0aCBsb25nIGxpc3RzIG9mIGtleSBzZXF1ZW5j ZXMsIHN1Y2ggYXMKK2Zyb20gYGttYWNyby1lZGl0LWxvc3NhZ2UnLiIKKyAgOnR5cGUgJ2Jvb2xl YW4KKyAgOmdyb3VwICdrbWFjcm8pCisKIChkZWZ2YXIta2V5bWFwIGVkbWFjcm8tbW9kZS1tYXAK ICAgIkMtYyBDLWMiICMnZWRtYWNyby1maW5pc2gtZWRpdAotICAiQy1jIEMtcSIgIydlZG1hY3Jv LWluc2VydC1rZXkpCisgICJDLWMgQy1xIiAjJ2VkbWFjcm8taW5zZXJ0LWtleQorICAiQy1jIEMt ciIgIydlZG1hY3JvLXNldC1tYWNyby10by1yZWdpb24tbGluZXMpCiAKIChkZWZmYWNlIGVkbWFj cm8tbGFiZWwKICAgJygoZGVmYXVsdCA6aW5oZXJpdCBib2xkKQpAQCAtODgsNyArOTcsMTAgQEAg ZWRtYWNyby1sYWJlbAogICA6Z3JvdXAgJ2ttYWNybykKIAogKGRlZnZhciBlZG1hY3JvLW1vZGUt Zm9udC1sb2NrLWtleXdvcmRzCi0gIGAoKCwocnggYm9sIChncm91cCAob3IgIkNvbW1hbmQiICJL ZXkiICJNYWNybyIpICI6IikpIDAgJ2VkbWFjcm8tbGFiZWwpCisgIGAoKCwocnggYm9sIChncm91 cCAob3IgIkNvbW1hbmQiICJLZXkiCisgICAgICAgICAgICAgICAgICAgICAgICAgKHNlcSAiTWFj cm8iICh6ZXJvLW9yLW9uZSAiIChtb3N0IHJlY2VudCBmaXJzdCkiKSkpCisgICAgICAgICAgICAg ICAgICAgICAiOiIpKQorICAgICAwICdlZG1hY3JvLWxhYmVsKQogICAgICgsKHJ4IGJvbAogICAg ICAgICAgIChncm91cCAiOzsgS2V5Ym9hcmQgTWFjcm8gRWRpdG9yLiAgUHJlc3MgIikKICAgICAg ICAgICAoZ3JvdXAgKCo/IG5vbmwpKQpAQCAtMTY2LDcgKzE3OCwxMyBAQCBlZGl0LWtiZC1tYWNy bwogICAgICAgKGxldCogKChvbGRidWYgKGN1cnJlbnQtYnVmZmVyKSkKIAkgICAgIChtbWFjIChl ZG1hY3JvLWZpeC1tZW51LWNvbW1hbmRzIG1hYykpCiAJICAgICAoZm10IChlZG1hY3JvLWZvcm1h dC1rZXlzIG1tYWMgMSkpCi0JICAgICAoZm10diAoZWRtYWNyby1mb3JtYXQta2V5cyBtbWFjIChu b3QgcHJlZml4KSkpCisJICAgICAoZm10diAobGV0ICgoZm10diAoZWRtYWNyby1mb3JtYXQta2V5 cyBtbWFjIChub3QgcHJlZml4KSkpKQorICAgICAgICAgICAgICAgICAgICAgKGlmIChub3QgZWRt YWNyby1yZXZlcnNlLWtleS1vcmRlcikKKyAgICAgICAgICAgICAgICAgICAgICAgICBmbXR2Cisg ICAgICAgICAgICAgICAgICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAgICAgICAgICAg ICAgICAgICAgKGluc2VydCBmbXR2KQorICAgICAgICAgICAgICAgICAgICAgICAgIChyZXZlcnNl LXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkKKyAgICAgICAgICAgICAgICAgICAgICAg ICAoYnVmZmVyLXN0cmluZykpKSkpCiAJICAgICAoYnVmIChnZXQtYnVmZmVyLWNyZWF0ZSAiKkVk aXQgTWFjcm8qIikpKQogCShtZXNzYWdlICJGb3JtYXR0aW5nIGtleWJvYXJkIG1hY3JvLi4uZG9u ZSIpCiAJKHN3aXRjaC10by1idWZmZXIgYnVmKQpAQCAtMTgxLDYgKzE5OSw5IEBAIGVkaXQta2Jk LW1hY3JvCiAgICAgICAgIChzZXRxLWxvY2FsIGZvbnQtbG9jay1kZWZhdWx0cwogICAgICAgICAg ICAgICAgICAgICAnKGVkbWFjcm8tbW9kZS1mb250LWxvY2sta2V5d29yZHMgbmlsIG5pbCBuaWwg bmlsKSkKICAgICAgICAgKHNldHEgZm9udC1sb2NrLW11bHRpbGluZSBuaWwpCisgICAgICAgIDs7 IE1ha2UgYnVmZmVyLWxvY2FsIHNvIHRoYXQgdGhlIGNvbW1hbmRzIHN0aWxsIHdvcmsKKyAgICAg ICAgOzsgZXZlbiBpZiB0aGUgZGVmYXVsdCB2YWx1ZSBjaGFuZ2VzLgorICAgICAgICAobWFrZS1s b2NhbC12YXJpYWJsZSAnZWRtYWNyby1yZXZlcnNlLWtleS1vcmRlcikKIAkoZXJhc2UtYnVmZmVy KQogICAgICAgICAoaW5zZXJ0IChzdWJzdGl0dXRlLWNvbW1hbmQta2V5cwogICAgICAgICAgICAg ICAgICAoY29uY2F0CkBAIC0yMDIsNyArMjIzLDExIEBAIGVkaXQta2JkLW1hY3JvCiAJICAgICAg KGluc2VydCAiS2V5OiBub25lXG4iKSkpCiAJICAod2hlbiAoYW5kIG1hYy1jb3VudGVyIG1hYy1m b3JtYXQpCiAJICAgIChpbnNlcnQgKGZvcm1hdCAiQ291bnRlcjogJWRcbkZvcm1hdDogXCIlc1wi XG4iIG1hYy1jb3VudGVyIG1hYy1mb3JtYXQpKSkpCi0JKGluc2VydCAiXG5NYWNybzpcblxuIikK KwkoaW5zZXJ0ICJcbk1hY3JvIgorICAgICAgICAgICAgICAgIChpZiBlZG1hY3JvLXJldmVyc2Ut a2V5LW9yZGVyCisgICAgICAgICAgICAgICAgICAgICIgKG1vc3QgcmVjZW50IGZpcnN0KSIKKyAg ICAgICAgICAgICAgICAgICIiKQorICAgICAgICAgICAgICAgICI6XG5cbiIpCiAJKHNhdmUtZXhj dXJzaW9uCiAJICAoaW5zZXJ0IGZtdHYgIlxuIikpCiAJKHJlY2VudGVyICcoNCkpCkBAIC0yNTUs NiArMjgwLDMzIEBAIGZvcm1hdC1rYmQtbWFjcm8KIAwKIDs7OyBDb21tYW5kcyBmb3IgKkVkaXQg TWFjcm8qIGJ1ZmZlci4KIAorKGRlZnZhciBlZG1hY3JvLS1za2lwLWxpbmUtcmVnZXhwCisgICJb IFx0XSpcXCgkXFx8OztcXHxSRU1bIFx0XG5dXFwpIgorICAiQSByZWdleHAgaWRlbnRpZnlpbmcg bGluZXMgdGhhdCBzaG91bGQgYmUgaWdub3JlZC4iKQorCisoZGVmdmFyIGVkbWFjcm8tLWNvbW1h bmQtbGluZS1yZWdleHAKKyAgIkNvbW1hbmQ6WyBcdF0qXFwoW14gXHRcbl0qXFwpWyBcdF0qJCIK KyAgIkEgcmVnZXhwIGlkZW50aWZ5aW5nIHRoZSBsaW5lIGNvbnRhaW5pbmcgdGhlIGNvbW1hbmQg bmFtZS4iKQorCisoZGVmdmFyIGVkbWFjcm8tLWtleS1saW5lLXJlZ2V4cAorICAiS2V5OlxcKC4q XFwpJCIKKyAgIkEgcmVnZXhwIGlkZW50aWZ5aW5nIHRoZSBsaW5lIGNvbnRhaW5pbmcgdGhlIGJv dW5kIGtleSBzZXF1ZW5jZS4iKQorCisoZGVmdmFyIGVkbWFjcm8tLWNvdW50ZXItbGluZS1yZWdl eHAKKyAgIkNvdW50ZXI6WyBcdF0qXFwoW14gXHRcbl0qXFwpWyBcdF0qJCIKKyAgIkEgcmVnZXhw IGlkZW50aWZ5aW5nIHRoZSBsaW5lIGNvbnRhaW5pbmcgdGhlIGNvdW50ZXIgdmFsdWUuIikKKwor KGRlZnZhciBlZG1hY3JvLS1mb3JtYXQtbGluZS1yZWdleHAKKyAgIkZvcm1hdDpbIFx0XSpcIlxc KFteXG5dKlxcKVwiWyBcdF0qJCIKKyAgIkEgcmVnZXhwIGlkZW50aWZ5aW5nIHRoZSBsaW5lIGNv bnRhaW5pbmcgdGhlIGNvdW50ZXIgZm9ybWF0LiIpCisKKyhkZWZ2YXIgZWRtYWNyby0tbWFjcm8t bGluZXMtcmVnZXhwCisgIChyeCAiTWFjcm8iCisgICAgICAoemVyby1vci1vbmUgIiAobW9zdCBy ZWNlbnQgZmlyc3QpIikKKyAgICAgICI6IgorICAgICAgKHplcm8tb3ItbW9yZSAoYW55ICIgXHRc biIpKSkKKyAgIkEgcmVnZXhwIGlkZW50aWZ5aW5nIHRoZSBsaW5lcyB0aGF0IHByZWNlZGUgdGhl IG1hY3JvJ3MgY29udGVudHMuIikKKwogKGRlZnVuIGVkbWFjcm8tZmluaXNoLWVkaXQgKCkKICAg KGludGVyYWN0aXZlIG5pbCBlZG1hY3JvLW1vZGUpCiAgICh1bmxlc3MgKGVxIG1ham9yLW1vZGUg J2VkbWFjcm8tbW9kZSkKQEAgLTI2Niw5ICszMTgsOSBAQCBlZG1hY3JvLWZpbmlzaC1lZGl0CiAJ KHRvcCAocG9pbnQtbWluKSkpCiAgICAgKGdvdG8tY2hhciB0b3ApCiAgICAgKGxldCAoKGNhc2Ut Zm9sZC1zZWFyY2ggbmlsKSkKLSAgICAgICh3aGlsZSAoY29uZCAoKGxvb2tpbmctYXQgIlsgXHRd KlxcKCRcXHw7O1xcfFJFTVsgXHRcbl1cXCkiKQorICAgICAgKHdoaWxlIChjb25kICgobG9va2lu Zy1hdCBlZG1hY3JvLS1za2lwLWxpbmUtcmVnZXhwKQogCQkgICAgdCkKLQkJICAgKChsb29raW5n LWF0ICJDb21tYW5kOlsgXHRdKlxcKFteIFx0XG5dKlxcKVsgXHRdKiQiKQorCQkgICAoKGxvb2tp bmctYXQgZWRtYWNyby0tY29tbWFuZC1saW5lLXJlZ2V4cCkKIAkJICAgICh3aGVuIGVkbWFjcm8t c3RvcmUtaG9vawogCQkgICAgICAoZXJyb3IgIlwiQ29tbWFuZFwiIGxpbmUgbm90IGFsbG93ZWQg aW4gdGhpcyBjb250ZXh0IikpCiAJCSAgICAobGV0ICgoc3RyIChtYXRjaC1zdHJpbmcgMSkpKQpA QCAtMjgzLDcgKzMzNSw3IEBAIGVkbWFjcm8tZmluaXNoLWVkaXQKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNtZCkpKQogCQkJICAgICAoa2V5Ym9hcmQtcXVpdCkpKSkKIAkJ ICAgIHQpCi0JCSAgICgobG9va2luZy1hdCAiS2V5OlxcKC4qXFwpJCIpCisJCSAgICgobG9va2lu Zy1hdCBlZG1hY3JvLS1rZXktbGluZS1yZWdleHApCiAJCSAgICAod2hlbiBlZG1hY3JvLXN0b3Jl LWhvb2sKIAkJICAgICAgKGVycm9yICJcIktleVwiIGxpbmUgbm90IGFsbG93ZWQgaW4gdGhpcyBj b250ZXh0IikpCiAJCSAgICAobGV0ICgoa2V5IChrYmQgKG1hdGNoLXN0cmluZyAxKSkpKQpAQCAt MzAzLDIxICszNTUsMjEgQEAgZWRtYWNyby1maW5pc2gtZWRpdAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChlZG1hY3JvLWZvcm1hdC1rZXlzIGtleSAxKSkpKQogCQkJ CSAoa2V5Ym9hcmQtcXVpdCkpKSkpKQogCQkgICAgdCkKLQkJICAgKChsb29raW5nLWF0ICJDb3Vu dGVyOlsgXHRdKlxcKFteIFx0XG5dKlxcKVsgXHRdKiQiKQorCQkgICAoKGxvb2tpbmctYXQgZWRt YWNyby0tY291bnRlci1saW5lLXJlZ2V4cCkKIAkJICAgICh3aGVuIGVkbWFjcm8tc3RvcmUtaG9v awogCQkgICAgICAoZXJyb3IgIlwiQ291bnRlclwiIGxpbmUgbm90IGFsbG93ZWQgaW4gdGhpcyBj b250ZXh0IikpCiAJCSAgICAobGV0ICgoc3RyIChtYXRjaC1zdHJpbmcgMSkpKQogCQkgICAgICAo dW5sZXNzIChlcXVhbCBzdHIgIiIpCiAJCQkoc2V0cSBtYWMtY291bnRlciAoc3RyaW5nLXRvLW51 bWJlciBzdHIpKSkpCiAJCSAgICB0KQotCQkgICAoKGxvb2tpbmctYXQgIkZvcm1hdDpbIFx0XSpc IlxcKFteXG5dKlxcKVwiWyBcdF0qJCIpCisJCSAgICgobG9va2luZy1hdCBlZG1hY3JvLS1mb3Jt YXQtbGluZS1yZWdleHApCiAJCSAgICAod2hlbiBlZG1hY3JvLXN0b3JlLWhvb2sKIAkJICAgICAg KGVycm9yICJcIkZvcm1hdFwiIGxpbmUgbm90IGFsbG93ZWQgaW4gdGhpcyBjb250ZXh0IikpCiAJ CSAgICAobGV0ICgoc3RyIChtYXRjaC1zdHJpbmcgMSkpKQogCQkgICAgICAodW5sZXNzIChlcXVh bCBzdHIgIiIpCiAJCQkoc2V0cSBtYWMtZm9ybWF0IHN0cikpKQogCQkgICAgdCkKLQkJICAgKChs b29raW5nLWF0ICJNYWNybzpbIFx0XG5dKiIpCisJCSAgICgobG9va2luZy1hdCBlZG1hY3JvLS1t YWNyby1saW5lcy1yZWdleHApCiAJCSAgICAoZ290by1jaGFyIChtYXRjaC1lbmQgMCkpCiAJCSAg ICBuaWwpCiAJCSAgICgoZW9icCkgbmlsKQpAQCAtMzM2LDcgKzM4OCwxMyBAQCBlZG1hY3JvLWZp bmlzaC1lZGl0CiAJKHdoZW4gKGJ1ZmZlci1uYW1lIG9idWYpCiAJICAoc2V0LWJ1ZmZlciBvYnVm KSkKIAkobWVzc2FnZSAiQ29tcGlsaW5nIGtleWJvYXJkIG1hY3JvLi4uIikKLQkobGV0ICgobWFj IChlZG1hY3JvLXBhcnNlLWtleXMgc3RyKSkpCisJKGxldCAoKG1hYyAoZWRtYWNyby1wYXJzZS1r ZXlzIChpZiBlZG1hY3JvLXJldmVyc2Uta2V5LW9yZGVyCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpbnNlcnQgc3RyKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJldmVyc2UtcmVnaW9uIChwb2ludC1taW4p CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKHBvaW50LW1heCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoYnVmZmVyLXN0cmluZykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHN0cikpKSkKIAkgIChtZXNzYWdlICJDb21waWxpbmcga2V5Ym9hcmQgbWFjcm8u Li5kb25lIikKIAkgIChpZiBzdG9yZS1ob29rCiAJICAgICAgKGZ1bmNhbGwgc3RvcmUtaG9vayBt YWMpCkBAIC0zNzIsNiArNDMwLDM0IEBAIGVkbWFjcm8taW5zZXJ0LWtleQogICAgICAgKGluc2Vy dCAoZWRtYWNyby1mb3JtYXQta2V5cyBrZXkgdCkgIlxuIikKICAgICAoaW5zZXJ0IChlZG1hY3Jv LWZvcm1hdC1rZXlzIGtleSkgIiAiKSkpCiAKKyhkZWZ1biBlZG1hY3JvLXNldC1tYWNyby10by1y ZWdpb24tbGluZXMgKGJlZyBlbmQpCisgICJTZXQgdGhlIE1hY3JvIHRleHQgdG8gdGhlIGxpbmVz IG9mIHRoZSByZWdpb24uCisKK0lmIEJFRyBpcyBub3QgYXQgdGhlIGJlZ2lubmluZyBvZiBhIGxp bmUsIGl0IGlzIG1vdmVkIHRvIHRoZQorYmVnaW5uaW5nIG9mIHRoZSBsaW5lLiAgSWYgRU5EIGlz IGF0IHRoZSBiZWdpbm5pbmcgb2YgYSBsaW5lLAordGhhdCBsaW5lIGlzIGV4Y2x1ZGVkLiAgT3Ro ZXJ3aXNlLCBpZiBFTkQgaXMgbm90IGF0IHRoZQorZW5kIG9mIGEgbGluZSwgaXQgaXMgbW92ZWQg dG8gdGhlIGVuZCBvZiB0aGUgbGluZS4iCisgIChpbnRlcmFjdGl2ZSAiciIgZWRtYWNyby1tb2Rl KQorICA7OyBVc2UgYHNhdmUtZXhjdXJzaW9uJyB0byByZXN0b3JlIHJlZ2lvbiBpZiB0aGVyZSBh cmUgYW55IGVycm9ycy4KKyAgOzsgSWYgdGhlcmUgYXJlIG5vIGVycm9ycywgdXBkYXRlIG1hY3Jv IGNvbnRlbnRzLCB0aGVuIGdvIHRvIHRoZQorICA7OyBiZWdpbm5pbmcgb2YgdGhlIG1hY3JvIGNv bnRlbnRzLgorICAobGV0ICgoZmluYWwtcG9zaXRpb24pKQorICAgIChzYXZlLWV4Y3Vyc2lvbgor ICAgICAgKGdvdG8tY2hhciBiZWcpCisgICAgICAodW5sZXNzIChib2xwKSAoc2V0cSBiZWcgKHBv cy1ib2wpKSkKKyAgICAgIChnb3RvLWNoYXIgZW5kKQorICAgICAgKHVubGVzcyAob3IgKGJvbHAp IChlb2xwKSkgKHNldHEgZW5kIChwb3MtZW9sKSkpCisgICAgICAobGV0ICgodGV4dCAoYnVmZmVy LXN1YnN0cmluZyBiZWcgZW5kKSkpCisgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisg ICAgICAgIChpZiAobm90IChsZXQgKChjYXNlLWZvbGQtc2VhcmNoIG5pbCkpCisgICAgICAgICAg ICAgICAgICAgKHJlLXNlYXJjaC1mb3J3YXJkIGVkbWFjcm8tLW1hY3JvLWxpbmVzLXJlZ2V4cCBu aWwgdCkpKQorICAgICAgICAgICAgKHVzZXItZXJyb3IgIlwiTWFjcm86XCIgbGluZSBub3QgZm91 bmQiKQorICAgICAgICAgIChkZWxldGUtcmVnaW9uIChtYXRjaC1lbmQgMCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAocG9pbnQtbWF4KSkKKyAgICAgICAgICAoaW5zZXJ0IHRleHQpCisgICAg ICAgICAgKHNldHEgZmluYWwtcG9zaXRpb24gKG1hdGNoLWJlZ2lubmluZyAwKSkpKSkKKyAgICAo Z290by1jaGFyIGZpbmFsLXBvc2l0aW9uKSkpCisKIChkZWZ1biBlZG1hY3JvLW1vZGUgKCkKICAg IlxcPGVkbWFjcm8tbW9kZS1tYXA+S2V5Ym9hcmQgTWFjcm8gRWRpdGluZyBtb2RlLiAgUHJlc3Mg XAogXFxbZWRtYWNyby1maW5pc2gtZWRpdF0gdG8gc2F2ZSBhbmQgZXhpdC4KLS0gCjIuMzQuMQoK --b1_5bPOUWVQ5QxjWN6gBGkeXB3LQhZ1dShm1HaJrZfo6gw-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 30 07:38:27 2023 Received: (at 65605) by debbugs.gnu.org; 30 Aug 2023 11:38:27 +0000 Received: from localhost ([127.0.0.1]:52261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbJWl-0007kN-BN for submit@debbugs.gnu.org; Wed, 30 Aug 2023 07:38:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbJWg-0007k5-8O for 65605@debbugs.gnu.org; Wed, 30 Aug 2023 07:38:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbJWT-0001W3-5k; Wed, 30 Aug 2023 07:38:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=w628Uvh7Nh4wKbxwAwLnQQkBRiadrZ793JDxxkxPNT4=; b=TkJC86lSHfsE eXM6p9M3+c5/eJX4HdXiDC0Y0oW/jeI6ZLEVTQ5aNGxScLTPspsgxMv357RcnqK67sHqC+pigND68 mbdkVKtYWLOKwcvSpVTzKVl+B9o405BJyYVUEwFRFZfDA9ERJhol9T/QxDNvMsU2aQBMHuUY7DF8D a9Ry/uJWcWmrZx45ZvxWP3Oorj1d1RADIg2jTYtTCgvmmzAlyI3eF1rudn9CW9Am/DGaJ/9K8ptQS 3q3IdRKux0ryDjFxCgLnsWV19bcWB4lQAHVOPL3GsFxf/1NllkJwQY22C/RAU+OWFFQcvKXeon00A 5L8JGyT++zubgMKleRT5sA==; Date: Wed, 30 Aug 2023 14:37:48 +0300 Message-Id: <83fs40hib7.fsf@gnu.org> From: Eli Zaretskii To: Okamsn In-Reply-To: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#65605: [PATCH] Command and option to make Edmacro better for long sequences References: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65605 Cc: 65605@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 30 Aug 2023 01:17:51 +0000 > From: Okamsn via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > The attached patch adds the command `edmacro-set-macro-to-region-lines` > for quickly reducing the presented keys to those in the region, and adds > the user option `edmacro-reverse-key-order` for showing the most recent > keys first. Thanks. > These two changes are useful for `kmacro-edit-lossage`. My use case is > that I would like to quickly create a keyboard macro from some of my > recent key presses, but Edmacro is slow to use when the lossage size is > large. When it is large, I must jump to the bottom of the buffer, then > cut the desired lines, then jump back up, then delete the remaining > lines, then paste the cut lines, then press `C-c C-c`. If I use > `delete-selection-mode`, I can combine two of the steps. With this new > change from the patch, I can move down a few lines, select a few lines, > then press `C-c C-r`, then press `C-c C-c`. If these commands are indeed important conveniences, they should be in the manual, I think. > +(defcustom edmacro-reverse-key-order nil > + "Non-nil if `edit-kbd-macro' should show the most recent keys first. > + > +This is useful when dealing with long lists of key sequences, such as > +from `kmacro-edit-lossage'." > + :type 'boolean > + :group 'kmacro) Defcustoms should have the :version tag. > +(defun edmacro-set-macro-to-region-lines (beg end) > + "Set the Macro text to the lines of the region. We prefer to have the mandatory arguments mentioned in the first line of a function's doc string. > +If BEG is not at the beginning of a line, it is moved to the > +beginning of the line. If END is at the beginning of a line, > +that line is excluded. Otherwise, if END is not at the > +end of a line, it is moved to the end of the line." This describes the implementation, whereas this is a command, so the doc string should have users, not programmer's in mind. Try to describe BEG and END in user-level terms, for example: Macro text will start and the beginning of line containing buffer position BEG. Also, the doc string should tell how BEG and END are determined in interactive invocations. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 07:02:00 2023 Received: (at control) by debbugs.gnu.org; 3 Sep 2023 11:02:00 +0000 Received: from localhost ([127.0.0.1]:39770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qckrf-0006Xy-VJ for submit@debbugs.gnu.org; Sun, 03 Sep 2023 07:02:00 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:51290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qckre-0006Xj-AL for control@debbugs.gnu.org; Sun, 03 Sep 2023 07:01:58 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-5008d16cc36so928947e87.2 for ; Sun, 03 Sep 2023 04:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693738902; x=1694343702; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=1juSM8OoHuwm61caK3Ip2B2Fryq242Y7+7g6jsa+FSU=; b=nnA7sRRG+pVZWCnS5fC3yDZ8DjaFqzql9v2A3RKpTRD6GpLEyBpec3oy8QHwaLww4n /ohV6m3rPR0idJE2c4yeq5GuJ4UOhbNt7Fcdwe+zrV4oyWTmtdfbu22exeHMRycmQ0QG FFGoBEhwHR9FyLxS+MTY3nN8MrBTteW5KK0JP8mb4EqtazJN5zkrMVNu342TG469nNg7 SWnNY9fECiZFtg88ar3+0zS/q6qv8dr6lWJkYnFvFAgRHHvPBGV8Q1DecHvbx6SnBuzF QPNzyyLn2PKlE5A/7ZzdfaS1vdbkVz83ssvUuOJi7qGnRGnri/qAh/jwFtw6fubFrW+r nmiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693738902; x=1694343702; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1juSM8OoHuwm61caK3Ip2B2Fryq242Y7+7g6jsa+FSU=; b=OhlpYnxfKhdBnlXV/mLnMGJPycKT2NGBb9qH1PJddLKHnFe7rOW64/DzwKaDwmjIHn cglIuHUBg4DqErRXe3K93PfHGkj2eLIYmpIsd5F9lPt92ct11felCa5+5NBS1VUQLinC m2grI8EiQ6RoDcpjm1VJYfKY8dGOWXyKXAmoF2+Oj6NDrYUGz2KOlXx8Et5/97EYDyzV VZFP4FBvappc4hxVJ2hJbjzKQibxYf27c0oA/8PIF1QKyhCDFCDWqONL6n6flB+d6mHX DKyQyp2G2n3jib4uj+wzW92okzNNBEptqmNfjntkOVxUsOwPXuxoFapP/xpvs74W9SLi vJNA== X-Gm-Message-State: AOJu0Yzvrrg24ZDj5aLFz+mZZueiMHC6/kIoa2tO4uz7di/Ay82sHPon Wkk+CnDLsF246E5dKpakSCsOahf0gT0nfZ8BOmZoX5cCU78= X-Google-Smtp-Source: AGHT+IF8cU8oWJnAamMfG4ThDyV0boQo3R1blNKj0+YhFupuDCaG2SyO1xZIsyl4TC8nyNxPsU62YTVoJsiEFKSmjqE= X-Received: by 2002:a19:7b06:0:b0:500:94aa:739c with SMTP id w6-20020a197b06000000b0050094aa739cmr3608814lfc.61.1693738902194; Sun, 03 Sep 2023 04:01:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 04:01:41 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 3 Sep 2023 04:01:41 -0700 Message-ID: Subject: control message for bug #65605 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 65605 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 13:22:36 2023 Received: (at 65605) by debbugs.gnu.org; 3 Sep 2023 17:22:36 +0000 Received: from localhost ([127.0.0.1]:46761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcqnz-0000aj-9i for submit@debbugs.gnu.org; Sun, 03 Sep 2023 13:22:35 -0400 Received: from mail-41103.protonmail.ch ([185.70.41.103]:48073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcqnt-0000aR-O5 for 65605@debbugs.gnu.org; Sun, 03 Sep 2023 13:22:34 -0400 Date: Sun, 03 Sep 2023 16:05:03 +0000 Authentication-Results: mail-41103.protonmail.ch; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="JuQClS65" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1693757106; x=1694016306; bh=WaqezXdJVRRhPQ3dKX3FV99lDhq3pQpQi0MknKPSnSU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=JuQClS650oY1dd+Jkg0YhaV33zUpbISsaGH7eozA7NPib9pYVX3H/CDi42WaMa5z6 L9pHZmWKWdzn1amISRYRE7a2t182wMmWmA3L6ixMvQFMm8dRy+qGJ7mTSQAOjp5Eyz rqhPSrRyMDEFXDzsk9J5X2FsGsPJprNpDh0bVuVQmXWmB4elzUICRaNk4ndCEjMO1H +UC5QY2uz0G/+w0VgnyjYaVFsvA9EyG6Brfj8bV4PjIJIPuEegN8L8IYsw/KBetnWM M8LUOJAJQ+Ik9kqG8QbTlfUsOe/aaL62D9nUz92NLPp+hbXk8jTALfQZqBMcBcpsIH 5udFehyVCpvOg== To: Eli Zaretskii From: Okamsn Subject: Re: bug#65605: [PATCH] Command and option to make Edmacro better for long sequences Message-ID: In-Reply-To: <83fs40hib7.fsf@gnu.org> References: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> <83fs40hib7.fsf@gnu.org> Feedback-ID: 25935600:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_pCVNVRxwvkiNrYg7DwikzUpEhoYtomgpqYukO1uY" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65605 Cc: 65605@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_pCVNVRxwvkiNrYg7DwikzUpEhoYtomgpqYukO1uY Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii wrote: > If these commands are indeed important conveniences, they should be in > the manual, I think. I have described the new command and `edmacro-insert-key` in the manual. > Defcustoms should have the :version tag. I have given it as "30.1". >=20 >> +(defun edmacro-set-macro-to-region-lines (beg end) >> + "Set the Macro text to the lines of the region. >=20 > We prefer to have the mandatory arguments mentioned in the first line > of a function's doc string. >=20 >> +If BEG is not at the beginning of a line, it is moved to the >> +beginning of the line. If END is at the beginning of a line, >> +that line is excluded. Otherwise, if END is not at the >> +end of a line, it is moved to the end of the line." >=20 > This describes the implementation, whereas this is a command, so the > doc string should have users, not programmer's in mind. Try to > describe BEG and END in user-level terms, for example: >=20 > Macro text will start and the beginning of line containing buffer > position BEG. >=20 > Also, the doc string should tell how BEG and END are determined in > interactive invocations. >=20 I have changed it. How does it look now? --b1_pCVNVRxwvkiNrYg7DwikzUpEhoYtomgpqYukO1uY Content-Type: text/x-patch; charset=UTF-8; name=v3-0001-Make-using-Edmacro-better-for-long-sequences-of-k.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v3-0001-Make-using-Edmacro-better-for-long-sequences-of-k.patch RnJvbSBmMTM2NTE5M2RmODNmN2E3NjVhYmM5NTUwN2JiZGRiMGQ1ZDVhOTI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFYXJsIEh5YXR0IDxva2Ftc25AcHJvdG9ubWFpbC5jb20+CkRh dGU6IFNhdCwgMTkgQXVnIDIwMjMgMTg6MjY6NDUgLTA0MDAKU3ViamVjdDogW1BBVENIIHYzXSBN YWtlIHVzaW5nIEVkbWFjcm8gYmV0dGVyIGZvciBsb25nIHNlcXVlbmNlcyBvZiBrZXlzLgoKKiBs aXNwL2VkbWFjcm8uZWwgKGVkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lcywKZWRtYWNy by1yZXZlcnNlLWtleS1vcmRlcik6IE5ldyBjb21tYW5kIGFuZCB1c2VyIG9wdGlvbiB0bwptYWtl IHdvcmtpbmcgd2l0aCBsb25nZXIgbGlzdHMgb2Yga2V5cyAoc3VjaCBhcyBmcm9tCidrbWFjcm8t ZWRpdC1sb3NzYWdlJykgZWFzaWVyLgooZWRpdC1rYmQtbWFjcm8pOiBNb3ZlIHJlZ2V4cHMgdXNl ZCB0byBpZGVudGlmeSBwYXJ0cyBvZiBidWZmZXIKdG8gaW50ZXJuYWwgdmFyaWFibGVzLgooZWRt YWNyby0tbWFjcm8tbGluZXMtcmVnZXhwLCBlZG1hY3JvLW1vZGUtZm9udC1sb2NrLWtleXdvcmRz KTogQWxsb3cKbm90aW5nIHdoZXRoZXIgdGhlIG1vc3QgcmVjZW50IGxpbmUgb2Yga2V5cyBpcyBk aXNwbGF5ZWQgZmlyc3QuCihlZG1hY3JvLW1vZGUtbWFwKTogQmluZCB0aGUgbmV3IGNvbW1hbmQg dG8gJ0MtYyBDLXInLgooZWRtYWNyby1tb2RlKTogRGVzY3JpYmUgdGhlIG5ldyBjb21tYW5kIGlu IHRoZSBtb2RlIGRvY3VtZW50YXRpb24Kc3RyaW5nLgoKKiBkb2MvZW1hY3Mva21hY3JvLnRleGkg KEVkaXQgS2V5Ym9hcmQgTWFjcm8pOiBNZW50aW9uCidlZG1hY3JvLWluc2VydC1rZXknIGFuZCB0 aGUgbmV3bHkgYWRkZWQKJ2VkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lcycuCi0tLQog ZG9jL2VtYWNzL2ttYWNyby50ZXhpIHwgIDExICsrKysKIGxpc3AvZWRtYWNyby5lbCAgICAgICB8 IDExMyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KIDIgZmlsZXMg Y2hhbmdlZCwgMTEzIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2RvYy9lbWFjcy9rbWFjcm8udGV4aSBiL2RvYy9lbWFjcy9rbWFjcm8udGV4aQppbmRleCBmYzE0 MDJiNDg5ZC4uMzAyMDFjYzcxYzMgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9rbWFjcm8udGV4aQor KysgYi9kb2MvZW1hY3Mva21hY3JvLnRleGkKQEAgLTUxNSw2ICs1MTUsMTcgQEAgRWRpdCBLZXli b2FyZCBNYWNybwogb2YgaG93IHRvIGVkaXQgdGhlIG1hY3JvLiAgV2hlbiB5b3UgYXJlIGZpbmlz aGVkIGVkaXRpbmcsIHR5cGUKIEBrYmR7Qy1jIEMtY30uCiAKK0BmaW5kZXggZWRtYWNyby1pbnNl cnQta2V5CitAZmluZGV4IGVkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lcworICBUaGUg bW9kZSBwcm92aWRlcyBjb21tYW5kcyBmb3IgbW9yZSBlYXNpbHkgZWRpdGluZyB0aGUgZm9ybWF0 dGVkCittYWNyby4gIFVzZSBAa2Jke0MtYyBDLXF9IChAY29kZXtlZG1hY3JvLWluc2VydC1rZXl9 KSB0byBpbnNlcnQgdGhlCituZXh0IGtleSBzZXF1ZW5jZSB0aGF0IHlvdSB0eXBlIGludG8gdGhl IGJ1ZmZlciB1c2luZyB0aGUgY29ycmVjdAorZm9ybWF0LCBzaW1pbGFyIHRvIEBrYmR7Qy1xfSAo QGNvZGV7cXVvdGVkLWluc2VydH0pLiAgVXNlIEBrYmR7Qy1jCitDLXJ9IChAY29kZXtlZG1hY3Jv LXNldC1tYWNyby10by1yZWdpb24tbGluZXN9KSB0byByZXBsYWNlIHRoZSBtYWNybydzCitmb3Jt YXR0ZWQgdGV4dCB3aXRoIHRoZSBsaW5lcyBvdmVybGFwcGluZyB0aGUgcmVnaW9uIG9mIHRleHQg YmV0d2VlbgorcG9pbnQgYW5kIG1hcmsuICBJZiB0aGUgcmVnaW9uIGVuZHMgYXQgdGhlIGJlZ2lu bmluZyBvZiBhIGxpbmUsIHRoYXQKK2ZpbmFsIGxpbmUgaXMgZXhjbHVkZWQuCisKIEBmaW5kZXgg ZWRpdC1rYmQtbWFjcm8KIEBraW5kZXggQy14IEMtayBlCiAgIFlvdSBjYW4gZWRpdCBhIG5hbWVk IGtleWJvYXJkIG1hY3JvIG9yIGEgbWFjcm8gYm91bmQgdG8gYSBrZXkgYnkgdHlwaW5nCmRpZmYg LS1naXQgYS9saXNwL2VkbWFjcm8uZWwgYi9saXNwL2VkbWFjcm8uZWwKaW5kZXggYmJmNWE3ZjA0 OTUuLjliYzM3ZTQ3NjIyIDEwMDY0NAotLS0gYS9saXNwL2VkbWFjcm8uZWwKKysrIGIvbGlzcC9l ZG1hY3JvLmVsCkBAIC03Myw5ICs3MywxOSBAQCBlZG1hY3JvLWVpZ2h0LWJpdHMKICAgOnR5cGUg J2Jvb2xlYW4KICAgOmdyb3VwICdrbWFjcm8pCiAKKyhkZWZjdXN0b20gZWRtYWNyby1yZXZlcnNl LWtleS1vcmRlciBuaWwKKyAgIk5vbi1uaWwgaWYgYGVkaXQta2JkLW1hY3JvJyBzaG91bGQgc2hv dyB0aGUgbW9zdCByZWNlbnQgbGluZSBvZiBrZXlzIGZpcnN0LgorCitUaGlzIGlzIHVzZWZ1bCB3 aGVuIGRlYWxpbmcgd2l0aCBsb25nIGxpc3RzIG9mIGtleSBzZXF1ZW5jZXMsIHN1Y2ggYXMKK2Zy b20gYGttYWNyby1lZGl0LWxvc3NhZ2UnLiIKKyAgOnR5cGUgJ2Jvb2xlYW4KKyAgOmdyb3VwICdr bWFjcm8KKyAgOnZlcnNpb24gIjMwLjEiKQorCiAoZGVmdmFyLWtleW1hcCBlZG1hY3JvLW1vZGUt bWFwCiAgICJDLWMgQy1jIiAjJ2VkbWFjcm8tZmluaXNoLWVkaXQKLSAgIkMtYyBDLXEiICMnZWRt YWNyby1pbnNlcnQta2V5KQorICAiQy1jIEMtcSIgIydlZG1hY3JvLWluc2VydC1rZXkKKyAgIkMt YyBDLXIiICMnZWRtYWNyby1zZXQtbWFjcm8tdG8tcmVnaW9uLWxpbmVzKQogCiAoZGVmZmFjZSBl ZG1hY3JvLWxhYmVsCiAgICcoKGRlZmF1bHQgOmluaGVyaXQgYm9sZCkKQEAgLTg4LDcgKzk4LDEw IEBAIGVkbWFjcm8tbGFiZWwKICAgOmdyb3VwICdrbWFjcm8pCiAKIChkZWZ2YXIgZWRtYWNyby1t b2RlLWZvbnQtbG9jay1rZXl3b3JkcwotICBgKCgsKHJ4IGJvbCAoZ3JvdXAgKG9yICJDb21tYW5k IiAiS2V5IiAiTWFjcm8iKSAiOiIpKSAwICdlZG1hY3JvLWxhYmVsKQorICBgKCgsKHJ4IGJvbCAo Z3JvdXAgKG9yICJDb21tYW5kIiAiS2V5IgorICAgICAgICAgICAgICAgICAgICAgICAgIChzZXEg Ik1hY3JvIiAoemVyby1vci1vbmUgIiAobW9zdCByZWNlbnQgbGluZSBmaXJzdCkiKSkpCisgICAg ICAgICAgICAgICAgICAgICAiOiIpKQorICAgICAwICdlZG1hY3JvLWxhYmVsKQogICAgICgsKHJ4 IGJvbAogICAgICAgICAgIChncm91cCAiOzsgS2V5Ym9hcmQgTWFjcm8gRWRpdG9yLiAgUHJlc3Mg IikKICAgICAgICAgICAoZ3JvdXAgKCo/IG5vbmwpKQpAQCAtMTY2LDcgKzE3OSwxMyBAQCBlZGl0 LWtiZC1tYWNybwogICAgICAgKGxldCogKChvbGRidWYgKGN1cnJlbnQtYnVmZmVyKSkKIAkgICAg IChtbWFjIChlZG1hY3JvLWZpeC1tZW51LWNvbW1hbmRzIG1hYykpCiAJICAgICAoZm10IChlZG1h Y3JvLWZvcm1hdC1rZXlzIG1tYWMgMSkpCi0JICAgICAoZm10diAoZWRtYWNyby1mb3JtYXQta2V5 cyBtbWFjIChub3QgcHJlZml4KSkpCisJICAgICAoZm10diAobGV0ICgoZm10diAoZWRtYWNyby1m b3JtYXQta2V5cyBtbWFjIChub3QgcHJlZml4KSkpKQorICAgICAgICAgICAgICAgICAgICAgKGlm IChub3QgZWRtYWNyby1yZXZlcnNlLWtleS1vcmRlcikKKyAgICAgICAgICAgICAgICAgICAgICAg ICBmbXR2CisgICAgICAgICAgICAgICAgICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAg ICAgICAgICAgICAgICAgICAgKGluc2VydCBmbXR2KQorICAgICAgICAgICAgICAgICAgICAgICAg IChyZXZlcnNlLXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAoYnVmZmVyLXN0cmluZykpKSkpCiAJICAgICAoYnVmIChnZXQtYnVmZmVyLWNy ZWF0ZSAiKkVkaXQgTWFjcm8qIikpKQogCShtZXNzYWdlICJGb3JtYXR0aW5nIGtleWJvYXJkIG1h Y3JvLi4uZG9uZSIpCiAJKHN3aXRjaC10by1idWZmZXIgYnVmKQpAQCAtMTgxLDYgKzIwMCw5IEBA IGVkaXQta2JkLW1hY3JvCiAgICAgICAgIChzZXRxLWxvY2FsIGZvbnQtbG9jay1kZWZhdWx0cwog ICAgICAgICAgICAgICAgICAgICAnKGVkbWFjcm8tbW9kZS1mb250LWxvY2sta2V5d29yZHMgbmls IG5pbCAoKD9cIiAuICJ3IikpKSkKICAgICAgICAgKHNldHEgZm9udC1sb2NrLW11bHRpbGluZSBu aWwpCisgICAgICAgIDs7IE1ha2UgYnVmZmVyLWxvY2FsIHNvIHRoYXQgdGhlIGNvbW1hbmRzIHN0 aWxsIHdvcmsKKyAgICAgICAgOzsgZXZlbiBpZiB0aGUgZGVmYXVsdCB2YWx1ZSBjaGFuZ2VzLgor ICAgICAgICAobWFrZS1sb2NhbC12YXJpYWJsZSAnZWRtYWNyby1yZXZlcnNlLWtleS1vcmRlcikK IAkoZXJhc2UtYnVmZmVyKQogICAgICAgICAoaW5zZXJ0IChzdWJzdGl0dXRlLWNvbW1hbmQta2V5 cwogICAgICAgICAgICAgICAgICAoY29uY2F0CkBAIC0yMDIsNyArMjI0LDkgQEAgZWRpdC1rYmQt bWFjcm8KIAkgICAgICAoaW5zZXJ0ICJLZXk6IG5vbmVcbiIpKSkKIAkgICh3aGVuIChhbmQgbWFj LWNvdW50ZXIgbWFjLWZvcm1hdCkKIAkgICAgKGluc2VydCAoZm9ybWF0ICJDb3VudGVyOiAlZFxu Rm9ybWF0OiBcIiVzXCJcbiIgbWFjLWNvdW50ZXIgbWFjLWZvcm1hdCkpKSkKLQkoaW5zZXJ0ICJc bk1hY3JvOlxuXG4iKQorCShpbnNlcnQgKGZvcm1hdCAiXG5NYWNybyVzOlxuXG4iIChpZiBlZG1h Y3JvLXJldmVyc2Uta2V5LW9yZGVyCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiIChtb3N0IHJlY2VudCBsaW5lIGZpcnN0KSIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiIikpKQogCShzYXZlLWV4Y3Vyc2lvbgogCSAgKGlu c2VydCBmbXR2ICJcbiIpKQogCShyZWNlbnRlciAnKDQpKQpAQCAtMjU1LDYgKzI3OSwzMyBAQCBm b3JtYXQta2JkLW1hY3JvCiAMCiA7OzsgQ29tbWFuZHMgZm9yICpFZGl0IE1hY3JvKiBidWZmZXIu CiAKKyhkZWZ2YXIgZWRtYWNyby0tc2tpcC1saW5lLXJlZ2V4cAorICAiWyBcdF0qXFwoJFxcfDs7 XFx8UkVNWyBcdFxuXVxcKSIKKyAgIkEgcmVnZXhwIGlkZW50aWZ5aW5nIGxpbmVzIHRoYXQgc2hv dWxkIGJlIGlnbm9yZWQuIikKKworKGRlZnZhciBlZG1hY3JvLS1jb21tYW5kLWxpbmUtcmVnZXhw CisgICJDb21tYW5kOlsgXHRdKlxcKFteIFx0XG5dKlxcKVsgXHRdKiQiCisgICJBIHJlZ2V4cCBp ZGVudGlmeWluZyB0aGUgbGluZSBjb250YWluaW5nIHRoZSBjb21tYW5kIG5hbWUuIikKKworKGRl ZnZhciBlZG1hY3JvLS1rZXktbGluZS1yZWdleHAKKyAgIktleTpcXCguKlxcKSQiCisgICJBIHJl Z2V4cCBpZGVudGlmeWluZyB0aGUgbGluZSBjb250YWluaW5nIHRoZSBib3VuZCBrZXkgc2VxdWVu Y2UuIikKKworKGRlZnZhciBlZG1hY3JvLS1jb3VudGVyLWxpbmUtcmVnZXhwCisgICJDb3VudGVy OlsgXHRdKlxcKFteIFx0XG5dKlxcKVsgXHRdKiQiCisgICJBIHJlZ2V4cCBpZGVudGlmeWluZyB0 aGUgbGluZSBjb250YWluaW5nIHRoZSBjb3VudGVyIHZhbHVlLiIpCisKKyhkZWZ2YXIgZWRtYWNy by0tZm9ybWF0LWxpbmUtcmVnZXhwCisgICJGb3JtYXQ6WyBcdF0qXCJcXChbXlxuXSpcXClcIlsg XHRdKiQiCisgICJBIHJlZ2V4cCBpZGVudGlmeWluZyB0aGUgbGluZSBjb250YWluaW5nIHRoZSBj b3VudGVyIGZvcm1hdC4iKQorCisoZGVmdmFyIGVkbWFjcm8tLW1hY3JvLWxpbmVzLXJlZ2V4cAor ICAocnggIk1hY3JvIgorICAgICAgKHplcm8tb3Itb25lICIgKG1vc3QgcmVjZW50IGxpbmUgZmly c3QpIikKKyAgICAgICI6IgorICAgICAgKHplcm8tb3ItbW9yZSAoYW55ICIgXHRcbiIpKSkKKyAg IkEgcmVnZXhwIGlkZW50aWZ5aW5nIHRoZSBsaW5lcyB0aGF0IHByZWNlZGUgdGhlIG1hY3JvJ3Mg Y29udGVudHMuIikKKwogKGRlZnVuIGVkbWFjcm8tZmluaXNoLWVkaXQgKCkKICAgKGludGVyYWN0 aXZlIG5pbCBlZG1hY3JvLW1vZGUpCiAgICh1bmxlc3MgKGVxIG1ham9yLW1vZGUgJ2VkbWFjcm8t bW9kZSkKQEAgLTI2Niw5ICszMTcsOSBAQCBlZG1hY3JvLWZpbmlzaC1lZGl0CiAJKHRvcCAocG9p bnQtbWluKSkpCiAgICAgKGdvdG8tY2hhciB0b3ApCiAgICAgKGxldCAoKGNhc2UtZm9sZC1zZWFy Y2ggbmlsKSkKLSAgICAgICh3aGlsZSAoY29uZCAoKGxvb2tpbmctYXQgIlsgXHRdKlxcKCRcXHw7 O1xcfFJFTVsgXHRcbl1cXCkiKQorICAgICAgKHdoaWxlIChjb25kICgobG9va2luZy1hdCBlZG1h Y3JvLS1za2lwLWxpbmUtcmVnZXhwKQogCQkgICAgdCkKLQkJICAgKChsb29raW5nLWF0ICJDb21t YW5kOlsgXHRdKlxcKFteIFx0XG5dKlxcKVsgXHRdKiQiKQorCQkgICAoKGxvb2tpbmctYXQgZWRt YWNyby0tY29tbWFuZC1saW5lLXJlZ2V4cCkKIAkJICAgICh3aGVuIGVkbWFjcm8tc3RvcmUtaG9v awogCQkgICAgICAoZXJyb3IgIlwiQ29tbWFuZFwiIGxpbmUgbm90IGFsbG93ZWQgaW4gdGhpcyBj b250ZXh0IikpCiAJCSAgICAobGV0ICgoc3RyIChtYXRjaC1zdHJpbmcgMSkpKQpAQCAtMjgzLDcg KzMzNCw3IEBAIGVkbWFjcm8tZmluaXNoLWVkaXQKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGNtZCkpKQogCQkJICAgICAoa2V5Ym9hcmQtcXVpdCkpKSkKIAkJICAgIHQpCi0J CSAgICgobG9va2luZy1hdCAiS2V5OlxcKC4qXFwpJCIpCisJCSAgICgobG9va2luZy1hdCBlZG1h Y3JvLS1rZXktbGluZS1yZWdleHApCiAJCSAgICAod2hlbiBlZG1hY3JvLXN0b3JlLWhvb2sKIAkJ ICAgICAgKGVycm9yICJcIktleVwiIGxpbmUgbm90IGFsbG93ZWQgaW4gdGhpcyBjb250ZXh0Iikp CiAJCSAgICAobGV0ICgoa2V5IChrYmQgKG1hdGNoLXN0cmluZyAxKSkpKQpAQCAtMzAzLDIxICsz NTQsMjEgQEAgZWRtYWNyby1maW5pc2gtZWRpdAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChlZG1hY3JvLWZvcm1hdC1rZXlzIGtleSAxKSkpKQogCQkJCSAoa2V5Ym9h cmQtcXVpdCkpKSkpKQogCQkgICAgdCkKLQkJICAgKChsb29raW5nLWF0ICJDb3VudGVyOlsgXHRd KlxcKFteIFx0XG5dKlxcKVsgXHRdKiQiKQorCQkgICAoKGxvb2tpbmctYXQgZWRtYWNyby0tY291 bnRlci1saW5lLXJlZ2V4cCkKIAkJICAgICh3aGVuIGVkbWFjcm8tc3RvcmUtaG9vawogCQkgICAg ICAoZXJyb3IgIlwiQ291bnRlclwiIGxpbmUgbm90IGFsbG93ZWQgaW4gdGhpcyBjb250ZXh0Iikp CiAJCSAgICAobGV0ICgoc3RyIChtYXRjaC1zdHJpbmcgMSkpKQogCQkgICAgICAodW5sZXNzIChl cXVhbCBzdHIgIiIpCiAJCQkoc2V0cSBtYWMtY291bnRlciAoc3RyaW5nLXRvLW51bWJlciBzdHIp KSkpCiAJCSAgICB0KQotCQkgICAoKGxvb2tpbmctYXQgIkZvcm1hdDpbIFx0XSpcIlxcKFteXG5d KlxcKVwiWyBcdF0qJCIpCisJCSAgICgobG9va2luZy1hdCBlZG1hY3JvLS1mb3JtYXQtbGluZS1y ZWdleHApCiAJCSAgICAod2hlbiBlZG1hY3JvLXN0b3JlLWhvb2sKIAkJICAgICAgKGVycm9yICJc IkZvcm1hdFwiIGxpbmUgbm90IGFsbG93ZWQgaW4gdGhpcyBjb250ZXh0IikpCiAJCSAgICAobGV0 ICgoc3RyIChtYXRjaC1zdHJpbmcgMSkpKQogCQkgICAgICAodW5sZXNzIChlcXVhbCBzdHIgIiIp CiAJCQkoc2V0cSBtYWMtZm9ybWF0IHN0cikpKQogCQkgICAgdCkKLQkJICAgKChsb29raW5nLWF0 ICJNYWNybzpbIFx0XG5dKiIpCisJCSAgICgobG9va2luZy1hdCBlZG1hY3JvLS1tYWNyby1saW5l cy1yZWdleHApCiAJCSAgICAoZ290by1jaGFyIChtYXRjaC1lbmQgMCkpCiAJCSAgICBuaWwpCiAJ CSAgICgoZW9icCkgbmlsKQpAQCAtMzM2LDcgKzM4NywxMyBAQCBlZG1hY3JvLWZpbmlzaC1lZGl0 CiAJKHdoZW4gKGJ1ZmZlci1uYW1lIG9idWYpCiAJICAoc2V0LWJ1ZmZlciBvYnVmKSkKIAkobWVz c2FnZSAiQ29tcGlsaW5nIGtleWJvYXJkIG1hY3JvLi4uIikKLQkobGV0ICgobWFjIChlZG1hY3Jv LXBhcnNlLWtleXMgc3RyKSkpCisJKGxldCAoKG1hYyAoZWRtYWNyby1wYXJzZS1rZXlzIChpZiBl ZG1hY3JvLXJldmVyc2Uta2V5LW9yZGVyCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChpbnNlcnQgc3RyKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHJldmVyc2UtcmVnaW9uIChwb2ludC1taW4pCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHBv aW50LW1heCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo YnVmZmVyLXN0cmluZykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHN0cikpKSkKIAkgIChtZXNzYWdlICJDb21waWxpbmcga2V5Ym9hcmQgbWFjcm8uLi5kb25lIikK IAkgIChpZiBzdG9yZS1ob29rCiAJICAgICAgKGZ1bmNhbGwgc3RvcmUtaG9vayBtYWMpCkBAIC0z NzIsNiArNDI5LDM2IEBAIGVkbWFjcm8taW5zZXJ0LWtleQogICAgICAgKGluc2VydCAoZWRtYWNy by1mb3JtYXQta2V5cyBrZXkgdCkgIlxuIikKICAgICAoaW5zZXJ0IChlZG1hY3JvLWZvcm1hdC1r ZXlzIGtleSkgIiAiKSkpCiAKKyhkZWZ1biBlZG1hY3JvLXNldC1tYWNyby10by1yZWdpb24tbGlu ZXMgKGJlZyBlbmQpCisgICJTZXQgdGhlIG1hY3JvIHRleHQgdG8gdGhlIGxpbmVzIG92ZXJsYXBw aW5nIHRoZSBidWZmZXIgdGV4dCBmcm9tIEJFRyB0byBFTkQuCisKK1doZW4gY2FsbGVkIGludGVy YWN0aXZlbHksIHRoaXMgY29tbWFuZCB1c2VzIHRoZSBiZWdpbm5pbmcgYW5kCitlbmQgb2YgdGhl IHNlbGVjdGVkIHJlZ2lvbiBhcyB0aGUgYnVmZmVyIHBvc2l0aW9ucy4KKworSWYgdGhlIHJlZ2lv biBlbmRzIGF0IHRoZSBiZWdpbm5pbmcgb2YgYSBsaW5lLCB0aGF0IGZpbmFsIGxpbmUgaXMKK2V4 Y2x1ZGVkLiIKKyAgKGludGVyYWN0aXZlICJyIiBlZG1hY3JvLW1vZGUpCisgIDs7IFVzZSBgc2F2 ZS1leGN1cnNpb24nIHRvIHJlc3RvcmUgcmVnaW9uIGlmIHRoZXJlIGFyZSBhbnkgZXJyb3JzLgor ICA7OyBJZiB0aGVyZSBhcmUgbm8gZXJyb3JzLCB1cGRhdGUgdGhlIG1hY3JvIGNvbnRlbnRzLCB0 aGVuIGdvIHRvIHRoZQorICA7OyBiZWdpbm5pbmcgb2YgdGhlIG1hY3JvIGNvbnRlbnRzLgorICAo bGV0ICgoZmluYWwtcG9zaXRpb24pKQorICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgKGdvdG8t Y2hhciBiZWcpCisgICAgICAodW5sZXNzIChib2xwKSAoc2V0cSBiZWcgKHBvcy1ib2wpKSkKKyAg ICAgIChnb3RvLWNoYXIgZW5kKQorICAgICAgKHVubGVzcyAob3IgKGJvbHApIChlb2xwKSkgKHNl dHEgZW5kIChwb3MtZW9sKSkpCisgICAgICAobGV0ICgodGV4dCAoYnVmZmVyLXN1YnN0cmluZyBi ZWcgZW5kKSkpCisgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgICAgICAgIChpZiAo bm90IChsZXQgKChjYXNlLWZvbGQtc2VhcmNoIG5pbCkpCisgICAgICAgICAgICAgICAgICAgKHJl LXNlYXJjaC1mb3J3YXJkIGVkbWFjcm8tLW1hY3JvLWxpbmVzLXJlZ2V4cCBuaWwgdCkpKQorICAg ICAgICAgICAgKHVzZXItZXJyb3IgIlwiTWFjcm86XCIgbGluZSBub3QgZm91bmQiKQorICAgICAg ICAgIChkZWxldGUtcmVnaW9uIChtYXRjaC1lbmQgMCkKKyAgICAgICAgICAgICAgICAgICAgICAg ICAocG9pbnQtbWF4KSkKKyAgICAgICAgICAoZ290by1jaGFyIChwb2ludC1tYXgpKQorICAgICAg ICAgIChpbnNlcnQgdGV4dCkKKyAgICAgICAgICAoc2V0cSBmaW5hbC1wb3NpdGlvbiAobWF0Y2gt YmVnaW5uaW5nIDApKSkpKQorICAgIChnb3RvLWNoYXIgZmluYWwtcG9zaXRpb24pKSkKKwogKGRl ZnVuIGVkbWFjcm8tbW9kZSAoKQogICAiXFw8ZWRtYWNyby1tb2RlLW1hcD5LZXlib2FyZCBNYWNy byBFZGl0aW5nIG1vZGUuICBQcmVzcyBcCiBcXFtlZG1hY3JvLWZpbmlzaC1lZGl0XSB0byBzYXZl IGFuZCBleGl0LgpAQCAtMzkzLDYgKzQ4MCwxMCBAQCBlZG1hY3JvLW1vZGUKIFlvdSBjYW4gZWRp dCB0aGVzZSBsaW5lcyB0byBjaGFuZ2UgdGhlIHBsYWNlcyB3aGVyZSB0aGUgbmV3IG1hY3JvCiBp cyBzdG9yZWQuCiAKK1ByZXNzIFxcW2VkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lc10g dG8gcmVwbGFjZSB0aGUgdGV4dCBmb2xsb3dpbmcgdGhlIFwiTWFjcm86XCIgbGluZQord2l0aCB0 aGUgdGV4dCBvZiB0aGUgbGluZXMgb3ZlcmxhcHBpbmcgdGhlIHJlZ2lvbiBvZiB0ZXh0IGJldHdl ZW4KK3BvaW50IGFuZCBtYXJrLiAgSWYgdGhhdCByZWdpb24gZW5kcyBhdCB0aGUgYmVnaW5uaW5n IG9mIGEgbGluZSwKK3RoYXQgZmluYWwgbGluZSBpcyBleGNsdWRlZC4KIAogRm9ybWF0IG9mIGtl eWJvYXJkIG1hY3JvcyBkdXJpbmcgZWRpdGluZzoKIAotLSAKMi4zNC4xCgo= --b1_pCVNVRxwvkiNrYg7DwikzUpEhoYtomgpqYukO1uY-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 14:36:44 2023 Received: (at 65605) by debbugs.gnu.org; 3 Sep 2023 18:36:44 +0000 Received: from localhost ([127.0.0.1]:46916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcrxj-00023P-No for submit@debbugs.gnu.org; Sun, 03 Sep 2023 14:36:43 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:46310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcrxi-00023C-4l for 65605@debbugs.gnu.org; Sun, 03 Sep 2023 14:36:42 -0400 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-5007c8308c3so1193486e87.0 for <65605@debbugs.gnu.org>; Sun, 03 Sep 2023 11:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766197; x=1694370997; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=HFLJC48RIIftEbhf0Cw5fMp1G4PJKDQ6mQKftFHigmw=; b=ijP0lUbos1HFYMdzK8fPpoVwpvzZaYmMt5V8FsGgI68lq244EQ2EwKT1fbaGdf/H9O 2rbH7qcGK/dqGyuebSKatuAHFNmeFe4TJwSKxB29xZ5Kj16GaHp0uJvOhCQhdS5pOR3s xkQIy5JbOA9jfjMkU6lUSog8T5925J2n2bqdl6tLAvJO5Mq8gRtz6vM5SBnjFazzzlKf IIn1GVz48pcWGuhZPT5wGDtNZm4swFYGynvpdkeDohyDN1VfkkV045Qq5Pt6arvRLKrI I6pPhHcEm63/MTi9WdXYZm1imV5SyLo31542M6EoybkP+VKpKc+PLlML50zXOl2Guzi6 5nxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766197; x=1694370997; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HFLJC48RIIftEbhf0Cw5fMp1G4PJKDQ6mQKftFHigmw=; b=K0/IIcZmdmlHwR67P/o9fk2C+WzjpKYUgn7jsiZXmbBzW6I7VWjmpm010tvBr8eNM9 OxuQ0HUfbNaCufydJd6HrfWZ1pLcXnafqXYYCWzt8KzKbK6TN6NCd4JTEm3fclgNIZYJ M+qnXZkAZCO7Up2B2t8Q+NRf/bTYZxzA7ezWisnIwgqEn73u3EACUSoRq0cHRUwnJivN MUbIyHf64HbcUa8mLxlUhi1dWuO29y6pNWXkJ2L9h+vsNX/2TpKwlnefw+CVf/1LmFlS Y3eYMKLvid8N93rbwkYPbJ10xDOwEaO9QV9TguOTTUPnVIb6heISqlULb2+rqV1EyMto 0WdQ== X-Gm-Message-State: AOJu0YwdkUrELGguaRLg+YVh3OzxKnOFMkRHcq9fL5CGbC5NyhC/e3SX SXOG0invYfYDsEjcJRlxxZ1RWHY/RFyzyH2ls+M= X-Google-Smtp-Source: AGHT+IGslW20uAUg/3h2eoU++Sc7qZTRH+S0d+TSXa4NSk0/7uAsyYP+EAAhx88x9Ggm5eIcyUxahkD2RUyUhq0NHto= X-Received: by 2002:a05:6512:2107:b0:4fe:c53:1824 with SMTP id q7-20020a056512210700b004fe0c531824mr4226675lfr.40.1693766196695; Sun, 03 Sep 2023 11:36:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 11:36:36 -0700 From: Stefan Kangas In-Reply-To: References: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> <83fs40hib7.fsf@gnu.org> MIME-Version: 1.0 Date: Sun, 3 Sep 2023 11:36:36 -0700 Message-ID: Subject: Re: bug#65605: [PATCH] Command and option to make Edmacro better for long sequences To: Okamsn , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65605 Cc: 65605@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Okamsn via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > From f1365193df83f7a765abc95507bbddb0d5d5a929 Mon Sep 17 00:00:00 2001 > From: Earl Hyatt > Date: Sat, 19 Aug 2023 18:26:45 -0400 > Subject: [PATCH v3] Make using Edmacro better for long sequences of keys. > > * lisp/edmacro.el (edmacro-set-macro-to-region-lines, > edmacro-reverse-key-order): New command and user option to > make working with longer lists of keys (such as from > 'kmacro-edit-lossage') easier. > (edit-kbd-macro): Move regexps used to identify parts of buffer > to internal variables. > (edmacro--macro-lines-regexp, edmacro-mode-font-lock-keywords): Allow > noting whether the most recent line of keys is displayed first. > (edmacro-mode-map): Bind the new command to 'C-c C-r'. > (edmacro-mode): Describe the new command in the mode documentation > string. Thanks, this looks like a useful feature. Your patch LGTM, but I think it deserves to be called out in NEWS. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 04 07:06:18 2023 Received: (at 65605) by debbugs.gnu.org; 4 Sep 2023 11:06:18 +0000 Received: from localhost ([127.0.0.1]:48900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7PO-0006gD-B6 for submit@debbugs.gnu.org; Mon, 04 Sep 2023 07:06:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7PI-0006fx-Vl for 65605@debbugs.gnu.org; Mon, 04 Sep 2023 07:06:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd7PC-0005a3-9V; Mon, 04 Sep 2023 07:06:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JC+1cU09iTRmU8bCN+n9k9Swgmz4AtnCnduLRDRiDhI=; b=VJ2rw2fmu6K4 NG39PXGzhUTtIgvoZ+3M6WlkKdlKX8qpZS1DMKxMJyGOxnwEiD1VdKNh7bUsiP2swDC1nyzEeS1bi 4N1JDHjlWpuHmNcGE4Sv3wKCdSZhuaYGFTRruifq0jp9fCpcaqyLUkpOiEhEeemLZaTXw33/G94Ed 0PdC9zltpS0+8P8MTxB3bl3nhDPoPsCwY3cMPw6VgrKC4uVd+YrZiDtp4qoBRw0UZzu1SvGQ+d2JC IHvWSaunVYProHdbl0GvTzRI2NTAhJUbc3UYFLcsMIo74E0zXARhfSSN+WOQ4guP3GDyVJdC582Vx 5mete1zmOPm08mc/danRhQ==; Date: Mon, 04 Sep 2023 14:05:38 +0300 Message-Id: <83pm2y5hbx.fsf@gnu.org> From: Eli Zaretskii To: Okamsn In-Reply-To: (message from Okamsn on Sun, 03 Sep 2023 16:05:03 +0000) Subject: Re: bug#65605: [PATCH] Command and option to make Edmacro better for long sequences References: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> <83fs40hib7.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65605 Cc: 65605@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 03 Sep 2023 16:05:03 +0000 > From: Okamsn > Cc: 65605@debbugs.gnu.org > > >> +If BEG is not at the beginning of a line, it is moved to the > >> +beginning of the line. If END is at the beginning of a line, > >> +that line is excluded. Otherwise, if END is not at the > >> +end of a line, it is moved to the end of the line." > > > > This describes the implementation, whereas this is a command, so the > > doc string should have users, not programmer's in mind. Try to > > describe BEG and END in user-level terms, for example: > > > > Macro text will start and the beginning of line containing buffer > > position BEG. > > > > Also, the doc string should tell how BEG and END are determined in > > interactive invocations. > > > > I have changed it. How does it look now? See some comments below. > +@findex edmacro-insert-key > +@findex edmacro-set-macro-to-region-lines > + The mode provides commands for more easily editing the formatted You say "The mode", but it is not clear what is "the mode" to which you allude. > +macro. Use @kbd{C-c C-q} (@code{edmacro-insert-key}) to insert the > +next key sequence that you type into the buffer using the correct > +format, similar to @kbd{C-q} (@code{quoted-insert}). Use @kbd{C-c > +C-r} (@code{edmacro-set-macro-to-region-lines}) to replace the macro's > +formatted text with the lines overlapping the region of text between > +point and mark. Here, "the lines overlapping the region of text between point and mark" is IMO not clear enough. I think you mean to say "text in the region", and the "overlapping" part is just to allude to the fact that the region might begin and/or end in the middle of a line? If so, I would suggest Use @kbd{C-c C-r} (@code{edmacro-set-macro-to-region-lines}) to replace the macro's formatted text with the text in the region. If the region begins not and beginning of a line or ends not at end of line, it is extended to include complete lines. Also, is the "formatted" in "macro's formatted text" really needed? What does "formatted" signify? > +(defcustom edmacro-reverse-key-order nil > + "Non-nil if `edit-kbd-macro' should show the most recent line of keys first. ^^^^ "Keys" or "key sequence"? > +(defun edmacro-set-macro-to-region-lines (beg end) > + "Set the macro text to the lines overlapping the buffer text from BEG to END. I would suggest Set macro text to lines of text in current buffer between BEG and END. > +When called interactively, this command uses the beginning and > +end of the selected region as the buffer positions. Interactively, BEG and END are the beginning and end of the region. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 08 20:45:27 2023 Received: (at 65605) by debbugs.gnu.org; 9 Sep 2023 00:45:27 +0000 Received: from localhost ([127.0.0.1]:45835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qem6I-0007pi-6W for submit@debbugs.gnu.org; Fri, 08 Sep 2023 20:45:27 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:58973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qem6E-0007pH-BR for 65605@debbugs.gnu.org; Fri, 08 Sep 2023 20:45:25 -0400 Date: Sat, 09 Sep 2023 00:45:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1694220313; x=1694479513; bh=BCtyGXs5C/8vWzrp/fie+fkEp7rG7Vb6hdhmnvzSX00=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=N3zsTaQoD1nvXEI/zG9tyukMbkQ7NlxG0dOdhIcwP08zuLbPMI/10ycJjQ4SpARLx NcbIXjD9RjCMc8BZtrfbb8Ngv53hC/zfsrxGPcTtmHJNt7VRw9sVqCSSazqOavtBUB M9qpdquIBSgyKaJvn9XwoTATfWTy121SlaW/MX2Lc5bbNQ73PWX9z7fXwxqQBFlrnS uQ3lh6vStSdaJ3zuToIUpVqgnfm3GgBmEwsj1Ezr64iWYY4hQMeULJV4yOCRZM7L5i DWQLroMm4BZbj3yyRH2hicR9slg9m3yaNGG+xMvlGyOq4XIa/KIVhP3VE3LE4CBNT1 a83PhS3d3/n9w== To: Eli Zaretskii From: Okamsn Subject: Re: bug#65605: [PATCH] Command and option to make Edmacro better for long sequences Message-ID: <3c4cb84b-8959-e3c1-f9a0-260c80a4ea75@protonmail.com> In-Reply-To: <83pm2y5hbx.fsf@gnu.org> References: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> <83fs40hib7.fsf@gnu.org> <83pm2y5hbx.fsf@gnu.org> Feedback-ID: 25935600:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_BQU4bMmpFgU2EUrRtyHUjgAcLWRKkT9Zh8c7OYgBSI" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65605 Cc: 65605@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_BQU4bMmpFgU2EUrRtyHUjgAcLWRKkT9Zh8c7OYgBSI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii wrote: >> Date: Sun, 03 Sep 2023 16:05:03 +0000 >> From: Okamsn >> Cc: 65605@debbugs.gnu.org >> >>>> +If BEG is not at the beginning of a line, it is moved to the >>>> +beginning of the line. If END is at the beginning of a line, >>>> +that line is excluded. Otherwise, if END is not at the >>>> +end of a line, it is moved to the end of the line." >>> >>> This describes the implementation, whereas this is a command, so the >>> doc string should have users, not programmer's in mind. Try to >>> describe BEG and END in user-level terms, for example: >>> >>> Macro text will start and the beginning of line containing buffer >>> position BEG. >>> >>> Also, the doc string should tell how BEG and END are determined in >>> interactive invocations. >>> >> >> I have changed it. How does it look now? >=20 > See some comments below. >=20 >> +@findex edmacro-insert-key >> +@findex edmacro-set-macro-to-region-lines >> + The mode provides commands for more easily editing the formatted >=20 > You say "The mode", but it is not clear what is "the mode" to which > you allude. >=20 >> +macro. Use @kbd{C-c C-q} (@code{edmacro-insert-key}) to insert the >> +next key sequence that you type into the buffer using the correct >> +format, similar to @kbd{C-q} (@code{quoted-insert}). Use @kbd{C-c >> +C-r} (@code{edmacro-set-macro-to-region-lines}) to replace the macro's >> +formatted text with the lines overlapping the region of text between >> +point and mark. >=20 > Here, "the lines overlapping the region of text between point and > mark" is IMO not clear enough. I think you mean to say "text in the > region", and the "overlapping" part is just to allude to the fact that > the region might begin and/or end in the middle of a line? If so, I > would suggest >=20 > Use @kbd{C-c C-r} (@code{edmacro-set-macro-to-region-lines}) to > replace the macro's formatted text with the text in the region. If > the region begins not and beginning of a line or ends not at end of > line, it is extended to include complete lines. >=20 > Also, is the "formatted" in "macro's formatted text" really needed? > What does "formatted" signify? I wasn't sure what to call the lines of formatted text showing the=20 macro's contents. I have changed it to just "text". >> +(defcustom edmacro-reverse-key-order nil >> + "Non-nil if `edit-kbd-macro' should show the most recent line of keys= first. > ^^= ^^ > "Keys" or "key sequence"? I have changed it to "key sequences". >> +(defun edmacro-set-macro-to-region-lines (beg end) >> + "Set the macro text to the lines overlapping the buffer text from BEG= to END. >=20 > I would suggest >=20 > Set macro text to lines of text in current buffer between BEG and END. >=20 >> +When called interactively, this command uses the beginning and >> +end of the selected region as the buffer positions. >=20 > Interactively, BEG and END are the beginning and end of the region. >=20 I have changed it to: "Set the macro text to lines of text in the buffer between BEG and END. Interactively, BEG and END are the beginning and end of the region. If the region does not begin at the start of a line or if it does not end at the end of a line, the region is extended to include complete lines. If the region ends at the beginning of a line, that final line is excluded." I have also added the new command and user option to "NEWS" as requested=20 by Stefan Kangas, and have described the new user option in the manual. I have also changed the name of the user option to=20 "edmacro-reverse-macro-lines", which is a bit clearer. --b1_BQU4bMmpFgU2EUrRtyHUjgAcLWRKkT9Zh8c7OYgBSI Content-Type: text/x-patch; charset=UTF-8; name=v4-0001-Make-using-Edmacro-better-for-long-sequences-of-k.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v4-0001-Make-using-Edmacro-better-for-long-sequences-of-k.patch RnJvbSBmYWEzMDZkZTgwY2FlNDE2YzEwNzlhOGRkOTAyNjE3YzM2NjY0NDQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFYXJsIEh5YXR0IDxva2Ftc25AcHJvdG9ubWFpbC5jb20+CkRh dGU6IFNhdCwgMTkgQXVnIDIwMjMgMTg6MjY6NDUgLTA0MDAKU3ViamVjdDogW1BBVENIIHY0XSBN YWtlIHVzaW5nIEVkbWFjcm8gYmV0dGVyIGZvciBsb25nIHNlcXVlbmNlcyBvZiBrZXlzLgoKKiBs aXNwL2VkbWFjcm8uZWwgKGVkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lcywKZWRtYWNy by1yZXZlcnNlLWtleS1vcmRlcik6IE5ldyBjb21tYW5kIGFuZCB1c2VyIG9wdGlvbiB0bwptYWtl IHdvcmtpbmcgd2l0aCBsb25nZXIgbGlzdHMgb2Yga2V5cyAoc3VjaCBhcyBmcm9tCidrbWFjcm8t ZWRpdC1sb3NzYWdlJykgZWFzaWVyLgooZWRpdC1rYmQtbWFjcm8pOiBNb3ZlIHJlZ2V4cHMgdXNl ZCB0byBpZGVudGlmeSBwYXJ0cyBvZiBidWZmZXIKdG8gaW50ZXJuYWwgdmFyaWFibGVzLgooZWRt YWNyby0tbWFjcm8tbGluZXMtcmVnZXhwLCBlZG1hY3JvLW1vZGUtZm9udC1sb2NrLWtleXdvcmRz KTogQWxsb3cKbm90aW5nIHdoZXRoZXIgdGhlIG1vc3QgcmVjZW50IGxpbmUgb2Yga2V5cyBpcyBk aXNwbGF5ZWQgZmlyc3QuCihlZG1hY3JvLW1vZGUtbWFwKTogQmluZCB0aGUgbmV3IGNvbW1hbmQg dG8gJ0MtYyBDLXInLgooZWRtYWNyby1tb2RlKTogRGVzY3JpYmUgdGhlIG5ldyBjb21tYW5kIGlu IHRoZSBtb2RlIGRvY3VtZW50YXRpb24Kc3RyaW5nLgoKKiBkb2MvZW1hY3Mva21hY3JvLnRleGkg KEVkaXQgS2V5Ym9hcmQgTWFjcm8pOiBNZW50aW9uCidlZG1hY3JvLWluc2VydC1rZXknIGFuZCB0 aGUgbmV3bHkgYWRkZWQKJ2VkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lcycgYW5kCidl ZG1hY3JvLXJldmVyc2Uta2V5LWxpbmUtb3JkZXInLgoKKiBldGMvTkVXUyAoRWRtYWNybyk6IEFk ZCBzZWN0aW9uIGRlc2NyaWJpbmcgdGhlIG5ldyBmZWF0dXJlcy4KLS0tCiBkb2MvZW1hY3Mva21h Y3JvLnRleGkgfCAgMTkgKysrKysrLQogZXRjL05FV1MgICAgICAgICAgICAgIHwgIDE0ICsrKysr KwogbGlzcC9lZG1hY3JvLmVsICAgICAgIHwgMTEzICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAxMzQgaW5zZXJ0aW9ucygrKSwgMTIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL2ttYWNyby50ZXhpIGIvZG9jL2Vt YWNzL2ttYWNyby50ZXhpCmluZGV4IGZjMTQwMmI0ODlkLi4wNTA5NWJjNjhiOCAxMDA2NDQKLS0t IGEvZG9jL2VtYWNzL2ttYWNyby50ZXhpCisrKyBiL2RvYy9lbWFjcy9rbWFjcm8udGV4aQpAQCAt NTE1LDYgKzUxNSwxOSBAQCBFZGl0IEtleWJvYXJkIE1hY3JvCiBvZiBob3cgdG8gZWRpdCB0aGUg bWFjcm8uICBXaGVuIHlvdSBhcmUgZmluaXNoZWQgZWRpdGluZywgdHlwZQogQGtiZHtDLWMgQy1j fS4KIAorQGZpbmRleCBlZG1hY3JvLWluc2VydC1rZXkKK0BmaW5kZXggZWRtYWNyby1zZXQtbWFj cm8tdG8tcmVnaW9uLWxpbmVzCisgIEBjb2Rle2VkbWFjcm8tbW9kZX0sIHRoZSBtYWpvciBtb2Rl IHVzZWQgYnkKK0Bjb2Rle2ttYWNyby1lZGl0LW1hY3JvfSwgcHJvdmlkZXMgY29tbWFuZHMgZm9y IG1vcmUgZWFzaWx5IGVkaXRpbmcKK3RoZSBmb3JtYXR0ZWQgbWFjcm8uICBVc2UgQGtiZHtDLWMg Qy1xfSAoQGNvZGV7ZWRtYWNyby1pbnNlcnQta2V5fSkgdG8KK2luc2VydCB0aGUgbmV4dCBrZXkg c2VxdWVuY2UgdGhhdCB5b3UgdHlwZSBpbnRvIHRoZSBidWZmZXIgdXNpbmcgdGhlCitjb3JyZWN0 IGZvcm1hdCwgc2ltaWxhciB0byBAa2Jke0MtcX0gKEBjb2Rle3F1b3RlZC1pbnNlcnR9KS4gIFVz ZQorQGtiZHtDLWMgQy1yfSAoQGNvZGV7ZWRtYWNyby1zZXQtbWFjcm8tdG8tcmVnaW9uLWxpbmVz fSkgdG8gcmVwbGFjZQordGhlIG1hY3JvJ3MgdGV4dCB3aXRoIHRoZSB0ZXh0IGluIHRoZSByZWdp b24uICBJZiB0aGUgcmVnaW9uIGRvZXMgbm90CitiZWdpbiBhdCB0aGUgc3RhcnQgb2YgYSBsaW5l IG9yIGlmIGl0IGRvZXMgbm90IGVuZCBhdCB0aGUgZW5kIG9mIGEKK2xpbmUsIHRoZSByZWdpb24g aXMgZXh0ZW5kZWQgdG8gaW5jbHVkZSBjb21wbGV0ZSBsaW5lcy4gIElmIHRoZSByZWdpb24KK2Vu ZHMgYXQgdGhlIGJlZ2lubmluZyBvZiBhIGxpbmUsIHRoYXQgZmluYWwgbGluZSBpcyBleGNsdWRl ZC4KKwogQGZpbmRleCBlZGl0LWtiZC1tYWNybwogQGtpbmRleCBDLXggQy1rIGUKICAgWW91IGNh biBlZGl0IGEgbmFtZWQga2V5Ym9hcmQgbWFjcm8gb3IgYSBtYWNybyBib3VuZCB0byBhIGtleSBi eSB0eXBpbmcKQEAgLTUyMyw5ICs1MzYsMTMgQEAgRWRpdCBLZXlib2FyZCBNYWNybwogQGtiZHtN LXggQHZhcntuYW1lfX0gb3Igc29tZSBvdGhlciBrZXkgc2VxdWVuY2UuCiAKIEBmaW5kZXgga21h Y3JvLWVkaXQtbG9zc2FnZQorQHZpbmRleCBlZG1hY3JvLXJldmVyc2UtbWFjcm8tbGluZXMKIEBr aW5kZXggQy14IEMtayBsCiAgIFlvdSBjYW4gZWRpdCB0aGUgbGFzdCAzMDAga2V5c3Ryb2tlcyBh cyBhIG1hY3JvIGJ5IHR5cGluZwotQGtiZHtDLXggQy1rIGx9IChAY29kZXtrbWFjcm8tZWRpdC1s b3NzYWdlfSkuCitAa2Jke0MteCBDLWsgbH0gKEBjb2Rle2ttYWNyby1lZGl0LWxvc3NhZ2V9KS4g IEJ5IGRlZmF1bHQsCit5b3VyIG1vc3QgcmVjZW50IGtleXN0cm9rZXMgYXJlIGxpc3RlZCBhdCB0 aGUgYm90dG9tIG9mIHRoZSBidWZmZXIuCitUbyBsaXN0IGEgbWFjcm8ncyBrZXkgc2VxdWVuY2Vz IGluIHJldmVyc2Ugb3JkZXIsIHNldAorQGNvZGV7ZWRtYWNyby1yZXZlcnNlLW1hY3JvLWxpbmVz fSB0byBAY29kZXt0fS4KIAogQG5vZGUgS2V5Ym9hcmQgTWFjcm8gU3RlcC1FZGl0CiBAc2VjdGlv biBTdGVwd2lzZSBFZGl0aW5nIGEgS2V5Ym9hcmQgTWFjcm8KZGlmZiAtLWdpdCBhL2V0Yy9ORVdT IGIvZXRjL05FV1MKaW5kZXggYmJmNGI2N2ZlMzQuLjU0NmQ3YjM0ZGU3IDEwMDY0NAotLS0gYS9l dGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtNzM0LDYgKzczNCwyMCBAQCBuZWl0aGVyIG9mIHdo aWNoIGhhdmUgYmVlbiBzdXBwb3J0ZWQgYnkgRW1hY3Mgc2luY2UgdmVyc2lvbiAyMy4xLgogVGhl IHVzZXIgb3B0aW9uICd1cmwtZ2F0ZXdheS1uc2xvb2t1cC1wcm9ncmFtJyBhbmQgdGhlIGZ1bmN0 aW9uCiAndXJsLWdhdGV3YXktbnNsb29rdXAtaG9zdCcgYXJlIGNvbnNlcXVlbnRseSBhbHNvIG9i c29sZXRlLgogCisrKysKKyoqIEVkbWFjcm8KKworKioqIE5ldyBjb21tYW5kICdlZG1hY3JvLXNl dC1tYWNyby10by1yZWdpb24tbGluZXMnLgorQm91bmQgdG8gJ0MtYyBDLXInLCB0aGlzIGNvbW1h bmQgcmVwbGFjZXMgdGhlIG1hY3JvIHRleHQgd2l0aCB0aGUKK2xpbmVzIG9mIHRoZSByZWdpb24u ICBJZiBuZWVkZWQsIHRoZSByZWdpb24gaXMgZXh0ZW5kZWQgdG8gaW5jbHVkZQord2hvbGUgbGlu ZXMuICBJZiB0aGUgcmVnaW9uIGVuZHMgYXQgdGhlIGJlZ2lubmluZyBvZiBhIGxpbmUsIHRoYXQg bGFzdAorbGluZSBpcyBleGNsdWRlZC4KKworKioqIE5ldyB1c2VyIG9wdGlvbiAnZWRtYWNyby1y ZXZlcnNlLW1hY3JvLWxpbmVzJy4KK1doZW4gdGhpcyBpcyBub24tbmlsLCB0aGUgbGluZXMgb2Yg a2V5IHNlcXVlbmNlcyBhcmUgZGlzcGxheWVkIHdpdGgKK3RoZSBtb3N0IHJlY2VudCBsaW5lIGZp c3QuICBUaGlzIGlzIGNhbiBiZSB1c2VmdWwgd2hlbiB3b3JraW5nIHdpdGgKK21hY3JvcyB3aXRo IG1hbnkgbGluZXMsIHN1Y2ggYXMgZnJvbSAna21hY3JvLWVkaXQtbG9zc2FnZScuCisKIAwKICog TmV3IE1vZGVzIGFuZCBQYWNrYWdlcyBpbiBFbWFjcyAzMC4xCiAKZGlmZiAtLWdpdCBhL2xpc3Av ZWRtYWNyby5lbCBiL2xpc3AvZWRtYWNyby5lbAppbmRleCBiYmY1YTdmMDQ5NS4uNmNhZDgxNTgz MjEgMTAwNjQ0Ci0tLSBhL2xpc3AvZWRtYWNyby5lbAorKysgYi9saXNwL2VkbWFjcm8uZWwKQEAg LTczLDkgKzczLDE5IEBAIGVkbWFjcm8tZWlnaHQtYml0cwogICA6dHlwZSAnYm9vbGVhbgogICA6 Z3JvdXAgJ2ttYWNybykKIAorKGRlZmN1c3RvbSBlZG1hY3JvLXJldmVyc2UtbWFjcm8tbGluZXMg bmlsCisgICJOb24tbmlsIGlmIGBlZGl0LWtiZC1tYWNybycgc2hvdWxkIHNob3cgdGhlIG1vc3Qg cmVjZW50IGxpbmUgb2Yga2V5IHNlcXVlbmNlcyBmaXJzdC4KKworVGhpcyBpcyB1c2VmdWwgd2hl biBkZWFsaW5nIHdpdGggbG9uZyBsaXN0cyBvZiBrZXkgc2VxdWVuY2VzLCBzdWNoIGFzCitmcm9t IGBrbWFjcm8tZWRpdC1sb3NzYWdlJy4iCisgIDp0eXBlICdib29sZWFuCisgIDpncm91cCAna21h Y3JvCisgIDp2ZXJzaW9uICIzMC4xIikKKwogKGRlZnZhci1rZXltYXAgZWRtYWNyby1tb2RlLW1h cAogICAiQy1jIEMtYyIgIydlZG1hY3JvLWZpbmlzaC1lZGl0Ci0gICJDLWMgQy1xIiAjJ2VkbWFj cm8taW5zZXJ0LWtleSkKKyAgIkMtYyBDLXEiICMnZWRtYWNyby1pbnNlcnQta2V5CisgICJDLWMg Qy1yIiAjJ2VkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lcykKIAogKGRlZmZhY2UgZWRt YWNyby1sYWJlbAogICAnKChkZWZhdWx0IDppbmhlcml0IGJvbGQpCkBAIC04OCw3ICs5OCwxMCBA QCBlZG1hY3JvLWxhYmVsCiAgIDpncm91cCAna21hY3JvKQogCiAoZGVmdmFyIGVkbWFjcm8tbW9k ZS1mb250LWxvY2sta2V5d29yZHMKLSAgYCgoLChyeCBib2wgKGdyb3VwIChvciAiQ29tbWFuZCIg IktleSIgIk1hY3JvIikgIjoiKSkgMCAnZWRtYWNyby1sYWJlbCkKKyAgYCgoLChyeCBib2wgKGdy b3VwIChvciAiQ29tbWFuZCIgIktleSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAoc2VxICJN YWNybyIgKHplcm8tb3Itb25lICIgKG1vc3QgcmVjZW50IGxpbmUgZmlyc3QpIikpKQorICAgICAg ICAgICAgICAgICAgICAgIjoiKSkKKyAgICAgMCAnZWRtYWNyby1sYWJlbCkKICAgICAoLChyeCBi b2wKICAgICAgICAgICAoZ3JvdXAgIjs7IEtleWJvYXJkIE1hY3JvIEVkaXRvci4gIFByZXNzICIp CiAgICAgICAgICAgKGdyb3VwICgqPyBub25sKSkKQEAgLTE2Niw3ICsxNzksMTMgQEAgZWRpdC1r YmQtbWFjcm8KICAgICAgIChsZXQqICgob2xkYnVmIChjdXJyZW50LWJ1ZmZlcikpCiAJICAgICAo bW1hYyAoZWRtYWNyby1maXgtbWVudS1jb21tYW5kcyBtYWMpKQogCSAgICAgKGZtdCAoZWRtYWNy by1mb3JtYXQta2V5cyBtbWFjIDEpKQotCSAgICAgKGZtdHYgKGVkbWFjcm8tZm9ybWF0LWtleXMg bW1hYyAobm90IHByZWZpeCkpKQorCSAgICAgKGZtdHYgKGxldCAoKGZtdHYgKGVkbWFjcm8tZm9y bWF0LWtleXMgbW1hYyAobm90IHByZWZpeCkpKSkKKyAgICAgICAgICAgICAgICAgICAgIChpZiAo bm90IGVkbWFjcm8tcmV2ZXJzZS1tYWNyby1saW5lcykKKyAgICAgICAgICAgICAgICAgICAgICAg ICBmbXR2CisgICAgICAgICAgICAgICAgICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAg ICAgICAgICAgICAgICAgICAgKGluc2VydCBmbXR2KQorICAgICAgICAgICAgICAgICAgICAgICAg IChyZXZlcnNlLXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAoYnVmZmVyLXN0cmluZykpKSkpCiAJICAgICAoYnVmIChnZXQtYnVmZmVyLWNy ZWF0ZSAiKkVkaXQgTWFjcm8qIikpKQogCShtZXNzYWdlICJGb3JtYXR0aW5nIGtleWJvYXJkIG1h Y3JvLi4uZG9uZSIpCiAJKHN3aXRjaC10by1idWZmZXIgYnVmKQpAQCAtMTgxLDYgKzIwMCw5IEBA IGVkaXQta2JkLW1hY3JvCiAgICAgICAgIChzZXRxLWxvY2FsIGZvbnQtbG9jay1kZWZhdWx0cwog ICAgICAgICAgICAgICAgICAgICAnKGVkbWFjcm8tbW9kZS1mb250LWxvY2sta2V5d29yZHMgbmls IG5pbCAoKD9cIiAuICJ3IikpKSkKICAgICAgICAgKHNldHEgZm9udC1sb2NrLW11bHRpbGluZSBu aWwpCisgICAgICAgIDs7IE1ha2UgYnVmZmVyLWxvY2FsIHNvIHRoYXQgdGhlIGNvbW1hbmRzIHN0 aWxsIHdvcmsKKyAgICAgICAgOzsgZXZlbiBpZiB0aGUgZGVmYXVsdCB2YWx1ZSBjaGFuZ2VzLgor ICAgICAgICAobWFrZS1sb2NhbC12YXJpYWJsZSAnZWRtYWNyby1yZXZlcnNlLW1hY3JvLWxpbmVz KQogCShlcmFzZS1idWZmZXIpCiAgICAgICAgIChpbnNlcnQgKHN1YnN0aXR1dGUtY29tbWFuZC1r ZXlzCiAgICAgICAgICAgICAgICAgIChjb25jYXQKQEAgLTIwMiw3ICsyMjQsOSBAQCBlZGl0LWti ZC1tYWNybwogCSAgICAgIChpbnNlcnQgIktleTogbm9uZVxuIikpKQogCSAgKHdoZW4gKGFuZCBt YWMtY291bnRlciBtYWMtZm9ybWF0KQogCSAgICAoaW5zZXJ0IChmb3JtYXQgIkNvdW50ZXI6ICVk XG5Gb3JtYXQ6IFwiJXNcIlxuIiBtYWMtY291bnRlciBtYWMtZm9ybWF0KSkpKQotCShpbnNlcnQg IlxuTWFjcm86XG5cbiIpCisJKGluc2VydCAoZm9ybWF0ICJcbk1hY3JvJXM6XG5cbiIgKGlmIGVk bWFjcm8tcmV2ZXJzZS1tYWNyby1saW5lcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIiAobW9zdCByZWNlbnQgbGluZSBmaXJzdCkiCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIiIpKSkKIAkoc2F2ZS1leGN1cnNpb24KIAkg IChpbnNlcnQgZm10diAiXG4iKSkKIAkocmVjZW50ZXIgJyg0KSkKQEAgLTI1NSw2ICsyNzksMzMg QEAgZm9ybWF0LWtiZC1tYWNybwogDAogOzs7IENvbW1hbmRzIGZvciAqRWRpdCBNYWNybyogYnVm ZmVyLgogCisoZGVmdmFyIGVkbWFjcm8tLXNraXAtbGluZS1yZWdleHAKKyAgIlsgXHRdKlxcKCRc XHw7O1xcfFJFTVsgXHRcbl1cXCkiCisgICJBIHJlZ2V4cCBpZGVudGlmeWluZyBsaW5lcyB0aGF0 IHNob3VsZCBiZSBpZ25vcmVkLiIpCisKKyhkZWZ2YXIgZWRtYWNyby0tY29tbWFuZC1saW5lLXJl Z2V4cAorICAiQ29tbWFuZDpbIFx0XSpcXChbXiBcdFxuXSpcXClbIFx0XSokIgorICAiQSByZWdl eHAgaWRlbnRpZnlpbmcgdGhlIGxpbmUgY29udGFpbmluZyB0aGUgY29tbWFuZCBuYW1lLiIpCisK KyhkZWZ2YXIgZWRtYWNyby0ta2V5LWxpbmUtcmVnZXhwCisgICJLZXk6XFwoLipcXCkkIgorICAi QSByZWdleHAgaWRlbnRpZnlpbmcgdGhlIGxpbmUgY29udGFpbmluZyB0aGUgYm91bmQga2V5IHNl cXVlbmNlLiIpCisKKyhkZWZ2YXIgZWRtYWNyby0tY291bnRlci1saW5lLXJlZ2V4cAorICAiQ291 bnRlcjpbIFx0XSpcXChbXiBcdFxuXSpcXClbIFx0XSokIgorICAiQSByZWdleHAgaWRlbnRpZnlp bmcgdGhlIGxpbmUgY29udGFpbmluZyB0aGUgY291bnRlciB2YWx1ZS4iKQorCisoZGVmdmFyIGVk bWFjcm8tLWZvcm1hdC1saW5lLXJlZ2V4cAorICAiRm9ybWF0OlsgXHRdKlwiXFwoW15cbl0qXFwp XCJbIFx0XSokIgorICAiQSByZWdleHAgaWRlbnRpZnlpbmcgdGhlIGxpbmUgY29udGFpbmluZyB0 aGUgY291bnRlciBmb3JtYXQuIikKKworKGRlZnZhciBlZG1hY3JvLS1tYWNyby1saW5lcy1yZWdl eHAKKyAgKHJ4ICJNYWNybyIKKyAgICAgICh6ZXJvLW9yLW9uZSAiIChtb3N0IHJlY2VudCBsaW5l IGZpcnN0KSIpCisgICAgICAiOiIKKyAgICAgICh6ZXJvLW9yLW1vcmUgKGFueSAiIFx0XG4iKSkp CisgICJBIHJlZ2V4cCBpZGVudGlmeWluZyB0aGUgbGluZXMgdGhhdCBwcmVjZWRlIHRoZSBtYWNy bydzIGNvbnRlbnRzLiIpCisKIChkZWZ1biBlZG1hY3JvLWZpbmlzaC1lZGl0ICgpCiAgIChpbnRl cmFjdGl2ZSBuaWwgZWRtYWNyby1tb2RlKQogICAodW5sZXNzIChlcSBtYWpvci1tb2RlICdlZG1h Y3JvLW1vZGUpCkBAIC0yNjYsOSArMzE3LDkgQEAgZWRtYWNyby1maW5pc2gtZWRpdAogCSh0b3Ag KHBvaW50LW1pbikpKQogICAgIChnb3RvLWNoYXIgdG9wKQogICAgIChsZXQgKChjYXNlLWZvbGQt c2VhcmNoIG5pbCkpCi0gICAgICAod2hpbGUgKGNvbmQgKChsb29raW5nLWF0ICJbIFx0XSpcXCgk XFx8OztcXHxSRU1bIFx0XG5dXFwpIikKKyAgICAgICh3aGlsZSAoY29uZCAoKGxvb2tpbmctYXQg ZWRtYWNyby0tc2tpcC1saW5lLXJlZ2V4cCkKIAkJICAgIHQpCi0JCSAgICgobG9va2luZy1hdCAi Q29tbWFuZDpbIFx0XSpcXChbXiBcdFxuXSpcXClbIFx0XSokIikKKwkJICAgKChsb29raW5nLWF0 IGVkbWFjcm8tLWNvbW1hbmQtbGluZS1yZWdleHApCiAJCSAgICAod2hlbiBlZG1hY3JvLXN0b3Jl LWhvb2sKIAkJICAgICAgKGVycm9yICJcIkNvbW1hbmRcIiBsaW5lIG5vdCBhbGxvd2VkIGluIHRo aXMgY29udGV4dCIpKQogCQkgICAgKGxldCAoKHN0ciAobWF0Y2gtc3RyaW5nIDEpKSkKQEAgLTI4 Myw3ICszMzQsNyBAQCBlZG1hY3JvLWZpbmlzaC1lZGl0CiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjbWQpKSkKIAkJCSAgICAgKGtleWJvYXJkLXF1aXQpKSkpCiAJCSAgICB0 KQotCQkgICAoKGxvb2tpbmctYXQgIktleTpcXCguKlxcKSQiKQorCQkgICAoKGxvb2tpbmctYXQg ZWRtYWNyby0ta2V5LWxpbmUtcmVnZXhwKQogCQkgICAgKHdoZW4gZWRtYWNyby1zdG9yZS1ob29r CiAJCSAgICAgIChlcnJvciAiXCJLZXlcIiBsaW5lIG5vdCBhbGxvd2VkIGluIHRoaXMgY29udGV4 dCIpKQogCQkgICAgKGxldCAoKGtleSAoa2JkIChtYXRjaC1zdHJpbmcgMSkpKSkKQEAgLTMwMywy MSArMzU0LDIxIEBAIGVkbWFjcm8tZmluaXNoLWVkaXQKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoZWRtYWNyby1mb3JtYXQta2V5cyBrZXkgMSkpKSkKIAkJCQkgKGtl eWJvYXJkLXF1aXQpKSkpKSkKIAkJICAgIHQpCi0JCSAgICgobG9va2luZy1hdCAiQ291bnRlcjpb IFx0XSpcXChbXiBcdFxuXSpcXClbIFx0XSokIikKKwkJICAgKChsb29raW5nLWF0IGVkbWFjcm8t LWNvdW50ZXItbGluZS1yZWdleHApCiAJCSAgICAod2hlbiBlZG1hY3JvLXN0b3JlLWhvb2sKIAkJ ICAgICAgKGVycm9yICJcIkNvdW50ZXJcIiBsaW5lIG5vdCBhbGxvd2VkIGluIHRoaXMgY29udGV4 dCIpKQogCQkgICAgKGxldCAoKHN0ciAobWF0Y2gtc3RyaW5nIDEpKSkKIAkJICAgICAgKHVubGVz cyAoZXF1YWwgc3RyICIiKQogCQkJKHNldHEgbWFjLWNvdW50ZXIgKHN0cmluZy10by1udW1iZXIg c3RyKSkpKQogCQkgICAgdCkKLQkJICAgKChsb29raW5nLWF0ICJGb3JtYXQ6WyBcdF0qXCJcXChb XlxuXSpcXClcIlsgXHRdKiQiKQorCQkgICAoKGxvb2tpbmctYXQgZWRtYWNyby0tZm9ybWF0LWxp bmUtcmVnZXhwKQogCQkgICAgKHdoZW4gZWRtYWNyby1zdG9yZS1ob29rCiAJCSAgICAgIChlcnJv ciAiXCJGb3JtYXRcIiBsaW5lIG5vdCBhbGxvd2VkIGluIHRoaXMgY29udGV4dCIpKQogCQkgICAg KGxldCAoKHN0ciAobWF0Y2gtc3RyaW5nIDEpKSkKIAkJICAgICAgKHVubGVzcyAoZXF1YWwgc3Ry ICIiKQogCQkJKHNldHEgbWFjLWZvcm1hdCBzdHIpKSkKIAkJICAgIHQpCi0JCSAgICgobG9va2lu Zy1hdCAiTWFjcm86WyBcdFxuXSoiKQorCQkgICAoKGxvb2tpbmctYXQgZWRtYWNyby0tbWFjcm8t bGluZXMtcmVnZXhwKQogCQkgICAgKGdvdG8tY2hhciAobWF0Y2gtZW5kIDApKQogCQkgICAgbmls KQogCQkgICAoKGVvYnApIG5pbCkKQEAgLTMzNiw3ICszODcsMTMgQEAgZWRtYWNyby1maW5pc2gt ZWRpdAogCSh3aGVuIChidWZmZXItbmFtZSBvYnVmKQogCSAgKHNldC1idWZmZXIgb2J1ZikpCiAJ KG1lc3NhZ2UgIkNvbXBpbGluZyBrZXlib2FyZCBtYWNyby4uLiIpCi0JKGxldCAoKG1hYyAoZWRt YWNyby1wYXJzZS1rZXlzIHN0cikpKQorCShsZXQgKChtYWMgKGVkbWFjcm8tcGFyc2Uta2V5cyAo aWYgZWRtYWNyby1yZXZlcnNlLW1hY3JvLWxpbmVzCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChpbnNlcnQgc3RyKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJldmVyc2UtcmVnaW9uIChwb2ludC1taW4pCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKHBvaW50LW1heCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoYnVmZmVyLXN0cmluZykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0cikpKSkKIAkgIChtZXNzYWdlICJDb21waWxpbmcga2V5Ym9hcmQgbWFjcm8uLi5k b25lIikKIAkgIChpZiBzdG9yZS1ob29rCiAJICAgICAgKGZ1bmNhbGwgc3RvcmUtaG9vayBtYWMp CkBAIC0zNzIsNiArNDI5LDM2IEBAIGVkbWFjcm8taW5zZXJ0LWtleQogICAgICAgKGluc2VydCAo ZWRtYWNyby1mb3JtYXQta2V5cyBrZXkgdCkgIlxuIikKICAgICAoaW5zZXJ0IChlZG1hY3JvLWZv cm1hdC1rZXlzIGtleSkgIiAiKSkpCiAKKyhkZWZ1biBlZG1hY3JvLXNldC1tYWNyby10by1yZWdp b24tbGluZXMgKGJlZyBlbmQpCisgICJTZXQgdGhlIG1hY3JvIHRleHQgdG8gbGluZXMgb2YgdGV4 dCBpbiB0aGUgYnVmZmVyIGJldHdlZW4gQkVHIGFuZCBFTkQuCisKK0ludGVyYWN0aXZlbHksIEJF RyBhbmQgRU5EIGFyZSB0aGUgYmVnaW5uaW5nIGFuZCBlbmQgb2YgdGhlCityZWdpb24uICBJZiB0 aGUgcmVnaW9uIGRvZXMgbm90IGJlZ2luIGF0IHRoZSBzdGFydCBvZiBhIGxpbmUgb3IKK2lmIGl0 IGRvZXMgbm90IGVuZCBhdCB0aGUgZW5kIG9mIGEgbGluZSwgdGhlIHJlZ2lvbiBpcyBleHRlbmRl ZAordG8gaW5jbHVkZSBjb21wbGV0ZSBsaW5lcy4gIElmIHRoZSByZWdpb24gZW5kcyBhdCB0aGUg YmVnaW5uaW5nCitvZiBhIGxpbmUsIHRoYXQgZmluYWwgbGluZSBpcyBleGNsdWRlZC4iCisgIChp bnRlcmFjdGl2ZSAiKnIiIGVkbWFjcm8tbW9kZSkKKyAgOzsgVXNlIGBzYXZlLWV4Y3Vyc2lvbicg dG8gcmVzdG9yZSByZWdpb24gaWYgdGhlcmUgYXJlIGFueSBlcnJvcnMuCisgIDs7IElmIHRoZXJl IGFyZSBubyBlcnJvcnMsIHVwZGF0ZSB0aGUgbWFjcm8gdGV4dCwgdGhlbiBnbyB0byB0aGUKKyAg OzsgYmVnaW5uaW5nIG9mIHRoZSBtYWNybyB0ZXh0LgorICAobGV0ICgoZmluYWwtcG9zaXRpb24p KQorICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgKGdvdG8tY2hhciBiZWcpCisgICAgICAodW5s ZXNzIChib2xwKSAoc2V0cSBiZWcgKHBvcy1ib2wpKSkKKyAgICAgIChnb3RvLWNoYXIgZW5kKQor ICAgICAgKHVubGVzcyAob3IgKGJvbHApIChlb2xwKSkgKHNldHEgZW5kIChwb3MtZW9sKSkpCisg ICAgICAobGV0ICgodGV4dCAoYnVmZmVyLXN1YnN0cmluZyBiZWcgZW5kKSkpCisgICAgICAgIChn b3RvLWNoYXIgKHBvaW50LW1pbikpCisgICAgICAgIChpZiAobm90IChsZXQgKChjYXNlLWZvbGQt c2VhcmNoIG5pbCkpCisgICAgICAgICAgICAgICAgICAgKHJlLXNlYXJjaC1mb3J3YXJkIGVkbWFj cm8tLW1hY3JvLWxpbmVzLXJlZ2V4cCBuaWwgdCkpKQorICAgICAgICAgICAgKHVzZXItZXJyb3Ig IlwiTWFjcm86XCIgbGluZSBub3QgZm91bmQiKQorICAgICAgICAgIChkZWxldGUtcmVnaW9uICht YXRjaC1lbmQgMCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAocG9pbnQtbWF4KSkKKyAgICAg ICAgICAoZ290by1jaGFyIChwb2ludC1tYXgpKQorICAgICAgICAgIChpbnNlcnQgdGV4dCkKKyAg ICAgICAgICAoc2V0cSBmaW5hbC1wb3NpdGlvbiAobWF0Y2gtYmVnaW5uaW5nIDApKSkpKQorICAg IChnb3RvLWNoYXIgZmluYWwtcG9zaXRpb24pKSkKKwogKGRlZnVuIGVkbWFjcm8tbW9kZSAoKQog ICAiXFw8ZWRtYWNyby1tb2RlLW1hcD5LZXlib2FyZCBNYWNybyBFZGl0aW5nIG1vZGUuICBQcmVz cyBcCiBcXFtlZG1hY3JvLWZpbmlzaC1lZGl0XSB0byBzYXZlIGFuZCBleGl0LgpAQCAtMzkzLDYg KzQ4MCwxMCBAQCBlZG1hY3JvLW1vZGUKIFlvdSBjYW4gZWRpdCB0aGVzZSBsaW5lcyB0byBjaGFu Z2UgdGhlIHBsYWNlcyB3aGVyZSB0aGUgbmV3IG1hY3JvCiBpcyBzdG9yZWQuCiAKK1ByZXNzIFxc W2VkbWFjcm8tc2V0LW1hY3JvLXRvLXJlZ2lvbi1saW5lc10gdG8gcmVwbGFjZSB0aGUgdGV4dCBm b2xsb3dpbmcgdGhlIFwiTWFjcm86XCIgbGluZQord2l0aCB0aGUgdGV4dCBvZiB0aGUgbGluZXMg b3ZlcmxhcHBpbmcgdGhlIHJlZ2lvbiBvZiB0ZXh0IGJldHdlZW4KK3BvaW50IGFuZCBtYXJrLiAg SWYgdGhhdCByZWdpb24gZW5kcyBhdCB0aGUgYmVnaW5uaW5nIG9mIGEgbGluZSwKK3RoYXQgZmlu YWwgbGluZSBpcyBleGNsdWRlZC4KIAogRm9ybWF0IG9mIGtleWJvYXJkIG1hY3JvcyBkdXJpbmcg ZWRpdGluZzoKIAotLSAKMi4zNC4xCgo= --b1_BQU4bMmpFgU2EUrRtyHUjgAcLWRKkT9Zh8c7OYgBSI-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 16 05:55:33 2023 Received: (at 65605-done) by debbugs.gnu.org; 16 Sep 2023 09:55:33 +0000 Received: from localhost ([127.0.0.1]:45405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhS1V-00039P-Bj for submit@debbugs.gnu.org; Sat, 16 Sep 2023 05:55:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhS1Q-000398-Ni for 65605-done@debbugs.gnu.org; Sat, 16 Sep 2023 05:55:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhS1B-0003Dj-2o; Sat, 16 Sep 2023 05:55:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9aufVT5+1+DSWIDS0CqtHSMSQ1k6ippwPmKmoBUrm0A=; b=ZeD6oDuAVh99 niXv8C1FzAFc1zrw0wNDWj+KtYxfNe/uhF2jeJAAXl0NVMR0QpuVDr65LM43RUpRpGiO4iQi9ptyu TyV4JksJwRnRN920eexZvoL9xK2W8aHlXCrATZfxdPYA7VUrfWC4qQqn66UBoi8uB7B9TZaGerYxk bz0QFnzWjO6sFixFKYQ59+Allo8DFXlWez16/9n08bGhZ30LUWzYrtfnNX6TE1A/VgXipCQg4ylwT 8EfqW/vjN1tESVkatTrcUPfRoXyLeRbIBbYd8e0Y305jQRtbM/IvNz0xsXneYLeOPo4/kHd9ZIXIc Yt8YL/c+NM3EIdPiQV/2bg==; Date: Sat, 16 Sep 2023 12:55:05 +0300 Message-Id: <83pm2iigsm.fsf@gnu.org> From: Eli Zaretskii To: Okamsn In-Reply-To: <3c4cb84b-8959-e3c1-f9a0-260c80a4ea75@protonmail.com> (message from Okamsn on Sat, 09 Sep 2023 00:45:05 +0000) Subject: Re: bug#65605: [PATCH] Command and option to make Edmacro better for long sequences References: <225c038a-5279-bfe9-cc04-eb09bb1d47f8@protonmail.com> <83fs40hib7.fsf@gnu.org> <83pm2y5hbx.fsf@gnu.org> <3c4cb84b-8959-e3c1-f9a0-260c80a4ea75@protonmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65605-done Cc: 65605-done@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 09 Sep 2023 00:45:05 +0000 > From: Okamsn > Cc: 65605@debbugs.gnu.org, stefankangas@gmail.com > > Eli Zaretskii wrote: > >> Date: Sun, 03 Sep 2023 16:05:03 +0000 > >> From: Okamsn > >> Cc: 65605@debbugs.gnu.org > >> > >>>> +If BEG is not at the beginning of a line, it is moved to the > >>>> +beginning of the line. If END is at the beginning of a line, > >>>> +that line is excluded. Otherwise, if END is not at the > >>>> +end of a line, it is moved to the end of the line." > >>> > >>> This describes the implementation, whereas this is a command, so the > >>> doc string should have users, not programmer's in mind. Try to > >>> describe BEG and END in user-level terms, for example: > >>> > >>> Macro text will start and the beginning of line containing buffer > >>> position BEG. > >>> > >>> Also, the doc string should tell how BEG and END are determined in > >>> interactive invocations. > >>> > >> > >> I have changed it. How does it look now? > > > > See some comments below. > > > >> +@findex edmacro-insert-key > >> +@findex edmacro-set-macro-to-region-lines > >> + The mode provides commands for more easily editing the formatted > > > > You say "The mode", but it is not clear what is "the mode" to which > > you allude. > > > >> +macro. Use @kbd{C-c C-q} (@code{edmacro-insert-key}) to insert the > >> +next key sequence that you type into the buffer using the correct > >> +format, similar to @kbd{C-q} (@code{quoted-insert}). Use @kbd{C-c > >> +C-r} (@code{edmacro-set-macro-to-region-lines}) to replace the macro's > >> +formatted text with the lines overlapping the region of text between > >> +point and mark. > > > > Here, "the lines overlapping the region of text between point and > > mark" is IMO not clear enough. I think you mean to say "text in the > > region", and the "overlapping" part is just to allude to the fact that > > the region might begin and/or end in the middle of a line? If so, I > > would suggest > > > > Use @kbd{C-c C-r} (@code{edmacro-set-macro-to-region-lines}) to > > replace the macro's formatted text with the text in the region. If > > the region begins not and beginning of a line or ends not at end of > > line, it is extended to include complete lines. > > > > Also, is the "formatted" in "macro's formatted text" really needed? > > What does "formatted" signify? > > I wasn't sure what to call the lines of formatted text showing the > macro's contents. I have changed it to just "text". > > >> +(defcustom edmacro-reverse-key-order nil > >> + "Non-nil if `edit-kbd-macro' should show the most recent line of keys first. > > ^^^^ > > "Keys" or "key sequence"? > > I have changed it to "key sequences". > > >> +(defun edmacro-set-macro-to-region-lines (beg end) > >> + "Set the macro text to the lines overlapping the buffer text from BEG to END. > > > > I would suggest > > > > Set macro text to lines of text in current buffer between BEG and END. > > > >> +When called interactively, this command uses the beginning and > >> +end of the selected region as the buffer positions. > > > > Interactively, BEG and END are the beginning and end of the region. > > > > I have changed it to: > > "Set the macro text to lines of text in the buffer between BEG and END. > > Interactively, BEG and END are the beginning and end of the > region. If the region does not begin at the start of a line or > if it does not end at the end of a line, the region is extended > to include complete lines. If the region ends at the beginning > of a line, that final line is excluded." > > I have also added the new command and user option to "NEWS" as requested > by Stefan Kangas, and have described the new user option in the manual. > > I have also changed the name of the user option to > "edmacro-reverse-macro-lines", which is a bit clearer. Thanks, installed on the master branch, and closing the bug. From unknown Thu Jun 19 16:21:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Oct 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator