GNU bug report logs - #65600
[PATCH] Allow parameters AM_PROG_LEX

Previous Next

Package: automake-patches;

Reported by: Bogdan <bogdro_rep <at> gmx.us>

Date: Tue, 29 Aug 2023 18:58:02 UTC

Severity: normal

Tags: patch

Merged with 65730

Done: Karl Berry <karl <at> freefriends.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Karl Berry <karl <at> freefriends.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65600: closed ([PATCH] Allow parameters AM_PROG_LEX)
Date: Wed, 01 Nov 2023 16:24:03 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 1 Nov 2023 10:23:14 -0600
with message-id <202311011623.3A1GNEpO022527 <at> freefriends.org>
and subject line Re: [bug#65730] [PATCH v2] m4: Update invocation of AC_PROG_LEX
has caused the debbugs.gnu.org bug report #65600,
regarding [PATCH] Allow parameters AM_PROG_LEX
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65600: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65600
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Bogdan <bogdro_rep <at> gmx.us>
To: automake-patches <at> gnu.org
Subject: [PATCH] Allow parameters AM_PROG_LEX
Date: Tue, 29 Aug 2023 20:56:18 +0200
[Message part 3 (text/plain, inline)]
Hi.

 In reference to:
https://lists.gnu.org/archive/html/automake/2023-07/msg00007.html.

 The attached patch allows the AM_PROG_LEX macro to accept
parameters, to accommodate for the fact that AC_PROG_LEX now (since
Autoconf 2.70) requires one. The values accepted by AM_PROG_LEX are
passed to AC_PROG_LEX the following way:
- an empty value is passed as empty, resulting in an Autoconf warning
(just like it is now),
- the word 'yywrap' is passed unchanged,
- the word 'noyywrap' is passed unchanged,
- the word 'empty' results in an empty value (and thus an Autoconf
warning)
- any other word results in a syntax warning and an empty value being
passed (resulting in an Autoconf warning).

 Since it's Autoconf 2.70 that started using the parameter, I've
bumped the required value. You may change back if needed.

 My M4 "knowledge" is simply basing on other examples and doing
whatever that doesn't result in an error, so you may change the code
as needed (m4_define, m4_warn, m4_expand).

 Test for the parameters is added. All tests matching *lex*sh pass.
+11-20s to testing time.

--
Regards - Bogdan ('bogdro') D.                 (GNU/Linux & FreeDOS)
X86 assembly (DOS, GNU/Linux):    http://bogdro.evai.pl/index-en.php
Soft(EN): http://bogdro.evai.pl/soft  http://bogdro.evai.pl/soft4asm
www.Xiph.org  www.TorProject.org  www.LibreOffice.org  www.GnuPG.org
[automake-am_prog_lex-params-mail.diff (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Karl Berry <karl <at> freefriends.org>
To: stlman <at> poczta.fm
Cc: 65730 <at> debbugs.gnu.org
Subject: Re: [bug#65730] [PATCH v2] m4: Update invocation of AC_PROG_LEX
Date: Wed, 1 Nov 2023 10:23:14 -0600
    * m4/lex.m4: pass the required argument to AC_PROG_LEX

Ɓukasz, I finally committed your patch for this.
Bogdan, I also committed your test.

Thanks much. Closing these out (#65730, #65600). --karl



This bug report was last modified 1 year and 200 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.