Subject: bug#65590: 29.0.50; esh-var-test/interp-concat-cmd fails on macOS

From: Jim Porter <[email-masked]>
Date: Fri, 1 Sep 2023 09:30:21 -0700

On 9/1/2023 9:03 AM, Stefan Kangas wrote:
> Jim Porter <[email-masked]> writes:
>>
>> On 8/29/2023 5:44 PM, Jim Porter wrote:
>>> Can you try the following patches? They shouldn't change the behavior,
>>> but they do add some extra debugging information to failed tests.
>>
>> To help diagnose some similar EMBA failures, I've pushed these patches
>> to master. Hopefully, we'll get some useful debug info.
> 
> Thanks.  Please see the attached files, with debug logs from these
> test failures:

Hmm, that's not right. Did you do a full recompile of all the Eshell 
code/tests? The errors should look something like this (just an example 
from me forcing a test to fail):

------------------------------------------------------------

Test esh-proc-test/output/to-screen condition:
     Command logs: command: "sh -c 'echo stdout; echo stderr >&2'"

                   ----------------------------------------
                   [process] started external process `sh'
                   ----------------------------------------
                   [process] received output from process `sh'

                   stdout
                   stderr

                   ----------------------------------------
                   [process] sentinel for external process `sh': "finished
                   "
                   ----------------------------------------
                   [process] finished external process `sh'
     (ert-test-failed
      ((should (eshell-match-output regexp)) :form
       (eshell-match-output "[TEST]stdout\nstderr\n") :value nil
       :explanation
       (mismatched-output
        (command "sh -c 'echo stdout; echo stderr >&2'\n")
        (output "stdout\nstderr\n") (regexp "[TEST]stdout\nstderr\n"))))
    FAILED  11/21  esh-proc-test/output/to-screen (0.105507 sec) at 
../../test/lisp/eshell/esh-proc-tests.el:52