GNU bug report logs - #65580
[PATCH] ; * lisp/help-fns.el (help-do-arg-highlight): Fix regexp.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65580: closed ([PATCH] ; * lisp/help-fns.el (help-do-arg-highlight):
 Fix regexp.)
Date: Fri, 01 Sep 2023 18:34:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 1 Sep 2023 20:32:33 +0200
with message-id <CADwFkm=b=CmKt+Xw-HG+k28dkX1TjMMMu+8rEgpS_EO81m2TWQ <at> mail.gmail.com>
and subject line Re: bug#65580: [PATCH] ; * lisp/help-fns.el (help-do-arg-highlight): Fix regexp.
has caused the debbugs.gnu.org bug report #65580,
regarding [PATCH] ; * lisp/help-fns.el (help-do-arg-highlight): Fix regexp.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65580: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65580
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eshel Yaron <me <at> eshelyaron.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; * lisp/help-fns.el (help-do-arg-highlight): Fix regexp.
Date: Mon, 28 Aug 2023 14:02:18 +0200

[Message part 3 (text/plain, inline)]

Tags: patch

Tags: patch

This patch addresses the following existing issue:

In the output of `C-h f with-delayed-message RET`, the word `message` in
the function name is incorrectly highlighted with `help-argument-name`.

This can be seen also with a definition such as:

--8<---------------cut here---------------start------------->8---
(defun foo-bar (baz)
    "Frobnicate BAZ.

\(fn (foo bar))"
  nil)
--8<---------------cut here---------------end--------------->8---

Now `C-h f foo-bar RET` shows both `foo` and `bar` in the function name
with `help-argument-name` (as well as the `foo` and `bar` arguments).

The attached patch tweaks the regular expression that
`help-do-arg-highlight` uses to find argument occurrences such that it
skips the function name.

In GNU Emacs 30.0.50 (build 3, x86_64-apple-darwin22.5.0, NS
 appkit-2299.60 Version 13.4 (Build 22F66)) of 2023-08-27
Repository revision: c122cc831869a9a11f50187c5cf999389b223eee
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2299
System Description:  macOS 13.4

Configured using:
 'configure 'CFLAGS=-g0 -O3' --with-native-compilation --with-json
 --with-imagemagick --with-tree-sitter --enable-link-time-optimization'

[0001-lisp-help-fns.el-help-do-arg-highlight-Fix-regexp.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 65580-done <at> debbugs.gnu.org
Subject: Re: bug#65580: [PATCH] ; * lisp/help-fns.el (help-do-arg-highlight):
 Fix regexp.
Date: Fri, 1 Sep 2023 20:32:33 +0200

Version: 30.1

> This patch addresses the following existing issue:
>
> In the output of `C-h f with-delayed-message RET`, the word `message` in
> the function name is incorrectly highlighted with `help-argument-name`.
>
> This can be seen also with a definition such as:
>
> --8<---------------cut here---------------start------------->8---
> (defun foo-bar (baz)
>     "Frobnicate BAZ.
>
> \(fn (foo bar))"
>   nil)
> --8<---------------cut here---------------end--------------->8---
>
> Now `C-h f foo-bar RET` shows both `foo` and `bar` in the function name
> with `help-argument-name` (as well as the `foo` and `bar` arguments).
>
> The attached patch tweaks the regular expression that
> `help-do-arg-highlight` uses to find argument occurrences such that it
> skips the function name.

Thanks, pushed to master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.