GNU bug report logs - #65580
[PATCH] ; * lisp/help-fns.el (help-do-arg-highlight): Fix regexp.

Previous Next

Full log

Message #10 received at 65580-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 65580-done <at> debbugs.gnu.org
Subject: Re: bug#65580: [PATCH] ; * lisp/help-fns.el (help-do-arg-highlight):
 Fix regexp.
Date: Fri, 1 Sep 2023 20:32:33 +0200

Version: 30.1

> This patch addresses the following existing issue:
>
> In the output of `C-h f with-delayed-message RET`, the word `message` in
> the function name is incorrectly highlighted with `help-argument-name`.
>
> This can be seen also with a definition such as:
>
> --8<---------------cut here---------------start------------->8---
> (defun foo-bar (baz)
>     "Frobnicate BAZ.
>
> \(fn (foo bar))"
>   nil)
> --8<---------------cut here---------------end--------------->8---
>
> Now `C-h f foo-bar RET` shows both `foo` and `bar` in the function name
> with `help-argument-name` (as well as the `foo` and `bar` arguments).
>
> The attached patch tweaks the regular expression that
> `help-do-arg-highlight` uses to find argument occurrences such that it
> skips the function name.

Thanks, pushed to master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.