GNU bug report logs - #65578
Eglot with mouse

Previous Next

Full log

Message #23 received at 65578 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 65578 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#65578: Eglot with mouse
Date: Wed, 30 Aug 2023 19:35:45 +0300

>>> @@ -1637,7 +1637,9 @@ xref-find-definitions-at-mouse
>>> -        (xref-find-definitions identifier)
>>> +        (progn
>>> +          (mouse-set-point event)
>>> +          (xref-find-definitions identifier))
>>>         (user-error "No identifier here"))))
>> The problem with this solution is that when it doesn't find
>> the identifier then it leaves point at the wrong place.
>
> I'm not sure is a big problem, but we could save the original position and
> restore it in case of error too:

Thanks.  I tend to agree with João that your initial version would be
sufficient to leave point at the position of right-clicking.

Then the same change is also needed in xref-find-references-at-mouse
with mouse-set-point before xref-find-references.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.