GNU bug report logs - #65578
Eglot with mouse

Previous Next

Full log

Message #20 received at 65578 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 65578 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#65578: Eglot with mouse
Date: Mon, 28 Aug 2023 18:11:14 +0100

On Mon, Aug 28, 2023 at 6:00 PM Dmitry Gutov <dmitry <at> gutov.dev> wrote:
>
> On 28/08/2023 19:42, Juri Linkov wrote:
> >>> xref-find-definitions-at-mouse uses save-excursion with
> >>> mouse-set-point before calling xref-backend-identifier-at-point.
> >>> But the same save-excursion with mouse-set-point can't be added
> >>> around xref-find-definitions because save-excursion will restore
> >>> the original position after visiting the found identifier.
> >> Could we do that without additional save-excursion?
> >>
> >> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
> >> index 0666b18cba1..0c3e34fe0a5 100644
> >> --- a/lisp/progmodes/xref.el
> >> +++ b/lisp/progmodes/xref.el
> >> @@ -1637,7 +1637,9 @@ xref-find-definitions-at-mouse
> >>              (mouse-set-point event)
> >>              (xref-backend-identifier-at-point (xref-find-backend)))))
> >>       (if identifier
> >> -        (xref-find-definitions identifier)
> >> +        (progn
> >> +          (mouse-set-point event)
> >> +          (xref-find-definitions identifier))
> >>         (user-error "No identifier here"))))
> > The problem with this solution is that when it doesn't find
> > the identifier then it leaves point at the wrong place.
>
> I'm not sure is a big problem, but we could save the original position
> and restore it in case of error too:

Have to agree with Dmitry.  If I click a position to get a xref to
somewhere else, I'm kind of already expecting/hoping that point
moves.  So the fact that, in the error/exception case, it sticks
to the place where I right-clicked is really not so bad.  Personally,
I'd not complicate the implementation beyond what Dmitry proposed
initially.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.