GNU bug report logs - #65556
[PATCH] Added SiriKali

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Cc: 65556 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune <at> gmail.com>, paren <at> disroot.org, Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>, Raghav Gururajan <rg <at> raghavgururajan.name>, jgart <jgart <at> dismail.de>, Mathieu Othacehe <othacehe <at> gnu.org>, Christopher Baines <guix <at> cbaines.net>
Subject: [bug#65556] [PATCH] Added SiriKali
Date: Thu, 19 Oct 2023 22:07:06 +0200

Hi Aaron,

Sorry for the long delay!

Aaron Covrig <aaron.covrig.us <at> ieee.org> skribis:

> Project main page: https://mhogomchungu.github.io/sirikali/
> Project GitHub: https://github.com/mhogomchungu/sirikali
>
> Comment: SiriKali provides a user friendly GUI for managing
> encrypted folders and supports 'cloud friendly' encryption
> such as CryFS, where the encrypted contents are split across
> multiple encrypted blocks. These blocks only update as their
> respective contents are changed, allowing for easier syncing
> across network links by simplifying resumption of interrupted
> transfers and providing smaller units for differential
> transfer deltas.

The comment above should rather complement the ‘description’ field of
the package.

For the commit log, we use a peculiar convention that consists in
describing the changes in terms of files, variables, etc.:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

(One of us can fix it up for you though, if needed.)

> +++ b/gnu/packages/sirikali.scm

Rather than create a new file, I’d suggest putting it in
file-systems.scm.

> +    (build-system cmake-build-system)
> +    (arguments
> +     '(#:tests? #f ;No tests
> +       #:configure-flags '("-DQT5=true" "-DCMAKE_BUILD_TYPE=RELEASE")))

You can remove “-DCMAKE_BUILD_TYPE=RELEASE” (the default is
“RelWithDebInfo”).

Could you send an updated patch?

Thanks in advance,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.