From unknown Thu Jun 19 12:35:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65550 <65550@debbugs.gnu.org> To: bug#65550 <65550@debbugs.gnu.org> Subject: Status: Don't add propagated-inputs for all outputs Reply-To: bug#65550 <65550@debbugs.gnu.org> Date: Thu, 19 Jun 2025 19:35:35 +0000 retitle 65550 Don't add propagated-inputs for all outputs reassign 65550 guix-patches submitter 65550 =E5=AE=8B=E6=96=87=E6=AD=A6 severity 65550 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 26 07:36:33 2023 Received: (at submit) by debbugs.gnu.org; 26 Aug 2023 11:36:33 +0000 Received: from localhost ([127.0.0.1]:41808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZrai-0007S9-NN for submit@debbugs.gnu.org; Sat, 26 Aug 2023 07:36:33 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZrae-0007Ru-Co for submit@debbugs.gnu.org; Sat, 26 Aug 2023 07:36:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZraT-0001sG-E4; Sat, 26 Aug 2023 07:36:17 -0400 Received: from mail.envs.net ([5.199.136.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZraQ-0008AK-5S; Sat, 26 Aug 2023 07:36:17 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 7AAC038A0135; Sat, 26 Aug 2023 11:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1693049762; bh=dWqCtB6ude7otmAza3mZgG2YQdQSabxBvnFsBys4TQI=; h=From:To:Cc:Subject:Date:From; b=gCL7PXy6YS4TaqNPvDuXylH2DX/NfG0BSuQbtp3BembyLYFGbHiDmCcEomXwLgQBa aRAEsHPuOTOExu/EsSRbyuEdS14boTOUXaGRnVtkr/YVFpPIlaDBR0Vq8tmlkZO/Yq +eOlj7nNBlgsRIsDLukG3UeZtfUMsIj9++flgaZc0B1iGXTOwq2nxq4E34MTkXJ9U+ rOs+ighZm014K67Qr3jGbYd027t9kmx1n8Tebws2Vv4A9q0GRKjY2rFobtiFVObxt2 gcQ+LDz6j+P3pkhSpVjVLzT9PSqywFlhZ6LZKtK6YE6spdst51CdsvoYzCC6bUP1Jm I8gcVLoXTl/gSoQ7aGUPW9jJmnnzvAHZhE04jECfOZV1rG547LQMWVxm7F4WrTaby+ fM6A4biB6oqv0EM//LBOjkif4BHRGdfg/N7JRE7EHg9Smlvpf5+yc3aeHB3+WNrLHr 386hfZYT43PRIjHZRFgTTwF2MCWoQVFvUfsUdB/Inl38Y4p24q6ZvjJsJuLt9Idyzr slBXQz/JduTkZaYTK3FCCaUy4PtapPjZtPBp49gWZJLx8U3fyxmehaNAesEGc1WETM Ljt0+S0qCA+hFEpUhNDSCX7S8uKxzpyJBuQ0AAvfX7+140/cl7YSJCuo79saSTc+4K K3eKMh38clzTY+xwcLwJQZSI= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zXFci15z9Pa6; Sat, 26 Aug 2023 11:35:59 +0000 (UTC) Received: from localhost (unknown [36.170.44.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sat, 26 Aug 2023 11:35:58 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 4f4efede; Sat, 26 Aug 2023 11:36:05 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: guix-patches@gnu.org Subject: Don't add propagated-inputs for all outputs Date: Sat, 26 Aug 2023 19:36:05 +0800 Message-ID: <87ttsm828q.fsf@envs.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=5.199.136.28; envelope-from=iyzsong@envs.net; helo=mail.envs.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: guix-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Hello, we have a TODO for "extend `propagated-inputs` with support for multiple outputs". I try to do it for a while, but unable to find a clear way, since add a new syntax for specify output in propagated-inputs require changes in too many places.. Think about the intention, what we want is to avoid unwanted propagated-inputs for building a package or user profiles, and propagated-inputs is mostly used for development packages which requiring headers/libraries from its inputs. It seems I can hardcode the choice here to the "dev" output (if a package have both "dev" and "out", its "out" should considered be an application) or the "out" output (a library/development package). Then the change is straight: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-packages-Don-t-propagate-inputs-for-non-development-.patch >From 98a8666a0cbf33e24efff615243b98144a92c950 Mon Sep 17 00:00:00 2001 Message-ID: <98a8666a0cbf33e24efff615243b98144a92c950.1693047369.git.iyzsong@member.fsf.org> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Date: Sat, 26 Aug 2023 18:27:09 +0800 Subject: [PATCH] packages: Don't propagate inputs for non-development package outputs. * guix/packages.scm (transitive-inputs): Only include propagated inputs from a package for its "dev" output, or its "out" output if the package doesn't have a "dev" one. --- guix/packages.scm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/guix/packages.scm b/guix/packages.scm index ba98bb0fb4..435d55de71 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -1143,7 +1143,13 @@ (define (transitive-inputs inputs) (loop rest result propagated first? seen) (loop rest (cons input result) - (cons (package-propagated-inputs package) propagated) + ;; Only add propagated inputs for PACKAGE:dev, or PACKAGE:out + ;; when PACKAGE doesn't have a "dev" output. + (if (if (member "dev" (package-outputs package)) + (member "dev" outputs) + (or (null? outputs) (member "out" outputs))) + (cons (package-propagated-inputs package) propagated) + propagated) first? (vhash-consq package outputs seen)))) ((input rest ...) base-commit: eeb71d778f149834015858467fbeeb1276d96d1d -- 2.41.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Not much benifits now, but i think it will helps when we have more mulitple outputs packages. Also how about add a slimming team aiming to reduce the closure size of packages and system, anyone interested? Thanks. =F0=9F=A5=B3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 26 09:53:22 2023 Received: (at 65550) by debbugs.gnu.org; 26 Aug 2023 13:53:23 +0000 Received: from localhost ([127.0.0.1]:41885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZtj8-0007lj-Kg for submit@debbugs.gnu.org; Sat, 26 Aug 2023 09:53:22 -0400 Received: from mail.envs.net ([5.199.136.28]:50660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZtj4-0007lX-Ld for 65550@debbugs.gnu.org; Sat, 26 Aug 2023 09:53:21 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 7D4B938A0135; Sat, 26 Aug 2023 13:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1693057991; bh=XwtRDTysApj3vpS2m97cpoNW3cF1epMbR4eHg4BfUgE=; h=From:To:Cc:Subject:Date:From; b=VGmQ+aL897S3pB4ZL7Ebqw6lhi+GEPZdremt55xzUOSdHLNwaYAiR4bADGmY0BP2r XEAfwoMqNdoRiz987NtbQEurRbUfC8+rs71AtPP9HHRNVP/vjC83FHtle4DgtEZkqG HPnq8aFiO9/n3ssXvmEf2u8Ty995UbX1TpX+l7HKQ9H/0/XcJH9pb/QlximXo+jD2j Cy/CnuCCGzwPB9gNUnCbrEWWwQslRR5kRVJuDU7Bh7nGFt1Bfnr02Vvb6rXgeZ1vPH /mO8HQtPFbED1di4RU4+Kn+0WG1GPIzCAWqTDrazLa0j8PH5r8tmAs8zcwgCNxFHuK rcyS2W5mpKAt/vzlrkfzV+RUgPJjrxYdZR+fEkoKmuO74vyh3LdCVEuTAtnwy74UJ+ /+EeV+4ZFCrSrvZT6FYGLOGqpjNyDQhuBwJdkJWHkarHwhbBfQxhvCSpOnTKcVA8E4 9e3V+N7kcCkelyazUZp3dr7trR2cVqLMuJBJdgs0lIbjQCgh6yhZHSvt/YMKiRb+6P D6sVJPVP5LjRjZLk5vJgWi84UEe8eLFv9XA6VOSpdxfhAKUW+ZAqzTBAyMAFfMyaCZ 8wdo797nub6TT8XFems+X7V2UHk5fKl7tUwVd1IaEVAQQVs7dEpLT22lHbVM3kdz3R sSMdIWhPmA7FpnwZehQoczHk= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KCuhsznlm3Mu; Sat, 26 Aug 2023 13:53:07 +0000 (UTC) Received: from localhost (unknown [36.170.44.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sat, 26 Aug 2023 13:53:07 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 864af4ec; Sat, 26 Aug 2023 13:53:25 +0000 (UTC) From: iyzsong@envs.net To: 65550@debbugs.gnu.org Subject: [PATCH] profiles: Don't propagate inputs for non-development packages. Date: Sat, 26 Aug 2023 21:53:09 +0800 Message-ID: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * guix/profiles.scm (package->manifest-entry): Only include propagated inputs from a package for its "dev" output, or its "out" output if the package doesn't have a "dev" one. --- guix/profiles.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/guix/profiles.scm b/guix/profiles.scm index fea766879d..9ed81dec4d 100644 --- a/guix/profiles.scm +++ b/guix/profiles.scm @@ -390,7 +390,14 @@ (define* (package->manifest-entry package #:optional (output "out") ((label package output) (package->manifest-entry package output #:parent (delay entry)))) - (package-propagated-inputs package))) + ;; Only add propagated inputs for PACKAGE:dev, or + ;; PACKAGE:out when PACKAGE doesn't have a "dev" + ;; output. + (if (if (member "dev" (package-outputs package)) + (equal? "dev" output) + (equal? "out" output)) + (package-propagated-inputs package) + '()))) (entry (manifest-entry (name (package-name package)) (version (package-version package)) base-commit: 98a8666a0cbf33e24efff615243b98144a92c950 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 26 10:21:52 2023 Received: (at 65550) by debbugs.gnu.org; 26 Aug 2023 14:21:52 +0000 Received: from localhost ([127.0.0.1]:43269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZuAi-0000MP-2Z for submit@debbugs.gnu.org; Sat, 26 Aug 2023 10:21:52 -0400 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:61543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZuAe-0000M9-K0 for 65550@debbugs.gnu.org; Sat, 26 Aug 2023 10:21:50 -0400 Received: by mail-ed1-x541.google.com with SMTP id 4fb4d7f45d1cf-523100882f2so2516817a12.2 for <65550@debbugs.gnu.org>; Sat, 26 Aug 2023 07:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693059697; x=1693664497; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=rlqPJime3HsddgAFm9geFxapRkdUARms8KrkUIfopag=; b=NnG+R/wanp/hXuc5tPTHkYTFdoDYFFj/z2rK8sAEMIxkGRr5cDLOr8uLL+NVMXn/5i 0IpnVByhcYtcREeNTScCbldl81KWHxZFfEb/ev5t8n7OZA3O3LFj3HlC1365iZ8N+bs7 zQ43k6heCcLhvNNQMB2lz9c29Itz+INBVjjNf5QKfZH0u1O7wDDr5/TFIZvzxdGu6Vp2 GQA8PS/Abs0Eb6RRwpuZOoV3Ulj48oMGmdlXR28/rfRG/7Wojw28XqiQFRZSIpg3pB3L wNj+e3yX+qaSp2zOIJM4SV2U8c9RJvrQomBQMjXWK4y5UCdCK68BqXqw8K3Sq95EvxtD JJww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693059697; x=1693664497; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rlqPJime3HsddgAFm9geFxapRkdUARms8KrkUIfopag=; b=Uo2QfPDPRCjB6JM+dWEi8G2h6Ul/Gj32wAgWu6+eO6UwRPHFRMeWOyTcXRvS7UrbET 5HybqLyODpXGGCunF8eQDBGdEEQmfXsRxDSR+6cGY/J8In3rPHYGw7o1ttEu22Mi8s/5 /9KYyk/iXif1A3nKpcymlgu94XSABIEIQPtoJsE7GqkOEzEds52cOp+xnpIVLMq53O+y hKPyLfKf1t0D3JH8n02xYiigH7r7Yvvpmz9agh2o4qnbxNV8ivRdiET9NbHRJDtQK0w6 0P7V8y1wUM+HXYeouL6tcEM6eXiYxta6v5r7KyfvQQiH8awNzjPkSIj+YKe+vP+YYv4N Yi1A== X-Gm-Message-State: AOJu0YxAYkoIWcl6l2v27B9wWm0hDsd40nG1B7+FjyuHdi6qpnOVQpAS FEVWtI1Q/UEhUGTIqOqDnIJGwCx5PcqGJg== X-Google-Smtp-Source: AGHT+IGOePRg5JKXD/Fy8NFAHvNuDaaeAQsxuuJXmWbKDGMMimdKFjs+LzbaV94RejLwXwDTvfJRSA== X-Received: by 2002:aa7:cb4d:0:b0:527:251e:1be8 with SMTP id w13-20020aa7cb4d000000b00527251e1be8mr16064040edt.13.1693059697389; Sat, 26 Aug 2023 07:21:37 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id p8-20020aa7d308000000b005288f0e547esm2215223edq.55.2023.08.26.07.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Aug 2023 07:21:36 -0700 (PDT) Message-ID: <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> Subject: Re: [PATCH] profiles: Don't propagate inputs for non-development packages. From: Liliana Marie Prikler To: iyzsong@envs.net, 65550@debbugs.gnu.org Date: Sat, 26 Aug 2023 16:21:34 +0200 In-Reply-To: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Samstag, dem 26.08.2023 um 21:53 +0800 schrieb iyzsong@envs.net: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 >=20 > * guix/profiles.scm (package->manifest-entry): Only include > propagated inputs from a package for its "dev" output, or its "out" > output if the package doesn't have a "dev" one. > --- I think this patch misses the most obvious use case of the out:lib split. I also think that hardcoding this list is bound to fail. Instead, we could for the time being solve this with yet another package property. '((propagate-inputs-from "lib")) ; but not out '((propagate-inputs-from . ("lib"))) ; same meaning, different style '((propagate-inputs-from "out" "lib")) ; but not doc If the property is missing, we still propagate from all outputs, as is currently done. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 03:30:02 2023 Received: (at 65550) by debbugs.gnu.org; 27 Aug 2023 07:30:03 +0000 Received: from localhost ([127.0.0.1]:43976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaADh-0007rx-UZ for submit@debbugs.gnu.org; Sun, 27 Aug 2023 03:30:02 -0400 Received: from mail.envs.net ([5.199.136.28]:55002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaADe-0007rT-Rt for 65550@debbugs.gnu.org; Sun, 27 Aug 2023 03:30:00 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id D70F138A0135; Sun, 27 Aug 2023 07:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1693121390; bh=SZ57JiwzrZvomWc8pkEbtwv/9NtSufgtCGzQiRyEU24=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aIck9dph8qwtgqUaV4irE+CskZqFZmpbO+zcXkmzTrnHbG1qYlraPN2WBvE/4/1dA dFJaEx7RAFfzhFyNJYo3El24398dbedNz7tAo+r/joHxDvhxuFkdF8AKuccz+OwU0z 5sUSMuqg5qUSDq4SfjMxixJ3rw2PX+CRIYTGXt5qld9+m04d2HZVURpA+c4d2GKlM4 aswqiqsyassOEC+3LhOzboQ1lfszs1hglOtYm+DJwatTdGfqxuQWg7dvIYlCBGddUV d1RJnJYQ0VTg/B1bupnXoGEpmxtCKYiv02JYvLhhjKjrpvFldV0n37wuOU9un5nfiM rl3K05wx9hgjeb2839aRHppJ828NG018XCbEflV6PDEs+2YLmTQ6NXPUl8EqXv5Wh7 5ha2ARSp9gd6kPswoXWnB+Nv4q0hvTkCt1MGWnRhM2HH55LfSCyxKAAt/87ocWVg4F d0FnKKiGW8EMWNv8SpcpIoclgOyX2O1kfDSdbHl7o2eOhJ+dUFts5PlPKT/zvFJPd7 BBJxgs1hHfD0yGw8FrHQCLS9NNhuEIox6cUv4hc0OMQpvQ3UUvFTEBC1NPMVUZnMlH efY6Gi4iVdWuGAqDB+5j3V2zhL34G7gwa3ULu9Kl/wgeLmU0j5W4XYaAaOxQPse1ic ALREff0ieOA9owNoY0boLY8A= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NTFL6EhsNUnK; Sun, 27 Aug 2023 07:29:45 +0000 (UTC) Received: from localhost (unknown [36.170.44.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 27 Aug 2023 07:29:45 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 789c694a; Sun, 27 Aug 2023 07:30:05 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Liliana Marie Prikler Subject: Re: [PATCH] profiles: Don't propagate inputs for non-development packages. References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> Date: Sun, 27 Aug 2023 15:30:05 +0800 In-Reply-To: <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 26 Aug 2023 16:21:34 +0200") Message-ID: <87edjpaqo2.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Liliana Marie Prikler writes: > Am Samstag, dem 26.08.2023 um 21:53 +0800 schrieb iyzsong@envs.net: >> From: =E5=AE=8B=E6=96=87=E6=AD=A6 >>=20 >> * guix/profiles.scm (package->manifest-entry): Only include >> propagated inputs from a package for its "dev" output, or its "out" >> output if the package doesn't have a "dev" one. >> --- > I think this patch misses the most obvious use case of the out:lib > split. I also think that hardcoding this list is bound to fail. Ah, that's true. We currently put both headers and pkgconfig files in the "lib" output, I think we should put those files into "dev" instead, only leave shared libraries in "lib" (then we don't need propagated it anymore). And I did a test to find packages with "lib" and propagated-inputs: --8<---------------cut here---------------start------------->8--- (use-modules (gnu packages) (guix packages) (srfi srfi-1) (ice-9 pretty-print)) (define x (delete-duplicates (fold-packages (lambda (package result) (if (and (member "lib" (package-outputs package)) (not (null? (package-propagated-inputs package)))) (cons (package-name package) result) result)) '()))) (pretty-print x) --8<---------------cut here---------------end--------------->8--- Only hwloc and apache-arrow, and 24 packages (uniqued by name) have a "lib" output, seems doable. > Instead, we could for the time being solve this with yet another > package property. > '((propagate-inputs-from "lib")) ; but not out > '((propagate-inputs-from . ("lib"))) ; same meaning, different style > '((propagate-inputs-from "out" "lib")) ; but not doc > If the property is missing, we still propagate from all outputs, as is > currently done. > > WDYT? Yes, a property is more flexible here, haven't think about it. Well I wishful think if we always follow a good convention (put development files in "dev" or "out"), then maybe we can saving some bytes in code? I'd like to split more packages with multiple outputs with "dev" to see how the convention works out. If not then we could take this 'property' way. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 03:34:52 2023 Received: (at 65550) by debbugs.gnu.org; 27 Aug 2023 07:34:53 +0000 Received: from localhost ([127.0.0.1]:43988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaAIO-0002Bf-L9 for submit@debbugs.gnu.org; Sun, 27 Aug 2023 03:34:52 -0400 Received: from jpoiret.xyz ([206.189.101.64]:35570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaAIN-0002BX-3T for 65550@debbugs.gnu.org; Sun, 27 Aug 2023 03:34:51 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 5BD70184B88; Sun, 27 Aug 2023 07:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1693121684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QgSm6w5I0DZITGHaFL+si4hg4JDmTYeufXtUV6siT2s=; b=h8SeXjk8gCb8us2j6oN5AF+214FX3bWkzZStin7e2yeJGKRjxPD2V99NMOtrBxMkJyd5T+ LlWxfTgUQaCgJw4H4gHB3K+Dz9eqOPVamMbNa2w5OVmuXOIj03l5B43R/eGrqd5pcDd5+u Yr4upJl0utjcWWdoPboLIw5rEORoFyJR9uMZvB2Xi1FgkyT9Tla1tVUBrMNaqKG3BMms5s jFFNIATXbL8NbZi89vBTbc8a+6AFs9+R3mEV+FvUhOlaBuI3tP6ZWaGgrOFqN4gnj/mRb6 1vCwQizXn4FUmahj4LCCScVY5nwn4/kD6Bqo6mceLOz/BY3kCbiXwjSBOfjeJg== From: Josselin Poiret To: Liliana Marie Prikler , iyzsong@envs.net, 65550@debbugs.gnu.org Subject: Re: [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages. In-Reply-To: <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> Date: Sun, 27 Aug 2023 09:34:36 +0200 Message-ID: <87edjp546r.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Level: * X-Spamd-Bar: + Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: =?utf-8?B?5a6L5paH5q2m?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi everyone, Liliana Marie Prikler writes: > I think this patch misses the most obvious use case of the out:lib > split. I also think that hardcoding this list is bound to fail. > > Instead, we could for the time being solve this with yet another > package property. > '((propagate-inputs-from "lib")) ; but not out > '((propagate-inputs-from . ("lib"))) ; same meaning, different style > '((propagate-inputs-from "out" "lib")) ; but not doc > If the property is missing, we still propagate from all outputs, as is > currently done. > > WDYT? I don't really like the hackiness of this (yet another weird thing for independent contributors to learn), but I also understand the need. This one LGTM, but maybe we should think a bit more about simpler solutions before committing to this. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmTq/IwQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5Fhcaigk4DACTjnep95n94z6NvwqpwE1qUnSppWFpcu4p xD0jb5UVB+9voHTNCkLtkCYy5pdgi0Ua+pZgjS+aGEGZ/Cffmk4SsQhAzKD/r4/u UTaidht6FAgP/SPTbDKZXfMa2iJnQkuNmtq89bpSOQD6rfyjLr+otPDOpoeEAqzq LLI+Lzz/TK3J/3/fVAEAlPLztgPvKgFKa4+nFgOwKHSon8hDYDpC9id95fJt7Fcm MIf0oTJtYXhYYtC5aQGRB3Ht5aqI7Ru414Hgm2L3pyJ8TVBM+inUE+kI2geTQru3 4oy7zc2t85xh/vS82VbirCdARBmURwQ0C3cHH6OF5mqyBQyLMoQ5n5YKGH6RSxvW M/yEfLhnkj93Zcw50kXEeRTKE0NXk2VUFLxMiZLunXbB9vnh/YvKLiwzMFA8Qleb 5ognJnNFY5PlBBcNjCc/+fwDpHgxCZ9mS4Uuaz1f0xhc1mHGlOe2r6S133+oK0zs GADdmOM90yY4a6+rLjW7hQOxLZosmYQ= =SMWB -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 05:31:52 2023 Received: (at 65550) by debbugs.gnu.org; 27 Aug 2023 09:31:52 +0000 Received: from localhost ([127.0.0.1]:44166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaC7c-0005J4-G1 for submit@debbugs.gnu.org; Sun, 27 Aug 2023 05:31:52 -0400 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:48313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaC7X-0005Io-9i for 65550@debbugs.gnu.org; Sun, 27 Aug 2023 05:31:51 -0400 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-9a2185bd83cso286179166b.0 for <65550@debbugs.gnu.org>; Sun, 27 Aug 2023 02:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693128696; x=1693733496; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=L2Y7ejuGZFXVygkKN/EShBrdXy+SIPljAnWh1NQ54S0=; b=mmybe2ZUwvUsEWR2RKra2rovQH/0mhl5zo1XEpoFokB1fwUo9HSlenFPbjBqD2gJex 18aVUjztsDai+/mif26C1veTo42cb70qOaxeQxXdmRqEuqN/A4sEVUfxEp9dIQ8hbUSw P9oD1Zxjlnhh+cCWWHfF+OEh0CFJwDkzLxCp3B7SBothHNjq+TRr1RDnZjgqmMc2ik6a WMyJAEckxrFTEu5a2afbnVrUjvZgTGtxaFgtXloer/ChjYHOXuAH5HPo5ybHo7qPFQKG C6kHLDQUe96rIZIUY+zp0al/YALacFlsvoOTq/ciyNB/PIBqnNItQEPnAIh/bSCBWOFW 3PFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693128696; x=1693733496; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=L2Y7ejuGZFXVygkKN/EShBrdXy+SIPljAnWh1NQ54S0=; b=UGv5xLddNLjWftK+C394cixmGLKC5KdGtn/D1yn+eg7jBuvxhPLAaC6rvTkdwrEiJZ BlwQjGWoERdsa6tVb/7PUL9VbNhFjMd/8S9cAYJNS65KpsSJ2kYWCb2A/Q8NWp0F3cTK FUYK68xcTW4qsngaDq7LQnS8UFvgTcmuPewmJ48LMwCJe13PO3nN3UKZ2tDPAo7AQfUg 8CeX7i48z3BVSrAO7do0JKNYc6puJdfEuQqB/DY0EFazlvyW5AHt4Wt33UGPPKL34dJd vbPnrwx4P5XzMe49AvtaJ3ZHvJTnHWo+p6ivoA7cViiOxcEnS/6akVyTZj6kweZr4zTy S/XQ== X-Gm-Message-State: AOJu0YwzbS+ytmUcPvPyEtY6JPpS0Sdq++HWb/RznnbgyTHJFre03AQT At1MsyRXMnARXEGCOYsktIg= X-Google-Smtp-Source: AGHT+IEtp9feNtCjA25/FnATkjHbcwH2m8nSERtB7O/ed32ajIFUVktMjtxiePsY5Fpdz5REYUJUwg== X-Received: by 2002:a17:906:2243:b0:9a1:8a39:c62d with SMTP id 3-20020a170906224300b009a18a39c62dmr16003834ejr.38.1693128695543; Sun, 27 Aug 2023 02:31:35 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id jx13-20020a170906ca4d00b00992d122af63sm3231865ejb.89.2023.08.27.02.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 02:31:34 -0700 (PDT) Message-ID: <81f39ef4b6e0ec4de7b55446c755fb0dec621c49.camel@gmail.com> Subject: Re: [PATCH] profiles: Don't propagate inputs for non-development packages. From: Liliana Marie Prikler To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Date: Sun, 27 Aug 2023 11:31:33 +0200 In-Reply-To: <87edjpaqo2.fsf@envs.net> References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> <87edjpaqo2.fsf@envs.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 27.08.2023 um 15:30 +0800 schrieb =E5=AE=8B=E6=96=87=E6=AD= =A6: > > Instead, we could for the time being solve this with yet another > > package property. > > =C2=A0 '((propagate-inputs-from "lib")) ; but not out > > =C2=A0 '((propagate-inputs-from . ("lib"))) ; same meaning, different > > style > > =C2=A0 '((propagate-inputs-from "out" "lib")) ; but not doc > > If the property is missing, we still propagate from all outputs, as > > is currently done. > >=20 > > WDYT? >=20 > Yes, a property is more flexible here, haven't think about it.=C2=A0 Well > I wishful think if we always follow a good convention (put > development files in "dev" or "out"), then maybe we can saving some > bytes in code? I'd like to split more packages with multiple outputs > with "dev" to see how the convention works out.=C2=A0 If not then we coul= d > take this 'property' way. I'd really like to avoid yet another special output, when "bin", "lib", etc. have already been given clear meanings, one of which strongly overlaps with "stuff that wants propagated inputs for pkg-config reasons". The only package that currently has a "dev" output is mariadb, and it's quite an odd one, as "dev" has been introduced to reduce closure size, not to propagate even more. I don't think that hardcoding output names works given this precedent. At the very least, "dev" is the wrong choice. Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 06:24:35 2023 Received: (at 65550) by debbugs.gnu.org; 29 Aug 2023 10:24:35 +0000 Received: from localhost ([127.0.0.1]:49578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qavtj-00081x-63 for submit@debbugs.gnu.org; Tue, 29 Aug 2023 06:24:35 -0400 Received: from mail.envs.net ([5.199.136.28]:46294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qavtf-00081k-RT for 65550@debbugs.gnu.org; Tue, 29 Aug 2023 06:24:33 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 5B1C538A013B; Tue, 29 Aug 2023 10:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1693304662; bh=VQE6TdDTHYIfiahs9fNLU3IsApLCLkYUMgjuawn9u7s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S9aXUPcNqPaGoAhZmQAR1iK1TElvQAQ2nSYfcw31KxMFN1UtPEvsMTKoIDtkYbePQ GPrAb7IFrGr7nJ/4FXkhMjON8xhooenDA4tXBTr0BNayWGshCq/snKsl4yUIQRESuL U8w6OktGZe6iWzUTolET8obS1aUtU1dVnOtmYcMpAVeoG48VBz4hWH8sKwSfbxgWNX hmm75uR+OBAW8bLrmyCeL23y/bmUXhFPhdksYSzhAq3VengRxFH10w3tgDSsEj6YVj ZZienJqf0g1J30ubcxcl5nqEPtFwjY1sROcl3OMqOK4xx2y9rbG43Tat59e4ctdZzS BpSWwpTW7IIcr5dCLz10rWwZQldfTXbJ1xrqkqsJQ+Ui08VoOz6InKhWc1J2jkeOUr SS9Ys62bSZRPrEtK7b0GFZRHO3TKh1KEK0SufaHP8K/551BJD4At1DM+BV/i0siXMC bFLNmBQ/RkfF2MsdzKlRtQYRWxIuhJf0Huk5zS8ETdU/dhfjH4D7OWZvbg/OsLGFB8 PhSNMR57ESWHG3QkT3lkne75QLMcoiCOKHq6i5l3i19OuFSpf2W2qfAd1IvVy2BT5N ea9LfsMjxPhTl6bnFQIT4SywJZefp7VIDJFsULrOCutlKcaMPQiXKo/2U8lAIRZxof Pfi12nZgk6NppSVxKS833u0g= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id wEpFYCAjrZZu; Tue, 29 Aug 2023 10:24:17 +0000 (UTC) Received: from localhost (unknown [36.170.44.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Tue, 29 Aug 2023 10:24:16 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id c118336c; Tue, 29 Aug 2023 10:24:32 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Liliana Marie Prikler Subject: Re: [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages. References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> <87edjpaqo2.fsf@envs.net> <81f39ef4b6e0ec4de7b55446c755fb0dec621c49.camel@gmail.com> Date: Tue, 29 Aug 2023 18:24:31 +0800 In-Reply-To: <81f39ef4b6e0ec4de7b55446c755fb0dec621c49.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 27 Aug 2023 11:31:33 +0200") Message-ID: <877cpedu3k.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Liliana Marie Prikler writes: > I'd really like to avoid yet another special output, when "bin", "lib", > etc. have already been given clear meanings, one of which strongly > overlaps with "stuff that wants propagated inputs for pkg-config > reasons". The benefit to put headers files and libraries files into seperated outputs is to reduce the runtime closure size of packages, for example my home profile contains xfce, emacs, fonts, etc. has total 5GiB (by guix size), and they have 300MiB under include. calculated by: --8<---------------cut here---------------start------------->8--- x=/gnu/store/0fyhci5kv03rfb9430jqs9wki2ifq5ja-profile guix size $x for i in `guix size $x`; do [ -e $i/include ] && du -sb $i/include; done | awk '{ sum += $1 } END { print sum / 1024 / 1024 }' --8<---------------cut here---------------end--------------->8--- If put headers and other development files into a "dev" output, then those 300MiB can be saved (won't need to be substituted if substitutes available). Note that use a "include" output won't help here if you leave pkg-config files in "lib", since pkg-config files need reference its include and binaries need reference its libraries. So it seems to me a "dev" output is unavoidable, also both Debian and Alpine Linux use '-dev' packages for the same reason, it should be familiar to learn.. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 13:02:06 2023 Received: (at 65550) by debbugs.gnu.org; 29 Aug 2023 17:02:06 +0000 Received: from localhost ([127.0.0.1]:51459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb26Q-0007dW-54 for submit@debbugs.gnu.org; Tue, 29 Aug 2023 13:02:06 -0400 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:52510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb26K-0007cy-Kd for 65550@debbugs.gnu.org; Tue, 29 Aug 2023 13:02:04 -0400 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2bcc187e0b5so71160371fa.1 for <65550@debbugs.gnu.org>; Tue, 29 Aug 2023 10:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693328508; x=1693933308; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=+oRllfCjHLE0NvlHhEneXMQa/hC8g6uKxmImaP4Yel0=; b=XQcOZq188/y+Uk/pyg1iU5Az0NQ/xyT811wxa37vATV0AvI894jETF2EBjIdUEFNsF PUmtnGV+TS46wcjsCeNsgRbBzl6XB5FTEDt9rOdVB9ukQnpBIlzr/iSkMCry/xABMTs/ dGypyXobFUDzfOnkcCLEMEdTqPLwrttKuiNss2ZBy+W+hEYpCS+d/HycDn2sbIcyKlEY zsnbzNiU7QKfnm2pXCjwMqd4jYoCCg4LLLWoCM9jVMGP03RlPPXephM2qm0dkeW6DfKI gDPF8cfrcNajFHpnN7fbUrURXXAnbqERgjGM3+Tdgpm5c0yiXkcXSjU8aEZhHDIv5b6w kkXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693328508; x=1693933308; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+oRllfCjHLE0NvlHhEneXMQa/hC8g6uKxmImaP4Yel0=; b=T3QBDY03111jiGt4eANwaYnjIylNVnLpg4/5/KVaiyLhPlXm5Ii4mfNrsW3Mo2JO3k m/lSYp7InHJBnivWvO0ZiOehYchBTQcP4abxbwZZfMcfvm3bTow751ypQi06v+2H8MqQ w/RWatvy7xkvy3jAl7ZGfBKWHooOkRgEhEIbSCblV4HK3CyIBTHf4IRsPIj/9oCjhGg9 iF9X1qdVf00Gtxbr+OzQ/EtoRpiZsx9p8jvKJG+UBOKOO2ACAk4B7BorratkpNfDAnUP MWJFz477Pe+TG8vA8X/n0STnjc1zLD8LbJhxbugt7FfRacgUELUoUdM2tw4YBf/K+IWp eu3w== X-Gm-Message-State: AOJu0YyChZTZivfb0a9/YpDgD9jgF6xUosi2ItSGlmK21RYCLP9KZHIQ aQD8oMh6wWI44DzZys5KbMw= X-Google-Smtp-Source: AGHT+IHZXFMT+hHmeFXd44KM6gkl9l45b56GvLLZiktIHvoU/cpK4UuhGG9sHrrJr/a4Rei5K+IVVA== X-Received: by 2002:a2e:994b:0:b0:2bc:de11:453b with SMTP id r11-20020a2e994b000000b002bcde11453bmr12673678ljj.1.1693328507347; Tue, 29 Aug 2023 10:01:47 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id k6-20020a17090646c600b009a168ab6ee2sm6083284ejs.164.2023.08.29.10.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 10:01:45 -0700 (PDT) Message-ID: Subject: Re: [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages. From: Liliana Marie Prikler To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Date: Tue, 29 Aug 2023 19:01:44 +0200 In-Reply-To: <877cpedu3k.fsf@envs.net> References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> <87edjpaqo2.fsf@envs.net> <81f39ef4b6e0ec4de7b55446c755fb0dec621c49.camel@gmail.com> <877cpedu3k.fsf@envs.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 29.08.2023 um 18:24 +0800 schrieb =E5=AE=8B=E6=96=87=E6=AD= =A6: > Liliana Marie Prikler writes: >=20 > > I'd really like to avoid yet another special output, when "bin", > > "lib", etc. have already been given clear meanings, one of which > > strongly overlaps with "stuff that wants propagated inputs for pkg- > > config reasons". >=20 > The benefit to put headers files and libraries files into seperated > outputs is to reduce the runtime closure size of packages, for > example my home profile contains xfce, emacs, fonts, etc. has total > 5GiB (by guix size), and they have 300MiB under include. >=20 > calculated by: > --8<---------------cut here---------------start------------->8--- > x=3D/gnu/store/0fyhci5kv03rfb9430jqs9wki2ifq5ja-profile > guix size $x > for i in `guix size $x`; > =C2=A0 do [ -e $i/include ] && du -sb $i/include; > done | awk '{ sum +=3D $1 } END { print sum / 1024 / 1024 }' > --8<---------------cut here---------------end--------------->8--- >=20 > If put headers and other development files into a "dev" output, then > those 300MiB can be saved (won't need to be substituted if > substitutes available).=C2=A0 Note that use a "include" output won't help > here if you leave pkg-config files in "lib", since pkg-config files > need reference its include and binaries need reference its libraries. >=20 > So it seems to me a "dev" output is unavoidable, also both Debian and > Alpine Linux use '-dev' packages for the same reason, it should be > familiar to learn.. There is little point in a dev package when you blow up its size by propagating inputs=E2=80=A6 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 30 06:55:16 2023 Received: (at 65550) by debbugs.gnu.org; 30 Aug 2023 10:55:16 +0000 Received: from localhost ([127.0.0.1]:52207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbIqx-00045N-VB for submit@debbugs.gnu.org; Wed, 30 Aug 2023 06:55:16 -0400 Received: from mail.envs.net ([5.199.136.28]:58644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbIqs-000455-DU for 65550@debbugs.gnu.org; Wed, 30 Aug 2023 06:55:14 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 88BBE38A0143; Wed, 30 Aug 2023 10:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1693392900; bh=cfl97LlQzP0D0TigVHSpFtzdnQTB3IuobxLxeRvkBZE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EXoUsEQJGF4xwpxrZDCgUALrLZzNnqplTXk1389+2pHx4417oYG9iemPjIiZ2IuR6 Dzk0nmN4XNRquSZ8N4mrWKGLJ6tzymh+N8x0/ai0C1mqnmtTst/ta33c6hPSbK507f 683VzU4QzXN3VOTlLvd2r2khGYjQGASiub3/XWEKha4YXb3POKxjyK/YgJWoKF6QgC 8oGk/V6Qs2l0h2wbFNPEmZoR/hjfHANacmMx0E7L37YzefNPp2/+mwEjiNwugmE6x9 eJ/K0EIZzfExkj1wx8lL+PNPyQrk9qQGu6VgjIUlwWgFOLbPcQ+M2JxvNNmuTxO62y dgbrpoB4iYcxmayccNvlAyx6EvgIsPE8rYP7PGxjJaJ0u2T1ArRAmAqUodV3bLUA96 TqBgh9utHTklp6ZCtjU1DW0/ClfI2Jj7VWCn98iRFlTKLcqO41dsts3eYvIbxyFXeG LBvtQD8X3gb0u2G4b/zLwPIMvOmKkTJ7FmznAbe11Osh2++dnS/5MBdGLxZAy4/wKD +0UoqRy9H4sYZV60/lNgCep9jC3BFeFJ/IUr+6wvbqBJqhzstIAfD24AguGlwhNvk1 wmuXAcJ4EahSOIF7uzbfPC+M5XVxnP/Iy3QuiAgt8jkIvFOujw/tRHrgLAPbX0yXtr RhsuPL6s0/sTIVyWPHw41zHE= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NV4Z7p7zn2Im; Wed, 30 Aug 2023 10:54:55 +0000 (UTC) Received: from localhost (unknown [36.170.58.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Wed, 30 Aug 2023 10:54:55 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id f40e8eac; Wed, 30 Aug 2023 10:55:20 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Liliana Marie Prikler Subject: Re: [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages. References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> <87edjpaqo2.fsf@envs.net> <81f39ef4b6e0ec4de7b55446c755fb0dec621c49.camel@gmail.com> <877cpedu3k.fsf@envs.net> Date: Wed, 30 Aug 2023 18:55:20 +0800 In-Reply-To: (Liliana Marie Prikler's message of "Tue, 29 Aug 2023 19:01:44 +0200") Message-ID: <87a5u8vlyf.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Liliana Marie Prikler writes: > Am Dienstag, dem 29.08.2023 um 18:24 +0800 schrieb =E5=AE=8B=E6=96=87=E6= =AD=A6: >> [...] >> If put headers and other development files into a "dev" output, then >> those 300MiB can be saved (won't need to be substituted if >> substitutes available).=C2=A0 Note that use a "include" output won't help >> here if you leave pkg-config files in "lib", since pkg-config files >> need reference its include and binaries need reference its libraries. >>=20 >> So it seems to me a "dev" output is unavoidable, also both Debian and >> Alpine Linux use '-dev' packages for the same reason, it should be >> familiar to learn.. > There is little point in a dev package when you blow up its size by > propagating inputs=E2=80=A6 Well propagated-inputs won't increase size of a package, they bring some of its inputs when build other one to remove the need to list those some inputs as inputs of the other one. Consider gtk+ and mousepad: gtk+ propagated cairo, freetype, pango, etc. =20=20 so I don't need add those inputs to mousepad, and if gtk+ doesn't propagated them then I must add them to mousepad because those are actually needed (because pkg-config check them and need link flags from those dependencies of gtk+). But for runtime, when substitute of mousepad is available, if we split thoes packages with "dev" outputs, guix size mousepad would still be something like: ... /gnu/store/xxxx-mesa-23.1.4 /gnu/store/xxxx-freetype-2.13.0 /gnu/store/xxxx-gtk+-3.24.37 ... It won't include any "dev" output of its dependencies packages, since development files are not referenced by mousepad's binary, so the size of headers and development files is saved (won't be substituted). Only when substitute of mousepad is not available, you'll start by download mesa-23.1.4-dev, gtk+3.24.37-dev, etc. And after build, those "dev" outputs can be GCed immediately. Hope it's clear now! From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 22:16:43 2023 Received: (at 65550) by debbugs.gnu.org; 1 Sep 2023 02:16:43 +0000 Received: from localhost ([127.0.0.1]:59534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbtiF-0002qF-3x for submit@debbugs.gnu.org; Thu, 31 Aug 2023 22:16:43 -0400 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:44183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbtiD-0002q0-En for 65550@debbugs.gnu.org; Thu, 31 Aug 2023 22:16:42 -0400 Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-41214998fc2so8885881cf.0 for <65550@debbugs.gnu.org>; Thu, 31 Aug 2023 19:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693534587; x=1694139387; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=n1JAMr6wvc/9w6qAVo1MMqK8HBUrjaGyuUiTFrJG8xY=; b=UaRjhD9EWUOVq/mdtMnLc9DHclQMl99bVy3ZY6tDWi4lEy//j2QN9+SO1TQV1Q6yr1 0DuonowbJYVGz+VXUGVW8dZvI/r494E2zWMQk5A4f+fPqOu31G6+obn4FVV5pzO6oAT4 egxFOD8LEAc92O2/G8PREeBTKwHBRR7W+NEHLMcruBPW8xDZAdYNKkBmpXa/T266WnM7 cw35VCCxOu2lncHwRWanSvLnxQ8lm0hYmqTBSOg6n9a4W5t/MoNcx1DwhI9Ug1WoEESS Kv4bsGYgC32WiNVHVGelpNWX3LHlPLIJMvnw9nCkWg3E5QlK101zgQ9ctv5/lLNtogw3 /qSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693534587; x=1694139387; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=n1JAMr6wvc/9w6qAVo1MMqK8HBUrjaGyuUiTFrJG8xY=; b=DOyTDW5Aqq4FNAmbawIl4oT0zf4QrxQPyqB3iU5Nb60f0NEBfTXLrDkRPISrzaZ6lj V4S5sr66piO1wCfY10DqFEayCWYqxp6lb9BvTUr39Eqd6Z38nZmtVoEhOfKKp50zAZj3 7sX0PJGXEXYH5RQXiSwSWMEp3/YWRUH8BhyAoDH0uu2ztmJnYvR6ll4O8TAIuUzGqe/z R37NmXNGzJhFaEGcarrqw0yEGIRn+24cekz+3rAdsKgiXE8xKmpLvhk6hj08mNrsgyfj UOFr+bQc+h0IWWvRV6uqqHNBHP/UxU59Zd6SS7zja4+mM/lqGC9aMin9QQhycTMgD0T0 UTzw== X-Gm-Message-State: AOJu0Yx7gDy37IfQ2oQuNUauQQ27uJ7XH4CtGaS80rcRd5516S6M0X/g 9fyA61zx9UHlJwboobrvko0= X-Google-Smtp-Source: AGHT+IHMDgP9TN6Lzxo/XVMBAUcBRSdSq3sIRcltUho7W94E/Z3FLV99Jp9A7d8dw5m/aXAbHawHeg== X-Received: by 2002:ac8:5b4e:0:b0:412:1ba6:32af with SMTP id n14-20020ac85b4e000000b004121ba632afmr1120791qtw.19.1693534586935; Thu, 31 Aug 2023 19:16:26 -0700 (PDT) Received: from hurd (dsl-10-128-23.b2b2c.ca. [72.10.128.23]) by smtp.gmail.com with ESMTPSA id br17-20020a05622a1e1100b00403cce833eesm1087461qtb.27.2023.08.31.19.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 19:16:26 -0700 (PDT) From: Maxim Cournoyer To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: bug#65550: Don't add propagated-inputs for all outputs References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> <87edjpaqo2.fsf@envs.net> <81f39ef4b6e0ec4de7b55446c755fb0dec621c49.camel@gmail.com> <877cpedu3k.fsf@envs.net> Date: Thu, 31 Aug 2023 22:16:25 -0400 In-Reply-To: <877cpedu3k.fsf@envs.net> (=?utf-8?B?IuWui+aWh+atpiIncw==?= message of "Tue, 29 Aug 2023 18:24:31 +0800") Message-ID: <87msy67i4m.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > Liliana Marie Prikler writes: > >> I'd really like to avoid yet another special output, when "bin", "lib", >> etc. have already been given clear meanings, one of which strongly >> overlaps with "stuff that wants propagated inputs for pkg-config >> reasons". > > The benefit to put headers files and libraries files into seperated > outputs is to reduce the runtime closure size of packages, for example > my home profile contains xfce, emacs, fonts, etc. has total 5GiB (by > guix size), and they have 300MiB under include. > > calculated by: > > x=3D/gnu/store/0fyhci5kv03rfb9430jqs9wki2ifq5ja-profile > guix size $x > for i in `guix size $x`; > do [ -e $i/include ] && du -sb $i/include; > done | awk '{ sum +=3D $1 } END { print sum / 1024 / 1024 }' > > If put headers and other development files into a "dev" output, then > those 300MiB can be saved (won't need to be substituted if substitutes > available). Note that use a "include" output won't help here if you > leave pkg-config files in "lib", since pkg-config files need reference > its include and binaries need reference its libraries. > > So it seems to me a "dev" output is unavoidable, also both Debian and > Alpine Linux use '-dev' packages for the same reason, it should be > familiar to learn.. I'm not convinced that saving 300 MiB on 5 GiB is worth making using Guix packages more complicated, especially in this age of compressed file systems (text files compress very well). We'd also have to change a couple things to make it convenient and not have to plaster the code base with ugly `(,lib "dev") inputs ^^'. I reckon it could all be automated, but I'm not sure it's worth the effort at this stage (there bigger low hanging fruits to pick in my opinion -- such as moving static libraries automatically in the gnu build system, paying more attention to large documentation or unecessary installed files, etc.). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 22:34:23 2023 Received: (at 65550) by debbugs.gnu.org; 1 Sep 2023 02:34:23 +0000 Received: from localhost ([127.0.0.1]:59539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbtzK-0003Gj-VJ for submit@debbugs.gnu.org; Thu, 31 Aug 2023 22:34:23 -0400 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]:44048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbtzI-0003GX-OE for 65550@debbugs.gnu.org; Thu, 31 Aug 2023 22:34:21 -0400 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-64a70194fbeso8631036d6.0 for <65550@debbugs.gnu.org>; Thu, 31 Aug 2023 19:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693535646; x=1694140446; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=UkYETkI1BPE1C1olyN/uGplV7BgnowFQKdE24jWy3NA=; b=BzRuqJ0+0qimHxBXHWi/K7aqrZ+1rcyj/AWxKAFax0Nbuj0ZYsrmk/xZ/LF0O7HN2u 7ZqNH3j5flwtJcVAF0Dhvs3rZNw0prvtomHK1i3aR2nTNxeDvf+eFOgosnYVS4Rqyl4Z +TxeLt1iPwMuxsqpyRAWiMAC/Qmn86xiePXGEIwI3ft69jhfqUcehAEl5KW5oRTqTvkC v/QN3Lbgi6/AohMVXk52LFU6UJ8iGW6lN61BzhBxg6aFoI2s9hf2/hV//c/HZusSkbM6 p7mfjVc7PQUHfQ7loeDWI4doeKmaJ9XYRhxDXTa8JQo+vpWD4iL0i9PNBhduJQSTjAZP 3FjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693535646; x=1694140446; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UkYETkI1BPE1C1olyN/uGplV7BgnowFQKdE24jWy3NA=; b=KEs7MmNbJiLTGRZsB+frq9mljydmj5Dlr50syKksxGlsiA6zrm4qv3YznTCF+Uvul+ 84HZbIwUjM5TrzTO3JpmS/ZBlYnKAd7eF4dIuWP99RHkC5iW/iqvtc+qLfWLHGoJRw6Q IK+MAsKJCipjZFoIuYM/hQ3kn1jsVwGaIsHdofCORwePftvV5spgwtWrmeI3gbV5VYPn NDergncxA/3CKEgHsCv+FUvtY8Q8lUJmy6anWYfPvi87lugwvKBhC4WBleedWdk5JR/A 1mLF0oocSwooDU0Z0A0UBC+oiOj0h+kxuO7ZcAja9/nU4q6pu0sf8iFqSxfzcb+2rYn6 xTHA== X-Gm-Message-State: AOJu0Yzv9Y6Nd2k01zcWJeDV4vqpuCRBIKGPKEdAyluSs5YXqriDq3WJ 6PwGGSX2NMoM+L6YQvX+3iw= X-Google-Smtp-Source: AGHT+IFp0UcJ3del9z6AyZl6sEJ+lNEcYqkPXc9WVKcgIj1DO74IT6UiuoiZMn5DzYXVEumkzJeA8w== X-Received: by 2002:a0c:cb8a:0:b0:64a:b025:6a0 with SMTP id p10-20020a0ccb8a000000b0064ab02506a0mr952970qvk.41.1693535646245; Thu, 31 Aug 2023 19:34:06 -0700 (PDT) Received: from hurd (dsl-10-128-23.b2b2c.ca. [72.10.128.23]) by smtp.gmail.com with ESMTPSA id z14-20020a0cda8e000000b0063cfe9adb2csm1078269qvj.108.2023.08.31.19.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 19:34:05 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: bug#65550: Don't add propagated-inputs for all outputs References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> Date: Thu, 31 Aug 2023 22:34:04 -0400 In-Reply-To: <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 26 Aug 2023 16:21:34 +0200") Message-ID: <87a5u67hb7.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= , iyzsong@envs.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana and =E5=AE=8B=E6=96=87=E6=AD=A6, Liliana Marie Prikler writes: > Am Samstag, dem 26.08.2023 um 21:53 +0800 schrieb iyzsong@envs.net: >> From: =E5=AE=8B=E6=96=87=E6=AD=A6 >> >> * guix/profiles.scm (package->manifest-entry): Only include >> propagated inputs from a package for its "dev" output, or its "out" >> output if the package doesn't have a "dev" one. >> --- > I think this patch misses the most obvious use case of the out:lib > split. I also think that hardcoding this list is bound to fail. > > Instead, we could for the time being solve this with yet another > package property. > '((propagate-inputs-from "lib")) ; but not out > '((propagate-inputs-from . ("lib"))) ; same meaning, different style > '((propagate-inputs-from "out" "lib")) ; but not doc > If the property is missing, we still propagate from all outputs, as is > currently done. I'm rather against the proposed changes as it stands. I think it'd lead to a lot of noise in the code base and favor more complex splits of packages, which I'm doubtful is worth the cost (in terms of hackiness/complexity). Since I've known Guix, I've appreciated that a simple 'find $(guix build some-package) typically shows me the package whole, except perhaps for its doc and debug symbols. Having to know which packages have a "lib" outputs when using them in package definitions is also not fun in my experience (you start by adding the package, then it fails, then you verify its outputs, then you add `(,package "lib")), and I fear going to a "dev" output would bring the same kind of annoyance but at larger scale. I think we'd need to evaluate what we'd gain in terms of size reduction a bit more carefully before moving in this direction and how it'd impact the user experience. E.g., if we can reduce the minimal Guix image size by maybe 30%, that'd be nice, but if we're talking of about 5% like in your example profile, it doesn't seem worth the complexity to me. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 08:53:50 2023 Received: (at 65550) by debbugs.gnu.org; 1 Sep 2023 12:53:50 +0000 Received: from localhost ([127.0.0.1]:60054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3eo-00029G-EU for submit@debbugs.gnu.org; Fri, 01 Sep 2023 08:53:50 -0400 Received: from mail.envs.net ([5.199.136.28]:38066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3el-000296-Qh for 65550@debbugs.gnu.org; Fri, 01 Sep 2023 08:53:49 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id B659738A0143; Fri, 1 Sep 2023 12:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1693572816; bh=G6u3oOahU4dGebUIGRhcpDxbJBBSCBGNkZw/PEDIvjw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XtOGsMNgLsVAuiFOJ7rZnVjWOeNQnntDEfnF+0hLqyssQ4IUdi4XfcN7cNLcxQ0lR 0FbH51xyrWxd0MzSjd/MSYV8dC8U9GvcPfAvDOqcFeSB3EfJm5GWo8as+uOR43dA6T iI9yrVd3Wf4SFSYa/8UtuM5IsZgT/50eD+mzUBwjdP7kM5QxsHtDRLLMpbhnqBoW/J qIvRovjW9C1ddWVnxNOSCQ+pFeLb8gpG3p2AvyYrsieyvUGZWWn62T+8Rjm5OZ8Glu OCvYXTL7P1VcH4oVWz29V+NjoOCnNKqp9vDlCFytAN/sXSTkAwKXSp71jZ99RkHLIv FfBHETdjKMCfhgGer+qEkKXUumpBiiFOx0XCetDNlyQvqBDwA6yzAzpU0XAhOnXXGd aLOSjX1MFmcOp0uaYbkFfHRa8w2D6Q2JxFDhmEwgYrPGIojyncJ4wbTIwH/9b+NYUE N2GOkzgcAiwuYd2bD0GXCykNgtkRvZOS057vE8eIhmjkJYzQiebtFfAPVz09XBU+Bz +CbVx/a8dbv8JGJ0dNAaurtTgXH47XaRhGeP0hLkl3wCNrWK3dUsC0CIwuROsgo+fZ MgObPOLWG/yt9TADVF4m2cirAsylhwy5sqwF/atLfhtGdnxvAPIXSLw9jA5w901Rsw HHQ9y/lByJVtMijeRFq0rpSk= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WPJOtbb5_cRo; Fri, 1 Sep 2023 12:53:30 +0000 (UTC) Received: from localhost (unknown [36.170.58.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Fri, 1 Sep 2023 12:53:30 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d80a538b; Fri, 1 Sep 2023 12:53:55 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Maxim Cournoyer Subject: Re: bug#65550: Don't add propagated-inputs for all outputs References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> <87a5u67hb7.fsf_-_@gmail.com> Date: Fri, 01 Sep 2023 20:53:55 +0800 In-Reply-To: <87a5u67hb7.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Thu, 31 Aug 2023 22:34:04 -0400") Message-ID: <87a5u6yrz0.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxim Cournoyer writes: > Hi Liliana and =E5=AE=8B=E6=96=87=E6=AD=A6, > > Liliana Marie Prikler writes: > >> Am Samstag, dem 26.08.2023 um 21:53 +0800 schrieb iyzsong@envs.net: >>> From: =E5=AE=8B=E6=96=87=E6=AD=A6 >>> >>> * guix/profiles.scm (package->manifest-entry): Only include >>> propagated inputs from a package for its "dev" output, or its "out" >>> output if the package doesn't have a "dev" one. >>> --- >> I think this patch misses the most obvious use case of the out:lib >> split. I also think that hardcoding this list is bound to fail. >> >> Instead, we could for the time being solve this with yet another >> package property. >> '((propagate-inputs-from "lib")) ; but not out >> '((propagate-inputs-from . ("lib"))) ; same meaning, different style >> '((propagate-inputs-from "out" "lib")) ; but not doc >> If the property is missing, we still propagate from all outputs, as is >> currently done. > > [...] > > I think we'd need to evaluate what we'd gain in terms of size reduction > a bit more carefully before moving in this direction and how it'd impact > the user experience. E.g., if we can reduce the minimal Guix image size > by maybe 30%, that'd be nice, but if we're talking of about 5% like in > your example profile, it doesn't seem worth the complexity to me. I agree, thanks Maxim and Liliana for the inputs! From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 11:04:04 2023 Received: (at 65550) by debbugs.gnu.org; 1 Sep 2023 15:04:04 +0000 Received: from localhost ([127.0.0.1]:33646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc5gq-0002ku-06 for submit@debbugs.gnu.org; Fri, 01 Sep 2023 11:04:04 -0400 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:42080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc5gn-0002kO-Fb for 65550@debbugs.gnu.org; Fri, 01 Sep 2023 11:04:02 -0400 Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-41205469f4eso489231cf.0 for <65550@debbugs.gnu.org>; Fri, 01 Sep 2023 08:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693580627; x=1694185427; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=jBV8WItrTgdAk/6RAL/GuHHeJ6ArHUGzdvFHd96TuyU=; b=lMeFm4YTpcwvtJQ/nHLzHn4nKi4Gf3EOwIZlpSfuLA+z2t0XW+pLFHQ+8Wx8w1/ph2 Z06BGdUZu5SUofi0NviJGvfpx+KUShE3ZwZiQn9uqPM2ZJTPAGu0VWg/0vmwyRuElQGr wrhAsjjD5l6Vo8DNKEnooLhDKfKJ6c5isPLNc6uK3sy/xVDIexJxXbXJoU4qwknUpmWr 4qJpt6jiGNpUAz7/3oShpir4o5L171rJcOs/bC2cRoIddOCFU4rprn8bS74B7sAwz43p Pw6KSv+7MJV0ja+sGS7bm146atI9lBzKEMszy1hTd10GvWSgVMA0TwxlwHZnY7swYH4O jdkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693580627; x=1694185427; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jBV8WItrTgdAk/6RAL/GuHHeJ6ArHUGzdvFHd96TuyU=; b=bZ2dITqPwkmSaiTH9e+RscJakUl/d6IUEtqKKh6zvhGCbP2EUSwwD0U8x3wckrkuX4 fsWcnm2O87VfYuO2fPKa13tdTVJxXScLIike/Sp0Z8rpqKYHmhtIKWj/QabPN5kDwPLr sBGvoRSyruRHtqjKaP2lNVnf1k4/X1GxWIOdWF8B/Fp6ucjL76d6PzYNlaLtDm/OmRkz KRkEoEM7NkbB5PSeWj0hujB8LNEPfcAkgEwmhl6ZzljbV5YU5wXNXSc7WdQa09LUQori 6OkxIGJQa/5anzckD2zb3jhx+xYx9zKewT9/dCSBaZI33YwNFphhOn4K5MxUbhYRrtBg Ya/Q== X-Gm-Message-State: AOJu0YyFw39+t9XBwDMKitMmmkvKMmyBRc1b91QwhDgWxQosiqPvEx2E A3ZC96leuvuRiRILUacsrcw= X-Google-Smtp-Source: AGHT+IF281PVb26/UAeeZjcwX5+qg+7R1D19jqpaNEIwIjLzzdRsEz7GWp4YZIfRqL1gjCPw7to7og== X-Received: by 2002:a05:622a:42:b0:3f9:d1c3:cc45 with SMTP id y2-20020a05622a004200b003f9d1c3cc45mr8090463qtw.28.1693580626620; Fri, 01 Sep 2023 08:03:46 -0700 (PDT) Received: from hurd (dsl-154-228.b2b2c.ca. [66.158.154.228]) by smtp.gmail.com with ESMTPSA id f3-20020a05622a1a0300b004108c610d08sm1513360qtb.32.2023.09.01.08.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 08:03:46 -0700 (PDT) From: Maxim Cournoyer To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: bug#65550: Don't add propagated-inputs for all outputs References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> <87a5u67hb7.fsf_-_@gmail.com> <87a5u6yrz0.fsf@envs.net> Date: Fri, 01 Sep 2023 11:03:45 -0400 In-Reply-To: <87a5u6yrz0.fsf@envs.net> (=?utf-8?B?IuWui+aWh+atpiIncw==?= message of "Fri, 01 Sep 2023 20:53:55 +0800") Message-ID: <87ttse0wby.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, =E5=AE=8B=E6=96=87=E6=AD=A6 writes: [...] >> I think we'd need to evaluate what we'd gain in terms of size reduction >> a bit more carefully before moving in this direction and how it'd impact >> the user experience. E.g., if we can reduce the minimal Guix image size >> by maybe 30%, that'd be nice, but if we're talking of about 5% like in >> your example profile, it doesn't seem worth the complexity to me. > > I agree, thanks Maxim and Liliana for the inputs! Should we close this issue for now? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 20:42:52 2023 Received: (at 65550-done) by debbugs.gnu.org; 2 Sep 2023 00:42:52 +0000 Received: from localhost ([127.0.0.1]:34552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcEix-0005NE-Q3 for submit@debbugs.gnu.org; Fri, 01 Sep 2023 20:42:52 -0400 Received: from mail.envs.net ([5.199.136.28]:34524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcEiw-0005N6-5V for 65550-done@debbugs.gnu.org; Fri, 01 Sep 2023 20:42:50 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 1998938A0142; Sat, 2 Sep 2023 00:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1693615360; bh=T510dyA2ETNxKigpDG1A0gEgNgfvwTeWhVV9Nw/bpBo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZZZv/wGzKeBLIwmqz5T8OnuS4dfkerDroxszeJCICHunmm+FjyJtTk3D+No8810HW B7kwJSlf2mcdnTBjbM9SBekqIN8XO9A0s5Zlco8F7vubbZYr7huokp3ShvbyADTf03 EicIGWHjLyQJomFIPcpM0S5Bdb5jzCf26XYhjhldbxZD5Sj/x9/eqG5P9gE/jFhHj3 B3GYQZ091pcjA77wsAP8E/wUpXF8R3aBbrWN1BcOzYG7Lx7dRM7TDrQ3sSptsS4P/8 tQ9x5ODK/s5WNiHHfQfXP3sjtJDF1pkDFFsmqjA+sVrKNBBIz2bdk7Nuele+73HLR3 05zVSZFVhIWGNt93d1wKJfcRFJx/4wzXo/QvdSAheg2BuyrE9qvwjh7y+0ngkX+pWp HVJ62w4WqffkNWatka8TiZKD0E9B+hRMbOCx8QTb8tU0SiVviPuVe97A+il0wQl5MR 4nUAu17r4RTYDaY2djVF9T5jyrVEw6mFY9qbm36an9BSWiQBWGuDIOAmsRiR1ZYgO9 6K19HG/DLzF8XNRz8DwG9KcmBdHf+jY8s/Q7tTGUr+GeQMRFg8Y5LVTBdac2gckDjE cVqPnLQXv89d8DT+5rJrpyMS/qS4bfXou/qAILpiH8SaSlJMPgJL8IUrpexznwEwZZ HyuBDfS01kAe3CMvaFKdfJaY= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id x2wLAwypFopu; Sat, 2 Sep 2023 00:42:33 +0000 (UTC) Received: from localhost (unknown [36.170.58.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sat, 2 Sep 2023 00:42:33 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b90494f2; Sat, 2 Sep 2023 00:43:01 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Maxim Cournoyer Subject: Re: bug#65550: Don't add propagated-inputs for all outputs References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> <87a5u67hb7.fsf_-_@gmail.com> <87a5u6yrz0.fsf@envs.net> <87ttse0wby.fsf@gmail.com> Date: Sat, 02 Sep 2023 08:43:01 +0800 In-Reply-To: <87ttse0wby.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 01 Sep 2023 11:03:45 -0400") Message-ID: <871qfhiewa.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65550-done Cc: 65550-done@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxim Cournoyer writes: > Hi, > > =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > > [...] > >>> I think we'd need to evaluate what we'd gain in terms of size reduction >>> a bit more carefully before moving in this direction and how it'd impact >>> the user experience. E.g., if we can reduce the minimal Guix image size >>> by maybe 30%, that'd be nice, but if we're talking of about 5% like in >>> your example profile, it doesn't seem worth the complexity to me. >> >> I agree, thanks Maxim and Liliana for the inputs! > > Should we close this issue for now? Yes, closing. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 09 06:38:22 2023 Received: (at 65550) by debbugs.gnu.org; 9 Sep 2023 10:38:22 +0000 Received: from localhost ([127.0.0.1]:46225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qevM6-0003Lh-6x for submit@debbugs.gnu.org; Sat, 09 Sep 2023 06:38:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qevM1-0003LR-2b for 65550@debbugs.gnu.org; Sat, 09 Sep 2023 06:38:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qevLq-0006dQ-Rr; Sat, 09 Sep 2023 06:38:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=trOFcvzx+Xifc6QXfB8y+NTJhGBP211OWiJ7fcMoEE0=; b=Ztjl7RIzZ8ZkNn/2UpIi RDurgnQiJNA9snUMNtfR8kxpHe/1niDV4PQnqj0WwKivt9eJ7rrVHZpMjLfFEcRvdzM/2kcGylHkR K7txJUj2jcqjpgQ4Ha9030/EcLxtFc6ImBa/vOmXQVCEGHtfd0vpCqNQM+5n0ebdnzoNWTn43t0Oc qsYud2M1IPzK1sr+3wOliINjtuXSWIHOuEYX8ELcWZ1EccJEtot5rLJ4a7WHJA3VKlSI60fnIRSOj PkvQs1GqYnYOtc7csVZKQTbPIgGpSdS1Fg4oHkoocoDCZNGfQ2eFpPv+//5J//vDU34ZDq6tGQzEE 2YCJfbRe2sLH/g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: iyzsong@envs.net Subject: Re: [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages. References: <87ttsm828q.fsf@envs.net> <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 23 Fructidor an 231 de la =?utf-8?Q?R=C3=A9vol?= =?utf-8?Q?ution=2C?= jour du Houblon X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 09 Sep 2023 12:38:03 +0200 In-Reply-To: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> (iyzsong@envs.net's message of "Sat, 26 Aug 2023 21:53:09 +0800") Message-ID: <87o7ibzl6c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65550 Cc: 65550@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Josselin Poiret , Ricardo Wurmus , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! iyzsong@envs.net skribis: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 > > * guix/profiles.scm (package->manifest-entry): Only include propagated in= puts > from a package for its "dev" output, or its "out" output if the package > doesn't have a "dev" one. What=E2=80=99s the rationale? Right now, there=E2=80=99s only one package with an output called =E2=80=9C= dev=E2=80=9D: --8<---------------cut here---------------start------------->8--- $ guix package -A |cut -f3|grep dev|wc -l 1 --8<---------------cut here---------------end--------------->8--- So the focus on =E2=80=9Cdev=E2=80=9D is debatable. More importantly, this would break things like: guix shell python python-scipy -C -- python3 -c 'import numpy' =E2=80=A6 where =E2=80=98python-numpy=E2=80=99 is propagated by =E2=80=98py= thon-scipy=E2=80=99. Definitely not something we want to change. WDYT? Ludo=E2=80=99. From unknown Thu Jun 19 12:35:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Oct 2023 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator