GNU bug report logs - #6554
[coreutils] Additional suffix for split

Previous Next

Full log

Message #47 received at 6554-done <at> debbugs.gnu.org (full text, mbox):

From: Jérémy Compostella <jeremy.compostella <at> gmail.com>
To: Pádraig Brady <P <at> draigbrady.com>
Cc: Eric Blake <eblake <at> redhat.com>, coreutils <at> gnu.org,
	6554-done <at> debbugs.gnu.org, Peng Yu <pengyu.ut <at> gmail.com>
Subject: Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)
Date: Sun, 19 Feb 2012 19:30:16 +0100

[Message part 1 (text/plain, inline)]

> On 02/19/2012 12:54 PM, Jérémy Compostella wrote:
> > Pádraig,
> >
> > I replaced --suffix with --additional-suffix and made some cleaning.
> >
> > Feel free to comment the attached patch.
>
> Logic is perfect again.
Thanks :)

> I adjusted the help output a little like:
>
> -  -a, --suffix-length=N   use suffixes of length N (default %d)\n\
> -      --additional-suffix=SUFFIX  append an additional SUFFIX to output
file\n\
> -                                       names. SUFFIX must not contain
slash.\n\
> +  -a, --suffix-length=N   generate suffixes of length N (default %d)\n\
> +      --additional-suffix=SUFFIX  append an additional SUFFIX to file
names.\n\
I'm just wondering why did you removed the slash warning ? This warning
is maybe too much in the command usage but IMHO the man page should
mention it. Moreover, the mktemp mention this "restriction" on its
--suffix option this way.

Cheers,

Jérémy

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.