From unknown Mon Aug 11 21:14:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65539: [PATCH] ; Fix push-button when triggered by a single keypress Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Aug 2023 17:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 65539@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169298570810344 (code B ref -1); Fri, 25 Aug 2023 17:49:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Aug 2023 17:48:28 +0000 Received: from localhost ([127.0.0.1]:41175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZav5-0002gk-Rg for submit@debbugs.gnu.org; Fri, 25 Aug 2023 13:48:28 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZav1-0002ff-HZ for submit@debbugs.gnu.org; Fri, 25 Aug 2023 13:48:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZauq-0004ic-Q7 for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2023 13:48:12 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZaum-00008b-7H for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2023 13:48:10 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3F3B55C071E for ; Fri, 25 Aug 2023 13:48:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 25 Aug 2023 13:48:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1692985684; x=1693072084; bh=iLEWOD+h26JerXNo8su5gy2ha kHDPsxiFQ4JgjLr9p4=; b=tL1UPpAsvwPDWfw9a8yMtvO1aYWCGO42NVEbxnbl/ E97SAHwuDQAaYeQ+qBfPawiHWwsbBDoBa5SHlRaCYvTwI8rFKa5EdOTQYbA4nWqz Xw5vtPLvC+dPi5dcbiXPJuYpxyfbE0tA3d6hO5e7y1+wTko5wuaRjXGGgvEE22fr LoZeKCyDTfnakzxRKl7yWSNzhMigsvRbUfoKgEYOrL0iN5Ybq5jdR9NvlqMN2MTW 1c5EH4cpEOKC+6McWL6mVcsGfSWtxxRJORvHbVsvCw3gJKhq67JTqKZP66vwougC npd2t5UfwCDjvcKBm91a3URsP7M8cUNv88k2H9E60dnuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692985684; x=1693072084; bh=iLEWOD+h26JerXNo8su5gy2hakHDPsxiFQ4 JgjLr9p4=; b=Vq7JSGnWygipkLBTLtcHavt8+LUYWLbpVZb7if59JlZS1lTVtul 0U1igz48elNB9gGlIJ1xyjRieeviqCViN5acJHrl3GsP7ROGiIcRjyLbvLOoJvw1 K3UiqFz8qw0MzRWRfHBUn1En0RJBRBxnwSTd1OmG3grhXeL7VP5eW+bDkxMK7uy7 PZoPw7cjYWCq6uxR89okwQctKwdlq1bFcuBQbSjOdMyn13C2NQvsOTJ5ns/mO6t6 5BOOMM1+gdvP4sKkYCSa50FZJmY+UxQe0Y3NTqLPD3phR8ex8ixFB3/NxKo+uqvc pZRiBMUWlyn2NDjFqOUVTi26Dwxdy6IXoig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvkedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesmhdtreertd dttdenucfhrhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggr lhhivghnrdgtohhmqeenucggtffrrghtthgvrhhnpeekffffgfevteehtdeiffelffegke dvieeigeehfedtteejkeefhfevtddtkeefffenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 25 Aug 2023 13:48:03 -0400 (EDT) From: Steven Allen Date: Fri, 25 Aug 2023 10:48:01 -0700 Message-ID: <87sf87qai6.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=66.111.4.29; envelope-from=steven@stebalien.com; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain The following code was broken in the recent android merge: (keymap-set button-map "" 'push-button) The attached patch fixes this. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-push-button-when-triggered-by-a-single-keypress.patch Content-Description: fix push-button >From c6270b325e322d5fc2c2eafba2661d7bc82ad47f Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Fri, 25 Aug 2023 10:43:43 -0700 Subject: [PATCH] ; Fix push-button when triggered by a single keypress * lisp/button.el (push-button): don't assume the event is a list, it may be a single key. --- lisp/button.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/button.el b/lisp/button.el index b01595943fc..bfe6ccc8d1f 100644 --- a/lisp/button.el +++ b/lisp/button.el @@ -492,7 +492,7 @@ push-button (if str-button ;; mode-line, header-line, or display string event. (button-activate str t) - (if (eq (car pos) 'touchscreen-down) + (if (eq (car-safe pos) 'touchscreen-down) ;; If touch-screen-track tap returns nil, then the ;; tap was cancelled. (when (touch-screen-track-tap pos) -- 2.42.0 --=-=-=-- From unknown Mon Aug 11 21:14:41 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Steven Allen Subject: bug#65539: closed (Re: bug#65539: [PATCH] ; Fix push-button when triggered by a single keypress) Message-ID: References: <83ledreelj.fsf@gnu.org> <87sf87qai6.fsf@stebalien.com> X-Gnu-PR-Message: they-closed 65539 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 65539@debbugs.gnu.org Date: Thu, 31 Aug 2023 09:40:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1693474802-11339-1" This is a multi-part message in MIME format... ------------=_1693474802-11339-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #65539: [PATCH] ; Fix push-button when triggered by a single keypress which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 65539@debbugs.gnu.org. --=20 65539: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65539 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1693474802-11339-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 65539-done) by debbugs.gnu.org; 31 Aug 2023 09:39:05 +0000 Received: from localhost ([127.0.0.1]:54870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbe8n-0002va-0Z for submit@debbugs.gnu.org; Thu, 31 Aug 2023 05:39:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbe8k-0002v4-Kh for 65539-done@debbugs.gnu.org; Thu, 31 Aug 2023 05:39:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbe8X-00071B-6r; Thu, 31 Aug 2023 05:38:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wKI1gTeExlcpJlgMRheQCOMbOf1BHP7cPpOdouz+Di8=; b=oE8bX+/tA+4d eUD8byE/rtM3PL6CZhuVK60HRH82VNIQoaZIXqY2fji2WKQjP3VDMmwDHULAQMCxyq7ElnkjRrqvj 31UiK5V9vc7ExKQunMdXDSaJPw2UpxNVN1Fmuhs4zdgW+/CBp4u3+/jz3M2d/o58Il9yq5F2k9xq9 nkFTcWcDsg7c6N7KpH1z2N6dcH4CCCqrWEOc8FkuHHatOPymJlOp3+jmPxYQC9Za9JAO1WmUtHcDO MchgarZRWqwWPoSliB6eEdnAnxUzw91x5nEp0Z6GUHlwRydZMr9VNqejG49L5aiWZxzuOGvwAX2PI BgJ2Q88MeB7skIPsb6+6kA==; Date: Thu, 31 Aug 2023 12:38:32 +0300 Message-Id: <83ledreelj.fsf@gnu.org> From: Eli Zaretskii To: Steven Allen In-Reply-To: <87sf87qai6.fsf@stebalien.com> (message from Steven Allen on Fri, 25 Aug 2023 10:48:01 -0700) Subject: Re: bug#65539: [PATCH] ; Fix push-button when triggered by a single keypress References: <87sf87qai6.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65539-done Cc: 65539-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Steven Allen > Date: Fri, 25 Aug 2023 10:48:01 -0700 > > The following code was broken in the recent android merge: > > (keymap-set button-map "" 'push-button) > > The attached patch fixes this. Thanks, installed on master, and closing the bug. ------------=_1693474802-11339-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Aug 2023 17:48:28 +0000 Received: from localhost ([127.0.0.1]:41175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZav5-0002gk-Rg for submit@debbugs.gnu.org; Fri, 25 Aug 2023 13:48:28 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZav1-0002ff-HZ for submit@debbugs.gnu.org; Fri, 25 Aug 2023 13:48:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZauq-0004ic-Q7 for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2023 13:48:12 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZaum-00008b-7H for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2023 13:48:10 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3F3B55C071E for ; Fri, 25 Aug 2023 13:48:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 25 Aug 2023 13:48:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1692985684; x=1693072084; bh=iLEWOD+h26JerXNo8su5gy2ha kHDPsxiFQ4JgjLr9p4=; b=tL1UPpAsvwPDWfw9a8yMtvO1aYWCGO42NVEbxnbl/ E97SAHwuDQAaYeQ+qBfPawiHWwsbBDoBa5SHlRaCYvTwI8rFKa5EdOTQYbA4nWqz Xw5vtPLvC+dPi5dcbiXPJuYpxyfbE0tA3d6hO5e7y1+wTko5wuaRjXGGgvEE22fr LoZeKCyDTfnakzxRKl7yWSNzhMigsvRbUfoKgEYOrL0iN5Ybq5jdR9NvlqMN2MTW 1c5EH4cpEOKC+6McWL6mVcsGfSWtxxRJORvHbVsvCw3gJKhq67JTqKZP66vwougC npd2t5UfwCDjvcKBm91a3URsP7M8cUNv88k2H9E60dnuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692985684; x=1693072084; bh=iLEWOD+h26JerXNo8su5gy2hakHDPsxiFQ4 JgjLr9p4=; b=Vq7JSGnWygipkLBTLtcHavt8+LUYWLbpVZb7if59JlZS1lTVtul 0U1igz48elNB9gGlIJ1xyjRieeviqCViN5acJHrl3GsP7ROGiIcRjyLbvLOoJvw1 K3UiqFz8qw0MzRWRfHBUn1En0RJBRBxnwSTd1OmG3grhXeL7VP5eW+bDkxMK7uy7 PZoPw7cjYWCq6uxR89okwQctKwdlq1bFcuBQbSjOdMyn13C2NQvsOTJ5ns/mO6t6 5BOOMM1+gdvP4sKkYCSa50FZJmY+UxQe0Y3NTqLPD3phR8ex8ixFB3/NxKo+uqvc pZRiBMUWlyn2NDjFqOUVTi26Dwxdy6IXoig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvkedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesmhdtreertd dttdenucfhrhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggr lhhivghnrdgtohhmqeenucggtffrrghtthgvrhhnpeekffffgfevteehtdeiffelffegke dvieeigeehfedtteejkeefhfevtddtkeefffenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 25 Aug 2023 13:48:03 -0400 (EDT) From: Steven Allen To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; Fix push-button when triggered by a single keypress Date: Fri, 25 Aug 2023 10:48:01 -0700 Message-ID: <87sf87qai6.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=66.111.4.29; envelope-from=steven@stebalien.com; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain The following code was broken in the recent android merge: (keymap-set button-map "" 'push-button) The attached patch fixes this. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-push-button-when-triggered-by-a-single-keypress.patch Content-Description: fix push-button >From c6270b325e322d5fc2c2eafba2661d7bc82ad47f Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Fri, 25 Aug 2023 10:43:43 -0700 Subject: [PATCH] ; Fix push-button when triggered by a single keypress * lisp/button.el (push-button): don't assume the event is a list, it may be a single key. --- lisp/button.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/button.el b/lisp/button.el index b01595943fc..bfe6ccc8d1f 100644 --- a/lisp/button.el +++ b/lisp/button.el @@ -492,7 +492,7 @@ push-button (if str-button ;; mode-line, header-line, or display string event. (button-activate str t) - (if (eq (car pos) 'touchscreen-down) + (if (eq (car-safe pos) 'touchscreen-down) ;; If touch-screen-track tap returns nil, then the ;; tap was cancelled. (when (touch-screen-track-tap pos) -- 2.42.0 --=-=-=-- ------------=_1693474802-11339-1--