GNU bug report logs - #65509
[PATCH] Use correct env var when opening frames with freedesktop menu entries

Previous Next

Package: emacs;

Reported by: Davide Masserut <dm <at> mssdvd.com>

Date: Thu, 24 Aug 2023 18:45:01 UTC

Severity: normal

Tags: patch

Merged with 64310

Found in version 29.0.92

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65509: closed ([PATCH] Use correct env var when opening
 frames with freedesktop menu entries)
Date: Fri, 15 Sep 2023 11:35:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 15 Sep 2023 14:34:29 +0300
with message-id <83msxnk6uy.fsf <at> gnu.org>
and subject line Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries
has caused the debbugs.gnu.org bug report #65509,
regarding [PATCH] Use correct env var when opening frames with freedesktop menu entries
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65509: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65509
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Davide Masserut <dm <at> mssdvd.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Use correct env var when opening frames with freedesktop menu
 entries
Date: Thu, 24 Aug 2023 20:32:47 +0200
[Message part 3 (text/plain, inline)]
Tags: patch

When Emacs is built with PGTK, frames opened with the 
emacsclient.desktop entry are opened as X11 windows instead of 
Wayland.

This patch adds a sed command to the Makefile that replaces the 
environment variable "$DISPLAY" with "$WAYLAND_DISPLAY" when built 
with PGTK.



In GNU Emacs 30.0.50 (build 32, x86_64-pc-linux-gnu, GTK+ Version
3.24.38, cairo version 1.17.8) of 2023-08-24 built on T480s
Repository revision: 3907c884f03cf5f2a09696bda015b1060c7111ba
Repository branch: master
System Description: Arch Linux

Configured using:
'configure -C --prefix /home/davide/.local --with-pgtk
--with-native-compilation --enable-link-time-optimization
--enable-locallisppath=/usr/share/emacs/site-lisp/
'CFLAGS=-march=native -O2''
[0001-Use-correct-env-var-when-opening-frames-with-freedes.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: dm <at> mssdvd.com, stefankangas <at> gmail.com, 65509-done <at> debbugs.gnu.org
Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with
 freedesktop menu entries
Date: Fri, 15 Sep 2023 14:34:29 +0300
> From: Po Lu <luangruo <at> yahoo.com>
> Cc: dm <at> mssdvd.com,  stefankangas <at> gmail.com,  65509 <at> debbugs.gnu.org
> Date: Fri, 15 Sep 2023 15:44:02 +0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Why is it not safe?
> 
> Because there was previously no problem with the X build under Emacs 29,
> and using --reuse-frame there would chance introducing one.

OK, installed on emacs-29 and closing the bug.

Thanks.


This bug report was last modified 1 year and 306 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.