From unknown Thu Jun 19 14:03:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65509 <65509@debbugs.gnu.org> To: bug#65509 <65509@debbugs.gnu.org> Subject: Status: [PATCH] Use correct env var when opening frames with freedesktop menu entries Reply-To: bug#65509 <65509@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:03:07 +0000 retitle 65509 [PATCH] Use correct env var when opening frames with freedesk= top menu entries reassign 65509 emacs submitter 65509 Davide Masserut severity 65509 normal tag 65509 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 14:44:27 2023 Received: (at submit) by debbugs.gnu.org; 24 Aug 2023 18:44:27 +0000 Received: from localhost ([127.0.0.1]:38630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZFJj-0006XR-4T for submit@debbugs.gnu.org; Thu, 24 Aug 2023 14:44:27 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZFJh-0006XE-GU for submit@debbugs.gnu.org; Thu, 24 Aug 2023 14:44:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZFJX-0003zY-J0 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 14:44:15 -0400 Received: from out-39.mta1.migadu.com ([2001:41d0:203:375::27]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZFJU-0000Yp-6e for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 14:44:15 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1692902645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=kpJVrMIbc7Jk2oamzfoLuQMr0N6fEn+C37Kka0gV8M8=; b=KySKbiVh8GgNmJuJXzZ8P23MLKhFTVjUysfZLj9o/FzMIKbpEiSOH+XXT0388T+wNV9By7 idNHaPrg0s8GKyiNJVZQavbCD/KJqdoDsr7oFpvz/xvPhKdM2VW8S6hT9ljVeSt6QKY/c1 zxoo3jVhe4m5sMxsS23yoonAoUafZ7LFKwyNMzPX1DkLepRo1PpLq10phcuwwOhSpK2r7b uJ5k9tHux1OIw9LPdKcYF2b4StpWx2Nzf1vwac6Z2DtN1t6wjN9oSIAQQLvgaQaKeTJ5VU MhmnZxsuBoeXLWEmn8v37gLV+esBVZNctq7JfIpNfNiDf3Vf2bjAoZXwIswNzg== From: Davide Masserut To: bug-gnu-emacs@gnu.org Subject: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Thu, 24 Aug 2023 20:32:47 +0200 Message-ID: <87ttsomgb5.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::27; envelope-from=dm@mssdvd.com; helo=out-39.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain; format=flowed Tags: patch When Emacs is built with PGTK, frames opened with the emacsclient.desktop entry are opened as X11 windows instead of Wayland. This patch adds a sed command to the Makefile that replaces the environment variable "$DISPLAY" with "$WAYLAND_DISPLAY" when built with PGTK. In GNU Emacs 30.0.50 (build 32, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-08-24 built on T480s Repository revision: 3907c884f03cf5f2a09696bda015b1060c7111ba Repository branch: master System Description: Arch Linux Configured using: 'configure -C --prefix /home/davide/.local --with-pgtk --with-native-compilation --enable-link-time-optimization --enable-locallisppath=/usr/share/emacs/site-lisp/ 'CFLAGS=-march=native -O2'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Use-correct-env-var-when-opening-frames-with-freedes.patch >From c4f516e30c72fbc88838f2ad52730d5e26f8f358 Mon Sep 17 00:00:00 2001 From: Davide Masserut Date: Thu, 24 Aug 2023 18:33:39 +0200 Subject: [PATCH] Use correct env var when opening frames with freedesktop menu entries Avoid opening X11 frames with emacsclient.desktop or emacsclient-mail.desktop when built with PGTK. * Makefile.in (install-etc): Replace DISPLAY with WAYLAND_DISPLAY when built with PGTK. --- Makefile.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Makefile.in b/Makefile.in index fdd9353e254..6a08e1a7b18 100644 --- a/Makefile.in +++ b/Makefile.in @@ -843,6 +843,9 @@ EMACS_ICON= ifeq (${USE_STARTUP_NOTIFICATION},no) USE_STARTUP_NOTIFICATION_SED_CMD=-e "/^StartupNotify=true$$/d" endif +ifeq ($(HAVE_PGTK),yes) +USE_WAYLAND_DISPLAY_SED_CMD=-e "/--display=/ s/DISPLAY/WAYLAND_DISPLAY/" +endif install-etc: umask 022; ${MKDIR_P} "$(DESTDIR)${desktopdir}" tmp=etc/emacs.tmpdesktop; rm -f $${tmp}; \ @@ -857,6 +860,7 @@ install-etc: sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ $(USE_STARTUP_NOTIFICATION_SED_CMD) \ + $(USE_WAYLAND_DISPLAY_SED_CMD) \ ${srcdir}/etc/emacsclient.desktop > $${tmp}; \ ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}.desktop"; \ rm -f $${tmp} @@ -870,6 +874,7 @@ install-etc: client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ + $(USE_WAYLAND_DISPLAY_SED_CMD) \ ${srcdir}/etc/emacsclient-mail.desktop > $${tmp}; \ ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}-mail.desktop"; \ rm -f $${tmp} -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 05:35:08 2023 Received: (at 65509) by debbugs.gnu.org; 31 Aug 2023 09:35:08 +0000 Received: from localhost ([127.0.0.1]:54861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbe4x-0002pL-SK for submit@debbugs.gnu.org; Thu, 31 Aug 2023 05:35:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbe4u-0002on-SZ for 65509@debbugs.gnu.org; Thu, 31 Aug 2023 05:35:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbe4V-0005PG-Nn; Thu, 31 Aug 2023 05:34:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Mt/Z4+waZJNarOz4nlq+q5Lv4q8YcLs3zNZzribbVpg=; b=AO87mHoYO2FZ hPyL3F90aZwlPrCtuBOAYms+I/b9qTeAUhpQ+ycp5arwqw7YsPtO0820hSVVpo7HvO4e0PWwfoJ/I +yTGhh7WR1tX6Ve3AP//2gjzfMwEDoHO/4NPIM92LGDqiUF8zQhGzv7LQkSQgXPg2u5jQ2qZjL7R9 GnS9eeaIz5uLnJ7Cv068K3DqFwQzP9gNh8mGz4gAlU2P/wCb62la/rky1/GppTN5TH3t0d2TkVS82 Zn1ufLTCdw87s/Jc9BMG8vhLgOa3Wue4/zYTPs0v463Rcg9hIR08bWIl+qoB6FK8OXBDVUdSe7zfZ PbO9FYI7GEHmac+CLRE7zw==; Date: Thu, 31 Aug 2023 12:34:19 +0300 Message-Id: <83msy7eesk.fsf@gnu.org> From: Eli Zaretskii To: Davide Masserut , Po Lu In-Reply-To: <87ttsomgb5.fsf@mssdvd.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries References: <87ttsomgb5.fsf@mssdvd.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 24 Aug 2023 20:32:47 +0200 > From: Davide Masserut via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > When Emacs is built with PGTK, frames opened with the > emacsclient.desktop entry are opened as X11 windows instead of > Wayland. > > This patch adds a sed command to the Makefile that replaces the > environment variable "$DISPLAY" with "$WAYLAND_DISPLAY" when built > with PGTK. Po Lu, any comments on this? From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 07:33:08 2023 Received: (at 65509) by debbugs.gnu.org; 31 Aug 2023 11:33:08 +0000 Received: from localhost ([127.0.0.1]:55084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbfvA-0002vT-Jp for submit@debbugs.gnu.org; Thu, 31 Aug 2023 07:33:08 -0400 Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:45007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbfv8-0002ut-NM for 65509@debbugs.gnu.org; Thu, 31 Aug 2023 07:33:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693481573; bh=+10x0PlZzose4fsQtRQYQehlaypRH/yHQx1tIS1Rbt8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=adxTkygbdgdunDWWVWgdXAawX3u4JH9iUXkVweIcJ3bhdUuyl/85i1v64cgs+yTW+BGmxCvLa+5smeI/60H13pgiDBnFZoU8UydeA5z7SpBnqXgVAAH9geLN+WJUpttP1jJcovI5/4UmTuCq+6PHXvws5/kDrED85xSEhs1Bmam0AgXrQdPr+TQz54Y2iE2HEradIqMb3IIbSDrzTb2UuSd/MU+Hl+UmMSfTOjjdzttY9jycL4MPTM3JwJ97YPOTLd+CoB+V1pH5yC/XvM5xel2R3RRP8ZaBU1/RlIQ2givi1vsvlGuIdspR8Xejo1ySXtuixYkY0j36UvXVFC78fQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693481573; bh=OwywXyz4H2DSjtU+UX+vLY8pocEbh05SjY6BAq+Cgcf=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=h61X4WZwIYjGOEs/S9lw9dm5uvKmJIvFRCPinPo/WLpGnpuEJ1kw/0N9TJ4W80APVkX060QVxcW9Lqqmr3mXSeGF+LaUt4k4/BBDIMF6g9MbX2SW1jdNeyd/i+HeeJC/huHWWPhENk0IcuY+Y/ghlW/3X+5bXoDUkVzmmFFsT7UKL09oyIehOpBL++sT4rAgUY3HqZMLidzn98aXwNpu7BoeakcCSfK9aZNzZb94upzLiw+FSCn6xwdZXW5UbutFOMGooJZnCCabbGTmgBipZFI+8fDI0N5QmTbg+tbn65/oLiinkS+bRNoOXiSdnqbd+t62R9SoTgW7reOQvyTDfA== X-YMail-OSG: mzWBdkEVM1l2Wfrd4RtD_pU0x9QwpYM7RXbQKvkKXdUs1ibcGNOEFxQyX7ZMwYf 6nExiJameQW8BwsUz8iJNF7TD1t569Js7Josd2bdtHdIW95f5vXuHoQLrxRrrDqBQDYINHLrqaz5 Ws4UdeXIYq0rKSoOcmPJMJSms8mkJrZ4PRb_ayG9nhThFE9.K.M3.z0h4vN2.Y5x4JiSZ7XzLrlD LnQGz4uPoHsZ_RTLnsw.dR2TWMA5i2DKoXfuFq6LldkFsL3_0.AG6OTG3fhuUsqinF.dGOOKkzWD eoZOuam611ZyI.1nI7QLN.zTRXtX8iaDeSRDOhSO0iCh5KEu34mSA2jzsxAVTIZ.DMLOzfudYMzS HEA6d.WAeOqVLtysu77k1AJ8VQPAuP2lVAsISGDcsqhu4g_cM5mBU_Jko0DNBu7dUiwd6qUDjB5s 3.VUEhfWRac5I3ATDENtkLPf8kV2Cj5mHB3PRtLFimM7dUPxkai98OvH.HInsy2u_EQrx4qqAU4n XmfRcDDqTqgF590pgXjL5uS.Ld_nmkaTHOtF_19XsDE9O2g.UiWTPVs_GThs68MtPAmrL.9d3SSR 0lV7l_X7beHxCBHBYRnpoAh.6nlHf0unoxcNxlBqVRZMCzIoflGneNaTFjyeUHaPGzSpl5saxuBv ejhwB8.dFPiPXbADc8raSu7kgR9XRAxgmbNOViLqKOGfg34DC8FORZOyuBDzh1TylA7JIMMp6fRT mkVG6d3a4eM8.PafpyicjAp2p0wBzEm0aWhoBxly7BZ.dRahe.AOf0hm5AFP1hOPOKZR8MxyC7EM sSGWXOnySDbEljAPntg7nHMPJekPTEL1me6akF015MCFNOYmJlGfN95zWRCC6e33L5bdZS29os2U z3eRaZxjv5vi8NvT7VLx1hrTYWX97YYrnnKGrePgTt37V63mR9afKdElK2yDj1zKDeslpMBwMP1L uFYAhAXRbUSTdaYoVYJtvkDw9ttAFe50lhXQHvqEheluf9p0YJ__zTiRc5_HBQwoawqWUFCykkfP xniiSsyVLHNOoXiG_burO_pWf4e1YLjgQ6fOVe2iQmBckNXedwUo7fJpSxd8c4Nua7NA4gFr7IwD 4xORIb.AhYqzeg0h2dXtbSFHOL3.kqb3twiRDwJL8vKVOyCOmTATrmbjcTnfpqN3T.u7vH1iOUVG AvugOi0_WPUJWY1tJX46V6c67QPDH2tb.kCGDwr2egAJ2hvVSaEeDlyhhLcSw57KZoEnbfjeEJqq 51N.zLnL2fMFXo9bhjFq7zfdvmyirI..jT2V0vLN4DWE6i7EVy229q5Jg1a0WApDALUcyqJDYjYB 1HvMizW2ZVC2ssVIaAlSlBtAaPe7L6vibSUmHMa3QQNpBsXi3jSJGtAhfKgN0NSrOqKtxSs93GaB NHwgs8oIuzg7PPbAzc4suU7Mwa7e_2QDSG9gY7GJsQ6PNtfPN3OU7zc8dCvXt4C0AwLDY4SXdKjv Xeesd3_pSENQVpic3_91JG.jXDIyfSWf8TPv26XqcXTwYgmOKuqFzzYCqXmMEGbt22Bh913fQiEp HclkgZPDlzkKjLvdOFbszsPchbcFARzSQUAuBGsPSGioaIE3e3SnYNM5a1a5ipdA.qNw6dmvzFSG rTZNXqk9LwtZioDqZwAPece2ZjsIwI_atjWX34Jf6N4jVXH82s7INj0tpVG9uoL2K0CqxXasMLsK Bno6oWqgLIv4fNyUK7nvlelT_csrsKOLYVh6AVlrL1AGyfnT2N9pE.X317ez45nZsXMsAnZIRSCs mfmt2IEc.go9cRX3TXALUtB.X7c_kp1.MiNhHDua3eEA6EKFjO9Mq6bRIwVz.4SaPa_bQqhTdO1W c0bIV8ZkxOmntFqCpnZc8KfslCHC9EW_Z4T63c1x1YBbA82kNg.dE0Jl8miI8eC3E6O1Font9iVM r2FjUXZjScvCThvqxkxIqJdISIN8.LmVYuWS08scEhuevuo1rJOKz8NYqKWTALgcQFiDEVA78I3E 8VKHOEaP3r1XiD7oZR9A_E_azvjHOL6fQg4u5Etwo3S22s8iAaGiKYlBJPL4K2enlwsA_9gHEKVg ZN2b_fPmjh8DzsaQlXoN.1IPc0XjVxdrAXADLX_NQ2iQiBJHoyJapav2xAp1BfjcEBv4sT786wkP AKkKi3n2KJr2QknDTd7FQYscbJBEdcED1gAIGg0uuvOZId8YiL2wrHuW1Y..BLWpGCxIECBrrc1i B4JnGBgU5tDGCMpSeaJn0yOoLuJpoxJvkTlP.rRe2zn1YdG6hfTkoTMiR89ZMSZR..H_w X-Sonic-MF: X-Sonic-ID: 489ee32c-88d5-4fb0-915c-2bce120fc2ba Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Thu, 31 Aug 2023 11:32:53 +0000 Received: by hermes--production-sg3-69654d8bd-cdvp5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cfce4b2e36ffd061ea0ce6c5e1c4c922; Thu, 31 Aug 2023 11:32:49 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <83msy7eesk.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 31 Aug 2023 12:34:19 +0300") References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> Date: Thu, 31 Aug 2023 19:32:38 +0800 Message-ID: <87pm33sazt.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 650 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Davide Masserut , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Thu, 24 Aug 2023 20:32:47 +0200 >> From: Davide Masserut via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> When Emacs is built with PGTK, frames opened with the >> emacsclient.desktop entry are opened as X11 windows instead of >> Wayland. >> >> This patch adds a sed command to the Makefile that replaces the >> environment variable "$DISPLAY" with "$WAYLAND_DISPLAY" when built >> with PGTK. > > Po Lu, any comments on this? I think this is the fix for the bug I couldn't reproduce earlier, bug#64310. The patch seems appropriate, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 14:43:36 2023 Received: (at 65509) by debbugs.gnu.org; 1 Sep 2023 18:43:36 +0000 Received: from localhost ([127.0.0.1]:33871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc97I-0002lW-BH for submit@debbugs.gnu.org; Fri, 01 Sep 2023 14:43:36 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:54726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc97D-0002l0-2j for 65509@debbugs.gnu.org; Fri, 01 Sep 2023 14:43:34 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50078e52537so4200531e87.1 for <65509@debbugs.gnu.org>; Fri, 01 Sep 2023 11:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693593795; x=1694198595; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dopnW8nZWc2qr9V6vnqhknaLOz2k9KE4qu4gub09jXE=; b=UrsZb9dzZE6t/e7RzDPka4ICnj/JrbsaC+hHe3ZeXcnWV8tBAWIg3L5hsPW3jcK48x tzscNCi6nFqeDXqPzekMXIyu28zuq//VZGaSk8WZyQ56gktlkf3fWv05JCTynUj9rP2x DCOmg377NJ6Oa+Rc8Lo3HHpqwppIbrmPbfR8Pimv/56x4AP8ps9i/sy66tQyUdnd9ZcQ HzmqJyVcx/SKyshnfrTdsXHVUbQzz+4o4YlWuM3L62zlxzSC7/U6rRjJ9QxsfgYxu8w4 Dl0QpPmlkziCJjKw4iFq/gBf1Xwi1mdavZihHgtXnjE6iTjLPVUh8IFX1x7tm1gBCXAE L5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693593795; x=1694198595; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dopnW8nZWc2qr9V6vnqhknaLOz2k9KE4qu4gub09jXE=; b=KN+7mx7Fz3gLLyVNzQO1wZLZyH57hbUZkiAKuZ8PsPuZjqkhAPflDhLJdUKK3SvbuG i/ID7rkuCZOT0x2qAMCHsPbsk30JO0UMZdjTPvyfRT87v8Z23iynn+R90+s+RJhK1mae jqpEaDMcJtIUfdQFWtnvdm7YJY2deediooSgR9qU1vuPX6juk0YwO2Ho/bcWTuFLVchd L5eq2k34/jtx6fr68jm15i8HchTYO7/sZ3mNht5zOsdi+hcfc5W6pOvGHP/9KkOGEpso FoWWg9AocGClGTdsdm6T/ZQupmYYUjhmsTMwGa2x1Mh5Y3Y8zi6ayyMJ93ALvD1ZAeXT Mq0g== X-Gm-Message-State: AOJu0YwJZV6xcW7z4KKsvFT7/n3wG8q/u7ckqLspm37QqpBqzB/Lvy9Z m7N5+ETdIN/Yoiw574IUysTmc3iCamYEq5szGAc= X-Google-Smtp-Source: AGHT+IHDA4S/JdcnKDvr7z9dR6xAXRCfjm6HvqtT0s/Kb336eLdLN7A4EW5WkGnowMh77pVvasGb5yKi63zheKrTnhY= X-Received: by 2002:a05:6512:e9f:b0:4fd:c84f:30c9 with SMTP id bi31-20020a0565120e9f00b004fdc84f30c9mr2585289lfb.47.1693593795104; Fri, 01 Sep 2023 11:43:15 -0700 (PDT) MIME-Version: 1.0 References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> In-Reply-To: <87pm33sazt.fsf@yahoo.com> From: Stefan Kangas Date: Fri, 1 Sep 2023 20:43:03 +0200 Message-ID: Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries To: Po Lu Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , Davide Masserut , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 64310 65509 thanks Po Lu writes: > I think this is the fix for the bug I couldn't reproduce earlier, > bug#64310. The patch seems appropriate, thanks. >From the previous discussion, it seems like we wanted to get this fixed on emacs-29? Eli, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 15:05:56 2023 Received: (at 65509) by debbugs.gnu.org; 1 Sep 2023 19:05:56 +0000 Received: from localhost ([127.0.0.1]:33951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc9St-0006AH-R1 for submit@debbugs.gnu.org; Fri, 01 Sep 2023 15:05:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc9Sr-0006A3-Al for 65509@debbugs.gnu.org; Fri, 01 Sep 2023 15:05:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qc9Sb-0002R6-OJ; Fri, 01 Sep 2023 15:05:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=imzsgoRAWM5t5kL8kogi7hahvFYMGBihz8GdmuY7Y/M=; b=dLrrqfMOKAb9 YX0/XLMI8mn++NgP9aRnsAQNNL/5cEKPSswKPMk7wuKEWLepI0MTJmeCVValfHtiTV7Ux0qh+7jsa DMUNkCV3Ag3HFQ7OOAQw8Pjbu215CUL20NARQIIDRQSNq3yo+lWu37VhfOV+EOyIk2qrSs/iGhEHv ToSBpGJZLiyg9Ux+xZUJ0kZhTeiX/KUW7vxrFPcdlXSUfBtdNOn09GL/J+ovdS2rvZTpQtBi1f42S 7AJLHkR82t6OMtuw3WvOMgDZ5uDR1JzL/sfrRukwjESMaj5EB546hSUebzw9tquALJXLOp+RK9Le4 M3z0nwpMqkERRrbhRMvo/A==; Date: Fri, 01 Sep 2023 22:04:56 +0300 Message-Id: <835y4tbtpj.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Fri, 1 Sep 2023 20:43:03 +0200) Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65509 Cc: luangruo@yahoo.com, dm@mssdvd.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Fri, 1 Sep 2023 20:43:03 +0200 > Cc: Eli Zaretskii , Davide Masserut , 65509@debbugs.gnu.org > > forcemerge 64310 65509 > thanks > > Po Lu writes: > > > I think this is the fix for the bug I couldn't reproduce earlier, > > bug#64310. The patch seems appropriate, thanks. > > >From the previous discussion, it seems like we wanted to get this > fixed on emacs-29? > > Eli, WDYT? I don't know enough about these Freedesktop shortcuts to have an opinion. If this is installed only for the PGTK build, and you think it solves the problem, feel free to install on emacs-29. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 12:54:34 2023 Received: (at 65509) by debbugs.gnu.org; 2 Sep 2023 16:54:34 +0000 Received: from localhost ([127.0.0.1]:38505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTtG-0004n4-Rp for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:54:34 -0400 Received: from out-233.mta0.migadu.com ([91.218.175.233]:34049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTtB-0004mq-Iu for 65509@debbugs.gnu.org; Sat, 02 Sep 2023 12:54:29 -0400 References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1693673654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vECKny6I+RztVEB6dNhoHYla18T7k5LnsUXVTIVL9XA=; b=fLWpSNlFAIyKKmR91BWzdvBRarCC8K5hO/c1H0hUwZlK9MDc5ciaQXXpNFsCZc7KiwiY+a FOPx9KMqaY1f8yeMy4LXgEFjuaS9H5uTix34/jVO7NUnJJ9A99gRHY+ZThExbxuN3Wu4Fn EmMpH0AbhGsS7b1DdfTTQ+2BZXHkPA7SCXT72kAdKqmCwh2Ftby95R8q8+OdM1Oay96E5A HLJ61CVSau95q+AHxpbVxu8QGDwL9U47F6JQXv9D6caX72EQbu4fsAf8ngdm8TUVt3iO/q LlB0nsuSciJtE2+HpCre0dt9sRQNe2v0lO8MmUQHJD64PRCmXjISuVBBfpbLVw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Davide Masserut To: Eli Zaretskii Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Sat, 02 Sep 2023 18:24:43 +0200 In-reply-to: <835y4tbtpj.fsf@gnu.org> Message-ID: <87pm303499.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: luangruo@yahoo.com, Stefan Kangas , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Fri, 1 Sep 2023 20:43:03 +0200 >> Cc: Eli Zaretskii , Davide Masserut >> , 65509@debbugs.gnu.org >> >> forcemerge 64310 65509 >> thanks >> >> Po Lu writes: >> >> > I think this is the fix for the bug I couldn't reproduce >> > earlier, >> > bug#64310. The patch seems appropriate, thanks. >> >> >From the previous discussion, it seems like we wanted to get >> >this >> fixed on emacs-29? >> >> Eli, WDYT? > > I don't know enough about these Freedesktop shortcuts to have an > opinion. If this is installed only for the PGTK build, and you > think > it solves the problem, feel free to install on emacs-29. For the same reason that the current emacsclient.desktop doesn't work with Wayland, installing the patch would break PGTK builds under Xorg because they would look for an environment variable that is not set by Xorg DEs. Sorry, I've just noticed it. We could choose to always open a new frame instead of reusing exiting ones. How does Emacs behave on other operating systems? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 12:59:28 2023 Received: (at 65509) by debbugs.gnu.org; 2 Sep 2023 16:59:28 +0000 Received: from localhost ([127.0.0.1]:38514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTy3-0004uQ-VD for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:59:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTy1-0004u8-Jk for 65509@debbugs.gnu.org; Sat, 02 Sep 2023 12:59:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcTxl-0005mG-WB; Sat, 02 Sep 2023 12:59:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DqEp4ySByk1es4E7r4YxF/7yC/1LHX6jd0jV4cwIV9U=; b=AjW0bH55EbW5 C/INyw1bsXONvCCCfxVBorzcCGfZVgPRwSRqiaZKIIe9f9UmjdpqjFmD8vWX268NAW08apN7NAnpp lG5cMfq8lzEc5gwX98BZlOryBm7o5MNIrZ4qPkFMR3uJbkpGNsp46LwR8xKsIeSboUmvVZ7+NKP+5 8Wt3+xG0lF0/L1gc94hkTDEIpuncPd220qGkj/jlxxzkKC6e7MTMnMKNDN1LyIRGQ2IrT9Ngl4AfQ r6jUEMLJmi8lK2zv4qr0qFg26P3PLNxoDzc3mf9f3rEIZmcM2pGv0SG9xehbUMVmILf+h9GH0t4fD B/YUMmVnFYckyU1K+DF/sA==; Date: Sat, 02 Sep 2023 19:58:57 +0300 Message-Id: <8334zwa4vi.fsf@gnu.org> From: Eli Zaretskii To: Davide Masserut In-Reply-To: <87pm303499.fsf@mssdvd.com> (message from Davide Masserut on Sat, 02 Sep 2023 18:24:43 +0200) Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65509 Cc: luangruo@yahoo.com, stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Davide Masserut > Cc: Stefan Kangas , luangruo@yahoo.com, > 65509@debbugs.gnu.org > Date: Sat, 02 Sep 2023 18:24:43 +0200 > > Eli Zaretskii writes: > > >> Po Lu writes: > >> > >> > I think this is the fix for the bug I couldn't reproduce > >> > earlier, bug#64310. The patch seems appropriate, thanks. > >> > >> >From the previous discussion, it seems like we wanted to get > >> >this fixed on emacs-29? > >> > >> Eli, WDYT? > > > > I don't know enough about these Freedesktop shortcuts to have an > > opinion. If this is installed only for the PGTK build, and you > > think > > it solves the problem, feel free to install on emacs-29. > > For the same reason that the current emacsclient.desktop doesn't > work with Wayland, installing the patch would break PGTK builds > under Xorg because they would look for an environment variable > that is not set by Xorg DEs. Sorry, I've just noticed it. Can you describe the issue in more detail? In particular, would it work to try several variables one after another? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 20:59:38 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 00:59:38 +0000 Received: from localhost ([127.0.0.1]:38944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcbSj-0007mz-Oq for submit@debbugs.gnu.org; Sat, 02 Sep 2023 20:59:38 -0400 Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]:41622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcbSe-0007md-F6 for 65509@debbugs.gnu.org; Sat, 02 Sep 2023 20:59:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693702756; bh=zsVyAKKhbj0Oo2eUbcKvrtjvhlUynsH15DylIWN4dfw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=is0kfFd8MM7jPbAWGGVFYzVF1KShknO0rYAQJSjMO9K2ndehBCjwEjW7mo3NbKOH9wPRXG9IAkiNp63M0TsDKkipQ6aylyTWA3jdb0RvVmYWYuKz8LzG4Pw4OvHs+8JE2qMTaYEmKaBsi95h0+Cu5apQJ7KjZSGz+hFzW695fQDbVNclJlNdlkjCW59dvP5dZFHBaSDbmMq9BXmaQv9WaE07V9dioZSCSucmdNlonx6iFQR4vi7R5eXy5xVrBviy7nF/wUG/nE2Xe53VDscpCKB/9E/o+UW1/GOAbLGT+3muznes3JJk9rbpM7zJzy57TMCpP454lPcxbSgV3RPoUw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693702756; bh=NQdkHuKZuRplobdReF8XWPfUPE9tIHscpbUEL3a81TE=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=nHeQsxt65Rs4alMsFo10Qwf7owuzaT/RM+YITdNDGyaRbIVhaBkPlZXpr+uI1UfWBIuExJKpNM+HZMEnXOXB6bqph5GLlmy6H1WBlKlt3P5peiT4wLWy1FBoEnLJnbiS1wNq2Pd37J7EjQr0lKVk0dQYKtZ4Bf0R4Rk5eFXqQqcvvAaLZUSFTZi80UtihZ50dkon8atXdtFGQkF/HsAo7FiNuXsPTlWPrHBTYHdrHFkjvawg7dUrcnTqUt/6aWz/qDJCkjTVXOUNymtu1F8VxWuE3DC3dk/TixHN1mcmHDtG5qGpePDTHBafkYiNuJwmfmGdFz9UIIgvIXx9dwjhbg== X-YMail-OSG: iqN02pMVM1kunk0Yr5N_4j9cwSHIF4qItKZOjAwIhWugJEJY_hEgcAS8mygSOeY 9tOdG.qD7CuwhvRTiUZDTFbJW0oLqPyKn_zkupqZOWfngbRGTaWO0WY43I5RfOQFmxV0Zp35S1sW g.dg2xI3E8NGjFqi7kSgIJtGjYEs9cSv499qka0RhItqAR2DqMCTbEpSqSkycDS1n6dulGNDirtO 9KT3RJPTqEePRXi_6zYNOT1K3xeDzkTEJWya0p9mbfqxC87N.tru0ZJD7thRfkX3L4YTbqQg2Dhc ZTcnkB71lynj5KGVkWN9DfCTWmYj3lRkqZ5AF3PcRocHr6SjDTjz42peKkaLnycQp6yphfgNCc7V FNysLv18hHSHp07_mbRZjwOJnsOWgYN20FHbxwjKIzVOUIxEpy.UN6M5dGTRff4ySdXLFJXSPQE4 coe575v5EUnMcPmjrUATvJjDMTg4lTWr8HWm0D9_Y8rzmTyuBTmDSZHXtbupqMC0ry4ykTEk6dVj a5sUFXgrgtPQYLhHoJ_omUjwRN8qUlruXrbSTCtQ9EVwL_Tul62LGKM154KddxC1hnxt43JMxW7Y 9yNubVnahlS_oTbyYJsB.wNmxeL1x1HIcJVcYEsYp32i4d.XgLTZo6xOPSUCmmUzwPzKR2F.J4La Q.86d535jSX6wccyT4m1FjUJ2vfWfcjgQoNGU1XbmA1oyqoXNhwncJ6BJVeyJhoxU78.jGrVLfyo BEebtMpqkU606OpjUHbW3CP2mXXqe3q.KiH9vuAkN9ojt8ZzxdHZDfdKqERoRnsUu6XA63jyV19i 71o_.pKh_7LlIYKPjQUIKLRQEl6YABOG.2GqWivSgCJdidtyEajVV03u6jibnHgPQwLxQhjpmQaF SnGtVFyxI9TLb9qjCUXLZss9uH7Q9TD5ov1p9zzeIlUcTI1n1.YPkPeQsNx6FaETs86w2029LOqI sbSNhZiLh6MNIxBye1EDeNheoK_0GEwxBt_zXdooaTLIGnrm4AHVCIyuH2JQUZ0FLQ002dSvQE3D cjYf.J3ig7IiE4Nbxl1wQWxJo2gdL34Xh1MFRNLYHvKfdWSjOMWJGrE5ypNmWl_XWcYeQFSGZ0Qn aCQCx4NsnwVi065OrkGsaoiCsF8nZtH3NnsXtdPbU3902yoO95M.dFwrRbMjGXtvqSo4yyor_sSM sWZQKLNhsCmu1rE7hV6Rgo4aL3cRvYUpv5g8w.T3tNaN5DS8xlC0DwYgvovTcC_qwQcHZbIyLG5L KK7zXpWGrtFw5nyqdIkPQdwR4gclje719hsFNtsEJRwcLbRXDJjA12BLCRvhK7EPq1NrpTP8SUvL tOU5dxI3IdSqKWbRZQbNr_FvFwzt8.ypHR2kGSgPhxJTlyswFc6NM4XCMEwzS7qHWCZRpFMouvmy Rmt4hTzg.V2LSRwhgakPlUqoXaib574GFUuIm080.9fUzl_yo7vcow00GQgtoEsrS5cNwVEYK4px QFEXSzn6_K4oPrpKHQxDUlM20n3IkCkl8pRg.S3YZuOlGYE2ql9iJShumaVDT2DvRgkJJrBkns8J GVgGdbhL2fxTUgHC8uMmmwrkxRcNId9GbQXWiTSSVEIOmVcSBijH02YznK7D0i5v7yV5ZEzb.WOo C_EgbV_KpAsvzfDJtxOAa_cJgXvp3D6828lnc7XqPlD_EJfnUeiQ5PGtJjKJ6WfmlwmZRuKgsJfz 5FBgvlGQB4wrZvSR1PuFNi.TBYr08O4uZyY5k0FfbVAQ6bDpDnlSkhxbeGR._WOQD5xYa47z9tWA keKp_Ptees5nuSCrpYAAXgDO2mFK.bUtDbuRL9gY1UMH2m4TSEhl4PazoVCVR3TAzJi21YV7DNtd xRkb1FWWD1SfBrkMpxjbYW8qj7h1oqRdjhUvUBwZJ73Po7XLk561u4A.VTGAkVkiO4wjYkSOeg67 IgwVWJV55MnjhPSHQkwBz7d7tSmqBg1glBYQ56J1U0Gn9KLKYF.jok9ZkD5DtBDGlDwfHAQfUIKI .4A19gzwHXnwSAz3ODziHj13sm6fatgcbqfsabwvzMGJYFcDBEvPvuhMBnpnlwIerPAIaJaRzo9T kpOftMJVbcPhoTXPhxi9w07Johfu1_uy8I._q69VXBwKpQRu3g.iGFqDgdDB0RaXByWVQdfcDJn3 _FIDDfQFmoN5KREEcvumIO6Cnvt9XW3iZZEHNB57l.lW0XZrMNKMEF71.bUMYAobOMldDh8oiEGl m_I_fNsIPg1zUrOfxXdwnVpHQJJ1p3Y1oFv7YOrFXTKjVWTw3ftb09w4OPvMSJaA4J2KuPnE- X-Sonic-MF: X-Sonic-ID: 0ab7c0a8-6559-4674-baae-06580e6ecdc6 Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 3 Sep 2023 00:59:16 +0000 Received: by hermes--production-sg3-69654d8bd-7fcnj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6163b325c354dccd9dd41d304d33f8b2; Sun, 03 Sep 2023 00:59:09 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <8334zwa4vi.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Sep 2023 19:58:57 +0300") References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> Date: Sun, 03 Sep 2023 08:59:04 +0800 Message-ID: <87y1hokr6v.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 489 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Davide Masserut , stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> For the same reason that the current emacsclient.desktop doesn't >> work with Wayland, installing the patch would break PGTK builds >> under Xorg because they would look for an environment variable >> that is not set by Xorg DEs. Sorry, I've just noticed it. > > Can you describe the issue in more detail? In particular, would it > work to try several variables one after another? PGTK builds don't support X anyway, so this is a nonproblem. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 01:34:58 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 05:34:58 +0000 Received: from localhost ([127.0.0.1]:39072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcflC-0006WE-7L for submit@debbugs.gnu.org; Sun, 03 Sep 2023 01:34:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcfl9-0006W1-Nv for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 01:34:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcfku-000328-0D; Sun, 03 Sep 2023 01:34:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tzSWNxAUsK9UA+GOpWChJepxIGyrq3vkwhJNyMYZcmE=; b=dy5evv7+npcj AX6K1a1/QlfKRlAnMgcXqPBnU9JvFc8GIOvEiHf2AHYvSQwcuZrqjBbzEKXoE8Eac2wO73O6xZUyO fFE+s5X8NFdDCT9MK1gSFZFViQy0pBy9QflNYB+60bgFzSkp74qZm7/SVOB9pdhZIPfgk1uKkmV4u /ft3MlC99lba+7WAtCXzsJYymh0W4cpPMU5EDPhw4dRAvYPjDKo3/59TwLtIVNzhFuYK/yH/PLONT a4WFdFwd0gbJbrOuB++iGWpbKCC+YB7gAroCx/uHQaBNY4L396yunWP23dTYtlmdRX82MzwuMYloq 2iwze0NzYy+VnnoxccFoAA==; Date: Sun, 03 Sep 2023 08:34:21 +0300 Message-Id: <83jzt795wi.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87y1hokr6v.fsf@yahoo.com> (message from Po Lu on Sun, 03 Sep 2023 08:59:04 +0800) Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65509 Cc: dm@mssdvd.com, stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: Davide Masserut , stefankangas@gmail.com, > 65509@debbugs.gnu.org > Date: Sun, 03 Sep 2023 08:59:04 +0800 > > Eli Zaretskii writes: > > >> For the same reason that the current emacsclient.desktop doesn't > >> work with Wayland, installing the patch would break PGTK builds > >> under Xorg because they would look for an environment variable > >> that is not set by Xorg DEs. Sorry, I've just noticed it. > > > > Can you describe the issue in more detail? In particular, would it > > work to try several variables one after another? > > PGTK builds don't support X anyway, so this is a nonproblem. Not sure I understand: you are saying we should install the patch and stop worrying about breaking some other configuration? From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 02:07:56 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 06:07:56 +0000 Received: from localhost ([127.0.0.1]:39088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcgH6-0007cH-Hy for submit@debbugs.gnu.org; Sun, 03 Sep 2023 02:07:56 -0400 Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:37892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcgH4-0007c1-Cl for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 02:07:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693721258; bh=zzN8XvCfyf0T7ur5X/uh2sJbqUXHy0viqIziHvS+uV4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=pW0H/N0qujal9hmsoXCBw6G6XvTipJ4TcgCJjEzFdZ5UyJc9Sp2MtIYkUjRbzhlc9RwcH+YjygZTRBHtm1re+enNxYwT40Oc/LGvyfmDDJQNbmnis9XATRp5vp05pMi4KGPdWs+a2HX2NuW4O5TolULfIJoUt/y8esWzAje1Uqt8Yj0m7/KANss8oXE47PvIk7uUMZXs8UPM/Cu3XluoDcOGyGU4fXXM1p2DsPNca6st2GGpcvecbHL+adpIZllyS8FbKUyLXW2KY/8cEFmW6846zfycc/NVHRoy6miT3KBhm/MnMI5ATXD9OJjacCF/fft5mznC6msrxQUGgZiLsQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693721258; bh=vGmQc1EJhXMZFhY2yeREtzCkoH48G2Rb0QJ9eR1KQqB=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=hnPyeKZ6TM+Z6hB5vOngQopSyc0L9RDk1wBg7rKdJCmOVSukJ3ux7SpiV40VHIf6fvoWy6TYrkdegId5TOD0dNDMZgQ2Oi4+gEQXpFsrxJ6gX7wWPAm5HAqi0aK/FDixWsPB1nVSpMukkICRIvjtP2jYBWw+n4YROVerdvOEWH/ldJElJ8fuzVOsysX+0ADf+CGepzdQIFXgJQ/tPwjx+1RglnnW4+wzb0Q8kZTY0pUJEB/8vlxOT2QV24p/q1miWCHC7ITgOzcA4mtiOeKeTJmiYMvQdzGz6rscmuaspx5vy0SUd2iheCb1Ufk93ZmarTTvWDo8/isDNf1VwE5tRQ== X-YMail-OSG: BzhgVuoVM1lPKoNq.y0p956cCjt52LWcssmnNX43JNff7S._3tsrLZe4ghWcduI sTTFhg5jUXi_yDaXsD9mcXmnMOb0A_NMHq6416e_ZpU3Q4zejlhatiQy7qC0HBXn97NYUkfcBTg_ WYq2if9zm109.Mj7UGAKoXe6.Svvjs8xmBGWR6ycSL0dR_jHCrqQ544WuqaayMcfTtlkG_MkJfIv MokQ3.PbNxNM1.z_ua20r7Uo85akUukvPPfw6ThhUCHfZG26bGUk4M2yMzTh3TsirKLds19jbXyy pWL4FNG2c1forjMsp_kXBWOWoD0SPu0kfszg6UWltw3jnR2hS2W0EirWGFXmegNQa5kpCjNEemL8 KvSkqyqi2S9ePgYF1uR1oF3COzHnf9xp3F1tJu.7jb9_PrqP9G3Mco14Ta6cDZM_B3p061Ch0VA3 mhcMmd6x..dAKQfp0M3bl_oNGqeUW2OM7oSoukoJCGTdx1i6Ju1Vrtf1XyXo1hP0_WmsExktoYe3 J65kYrcAtbPidc2R4jn0exMcHej09WSAiN8KYYdMQhXx8gAwyBBeDsVHvdPDxn9TC_fIKn8Pd8HE hC5XBc6jMTdrozXzEPfzQKvyBKceKxh2q7qdsWhlg4qrJLw3OdAgO5kFUkoElNVSM2l1KY0r68rk hSQZOBPMwJjHZQFLCNMTVdnCHBRZFcpY5L5u7K03GUKIGAKswJoMkzzJcMHvEJe4mC53blDRp0pz 8u3GI_I9SpC4j3YY_Y4t_DVF62QnsXzv8txcCXy21dSFOwNI1fdtUMiij1LPySsFtr_os6D.pvAk llbMmn9qrEfi9W7wIPSKhotTihABscdPQkqqFKgur6ZS4oXpx0c0p3XA7d4UME7CEItC1y1.QXEz Nr26IU0TYwdxLwBx7RyLMEYL9ChTBNw_wqXRGEuPI4wbFHMgdDmqKBCsNIIOiE4AQwTc6gtl1mIl 0bIy.yMqP89zbnauhd5oneLmeJqRdRlKEtuIkwWiUxueAVFdwPp.gH9DAlU8mxPuGwcWvivcwTvL FrS4sJPWB7cwOMJoJ9BEgtzeD3R9_8DwWwJXIvgZzZ1XA7CJpYwGIkMIQUO1Fej.JmJTUQv9iBMk vPmZKiB8NpZx24Y0hXBKBbw1wrNbRt8NTtpmRHdQ8FmGzzzR1rnL1oMAnuerGiZT.ULovNN873Gc WkYO4oZTGZ_JB8Jp8Vi_HOZtka9DqAOczDFlcS8fC6SMlIcK85YVZRwFjXGK_MN.B8qfMk06qtd3 AAZDmz5rMhRobjMZcR_JrqyveSijHfOCLy2UZOrdfGg1UcN2d1n8wUlXdQawSbDb7Tdn5g4B7hiO DM.QDRimmoivKTkkxfc7P5jG2SMuB92fym.rbmn4eayAQjGFTrL0EqA6PM.xvGTqthZmuAeOd.HK _1kehYi4RQe6HQPHA7SXHTo956yYS56mkKlRo4iGWTcz5dsBylyeyjkBTzZ_NgsEc62790yYO0SK vgKs0jyeewBn4OXAwG_bOS1ReoeR1fAYdsjv2CkZ6kpQOa1M5i7g5o1G7P.QZAndQ33DD1cI7BAo eGOGsM9FLjk07qQJ1zbdbK7OaMWZ.Yb7ij2LWAsZ8iJ0xMWNCoEtabM6Ki4ciI6LftE_EDs5Sab0 VgxUbmFIxThtVx6v851Bq.CadZXvZuTZxNW8tOhZwACFVnwWlfwqe7EOHrm.Jmj_CU3Or4t6gyYi vT6208aiNFw_1mcyM0g.JRopzOxpNVkhySAsGSz40Dzj2.1n8CD0CfMRnMzHRXss7AV3AO7NtEyS J4YnGMFAG4R_3chbM4xx1QYNLT9fHGlhwMz9YPXroyRjVK2hjpOFVGPzyvrZ5kSpZPIPkNpyo3ZD kqf7IqUwaWleAiT75ltsDEqqlJiDhfiMzwnpeK9BmrLvxGQYBC7CMON7wE2l6wj3miq4Ld6nlx9x oKjp2eXpLWkBOGMEvyGJsJRxcf8KRQt_idvq4fxEIIsIRNQlsXN4gb8CwQVxj.0VkISInrE8XugE XZfKgor8kTHH2Ub2KQO7b9wkQFTgayqFWALy5er6nOOvy.cwH33bnVfgTqk_lYIUAtyQHMyjLW0L fluwuoumGSxtf8D8YnMfXqRnk7jNDpRotiYFztEvD_nCJcghRP9Wv6ITE1P8C_WevzEndmaHCFf. Vsl2aFTZ5nDEtymGEtvzwifIEHqifDKesxsJYF2RpvqMj7JcoWRtiuu_2ogkB5h6KDnkYa2lFv3c qO.S4I1LTtOrMCae6m718wrnQYSAelvr29U3LjbjDb3cXe6kPv8SeLiiBDnekPXK_Zdn1Fuk- X-Sonic-MF: X-Sonic-ID: d9a5ee08-4ca4-440d-a006-1335bd2a00da Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 3 Sep 2023 06:07:38 +0000 Received: by hermes--production-sg3-69654d8bd-sbrjf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7be7456680b16dbf44ecac6bac8aef73; Sun, 03 Sep 2023 06:07:34 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <83jzt795wi.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Sep 2023 08:34:21 +0300") References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> Date: Sun, 03 Sep 2023 14:07:28 +0800 Message-ID: <87r0nflrhb.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 181 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: dm@mssdvd.com, stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Not sure I understand: you are saying we should install the patch and > stop worrying about breaking some other configuration? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 08:30:13 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 12:30:13 +0000 Received: from localhost ([127.0.0.1]:39911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmF3-0008TF-Gg for submit@debbugs.gnu.org; Sun, 03 Sep 2023 08:30:13 -0400 Received: from out-227.mta1.migadu.com ([95.215.58.227]:20551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmEy-0008R2-1h for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 08:30:11 -0400 References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1693744196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QJFjUKfPmt/MpqSNE2Vt6HpfTBDy85mEvLxtTbC32QY=; b=f5SjP3kArAZOLTaYRuL4t68oSqxKYJlIloRt8r9WAJdC7s0bvSCfs79u0Ay+AjL7raWpFE +rj8aeiRrh1EZwaL9qWAJcNkZLJTYnkoHe2IRujL2+elYTEfmgpsWc6EJTVwawMZ4339h3 HnXoZddIO/pVyuLwnRyWqOa7F7HWu0rdofmZdGz9nix+rvgFqyF7pBi33NY2IRVT+qLDiB tJyEcqSpUBXPC0JBGr7cO3NbRuKjKHXJ+4JiZmdkxdmoQlTft/efjI0V9rMsz4rsBb8GNg 4xaw+/Famm9S2h9anhkFImlNh2vhAGEVRYr2qedC+Zk48EvzKp4sCU62uDT80A== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Davide Masserut To: Po Lu Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Sun, 03 Sep 2023 14:13:02 +0200 In-reply-to: <87r0nflrhb.fsf@yahoo.com> Message-ID: <87lednqw1v.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Eli Zaretskii writes: > >> Not sure I understand: you are saying we should install the >> patch and >> stop worrying about breaking some other configuration? > > Yes, thanks. I think we should print to stderr the warning that appears when a PGTK frame is opened in X. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 08:42:24 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 12:42:24 +0000 Received: from localhost ([127.0.0.1]:39927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmQp-0000JV-TO for submit@debbugs.gnu.org; Sun, 03 Sep 2023 08:42:24 -0400 Received: from sonic315-20.consmr.mail.ne1.yahoo.com ([66.163.190.146]:35003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmQk-0000J0-MQ for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 08:42:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693744922; bh=GlqfyxUlii+pYOcNfk9MsEUIJlbXki5sOe/PEL4dKWw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=BgP69VTh0nJL+UM2fc0HqEXYOmFfAf6HyRt7EZdqzBjNFTc4NquRvIGoT57mCD6pli5YVRC+fufGpTJaKcvi9Rq4NUNkfYBuEY6WoT1LqeMUnVZxFG1LjQaNX8Rn1+/Y4KEmLtDHn/L22/idYZuS6h/eKnvcIImEI3jeCUK9KlUTH2BsOukX1FQQlyXzHAaTIZBtW6MsonV7YuyHiDodOAaF6N7W81r0KQSin72XX7Q/d4aLucQGNJ9E2LPZumHyB6aU/pSwmQgLyBF2RHVV5uIKJQp21pIcMaN9rM1433EaJtoAXVs51+Tiyy/kGnvtdVJVXk/Gk9z8Uvf4fq5U3g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693744922; bh=DRLZy4YPIGKD7SN7xLNYrJkhG+7/hD6ICg7Nd6iO6Yw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XKji8x4JtdvlWJ064rU3CAuNb94QQGNANVVEo5Hy+GnRrVOIHfMUmZihnKUc98Wx7rJkpFK4bxWRvSj+FEesMKlaO9AwqOEmxXCSSe7kuUbSImyf/KFwPAV17Y3xk7rPS3xe0Lzi41k8FZMxULQIT0CkmaZMbCBifSDgn4bUloceOtUV5dF7xoaaa+PcEAt+xxA1UdWrsJ3gk5XwVZKry2JD/4i904gVU3XMprn3aY5aRYBbtXh4n6O2RcecdXIlaZy7wBl4JEFYrQNWAJK8NEkIPYrDvpKfmB0F9w29X/xxBgiZ5+suNIQO522BLKma/76S5pusg8aIdzEqnbsoHA== X-YMail-OSG: R5.0jsQVM1k8y8Jny42hpiSNkNvPuQttrhhKUPffumBI9Vm6rsLPYUyQZYrn6g8 H4vgfSvBh1LfjEVgOuwAmtrFLUefRQXNDKj_XmegMZGgULyQeC402WlHhqG8gtaxPymQwDmj_tZD XfMxvh9Wh3bqch_1l.WH_43y1ZIHFaJXCj_voOUddIIRHoW2iJpgh2uOj03qzQA7jC2ulj1.cOST dVId5Dw7YW_8CP3FVo8d5wOVWoTgQjUQ7XX3_uqeVjXtRweGkCMtAmBcYNIdPrD9ALyn_J1i0L9t JleSt1OlVth7dl.kh5wjshwsVgBySsEJeGqCommwHnGbPzi6TtMeBgywjiZOqa.uyV5NSPRMf7nq A_Za.NiZUbe8.XzMtRZGl1IpOMlbwPnUMRRxbBtyAOn7XPB0UfrD3DaIEjSuC65LBteDF0Cj8_Gr kehhue8n4GhnEkgVH30g7yp1S9Ns3WlXg4ivFEPgnrXvKbJ1f3Q4BF1ttq_x.J3fB8huvvMFce9o xIh1NvCh8I_pa9JJ.vGZ9I8vVGN2JlAXfJUfJfMjfCF_3Ky5Y4h3nkVfhtUGnBSN2rMlmllF4BFU LBlcxUzu21wjKMKC.CASV1aq.oR5vCKjtMSkSFZTfWBU4bfdqCLjHhWQRQPIzehO5YkZy_aWPGRu TeHFhd_iWynWkl00yb6UBYp4G0qp_8A_4ngTHwJGOxGaYJY5GXsDY_9NPY4GQlbFgunqdaLJdugU E21k1Z3sZBTg9nI79yMmYyAYJTv_bxSv6NmuEPY0y8FZi_j68dEFHGXSEab53UXDvq.scQBTcTVj tkylfDSFgtCjJG6Lq8HYNm1Xrow9_B7Dm7Y9rumsjxwGXV.Wh6V7.RZ4S4hQS4DK8rwNDbFvmhPs I.KYV2z0Wr5jvvZ1SHscPdzTqLTyPNFIUBRi5O0byaYRBbqL4WxycNM0cqXgf4tGZiqcYJdn4Nsn .1MLCykvDgHZFUazgWr86NWiZcqWsckf6FXpfyZxEktxMhxwMZrOi.pEUeuCr4iw2HAlnyzxIUzb lBmaaPiSIDwXFgYRB2LIlPkeoi1AGoGG_o6FA8uWuWWg7H9poUfGw.WZjxvWzV8QG6eCboWwhWiy n1kUH1EwdTwKlA7MJdswoM3P87Vt9W4yC6zYspYT2rpiIZk8qkA8uCYE0q2bm3Yel1Z0IMl79O8T gdLY6yrKNVehUbDpNrQVD8MsYjlUwtdSkkztARaDWiv5RFBxATNX.ZMPHZ4uNB7wJBRFNy2IIZsT V2haS3RMKQl54o2JnQaGsPImQaTL3tVV2jr7WIpIUBowLL8JywrL_6wzqrTPcFzIIoobcJp4KLj5 TkynSd5V2OIIQMEl6jXUUi5xeixjzfbrsGT0NkE2.UwqUdbEeaBKEvY_y1YEDYO8GwJom2PLON6E ewxRXS6nP00LT0gHA_zZi9oAFw.0ABSDEYlaCjtgSHC2JPp7.oh38mJ9Y1OK1Fx_VOCk6p5HGo5s wRz2C8lL3oF1hG9aqZb8K8r3NSIqWClMPTTHPNJmQ8.uMEQiTIZZrXRojV2J7JnXl1kZTXAUkenR QotRxdP8N9ImNb0V2p4iomJF352Hf_UlHk8MaygK6H1sD_mZNWSylTayYKxCvYCDF8gQHq4iXYp. WwO3lvI6EIuuER8FOsZZyuFit8mwGIJTtNAZWB_8pNaLJSTchG0NofqMILqwJ3PVp.9dWpEKiqx0 mYBQ1uTYMcjexHbFNO20W8UWMU6hzlLlJfBkFA8B4G4KKYDG_j04YWMs2zGGB_f44Tum52JPvmrR u2Iwsua6DtWjVTlJz4YdLEFNX1Y5NBTGBqdBzWEdqSb_Sf2156R2AGRQT5PX49R__zvQ7QAYcsi8 GBvOXaetjiRxBYR0_WouNOJJWirxoOwUdEEjy1NLEempsrRDo52u3Vxz4bL485jpvFGVpoLp_L3N jK0_S_pUDivXhMNLwpTQyymDF1gkSQoI1LtDLnZLLDA5g4lhmXZ3i6BFyv9Qy7J.ZSs8a9vhjMpf DlvNqiMCMlhkrjfSDObQ9sgTzM8xLH9cCJb0NFRXhjPNi8Y6pPewqexsw1BqTYvjs3MHFTeBZ6Qs iNmd4N1.BxZW6gbk.6WaJTX5EbRO2.a2P02urkBMy9t7kVumFqtWEQOBdSzJdE.OU0Mwwq8VnK7z HeI0v5XH0G5OL2hAhDA54HkeFk00VvVNdomr.3TG3B_R0T.qrNY1kqGXV8cya1XhvkqWntuiu8ON 33YBVk__CCMklXufTbcEqb5tfXMh6IFXH4en84maAcfsuQq7hgNUFf21d24N72DQn7Q-- X-Sonic-MF: X-Sonic-ID: 6a2c116a-b7f6-4bc4-8b1a-d395f7b16735 Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Sun, 3 Sep 2023 12:42:02 +0000 Received: by hermes--production-sg3-69654d8bd-2bh2f (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 37ab9a1b0fa8549dff523976a949d446; Sun, 03 Sep 2023 12:41:59 +0000 (UTC) From: Po Lu To: Davide Masserut Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <87lednqw1v.fsf@mssdvd.com> (Davide Masserut's message of "Sun, 03 Sep 2023 14:13:02 +0200") References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> Date: Sun, 03 Sep 2023 20:41:52 +0800 Message-ID: <871qffl97z.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 297 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Davide Masserut writes: > I think we should print to stderr the warning that appears when a PGTK > frame is opened in X. Why? It's not as intrusive as displaying the warning in a window, and we want it to be as effective as possible at deterring people from that configuration. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 08:50:59 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 12:50:59 +0000 Received: from localhost ([127.0.0.1]:39935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmZ8-0000aq-S5 for submit@debbugs.gnu.org; Sun, 03 Sep 2023 08:50:59 -0400 Received: from out-212.mta1.migadu.com ([2001:41d0:203:375::d4]:44941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmZ5-0000ae-8N for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 08:50:57 -0400 References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1693745443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B/AWeEdTOMPIzKmiovXbIti60PNyPsjzQXhvZqYK9Dg=; b=1/7ERR2usqg61YGoQYAvLttezvPeWAsG6EdURxB46up61Gnf4kxDJbRuju+dKA8/7q2PdW wgVQkuJX9ao1z9Cea1U4ynYpomLuDCqzqE18Ezr4GjsxKsWVO8zCrgIUiPYYoLtvVnxDhd BO6lozDg4V+g9+wdqMPMNlnHIPLSZ6bDAy7jCFjkAGOMQ8q9CFI181NEvcLIJrFnHeUhUR il8DnSJXDlboVGk3SxWOqA/nLsivhLHzrfv8kdQE+oOITPC/zESn5P9XREAQ4du1eiiHPN NzStz9xW61pfmHYnTY3OFe5xZAYkfiPJJcC8lgfTN0VPEaJJczru+ZBMxmx3iA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Davide Masserut To: Po Lu Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Sun, 03 Sep 2023 14:48:16 +0200 In-reply-to: <871qffl97z.fsf@yahoo.com> Message-ID: <87h6obqv35.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Davide Masserut writes: > >> I think we should print to stderr the warning that appears when >> a PGTK >> frame is opened in X. > > Why? It's not as intrusive as displaying the warning in a > window, and > we want it to be as effective as possible at deterring people > from that > configuration. Sorry, I meant we should *also* print the warning to stderr. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 08:51:33 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 12:51:33 +0000 Received: from localhost ([127.0.0.1]:39939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmZh-0000bz-EP for submit@debbugs.gnu.org; Sun, 03 Sep 2023 08:51:33 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:57833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmZf-0000bm-6s for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 08:51:32 -0400 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-5009969be25so958342e87.3 for <65509@debbugs.gnu.org>; Sun, 03 Sep 2023 05:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693745474; x=1694350274; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ChrDEWtYx2LZRIZR8Neu+AdIjArP9tZVvGCVpxZuLug=; b=AJ9XaeNpi9rVk7YVUYjcjSgR6mYZ3I1ccU9G3gpXVXB/1rtdLS7Zy9czEfpRBpWVM9 Riq0/XSeES3shRoy6pvBfGUtc8B41xGLm+iXO8UXBbxJd5W8QlZlo7Wt67djbEhBiPzP /r/r7T1+W0M9KAjRjAdbzX33jMdNbzKrf2JGz/MuXanPLsVgQg+sBEvDFIism8zhHynB /y//n/MCOK3NjCwcFiS7PMKakx1K+/d+V05XiEEDUtQ/l4YnXE/RWIamEf3KHAZjt6dT GEd32+STuHYHVvKQh5CiDE7W57vw85HSRcVureH9rJSjLMtvtg4kbT7g2DjpZoXai4u5 7FqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693745474; x=1694350274; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ChrDEWtYx2LZRIZR8Neu+AdIjArP9tZVvGCVpxZuLug=; b=cspn7ZqTRm6TiRrbmuLf6xQBLUXzeVn3Vc5CHu8GEA7V1mOxNInm3civvfPdZJzJCU p0X03LthaZajMIPjT9TiqDUl/UQrDQdiwrgWDhKP6X9J8CcDiimtfB806mTBEGYfGhS6 bSevW+wkEc4lL63D5M72tXWBplyQgdRyI5dqf9ToJLSqwFTKU+xm5hqqzlEkdasclX5g 6y4Z+QdDAsYkNh2ueL+9qqRhCo6zc9RKNpb4PwDnHzmeRFdp1MLB4w9XXQxmfjq5bDRd cU8g3KyDTtXLdboZel5rpXhvOKpNbtmQjZ1PHlpn9bht7Ahyl6euggocgZ6cZ3G451D2 ba0A== X-Gm-Message-State: AOJu0Yw4hZTu3smhhU6mNugbwXMZ/p4T0BnyrePfpPRL5v9PDeruV39S nhs5lnl1TCrseL/iLfcZbGLfxXMZxxHj4zw0C9U= X-Google-Smtp-Source: AGHT+IEEVJ0NabSW+iweMjcobByGzB//ytK+s5oBhYTe8U4ITb7OD+9spPbGTVq3JdjBqtLWI1lZiylVtYfHnag2ZB0= X-Received: by 2002:ac2:4545:0:b0:4f9:5580:1894 with SMTP id j5-20020ac24545000000b004f955801894mr4857201lfm.15.1693745474434; Sun, 03 Sep 2023 05:51:14 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 05:51:13 -0700 From: Stefan Kangas In-Reply-To: <871qffl97z.fsf@yahoo.com> References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> MIME-Version: 1.0 Date: Sun, 3 Sep 2023 05:51:13 -0700 Message-ID: Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries To: Po Lu , Davide Masserut Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Davide Masserut writes: > >> I think we should print to stderr the warning that appears when a PGTK >> frame is opened in X. > > Why? It's not as intrusive as displaying the warning in a window, and > we want it to be as effective as possible at deterring people from that > configuration. Not sure it's worth doing, but one option is to do both. Users that miss one would see the other. BTW, if it's unsupported, should we even show a PGTK frame on X? From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 09:01:13 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 13:01:13 +0000 Received: from localhost ([127.0.0.1]:39999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmj3-0000vM-Fb for submit@debbugs.gnu.org; Sun, 03 Sep 2023 09:01:13 -0400 Received: from sonic317-32.consmr.mail.ne1.yahoo.com ([66.163.184.43]:37369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmj1-0000v6-LO for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 09:01:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693746055; bh=CMjcsgoyZ7PT3/s9mpcNde5JmW/XXf6W0LM4PhZyD0w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=SZKkdhKu7h6XDQcTWO1uUwNRU8erauIdllZ57flHBwc+BzU5b9/IlVUvYdaeMvNwJG803Lmm1/O+zU1wVe9HRM0ugZMdjvW6A0KHgs5FYY6fKxz3HqjsolraP4l7j/W3V1g4PzRKHm4VONflQ4SlzVWxkpj+rhc2s1RSEd09BPg3fwJcFO7vIH8fOiaybKpLcfuIprXJSo9UNkAaTSYXOFqIXpWGL6rKug1ocy358N9xfDl6FZjxVrtQF7J1AHAo17hjJILWLE8pDH4jVzOI4cTkxVT8gzYNovfG2CWD8gsa8UeiG49tM7K26K4X7RFEXLRn6dWOuzyMrLxO3o3WXQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693746055; bh=s9GzwGwUTmn6JGhZn99v1bubLJPaKBmWiP45XTBz+np=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=huj0eQQkeX3fe1y3/kYgprgWRRwbDvyN9UuhuNf6quxCbdHYhFW8TLwHKOhd76iINI+nrZsZECw6p74+jaTcYioS3RUa499HvmClWvmT6N7nJlOXh4B5YcxTYBgyVwUNraTO1J1p/TPovwnoGHhJtx7GERxr6YCZuunwHn8zj9UijURYyHbEriV4L6MgcmMwr6EfJBZMEZcuUFbPCiPlzy/d5fRCOmGNhH3zXFYH1VQgesO6SMqWv6KcMqfo4tf4VOrQjoct+uW1WB9dqKQaX49Eh01XS57KOLHPXc81aiS4dUnJjF4Lfja+BZI+kJBcKsFrJy53o1UDdDvH8iUn0Q== X-YMail-OSG: Rp0znWEVM1l1vWy._6FIwkWJ2LPNNiciAiJSNa9w_uEkq1GlwQlGgFHxrDbCtRK HInOuXUWrhEnDx8ds7o79MwTo6q8i5HqeOhu2CAC.MNSBua2l3iAjkISBNhtT6KpJS2R_mmumwHH 1G2ilpWUkIz1ohmLabt5hNpyAMgAKZMnCf_kXjxGfgSFUviDpTmh0Z22HdO_PfgZ4ekf5NkEilYU iVhyx9T_ZUPyHNMUjor9vEb_yvmAd5JluQSw9uEmiHWUBcIwo07DNnVWdBApr0DNvuqihV4vpmZx UO4AJkLuiBA0tY7IlGOxVYOKcp2Dqo1lr1qelaH11g.T9wHBfBFe252gAB79jvLzNOlHASwfL.Sy 4iEayQvvx1wUI0Ifr3C6pmMGXOkGr6KQ04Jdq7Lqobwe7FQg29P.RRCDdBqDipAiWYifnsdKeu18 phIGysvXLBTmBBRUayqSjpTiTpNiZbFgQTuP2AQB_F78acM6Lj8sf45tReofrG5wwqGIZmTMIwRt ZxM.4m7DUXA0yf3j2YPV6kLn.rRd6RrCYDSLZWmX_lnREwam5BZvT2pok9v6zPMLMFklhjtov1Vh z0deEiMUm__WOUDKFF6F.maSzhoDG6nETH8kDBctPm2yL71xonzq6ET4Qu.Kn.opAwxvt1Xh3iro 13wG1Ju.c2Rb8NSK3S.eaawWQFbdFQD4v7k8tqr08ZTMjqnt8xf7OJ3yapnTnpDSopFgNVQD2Xbi vo1f9qRXYnIVaFzG4KEZBOKtZt5p0DVyK4KFD3BuYl.piA8jwcYCiQ7mbDKwClTelqERMnSrfVuN lixwxNtlFsay7NEkDwEz5s0VB093Llomqg.qd8rqKpWROgkJC.h7fRke2_BDWMvLAnYn2abbDvq8 45ZUar6p2iydYXVfSSvCqK3miSZ3.t1CRS_Zd0oN02eYFeIVXHnI84orAKquAFsZs1ZPq_Oovjmu M5ka4.6Fbi4Ni50KIAd2bdyrXmX61qZX3rofj7TM93omo9fQs.P9EoEhMjanTyutTZFoTauRrUoZ VIrueE2ZLha8K1WXaJVOP1gL_5yuylJonCfvv3j8VvhHHDTDwCx0VZjBe0GdV_NGmg4MbIix6rXG UzMm7X0oqidbjdjwSrbw..lgCrbnyfodnSeJBhAtdXMOfVzz_AOAeoPzFcjcblQFXU3E0tBtFX_D AVhmoWiOig5od._1HZlL39frn_86eyOKefiBeYOnqBxz9iyuiZXhgE5thlE1J9k.jF_NL38t52IN LqMcAqG0.iHjqzDMuPBxuxJOKCubndXgjtOZuZDzhTUHen4QGc0VNBGtT8P7cDNhCA.Qn8iCoXnP WOlIKACaSk7nkpcqsKtNjCCVzMbk8bJx.6otWXZ6HB0._s9ywFfaWnXXrd0khlzOsp.EyGYxTE.0 nVAI3RbwjdaPG3TWQF8pVLRUiBkFifEgvXxX3sA5BkPNmzI4wmfwNU8qML.FuwNn1QGa..Xt1Fqk 9fM4PXtqbIrUZU2IyzSYMromc.pBESnLke8jHewvfifo34J7hpfXaFYBJ8RvIM3egmYEH92SqXmw 7AIm2AqExQ1zVxmy_s30aGfPJkkCPCCut9l4mFJY8n5w1dDrZL6OgirUwTQh6uui3BdYqluUTCQk 05kQsiirqT2QpDRwT3.YV823kZi_u03kEmuK4pTim5RTgRCB5ox3ycosIGcfjPXKQ0YzExTYNAO6 8vtukSCFcEN3vZY2_Qke5ZFV1NzA6TCVZ3Hnjv0qKXGqqK_hTvvf1NMbPm7dL0A9lWq7TI6SmTwW 8MTC.fPF0fvKcGJUhzkq3WxovcHPO_IPjworBMuiiCUeH6f4ntmfiaLRKmK915lHueGrWOyvc2vC QjGq6xDSITmmMx0wWh8.d9rnckU.f_Ve6mLgFj9Hus3N7_G0I0e2FPinM3i1UeA6NG_mdKYMfVP8 DVn54G5CkMWCt0Tm9TxUG2b7sCObQzAt0ZQRvfwVOmEUETiY9EjkWWD8m6o4O4HScIcEaeq73nZ2 F9cRSDioGzNBwxaE3o7tkBY4vL.bGRJu11cSJSuzYoRagJTEdzguOJAgNqO5_GWQWgZLhivyRLyj rKnjUEOiDgzXO2q1BFNY7W4mFfgrA3mZHxuoz_PgdOd8tisc.HLKdOO..U0owNR4J1JMBgTOH5Nq eLQmvA8KS7wKgpxYACX2xxRGB2nn6xPK8L.UdR6JMCOAGf8tJybjDp_6T.Zjm4Q3DRPh73g1mzf8 18ehmdvedr6zI.DgGMJoYB3jwwRnTHX3_2jw9oUivw8uGFf4cpm9qxJ5d.DZcw81o0w0- X-Sonic-MF: X-Sonic-ID: 964bf15b-443b-4d35-a961-fdf56f9c42e3 Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Sun, 3 Sep 2023 13:00:55 +0000 Received: by hermes--production-sg3-69654d8bd-sbrjf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d7dda6b59414f39b0cc3eae922e3d073; Sun, 03 Sep 2023 13:00:51 +0000 (UTC) From: Po Lu To: Stefan Kangas Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: (Stefan Kangas's message of "Sun, 3 Sep 2023 05:51:13 -0700") References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> Date: Sun, 03 Sep 2023 21:00:44 +0800 Message-ID: <87wmx7jts3.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 458 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , Davide Masserut , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Not sure it's worth doing, but one option is to do both. Users that > miss one would see the other. I won't object to such a change, though I cannot claim to understand the rationale behind it. (Who would see the message printed to stderr, but not the dialog displayed, during connection setup?) > BTW, if it's unsupported, should we even show a PGTK frame on X? It's still useful for testing purposes. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 09:32:06 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 13:32:06 +0000 Received: from localhost ([127.0.0.1]:40013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcnCv-0001cg-Tg for submit@debbugs.gnu.org; Sun, 03 Sep 2023 09:32:06 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:60649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcnCp-0001cF-Hz for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 09:32:04 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-500a398cda5so1105504e87.0 for <65509@debbugs.gnu.org>; Sun, 03 Sep 2023 06:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693747903; x=1694352703; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=KeYk5aovUpU4tlgtyJNvBhtTmorfKuA9CVp7NRbbliU=; b=qIR1ehsc6D33feJx54UcurG9gtZi4pPhBeaww37F0hxnme71U490Zw5RSU4ef5GLft TeCB1WIdatwdfvO9FuvPUn+5VhStmjumWX1fQNslAMN1tAZkAQoZeWyJUb4JTYG+X0A8 ahLPx0Q1OShnRfVLCyEB782bP5tIFsaJe0wLN8pkmjCJYEzNj/hIy2ARYNZIEZYqmslS jpfDZeAzjUjAinY0xiGmye+nWOFPaNJfU6HAHL4bvl1fbd2sbJHlZggZOTsmQXGhOY38 m+nlWcx62tWAfmtLp46e0gzSqnIg8vPtqle2QaRiTnCAgLeLmylA6y8xfVDWAQZkugrF U2xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693747903; x=1694352703; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KeYk5aovUpU4tlgtyJNvBhtTmorfKuA9CVp7NRbbliU=; b=NUtwZGWXflL7pkZOCxZjUhUqgkePbibOp+bh60PVfeus6PA6185VHbw4bJftZ3jXtt SL724v3SKmYM83Lsb3cp166+fYudzQRomf/rg/uFWVtBqJ8nuy0CbgDAss2c1eX1Y8Ix gSVIzUlrMasTFlVY9M83GCme3V/ZFwNbzSh3GfMWYETI6L9+TrSEp0SVqeUe7+XOQ6lI MlWuc8jL/LqBvdF/swko+SQkvZw/cdxZOGSSfBt+b+LUIIAidSWz5s4hV3qe0T9t3/q8 nLMMISeZsn/sVyPdKWEVdeCFZu9aNp4MjLHQFMGbCPqbw8bBIiKk4CBJQyO5K+1CbvrC QQoA== X-Gm-Message-State: AOJu0Yz41XJz+RWzP7w2Em+LS23b4dkDFLbGYhvRhZvQiI83gly2LtB8 VwNZe4JsZvBrRopvSpLqH3Fg/p/6igncXexiUcw= X-Google-Smtp-Source: AGHT+IExJEOsCkSWhNb8Tx1OYiS0hKwhn/dLJ47obdatdNlw4ayeBqvkbq7DDnNwIuh1G4K1HZiEIlVuZFRqM6HZrh8= X-Received: by 2002:a05:6512:3d28:b0:500:adbd:43e9 with SMTP id d40-20020a0565123d2800b00500adbd43e9mr5611930lfv.15.1693747903024; Sun, 03 Sep 2023 06:31:43 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 06:31:42 -0700 From: Stefan Kangas In-Reply-To: <87wmx7jts3.fsf@yahoo.com> References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> MIME-Version: 1.0 Date: Sun, 3 Sep 2023 06:31:42 -0700 Message-ID: Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries To: Po Lu Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , Davide Masserut , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: >> BTW, if it's unsupported, should we even show a PGTK frame on X? > > It's still useful for testing purposes. Aha, right. I believe you already said so in the past. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 10:09:57 2023 Received: (at 65509) by debbugs.gnu.org; 3 Sep 2023 14:09:57 +0000 Received: from localhost ([127.0.0.1]:43248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcnnY-0003Ob-VJ for submit@debbugs.gnu.org; Sun, 03 Sep 2023 10:09:57 -0400 Received: from out-217.mta1.migadu.com ([2001:41d0:203:375::d9]:28870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcnnW-0003OS-1u for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 10:09:56 -0400 References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1693750182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3DVaxkNVakb3EhddndVcHG3xdNbLz0kFEZpcg8XQ2L0=; b=ZiZhMu9S0XopXxp8ejSc72GIzorWrhN6vDvGI8b6HC9IyxcT74qizgTJCv+4xo3ok7PlKC LtWAOTx3lUCVfzYeSkTT+j05CVxtMhatEeECjJsIY4ohoXVDWnTxSIWJjTatIXVWV2hPEM 4m6/JtvKT147qmq7QnmiZPHbwVrjGGqeNIyhMxCd6BQgZFkrXwhE9V0AIzcMvyT6TL3+y+ ZtQVAnpFpXMYo0murjvYnwXa+9mkID7WXWkAyAb8RsNTRqmv90k1snhChuUZQl08ebxENT kGnxRGtf4/lRK3VORXCp5BB6VmAQt/vyaSpKQ9CM7bnSmqMR9evm7GcmOwfTpw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Davide Masserut To: Po Lu Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Sun, 03 Sep 2023 15:42:44 +0200 In-reply-to: <87wmx7jts3.fsf@yahoo.com> Message-ID: <87lednz6u8.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , Stefan Kangas , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Stefan Kangas writes: > >> Not sure it's worth doing, but one option is to do both. Users >> that >> miss one would see the other. > > I won't object to such a change, though I cannot claim to > understand the > rationale behind it. (Who would see the message printed to > stderr, but > not the dialog displayed, during connection setup?) X DEs don't set the $WAYLAND_DISPLAY environment variable, so querying for it returns an empty string. If I run this in X: emacsclient --alternate-editor= --display=$WAYLAND_DISPLAY .emacs.el the following occurs. When the --display argument is an empty string, Emacs first tries to reuse an exiting frame and, if doesn't find one, it falls back to open it in the same terminal. The problem arises when an instance is launched through the DE facilities: Emacs can't use a terminal as a fallback and therefore it opens in the background without showing the frame. If we decide that handling such case is not worth the trouble, an error in system log should warn the user to use the X backend. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 20:38:48 2023 Received: (at 65509) by debbugs.gnu.org; 4 Sep 2023 00:38:48 +0000 Received: from localhost ([127.0.0.1]:47829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcxc7-000838-RS for submit@debbugs.gnu.org; Sun, 03 Sep 2023 20:38:48 -0400 Received: from sonic310-25.consmr.mail.ne1.yahoo.com ([66.163.186.206]:35729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcxc6-00082v-BG for 65509@debbugs.gnu.org; Sun, 03 Sep 2023 20:38:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693787921; bh=hRveioQDD37uc6efn1azM9rX+hFSumDqb23LGZeSKZM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=HWQMvlsNrV1hy0YRI00Y18GG2ZRfS5E6vEAXx09MtiHYHEYGYot4ffchpzVFzQffY+JofTMEyu5iRvwP31bkazzj27Hn6X0oiqUJNJArjcphkrz3ImfbpVsBJlmkisGHBOWgbuYyLpnlVWJMv5TUb22IY0RJUANLI7WjHXH483/YBZet/0rn9TmDy+ISkFkvQLmI3/iAzEEEFp/RfjlTf6TypH+WEFQe8Eidch9RFV4ADElOwI+TyoH59dbJkx3CGcBI3nUpY/ZMHnSMaGU023HONR9IrfEc7G26GnA7n4PuP+WoSZ1a1KKrkgr/b2mZLGU44eqoSt96AbyBcn7WcQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693787921; bh=uVIEFNqkfTH2jxXvCEUzALL3RuhVfumM/sYnEiPDim+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=esLJVbAiH5zC9S9uWOvXZT0Sf+XXABsq5v4qWfL752u9GLyQq1sTm+bRqEyKkAU1bM+c5zwj+JBf7xsMaHcdVpLOBJjzyLzlt6+0Un3ao8S8ts30gPm3IavOo+eyDAgTKNR3bkDiXQtDC/bBrG7dEq/0RrlQ5BSp3r3+IAr2J9XuGNaYCJCuBWQJgVwATIzL7mr/b9IxQ498emywF+khv6LYWFJ1QfcQQeGomfLtH2qCGPFUJnMRzI3mQrjxE6wARUybdXDOvP99r2rTZhkAZ2FvhwR1ecvk+KSleod/aNGvkO2+N7xNirPc6PHHtKHdjhV6MG7j+cNiHMABu0jq6Q== X-YMail-OSG: 3gFiu_AVM1ndd6VBIqffS68bHbjc7k4u9isndQKE2r.dQfD9sZzmTdHvZ20.bDR .JfiyDy17w6ZF62b6g1AiO8FSu1bz_aPQiWMGjyLibuRgjze7nIWBPEkz1QI1ah495QdUZgb.hef 5NhrfInBrjcTwjx9jvcor447y0HSvb0iyLIHVgumWrQCyrAFEERI7.okneAh6K1T9ymc.DPMwvDW QBwhY5ol15hW2vUHOnCcMpW538DpUhCWDzfsBZC6h8XzA0st7FguXIleWdPzDLOvnajN3yIvLHzL y0IGp2_BrT5yU5OI.sXUzeMa3yQY3_kpysrTMr5fYxmkOg1srwKQuuQaoBIrVFyHe2cOMS9xjF9E HKyc92mgQ.2t.sDDbZnyfxtDTT6p6DvJ1VZAdTZE9L6rQRYijZ9YugCDjsKsYZPrvXsb1uZCnsWv 3ItTUwpQ2VN48MNlM0dUpKFs6AyHkXlU0QbJHXiFJLHNWshv14kYZ1yq7SvtKZFPchYnzFz28Pz6 q2whsQgoN9O21Vj3ZY7GHxzaHM01rw7eMzWM2dVhoyWjyLzYMQh8v58u1lRfadPJ.1QNJJ8LGtDf 2KqBoqztqgxZ_Hv.c1rV38tJ6iQ0UVK.b_0L44A_sPjPiBBIvby6xBjvZCViExMrY_NhV7OhcFDk 1liBjPfm8BYn7qv_cQA1puujWySFp3lkcHu65EkVjfCsQhVANbhvxfgk1UTLp2LaHHc73fT1XiJ1 2523pflbaI60S76cNs.aL1wREh.pRwrmpEfPeJHjZ6OpGCsnJhgtX7Y3Ck0V6tA0CLVxuSJMkVR6 EfrB.Qmk_azmpSLns4_FxB7e7l_UDk5pdWj1MOobQGF_SoW0toW3oO1YVn5dvHiVo0TJAQPoFez0 1u.ohcLkJthOrTfaFlYr7sUyKf4_C8B6qDjTxlLkUBCvdlBmG_clIt2tvNr6nDGvAvV_b1wCywx8 YHKiJrrfaeHQcRW8Ehi6nU.FAhQg3FGosIUfkMCXcU.2SepFGwnpHmjM5nu9p3k78qNqKCvE7Olh BLTL5yZJQrFXaMhN5qmhIszvYOOYCx05SI1jrXf9K8XTG.XyBjactfkb1s2QXLr9XQEb9DhSvuph 3a3drgD4wroA6kG5hUDRAMpZR0rrt7feqcUJCmIEN_8MMoWb5NUgh93jhn65LYH.SzcPb0sbkV4z DIR26ZweTGxtLsQBFtBbCpQfpaS1V8uFuPBeBevbqkKyE4Mb5xEXRSsDZh7_1kyOI0UZMkZ5NOWD tBcCLcFv2Sl.DkDed_ybVGiqcanfSXENEAmmjmiqfY756SgtGhTo8J5yErVbmAj0cay9hHMbOD2W _1i4mV3iapCWQS2r2upXTSX9FJQmE9vts5P8j1Agm3AI77Lhwc0wXCDpo9XVCxY5b8Ui8voZ4d8Q MbovK9p_NxQ1K93R6owmr2hKzb5wwcb6zmWlk.bRqobZOsZzZW0bhJxhsyxt11h2zkT3vjCvvRD9 5LCxDhyOL4A0BiRLuCpBFZYVSsDYZdUoTROrz7MXRWlSlriO979U4QoN5lVausn6huX.XFvUms4K MPZFaIL4.iZMjm941jEJ7iQjLcw7j3IEGm1eFn0tpSM2F8bRDee9KMnE_Jzp4nuOLDIBDiGM5ZP3 x6bV9Oze2CqhVoDu7elMFjISoHO1XrU7kU05KMfDDcFiqJVZJU_.jb5gYVHnUIBKcKMnRGrXlMC7 368vYaeBHzI6bB4d6dDOHwKyYLWYH9EC_.V1VZAwJOrTq4yL8G._jau4BBV8fdka61SYneCRzQoT 4AAHYg6NaPwvSiX.lsOCEsIamWaySfyOSXZ6As7f83XQxOPE6890ZXFKm3HocVWE5oPsfS7GmMRQ 53HKmT3082UKMHCzLjjRzz9GHWb8r.XeG1A6AKqIzi2Lk5G4JrJKRtrcqm.ovMwWBdXQtXYQjls5 0cFikV0hGlVuGLXINBpDbvbPcd1cHR6sZtVFg0Ti1y2Z39mb9mW6RWDRSSUhP0N6FPPXPwbiQvjv PLSWV.984D4xh6v7btMYRrmZ07m86AqBHTKvC4F_JuaVTyru3Bkdl15qrnvrGdViy26QhSXcyqbk EkRkhu0WaPKQuh5FISXO5Z2F37BYguf0MLyJxD0WIGQ8lgdCMnID80.GXUyiO3br30dMwbmIQMdw 2kZB0TX5fe2lZg1wKyzbOnXan062cguK3Ylia8DWJJBKf9Phrk1yOPpQ8OLtbCVbCx44_PO3eZK1 _wg_KECIPBc2jFF98MQHo6Q5J23aZQVjf2brudrJdFhI4b2WXE8er_Sn4EKGDzSAvQYamVA-- X-Sonic-MF: X-Sonic-ID: de7c6a65-2dee-48b1-804e-029824186249 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Mon, 4 Sep 2023 00:38:41 +0000 Received: by hermes--production-sg3-69654d8bd-lxqd4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1e10f100354261a0afdabbf7a8e03b0e; Mon, 04 Sep 2023 00:38:37 +0000 (UTC) From: Po Lu To: Davide Masserut Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <87lednz6u8.fsf@mssdvd.com> (Davide Masserut's message of "Sun, 03 Sep 2023 15:42:44 +0200") References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> Date: Mon, 04 Sep 2023 08:38:31 +0800 Message-ID: <87edjekc1k.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1034 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , Stefan Kangas , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Davide Masserut writes: > X DEs don't set the $WAYLAND_DISPLAY environment variable, so querying > for it returns an empty string. > > If I run this in X: > > emacsclient --alternate-editor= --display=$WAYLAND_DISPLAY .emacs.el > > the following occurs. > > When the --display argument is an empty string, Emacs first tries to > reuse an exiting frame and, if doesn't find one, it falls back to open > it in the same terminal. The problem arises when an instance is > launched through the DE facilities: Emacs can't use a terminal as a > fallback and therefore it opens in the background without showing the > frame. > > If we decide that handling such case is not worth the trouble, an > error in system log should warn the user to use the X backend. I don't quite follow: if neither of the display environment variables are present, then Emacs deduces that no display server is running, whereupon it resorts to displaying a TTY frame. We do support TTY frames under PGTK, so such a warning would be purposeless. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 11:12:24 2023 Received: (at 65509) by debbugs.gnu.org; 5 Sep 2023 15:12:24 +0000 Received: from localhost ([127.0.0.1]:57819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXj5-0006Qq-UI for submit@debbugs.gnu.org; Tue, 05 Sep 2023 11:12:24 -0400 Received: from out-225.mta0.migadu.com ([2001:41d0:1004:224b::e1]:51965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXj2-0006Qe-OX for 65509@debbugs.gnu.org; Tue, 05 Sep 2023 11:12:22 -0400 References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1693926738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=leG+wuafwuqgKp6u+6hP0/osB50jiwYM8BSNJSYASwc=; b=zEhXLtFMpcJRkgDoFONW/lJBYGP1O9zG9W7pFxOGnJOJMnB4+IZPtkgTMxCGWcMfP7sijC +Jy09jiuCzjVX2YkTGNwnI81SD/rzh2v/1P5C2hDQPunOysx68tbWMICEl6Rst2BIaqLHK pANVfvpi7NwbaL2DWjS6+4+6Aomm8X0Lmj5CYM3ZfhbgAKN5QbuiryM2sqrlB0Zyjn6sA5 zS7Vtf8cV9kfxlaQabqhTNDDUPJabZd8DlAudrYakWG9xIz9yaR01/GVmvIfxjjNhIPmnN yLt8u/yBV/3y6Gs2nXD2NQ3S1TRjqz1R/Nacriq1rX0IHQgkTSll6SKODzZmvw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Davide Masserut To: Po Lu Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Tue, 05 Sep 2023 16:46:30 +0200 In-reply-to: <87edjekc1k.fsf@yahoo.com> Message-ID: <87il8oodrm.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , Stefan Kangas , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Davide Masserut writes: > >> X DEs don't set the $WAYLAND_DISPLAY environment variable, so >> querying for it returns an empty string. >> >> If I run this in X: >> >> emacsclient --alternate-editor= --display=$WAYLAND_DISPLAY >> .emacs.el >> >> the following occurs. >> >> When the --display argument is an empty string, Emacs first tries >> to >> reuse an exiting frame and, if doesn't find one, it falls back to >> open it in the same terminal. The problem arises when an instance >> is >> launched through the DE facilities: Emacs can't use a terminal as a >> fallback and therefore it opens in the background without showing >> the >> frame. >> >> If we decide that handling such case is not worth the trouble, an >> error in system log should warn the user to use the X backend. > > I don't quite follow: if neither of the display environment > variables > are present, then Emacs deduces that no display server is running, > whereupon it resorts to displaying a TTY frame. Correct. However, that TTY is occupied by the X window manager, which hides the Emacs interface. When the argument of --display doesn't exits or is empty, should we check if $DISPLAY is present in the environment and use its value? When PGTK is enabled, we could check $WAYLAND_DISPLAY and then $DISPLAY before resorting to displaying the frame in a terminal or in a TTY. I tested this with Gnome and i3, both started from a TTY using startx. I'm not sure how this behaves when using a display manager. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 20:07:49 2023 Received: (at 65509) by debbugs.gnu.org; 6 Sep 2023 00:07:49 +0000 Received: from localhost ([127.0.0.1]:60013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdg5F-0000FX-5T for submit@debbugs.gnu.org; Tue, 05 Sep 2023 20:07:49 -0400 Received: from sonic313-9.consmr.mail.ne1.yahoo.com ([66.163.185.32]:44824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdg5B-0000F3-Ev for 65509@debbugs.gnu.org; Tue, 05 Sep 2023 20:07:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693958859; bh=K8R1YeX2YMrrzV6DwkaFGKf1qnEPIqNzjQdyUn9xItg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=OfmTFB/JplvPVqv8eR/Om4Ga50LZmFze3xgxlx+Mq2XiZ5t2f1pcWEoHxxAuvPkbf47bCyN5+V4AEv6oWwFZFehfLBBxkKD/MvePEMkgtfR9Fo5XpZrBcaMPZLeB5DarB8yLu4efPHrb9T2Ky+eTR5k9oECYVUjOlFEgERQwANqaacdGJfEbp0zy5BskevQDewTsYp+lRYlXrCjJr6ZWU8c8L8X6tDjlXpzq7wYogxRCNubv9e9YvJ+fwydsqtd0SHdpCYzGpF2MdglH4c4ayY/K7gA+YBw8HE9ggnNrSW8p6dgHmpS7jTTBOmm0nolTISvgrdaZzKDTwDJyyPUkcw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693958859; bh=ptsi4HCOMvXvi07B6SUuX4VBePJmsoNTvNFy8utdoOx=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=H5prO45AZ/woiR95p7o/NCuytZu0qfV5E2IrA2PN2G+fAzXjC1fR+YJtSlwf3l1v5QGmH5+fRDzNJyz5c8JZ4nu7doFIUUDDp8hbPPhh1LaNAlacFznmMgdXeRjh7bj7xS/oyRkbiV+nJAnQA3EKzmoRhYJlus2GYWW5gIjM6rXlhTahjMr8tFj9miITLFBd+drQ5SjRa/NYyK8HH39+oIXDiY59q2fXH+DFbDvjOU2nH/o298QIyCEJrL62vpfOkEUn+oHngJL47qwzqvjwFioWI2ZwJZtDs+KIyjEsK/bgmCyP+JWJbhB38YMn4p2vWu6NIIbJxh0ikfrM2YKB9g== X-YMail-OSG: 5GWYumEVM1lHMQ488Rdn0lOPP1DPsNRLRRUGQ0.TnN99scKg1D3Lzzv.ijkP9Iv aThUPIJb5iy2gKDmpafCminbL3tle5ltBt62dbxX7Wq.diN_EgWBHy0OiID.jVKGeNnLH3XsqaHa E1Amd38v8hXKLTmGDWcaN56OhdBCWI4Ld9VV7Xqn32BzUiYXn1XfRq67Bggtc2surrlszFBzdFSd bGxzldiPmjiWqpU8oMsbNALlOF4IIl_bNCITJA8aFDD4UXo4KoKG8E2RZzBsayIQjX6CGn7.Sq2T 9hP6bIeNt5rss4ZZfrbkMdMC78zCQwB_Ar5NGIWSSnoErwhUACN_JmdPhMyw7_GPN46zA2LbkO5d dKxYrgl_6b6jcVqOZskk7BNMD_5hod479vxwO99TALBHIfbhAZmvLJWHDovPG5ktYjHsxZmT7aeO Kzcl5IzyxkU1G3_uWEqY2KQJOrH3D7k6IO.v2s.7cy4CIvTjpymipNK2fC3Ld6KVDumQj19Mbpdh PfMcrJSqkVov8dnFbWjB35enOLX4OLrOrsaYT1WJp1..5nC5eDeDMNIoX9csswW7pbx5ckZF882B NyxaRqMHb_F34W6RFwSH7pzmq8s_GQ4PsLuQSjIXxOY6pOUrQrkGV2_iEjCxeJnli_qMajybK3QC N95jQ9y74EBw_8BKLRKB5CFMPEBQ.nOtqR0jxZbkJDqHzd9RISQ5xyFMrxx2lexKR1Bbtp2kdUWK z67GiAQTZMMwaZGwvJF7ozD4H06zKxxi3aMzC7w4wz014W6Jbw0KKUhxntFmxmAX7Wb1piaKUmNO 5DsRv2LNl5l0HJ7K9ZpOJm76rTqjt5e.CI0FzvrdU7G6WhS_ryKXYfoP6Nm1proZC.ihoXfjhO0U dS6OFC1LuI3Sso.7AG9oIDrH5VyX8QW5XasRH6D65qRBfSsiMwIJC_qc1OfWzhTPXjPBUsJn1IUh qe7p5C6wBDse3GLhi0L43hFRTkRzZ5gpvtk9agd57H.CkLqpYuQE77_0wuBveGEscTZkYG0s8RIi kWoSJ1cn_ciRBBKuTNbqkmgr38PNiAAkJu8lKZgLEhCwD36b9hIthFKdZ4mV84VNRFgsPVDXOBxZ zb5rn8vASwAfnlFwXfNPji106CGO_s2jv8FliSq.xSwv9zu3as1GfFrwRrBqBZv_iC0qxJUGlYiv H4SsXKuX71uY2jWKLMoH.oo9h2S5p.gPEYYrHC7Wn.n_olMXqeQlSR2_8_X8Xa2xXzjV_57A34rk FanQa78daVMy00ImoUd3USZjnKb2O.MDsZTAL74FjY795GuSoNITnbsMYZN_bQdmZTQfd3TLyeB7 zs.isNH1.4oV_Lp.oV_j3sl8X5KCxiPlwYiye5qlpSefNzJTbZlILkwVcigUEw3lQ11IXTCiterT KUui4_Xc8zc_vL9.VsNZRYM763hTPNYPBmmFJIpCAgbqR07tYAa0Qb0i1v8c8sRrhx8RPVLFld7. W8I07yTKYgrMeYdRub846fZTL5GrZrXyoJC6n1wxjCuoG9IYWmgOQs5DheCEbdYw7YOhU8Aahk7W yz3ZvkzPVqlQpUGk9X6jdRnC2mIUkcyxu0SHKlj6UTh1fq1493pOj2JOkpdyR9hsU1EDpmSbSeIg .mRYeSMdxkBdOwjxtmqi3NIHtyvc6ACnLax4lWujltwnc.m.zIthuL_km.sIzf.hExRGJaMxGg6k oNKMdKL5hFpuZrPAsGevgGvogVMmw9O5hBHbwTFD4anAN4qJfrg_aPgNcc5J_mtZa4GtQFFGJqNy _h28ova1uf6jzBHvBMX_tZ.DjqtNjGaq64C0R63qqgdd9r9i6xFo4rtNjC0lcmRGYBDWBOhMoaCy GpQxsef989FF33_H7yitqFcPEUADON_4_tJZFIwS5PO7tNF9pnpGqhepysf_IeQ87dCMLVASlvHS ygHD.tAuOYjI8HuSb2QzlKZYzyfo2.cNcC85ZE4H6knMt_xptN1GPSU585JYQfNd.GjxGFOFoDcD uLmecx_KOh8kW1SsM0TZvdMAe8q0wgR8BhszFV7z5WHA5u5FoFuFlJvTJc9Lp5lhGWlQTNqbpQFb _rNT.4usMXX6NboeG.OyO8g7Os4dUhOBtcdWtzBOOXHlve.SoR_8Xx3UUhDNYBTrQ4oVjRWvm.I4 _rmDXkgWFX074WYMF9yMMr2k1ZX6bZVwaBcjiuAUqTPZEQ86HBPd3mNXiidXWi_R4Ue5qscZbyE4 riSGU.XSkfQnRT.0s.38JZoTr5CR8dCkaJpaqS_St0ridtUDWyK74rA-- X-Sonic-MF: X-Sonic-ID: 4d26de60-84e2-4498-a901-1eb070a916e6 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Wed, 6 Sep 2023 00:07:39 +0000 Received: by hermes--production-sg3-69654d8bd-j2jc2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7f0f4dfd3b526da31bba191f5d7aab55; Wed, 06 Sep 2023 00:07:34 +0000 (UTC) From: Po Lu To: Davide Masserut Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <87il8oodrm.fsf@mssdvd.com> (Davide Masserut's message of "Tue, 05 Sep 2023 16:46:30 +0200") References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> Date: Wed, 06 Sep 2023 08:07:22 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 902 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , Stefan Kangas , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Davide Masserut writes: > Correct. However, that TTY is occupied by the X window manager, which > hides the Emacs interface. > > When the argument of --display doesn't exits or is empty, should we > check if $DISPLAY is present in the environment and use its value? > > When PGTK is enabled, we could check $WAYLAND_DISPLAY and then > $DISPLAY before resorting to displaying the frame in a terminal or in > a TTY. > > I tested this with Gnome and i3, both started from a TTY using > startx. I'm not sure how this behaves when using a display manager. Display selection is GTK's territory, and we basically give it carte blanche to judge which displays are suitable, since we can't account for every present and future GDK backend. Only subsequent to the establishment of the display connection are we capable of taking display-specific action, such as displaying a warning message. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 06 10:13:23 2023 Received: (at 65509) by debbugs.gnu.org; 6 Sep 2023 14:13:23 +0000 Received: from localhost ([127.0.0.1]:37072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdtHX-0003RP-1f for submit@debbugs.gnu.org; Wed, 06 Sep 2023 10:13:23 -0400 Received: from out-227.mta0.migadu.com ([2001:41d0:1004:224b::e3]:15344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdtHU-0003RF-4t for 65509@debbugs.gnu.org; Wed, 06 Sep 2023 10:13:21 -0400 References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1694009596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8/3/0/IDQXLmB6FZoecpEs9HTC8IifeFa4hh2v/IMt4=; b=pKLYQiwTyihcxFyibPtR1OQh+cA6xT9Eo0dupKi8AthNaTobLILluk11pS1KDRJjkJAijI 0sFn0GVE1dy3huw69nIKdRbDcMHSHIyWZl3Mek7MEOLUhu6feoAW9oUB3qNk90oYfReycI lykQMHxN3mMOzu63aN0FrwGHLW32bhr0dbKk0A2AyPBNhR16raJApgEuFcdAlVwXqApy4Q Dy+mFgz731eHSL2K/jsHwKxwnihKVRgdlp0IbrY2iEAlu8ZmhOIdOQRV7pJRZ3qHSgucMv VxnOjicVrBK9yf8LoE7Ux5C14j4mdFPsfNwLL20vIn2018uijvaXTWtw3PZcGg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Davide Masserut To: Po Lu Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Wed, 06 Sep 2023 16:01:58 +0200 In-reply-to: Message-ID: <87il8ncruu.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , Stefan Kangas , 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed Po Lu writes: > Davide Masserut writes: > >> Correct. However, that TTY is occupied by the X window manager, >> which hides the Emacs interface. >> >> When the argument of --display doesn't exits or is empty, should we >> check if $DISPLAY is present in the environment and use its value? >> >> When PGTK is enabled, we could check $WAYLAND_DISPLAY and then >> $DISPLAY before resorting to displaying the frame in a terminal or in >> a TTY. >> >> I tested this with Gnome and i3, both started from a TTY using >> startx. I'm not sure how this behaves when using a display manager. > > Display selection is GTK's territory, and we basically give it carte > blanche to judge which displays are suitable, since we can't account > for every present and future GDK backend. > > Only subsequent to the establishment of the display connection are we > capable of taking display-specific action, such as displaying a > warning message. It turns out that Emacs 29 has new CLI option that solves exactly these problems. The attached patch replaces the usage of --display=$DISPLAY with --reuse-frame. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Avoid-using-display-to-reuse-frames.patch >From bb7ba852c9add6ed5b3c1edd783aaf07eca08a46 Mon Sep 17 00:00:00 2001 From: Davide Masserut Date: Wed, 6 Sep 2023 15:35:47 +0200 Subject: [PATCH] Avoid using --display to reuse frames Using hard-coded display values can cause graphical frames to open using the wrong backend or not open at all. * etc/emacsclient-mail.desktop, etc/emacsclient.desktop: Use --reuse-frame instead of --display. --- etc/emacsclient-mail.desktop | 4 ++-- etc/emacsclient.desktop | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/etc/emacsclient-mail.desktop b/etc/emacsclient-mail.desktop index 0a2420ddead..819e3855567 100644 --- a/etc/emacsclient-mail.desktop +++ b/etc/emacsclient-mail.desktop @@ -2,9 +2,9 @@ Categories=Network;Email; Comment=GNU Emacs is an extensible, customizable text editor - and more # We want to pass the following commands to the shell wrapper: -# u=$(echo "$1" | sed 's/[\"]/\\&/g'); exec emacsclient --alternate-editor= --display="$DISPLAY" --eval "(message-mailto \"$u\")" +# u=$(echo "$1" | sed 's/[\"]/\\&/g'); exec emacsclient --alternate-editor= --reuse-frame --eval "(message-mailto \"$u\")" # Special chars '"', '$', and '\' must be escaped as '\\"', '\\$', and '\\\\'. -Exec=sh -c "u=\\$(echo \\"\\$1\\" | sed 's/[\\\\\\"]/\\\\\\\\&/g'); exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" --eval \\"(message-mailto \\\\\\"\\$u\\\\\\")\\"" sh %u +Exec=sh -c "u=\\$(echo \\"\\$1\\" | sed 's/[\\\\\\"]/\\\\\\\\&/g'); exec emacsclient --alternate-editor= --reuse-frame --eval \\"(message-mailto \\\\\\"\\$u\\\\\\")\\"" sh %u Icon=emacs Name=Emacs (Mail, Client) MimeType=x-scheme-handler/mailto; diff --git a/etc/emacsclient.desktop b/etc/emacsclient.desktop index 4395d3b02bc..cfbd4d97979 100644 --- a/etc/emacsclient.desktop +++ b/etc/emacsclient.desktop @@ -3,7 +3,7 @@ Name=Emacs (Client) GenericName=Text Editor Comment=Edit text MimeType=text/english;text/plain;text/x-makefile;text/x-c++hdr;text/x-c++src;text/x-chdr;text/x-csrc;text/x-java;text/x-moc;text/x-pascal;text/x-tcl;text/x-tex;application/x-shellscript;text/x-c;text/x-c++;x-scheme-handler/org-protocol; -Exec=sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %F +Exec=sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --reuse-frame \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %F Icon=emacs Type=Application Terminal=false -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 04:27:04 2023 Received: (at 65509) by debbugs.gnu.org; 7 Sep 2023 08:27:04 +0000 Received: from localhost ([127.0.0.1]:38502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeALv-00080E-L4 for submit@debbugs.gnu.org; Thu, 07 Sep 2023 04:27:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeALr-0007zi-UV for 65509@debbugs.gnu.org; Thu, 07 Sep 2023 04:27:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeALk-0008Nq-JI; Thu, 07 Sep 2023 04:26:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zj9vSSuafJ+cLwysyVs6yg5XG0StUMP+QVn+ov+gzDA=; b=UCgpzAWwb0BQ oRjJhU6/zGp3gx9xKhCCd8u9jGPHG4/a2BI5jHPhDeR6/eDfk5DKk2vhD027wCOUVVogwm1PpcktH pwWmVPHkSpjpEkbymc3bdyOORVEekyitYnRUOkoAfTNmNNUE1ztsvl+vu7D/GMrxKsvWxIa5Yodix iPjJe/AX7pOtN4fCBuqptCYbCeEKa6VUPyFJuQ8uVC+sZaUD1aflyEhu08DQ3QSL9z+Hj0o1GRWTz C6qyVzR7VLblRhYNsV69b2vTjBC3SVq1U/y40GqWL3DibQQTEMTh/OeB73d23XDvTyzE6loGR4Jw3 Tl+5wMLJjf2Yt9DXN0twaA==; Date: Thu, 07 Sep 2023 11:26:38 +0300 Message-Id: <83wmx2z8w1.fsf@gnu.org> From: Eli Zaretskii To: luangruo@yahoo.com, Davide Masserut In-Reply-To: <87il8ncruu.fsf@mssdvd.com> (message from Davide Masserut on Wed, 06 Sep 2023 16:01:58 +0200) Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65509 Cc: stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Davide Masserut > Cc: Stefan Kangas , Eli Zaretskii , > 65509@debbugs.gnu.org > Date: Wed, 06 Sep 2023 16:01:58 +0200 > > It turns out that Emacs 29 has new CLI option that solves exactly these problems. > > The attached patch replaces the usage of --display=$DISPLAY with --reuse-frame. Po Lu, any objections to installing this on emacs-29? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 05:27:08 2023 Received: (at 65509) by debbugs.gnu.org; 7 Sep 2023 09:27:08 +0000 Received: from localhost ([127.0.0.1]:38605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeBI4-0003pL-3A for submit@debbugs.gnu.org; Thu, 07 Sep 2023 05:27:08 -0400 Received: from sonic316-22.consmr.mail.ne1.yahoo.com ([66.163.187.148]:42737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeBI1-0003op-Dm for 65509@debbugs.gnu.org; Thu, 07 Sep 2023 05:27:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694078818; bh=3iQmflNT0iAvo4+I4cBIs9Z794nJB2HlBYxJpT4emO0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=rLcaNXI8jat19q935zlUk8MpIu2jXt3ujOiIifDW2TrxlB+5tkg0YzX0VlFeI9TAxnJ5VQASoR1wRVWlGWxSXC/tzfYfJnUdwuZmYczokWlCCbx295JygLRiaR8izxitIeNGYGrEprRUDJCLjGGjqX/NFIXbKd+FX/+9U1Z3e1mwrotUEsUWPyA/XRmYPn3MVyFS4/8+CTT36NBT0/8jWliEJci6Co/F87I6d5Twmo4C8B6K37+YmstdVOrvibJ5nKwjhjeLpA3WvLi7QC+1aXYZYvBgFIm8Ev/WMiuwFHusVnZ0e5/ovZeCDjljO9VsGpX40WY6lsgBu/sCszMslw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694078818; bh=oizxPsX+uZ2Ub0csOI1v/6KPbsGPnQm1H99wUCU4h7m=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=tpsXADNUumlw+QMMugiRkV4RyeBga81HP5TuhYC4o+NSLO2fQXgm6GLcZ2YCZVrtt7Qz0BWXMbGtjHn+ObkgdO4GVlwnRLMeNU24IUQhATCyEUacfORxGvi3oUj1v+giC6qupgXN6X1uTz9HPV8EKk567L14FyLv5eINdZ0QjV3yp3X5c4nMQA//BJB2FwxRlZv+hKv9vdBKRndudZneB2N87/eQgEOUWe3chZSaHHkBUTuPKwOpHcOalAifDJj6aQBqnOvqn9WUDn8qE6CjTWB3ePnIwbas3xLh10i7G905hAN26M0a54lT3VhuBhM5ivVAIXGTeBQradjQMeLwug== X-YMail-OSG: UFCxBgcVM1ldMr03lLJApLcv9cwSrBF2okQXV1m.EnTDhGnAwRL05I19HFggLeQ xJlowQezxUnbzsE7cu7S5Rg3MNkno5J9I9u_geelyUz2a8T7ZD5MhJAfFcqLBI8s1oKJKFuxmd_8 91K99ZBx5BiugCmNzFxrNHdsBvh8wDVMw0Ys27p_Yg8fgkDebmbP3iDV3TnCUA7qy6gBIbbuxz9s kwmFIgB329J.TuRpnc777332IwA06VBKCOO9jkkl_U9lX._dXAKyd1qWbnthTKPgiN4_tPMogUQL r9jbWG1BUmRVoNplvbAyLzsb9_.bm39Dd6OnmWf3_Rqvo8wKv3xEi6.TzQ_Rx83kQzReDReyilss btKYv7He_LrZncBMBHXYRlcgNB7mOyHA73w6uPwvIbwcaNVcl1oLDgYf8I6J1u4WcH4JCZVvTowl sUPmUcLaYncrljigNN7_hhHBcjdqhd3L5CCE3ISbXIf7JRK6AreDAjusIgLNVX3JG2.jKCk_mGcl _kP.CNlGgLJUZ_V3dQ5bcElmJO28D3TS89WaUVM7Qszcq.EQXHiwWUS_4UWypDbCiim8R9UboUcB 6S8THJsTG9_lMRkUpi9oQXtC4MBRSQ3QzFfmAt5HWmNxlpvGUHApXj_VYm_unLoQfDA78pNh2TmJ YfDonn.XOZwVvQwAy6R7f66xh6pb3LAotmaZfZzo2.wVDRj66F5muK7ULkShG5YnP4hgPmL7yao. WqMeuCFoxMQsezficKJ4U1xRUcf5QmLmrLAZQm9YzEkIxYn_Pl9_3JGRKLmAUQ7fwohW0sM9jvgW EucJajHSZ8xG_dV2juX0BIRKZ.cNPxBHoOroumrdIcC3kPYLZxM1xMIO1WxAavX_e_17BfnRElAt KKNgIfC0_sdcmuYOs7t58TqQ37e.VQBeB29WEEE5btLuQj.djbiwyI6T.XVAeTE7_ask_55kRt6q dB6ufcyzfO_ZTZmrVAwIkXzDMiXU8WcWyMSLVjYxqWQ4klqSsqbIB61Gos579jF.QmwSyERulcHK Zyx_Zuz4Q5Mv8BaMr6p.3dF_4DiOxBEuR4.h.boaPi0RKTA_W5FGhHWWcahXt.HS3LCtFXS1Xo5N 8WOPMDVozhjqgmawD6rjn.LnuTDVnmw3GD2HXgB9kX9_6bHst4rkNpoBlQwO7glofWxxxP1Ktst. UhJwfT7nzC7uA35WMv6BCHfuly3raWU8Qco14dj60YmKfFgTYkoHHMAVb59BmEaKgac041YWcW1a zCatqlMjblKpeVwX105lhgq6AQfgCLHU1GvZK8eFDouJusBhiVXEwO8QNpxlCksLb90Sy0ThcBBD _1TxyJOntP_OP4fx1HLJ5eY3udYMKE_lgkELgSQuIij8s4ck4EpOr5GBkFz5Yw_Mp.vpLiEhYY54 Vnfng7T3f3nAXWgbtWMOdxfF8JkQArRXy0RxhfvchqkK8SfsN4VrqqlXH6OXD.vJ0kMPNVCRwgGW NLNxhQ1Xfs6EQz9IfEt0Tiwf50huNocD7rEXCGhJvZ8twFTPRwD6DGTJ.IRygYpfwRmrbBA2qJGL k.qxJyTXNveNUDnidmKsASFAXpG_2_zJNbegSsLfTV0wcxw1TCFUCu8k.h2VUD2.8VM4KDFNTWNm iYfxsi1phZCaKIKLs5OpFgMlB1wcddo3rHVf9w8Kx07lspgzJFJoGPLfyg3xz9wW64TUnFu9bUVG jDUe_ueXEuXFs9qHMuuHgOye0fQhNaLtexgajWWBxYZUWcdm6OYWga2Ffv2JPAJJRAoheLjhl1GP CyXBtFW48bjgFL_IZjamjcLl6smWacQgNzTomZ.DBftb2rJ1sE4aUxY566u6EYXZDd6Yf1yJR_vq Rbf2G.CfNp5J8398JHN2uJgvEpjRERxn1zgb5.sE7Aum8MTlovSyGKuYMbfFvkpe5YJSdhbu2dcQ 5BpqNSVKjNRXvmjoP1RcQNA0a55OCt_dRjB36fsD586JOa7U6_.2gtDFi1cengRzDnkTMY4o4l48 hkjhBwJaU5cYivhAhUerQReVC6yhdJHLoMP_BELbjPCFIu102enUr8ES3jU2vVvdygL1Wf5tqAQB TUyeMCgO_GtmFSTgRrBRT2bxpfesOEt3bpWkNgCa3d3eJrRgVUxt066fFJnN3yFYCpluFeXw5DFw jGcVA_vsSjGShPsLfgWch7NCV6lWGQ7Xcy8XMqrMkSGKvttStEOEOmzEL2rZplcT50r.zP561xOU zz0uNRlgzKRgvs_iA7bT1om_j3PKcslqbyImb5oet3Nrg015TjZwxicUyCxwTY2Yjp2Cy X-Sonic-MF: X-Sonic-ID: 2acbcf0d-6f5d-49fc-b952-b1059aa0c3f9 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Thu, 7 Sep 2023 09:26:58 +0000 Received: by hermes--production-sg3-69654d8bd-7fcnj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 825f42e52ebba8b9440cdfa3ba0acb81; Thu, 07 Sep 2023 09:26:55 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <83wmx2z8w1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Sep 2023 11:26:38 +0300") References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> Date: Thu, 07 Sep 2023 17:26:47 +0800 Message-ID: <87cyyufi5k.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 561 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Davide Masserut , stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Davide Masserut >> Cc: Stefan Kangas , Eli Zaretskii , >> 65509@debbugs.gnu.org >> Date: Wed, 06 Sep 2023 16:01:58 +0200 >> >> It turns out that Emacs 29 has new CLI option that solves exactly these problems. >> >> The attached patch replaces the usage of --display=$DISPLAY with --reuse-frame. > > Po Lu, any objections to installing this on emacs-29? Yes. Davide, would you please rewrite the patch so that your change is only applied to the PGTK port? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 05:40:09 2023 Received: (at 65509) by debbugs.gnu.org; 7 Sep 2023 09:40:09 +0000 Received: from localhost ([127.0.0.1]:38630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeBUe-0004AA-NM for submit@debbugs.gnu.org; Thu, 07 Sep 2023 05:40:09 -0400 Received: from out-214.mta0.migadu.com ([91.218.175.214]:28941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeBUQ-00049O-NG for 65509@debbugs.gnu.org; Thu, 07 Sep 2023 05:40:06 -0400 References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> <87cyyufi5k.fsf@yahoo.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1694079591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DOfW9cgosuaaoaVopAyiN6FA5IsdXhYyRcE5f0HSyKo=; b=LvQggGHX9E3VTxDIV2ZjMO1+FUJooGC8MzkIV8jIR62nHRm3SS33EpdlgcC40bh9H2VIYz TaJAhoZz44TW6am871oMRUEbC8iQrr0kDGzfBi4Ck517PXn+CDGbdLcvu8PxEsWglJXmqE VQE2rpnuEZw5/xxR0j2QhfUWiGMFv1LOG3CuLOGICbjG64CVFgplKnTdVsyySip8NTmadx yXWzwEW11f6Oxf3p6+wJr5oahSUXU2ivxsP/LiNBo5wgUNfLasoMUz5WkvpKaIiI4BV1Xe E13xNRpasV68BmvYt/yat+EHhaJJN2WvBq5VGA1VWgr8l6iVRlqLeO7KwzkrrA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Davide Masserut To: Po Lu Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Thu, 07 Sep 2023 11:37:02 +0200 In-reply-to: <87cyyufi5k.fsf@yahoo.com> Message-ID: <87wmx28gpp.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: Eli Zaretskii , stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Eli Zaretskii writes: > >>> From: Davide Masserut Cc: Stefan Kangas >>> , Eli Zaretskii , >>> 65509@debbugs.gnu.org Date: Wed, 06 Sep 2023 16:01:58 +0200 >>> >>> It turns out that Emacs 29 has new CLI option that solves exactly >>> these problems. >>> >>> The attached patch replaces the usage of --display=$DISPLAY with >>> --reuse-frame. >> >> Po Lu, any objections to installing this on emacs-29? > > Yes. Davide, would you please rewrite the patch so that your change > is only applied to the PGTK port? Sure. Is there any risk regarding multi-user setups or something like that? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 08 11:50:05 2023 Received: (at 65509) by debbugs.gnu.org; 8 Sep 2023 15:50:06 +0000 Received: from localhost ([127.0.0.1]:45268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qedkD-00069F-FY for submit@debbugs.gnu.org; Fri, 08 Sep 2023 11:50:05 -0400 Received: from out-220.mta1.migadu.com ([2001:41d0:203:375::dc]:17587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qedkA-00068f-0O for 65509@debbugs.gnu.org; Fri, 08 Sep 2023 11:50:04 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1694188197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VAe6qCneugHz9HCoRbR8yC85mT8fMrli+hT2Iy0YfEQ=; b=nT9t2kjDMshwl2KrDpeFOL1T1rX9Rps7iSE5VWJJYoavOE6hBSmrNEod8f6XqXmdNMQr9u +Thg3ZjyBezKOUKUU0Ss/KhP2nXxIKTTQs06XNcQ6fnGwAuxJw5paBHpKfJXOK9CbT99bb 2dJQ4s6DI1qcUUsRyzIhopX+1Vg7UKbCFRVrFH9iypm5Iy9uzt7zj3ueaWs7jlV49W6EKn hhyap6O+mMGuZY5D+18aiPInBWTRT4fymcvzMpcbhnKgOFAbX6s6DZB4ARW1NyU2X5xmOn 8j1CN6l4Qzgx7KqOHbiBVzgy+Sx+EBmWNnT3NU1R1dbWqroYp6X6AluNJ/K57A== From: Davide Masserut To: Po Lu , Eli Zaretskii Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <87cyyufi5k.fsf@yahoo.com> References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> <87cyyufi5k.fsf@yahoo.com> Date: Fri, 08 Sep 2023 17:49:43 +0200 Message-ID: <87fs3omzqg.fsf@mssdvd.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Po Lu writes: > Eli Zaretskii writes: > >>> From: Davide Masserut >>> Cc: Stefan Kangas , Eli Zaretskii , >>> 65509@debbugs.gnu.org >>> Date: Wed, 06 Sep 2023 16:01:58 +0200 >>> >>> It turns out that Emacs 29 has new CLI option that solves exactly these problems. >>> >>> The attached patch replaces the usage of --display=$DISPLAY with --reuse-frame. >> >> Po Lu, any objections to installing this on emacs-29? > > Yes. Davide, would you please rewrite the patch so that your change is > only applied to the PGTK port? Done. Po, why can't we use --reuse-frame in X builds? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Avoid-using-display-to-reuse-frames-in-PGTK.patch >From 43085522a08b94ef594bd270d61a38d7bb26e036 Mon Sep 17 00:00:00 2001 From: Davide Masserut Date: Thu, 24 Aug 2023 18:33:39 +0200 Subject: [PATCH] Avoid using --display to reuse frames in PGTK Using hard-coded display values can cause PGTK graphical frames to open using the wrong backend or not open at all. * Makefile.in (install-etc): Use --reuse-frame instead of --display=$DISPLAY. --- Makefile.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Makefile.in b/Makefile.in index fdd9353e254..c82aad1af60 100644 --- a/Makefile.in +++ b/Makefile.in @@ -843,6 +843,9 @@ EMACS_ICON= ifeq (${USE_STARTUP_NOTIFICATION},no) USE_STARTUP_NOTIFICATION_SED_CMD=-e "/^StartupNotify=true$$/d" endif +ifeq ($(HAVE_PGTK),yes) +USE_WAYLAND_DISPLAY_SED_CMD=-e "s/display=[^ ]*/reuse-frame/" +endif install-etc: umask 022; ${MKDIR_P} "$(DESTDIR)${desktopdir}" tmp=etc/emacs.tmpdesktop; rm -f $${tmp}; \ @@ -857,6 +860,7 @@ install-etc: sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ $(USE_STARTUP_NOTIFICATION_SED_CMD) \ + $(USE_WAYLAND_DISPLAY_SED_CMD) \ ${srcdir}/etc/emacsclient.desktop > $${tmp}; \ ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}.desktop"; \ rm -f $${tmp} @@ -870,6 +874,7 @@ install-etc: client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ + $(USE_WAYLAND_DISPLAY_SED_CMD) \ ${srcdir}/etc/emacsclient-mail.desktop > $${tmp}; \ ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}-mail.desktop"; \ rm -f $${tmp} -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 03:05:40 2023 Received: (at 65509) by debbugs.gnu.org; 15 Sep 2023 07:05:40 +0000 Received: from localhost ([127.0.0.1]:41923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh2tY-0006HK-09 for submit@debbugs.gnu.org; Fri, 15 Sep 2023 03:05:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh2tV-0006H7-6j for 65509@debbugs.gnu.org; Fri, 15 Sep 2023 03:05:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh2tI-0001ir-Qj; Fri, 15 Sep 2023 03:05:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZCw5AyPQTFeY5RwTzn19hOrultKLhhMAqSreb4Kw5mI=; b=DAn+uHtlCoTI gHNzk3tIVuVnSMyE5h54g6jeJN60/y/sIoDo0HIZJ+fyFnux/tJXzMvP3aP+h6ayEjM1IhjJpg7Ei EM0BMpxfIsLBnNzTkRGaVTwFo3TpXtSL75h7gCB6EAvu+1K9ovSFzWMvDeBjf3OpFMkA/CamTZ+0f lAQ/2ZoiOz74BzoPaQV1uPCN2nYND1tEAaiV0KhEP7jcbjoWS2ilHYJRqsDd5ORWk3O+OXKVv6mK5 13exLQAHYNHDoAtaQSlMLAyICXl4/CJDacsSxAti6p8di1F5yVD06mEuyoMmV5es1jxqvraBUDQJT MCVQrfo3SYnXBLLftbiuYg==; Date: Fri, 15 Sep 2023 10:05:16 +0300 Message-Id: <83wmwrkjbn.fsf@gnu.org> From: Eli Zaretskii To: luangruo@yahoo.com, Davide Masserut In-Reply-To: <87fs3omzqg.fsf@mssdvd.com> (message from Davide Masserut on Fri, 08 Sep 2023 17:49:43 +0200) Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> <87cyyufi5k.fsf@yahoo.com> <87fs3omzqg.fsf@mssdvd.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65509 Cc: stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Po Lu, could you please respond? > From: Davide Masserut > Cc: stefankangas@gmail.com, 65509@debbugs.gnu.org > Date: Fri, 08 Sep 2023 17:49:43 +0200 > > > Po Lu writes: > > > Eli Zaretskii writes: > > > >>> From: Davide Masserut > >>> Cc: Stefan Kangas , Eli Zaretskii , > >>> 65509@debbugs.gnu.org > >>> Date: Wed, 06 Sep 2023 16:01:58 +0200 > >>> > >>> It turns out that Emacs 29 has new CLI option that solves exactly these problems. > >>> > >>> The attached patch replaces the usage of --display=$DISPLAY with --reuse-frame. > >> > >> Po Lu, any objections to installing this on emacs-29? > > > > Yes. Davide, would you please rewrite the patch so that your change is > > only applied to the PGTK port? > > Done. Po, why can't we use --reuse-frame in X builds? > > > >From 43085522a08b94ef594bd270d61a38d7bb26e036 Mon Sep 17 00:00:00 2001 > From: Davide Masserut > Date: Thu, 24 Aug 2023 18:33:39 +0200 > Subject: [PATCH] Avoid using --display to reuse frames in PGTK > > Using hard-coded display values can cause PGTK graphical frames to > open using the wrong backend or not open at all. > > * Makefile.in (install-etc): Use --reuse-frame instead of > --display=$DISPLAY. > --- > Makefile.in | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Makefile.in b/Makefile.in > index fdd9353e254..c82aad1af60 100644 > --- a/Makefile.in > +++ b/Makefile.in > @@ -843,6 +843,9 @@ EMACS_ICON= > ifeq (${USE_STARTUP_NOTIFICATION},no) > USE_STARTUP_NOTIFICATION_SED_CMD=-e "/^StartupNotify=true$$/d" > endif > +ifeq ($(HAVE_PGTK),yes) > +USE_WAYLAND_DISPLAY_SED_CMD=-e "s/display=[^ ]*/reuse-frame/" > +endif > install-etc: > umask 022; ${MKDIR_P} "$(DESTDIR)${desktopdir}" > tmp=etc/emacs.tmpdesktop; rm -f $${tmp}; \ > @@ -857,6 +860,7 @@ install-etc: > sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ > -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ > $(USE_STARTUP_NOTIFICATION_SED_CMD) \ > + $(USE_WAYLAND_DISPLAY_SED_CMD) \ > ${srcdir}/etc/emacsclient.desktop > $${tmp}; \ > ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}.desktop"; \ > rm -f $${tmp} > @@ -870,6 +874,7 @@ install-etc: > client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ > sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ > -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ > + $(USE_WAYLAND_DISPLAY_SED_CMD) \ > ${srcdir}/etc/emacsclient-mail.desktop > $${tmp}; \ > ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}-mail.desktop"; \ > rm -f $${tmp} > -- > 2.42.0 > From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 03:12:43 2023 Received: (at 65509) by debbugs.gnu.org; 15 Sep 2023 07:12:43 +0000 Received: from localhost ([127.0.0.1]:41934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh30N-0006Ss-9s for submit@debbugs.gnu.org; Fri, 15 Sep 2023 03:12:43 -0400 Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:40618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh30K-0006Sd-R7 for 65509@debbugs.gnu.org; Fri, 15 Sep 2023 03:12:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694761949; bh=erV4yOaUlGr7ojmovV3Wzt/EN94/wW98rS7/wjZUmN0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=YukVnbuKJIPUdMgRHCPUHU4Cxl0RyO3UDnvf1hOA+QLiqjM1Lvx0yThG9qRjko88D+nuYBRT3FvZUVq3Nc1g0dnFUr45tAP8I5KZJkoLLkr4CTwqdd2i9nGjVpssZqWVfi1i0zAlQMUqr8uUv1/AyE9ogFTiONnNYKhedXsrqJ29bCIB4rOhkg28lQ+8+YGLJ5Il6mmDU5TRaMV66I2YysZYbvjAApvP/z548s5FDIy+C2hqJlN+kk/uoUgAyyhpyaCXfRhBrfw6PMlx9vz7jbEWIv37lqN6AkAXkKrQWLz2pwYi3RGHBoV0QCtrg4Fh6bB+LJ5GS6Kr9rS4+sK5Dg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694761949; bh=3P+CPGNOr3zv0wG1Mq6MOZwvFhCD24aZSf0qJf3TIvZ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jpLRqu20eFuTTA2bu16UUNkjzN/kSM/3MbDqIFt70Tv6mVF52CEBkrmjL0fJ1Yw5GMsCjRHWqrCfgu48jngzV0WuXm/PNxQ9Lo5aQkRM0BxSaJmdu3L4wJuYgxaD7E8Zd48Jbmt9sjou/7Qdwu4Kno5QgqptmfZiJusgqq+liIj7OPD0pSM35xZybY/Tb5ggqYc/x+/ZOgfzWelK3+rU1tyv0ysx8XgtTNWKdeMuZA0l5qKK9zgmhjfgU6RLQWWpefK7e7wypIycyxycgOk4BNIBjlceuTZ80QsLxIcUgpsKpM7wD33xsxpIwqsU60/4vZq/HUtXWwjPYM47Sv6eCw== X-YMail-OSG: IiNWO0IVM1mqarM1ZGdaiI5zJDnLvtrShclCyVLJoQxAYsbMm3D9iZEG3jVCh7s JS6YSPlPYOLQ7GRKRFeHQ.D7ZHH1jC5yNixxixxzMGcqGJJFrGbZejSZ_4_2.6lVe_0OrZBldh_r lVnGdbfegC4mJbMCUBBDHaYVbS50DhHbQ6512f9V4rr4QIk3Zf4Hdeo4IU2csLGF_p__HJPf4vJk 0BWg3ZqU.IzWI0P_zwmRSYY7XzsdYm6Ys4yVtXIDmA4mNL3h5Vt0lYrF3DI5HEN4K3x7oOfXmPND BujA_V9K2ddcyzXCUNU1oGmP_gfubndQKrA5HuVXFEmuOZAA53UeYldsh5a_G.ujfw18oULOq2ee DBoxJQp9dveST3xPUFYWrGL0dnpMFv8EjgXav2w6ADhBSPkfUyWRB6DJPC5xM6nmhcqDW_KWNJoX r2lb_yY7DyJGEMlyf9rotPaJYknMSmM8VU7TOCy5s7LvnQqq.MXj8EY_AbFbiEoWLuJBsH2638KG RDW0Hsqwd9Ne9kFuiHHti1fNP_ry7musDqFp8KNDyv1Fc8XG3Ff15SZ9rd_M.oaK1S7UXM4zUxhq sYSMrErJ2H9eSrzqxZLXKHzz5hJYNeRMJp7Zv6yGU6UeE3KZszOzNGTsT1M8NPjPWhhk6qRmpOZA E5DfItWxv6zgp64wlqti1IXNAv.8JyoLknLU4ZJgXsAypqxuny1OxPkKDhzWigLGH_EPL_b5uNRK adT3TxP8l7GyZNtkvAprAqwMlDNOB5NvgAwz.Jsiz54a4UulWPGx9Yx4x0p20tfBtTYrTH8uT9QQ gnS9hZqJM8QueJBSMKqo8ASuAi7dR6UV6.EgW4yP8XdpAeM1UUJC7iZQPGjZSrc2cBs5jKG8IPmq FgL7MNEjXTbT765L9TTqR.nylCgOhSwWWjIaIaycNudO_nTRTpoFiuqujBpnGyKIT41wNLzAuufb VvRTUQoq1A4Xqd90aTEn3xCB6Y.fNUNV.AWUBVp9YP2VHfgcZGHPk.6X470oWgjAbYaKX0rDigSC N.vKCzpeaSGtrWfA5MOS3Rf4DQx34tdlKX9JSAWv8R0aviGcDbtVDF6ooPqLvgkt5tq51Nyv7sSr lZg1H7r_dllYgnd6zM0li6lsyEur7iJxXznVfDiEC5UcQJbg2SujBCBb.gnlpvQYJGjkeKxx6jPH 4axEb2NqJDC8WCjlVBnJIbCqNskXlLk.uqyWjDi5V1aHs3i5euQeMsS1mZ_j1rjaVVlumzMwaiUi IoCm.8yO5RVVn_WCTQNUzsFFmnfgZWRqsi7TRSJncpmVb2iznFXjHbV50MxvHoLcZx42189ebpk4 1kIvz7hZ6NPrYbMXDQU1FMhfcqPPq5AyiHYxKIxy4lX8ZtTyawfYMLrC8cr2L8a0rDOW9Hs1SrjS KBWJu9k0odWPWUFhD0uz8DYN_WhNYdTWyTXQmUxNUcohyln4f7m0hJBZXY_4OHijwse7znOtLISF Au74RinfV3jQMsJJmjC1S9SEp20cI6Vz8pBpnbW7N_tnG15n3MpZknCOHxf2Gx1_wdGEZhn7xGWY RqRPhkqJW1Ikpkt_hE.2oDw9ckfOBlpUeMda3zesWi.Vkh10uhItnvzGAehPX45WXRfYziLwYV5A EM_KsWf9t11YjHX5FUpV4wlRPIb3mgkNcsGkD1CNUlsS7dQ1VxvwUxeO.B8QNuGlDXNIkZTginLl ifNadGCaHtEfXLaKn9jf7MDiEMQgxbTCO3obRE9l439jF7KeJnHFSjwR5DYBeJuF6seA.k6y3qeC u_VswP.KvOtkemIsUddWvrTZvP3BBLNU7XwhmQPI19yqJuMHN9iCccfXV2d6E2AJ2pQKUsAM_Tui t8qjOAeL64eU0Q9hCBq8UfXDczGNR3MZ9ZjDQ2RSqljcd7C.R5NZ.tjOsWXfCMMPumjos4xdyHQz M84LXgoKzriX3R40kSpgomxF53dUMi8DJookXj7C1t298mLg2pgyWnjwEVQmFjfE8QkIKhdWTgoB sdKc26_4AmXslgGgLRV_niQ86AAFZW8dbqvzpKGOMtKhTrwfJpcTXCEcNAwvya7dJwOsD4OjcSLf _zds30A21npgToxUinVn9ek4mOMZ2lZfmXC7o1CJiZ9Ou6VtyobPEMmtHe5S_wC1qAizAN_esQkI mvxoZ_QD0hhbBHV9vC2o1m5PyNcsgmiPt7kNe.XiseUKfQuEwyIGKvnWkwrvw53srDGH4lsLHFHR _7ACE2Q3fVbrw9WxlryInOrXsqTgyoTrYSCCjPmWCh4RAykOX7TPqtFKCRNztc9uqus8- X-Sonic-MF: X-Sonic-ID: 87430058-25ce-4d4a-8170-7a2021ce9dbd Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Fri, 15 Sep 2023 07:12:29 +0000 Received: by hermes--production-sg3-55c667b499-gg78d (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 046767a2ce5402beb943616d2735f645; Fri, 15 Sep 2023 07:12:22 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <83wmwrkjbn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Sep 2023 10:05:16 +0300") References: <87ttsomgb5.fsf@mssdvd.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> <87cyyufi5k.fsf@yahoo.com> <87fs3omzqg.fsf@mssdvd.com> <83wmwrkjbn.fsf@gnu.org> Date: Fri, 15 Sep 2023 15:12:16 +0800 Message-ID: <87ttrvzz8v.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 2955 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 65509 Cc: Davide Masserut , stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Ping! Po Lu, could you please respond? > >> From: Davide Masserut >> Cc: stefankangas@gmail.com, 65509@debbugs.gnu.org >> Date: Fri, 08 Sep 2023 17:49:43 +0200 >> >> >> Po Lu writes: >> >> > Eli Zaretskii writes: >> > >> >>> From: Davide Masserut >> >>> Cc: Stefan Kangas , Eli Zaretskii , >> >>> 65509@debbugs.gnu.org >> >>> Date: Wed, 06 Sep 2023 16:01:58 +0200 >> >>> >> >>> It turns out that Emacs 29 has new CLI option that solves exactly these problems. >> >>> >> >>> The attached patch replaces the usage of --display=$DISPLAY with --reuse-frame. >> >> >> >> Po Lu, any objections to installing this on emacs-29? >> > >> > Yes. Davide, would you please rewrite the patch so that your change is >> > only applied to the PGTK port? >> >> Done. Po, why can't we use --reuse-frame in X builds? >> >> >> >From 43085522a08b94ef594bd270d61a38d7bb26e036 Mon Sep 17 00:00:00 2001 >> From: Davide Masserut >> Date: Thu, 24 Aug 2023 18:33:39 +0200 >> Subject: [PATCH] Avoid using --display to reuse frames in PGTK >> >> Using hard-coded display values can cause PGTK graphical frames to >> open using the wrong backend or not open at all. >> >> * Makefile.in (install-etc): Use --reuse-frame instead of >> --display=$DISPLAY. >> --- >> Makefile.in | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Makefile.in b/Makefile.in >> index fdd9353e254..c82aad1af60 100644 >> --- a/Makefile.in >> +++ b/Makefile.in >> @@ -843,6 +843,9 @@ EMACS_ICON= >> ifeq (${USE_STARTUP_NOTIFICATION},no) >> USE_STARTUP_NOTIFICATION_SED_CMD=-e "/^StartupNotify=true$$/d" >> endif >> +ifeq ($(HAVE_PGTK),yes) >> +USE_WAYLAND_DISPLAY_SED_CMD=-e "s/display=[^ ]*/reuse-frame/" >> +endif >> install-etc: >> umask 022; ${MKDIR_P} "$(DESTDIR)${desktopdir}" >> tmp=etc/emacs.tmpdesktop; rm -f $${tmp}; \ >> @@ -857,6 +860,7 @@ install-etc: >> sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ >> -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ >> $(USE_STARTUP_NOTIFICATION_SED_CMD) \ >> + $(USE_WAYLAND_DISPLAY_SED_CMD) \ >> ${srcdir}/etc/emacsclient.desktop > $${tmp}; \ >> ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}.desktop"; \ >> rm -f $${tmp} >> @@ -870,6 +874,7 @@ install-etc: >> client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ >> sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ >> -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ >> + $(USE_WAYLAND_DISPLAY_SED_CMD) \ >> ${srcdir}/etc/emacsclient-mail.desktop > $${tmp}; \ >> ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}-mail.desktop"; \ >> rm -f $${tmp} >> -- >> 2.42.0 >> That was lost in the spam filter. I'd rather not use --reuse-frame under the X build, because that's not safe for Emacs 29. This LGTM now. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 03:32:57 2023 Received: (at 65509) by debbugs.gnu.org; 15 Sep 2023 07:32:58 +0000 Received: from localhost ([127.0.0.1]:41945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh3Jx-00071t-Gg for submit@debbugs.gnu.org; Fri, 15 Sep 2023 03:32:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh3Jr-00071Z-Vr for 65509@debbugs.gnu.org; Fri, 15 Sep 2023 03:32:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh3Jg-0007Hy-6q; Fri, 15 Sep 2023 03:32:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qaA9/YP/yDC9K3wbPFj5j+Kqd6d9VSbSc4/Gy6UykfA=; b=Qx61QrZex5GQ AZFQW6IRhbVMJMegbnp6HU2WU2e3j5bDIR3fAARyLRTSK1KBvexu5zKJfgGKGqxDWpBIZgBWzvhS3 PwLIF02R8yEu6l7yR/6DHgUxktp64tAwZcH5MM5C1oxuDkTZWpI3vuOQXKozfnUyZwvifxVEmXD8z j80QLXfaYwrdCi0TT+3kEX69hHlEh8/L0J+SSqGnKsTsuKhMRS4I/CEp5sZh8Gn1d6YeHt5OcZWtS wbSUOOZAeEUtkX2h2tIejmKkClJiKTI1Tg0rvM+8j5xy6lB/wHNxK5qfKKjTtlfcrBG8XuzgbtaVU UmWPN+mFpx4X7BHHdz8abg==; Date: Fri, 15 Sep 2023 10:32:29 +0300 Message-Id: <83r0mzki2a.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87ttrvzz8v.fsf@yahoo.com> (message from Po Lu on Fri, 15 Sep 2023 15:12:16 +0800) Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries References: <87ttsomgb5.fsf@mssdvd.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> <87cyyufi5k.fsf@yahoo.com> <87fs3omzqg.fsf@mssdvd.com> <83wmwrkjbn.fsf@gnu.org> <87ttrvzz8v.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65509 Cc: dm@mssdvd.com, stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: Davide Masserut , stefankangas@gmail.com, > 65509@debbugs.gnu.org > Date: Fri, 15 Sep 2023 15:12:16 +0800 > > Eli Zaretskii writes: > > > Ping! Po Lu, could you please respond? > > > >> From: Davide Masserut > >> Cc: stefankangas@gmail.com, 65509@debbugs.gnu.org > >> Date: Fri, 08 Sep 2023 17:49:43 +0200 > >> > >> > >> Po Lu writes: > >> > >> > Eli Zaretskii writes: > >> > > >> >>> From: Davide Masserut > >> >>> Cc: Stefan Kangas , Eli Zaretskii , > >> >>> 65509@debbugs.gnu.org > >> >>> Date: Wed, 06 Sep 2023 16:01:58 +0200 > >> >>> > >> >>> It turns out that Emacs 29 has new CLI option that solves exactly these problems. > >> >>> > >> >>> The attached patch replaces the usage of --display=$DISPLAY with --reuse-frame. > >> >> > >> >> Po Lu, any objections to installing this on emacs-29? > >> > > >> > Yes. Davide, would you please rewrite the patch so that your change is > >> > only applied to the PGTK port? > >> > >> Done. Po, why can't we use --reuse-frame in X builds? > >> > >> > >> >From 43085522a08b94ef594bd270d61a38d7bb26e036 Mon Sep 17 00:00:00 2001 > >> From: Davide Masserut > >> Date: Thu, 24 Aug 2023 18:33:39 +0200 > >> Subject: [PATCH] Avoid using --display to reuse frames in PGTK > >> > >> Using hard-coded display values can cause PGTK graphical frames to > >> open using the wrong backend or not open at all. > >> > >> * Makefile.in (install-etc): Use --reuse-frame instead of > >> --display=$DISPLAY. > >> --- > >> Makefile.in | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Makefile.in b/Makefile.in > >> index fdd9353e254..c82aad1af60 100644 > >> --- a/Makefile.in > >> +++ b/Makefile.in > >> @@ -843,6 +843,9 @@ EMACS_ICON= > >> ifeq (${USE_STARTUP_NOTIFICATION},no) > >> USE_STARTUP_NOTIFICATION_SED_CMD=-e "/^StartupNotify=true$$/d" > >> endif > >> +ifeq ($(HAVE_PGTK),yes) > >> +USE_WAYLAND_DISPLAY_SED_CMD=-e "s/display=[^ ]*/reuse-frame/" > >> +endif > >> install-etc: > >> umask 022; ${MKDIR_P} "$(DESTDIR)${desktopdir}" > >> tmp=etc/emacs.tmpdesktop; rm -f $${tmp}; \ > >> @@ -857,6 +860,7 @@ install-etc: > >> sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ > >> -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ > >> $(USE_STARTUP_NOTIFICATION_SED_CMD) \ > >> + $(USE_WAYLAND_DISPLAY_SED_CMD) \ > >> ${srcdir}/etc/emacsclient.desktop > $${tmp}; \ > >> ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}.desktop"; \ > >> rm -f $${tmp} > >> @@ -870,6 +874,7 @@ install-etc: > >> client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ > >> sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ > >> -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ > >> + $(USE_WAYLAND_DISPLAY_SED_CMD) \ > >> ${srcdir}/etc/emacsclient-mail.desktop > $${tmp}; \ > >> ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}-mail.desktop"; \ > >> rm -f $${tmp} > >> -- > >> 2.42.0 > >> > > That was lost in the spam filter. I'd rather not use --reuse-frame > under the X build, because that's not safe for Emacs 29. Why is it not safe? > This LGTM now. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 03:44:30 2023 Received: (at 65509) by debbugs.gnu.org; 15 Sep 2023 07:44:30 +0000 Received: from localhost ([127.0.0.1]:41968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh3V8-0007Lj-2i for submit@debbugs.gnu.org; Fri, 15 Sep 2023 03:44:30 -0400 Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:44761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh3V5-0007LQ-DU for 65509@debbugs.gnu.org; Fri, 15 Sep 2023 03:44:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694763855; bh=l3fa0t2YwQGAxuxsUq6u8OVpZfmMdrSSG32pjiuc6ms=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=bVB0Ac9G0CqsUmc8vsXscIRFPsWpHTxNyO5HZxZGbo+wAnNX6Zdtry81aIUsL2VEoc+Z33z+Ntr5cFAGR9XZOnN/p23xX2wib2G/SsAAeOEsp2z+QBajGVtw/lSp2vmFKWbL/aMnaYdiziMKka/2OWcURr+mKnEDJ+YqNedmhb9QYAA0oSyxlSlnf2B56GF8VzXMX2o7JvRipxQBHnF//u03m4vCQBp3Z7Un/1FY5lszRP/mJ6i7OLk6yINrQkEWD71/jLg4U1jLREO+aCXThyw67GzFQi5HOvsuI38iZ+u7niVQ4AwRKcNCaALH6/4nVrfSNDiatZYsNg/XZVDXWQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694763855; bh=U4l4Tm4XTpDnqeZwGkhrNjOuBRzw/I7tvL3o63lvzdw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=FEPfuTyNjBT0ayBfDPxOCg8kjIDOUUWpkbIKpFwQusEgiEc/WbFiyXgSxzs6Sg1kuqdFPtRtjgKcbfhEtko4qsWSNR5tl3QwusJPOiL8cYQP3DfWRfl6+qjuzxydHYRnb8/46bHFHbZJKF6ayI1WXq+GZWyqhxg6WhftloxxHbBSa1RgsyWWk0hWugrZznBg7iaHJzS1lJ/OpD1yVHwb2kk9o6wFvRS+jawGBo/b64klKPVqzFVnnrDgikZyDbOSO/x8wVKfRqtPVZorHqN3/uZMOVCLPAs69T5mZO0x/f1zvSxjL3624OTNQ3cjHgK/rZw3dcqCViLFIBBv3/ys9A== X-YMail-OSG: b4DmOGoVM1naonhp1zMrzX5neOA4PCpH6e89jnKW3gYo7SioBl5lQAZMrGxNuNM 8DBcPiW6_kHnj8A2KGzh4weqzOs8dSFXFxZVj5S2Gis1z9e7C33oPjXF5iwJ4rxzW_P.61To87v8 ig2tbC2CpEjQKGQSWSmo5qvJNXRed8WwujxR0.ivMOAZwjkr.x.qAtqmo.h_JGxqSzlsqfmN.4Cy U9bpojVCtPjPEzwBs.BANlMLk7OopHgctaVsXlJQZQNwR_tPVNE4aRaVBo1klm5nwNLhhrUIUmCR Cp9YxwOzafJyRPhddpOjhufJ5P0xNkrGhEuq4OAu025w42RxkGG4yL3z8CH9J9Pc1ECGlRpHMBZG nBI17aDESYabCfa5WJm7Bjn6nktxsjocIm2jcAzCwkNjBppk1ftabjJUYfQq6O_hUz7kN15x_Mma _KJc3tubWKbTS3dIXeDxsX9hPH8mIUWQdJK24e41Q1d3kirxTKjxblUSIPuw2ucKkWrVWHfctmPX MZkl8FWe77pSzVHYgmZQVwYOyOWUnvGEhwqYeGls6gPup.5dVK_ZvvHSlKibSHIqkDsll4e7XhWd 5BOjsuQZ6.Icud6btaz29WVrrNJeG_vzPmqT3Mrr1rm3Z9OGvl0lKJYk7vQ.elijhHjmPNlB1Cfn n_Ht89OQZLD.tC8tA1u6VP23ptj2H8LubRBTWoQPCgoEuU4GIKkCMCE04E7P6eem1srzoOXBVFAP eqpF6A.xzal8iZCo.i0FvV4BttksAS9yuBVULZN5vNuQbVw4wz3r_6A3A8ZKqXqT5hlVWijjbhRq fWzahvuno6MIE2F4bbut5QDq56bWPlbSbb7.nJg2I8UzMR31WXw5BoGAVsTKf9Q8u62Bx7Z90l4I kfc7wYYJuakDCLadoodZGbAdGmCvPdGTf_OTn7czlVhI0Peb8etHcqxVB5ABk9lzdjBWY45ZtqIT gE_GkW2mCz6j5FsvZtNiUBs6x6_loqNh7Ur76LGp.cudNr_H0wmT9PWUQzYEhdqMOW2Ns1AwNpZX KksdAub.qW_PvovHiGylwf1Qr3gyBGvDg9yG51C.yedrQ.RFvrZ5.16of_UwqmnkW5f15hQ5ieSd p8CUeiirTABrExuTO3Vp.H0uk26dJ_q8qpleL1w7w00UL1Mbp2oaQrWRvgbTIB3TjIQNP8wK8nGo fBZFpboziAR82ceUe35DQSmDYm8G7WzUq6xp2Bvazd1KVF2QhfJ_YRMu223k4LQcxr3KiHf66Re9 mlDQBivRF5dsBP5sha5pSnXTliHTEEZn0jwigBNNFHnIR9kZoLN9lLMzc3emnnQrJqTwZq10FWJS LtEaIsvhEBcQb5cyFmmWhqNIZqBvBMEvnB43i7PvFJf.ONQodlHJuwqcFhwMtODdBuK_OVhDzirS Ge3J8sDIwX3C_W.uWPrFxi1SMFT1dXURTFNw.wJIyI5GV_M5r7bx2zFx1ulAM3Ro_Og40XUhLpDD O93DbTUmxm4jE966Pu9Fb1fWcYlpOWeNaJbqZrUS4PgIOn1BdHgFLl.jFRa9AU88PPRSOmlDkFhp vycKt8CioRvHAenrU3N1DRj4lzJIybPsqi9acxsL3awILAh4SqFnbWI0Na49ZcRXpIzVhQMhlbt2 8EEefgppzIjSQTMpOLUGy_a_7o3FWks42kZYPhjGouNORaY_97rO7hpGNFDNCtKDMdBiRwgOn4N9 XA.7NZ40NZbflhyFDMO45Xdxn99FdONrut18dhVtdr0BKaq98KnsbRMJM3DfJGHhldw29uYst5jS 4uqA7p75CVrjU_1dpHOS5q9bqctNHQap2M1WI7AtZfkjKNmvuMIhCqskCk9Abi.cRQGopq2SkSj_ HWZcYVGTdmQE0VjI64kyrclV73PL0lOC2W6Hm7Wn.mRbtK.YJ4udOhlVRZbq0Hq.Cnii82z0zE5E VrxoXsc5gPmmZr5ijvfUBRDvliOyuNOQnVN6PDo2bgDo.HMrXt.hUOzaNfY9EMmEjM7Ixo.KjUzg mSR7Tr23ysT8cX3mmvh7ArwOjH4VputFFsY_6TI9fLTC.HvaUrqqOmgnfs1ouIZwx07DiS5xCZMk uwzaVZK9.l8wqKC.r7.MMtzRTUu_9jsYp1Sgw.uBOkyxomoylqGDJnqrnMSSTi1b9Aol8i0CYQzG a71slNwh88mypK0uS83PLdRWvzRmRtrqMqjdhE0_gxxpHB5svU9nouEADvjg5k39vSWa1rzi_zst jiWzIx4WzmDu.m9nncQFNBNt6Dci_RrMFu5YLdAqeoOX1qWztKf8t2rlpYOagdw1nvhPhLw-- X-Sonic-MF: X-Sonic-ID: 0f50faf4-29d9-4708-88dc-4e86e6ef622a Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Fri, 15 Sep 2023 07:44:15 +0000 Received: by hermes--production-sg3-55c667b499-wx5qv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID be478a3db9ae31857650b6dd86940d15; Fri, 15 Sep 2023 07:44:11 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries In-Reply-To: <83r0mzki2a.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Sep 2023 10:32:29 +0300") References: <87ttsomgb5.fsf@mssdvd.com> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> <87cyyufi5k.fsf@yahoo.com> <87fs3omzqg.fsf@mssdvd.com> <83wmwrkjbn.fsf@gnu.org> <87ttrvzz8v.fsf@yahoo.com> <83r0mzki2a.fsf@gnu.org> Date: Fri, 15 Sep 2023 15:44:02 +0800 Message-ID: <87pm2jzxrx.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 194 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65509 Cc: dm@mssdvd.com, stefankangas@gmail.com, 65509@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Why is it not safe? Because there was previously no problem with the X build under Emacs 29, and using --reuse-frame there would chance introducing one. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 07:34:53 2023 Received: (at 65509-done) by debbugs.gnu.org; 15 Sep 2023 11:34:54 +0000 Received: from localhost ([127.0.0.1]:42274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh765-0002MA-Jl for submit@debbugs.gnu.org; Fri, 15 Sep 2023 07:34:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh763-0002Lu-82 for 65509-done@debbugs.gnu.org; Fri, 15 Sep 2023 07:34:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh75q-00017V-VU; Fri, 15 Sep 2023 07:34:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4c2OqP7dquhRZZLlVDpLVdCS92Ln1Z1RMhumqNTRj/4=; b=mKit9qSUsk5S Y8cblpIQ/G5BkXWuOtG4k9ZKR1YV9Ug122rFThgPLqs+/56/Ondf6CW0iXi7j9gMnUC6PKUmqT7zQ KKkNE/TxOgC7sVhV3Wh5SSX159Gs7JR3RxomiJf/AQQPZqT4UbfA4IdnEMflI5sBxAvjsrnuQGyeM CGlyax8T2hYVTt7mIF8DopCPip0whStn61h31eTJhU9IJVIwIUu9lep2andM4OGuRke4t7r++xegK /u9VQs33KeFhI7Afd34VCMPCG8S3GSR7ChhQ7HYX6GTrCrPLc3E8E51NWtmsTMUo2DPuQhWfZ51Uj +GGql6/9M4P9T+9hGtCznA==; Date: Fri, 15 Sep 2023 14:34:29 +0300 Message-Id: <83msxnk6uy.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87pm2jzxrx.fsf@yahoo.com> (message from Po Lu on Fri, 15 Sep 2023 15:44:02 +0800) Subject: Re: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries References: <87ttsomgb5.fsf@mssdvd.com> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> <87cyyufi5k.fsf@yahoo.com> <87fs3omzqg.fsf@mssdvd.com> <83wmwrkjbn.fsf@gnu.org> <87ttrvzz8v.fsf@yahoo.com> <83r0mzki2a.fsf@gnu.org> <87pm2jzxrx.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65509-done Cc: dm@mssdvd.com, stefankangas@gmail.com, 65509-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: dm@mssdvd.com, stefankangas@gmail.com, 65509@debbugs.gnu.org > Date: Fri, 15 Sep 2023 15:44:02 +0800 > > Eli Zaretskii writes: > > > Why is it not safe? > > Because there was previously no problem with the X build under Emacs 29, > and using --reuse-frame there would chance introducing one. OK, installed on emacs-29 and closing the bug. Thanks. From unknown Thu Jun 19 14:03:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Oct 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator