GNU bug report logs - #65491
[PATCH] Improve performance allocating vectors

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 65491 <at> debbugs.gnu.org, mattias.engdegard <at> gmail.com, monnier <at> iro.umontreal.ca
Subject: bug#65491: [PATCH] Improve performance allocating vectors
Date: Sun, 17 Sep 2023 19:44:59 +0300

> Date: Sun, 17 Sep 2023 09:37:29 -0700
> Cc: mattias.engdegard <at> gmail.com, 65491 <at> debbugs.gnu.org,
>  monnier <at> iro.umontreal.ca
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> On 2023-09-17 09:15, Eli Zaretskii wrote:
> > Even though the code is so completely obfuscated and hard to
> > understand?
> 
> If it's confusing, let's add a comment. That would be better than 
> unnecessarily duplicating the actual code.

Feel free to add any comments you find useful, that is always welcome.
But comments about complicated code have one downside: they need to be
updated when the code changes, and people forget to do that...

> > We also have USE_LSB_TAG and LISP_WORDS_ARE_POINTERS
> 
> Yes, and we should minimize dependencies on those macros as well.

My point is that XUNTAG depends on both of those as well.

> > I frequently find it easier to fire up GDB
> > and ask it to show me the values
> 
> Oh, I do that all the time too, with both Emacs and other programs. It's 
> OK. Why refuse help from GDB?

C code is supposed to be easily readable.  Going to GDB means it
isn't.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.