From unknown Fri Jun 20 18:16:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65487 <65487@debbugs.gnu.org> To: bug#65487 <65487@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization Reply-To: bug#65487 <65487@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:16:44 +0000 retitle 65487 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initi= alization reassign 65487 emacs submitter 65487 Christoph severity 65487 normal tag 65487 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 02:57:49 2023 Received: (at submit) by debbugs.gnu.org; 24 Aug 2023 06:57:49 +0000 Received: from localhost ([127.0.0.1]:36002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ4Hs-0000nS-F8 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 02:57:49 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYrvz-0002nE-34 for submit@debbugs.gnu.org; Wed, 23 Aug 2023 13:46:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYrvH-0002i6-Gm for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 13:45:50 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYrvF-0000Oi-A1 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 13:45:38 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-50091b91a83so2502869e87.3 for ; Wed, 23 Aug 2023 10:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1692812733; x=1693417533; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=+J3J39iLHKB+EbhYT2kwTRKXwQZU7lXYIv2+z3NJ1J8=; b=AEa1oPb1989Sfvd1QCJqABNMrWQT3Eh1oBpEMMi+2feKBcGlWylOAYawm8lYtOQ9I5 atj4SYn//hC0l2sa3PIsF/QnzugIL6HiyptYLtkH6Ugr291f7BON7IYyESVpMp6rDhzG 4yDTHB0IGhC04db5mLLgHPCq/prYg4Zwz2dl9RY7e3oYi+pT3D8OR/fEEnBUb7tHapIo ZGoNkUEQJzzP342ndW93cVp0cM6tddmPaDuuTVip8Cf4CKZ25fFbac5am1+OS3sI5Njr gvrF3d/DwigaS7XuwpMBUQFFZXtrzZW6vytdHCfhB0r2+NX0p7N22+RuSLcyg4i0RKM/ kQ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692812733; x=1693417533; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+J3J39iLHKB+EbhYT2kwTRKXwQZU7lXYIv2+z3NJ1J8=; b=bB5GrG3VSnAQYiEtnKsKp9rJddrokCvXu7nZCcQ7asACziuQj0C/lfc6m3y8R3A2Q7 ewgzUIunlY2K+LGUk+8qx86CTsJ6/bwThUDNdvXKjN+IqocsOzcKxQeSvLhMPf6abBUq JKNA9coUeFkVcV8HIVOZldcAKkjrcH1AaiKCSLePHfhLxmoKY0ALuBXIa8CrJM/iA6ym 0nSQgDAHtXfR1FXisWuwcgf7trSDft3hJH/6jzOI82ikzo0rEVyrZ/3qnRRulwjQCVUM DBRbe0CX77o6hEbfYVsdAvZuYLxatdfLmrqJYLLu57ASvFAHsj7C0Lelnu/3PtwPyDa2 FDTw== X-Gm-Message-State: AOJu0YzAUF2pJ4mrjyMB/RpxT6NyqwNI33oYipOeP7ITfRoOrRetixXm d09D/8dalH4i6sTZRHLq5FCTIHr0fXPMVz6Qczas3clP X-Google-Smtp-Source: AGHT+IHoQPXNHcEeG+i7HoGUUxF+ivtZHaeubOCmPmZeUGqai1MqbATZPiuJa4DZh1szpwAO2ztblKDIdd+8MI1K7ok= X-Received: by 2002:ac2:533c:0:b0:500:78ee:4d03 with SMTP id f28-20020ac2533c000000b0050078ee4d03mr7634118lfh.69.1692812732929; Wed, 23 Aug 2023 10:45:32 -0700 (PDT) MIME-Version: 1.0 From: Christoph Date: Wed, 23 Aug 2023 19:45:21 +0200 Message-ID: Subject: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000009eaa5c06039aad1a" Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=just.mychris@googlemail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 24 Aug 2023 02:57:44 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000009eaa5c06039aad1a Content-Type: text/plain; charset="UTF-8" Hi, while browsing the sources of `make-mode', I noticed that the variable initialization of `makefile-browser-client' is wrong. It is initialized with its documentation string. This is not a really a problem, the makefile browser still works, but the documentation string is lost as soon as the browser is opened once. -- Christoph --0000000000009eaa5c06039aad1a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-makefile-browser-client-variable-initialization.patch" Content-Disposition: attachment; filename="0001-Fix-makefile-browser-client-variable-initialization.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_llo0uf9q0 RnJvbSA3NjhlNDhlNThhNjYxYmQwNDVhMjVkYWNiZWJjY2RiOGNiMjZkZDg1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Q2hyaXN0b3BoPTIwRz1DMz1CNnR0c2Noa2Vz Pz0gPGp1c3QubXljaHJpc0Bnb29nbGVtYWlsLmNvbT4KRGF0ZTogV2VkLCAyMyBBdWcgMjAyMyAx OTozNDoxNCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCAnbWFrZWZpbGUtYnJvd3Nlci1jbGll bnQnIHZhcmlhYmxlIGluaXRpYWxpemF0aW9uCgoqIGxpc3AvcHJvZ21vZGVzL21ha2UtbW9kZS5l bCAobWFrZWZpbGUtYnJvd3Nlci1jbGllbnQpOgpJbml0aWFsaXplIHRvIG5pbAotLS0KIGxpc3Av cHJvZ21vZGVzL21ha2UtbW9kZS5lbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL21ha2UtbW9k ZS5lbCBiL2xpc3AvcHJvZ21vZGVzL21ha2UtbW9kZS5lbAppbmRleCAwMTdhNTUxYmMwNS4uZmYy YWExMzc4MTMgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL21ha2UtbW9kZS5lbAorKysgYi9s aXNwL3Byb2dtb2Rlcy9tYWtlLW1vZGUuZWwKQEAgLTY5NSw3ICs2OTUsNyBAQCBtYWtlZmlsZS1t YWNyby10YWJsZQogICAiVGFibGUgb2YgYWxsIG1hY3JvIG5hbWVzIGtub3duIGZvciB0aGlzIGJ1 ZmZlci4iKQogKHB1dCAnbWFrZWZpbGUtbWFjcm8tdGFibGUgJ3Jpc2t5LWxvY2FsLXZhcmlhYmxl IHQpCiAKLShkZWZ2YXIgbWFrZWZpbGUtYnJvd3Nlci1jbGllbnQKKyhkZWZ2YXIgbWFrZWZpbGUt YnJvd3Nlci1jbGllbnQgbmlsCiAgICJBIGJ1ZmZlciBpbiBNYWtlZmlsZSBtb2RlIHRoYXQgaXMg Y3VycmVudGx5IHVzaW5nIHRoZSBicm93c2VyLiIpCiAKIChkZWZ2YXIgbWFrZWZpbGUtYnJvd3Nl ci1zZWxlY3Rpb24tdmVjdG9yIG5pbCkKLS0gCjIuNDIuMAoK --0000000000009eaa5c06039aad1a-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 03:25:39 2023 Received: (at 65487-done) by debbugs.gnu.org; 24 Aug 2023 07:25:39 +0000 Received: from localhost ([127.0.0.1]:36024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ4ip-0001XD-Cs for submit@debbugs.gnu.org; Thu, 24 Aug 2023 03:25:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ4im-0001Wz-1g for 65487-done@debbugs.gnu.org; Thu, 24 Aug 2023 03:25:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ4ic-00016l-PS; Thu, 24 Aug 2023 03:25:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Orc2BDsL4VC++L4dWKdhPBM0Os13fZmXu+y/0EZqu5w=; b=hEryIteRltPG nDjizOA81psEoWwe2GTPHp50eE6ywOYNuS8Dz2kYfk23IvRJazkSnhQehmEVq9fUQIAWb3J5gM5BN E3KhgsbIHdoFZJSaHvOrK4qJmCAYdF22/F6/r0DYrHum8TnH43S5PgmcXlW+UOqaRnPYO1HOVIUko N1zHTYEqxaQfrPny8oMyeVPjr0Ye5AsEft6vQZTh4ZokBU4XVOxSD2mlRxaZSFonSmFxqnAzzOaWM bM9K+qTf6n4mCl6bJD8t7D56dHxHJIgdlMAZAiD9I8GsWZCnQgIkpKCqzUj+C28J5NCVbkJ2Hynzd K3EXHpWP+AJ/6eohTvsmdQ==; Date: Thu, 24 Aug 2023 10:25:50 +0300 Message-Id: <834jkorjep.fsf@gnu.org> From: Eli Zaretskii To: Christoph In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65487-done Cc: 65487-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 23 Aug 2023 19:45:21 +0200 > From: Christoph via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > while browsing the sources of `make-mode', I noticed that the variable > initialization of `makefile-browser-client' is wrong. It is > initialized with its documentation string. This is not a really a > problem, the makefile browser still works, but the documentation > string is lost as soon as the browser is opened once. Thanks, installed on the emacs-29 branch, and closing the bug. (It amazes me how such a glaring mistake could go undetected since 1992.) From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 17:02:12 2023 Received: (at 65487) by debbugs.gnu.org; 24 Aug 2023 21:02:12 +0000 Received: from localhost ([127.0.0.1]:38733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHT1-0004Uj-U5 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 17:02:12 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:57637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHSy-0004UL-K7; Thu, 24 Aug 2023 17:02:09 -0400 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-5009969be25so349922e87.3; Thu, 24 Aug 2023 14:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692910918; x=1693515718; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=47+vXmuTaL4WqFvoSAubw1Cdk25kZUpf8YZ39j37+vI=; b=YqfZQU/87BUVRprgNE2svDofDE6kUuGiMWKmXWUuV/sQF3bDPJphSUjojfC4IJX6oJ dYgxo4ZgfIYXqkkDikTxrcp47QMp/uypVTheVY4QsGLi//jm9wSN0j694jxCvRNdDoA5 g1zLG9YE1YMlQ17/EInGsluwNhsglWPQhb31Umadgl2l/v3wIo33yf/SUdeLLOaEYy52 W//+7OWQzvXFkCeO4l3ykWZlIBEa1XjPTRff3hnskT08AgT0eEHcQkiFZyu1Lm97DRnv fsmogg1sp2oD1N+4MTCoteKSId//OILYQkavBCdNzl8Yg/ISzkoeY+ORxLXwdaIrgQg0 nYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692910918; x=1693515718; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=47+vXmuTaL4WqFvoSAubw1Cdk25kZUpf8YZ39j37+vI=; b=DjeLJvbaSGTQL9IR9++75CORzGgCRA1i8aY0RJeDgT7Eyg0wF3XO51HC3Uq5bMWB/o +pjWQUi8lpkY8wgx3gjHQFgwARRQpuQ40KwaX4VkFaRq+CgFBp/67XhvJlbxtSQ5LC4E JwiCO4eyMbjyNW4S+QxsToQL3uTbdHQCPYOiBe+OWuSi6KHQNBEtWA/A7uNLBSBHh7iU +kuOALT+k1KQzRAu3aXgxcreXZEXi82XVjuvemsOiojmzxlpE6/nez6PcBSJ/NlXHxjD F6JG7db7D4Uq8hpD69LsXsKeCEPMow0VhEY3z/CQEJjKo7DXtwXXeXkQC2nrpEldvZqD Pt3g== X-Gm-Message-State: AOJu0Yz0GEG5emXLWT+8Xd536YjlzcUHEFaj191U8InfGATBkrGKuJyc Ppxcd4550SQcI02snUb3prNecIOiFW7UqYEH+dEgFRCslCI= X-Google-Smtp-Source: AGHT+IE5s3V7gdH8OY0OjA7k9FcwZB2zK2DjapRbSYEQSQBdWE870q/b1cQl9p6yF8EXlKg9hw6uPC+qASyAGzQxRUk= X-Received: by 2002:a05:6512:3299:b0:500:a3be:1ab6 with SMTP id p25-20020a056512329900b00500a3be1ab6mr1139384lfe.6.1692910918221; Thu, 24 Aug 2023 14:01:58 -0700 (PDT) MIME-Version: 1.0 References: <834jkorjep.fsf@gnu.org> In-Reply-To: <834jkorjep.fsf@gnu.org> From: Stefan Kangas Date: Thu, 24 Aug 2023 23:01:47 +0200 Message-ID: Subject: Re: bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization To: 65487@debbugs.gnu.org, eliz@gnu.org, just.mychris@googlemail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65487 Cc: 65487-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > (It amazes me how such a glaring mistake could go undetected since > 1992.) It might have something to do with this comment in that file: ;; * Consider removing browser mode. It seems useless. Also see Bug#58848: "Make makefile browser mode obsolete?". From unknown Fri Jun 20 18:16:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 Sep 2023 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator