Subject: bug#65487: closed (Re: bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 24 Aug 2023 07:26:01 +0000

Your bug report

#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
65487: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65487
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization
From: Eli Zaretskii <[email-masked]>
To: Christoph <[email-masked]>
Cc: [email-masked]
Date: Thu, 24 Aug 2023 10:25:50 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> Date: Wed, 23 Aug 2023 19:45:21 +0200
> From:  Christoph via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <[email-masked]>
> 
> while browsing the sources of `make-mode', I noticed that the variable
> initialization of `makefile-browser-client' is wrong. It is
> initialized with its documentation string.  This is not a really a
> problem, the makefile browser still works, but the documentation
> string is lost as soon as the browser is opened once.

Thanks, installed on the emacs-29 branch, and closing the bug.

(It amazes me how such a glaring mistake could go undetected since
1992.)

Subject: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization
From: Christoph <[email-masked]>
To: [email-masked]
Date: Wed, 23 Aug 2023 19:45:21 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

while browsing the sources of `make-mode', I noticed that the variable
initialization of `makefile-browser-client' is wrong. It is
initialized with its documentation string.  This is not a really a
problem, the makefile browser still works, but the documentation
string is lost as soon as the browser is opened once.

-- Christoph
From 768e48e58a661bd045a25dacbebccdb8cb26dd85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20G=C3=B6ttschkes?= <[email-masked]>
Date: Wed, 23 Aug 2023 19:34:14 +0200
Subject: [PATCH] Fix 'makefile-browser-client' variable initialization

* lisp/progmodes/make-mode.el (makefile-browser-client):
Initialize to nil
---
 lisp/progmodes/make-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el
index 017a551bc05..ff2aa137813 100644
--- a/lisp/progmodes/make-mode.el
+++ b/lisp/progmodes/make-mode.el
@@ -695,7 +695,7 @@ makefile-macro-table
   "Table of all macro names known for this buffer.")
 (put 'makefile-macro-table 'risky-local-variable t)
 
-(defvar makefile-browser-client
+(defvar makefile-browser-client nil
   "A buffer in Makefile mode that is currently using the browser.")
 
 (defvar makefile-browser-selection-vector nil)
-- 
2.42.0