GNU bug report logs - #65487
30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65487 in the body.
You can then email your comments to 65487 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <just.mychris <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization
Date: Wed, 23 Aug 2023 19:45:21 +0200

[Message part 1 (text/plain, inline)]

Hi,

while browsing the sources of `make-mode', I noticed that the variable
initialization of `makefile-browser-client' is wrong. It is
initialized with its documentation string.  This is not a really a
problem, the makefile browser still works, but the documentation
string is lost as soon as the browser is opened once.

-- Christoph

[0001-Fix-makefile-browser-client-variable-initialization.patch (text/x-patch, attachment)]

Message #10 received at 65487-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Christoph <just.mychris <at> googlemail.com>
Cc: 65487-done <at> debbugs.gnu.org
Subject: Re: bug#65487: 30.0.50;
 [PATCH] Fix 'makefile-browser-client' variable initialization
Date: Thu, 24 Aug 2023 10:25:50 +0300

> Date: Wed, 23 Aug 2023 19:45:21 +0200
> From:  Christoph via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> while browsing the sources of `make-mode', I noticed that the variable
> initialization of `makefile-browser-client' is wrong. It is
> initialized with its documentation string.  This is not a really a
> problem, the makefile browser still works, but the documentation
> string is lost as soon as the browser is opened once.

Thanks, installed on the emacs-29 branch, and closing the bug.

(It amazes me how such a glaring mistake could go undetected since
1992.)

Message #13 received at 65487 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: 65487 <at> debbugs.gnu.org, eliz <at> gnu.org, just.mychris <at> googlemail.com
Cc: 65487-done <at> debbugs.gnu.org
Subject: Re: bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client'
 variable initialization
Date: Thu, 24 Aug 2023 23:01:47 +0200

> (It amazes me how such a glaring mistake could go undetected since
> 1992.)

It might have something to do with this comment in that file:

;; * Consider removing browser mode.  It seems useless.

Also see Bug#58848: "Make makefile browser mode obsolete?".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.