GNU bug report logs - #65468
29.1; describe-theme fails to describe some themes not loaded

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thievol <at> posteo.net>

Date: Wed, 23 Aug 2023 08:55:01 UTC

Severity: normal

Tags: patch

Found in version 29.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: thievol <at> posteo.net, 65468 <at> debbugs.gnu.org, Protesilaos Stavrou <info <at> protesilaos.com>
Subject: bug#65468: 29.1; describe-theme fails to describe some themes not loaded
Date: Thu, 24 Aug 2023 07:16:10 -0300

[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 65468 <at> debbugs.gnu.org
>> Date: Wed, 23 Aug 2023 06:53:03 -0300
>> From: Mauro Aranda <maurooaranda <at> gmail.com>
>>
>> Thierry Volpiatto <thievol <at> posteo.net> writes:
>>
>>  > This because `describe-theme-1` is not looping in buffer to find
>>  > `deftheme` definition.
>>
>> It is a convention that the first form should be a call to deftheme.
>> But it seems built-in themes have deviated from that convention.  And
>> other themes might as well, I don't know.
>>
>>  >
>>  > Try (describe-theme 'leuven) to reproduce (if not already loaded of
>> course).
>>  >
>>
>> At least for the leuven themes, it should be easy to make them follow
>> the convention.
>
> I think we should indeed fix the themes that come with Emacs.

Here's a patch for the leuven themes.  And I'm CCing Prot so he can take
a look to adjust the modus-themes.
[0001-Adjust-built-in-themes-to-convention-Bug-65468.patch (text/x-patch, attachment)]
This bug report was last modified 1 year and 351 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.