GNU bug report logs - #65449
30.0.50; [PATCH] strokes: Support running other function when no stroke matches

Previous Next

Package: emacs;

Reported by: Liu Hui <liuhui1610 <at> gmail.com>

Date: Tue, 22 Aug 2023 06:26:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65449: closed (30.0.50; [PATCH] strokes: Support running
 other function when no stroke matches)
Date: Thu, 31 Aug 2023 09:33:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 31 Aug 2023 12:32:11 +0300
with message-id <83o7ineew4.fsf <at> gnu.org>
and subject line Re: bug#65449: 30.0.50; [PATCH] strokes: Support running other function when no stroke matches
has caused the debbugs.gnu.org bug report #65449,
regarding 30.0.50; [PATCH] strokes: Support running other function when no stroke matches
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65449: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65449
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Liu Hui <liuhui1610 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] strokes: Support running other function when no
 stroke matches
Date: Tue, 22 Aug 2023 14:25:24 +0800
[Message part 3 (text/plain, inline)]
Hi,

This patch allows users to call another function when no stroke
matches, instead of signaling an error. I bind down-mouse-3 to
strokes-do-stroke, and would like to pop up the context menu when no
stroke matches. In addition, two arguments stroke and match can be
passed to the function for other uses (e.g. making the error message
more informative).
[0001-strokes-Support-running-other-function-when-no-strok.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: liuhui1610 <at> gmail.com
Cc: 65449-done <at> debbugs.gnu.org
Subject: Re: bug#65449: 30.0.50;
 [PATCH] strokes: Support running other function when no stroke matches
Date: Thu, 31 Aug 2023 12:32:11 +0300
> Cc: 65449 <at> debbugs.gnu.org
> Date: Tue, 22 Aug 2023 19:05:47 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Liu Hui <liuhui1610 <at> gmail.com>
> > Date: Tue, 22 Aug 2023 21:50:58 +0800
> > Cc: 65449 <at> debbugs.gnu.org
> > 
> > I have updated the doc string in the attached patch. However, the
> > return value cannot be specified because the return value of
> > `strokes-execute-stroke' is not specified, i.e., `command-execute'
> > could return any value.
> 
> Thanks, looks reasonable.
> 
> Let's wait for a few days, to give others a chance to chime in and
> voice comments.  If nothing serious comes up, I will install this in a
> few days.

No further comments, so I've now installed this on the master branch,
and I'm closing the bug.


This bug report was last modified 1 year and 325 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.