GNU bug report logs - #65444
[PATCH] gnu-maintenance: Improve check for disabled host names.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 65444 <at> debbugs.gnu.org, maxim.cournoyer <at> gmail.com
Cc: Christopher Baines <guix <at> cbaines.net>, Josselin Poiret <dev <at> jpoiret.xyz>, Ludovic Courtès <ludo <at> gnu.org>, Mathieu Othacehe <othacehe <at> gnu.org>, Ricardo Wurmus <rekado <at> elephly.net>, Simon Tournier <zimon.toutoune <at> gmail.com>, Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: [bug#65444] [PATCH] gnu-maintenance: Improve check for disabled host names.
Date: Mon, 21 Aug 2023 16:56:21 -0400

Found while investigating <https://issues.guix.gnu.org/65304>.

* guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
---

 guix/gnu-maintenance.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm
index 32712f7218..5c16a7617d 100644
--- a/guix/gnu-maintenance.scm
+++ b/guix/gnu-maintenance.scm
@@ -846,7 +846,11 @@ (define html-updatable-package?
                           (let ((scheme (uri-scheme uri))
                                 (host   (uri-host uri)))
                             (and (memq scheme '(http https))
-                                 (not (member host hosting-sites)))))))))
+                                 ;; HOST may contain prefixes,
+                                 ;; e.g. "profanity-im.github.io", hence the
+                                 ;; suffix-based test below.
+                                 (not (any (cut string-suffix? <> host)
+                                           hosting-sites)))))))))
 
     (lambda (package)
       (or (assoc-ref (package-properties package) 'release-monitoring-url)

base-commit: 4c7627dfec88350f9a1705e9527c38dd41506f8b
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.