Subject: bug#65444: closed (Re: bug#65444: [PATCH] gnu-maintenance: Improve check for disabled host names.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 25 Aug 2023 14:09:02 +0000

Your bug report

#65444: [PATCH] gnu-maintenance: Improve check for disabled host names.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
65444: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65444
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#65444: [PATCH] gnu-maintenance: Improve check for disabled host names.
From: Maxim Cournoyer <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: Josselin Poiret <[email-masked]>, [email-masked], Simon Tournier <[email-masked]>, Mathieu Othacehe <[email-masked]>, Tobias Geerinckx-Rice <[email-masked]>, Ricardo Wurmus <[email-masked]>, Christopher Baines <[email-masked]>
Date: Fri, 25 Aug 2023 10:08:37 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Ludovic Courtès <[email-masked]> writes:

> Maxim Cournoyer <[email-masked]> skribis:
>
>> Found while investigating <https://issues.guix.gnu.org/65304>.
>>
>> * guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
>
> LGTM!

This change was installed with
c655231b72ac28b5a433069fcf86a835c9c83691.  Thanks for the review!

-- 
Thanks,
Maxim

Subject: [PATCH] gnu-maintenance: Improve check for disabled host names.
From: Maxim Cournoyer <[email-masked]>
To: [email-masked], [email-masked]
Date: Mon, 21 Aug 2023 16:56:21 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Found while investigating <https://issues.guix.gnu.org/65304>.

* guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
---

 guix/gnu-maintenance.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm
index 32712f7218..5c16a7617d 100644
--- a/guix/gnu-maintenance.scm
+++ b/guix/gnu-maintenance.scm
@@ -846,7 +846,11 @@ (define html-updatable-package?
                           (let ((scheme (uri-scheme uri))
                                 (host   (uri-host uri)))
                             (and (memq scheme '(http https))
-                                 (not (member host hosting-sites)))))))))
+                                 ;; HOST may contain prefixes,
+                                 ;; e.g. "profanity-im.github.io", hence the
+                                 ;; suffix-based test below.
+                                 (not (any (cut string-suffix? <> host)
+                                           hosting-sites)))))))))
 
     (lambda (package)
       (or (assoc-ref (package-properties package) 'release-monitoring-url)

base-commit: 4c7627dfec88350f9a1705e9527c38dd41506f8b
-- 
2.41.0