From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 65418@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169260822824536 (code B ref -1); Mon, 21 Aug 2023 08:58:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Aug 2023 08:57:08 +0000 Received: from localhost ([127.0.0.1]:55533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY0ih-0006Nf-KD for submit@debbugs.gnu.org; Mon, 21 Aug 2023 04:57:08 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY0UE-0005wL-P4 for submit@debbugs.gnu.org; Mon, 21 Aug 2023 04:42:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY0U6-0008Mt-S1 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 04:42:02 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qY0U4-00036J-HM for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 04:42:02 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-68a40d85593so423135b3a.2 for ; Mon, 21 Aug 2023 01:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692607318; x=1693212118; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=zHkxHgQx5H/vGOuKqu9m2UFSF3XXOxGbAgKNdyKc7gY=; b=YnTKe9vcWbyCkUDVfryVCr/gJp4RlV1xnNnCqx4PZPIkmG/bBB8DB2jL5AzFeGAdfr QGUQb/Hy72581I6DlCmo0uf2C5+HAf2Y1OivLLFop/eaGrtejBbgEUo+y/Tiq4HymzVq uKOurwD/O3DlpC66vdokipv91rb8Nomtbffr74OC2h16JdGg5S1t6eF2xmr23lLFqVXB BDXRRDv52hwIDmDXSc+6UHAog+XJ80VtKgonMQGAhf33m5mwc8SGxcV545k5zjZXm+Ii 3dAh8fQ12jPU8WUw5Kt2YaRFZkpT7UrqOBOZs9l6gM+qYedGVy/D4ZyLhZKop3Nbv2PT TvbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692607318; x=1693212118; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zHkxHgQx5H/vGOuKqu9m2UFSF3XXOxGbAgKNdyKc7gY=; b=Dk97FQTi/fPvMPCqWW5V38eI8yJQ2WtWzK5YgqCNG4RrKBAfEPpozUmi/xLfCjgkAH p3XDdQRgTSCC1Yatgai8fAlG2rnaw94jyRwGgat9CAnmiQ/5/9L4w4RBHHsf18hFZqh8 5Kv4xecpY4/D3IHj3NUNLN4Mx9bdN1GDUJB8+oSSfhdNOQDBbrayXq00v3jlwZJzTSXD FoQ6l6O4fWpwtdPX2ji6yYQOPIYAJowLk+8n4ePhjutVDUBQ3aqU7Xgqq4HShNQHoFEZ A6ybHWQQMpshTDNq6vCa9rvlg0cy33W9sUOi9lWaU9ySA2JBuG18i5nI2xX49Wan6Ec4 xHVw== X-Gm-Message-State: AOJu0Yyt329AnfoooJw1K4e+DFm/dT8lgOSlS1w8J1h378hUxx6dNUVy NDBnOSSGI2URcW4PM0COPz7J5x/qcTyCThx2WPzGySC5nhI= X-Google-Smtp-Source: AGHT+IENopFqH/pW6yM78RYXIJ2XEoNBrskZ+gHj/tHqrTQ5gOaauklRA6qTteOVdVBGRN3MH/5B1+5cwdFNmb/YIg8= X-Received: by 2002:a05:6a00:22d4:b0:687:60bf:aed9 with SMTP id f20-20020a056a0022d400b0068760bfaed9mr4860000pfj.24.1692607317841; Mon, 21 Aug 2023 01:41:57 -0700 (PDT) MIME-Version: 1.0 From: Filippo Argiolas Date: Mon, 21 Aug 2023 10:41:46 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=filippo.argiolas@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Mailman-Approved-At: Mon, 21 Aug 2023 04:57:05 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, I've recently been working in some big C project with ton of ifdefs and inactive code regions. One of the few annoyances (maybe the last) remaining with emacs+eglot is the inability to show these regions as grayed out in a LSP aware way. This was maybe possibile until now with clangd with semantic tokens but they've recently introduced a new protocol extension that should solve this problem in a much easier to implement way. It's been introduced in clangd 17 with the review [1]. It should be pretty straightforward to implement as it's just a server notification that sends inactive regions ranges once enabled. In [2] you can find the pull request that added support for this in vscode clangd extension. I did some experiment on my own but I'm still not able to see the notifications. Probably I'm missing something within eglot code base, my impression was that enabling the inactiveRegions capability would get me some Unknown notification message but I wasn't able to see them. Anyways it would be great if eglot could support this. Not sure UI-wise what would be the best approach, vscode patch reduces the opacity of the inactive regions but rendering them as comment would also be nice at first. 1. https://reviews.llvm.org/D143974 2. https://github.com/clangd/vscode-clangd/pull/193/commits/ef75f637e7f79f94064369368ca665861836e482 From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Filippo Argiolas Cc: 65418@debbugs.gnu.org Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169263706811544 (code B ref 65418); Mon, 21 Aug 2023 16:58:02 +0000 Received: (at 65418) by debbugs.gnu.org; 21 Aug 2023 16:57:48 +0000 Received: from localhost ([127.0.0.1]:57620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY8Dr-000308-MY for submit@debbugs.gnu.org; Mon, 21 Aug 2023 12:57:47 -0400 Received: from mout02.posteo.de ([185.67.36.66]:44529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY8Dp-0002zv-Gp for 65418@debbugs.gnu.org; Mon, 21 Aug 2023 12:57:46 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 90813240104 for <65418@debbugs.gnu.org>; Mon, 21 Aug 2023 18:57:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692637057; bh=BcrP0AhGkGlCIN6JC7b8bhi2Qf/uDEHvXagXvh3BG8Y=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=IeI1JTFQjmn9PfObU0kEUEWXN2pKKDZCwn67zF3Z3/pzqYmgv9RXx8BECvQ4rF6UI Dgq2C3MvLSGVflGNih2xICINsFmus8wTylqSVwKxuBdqrBR2TgiksrdqpEhJneqhLl gStxoxCsSSlRiqbDaqAF30nExfIT9Xvn8YV+DvrOvlVLHsdDfroSUy2bRWmZiNZn5g VahoPJQfhHSK5ZGHBkskwoVDmAyD3tQUVrsHyaqv8JfxnODIikJ9rOaD7Jh+FEheDb uQKDBZCx+e2fsVvpQjXFAJ50VJJBx/9xGAeZx9pM53aysx63tiUFcZMwF1U3cIvUM8 rI0yZImgCVYFw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RTzDd1WgCz6tn4; Mon, 21 Aug 2023 18:57:37 +0200 (CEST) From: Philip Kaludercic In-Reply-To: (Filippo Argiolas's message of "Mon, 21 Aug 2023 10:41:46 +0200") References: Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Mon, 21 Aug 2023 16:57:35 +0000 Message-ID: <87pm3ggwow.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Filippo Argiolas writes: > Anyways it would be great if eglot could support this. Not sure > UI-wise what would be the best approach, vscode patch reduces the > opacity of the inactive regions but rendering them as comment would > also be nice at first. I guess the `shadow' interface would be a viable option as well. From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 19:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 65418@debbugs.gnu.org Cc: Philip Kaludercic , Filippo Argiolas , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169264469312122 (code B ref 65418); Mon, 21 Aug 2023 19:05:02 +0000 Received: (at 65418) by debbugs.gnu.org; 21 Aug 2023 19:04:53 +0000 Received: from localhost ([127.0.0.1]:57836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYACr-00039R-Bp for submit@debbugs.gnu.org; Mon, 21 Aug 2023 15:04:53 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:58674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYACo-00039E-V3 for 65418@debbugs.gnu.org; Mon, 21 Aug 2023 15:04:51 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-99c3c8adb27so481768166b.1 for <65418@debbugs.gnu.org>; Mon, 21 Aug 2023 12:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692644683; x=1693249483; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=FhQwWz6yFsBRWk6iesrhnLPrwNTIJ0cwZSjnZLqIOcQ=; b=ch6ObzmsYGoxLC99WtC6+DQaemff3WoOwqjgadoIWf9OE2lA6ckWHYABI2G848sWFh EteX/fxIL5vbAUjbnuA3zR4uBUIoTyQLINJYa+pEAsp6CfHOFM3hR4A7tODusYsGVQeI lz8PYG28lo0HbawgEw1wVrveeqUh+6/jBuFLbJAwLeWnEf63gZ9FseVX+5m6epnxHkSM DYg0LvOljegFNX28FY8BOSAyL/e733OYyQLoQ+xrtbjHsgWs8VrzciupzVgG9zH8W4QQ nCXS++TuBbB4rI5r32Onvrn+rkpil+QCvFvRuFqunzXda+DyXojdnov6GuTqWiH0teIm OTkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692644683; x=1693249483; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FhQwWz6yFsBRWk6iesrhnLPrwNTIJ0cwZSjnZLqIOcQ=; b=U4oBhx48C6Opw+7qID+CVZhNUpFeQXFpkL3chHNkbz+lL1ojf5DplsDPDlqURMNRKm qDZ0PDgSsMJvguVBgu+3ImemQ0YwCHonBLI+Qv0/HNkXPNBdRqfLe1zyV5wyZnKQAoLd /KhAcQ3FGg8f5IvimhKaYPXtKT8HLpXZHrN0FfXzaO847ulfyVHe30zyVMUjT59O/LCo R0Cw7FINHlKGSoKy2nT/8D4Q+3OSWurYq0Bb8ahqmq1LS0RtKFODZqet0A2tm0a0Dpfg WKPQyls4bDQxY8VjmNvJqE7zMcnU6WJ5JiMRFelOIIIc9OXjWHbxEauTPcmkwcnh+z4w bhvw== X-Gm-Message-State: AOJu0YxhBrK61EIuJ4ZFzYdwdnlSgBYmWlDoO2Q+NuF3oVJl9iAsqyu8 zLIc/q/+e9VMVZ3kZRz5GPcoo/0en1g= X-Google-Smtp-Source: AGHT+IH5Tvry7HoiIMU13BFbjwqOGjmoe7MzM4RdC+B2wqB5L3UsBemokCzA4Tb/HuwItdwwkH6rXA== X-Received: by 2002:a17:906:5399:b0:9a1:6253:c56e with SMTP id g25-20020a170906539900b009a16253c56emr5726963ejo.35.1692644682508; Mon, 21 Aug 2023 12:04:42 -0700 (PDT) Received: from betli.gmail.com (catv-89-134-210-182.catv.fixed.vodafone.hu. [89.134.210.182]) by smtp.gmail.com with ESMTPSA id i22-20020a170906445600b009937dbabbdasm6896846ejp.217.2023.08.21.12.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 12:04:42 -0700 (PDT) From: Felician Nemeth References: Date: Mon, 21 Aug 2023 21:04:40 +0200 In-Reply-To: (Filippo Argiolas's message of "Mon, 21 Aug 2023 10:41:46 +0200") Message-ID: <87edjw6wtz.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEU2EgDVmFNHKAa4dz4q AwCDUSH2zWrE61tmAAACeklEQVQ4jU2UwY7jIAyGEZN5ABSFc9Ytcx6K6DmqmHsD8tyZKrz/I+xv yI6WKlHlj982tomiVckiWrUrgRU5jlqMpJKCkch5W419DQAiQGHDxdrWmm0/2kXCApiUmrZLq20s cjexq3VL25QuxjY7wOcJVEpb+jLeGLAK+OMyaa1hx9rFbkwHFWBVA2y8w1wHaLE7GuDdw5cEuOM5 SLIdrpwBkN0ezwI7nYoiilqthbcYc89KgC5+NnaOHGbZz0T6BCEgOLJ0vmYXuNdPAIXgDZJhF2Yu fjnPNwAsoUTUN/P8q3AAyz4zB/xmifEfiIbvS4jh7b7QqZiSm4MJC5kXNpCRaOsoyQXAMN2XCJfs j94NKfo7ACKUEgKE3y+Sg4jibUZ1A0jgYpxtvYMC3gHaHPq6x32ACeALIZoZxB+l9VrRNIA1ncRg wwC8pvQIvYO+a2yt3VXMVyli6L0VV6aOrJa4CpilVQA+eHt0xavk61akih5BUMay/0BAqu783C5h FifY/3QsAIoWYk6PgpwAzLI652+96e2IfN2cF+BD1uT23F21Ghh5OUl4RlO15oh5A2iv+Zk2wsjZ 2DtB5Sm3A4P0+kyb2vs4iEW7G9ohoN3Stl2kVat6MCkXldo6OKaE8P6GhmrKKxWZXQH1iklhhn+d iVeNf6mDdkV0ltFwApRbp+kXSGBFHGV2aPqnIIyQyzhD5n47khqKI08bIapcas4O+hPkct20NAEv ALRuZFUp3PrnQSAm+4lTdHCsYYZ/nGqQrM5z3NS3zefFxkfFPRFbsjpIfbTlvF3ibpVZQ9nzqv60 F/KXSRLJ1AGappJulZll70N/qz6EfwEOCdYOuTHAzAAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filippo Argiolas writes: > [...] This was maybe possibile until now with clangd with semantic > tokens but they've recently introduced a new protocol extension that > should solve this problem in a much easier to implement way. In the past, Jo=C3=A3o wasn't keen on supporting non-standard features in Eglot. I Cc'd him anyway as he is the maintainer of Eglot. > Not sure UI-wise what would be the best approach, vscode patch reduces > the opacity of the inactive regions but rendering them as comment > would also be nice at first. Maybe hide-ifdef-mode is good for providing inspiration. From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Aug 2023 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Felician Nemeth Cc: 65418@debbugs.gnu.org, Philip Kaludercic , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.16926900323093 (code B ref 65418); Tue, 22 Aug 2023 07:41:02 +0000 Received: (at 65418) by debbugs.gnu.org; 22 Aug 2023 07:40:32 +0000 Received: from localhost ([127.0.0.1]:58491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYM07-0000no-GJ for submit@debbugs.gnu.org; Tue, 22 Aug 2023 03:40:32 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:59455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYLWP-0005t1-3n for 65418@debbugs.gnu.org; Tue, 22 Aug 2023 03:09:49 -0400 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-56a8794b5adso1554171a12.2 for <65418@debbugs.gnu.org>; Tue, 22 Aug 2023 00:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692688180; x=1693292980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/0i7qF6qiyGosQY7r/AoBlCe4mjS/w5MTSq1F83VXlg=; b=NJGpM+FvJ0T0trp7JDQAxz2Hz8wXWURSDGONH1Mh8y/v7/9ym9JrT7qRASTEMgvsWO MVfKFNaHJh31Ej6ZcF2OtSF5GqCJHGmW4A6iI22fJ/1GqtG+DX/isdr1XnRYVu70CFiV TemkjBDtK+EDGtBqfxAOn/FJ66fEHh5/TLGyknopFRbrZFY29L6EqPZpa4+OLK3fwMfY S4wlWg4Ka5RkxFIJQBPakRHF4JCG4fUfUem4vQKvUm2+2/46osGA+Mi4RvYLq+b7+r7s lwPvGDFAbjcaE/cTib4CQAjjFrbG2UpKsEOCJSD6atdpoeSnab3khQCLPV1TnKmahXHb +F3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692688180; x=1693292980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/0i7qF6qiyGosQY7r/AoBlCe4mjS/w5MTSq1F83VXlg=; b=leeiuq2msCVtjv9ZWuECv3Lz4TQ4Xts4jbpwv6vbVcAER65KKxgoxnhy2ib/wvNN03 uMuVEkU4pKbPw58bv1dUc5DaJGi1sia+22G3iZwH4Ctty2Ju6fnxralcav0dFh3gYQ0j 2Ice4hL7sLz/Uoqb1zDrYCO6Cj0e8D2VbYwVp0+L9EzxrocRGk1xSzmi2mrGvc6JGfq3 JVOqdG/h7jmNTttQYLeCIFiDWFbjedL1X8dR2So25AalTRpaqs1jwghcfm5DOHRs3OcZ 1/ooh0ntd9WwFNr1wsaIogpvHFvGWYdZKUYtZTFuSz3RyJXjL6vScIzkA5J6REqS0yB/ dYIg== X-Gm-Message-State: AOJu0YzLvOi65Luyd4sxCZ4NWz27gAT4KrLNBBQQxE0L0/RQYfSkHLOS /vXIJwLQUnu4jnFZop4kg/wt3d84Tga8kxyPFa3KHyHs4z8= X-Google-Smtp-Source: AGHT+IHOlnPR0b5flxpIIYsQ5aliw3GyGVdp9PAJcu404NuWQ3wW7cCX3UNU9hdsJ99WEyX9KsFwirGYNThSFoADVS4= X-Received: by 2002:a17:90b:4f4d:b0:26b:e2b:6c8d with SMTP id pj13-20020a17090b4f4d00b0026b0e2b6c8dmr8043718pjb.41.1692688180603; Tue, 22 Aug 2023 00:09:40 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> In-Reply-To: <87edjw6wtz.fsf@betli.tmit.bme.hu> From: Filippo Argiolas Date: Tue, 22 Aug 2023 09:09:28 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Tue, 22 Aug 2023 03:40:30 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Aug 21, 2023 at 9:04=E2=80=AFPM Felician Nemeth wrote: > > Filippo Argiolas writes: > > > [...] This was maybe possibile until now with clangd with semantic > > tokens but they've recently introduced a new protocol extension that > > should solve this problem in a much easier to implement way. > > In the past, Jo=C3=A3o wasn't keen on supporting non-standard features in > Eglot. I Cc'd him anyway as he is the maintainer of Eglot. Let's wait for feedback from Jo=C3=A3o then. I'd say this could warrant an exception on the basis that disabling code with the preprocessor is something specific enough to C/C++. It makes sense to have it as a server extension. Also this IMHO would solve quite an important problem with C development, not sure if it's worth waiting while we could solve it now with the extension and move to the standard protocol if and once the LSP spec will support this. > > Not sure UI-wise what would be the best approach, vscode patch reduces > > the opacity of the inactive regions but rendering them as comment > > would also be nice at first. > > Maybe hide-ifdef-mode is good for providing inspiration. No idea how easy that would be and if that makes sense but we could maybe follow the eglot philosophy of working with existing components and just forward inactive regions to hide-ifdef-mode? Filippo From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Aug 2023 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Filippo Argiolas Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169269460921427 (code B ref 65418); Tue, 22 Aug 2023 08:57:02 +0000 Received: (at 65418) by debbugs.gnu.org; 22 Aug 2023 08:56:49 +0000 Received: from localhost ([127.0.0.1]:58550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYNBx-0005ZW-48 for submit@debbugs.gnu.org; Tue, 22 Aug 2023 04:56:49 -0400 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:51702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYNBu-0005ZH-Ho for 65418@debbugs.gnu.org; Tue, 22 Aug 2023 04:56:47 -0400 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2bcb0b973a5so39584131fa.3 for <65418@debbugs.gnu.org>; Tue, 22 Aug 2023 01:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692694598; x=1693299398; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1/LQHXRNIvxjZ4M3kMzXNZH07p8rRsA/RDfwlO3ixSI=; b=UjOenffkFucnkWMKCo1Zjllo9WgqcKgthvaOVfnZXpyHZILdgK2K5IQGKvFAKk4THH Tk5R0janfCPM0ESkwUSHrBkr1u4O1hq4kC8zaVgw16zTyq5wWv7F8UIBCyye9I/QvFgS v/GlOy85OeirW3+Gl0mwboPbp5yyyQ5LIZsQwofR5DXRN1Bb2C2E6ws8QYdAWaclKiS7 sAmEf5bWg12hDO2xWT+x38ReC5sLLvIoOVEhkM43v4fZvuRmzErFM/8cd9lbK5avAuhZ ClwOglwdv27ZbgY4BQ3EIoaYVeNSoiaFhBCWv6p9OFrumeww9tH1r5Myq8oza5e3cMH6 JJjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692694598; x=1693299398; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1/LQHXRNIvxjZ4M3kMzXNZH07p8rRsA/RDfwlO3ixSI=; b=E97z6xMEDvuwZVmXeDtphqVWBllmw5tDMhI/hxe+m+X/cuTFn3YlZWz3m3K12wl7xs 7oAJ7moR7RyYWc7FX5AmfVIlkXiZ6+ipCQlLm2N3n+jJiXIMCxT0KlT/apBXs6a79icU wZ3pxOnfNOTAH8GORBQ7mXJBfkYhipG3aeIp7G3TBezIHNOMopLJHZQYI5LsBCCRL+RM cF0w7q0UGlSNS7T8FKznUBcIacB680iXbDGbeBqcHAvVzyz9su1idUKQEPb/fO1uODDC 6g/TsLGHAs1z6bXk5tgw8oZ0hVly8yy+ZEsMoPzo7VEecaV+RKiGhLcQr2ZPYwtnjWWu ZBBA== X-Gm-Message-State: AOJu0YwOO1T13vLyBsf4FmL/NXW2Vv+nbdYGLiIzWJp7Fw9MI9q5MQBL zNPFV1jvb0d9wgCytiD8J1Si0Uv3fMSrgODNcGQ= X-Google-Smtp-Source: AGHT+IE7K+Fe7DGkd5PodN6dKSahFcEaM+lrlXn9C4EKqdTmQHhHxAdLyC7+YwZSL8dzS3vAUYteQJbsVgtzQfHkuo4= X-Received: by 2002:a2e:8416:0:b0:2b6:ddab:506a with SMTP id z22-20020a2e8416000000b002b6ddab506amr6996483ljg.34.1692694597400; Tue, 22 Aug 2023 01:56:37 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Tue, 22 Aug 2023 09:56:24 +0100 Message-ID: Content-Type: multipart/alternative; boundary="00000000000030fd3c06037f2cd1" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000030fd3c06037f2cd1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 22, 2023, 08:09 Filippo Argiolas wrote: > In the past, Jo=C3=A3o wasn't keen on supporting non-standard features in > > Eglot. I Cc'd him anyway as he is the maintainer of Eglot. > Right, but I'm not for making it hard either. Although this is non-standard, it's similar to a bunch of "code-painting" situations, some of which are standard, and some of which, like inlay hints are already in Eglot. So it shouldn't be a problem in itself to supply support for this in c-ts-mode or some eglot-c-extra.el or, if done well enough, even an example snippet of how to support a typical extension in your .emacs. I'm more worried that this isn't even out yet. Afaik Filippo you compiled a Clangd 17 with a patch, right? I have done that in the past, but it's not very practical every time, so either we wait for this to stabilize or you have to tell me where to grab the patched Clangd and llvm toolchain somewhere. Also I'm not 100% happy with my inlay hints implementation based on jit font lock, which misses the mark more often than I wished. I had an earlier, less efficient (but afair more correct) implementation before Eli suggested this one. The fault is not 100% on Emacs side though, and the LSP spec itself leaves much to be desired regarding invalidating regions. This is an opportunity to revisit these matters. Also this IMHO would solve quite an important problem with C > development, not sure if it's worth waiting while we could solve it > now with the extension and move to the standard protocol if and once > the LSP spec will support this. > I'm also personally interested in this feature. But how likely is it that this makes it into the LSP standard, in your opinion? FWIW, other languages have similar features. Common Lisp has read-time conditionals for example, which are similar if not identical in function (and obviously not as rotten as C macros). By the way, if you didn't know this silly trick, if you're in a #ifdef web, a half-decent way to know whether a given point is active is to try and find a definition inside it or type some syntactically correct code. If Eglot jumps to target or highlights variable names, the region is active, else it probably isn't. No idea how easy that would be and if that makes sense but we could > maybe follow the eglot philosophy of working with existing components > and just forward inactive regions to hide-ifdef-mode? > Yes, that is the philosophy, but these "standard components" differ in quality immensely. So it's on a case-by-case. Jo=C3=A3o --00000000000030fd3c06037f2cd1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Aug 22, 2023, 08:09 Filippo Argiolas <filippo.argiolas@gmail.com> w= rote:

> In the past, Jo=C3=A3o wasn't keen on supporting non-standard feat= ures in
> Eglot.=C2=A0 I Cc'd him anyway as he is the maintainer of Eglot.

Ri= ght, but I'm not for making it hard either. Although this is non-standa= rd, it's similar to a bunch of "code-painting" situations, so= me of which are standard, and some of which, like inlay hints are already i= n Eglot.

So it shouldn&#= 39;t be a problem in itself to supply support for this in c-ts-mode or some= eglot-c-extra.el or, if done well enough, even an example snippet of how t= o support a typical extension in your .emacs.

I'm more worried that this isn't even out yet= . Afaik Filippo you compiled a Clangd 17 with a patch, right? I have done t= hat in the past, but it's not very practical every time, so either we w= ait for this to stabilize or you have to tell me where to grab the patched = Clangd and llvm toolchain somewhere.

Also I'm not 100% happy with my inlay hints implementation= based on jit font lock, which misses the mark more often than I wished. I = had an earlier, less efficient (but afair more correct) implementation befo= re Eli suggested this one. The fault is not 100% on Emacs side though, and = the LSP spec itself leaves much to be desired regarding invalidating region= s. This is an opportunity to revisit these matters.
=
Also this IMHO would solve quite an important problem with C
development, not sure if it's worth waiting while we could solve it
now with the extension and move to the standard protocol if and once
the LSP spec will support this.

I'm also personally interested in this f= eature. But how likely is it that this makes it into the LSP standard, in y= our opinion?

FWIW, other= languages have similar features. Common Lisp has read-time conditionals fo= r example, which are similar if not identical in function (and obviously no= t as rotten as C macros).

By the way, if you didn't know this silly trick, if you're in a #= ifdef web, a half-decent way to know whether a given point is active is to = try and find a definition inside it or type some syntactically correct code= . If Eglot jumps to target or highlights variable names, the region is acti= ve, else it probably isn't.

No idea how easy that would be and if that makes sense but we could
maybe follow the eglot philosophy of working with existing components
and just forward inactive regions to hide-ifdef-mode?

Yes, that is the philo= sophy, but these "standard components" differ in quality immensel= y. So it's on a case-by-case.

Jo=C3=A3o
--00000000000030fd3c06037f2cd1-- From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Aug 2023 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169271788210053 (code B ref 65418); Tue, 22 Aug 2023 15:25:01 +0000 Received: (at 65418) by debbugs.gnu.org; 22 Aug 2023 15:24:42 +0000 Received: from localhost ([127.0.0.1]:60194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYTFJ-0002c5-LF for submit@debbugs.gnu.org; Tue, 22 Aug 2023 11:24:42 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:56323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYPAC-0000jb-Lc for 65418@debbugs.gnu.org; Tue, 22 Aug 2023 07:03:09 -0400 Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-26814e27a9eso2352788a91.0 for <65418@debbugs.gnu.org>; Tue, 22 Aug 2023 04:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692702179; x=1693306979; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cls0gmyBtMI1ookt/VnO0yP+GARVrvX8SfETDgmq/sU=; b=lBxxcdN6hw4zNXFUW5QVy171pdrOCCeR8kuHAH2kbNicHcvjaax6RARxjHWSU6UMp4 8VX7snTGW+twie/EuEbVneQE/4JgXEP0cgTOWd84eo1omp6hzu898pskzzS+F568zEPH atX6L1bRNau7+8eta0noPznkEkj/ka+Kwsq62fPWDIP+7SEFwvMIzG/eYKT2y6vroa9/ G4bxTK++iy+ZcesuauUK48f0N1AjnWo1RIabNZ8OxkQQOWlfmtbVML/7XIs7MFbwJzRp DY3tz0ccgNsm56E/XNkEg/hy/J2T+ILbI9nIJ5v/HkFl5w9qBKjzlG11F0wXcn6VFutU 3zgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692702179; x=1693306979; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cls0gmyBtMI1ookt/VnO0yP+GARVrvX8SfETDgmq/sU=; b=G2h//jRtufDsWKTM2K9Q5cPb0OFP/86SkiBQKbya1RP2GhKZcARfr//a1fQd7dbmzk BlYlPDfQQ+ixh5+IAAE3uAEPYjBya9HgQmQ9S4YWBb7Qui+NB+DfshLJQULlaAOX58CP UkC7eAMVHJOxUkYLBjNPdobplU55LHx+OOfecIvwhwA1ExJM9r+g2DFcBNqmzSi7PXFw YMxPUMWWvjsFJoQYG8ihU/a5EPkFq9mPED+hwQOqPeFLadlnF7FZoSc76flwBUS7UgIb zUdZRRjBga6LhpC7LjGr6EsZSO2AeFpnjKVTx1rs+O5g9vbAh0KtMVUgMDniQmsH7vmQ 1oog== X-Gm-Message-State: AOJu0YzQwH+CJm/QxsESRalNaAQxeCGyNnxMaWhxmFKkoPqqr6zM8jiT r8RFqTcpZ+WXTlBSrBnJMW54uH5aILDBaFTPgRU= X-Google-Smtp-Source: AGHT+IHwrMcrGo+hHi9+iN4TuLk1aSXryqEHwstrICUPU5Vp/+/foUAFLS4heHdgT34zQcaHCwrC37ZkibXqO8GscmQ= X-Received: by 2002:a17:90a:854c:b0:26d:1201:a8c4 with SMTP id a12-20020a17090a854c00b0026d1201a8c4mr6650799pjw.13.1692702179445; Tue, 22 Aug 2023 04:02:59 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> In-Reply-To: From: Filippo Argiolas Date: Tue, 22 Aug 2023 13:02:47 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Tue, 22 Aug 2023 11:24:40 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Aug 22, 2023 at 10:56=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > I'm more worried that this isn't even out yet. Afaik Filippo you compiled= a Clangd 17 with a patch, right? I have done that in the past, but it's no= t very practical every time, so either we wait for this to stabilize or you= have to tell me where to grab the patched Clangd and llvm toolchain somewh= ere. It's much easier than that! They release unstable git snapshots in github. You can find them at https://github.com/clangd/clangd/releases Clangd is released as a static binary you can just copy in your path (e.g. in ~/.local/bin). From what I can tell you don't need to upgrade the whole toolchain, the binary runs fine on its own. Latest one for linux is at https://github.com/clangd/clangd/releases/download/snapshot_202= 30820/clangd-linux-snapshot_20230820.zip It would be great if you could test it and see if you can get server notifications for inactiveRegions. I think the interface should be already stable, reading the review the only thing that is probably going to change at some point is dropping the support to generate semantic tokens for inactive regions as comments, which they are keeping for backwards compatibility. >> Also this IMHO would solve quite an important problem with C >> development, not sure if it's worth waiting while we could solve it >> now with the extension and move to the standard protocol if and once >> the LSP spec will support this. > > I'm also personally interested in this feature. But how likely is it that= this makes it into the LSP standard, in your opinion? Honestly I don't know :-) Only information I could find is this vscode issue https://github.com/microsoft/vscode/issues/123352 where they seemed to agree it's not something that belongs in semantic tokens but then the discussion stalled. > FWIW, other languages have similar features. Common Lisp has read-time co= nditionals for example, which are similar if not identical in function (and= obviously not as rotten as C macros). > > By the way, if you didn't know this silly trick, if you're in a #ifdef we= b, a half-decent way to know whether a given point is active is to try and = find a definition inside it or type some syntactically correct code. If Egl= ot jumps to target or highlights variable names, the region is active, else= it probably isn't. Thanks! that's actually a great way to see if the highlighted code is active! Still greying it out or dimming the colors would be great to see at a glance if a region is dead, especially for big regions. It's also one of those few features that Emacs still misses when compared to vscode. Filippo From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Aug 2023 12:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Filippo Argiolas Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.16929657806067 (code B ref 65418); Fri, 25 Aug 2023 12:17:01 +0000 Received: (at 65418) by debbugs.gnu.org; 25 Aug 2023 12:16:20 +0000 Received: from localhost ([127.0.0.1]:39496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZVjf-0001Zn-Vo for submit@debbugs.gnu.org; Fri, 25 Aug 2023 08:16:20 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:62678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZVjb-0001ZX-UF for 65418@debbugs.gnu.org; Fri, 25 Aug 2023 08:16:18 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3ff5ddb4329so12152515e9.0 for <65418@debbugs.gnu.org>; Fri, 25 Aug 2023 05:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692965765; x=1693570565; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y0Z9tCtmp6lZ6/yCEjOb3/W5h+3QQIp9AQ8cKvD8els=; b=BVUUdbW8ewsYo5XNo7jHt437CXP2WOTREG4SZnSUPMjr2GvHYpxd+IKq6huxSzYEpf /IWeJEaocLb3mfldRYOzb4TSoZI8CumQmrzWsbefPzWUsEqmI7625TZ/IUsMuPegZ/93 Bdg0nfg2Ha4/Y1lVpAHib06lq0cLhAt5KRi0kGJ0oyeZQLt3AsjjYdd98AIeh61lTCuk ep+4uoRC4H61RKbLhrogL1PWz7up2S9zuIgI1XHCUsoTf8LoAP3qGeqdtGMSzF4TQ1Mk cea5lpXzNTJN4n057EP28G9TGUPVP8NqhqWHC+HkA+jJ8lvWO23nfdJV45OInN2i+XmL 5r4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692965765; x=1693570565; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Y0Z9tCtmp6lZ6/yCEjOb3/W5h+3QQIp9AQ8cKvD8els=; b=dkLoX6JQmMr+SPuRrGVwy/BQ3VW7hBv7fe+/LqLqELSbyQ8AoTfssUaptso1wHTvrO XAaUZqfVKwixAVHVuLudgFYACjeU2Oz6GCkIcG03TNHzEniuwwSB7E9dRJMiggbU56RG QJ//srxQjnEcsqAd8B+FSQXlT3/vRgr2+91EFI/ZmPvsWXaOenXVjfveZyf1x/tsqH1H NWZHt8wHgLMMyPODm96QY6Fa51s8qIlcFLPiNhmkj8hSsWQH6VgIz9FKqMskOoXa8uUu u0w9L2KZTg1DPRIieMBONAa/LP/ZcOO8GGUUj/zuG+dx1shth6qr4xBNsX0BZEy9F/7k Pj5g== X-Gm-Message-State: AOJu0YznjD8GtgmDLFd3JtS7lTLRp/aGnx85iVQSqRcJG+Cv0YW63YYS otPAxeS6np6pQj7yfkpRS0s= X-Google-Smtp-Source: AGHT+IHLJ/5hoMzOM5/kVUwaQqn23fcgrX6nusqU9LTSJmxDGdsk/LOBHixQHYVTwr038PYs+9T5Tg== X-Received: by 2002:a5d:58cf:0:b0:315:acbc:cab6 with SMTP id o15-20020a5d58cf000000b00315acbccab6mr15904182wrf.16.1692965764942; Fri, 25 Aug 2023 05:16:04 -0700 (PDT) Received: from krug ([87.196.73.154]) by smtp.gmail.com with ESMTPSA id n10-20020a5d51ca000000b0031c5dda3aedsm2045260wrv.95.2023.08.25.05.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 05:16:04 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= In-Reply-To: (Filippo Argiolas's message of "Tue, 22 Aug 2023 13:02:47 +0200") References: <87edjw6wtz.fsf@betli.tmit.bme.hu> Date: Fri, 25 Aug 2023 13:18:47 +0100 Message-ID: <87zg2fnwm0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filippo Argiolas writes: > On Tue, Aug 22, 2023 at 10:56=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: >> I'm more worried that this isn't even out yet. Afaik Filippo you >> compiled a Clangd 17 with a patch, right? I have done that in the >> past, but it's not very practical every time, so either we wait for >> this to stabilize or you have to tell me where to grab the patched >> Clangd and llvm toolchain somewhere. > > It's much easier than that! They release unstable git snapshots in > github. You can find them at https://github.com/clangd/clangd/releases > Clangd is released as a static binary you can just copy in your path > (e.g. in ~/.local/bin). From what I can tell you don't need to upgrade > the whole toolchain, the binary runs fine on its own. Latest one for > linux is at > https://github.com/clangd/clangd/releases/download/snapshot_20230820/clan= gd-linux-snapshot_20230820.zip > > It would be great if you could test it and see if you can get server > notifications for inactiveRegions. OK, after fetching that git snapshot today, I've done this: ;;; eglot-clangd-inactive-region.el -*- lexical-binding: t; -*- =20=20=20=20 (require 'eglot) (require 'cl-lib) =20=20=20=20 (cl-defmethod eglot-client-capabilities :around (server) (let ((base (cl-call-next-method))) (when (cl-find "clangd" (process-command (jsonrpc--process server)) :test #'string-match) (setf (cl-getf (cl-getf base :textDocument) :inactiveRegionsCapabilities) '(:inactiveRegions t))) base)) =20=20=20=20 (defvar-local eglot-clangd-inactive-region-overlays '()) =20=20=20=20 (cl-defmethod eglot-handle-notification (_server (_method (eql textDocument/inactiveRegions)) &key regions textDocument &allow-other-keys) (if-let* ((path (expand-file-name (eglot--uri-to-path (cl-getf textDocument :uri)))) (buffer (find-buffer-visiting path))) (with-current-buffer buffer (mapc #'delete-overlay eglot-clangd-inactive-region-overlays) (cl-loop for r across regions for (beg . end) =3D (eglot--range-region r) for ov =3D (make-overlay beg end) do (overlay-put ov 'face 'shadow) (push ov eglot-clangd-inactive-region-overlays))))) Be sure to evaluate with lexical-binding (easiest if you save it to a file first). It's bare-bone but it works, because the method for communicating "inactive regions" is very basic (and similar to unsolicited diagnostics). Only minimally tested, so YMMV. This serves as a good example of how to support unofficial LSP extensions using Eglot as an API. Could well be in the manual. The method for providing a client-side capability based on a server is crude. Servers do identify themselves properly via LSP, but only after being initialized, so it's too late and I had to use an heuritic based on the command. We could also use a proper subclass for clangd servers, but that's too verbose and overkill IMHO. The usage of some '--' symbols like 'eglot--uri-to-path' and 'eglot--range-region' points out that these symbols should probably be promoted to be part of the Eglot API. Patches welcome for that. Jo=C3=A3o From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Aug 2023 14:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Filippo Argiolas Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.16931447535716 (code B ref 65418); Sun, 27 Aug 2023 14:00:03 +0000 Received: (at 65418) by debbugs.gnu.org; 27 Aug 2023 13:59:13 +0000 Received: from localhost ([127.0.0.1]:45914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaGIL-0001U7-7E for submit@debbugs.gnu.org; Sun, 27 Aug 2023 09:59:13 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:61865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaGIF-0001Th-NF for 65418@debbugs.gnu.org; Sun, 27 Aug 2023 09:59:12 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-31c8a710545so769089f8f.3 for <65418@debbugs.gnu.org>; Sun, 27 Aug 2023 06:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693144736; x=1693749536; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SLdIMFvANYCR1H+2E6GRPNl5jbPUB5twcl0/By8qYEE=; b=PZqYE9bPhD/MXje36uq0gNE/Ot6g0PH4diT4bzRGfQwbIQTBG+ehadCZNQ2u1vaCgs ivMgGGm0GGRwZ6n3EHRZ4bkkHcL0vixIDCxi/9Eekn/4G29Um/dkiV1/0P5uUqH0be+E tMLZ49trj2haNyqYTD5n5fuxlgjOCEdkd67QnMoUCgP3koPXYHvAQViQTlFEYYDTgqKR 77nxVriNIUMRojFtIGmNfCWraifBGJb6FXlh+DtILjap+hqVEAny2ltyraCoYngihVu+ Sk8rm1exr+HfMI8EKDFsvFIWg00Thp/09oizAQm8e94ZsXSRJKng7PAoHqx+nbWcSchW xaCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693144736; x=1693749536; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SLdIMFvANYCR1H+2E6GRPNl5jbPUB5twcl0/By8qYEE=; b=YUbPeDcmkVxqm9h28bDUYC6C1PJbFVyOdjYGAAXUgbCyCiZQNUtPmmjAMyImDV/y1h fqLdQJvE16bUu4XS3iKKK5Xmhp4YhYzJU+A9QCnEgEBDpuhydsrhSs4pTyOT5utPKtLX REAumbslrUDbtGH0ldB6rFDo3igBh1ouHMdzI320xQXF4An8UwDJwnPQQ9fkJ5GHFyh6 0HQxyjBg6oU1NXKCS927zFOCIWuP2WNpH7xK86V5igu47Ht58oS2xMFjo+datf90UUsH P+So/ehZaQfRK38cbgyzP8/zKEfWzJxMgd22FFWlnXudRfBO27O43mJS8vBv/Isw16rq vbiA== X-Gm-Message-State: AOJu0YxTSiXHnGGGIskRnbXd5lJJt7SUgja4VBib/7kanD2WRN5Ku4my QcjHxBsb/Qrkj3FQDpFFoSI= X-Google-Smtp-Source: AGHT+IHZfoJrSRVRWrY6J/b0LNuHLvd5Fsep9GFPstDfQ4FjKJEj9Ah6lXfhaij5YWEtl2N/7nYQrw== X-Received: by 2002:a5d:4a12:0:b0:318:7bc:122e with SMTP id m18-20020a5d4a12000000b0031807bc122emr17957590wrq.23.1693144735796; Sun, 27 Aug 2023 06:58:55 -0700 (PDT) Received: from krug ([87.196.73.195]) by smtp.gmail.com with ESMTPSA id v7-20020adfe4c7000000b003176aa612b1sm7749085wrm.38.2023.08.27.06.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 06:58:55 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= In-Reply-To: (Filippo Argiolas's message of "Sun, 27 Aug 2023 12:52:58 +0200") References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> Date: Sun, 27 Aug 2023 15:01:37 +0100 Message-ID: <873504d1oe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filippo Argiolas writes: > On Fri, Aug 25, 2023 at 2:16=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: >> >> Filippo Argiolas writes: >> >> OK, after fetching that git snapshot today, I've done this: >> >> It's bare-bone but it works, because the method for communicating >> "inactive regions" is very basic (and similar to unsolicited >> diagnostics). >> >> Only minimally tested, so YMMV. >> >> This serves as a good example of how to support unofficial LSP >> extensions using Eglot as an API. Could well be in the manual. >> >> The method for providing a client-side capability based on a server is >> crude. Servers do identify themselves properly via LSP, but only after >> being initialized, so it's too late and I had to use an heuritic based >> on the command. We could also use a proper subclass for clangd servers, >> but that's too verbose and overkill IMHO. > > That's great! Definitely owe you a beer or a bottle of your favorite > beverage! Glad to help. You're lucky I'm not some kind of wine connoisseur ;-) > About the heuristic would it be that bad to just include > inactiveRegions in the general client capabilities? Guess it would be > just ignored by other servers not supporting it, wouldn't it? Yes, but you would still need the extra add-on code. It just doesn't belong in Eglot. It could belong in cc-mode.el (as could eglot-server-programs's clangd entry, btw) but I heavily doubt the author of that package would accept it. The brand new c++-ts-mode and c-ts-mode is a different story though. Or it could just be a separate file to require. Or a separate GNU ELPA package. > Kind of surprised clangd doesn't use some kind of namespacing > convention for their protocol extensions. Yes. What's worse, it supports multiple different versions outside and inside of the standard of the same feature. I've just seen this with the textDocument/typeHierarchy method, which is now officially called textDocument/prepareTypeHierarchy. So I don't want to add two methods to support basically the same thing to Eglot. > Anyway, it would be great if this could be a part of eglot but I can > understand being careful given it's not in the standard protocol and > not even in a released clangd yet. > It would be great though if this example was included in the docs. It > says a lot about how easy to extend and well designed eglot is. Make a patch for that (and remember to also include the exportation of the '--' symbols). > One thing about UI, all the themes I tried seem to render shadow as > grey-ish but it was my impression reading the docs that it would be a > dim version of the current face, so it would still have syntax > highlighting. Is it just a theme limitation (probably because shadow > wasn't used for something like this before) or it's not technically > possible? I'm fairly sure it's technically possible, even if perhaps not easy. You can investigate or ask this on emacs-devel. Jo=C3=A3o From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Aug 2023 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169314808621477 (code B ref 65418); Sun, 27 Aug 2023 14:55:02 +0000 Received: (at 65418) by debbugs.gnu.org; 27 Aug 2023 14:54:46 +0000 Received: from localhost ([127.0.0.1]:45953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaHA5-0005aL-RG for submit@debbugs.gnu.org; Sun, 27 Aug 2023 10:54:46 -0400 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]:60793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaDOT-0007hk-KF for 65418@debbugs.gnu.org; Sun, 27 Aug 2023 06:53:22 -0400 Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-5734b893a11so1273003eaf.1 for <65418@debbugs.gnu.org>; Sun, 27 Aug 2023 03:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693133590; x=1693738390; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=b+o1Iz8JKZbTAb3aRi6yBccN6sWc9CsEp93LZvt7uzA=; b=WrdorQUKGvP82kyk5AXrmOBCOJbPG3sMmi7lwZfxSj4BVkx0t6sM3Lgyt8hMtuwq9t ddmGLddwtZod6eZhT+rBw8fWNtsdqvYbQBbyKLg2AT/I2xX60rHlJEMs1HVxDeghCFsB 3ucdORDq4MWkAZhXL7Zsd+AkyxLg+rSy89a1e4qqwKbUYl37vhqPJ+qlo0HdqLPTSvQ1 2Lu6WIaYGm4PDWnFrX9VlufBZNyrDzkdthIUYulMXOhz53I+O0EJ/eBmGucduBj+J62O 7blfpZaIP9ymenfLNc7TG1reuGYY/hRQHbRZ39y2GA5UPCXhVmHrZo31iYLZ7LvQf+oo s5ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693133590; x=1693738390; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b+o1Iz8JKZbTAb3aRi6yBccN6sWc9CsEp93LZvt7uzA=; b=JPlVR4mUV8S7EYbWGXCDWfaqA4iB9arSf8l4rzgPu1QQ3m9HaEdYkEGAgyBWAeX9mi +zIaAXYBNLDVkGYTDmK/u8Y08eq6pGI2AidXkIDLcM5xMFwkk8li1QXOnLq0kQ39QSkG iKE758oMRFhOFySpe0icH3ogFcZ2RoTWPuup8FDvfbF+TiRpvkEqRQBpHnkaqK5SvGBp ZMJmns1qu53G+bX3CI/BdNWshnlfKoTfJbW9Sg5M5RXRnOcBzKx7OJNXVjmd7VS5FHBz 3awV2GYNsu8JmbVW20Vs+bTQbsBZsykBj4adVcooVQDkwNke77V9ZcPxKnTBfG5Dt9Jv xc4Q== X-Gm-Message-State: AOJu0Yyj6RX/sgtMMoovTYdHiuGSqGKEwmjxBwCKAU6ne+obDdLnfGjQ g1Fdte2KKqXeumv4R897xD29GgiloPER2ZKU1Fc= X-Google-Smtp-Source: AGHT+IFUmmLf81XW+0v/PIBWIgf/w876vPads/HiyjhrNHxjunDXgCtA0VL7OiFm16kFVbgbhAhrywxkC/s/XCjErhA= X-Received: by 2002:a05:6358:2909:b0:135:499a:382b with SMTP id y9-20020a056358290900b00135499a382bmr27241785rwb.7.1693133589936; Sun, 27 Aug 2023 03:53:09 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> In-Reply-To: <87zg2fnwm0.fsf@gmail.com> From: Filippo Argiolas Date: Sun, 27 Aug 2023 12:52:58 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Sun, 27 Aug 2023 10:54:44 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Aug 25, 2023 at 2:16=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > Filippo Argiolas writes: > > OK, after fetching that git snapshot today, I've done this: > > It's bare-bone but it works, because the method for communicating > "inactive regions" is very basic (and similar to unsolicited > diagnostics). > > Only minimally tested, so YMMV. > > This serves as a good example of how to support unofficial LSP > extensions using Eglot as an API. Could well be in the manual. > > The method for providing a client-side capability based on a server is > crude. Servers do identify themselves properly via LSP, but only after > being initialized, so it's too late and I had to use an heuritic based > on the command. We could also use a proper subclass for clangd servers, > but that's too verbose and overkill IMHO. That's great! Definitely owe you a beer or a bottle of your favorite bevera= ge! Still testing it but so far it seems to work perfectly! Love that clangd is smart enough to classify as inactive also other stuff beyond ifdefs, like headers included but not used. About the heuristic would it be that bad to just include inactiveRegions in the general client capabilities? Guess it would be just ignored by other servers not supporting it, wouldn't it? Kind of surprised clangd doesn't use some kind of namespacing convention for their protocol extensions. Anyway, it would be great if this could be a part of eglot but I can understand being careful given it's not in the standard protocol and not even in a released clangd yet. It would be great though if this example was included in the docs. It says a lot about how easy to extend and well designed eglot is. One thing about UI, all the themes I tried seem to render shadow as grey-ish but it was my impression reading the docs that it would be a dim version of the current face, so it would still have syntax highlighting. Is it just a theme limitation (probably because shadow wasn't used for something like this before) or it's not technically possible? Thanks a lot again, Filippo From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 19:06:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.16935087515049 (code B ref 65418); Thu, 31 Aug 2023 19:06:03 +0000 Received: (at 65418) by debbugs.gnu.org; 31 Aug 2023 19:05:51 +0000 Received: from localhost ([127.0.0.1]:59221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbmzH-0001JH-5R for submit@debbugs.gnu.org; Thu, 31 Aug 2023 15:05:51 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:46121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qblTj-00043l-Rs for 65418@debbugs.gnu.org; Thu, 31 Aug 2023 13:29:12 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-68bed2c786eso900385b3a.0 for <65418@debbugs.gnu.org>; Thu, 31 Aug 2023 10:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693502937; x=1694107737; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sZHLw62BnUTK9xflBGtI3L3iwlyrFVkJMWzBbPcgIcE=; b=qJK3TO+B44sqZG+TC0ue8l+QIm68kmLZPfcTeJ0e1K136j9QGBIeowN+R0+TtOvyZs tJADMQw6ptlQd7iDKxBdw1oHbvi63CPz3DiiG2UEOwUYzY7UNj7IKv0YXrAu3d5wL1/Z E30r4ngkR3JdnEHqA/agvcbV2RRQzs0IboEV0mNffZ2WtT3Tz3pRMbxiCjvXEwVrImFy 0cEegCqoI9uxsIPTFR6X+pzCLY1i6153XXjGwUfkL7lPI68eYbU+E4v4AmLQd3mhWmFv sfxVkBMx/AFWKZy2Azwl7BVrr/1ObXO0CDMNJz9vexo+Y6I+HwxHXDfZfoDWdgZSzNcG 8ztQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693502937; x=1694107737; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sZHLw62BnUTK9xflBGtI3L3iwlyrFVkJMWzBbPcgIcE=; b=VelpgjzcpzsVETlv2U4YpnSar4aSctZJWoOWBMmveF6282JTqLqvF9RUXqtXMWeJIt zHsYat0T3J816C3dne6l9lJO//zBGEt5LTtTFpoFSkYwyDyr0V8S1qEWlZW5VkFkfM43 jToGoJVp7ZaFplFN6OSCrQAJze8GvJKGzQ5mNlgJX4/Oy+aDXirDE5BujkcG/MjmFYBe zjNoNg0V0cpWmaSFxGnltti6WROVz1UzVAxMg/cAqRli7MbqicJIwlg8a8HAWDhUfaQp ZT/LtrUs68QxEuN2LQM7oHdskOsAOy3f+W0VojiVUsqr22TEHFSXP0gqjHvLTGsEszK4 3poQ== X-Gm-Message-State: AOJu0YzVKWJAXPSvw7JjE0AI7SiviklW2ykOMRh9nbL7uHL81ixuVHJR pb59A1559NfdRZCSDnjRt6qYqtd1Tar138JAXXE= X-Google-Smtp-Source: AGHT+IHiVJoUP+sOgHRBVJxOQnv+aukfaOjWVQvAmOq82iCQw03saHh6+U0XmgE5jD1nc6iwF0B++QbylVcoyhQqFNU= X-Received: by 2002:a05:6a00:2e19:b0:68b:e6e0:5047 with SMTP id fc25-20020a056a002e1900b0068be6e05047mr389037pfb.14.1693502937205; Thu, 31 Aug 2023 10:28:57 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> In-Reply-To: <873504d1oe.fsf@gmail.com> From: Filippo Argiolas Date: Thu, 31 Aug 2023 19:28:45 +0200 Message-ID: Content-Type: multipart/mixed; boundary="00000000000001484a06043b6135" X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Thu, 31 Aug 2023 15:05:48 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000001484a06043b6135 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > Glad to help. You're lucky I'm not some kind of wine connoisseur ;-) > Make a patch for that (and remember to also include the exportation of > the '--' symbols). > Many thanks again! That code definitely made this work week more enjoyable = ;-) Sorry for the delay with the patch, little time left these days for side projects or even trivial contributions like this. See if the attached patches could do! > > One thing about UI, all the themes I tried seem to render shadow as > > grey-ish but it was my impression reading the docs that it would be a > > dim version of the current face, so it would still have syntax > > highlighting. Is it just a theme limitation (probably because shadow > > wasn't used for something like this before) or it's not technically > > possible? > > I'm fairly sure it's technically possible, even if perhaps not easy. > You can investigate or ask this on emacs-devel. Agreed, will move the discussion about this there. Filippo --00000000000001484a06043b6135 Content-Type: application/octet-stream; name="0002-Promote-eglot-methods-used-in-examples-to-public.patch" Content-Disposition: attachment; filename="0002-Promote-eglot-methods-used-in-examples-to-public.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_llzfvvao1 RnJvbSAxODM0MDEwNDI5M2VmMDA0YzM4MzA1YWM5OTgzOWU1Y2E5ZmFlZGM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGaWxpcHBvIEFyZ2lvbGFzIDxmaWxpcHBvLmFyZ2lvbGFzQGdt YWlsLmNvbT4KRGF0ZTogVGh1LCAzMSBBdWcgMjAyMyAxOTowOTo0NyArMDIwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBQcm9tb3RlIGVnbG90IG1ldGhvZHMgdXNlZCBpbiBleGFtcGxlcyB0byBwdWJs aWMKCiogbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWw6IHByb21vdGUgZWdsb3QtLXVyaS10by1wYXRo IGFuZAplZ2xvdC0tcmFuZ2UtcmVnaW9uIHRvIHB1YmxpYyBBUEkgYXMgdGhleSdyZSBiZWluZyB1 c2VkIGluIGVnbG90IGRvY3MKYXMgZXhhbXBsZSBhYm91dCBleHRlbmRpbmcgZWdsb3QgZnVuY3Rp b25hbGl0eQoKKiBkb2MvbWlzYy9lZ2xvdC50ZXhpOiB1cGRhdGUgRXh0ZW5kaW5nIEVnbG90IGV4 YW1wbGUgd2l0aCBuZXcgcHVibGljIG1ldGhvZHMKLS0tCiBkb2MvbWlzYy9lZ2xvdC50ZXhpICAg ICB8ICAyICstCiBsaXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbCB8IDMyICsrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDE3IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9taXNjL2VnbG90LnRleGkgYi9kb2MvbWlzYy9l Z2xvdC50ZXhpCmluZGV4IGVkMTQ1NjcyNWFlLi5kYzY2OGFlNzk2MCAxMDA2NDQKLS0tIGEvZG9j L21pc2MvZWdsb3QudGV4aQorKysgYi9kb2MvbWlzYy9lZ2xvdC50ZXhpCkBAIC0xMzE2LDcgKzEz MTYsNyBAQCBFeHRlbmRpbmcgRWdsb3QKIChjbC1kZWZtZXRob2QgZWdsb3QtaGFuZGxlLW5vdGlm aWNhdGlvbgogICAoX3NlcnZlciAoX21ldGhvZCAoZXFsIHRleHREb2N1bWVudC9pbmFjdGl2ZVJl Z2lvbnMpKQogICAgICAgICAgICAma2V5IHJlZ2lvbnMgdGV4dERvY3VtZW50ICZhbGxvdy1vdGhl ci1rZXlzKQotICAoaWYtbGV0KiAoKHBhdGggKGV4cGFuZC1maWxlLW5hbWUgKGVnbG90LS11cmkt dG8tcGF0aAorICAoaWYtbGV0KiAoKHBhdGggKGV4cGFuZC1maWxlLW5hbWUgKGVnbG90LXVyaS10 by1wYXRoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNsLWdldGYgdGV4 dERvY3VtZW50IDp1cmkpKSkpCiAgICAgICAgICAgICAoYnVmZmVyIChmaW5kLWJ1ZmZlci12aXNp dGluZyBwYXRoKSkpCiAgICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciBidWZmZXIKZGlmZiAtLWdp dCBhL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsIGIvbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwKaW5k ZXggNjVkYWEwOTQxZDUuLjMxOTBhOWZlNzYyIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9l Z2xvdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbApAQCAtMTY3MSw3ICsxNjcxLDcg QEAgZWdsb3QtLXBhdGgtdG8tdXJpCiAgICAgICAgICAgICAgICBlZ2xvdC0tdXJpLXBhdGgtYWxs b3dlZC1jaGFycykpKSkpCiAKIChkZWNsYXJlLWZ1bmN0aW9uIHczMi1sb25nLWZpbGUtbmFtZSAi dzMycHJvYy5jIiAoZm4pKQotKGRlZnVuIGVnbG90LS11cmktdG8tcGF0aCAodXJpKQorKGRlZnVu IGVnbG90LXVyaS10by1wYXRoICh1cmkpCiAgICJDb252ZXJ0IFVSSSB0byBmaWxlIHBhdGgsIGhl bHBlZCBieSBgZWdsb3QtLWN1cnJlbnQtc2VydmVyJy4iCiAgICh3aGVuIChrZXl3b3JkcCB1cmkp IChzZXRxIHVyaSAoc3Vic3RyaW5nIChzeW1ib2wtbmFtZSB1cmkpIDEpKSkKICAgKGxldCogKChz ZXJ2ZXIgKGVnbG90LWN1cnJlbnQtc2VydmVyKSkKQEAgLTE3ODAsNyArMTc4MCw3IEBAIGVnbG90 LS1zZXJ2ZXItY2FwYWJsZS1vci1sb3NlCiAgICAgICAgICAgICAgICAgICAgIChtYXBjb25jYXQg IydzeW1ib2wtbmFtZSBmZWF0cyAiICIpKSkKICAgICByZXR2YWwpKQogCi0oZGVmdW4gZWdsb3Qt LXJhbmdlLXJlZ2lvbiAocmFuZ2UgJm9wdGlvbmFsIG1hcmtlcnMpCisoZGVmdW4gZWdsb3QtcmFu Z2UtcmVnaW9uIChyYW5nZSAmb3B0aW9uYWwgbWFya2VycykKICAgIlJldHVybiByZWdpb24gKEJF RyAuIEVORCkgdGhhdCByZXByZXNlbnRzIExTUCBSQU5HRS4KIElmIG9wdGlvbmFsIE1BUktFUlMs IG1ha2UgbWFya2Vycy4iCiAgIChsZXQqICgoc3QgKHBsaXN0LWdldCByYW5nZSA6c3RhcnQpKQpA QCAtMjI5MSw3ICsyMjkxLDcgQEAgZWdsb3QtaGFuZGxlLW5vdGlmaWNhdGlvbgogICAgICAgICAg ICAgICAgICAgICAodCAgICAgICAgICAnZWdsb3Qtbm90ZSkpKQogICAgICAgICAgICAgKG1lc3Mg KHNvdXJjZSBjb2RlIG1lc3NhZ2UpCiAgICAgICAgICAgICAgIChjb25jYXQgc291cmNlIChhbmQg Y29kZSAoZm9ybWF0ICIgWyVzXSIgY29kZSkpICI6ICIgbWVzc2FnZSkpKQotICAgIChpZi1sZXQq ICgocGF0aCAoZXhwYW5kLWZpbGUtbmFtZSAoZWdsb3QtLXVyaS10by1wYXRoIHVyaSkpKQorICAg IChpZi1sZXQqICgocGF0aCAoZXhwYW5kLWZpbGUtbmFtZSAoZWdsb3QtdXJpLXRvLXBhdGggdXJp KSkpCiAgICAgICAgICAgICAgIChidWZmZXIgKGZpbmQtYnVmZmVyLXZpc2l0aW5nIHBhdGgpKSkK ICAgICAgICAgKHdpdGgtY3VycmVudC1idWZmZXIgYnVmZmVyCiAgICAgICAgICAgKGNsLWxvb3AK QEAgLTIzMDMsNyArMjMwMyw3IEBAIGVnbG90LWhhbmRsZS1ub3RpZmljYXRpb24KICAgICAgICAg ICAgICAgICAgICAgICAgZGlhZy1zcGVjCiAgICAgICAgICAgICAgICAgICAgICAoc2V0cSBtZXNz YWdlIChtZXNzIHNvdXJjZSBjb2RlIG1lc3NhZ2UpKQogICAgICAgICAgICAgICAgICAgICAgKHBj YXNlLWxldAotICAgICAgICAgICAgICAgICAgICAgICAgICgoYCgsYmVnIC4gLGVuZCkgKGVnbG90 LS1yYW5nZS1yZWdpb24gcmFuZ2UpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAoKGAoLGJl ZyAuICxlbmQpIChlZ2xvdC1yYW5nZS1yZWdpb24gcmFuZ2UpKSkKICAgICAgICAgICAgICAgICAg ICAgICAgOzsgRmFsbGJhY2sgdG8gYGZseW1ha2UtZGlhZy1yZWdpb24nIGlmIHNlcnZlcgogICAg ICAgICAgICAgICAgICAgICAgICA7OyBib3RjaGVkIHRoZSByYW5nZQogICAgICAgICAgICAgICAg ICAgICAgICAod2hlbiAoPSBiZWcgZW5kKQpAQCAtMjM5NSw3ICsyMzk1LDcgQEAgZWdsb3QtaGFu ZGxlLXJlcXVlc3QKICAgICAgICAgKGZpbGVuYW1lKSkKICAgICAoY29uZAogICAgICAoKGVxIGV4 dGVybmFsIHQpIChicm93c2UtdXJsIHVyaSkpCi0gICAgICgoZmlsZS1yZWFkYWJsZS1wIChzZXRx IGZpbGVuYW1lIChlZ2xvdC0tdXJpLXRvLXBhdGggdXJpKSkpCisgICAgICgoZmlsZS1yZWFkYWJs ZS1wIChzZXRxIGZpbGVuYW1lIChlZ2xvdC11cmktdG8tcGF0aCB1cmkpKSkKICAgICAgIDs7IFVz ZSBydW4td2l0aC10aW1lciB0byBhdm9pZCBuZXN0ZWQgY2xpZW50IHJlcXVlc3RzIGxpa2UgdGhl CiAgICAgICA7OyAic3luY2hyb25vdXMgaW1lbnUiIGZsb2F0ZWQgaW4gYnVnIzYyMTE2IHByZXN1 bWFibHkgY2F1c2VkIGJ5CiAgICAgICA7OyB3aGljaC1mdW5jLW1vZGUuCkBAIC0yNDA4LDcgKzI0 MDgsNyBAQCBlZ2xvdC1oYW5kbGUtcmVxdWVzdAogICAgICAgICAgICAgICAgICAgKHNlbGVjdC1m cmFtZS1zZXQtaW5wdXQtZm9jdXMgKHNlbGVjdGVkLWZyYW1lKSkpCiAgICAgICAgICAgICAgICAg ICgoZGlzcGxheS1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkpKQogICAgICAgICAgICAod2hlbiBz ZWxlY3Rpb24KLSAgICAgICAgICAgICAocGNhc2UtbGV0ICgoYCgsYmVnIC4gLGVuZCkgKGVnbG90 LS1yYW5nZS1yZWdpb24gc2VsZWN0aW9uKSkpCisgICAgICAgICAgICAgKHBjYXNlLWxldCAoKGAo LGJlZyAuICxlbmQpIChlZ2xvdC1yYW5nZS1yZWdpb24gc2VsZWN0aW9uKSkpCiAgICAgICAgICAg ICAgICA7OyBGSVhNRTogaXQgaXMgdmVyeSBuYXVnaHR5IHRvIHVzZSBzb21lb25lIGVsc2UncyBg LS0nCiAgICAgICAgICAgICAgICA7OyBmdW5jdGlvbiwgYnV0IGB4cmVmLS1nb3RvLWNoYXInIGhh cHBlbnMgdG8gaGF2ZQogICAgICAgICAgICAgICAgOzsgZXhhY3RseSB0aGUgc2VtYW50aWNzIHdl IHdhbnQgdmlzLWEtdmlzIHdpZGVuaW5nLgpAQCAtMjY0Myw3ICsyNjQzLDcgQEAgZWdsb3QtaGFu ZGxlLXJlcXVlc3QKICAgICAgICAgIChtYXBjYXIKICAgICAgICAgICAoZWdsb3QtLWxhbWJkYSAo KENvbmZpZ3VyYXRpb25JdGVtKSBzY29wZVVyaSBzZWN0aW9uKQogICAgICAgICAgICAgKGNsLWxv b3AKLSAgICAgICAgICAgICB3aXRoIHNjb3BlLXVyaS1wYXRoID0gKGFuZCBzY29wZVVyaSAoZWds b3QtLXVyaS10by1wYXRoIHNjb3BlVXJpKSkKKyAgICAgICAgICAgICB3aXRoIHNjb3BlLXVyaS1w YXRoID0gKGFuZCBzY29wZVVyaSAoZWdsb3QtdXJpLXRvLXBhdGggc2NvcGVVcmkpKQogICAgICAg ICAgICAgIGZvciAod3NlY3Rpb24gbykKICAgICAgICAgICAgICBvbiAoZWdsb3QtLXdvcmtzcGFj ZS1jb25maWd1cmF0aW9uLXBsaXN0IHNlcnZlciBzY29wZS11cmktcGF0aCkKICAgICAgICAgICAg ICBieSAjJ2NkZHIKQEAgLTI3NzQsMTIgKzI3NzQsMTIgQEAgZWdsb3QtLXhyZWYtbWFrZS1tYXRj aAogICAiTGlrZSBgeHJlZi1tYWtlLW1hdGNoJyBidXQgd2l0aCBMU1AncyBOQU1FLCBVUkkgYW5k IFJBTkdFLgogVHJ5IHRvIHZpc2l0IHRoZSB0YXJnZXQgZmlsZSBmb3IgYSByaWNoZXIgc3VtbWFy eSBsaW5lLiIKICAgKHBjYXNlLWxldCoKLSAgICAgICgoZmlsZSAoZWdsb3QtLXVyaS10by1wYXRo IHVyaSkpCisgICAgICAoKGZpbGUgKGVnbG90LXVyaS10by1wYXRoIHVyaSkpCiAgICAgICAgKHZp c2l0aW5nIChvciAoZmluZC1idWZmZXItdmlzaXRpbmcgZmlsZSkKICAgICAgICAgICAgICAgICAg ICAgIChnZXRoYXNoIHVyaSBlZ2xvdC0tdGVtcC1sb2NhdGlvbi1idWZmZXJzKSkpCiAgICAgICAg KGNvbGxlY3QgKGxhbWJkYSAoKQogICAgICAgICAgICAgICAgICAgKGVnbG90LS13aWRlbmluZwot ICAgICAgICAgICAgICAgICAgIChwY2FzZS1sZXQqICgoYCgsYmVnIC4gLGVuZCkgKGVnbG90LS1y YW5nZS1yZWdpb24gcmFuZ2UpKQorICAgICAgICAgICAgICAgICAgIChwY2FzZS1sZXQqICgoYCgs YmVnIC4gLGVuZCkgKGVnbG90LXJhbmdlLXJlZ2lvbiByYW5nZSkpCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChib2wgKHByb2duIChnb3RvLWNoYXIgYmVnKSAoZWdsb3QtLWJvbCkp KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3Vic3RyaW5nIChidWZmZXItc3Vi c3RyaW5nIGJvbCAobGluZS1lbmQtcG9zaXRpb24pKSkKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGhpLWJlZyAoLSBiZWcgYm9sKSkKQEAgLTMxOTAsNyArMzE5MCw3IEBAIGVnbG90 LWNvbXBsZXRpb24tYXQtcG9pbnQKICAgICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUtcmVn aW9uIG9yaWctcG9zIChwb2ludCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAoZWdsb3QtLWRi aW5kICgoVGV4dEVkaXQpIHJhbmdlIG5ld1RleHQpIHRleHRFZGl0CiAgICAgICAgICAgICAgICAg ICAgICAgICAgIChwY2FzZS1sZXQgKChgKCxiZWcgLiAsZW5kKQotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGVnbG90LS1yYW5nZS1yZWdpb24gcmFuZ2UpKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlZ2xvdC1yYW5nZS1yZWdpb24gcmFu Z2UpKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiBiZWcgZW5k KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIChnb3RvLWNoYXIgYmVnKQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChmdW5jYWxsIChvciBzbmlwcGV0LWZuICMnaW5zZXJ0KSBuZXdU ZXh0KSkpKQpAQCAtMzMzMSw3ICszMzMxLDcgQEAgZWdsb3QtLWhpZ2hsaWdodC1waWdneWJhY2sK ICAgICAgICAgICAgICAgICAgKG1hcGNhcgogICAgICAgICAgICAgICAgICAgKGVnbG90LS1sYW1i ZGEgKChEb2N1bWVudEhpZ2hsaWdodCkgcmFuZ2UpCiAgICAgICAgICAgICAgICAgICAgIChwY2Fz ZS1sZXQgKChgKCxiZWcgLiAsZW5kKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGVnbG90LS1yYW5nZS1yZWdpb24gcmFuZ2UpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChlZ2xvdC1yYW5nZS1yZWdpb24gcmFuZ2UpKSkKICAgICAgICAgICAgICAgICAgICAg ICAobGV0ICgob3YgKG1ha2Utb3ZlcmxheSBiZWcgZW5kKSkpCiAgICAgICAgICAgICAgICAgICAg ICAgICAob3ZlcmxheS1wdXQgb3YgJ2ZhY2UgJ2VnbG90LWhpZ2hsaWdodC1zeW1ib2wtZmFjZSkK ICAgICAgICAgICAgICAgICAgICAgICAgIChvdmVybGF5LXB1dCBvdiAnbW9kaWZpY2F0aW9uLWhv b2tzCkBAIC0zMzUxLDcgKzMzNTEsNyBAQCBlZ2xvdC0taW1lbnUtU3ltYm9sSW5mb3JtYXRpb24K ICAgICAgICAocGNhc2UtbGFtYmRhIChgKCxjb250YWluZXIgLiAsb2JqcykpCiAgICAgICAgICAo bGV0ICgoZWxlbXMgKG1hcGNhcgogICAgICAgICAgICAgICAgICAgICAgICAoZWdsb3QtLWxhbWJk YSAoKFN5bWJvbEluZm9ybWF0aW9uKSBraW5kIG5hbWUgbG9jYXRpb24pCi0gICAgICAgICAgICAg ICAgICAgICAgICAgKGxldCAoKHJlZyAoZWdsb3QtLXJhbmdlLXJlZ2lvbgorICAgICAgICAgICAg ICAgICAgICAgICAgIChsZXQgKChyZWcgKGVnbG90LXJhbmdlLXJlZ2lvbgogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChwbGlzdC1nZXQgbG9jYXRpb24gOnJhbmdlKSkpCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGtpbmQgKGFsaXN0LWdldCBraW5kIGVnbG90 LS1zeW1ib2wta2luZC1uYW1lcykpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnMg KHByb3BlcnRpemUgbmFtZQpAQCAtMzM2Nyw3ICszMzY3LDcgQEAgZWdsb3QtLWltZW51LVN5bWJv bEluZm9ybWF0aW9uCiAoZGVmdW4gZWdsb3QtLWltZW51LURvY3VtZW50U3ltYm9sIChyZXMpCiAg ICJDb21wdXRlIGBpbWVudS0taW5kZXgtYWxpc3QnIGZvciBSRVMgdmVjdG9yIG9mIERvY3VtZW50 U3ltYm9sLiIKICAgKGNsLWxhYmVscyAoKGRmcyAoJmtleSBuYW1lIGNoaWxkcmVuIHJhbmdlIGtp bmQgJmFsbG93LW90aGVyLWtleXMpCi0gICAgICAgICAgICAgICAgKGxldCogKChyZWcgKGVnbG90 LS1yYW5nZS1yZWdpb24gcmFuZ2UpKQorICAgICAgICAgICAgICAgIChsZXQqICgocmVnIChlZ2xv dC1yYW5nZS1yZWdpb24gcmFuZ2UpKQogICAgICAgICAgICAgICAgICAgICAgICAoa2luZCAoYWxp c3QtZ2V0IGtpbmQgZWdsb3QtLXN5bWJvbC1raW5kLW5hbWVzKSkKICAgICAgICAgICAgICAgICAg ICAgICAgKG5hbWUgKHByb3BlcnRpemUgbmFtZQogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnYnJlYWRjcnVtYi1yZWdpb24gcmVnCkBAIC0zNDIzLDcgKzM0MjMsNyBA QCBlZ2xvdC0tYXBwbHktdGV4dC1lZGl0cwogICAgICAgICAgICAgICAgICAgICAgICh3aGVuIHJl cG9ydGVyCiAgICAgICAgICAgICAgICAgICAgICAgICAoZWdsb3QtLXJlcG9ydGVyLXVwZGF0ZSBy ZXBvcnRlciAoY2wtaW5jZiBkb25lKSkpKSkpKSkKICAgICAgICAgICAgIChtYXBjYXIgKGVnbG90 LS1sYW1iZGEgKChUZXh0RWRpdCkgcmFuZ2UgbmV3VGV4dCkKLSAgICAgICAgICAgICAgICAgICAg ICAoY29ucyBuZXdUZXh0IChlZ2xvdC0tcmFuZ2UtcmVnaW9uIHJhbmdlICdtYXJrZXJzKSkpCisg ICAgICAgICAgICAgICAgICAgICAgKGNvbnMgbmV3VGV4dCAoZWdsb3QtcmFuZ2UtcmVnaW9uIHJh bmdlICdtYXJrZXJzKSkpCiAgICAgICAgICAgICAgICAgICAgIChyZXZlcnNlIGVkaXRzKSkpCiAg ICAgICAodW5kby1hbWFsZ2FtYXRlLWNoYW5nZS1ncm91cCBjaGFuZ2UtZ3JvdXApCiAgICAgICAo d2hlbiByZXBvcnRlcgpAQCAtMzQzNiwxNCArMzQzNiwxNCBAQCBlZ2xvdC0tYXBwbHktd29ya3Nw YWNlLWVkaXQKICAgICAgICAgICAgKG1hcGNhciAoZWdsb3QtLWxhbWJkYSAoKFRleHREb2N1bWVu dEVkaXQpIHRleHREb2N1bWVudCBlZGl0cykKICAgICAgICAgICAgICAgICAgICAgIChlZ2xvdC0t ZGJpbmQgKChWZXJzaW9uZWRUZXh0RG9jdW1lbnRJZGVudGlmaWVyKSB1cmkgdmVyc2lvbikKICAg ICAgICAgICAgICAgICAgICAgICAgICB0ZXh0RG9jdW1lbnQKLSAgICAgICAgICAgICAgICAgICAg ICAgKGxpc3QgKGVnbG90LS11cmktdG8tcGF0aCB1cmkpIGVkaXRzIHZlcnNpb24pKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgKGxpc3QgKGVnbG90LXVyaS10by1wYXRoIHVyaSkgZWRpdHMgdmVy c2lvbikpKQogICAgICAgICAgICAgICAgICAgIGRvY3VtZW50Q2hhbmdlcykpKQogICAgICAgKHVu bGVzcyAoYW5kIGNoYW5nZXMgZG9jdW1lbnRDaGFuZ2VzKQogICAgICAgICA7OyBXZSBkb24ndCB3 YW50IGRvdWJsZSBlZGl0cywgYW5kIHNvbWUgc2VydmVycyBzZW5kIGJvdGgKICAgICAgICAgOzsg Y2hhbmdlcyBhbmQgZG9jdW1lbnRDaGFuZ2VzLiAgVGhpcyB1bmxlc3MgZW5zdXJlcyB0aGF0IHdl CiAgICAgICAgIDs7IHByZWZlciBkb2N1bWVudENoYW5nZXMgb3ZlciBjaGFuZ2VzLgogICAgICAg ICAoY2wtbG9vcCBmb3IgKHVyaSBlZGl0cykgb24gY2hhbmdlcyBieSAjJ2NkZHIKLSAgICAgICAg ICAgICAgICAgZG8gKHB1c2ggKGxpc3QgKGVnbG90LS11cmktdG8tcGF0aCB1cmkpIGVkaXRzKSBw cmVwYXJlZCkpKQorICAgICAgICAgICAgICAgICBkbyAocHVzaCAobGlzdCAoZWdsb3QtdXJpLXRv LXBhdGggdXJpKSBlZGl0cykgcHJlcGFyZWQpKSkKICAgICAgIChpZiAob3IgY29uZmlybQogICAg ICAgICAgICAgICAoY2wtbm90ZXZlcnkgIydmaW5kLWJ1ZmZlci12aXNpdGluZwogICAgICAgICAg ICAgICAgICAgICAgICAgICAgKG1hcGNhciAjJ2NhciBwcmVwYXJlZCkpKQotLSAKMi40MS4wCgo= --00000000000001484a06043b6135 Content-Type: application/octet-stream; name="0001-Add-documentation-about-extending-Eglot.patch" Content-Disposition: attachment; filename="0001-Add-documentation-about-extending-Eglot.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_llzfvvak0 RnJvbSBlODYwYmFiMmFjMjJmYjllYTk5ZTEyYmIwOTVmNzJlZjRjOWI3NzRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGaWxpcHBvIEFyZ2lvbGFzIDxmaWxpcHBvLmFyZ2lvbGFzQGdt YWlsLmNvbT4KRGF0ZTogVGh1LCAzMSBBdWcgMjAyMyAwNzoyMjowNSArMDIwMApTdWJqZWN0OiBb UEFUQ0ggMS8yXSBBZGQgZG9jdW1lbnRhdGlvbiBhYm91dCBleHRlbmRpbmcgRWdsb3QKTUlNRS1W ZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRl bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCiogZG9jL21pc2MvZWdsb3QudGV4aTogYWRkIGEg c2ltcGxlIGV4YW1wbGUgYWJvdXQgZXh0ZW5kaW5nIEVnbG90CmltcGxlbWVudGluZyBpdHMgZ2Vu ZXJpYyBtZXRob2RzLiBUaGUgZXhhbXBsZSwgZnJvbSBKb8OjbyBUw6F2b3JhLCBhZGRzCnN1cHBv cnQgdG8gaW5hY3RpdmVSZWdpb25zIGNsYW5nZCBwcm90b2NvbCBleHRlbnNpb24gcmVuZGVyaW5n CmluYWN0aXZlIGNvZGUgcmVnaW9ucyBhcyBzaGFkb3dlZCBpbiBhIExTUCBhd2FyZSB3YXkgKHNl ZSBkaXNjdXNzaW9uCmluIGJ1ZyM2NTQxOCkKLS0tCiBkb2MvbWlzYy9lZ2xvdC50ZXhpIHwgNzAg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hh bmdlZCwgNzAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RvYy9taXNjL2VnbG90LnRleGkg Yi9kb2MvbWlzYy9lZ2xvdC50ZXhpCmluZGV4IDZlYjIxMmNhODQxLi5lZDE0NTY3MjVhZSAxMDA2 NDQKLS0tIGEvZG9jL21pc2MvZWdsb3QudGV4aQorKysgYi9kb2MvbWlzYy9lZ2xvdC50ZXhpCkBA IC05ODUsNiArOTg1LDcgQEAgQWR2YW5jZWQgc2VydmVyIGNvbmZpZ3VyYXRpb24KICogUHJvamVj dC1zcGVjaWZpYyBjb25maWd1cmF0aW9uOjoKICogVXNlci1zcGVjaWZpYyBjb25maWd1cmF0aW9u OjoKICogSlNPTlJQQyBvYmplY3RzIGluIEVsaXNwOjoKKyogRXh0ZW5kaW5nIEVnbG90OjoKIEBl bmQgbWVudQogCiBJdCdzIGltcG9ydGFudCB0byBub3RlIHRoYXQgbm90IGFsbCBzZXJ2ZXJzIGFs bG93IGJvdGgga2luZHMgb2YKQEAgLTEyNjIsNiArMTI2Myw3NSBAQCBKU09OUlBDIG9iamVjdHMg aW4gRWxpc3AKIEB9CiBAZW5kIGV4YW1wbGUKIAorQG5vZGUgRXh0ZW5kaW5nIEVnbG90CitAc2Vj dGlvbiBFeHRlbmRpbmcgRWdsb3QKK1NvbWV0aW1lcyBpdCBtYXkgYmUgdXNlZnVsIHRvIGV4dGVu ZCBleGlzdGluZyBFZ2xvdCBmdW5jdGlvbmFsaXR5Cit1c2luZyBpdHMgcHVibGljIG1ldGhvZHMu ICBBIGdvb2QgZXhhbXBsZSBvZiB3aGVuIHRoaXMgbmVlZCBtYXkgYXJpc2UKK2lzIGFkZGluZyBz dXBwb3J0IGZvciBhIGN1c3RvbSBMU1AgcHJvdG9jb2wgZXh0ZW5zaW9uIG9ubHkgaW1wbGVtZW50 ZWQKK2J5IGEgc3BlY2lmaWMgc2VydmVyLgorCitUaGUgYmVzdCBzb3VyY2Ugb2YgZG9jdW1lbnRh dGlvbiBmb3IgdGhpcyBpcyBwcm9iYWJseSBFZ2xvdCBzb3VyY2UKK2NvZGUgaXRzZWxmLiBNb3N0 IG9mIHRoZSBmdW5jdGlvbmFsaXR5IGlzIGltcGxlbWVudGVkIHdpdGggZ2VuZXJpYworbWV0aG9k cyB0aGF0IGNhbiBiZSBlYXNpbHkgZXh0ZW5kZWQgb3Igb3ZlcnJpZGRlbiBhbmQgdGhlIGNvZGUg aXRzZWxmCitzaG93cyBtYW55IGV4YW1wbGVzIGFib3V0IGhvdyB0byBkbyB0aGlzLgorCitIZXJl J3MgYSBzaW1wbGUgZXhhbXBsZSB0aGF0IGFkZHMgc3VwcG9ydCBmb3IgY2xhbmdkCitAY29kZXtp bmFjdGl2ZVJlZ2lvbnN9IGV4dGVuc2lvbiBpbnRyb2R1Y2VkIGluIGNsYW5nZCAxNy4KKworV2hl biBAY29kZXtpbmFjdGl2ZVJlZ2lvbnN9IGNhcGFiaWxpdHkgaXMgZW5hYmxlZCB0aGUgc2VydmVy IHdpbGwgc2VuZAorYSBAY29kZXt0ZXh0RG9jdW1lbnQvaW5hY3RpdmVSZWdpb25zfSBub3RpZmlj YXRpb24gd2l0aCBhIGxpc3Qgb2YKK2luYWN0aXZlIGNvZGUgKGUuZy4gY29kZSB1bmRlciBpZmRl ZiBtYWNyb3MpIHJlZ2lvbnMgdG8gdGhlIGNsaWVudC4KKworVGhlIGZpcnN0IG1ldGhvZCBleHRl bmRzIEBjb2Rle2VnbG90LWNsaWVudC1jYXBhYmlsaXRpZXN9IHVzaW5nIGEKK3NpbXBsZSBoZXVy aXN0aWMgdG8gZGV0ZWN0IGlmIGN1cnJlbnQgc2VydmVyIGlzIEBjb21tYW5ke2NsYW5nZH0gYW5k CitlbmFibGVzIHRoZSBAY29kZXtpbmFjdGl2ZVJlZ2lvbn0gY2FwYWJpbGl0eS4KKworVGhlIHNl Y29uZCBtZXRob2QgaW1wbGVtZW50cyBAY29kZXtlZ2xvdC1oYW5kbGUtbm90aWZpY2F0aW9ufSB0 bworcHJvY2VzcyB0aGUgY29ycmVzcG9uZGVudCBzZXJ2ZXIgbm90aWZpY2F0aW9uIGFuZCBmb3Ig ZWFjaCByZWdpb24KK3JlY2VpdmVkIGl0IGNyZWF0ZXMgYW4gb3ZlcmxheSBhcHBseWluZyB0aGUg QGNvZGV7c2hhZG93fSBmYWNlIHRvIHRoZQorcmVnaW9uLiBPdmVybGF5cyBhcmUgcmVjcmVhdGVk IGV2ZXJ5IHRpbWUgYSBuZXcgbm90aWZpY2F0aW9uIGlzCityZWNlaXZlZC4KKworUmVzdWx0IHdp bGwgYmUgdGhhdCBhbGwgdGhlIGluYWN0aXZlIGNvZGUgaW4gdGhlIGJ1ZmZlciB3aWxsIGJlIG5p Y2VseQorZ3JleWVkIG91dCB1c2luZyB0aGUgTFNQIHNlcnZlciBrbm93bGVkZ2UgYWJvdXQgY3Vy cmVudCBjb21waWxlIHRpbWUKK3ByZXByb2Nlc3NvciBkZWZpbmVzLgorCitAbGlzcAorOzs7IGVn bG90LWNsYW5nZC1pbmFjdGl2ZS1yZWdpb24uZWwgLSotIGxleGljYWwtYmluZGluZzogdDsgLSot CisKKyhyZXF1aXJlICdlZ2xvdCkKKyhyZXF1aXJlICdjbC1saWIpCisKKyhjbC1kZWZtZXRob2Qg ZWdsb3QtY2xpZW50LWNhcGFiaWxpdGllcyA6YXJvdW5kIChzZXJ2ZXIpCisgIChsZXQgKChiYXNl IChjbC1jYWxsLW5leHQtbWV0aG9kKSkpCisgICAgKHdoZW4gKGNsLWZpbmQgImNsYW5nZCIgKHBy b2Nlc3MtY29tbWFuZCAoanNvbnJwYy0tcHJvY2VzcyBzZXJ2ZXIpKQorICAgICAgICAgICAgICAg ICAgIDp0ZXN0ICMnc3RyaW5nLW1hdGNoKQorICAgICAgKHNldGYgKGNsLWdldGYgKGNsLWdldGYg YmFzZSA6dGV4dERvY3VtZW50KQorICAgICAgICAgICAgICAgICAgICAgOmluYWN0aXZlUmVnaW9u c0NhcGFiaWxpdGllcykKKyAgICAgICAgICAgICcoOmluYWN0aXZlUmVnaW9ucyB0KSkpCisgICAg YmFzZSkpCisKKyhkZWZ2YXItbG9jYWwgZWdsb3QtY2xhbmdkLWluYWN0aXZlLXJlZ2lvbi1vdmVy bGF5cyAnKCkpCisKKyhjbC1kZWZtZXRob2QgZWdsb3QtaGFuZGxlLW5vdGlmaWNhdGlvbgorICAo X3NlcnZlciAoX21ldGhvZCAoZXFsIHRleHREb2N1bWVudC9pbmFjdGl2ZVJlZ2lvbnMpKQorICAg ICAgICAgICAma2V5IHJlZ2lvbnMgdGV4dERvY3VtZW50ICZhbGxvdy1vdGhlci1rZXlzKQorICAo aWYtbGV0KiAoKHBhdGggKGV4cGFuZC1maWxlLW5hbWUgKGVnbG90LS11cmktdG8tcGF0aAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjbC1nZXRmIHRleHREb2N1bWVudCA6 dXJpKSkpKQorICAgICAgICAgICAgKGJ1ZmZlciAoZmluZC1idWZmZXItdmlzaXRpbmcgcGF0aCkp KQorICAgICAgKHdpdGgtY3VycmVudC1idWZmZXIgYnVmZmVyCisgICAgICAgIChtYXBjICMnZGVs ZXRlLW92ZXJsYXkgZWdsb3QtY2xhbmdkLWluYWN0aXZlLXJlZ2lvbi1vdmVybGF5cykKKyAgICAg ICAgKGNsLWxvb3AKKyAgICAgICAgIGZvciByIGFjcm9zcyByZWdpb25zCisgICAgICAgICBmb3Ig KGJlZyAuIGVuZCkgPSAoZWdsb3QtLXJhbmdlLXJlZ2lvbiByKQorICAgICAgICAgZm9yIG92ID0g KG1ha2Utb3ZlcmxheSBiZWcgZW5kKQorICAgICAgICAgZG8KKyAgICAgICAgIChvdmVybGF5LXB1 dCBvdiAnZmFjZSAnc2hhZG93KQorICAgICAgICAgKHB1c2ggb3YgZWdsb3QtY2xhbmdkLWluYWN0 aXZlLXJlZ2lvbi1vdmVybGF5cykpKSkpCisKKyhwcm92aWRlICdlZ2xvdC1jbGFuZ2QtaW5hY3Rp dmUtcmVnaW9uKQorQGVuZCBsaXNwCisKIEBub2RlIFRyb3VibGVzaG9vdGluZyBFZ2xvdAogQGNo YXB0ZXIgVHJvdWJsZXNob290aW5nIEVnbG90CiBAY2luZGV4IHRyb3VibGVzaG9vdGluZyBFZ2xv dAotLSAKMi40MS4wCgo= --00000000000001484a06043b6135-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 16:53:26 2023 Received: (at control) by debbugs.gnu.org; 31 Aug 2023 20:53:26 +0000 Received: from localhost ([127.0.0.1]:59353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbofO-0003WK-5v for submit@debbugs.gnu.org; Thu, 31 Aug 2023 16:53:26 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:47226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbofM-0003W7-DI for control@debbugs.gnu.org; Thu, 31 Aug 2023 16:53:24 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-5007f3d3235so2443239e87.2 for ; Thu, 31 Aug 2023 13:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693515190; x=1694119990; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=lpn9mxSrH9MweR5l2FDfYWzvqzVkpLlJtny/uhGhZHg=; b=e0+o7UU/ByNjgZMHSFtIij3VbNBdF/UBLfQd6TMvDFr01S3UQrXhE/lBmuv+aGxTWw nqDOsz7F07E4DCn1oCg2lSgGAFqfy108ril5oIgGdJeGeo5zPghJSwvQ+mMqIlPkZXxG vXnQDmc4NmzWa3+vMJ+ixY8nkzWOi2kq8sDbQcUZMHZuiRGk93tJZD/62g9WvZwokPKO lV7BbyERDa1mE5HMRt8ntMl2SWfmnWRd4WtNoeNVjJo0D2lSmdBIB9/w4fx926DW2mqj o6TyoPGxDf3WZSuEp0O2ovyHJZzwvS+/1y4SvqiuO3eiJEfXlBjqOjKqXALGR8Qo9U8+ e2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693515190; x=1694119990; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lpn9mxSrH9MweR5l2FDfYWzvqzVkpLlJtny/uhGhZHg=; b=iLlys1Upq5CHEZ2cGdMCHovsBpFxyIk5xbfnAMR9qLs4gpM6PRNnhu3hPyUI5Ok6DA RnOIc0R1dtJtqPF33EuSEfavnR/kGsNhpys2ktgcLUn71cLgkHjhxtLJGdDhhQy52fg7 P2lG7hliVH6MuvXGDaX+DNhywtf2uW0lnXTe2ulUoWTG7j5QIOF/8lTxlC2pSqrNbtKZ xBgJHtqxB7/IwS7xJt9kxnK+hVCl+1mI6c/ykhebcWkGFu5sqFvT8ESBb8fomtMDdj5G 5eGlJv/l/chpoB0gZmKVRKFceZLv81NQrm8WUgEqmH9/PrWFpLyPgmevsrDdns1lTF5D gzhg== X-Gm-Message-State: AOJu0Yzon41Xb3ZzQvs1qrPfSMT1adbbuCMRJynUu06Bc/FHBkwwEuXm uj95YQg8zPliOneJ7WuS8E6HsTVoBF+lTkh66n+qx8kGCKw= X-Google-Smtp-Source: AGHT+IF1xL4Sq/bgnx/UUxMurEYXLnjclSFZD9qKAqMlrmAJJUBg4tG0jILWxb87h4gVZZAOi5h6pQx8ZQ42079jhJg= X-Received: by 2002:a05:6512:a88:b0:500:b53f:fbc2 with SMTP id m8-20020a0565120a8800b00500b53ffbc2mr309091lfu.26.1693515189607; Thu, 31 Aug 2023 13:53:09 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Thu, 31 Aug 2023 22:52:58 +0200 Message-ID: Subject: To: control Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 65418 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:12c listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 65418 + patch thanks From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169364249718595 (code B ref 65418); Sat, 02 Sep 2023 08:15:02 +0000 Received: (at 65418) by debbugs.gnu.org; 2 Sep 2023 08:14:57 +0000 Received: from localhost ([127.0.0.1]:35084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLmT-0004pr-2U for submit@debbugs.gnu.org; Sat, 02 Sep 2023 04:14:57 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:44178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLmQ-0004pe-NJ for 65418@debbugs.gnu.org; Sat, 02 Sep 2023 04:14:55 -0400 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-565e395e7a6so1619187a12.0 for <65418@debbugs.gnu.org>; Sat, 02 Sep 2023 01:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693642479; x=1694247279; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xIKnfDW8H+CXeBvozSyIHdKxY70gf3HxMp12XV7piw8=; b=cPZciI4ojXKOBNETuRtrYvlgVUDGQvj5J887rQXBDY2QmRxde+AwCVNV2wFv7fHj6c 7z1GLvc+WUnB8hsMvpusoy7q1Udr6pIVhVZF8kC1kPfp8nga/FP0No+HbM21hxLj84u1 O7hwn9qRIZyUi1oiEl5W7vYw4zolkKq+5W5EGqipPYhySgW5lHhCmOWp455x211dI3Az 2a/62AHbSup4NskDeTSW/onYfMjoeKEuaS21dJYW/1zXNKPm57RjWb3XVfnCxKEWiH/D yuhQMQ0v82WL9Z8uWDkN5q4wO2dEmZ8vvulwMAa7ghsi1SppBziWHNErpqJcbJDVyI16 kLcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693642479; x=1694247279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xIKnfDW8H+CXeBvozSyIHdKxY70gf3HxMp12XV7piw8=; b=a8hcgEYY4kc7xZSgopSzBZRXJvdx9vO6cJ+XNrXRKrBNC1asDac4CoZdugFtpvClAe Ho3i6h7OIteIrkHH2BJVlbnyNFSdhC0XRc8YvCVfATcizawE7gdoOC7QLqUDon8qmZa7 EnYtKkcpexqJJWAvqp7CmQfH1RwNfISDhIXrt7fjtDCGi+94TNA5uiBD8Z72vmM7QjtJ 7+mQ9hlhZ//eZkCAKlyy8r9kQ3j/youtHguV4iqpfV378OfW8PUim+YA2so2L4A8H2rm VjNeiZEy2Qmt3WcL2kwiSJalBn1U9GKab+QBtwnZ0RHkxT+wLQWx7MxvfnQEEGeK7FuX cHrA== X-Gm-Message-State: AOJu0YzLm6NiTyuEfarP9sbxJEHHKeItcvvKgUrF4cIod8HsVTSA4Wk3 1LQJWMmg402ILMGhiRplabspsMQINjTl95DtDq8= X-Google-Smtp-Source: AGHT+IEZ1BCi8uQnJXV/tcwP8udbU+aHtnvR+M3sGKfxMnSQd1iGOdKplFFYlvuJO/DIlltV2RSfSDrQLa/XEfeiQ6Y= X-Received: by 2002:a05:6a20:a10c:b0:137:23f1:4281 with SMTP id q12-20020a056a20a10c00b0013723f14281mr4636695pzk.12.1693642478787; Sat, 02 Sep 2023 01:14:38 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> In-Reply-To: <873504d1oe.fsf@gmail.com> From: Filippo Argiolas Date: Sat, 2 Sep 2023 10:14:26 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > One thing about UI, all the themes I tried seem to render shadow as > > grey-ish but it was my impression reading the docs that it would be a > > dim version of the current face, so it would still have syntax > > highlighting. Is it just a theme limitation (probably because shadow > > wasn't used for something like this before) or it's not technically > > possible? > > I'm fairly sure it's technically possible, even if perhaps not easy. > You can investigate or ask this on emacs-devel. Hi again, I ended up investigating this on my own and managed to get something workin= g. https://github.com/fargiolas/eglot-clangd-inactive-regions/blob/master/eglo= t-clangd-inactive-regions.el Still experimenting on it, the idea is to iterate over each inactive region, detect face changes and create an overlay with a darkened version of them, blending foreground and background colors. No idea if that's the best approach but it works so far and I'm loving the result! Comments/criticisms/patches/PRs welcome (maybe outside of this bug report). Despite being an emacs user for maybe 15+ years, that's the first time I ever wrote more than two lines of elisp. Thanks, Filippo From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 12:30:53 2023 Received: (at control) by debbugs.gnu.org; 2 Sep 2023 16:30:53 +0000 Received: from localhost ([127.0.0.1]:38369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTWO-0000ys-O8 for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:30:53 -0400 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:60820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTWK-0000f9-OJ for control@debbugs.gnu.org; Sat, 02 Sep 2023 12:30:51 -0400 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50087d47d4dso202043e87.1 for ; Sat, 02 Sep 2023 09:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693672233; x=1694277033; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=zSwxA7Sl8x4d+t93lCAzHOCdOK/ieflHDIo2qh8c0BI=; b=GQvSPDZzQUpxg5cc0ssYB7kgMwE1rXOqIignQrhM+AgaxCH+msO1u0HC6BYpmOh1oh 1yrm1NOPIUABxwohmRo3+IHVdlKQ8rzA4Uc9J4TlpjeHGczr2lodJgbJB3I0tRDA+qH/ 9iOtDWTEjbt13l5dARBMUwiSmaTh8b9BfZtijS/aDzJXMUxY4jktDEvd4ytJlut0Hq9B cSxboSJg1LlH8fmVS6rGBZ9zd0IrHHxyR2ddsmLUF5j3b/wMzaSCP+cjn3ntWIk7HEeX SbtXetPfXm9+DA+/jYGC9bzNTwe7eJYtjNiIP9BjwOQlX6ammY3Wp5/CZhldnI9fMPmd OAbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693672233; x=1694277033; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zSwxA7Sl8x4d+t93lCAzHOCdOK/ieflHDIo2qh8c0BI=; b=HHzc9yxXuNVofoEdmcw2d03/uFDJrJNVyFDnTTvKQYv+WFEQw36ijgRXnmh6BGjDoU sqyND2NI0nX9MxwOnIOTs5Axdig7oI+wDBjRqP/Ae5VD0EcLc30S3tRlIwJtq2Dq3ugL LzAlXpwDKZbkGCXArW0dPMHn1VM6Nja+WEBukcajvQqkBbBHhqwerMJql1mXv7CDWOxl F1aIXGxZGxKdBVXGMYJqFZ0MdEy7BzpqhKHaOzIiHW8gdAawKr/lP+Kxmvxycc/PMSGj 5hkTTWOiMSn5ykY+iA8IsyuQZig7d42SqdWIAqtERpx50XBkMaWWQauIOyVM59I/MxAI tOzA== X-Gm-Message-State: AOJu0Yzs8PAQh7GQ5GiHIIVputkCsrmz2xwixA5dBc5Zi5NOdeuPkTQi Lt4f5+/AMq0oeS63OSnT7UGPSq6URhHA/UXBrCzEaLDUlRQ= X-Google-Smtp-Source: AGHT+IGLxqXcPwEZ6cZtDKxHQw/rCMnU+KxGKCeWSmQM8dISSikXZQd1ba9AE/lj/bT+DvIzcOuFBgb9SDWLE2l5qvQ= X-Received: by 2002:a05:6512:15a0:b0:4ff:8729:555 with SMTP id bp32-20020a05651215a000b004ff87290555mr4705491lfb.11.1693672232801; Sat, 02 Sep 2023 09:30:32 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 2 Sep 2023 09:30:32 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sat, 2 Sep 2023 09:30:32 -0700 Message-ID: Subject: control message for bug #65418 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 65418 wishlist quit From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 01:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Filippo Argiolas Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.16937893781122 (code B ref 65418); Mon, 04 Sep 2023 01:03:02 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 01:02:58 +0000 Received: from localhost ([127.0.0.1]:47859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcxzW-0000I2-7a for submit@debbugs.gnu.org; Sun, 03 Sep 2023 21:02:58 -0400 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:57782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcxzU-0000Hp-Gf for 65418@debbugs.gnu.org; Sun, 03 Sep 2023 21:02:57 -0400 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2bd0d135ca3so14405641fa.3 for <65418@debbugs.gnu.org>; Sun, 03 Sep 2023 18:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693789371; x=1694394171; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/PUVlRMWTVPGG0Y1gITXRj2lhx0IvhPaWUmr/389SSw=; b=HrDqZzVINGFI+CMn/KUnt380mHv3Ie7c9fHedsgA1UTywaLt6jy10jK/McJFIv1uBB m1hurt3collkKbHpf79lbRRmRj5DHaVjifObQKAWE6jONdq0x/8Glz2pr17Mo8G7RT/j CkyfDledUcdwbK/Xuh2PgOMVlXIv/DrVHJE7oJJg1el0m7nST1YX3u5SVU252H0PF80X 31cISaF3vUMUsVp6vY4yrYyOqpAqQrspEtCJrrfL9CcM/EmxDlYJ/2gW9yFPjahCMGO+ vhFNJfIUNEkR1lmLZimCdxy/KHPnwamRjiSqc0pMZylv+36Vo/5g+y538f/Ut3olkKeO Wmrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693789371; x=1694394171; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/PUVlRMWTVPGG0Y1gITXRj2lhx0IvhPaWUmr/389SSw=; b=J57WaV5mZfwwgmcDO6Pxr+iwjZo0Cil5LIFr9HHW4e9/VJMKE6qxj5lfPmPFnUIOgh hYo0KEFnWc3MXbwGmxBdt124Hv2Ohhh6XDe4q3fAScRnvNS8gVcwEheQhwQL3BTdut5l Q6v0N9z9e8KcYs2dtyDOQ1Wd5HwcuLyRQ6oc7MfgXNjnWcUdiCQPc3WWAorNxhfwQjmJ zjdEra0dt/5skZZ4zI+8EM7h9mrNBCbUi6bla+bh+g8WGWB69tRm7WmfbQSdnSD2DSO4 ee22XHQDcC/ugA0MfYU8vq3urIrYsA5orrYKJR/69jFvemRaTGlj0zZ2ZXw9esXExzmQ PWeQ== X-Gm-Message-State: AOJu0YzZf3NEC8P3Ty7MsTSy54eF1BMVnucsJ1I4LkGiq1+uwdimZBwg 2EUvVEqwR5LGgfNQ6cTCsbBgAF6Nga8LkrcE4DY= X-Google-Smtp-Source: AGHT+IGOpzRmxa7eJy2bf4aOy5qeDYZj0Vjug68fFxV93fxHB1UTcqy0+H7QqWQYpNPXjnfOlisE2KkNJEqiEVta/OY= X-Received: by 2002:a2e:9bc7:0:b0:2bc:e51d:d09c with SMTP id w7-20020a2e9bc7000000b002bce51dd09cmr5260266ljj.36.1693789370588; Sun, 03 Sep 2023 18:02:50 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 4 Sep 2023 02:05:23 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Aug 31, 2023 at 6:28=E2=80=AFPM Filippo Argiolas wrote: > > On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > Glad to help. You're lucky I'm not some kind of wine connoisseur ;-) > > Make a patch for that (and remember to also include the exportation of > > the '--' symbols). > > > > Many thanks again! That code definitely made this work week more enjoyabl= e ;-) > > Sorry for the delay with the patch, little time left these days for > side projects or even trivial contributions like this. > See if the attached patches could do! They were very helpful. I just pushed heavily edited versions of them to master. I used them as a starting point and credited you as co-author (I could have done the other way round, crediting myself as co-author, but the changes I did were a bit too extensive for that). Jo=C3=A3o From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 01:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Filippo Argiolas , Eli Zaretskii Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.16937895821555 (code B ref 65418); Mon, 04 Sep 2023 01:07:01 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 01:06:22 +0000 Received: from localhost ([127.0.0.1]:47865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcy2n-0000P0-Q0 for submit@debbugs.gnu.org; Sun, 03 Sep 2023 21:06:22 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:46268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcy2m-0000On-CM for 65418@debbugs.gnu.org; Sun, 03 Sep 2023 21:06:21 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2bd3f629c76so14771281fa.0 for <65418@debbugs.gnu.org>; Sun, 03 Sep 2023 18:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693789575; x=1694394375; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VVW+OVsdnHTdva36L+cNBij6SwC696IFYQsFj9E16ec=; b=Pvsm9bm2v1PgXNVWwXIppPK0M6deT1FbF+R5h6G8Hi41U9PI4egIfTt2y4bpaaIYCD AjYPPVpN2/Vd9LbRgsrOkXdOSe5WF1j1bvhoj3nlemTG20pm9E1R9aa7OokNMT5KTlUo 87Fxw2HRw3fq0UlNLoBKQVb5KWz0Q9rmbYX5q78EAFFO89WJmVXQvN4KAymi0qD6mtKc JYUPwlsJv+FFKPPmBFcLXcGRd3J5CanKdwQrHR6dOG8Mcoy0VM9dZOyWuCfiBC2I11EQ T/jCJJmf/bxcF/bxoL8h3Uwf9t55qiG9wp8r7Xn2NJUfGToOFirIjzhHekX/3pQU5G+f CVig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693789575; x=1694394375; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VVW+OVsdnHTdva36L+cNBij6SwC696IFYQsFj9E16ec=; b=eTcWqEf0/glk80lO3usJ5zovhFydCBO3JJK4K3gSmqprVEHgmcaL9NKZdbuXx7S39r RzKGXHBEQngYzWizcyOci6QZ4/00bIiX4ocFF8u1B8Kx8u596INbU66cu4IYgjRiEbc8 AjQXbnh/Ri7woA+NkWdff/kDL7pClMrBApdqgqKpYQSSbDXSQHPDDsR8aQFnbdwDYG82 dRqvowk2ra9yepobjKAHp9wA3/T5DbzB2JBOgVY1Jlik6FPQbRqCsdcPKzREs/wsw5LI ETtliGep8et2r0VpIorPRDQ6uzs91Jjew8Kp0gT4J9HszKMU7uSHSr8n732gCEEfef6V bgKg== X-Gm-Message-State: AOJu0YxX6GkFP3iRVTVyyNWD/NKwCvwDp0vDHpFt7PM3yPKg3PD0OQT7 /pGQkvRphxjQSpR6dEh+DIqwkLmCg4m7XRHupEw= X-Google-Smtp-Source: AGHT+IFbgI1KG+8mtrMe2Cs7S+KVnn9B2hHKtdPQ0KyWbeG0c8uEhVoMOxymTIQd/h5ijR3eF1f1YJmdtIhCj1lHIQA= X-Received: by 2002:a2e:87c9:0:b0:2bd:180d:67b7 with SMTP id v9-20020a2e87c9000000b002bd180d67b7mr5585205ljj.40.1693789574698; Sun, 03 Sep 2023 18:06:14 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 4 Sep 2023 02:08:47 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Sep 4, 2023 at 2:05=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > On Thu, Aug 31, 2023 at 6:28=E2=80=AFPM Filippo Argiolas > wrote: > > > > On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > > Glad to help. You're lucky I'm not some kind of wine connoisseur ;-) > > > Make a patch for that (and remember to also include the exportation o= f > > > the '--' symbols). > > > > > > > Many thanks again! That code definitely made this work week more enjoya= ble ;-) > > > > Sorry for the delay with the patch, little time left these days for > > side projects or even trivial contributions like this. > > See if the attached patches could do! > > They were very helpful. I just pushed heavily edited versions of > them to master. I used them as a starting point and credited you as > co-author (I could have done the other way round, crediting myself > as co-author, but the changes I did were a bit too extensive for > that). Drats, I just noticed a very significant detail. I should have checked first, but you don't seem to have a FSF Copyright Assignment for Emacs. So I think I'll have to revert these two commits until we get one from you. I'm assuming you don't have a problem with that, else, we'll have to find another solution. Eli, can we send Filippo a CA request form? Jo=C3=A3o From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 04:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 65418@debbugs.gnu.org, Eli Zaretskii , Felician Nemeth , Philip Kaludercic Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169380002120863 (code B ref 65418); Mon, 04 Sep 2023 04:01:01 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 04:00:21 +0000 Received: from localhost ([127.0.0.1]:47918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd0l8-0005QL-Cq for submit@debbugs.gnu.org; Mon, 04 Sep 2023 00:00:21 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:56636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd0l2-0005Os-9J for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 00:00:17 -0400 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-26fb8225268so375216a91.1 for <65418@debbugs.gnu.org>; Sun, 03 Sep 2023 21:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693800007; x=1694404807; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3DDbsyMkihtuy/yNx0veNGTnHcwe7oHu5VLAvjoWMaA=; b=TbzRFlF1a/sb6c+HUChWKVYbiwKoQ6+PTnLzYJ1zS27n+12LaO+YFLaTUkgvAxqWBq v8QGjEyGRMUaFcFGT3SGlGVYA41fQ16r3y6xCvjpRe64aOpokbruh/P6MKJ/V5iBpmiH SuzhJlUWD4akTrW1kNIRvN72vxuwrc/wsDP8JAQ9PsyzTWd8oK51yHqP9dwP0VCKfmIK AENlAt75gpE2imZj7mMDYpg0xyRNRGJjYA0jgVM34iDoJ2aYmpqyOS0Zr3a9J1WZzgKG 2ozC+gXqIRqZTmkYBeq5BRtMlKCRdpvc0GTqGggHCBu08WgbMVj+7cOleDwdewE5PvF8 OnwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693800007; x=1694404807; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3DDbsyMkihtuy/yNx0veNGTnHcwe7oHu5VLAvjoWMaA=; b=G4Q0tTVJn0ZUxfpCi5yAQvIRuFvfiFM4m2Ao60ukxRdjdSm+9bhR5i/ZC0UDuk0JQx r8EI6YReJWNfRqjVBMSAq7YrCTlviaNH6Kip4lTcDnlQFwzQNtj0kcqIOU2SuzYtCZv+ JAGsTxJp++o2FzrDO0dMQgq5WBClpozmdwMKRcoYj+aqH6Fkg6TU1SOsqGVeS4WZdiJn QoO8f8PuI75hj72/tKxEq5ZlpxdMb1k5btT2TVEKcIWgJB99aw5XE3TN6MyfzIiCLwSc 17+1V3GBTYhLp5bTKnJxT8i95OxLnwrRZ0ngkK0VXux08EYDDnGnLgNxlS/OgKKTFNQH LPOw== X-Gm-Message-State: AOJu0YxoNRBaT4rmyRYr2YjPeSorscXxPUcVQQesk8JbZYNGWQ6mhl8M msRldbdCAltDRWKr8dKiMVeGCLKfUXJrUJliPns= X-Google-Smtp-Source: AGHT+IG/P5oFjp9ulF+iaQeMrVMP0Zi/uWgkxcqTDNMPywjbn0blkopkwYQx7ECHcm4kQrcOVSarRD3ACc6FmdvFzxY= X-Received: by 2002:a17:90b:98:b0:268:36a2:bd0 with SMTP id bb24-20020a17090b009800b0026836a20bd0mr6155707pjb.8.1693800006543; Sun, 03 Sep 2023 21:00:06 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> In-Reply-To: From: Filippo Argiolas Date: Mon, 4 Sep 2023 05:59:54 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Sep 4, 2023 at 3:06=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > On Mon, Sep 4, 2023 at 2:05=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > > > On Thu, Aug 31, 2023 at 6:28=E2=80=AFPM Filippo Argiolas > > wrote: > > > > > > On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > > > Glad to help. You're lucky I'm not some kind of wine connoisseur ;= -) > > > > Make a patch for that (and remember to also include the exportation= of > > > > the '--' symbols). > > > > > > > > > > Many thanks again! That code definitely made this work week more enjo= yable ;-) > > > > > > Sorry for the delay with the patch, little time left these days for > > > side projects or even trivial contributions like this. > > > See if the attached patches could do! > > > > They were very helpful. I just pushed heavily edited versions of > > them to master. I used them as a starting point and credited you as > > co-author (I could have done the other way round, crediting myself > > as co-author, but the changes I did were a bit too extensive for > > that). No problem for me, edit as much as you want! just glad to help. I'd be just as happy if you just thanked me in the commit message. > Drats, I just noticed a very significant detail. I should have > checked first, but you don't seem to have a FSF Copyright Assignment > for Emacs. So I think I'll have to revert these two commits until we > get one from you. > > I'm assuming you don't have a problem with that, else, we'll have to > find another solution. Eli, can we send Filippo a CA request form? I believe this contribution is trivial enough to not deserve any legal paperwork. It's just code written by yourself with a very few lines of docs you used as a starting point to write your own. I think it can be safely committed without issues, thanking me in the commi= t. I don't think I have any problem with CA but I never saw the actual forms, a bit skeptical if I'll have to involve my employer. I'd say we consider this one as trivial enough and I could still sign them to have them ready if I ever contribute something more meaningful. Filippo From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 04:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 65418@debbugs.gnu.org, Eli Zaretskii , Felician Nemeth , Philip Kaludercic Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169380058922114 (code B ref 65418); Mon, 04 Sep 2023 04:10:02 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 04:09:49 +0000 Received: from localhost ([127.0.0.1]:47972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd0uK-0005kb-7X for submit@debbugs.gnu.org; Mon, 04 Sep 2023 00:09:48 -0400 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]:60580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd0uG-0005kG-BE for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 00:09:46 -0400 Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6bc9811558cso945054a34.0 for <65418@debbugs.gnu.org>; Sun, 03 Sep 2023 21:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693800579; x=1694405379; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Idk1X6EmtYfSWYSQHrbiscWUeDNqda7qMIJ74MPS5D4=; b=SiD6wnsAOGKSzHqTRYY1zm70c/usUBGMkc13apmG2rZ9i/GJslIDLYdHLaRPXIWExE 8yi6D2UkqhroNVai33tPovX7W5bX+S4y22q9WMdqVwKk0UK3yDhNrBBlhZ04Pi2OfbHV PUCZoEx2WZEjSK7CCG5q1FzVdZKVh/ipwcjOlok7QzxFVlb8IjdsYAuxCyX2cMNASl+H za9Zv8oMbpUMbNjtl4J6synRHq+1iidTNHc0PP7YFA3QyCW6aoJhmcOh3WSThADpBrhf 6Jyg71aCeam9B3vX1+DuRjJzuFQNRG023s5Jjcq5Z2wp0fxqTMWxag78rkEl151XXWct V3qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693800579; x=1694405379; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Idk1X6EmtYfSWYSQHrbiscWUeDNqda7qMIJ74MPS5D4=; b=VYNR7+I4GIpFl5a4aBEJlMEQTJ71UB8kld7UYIYKAG6MHq/syxj6ytL7yD+ji9Phn+ jZpzEaziiec3oitbo8ecNzfrI3o5wpHDG/EXCCsCpWjTYmdRemcyjLQAvf0EvTdYLgak KegJFM0MVBiFHuw+ehzTTwnmjiO0jndjTWr410eNg8Zf0AAfoSteIQGIIudOKTUlnzlD gmbTmtphzpKv8iUrqJ3fl/Y9HfQmHdhGNqy/tRrLCvScPXAfWWJ7M2Whc+/6uONMqLPG iA3twFb1k5srY9sBrPH2NCRUFxH8zrauIjIEZnEdGT3Pyjdyj2J2kTlrRSZKcKCG6BSL WM7w== X-Gm-Message-State: AOJu0Yx3KtRy7yJ5fW9sdP6IkVSHqR/RWUKePvgILx876/DwitPEF3tn vbg4TJRlTLb5qMbNFzlhCJdt39pPt43HMhSXJ+M= X-Google-Smtp-Source: AGHT+IHdYSt5ECCQVUwIri3oIX0lqIbJaMr0Z39JSdfqfkFBlqAtlQBlHm+PmFSLHuFrjKid2wVWF/zqjaZW3aIbUgA= X-Received: by 2002:a05:6830:148a:b0:6bc:f5fc:ebb9 with SMTP id s10-20020a056830148a00b006bcf5fcebb9mr10102286otq.27.1693800578991; Sun, 03 Sep 2023 21:09:38 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> In-Reply-To: From: Filippo Argiolas Date: Mon, 4 Sep 2023 06:09:26 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Sep 4, 2023 at 5:59=E2=80=AFAM Filippo Argiolas wrote: > > On Mon, Sep 4, 2023 at 3:06=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > > > On Mon, Sep 4, 2023 at 2:05=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > > > > > On Thu, Aug 31, 2023 at 6:28=E2=80=AFPM Filippo Argiolas > > > wrote: > > > > > > > > On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > > > > Glad to help. You're lucky I'm not some kind of wine connoisseur= ;-) > > > > > Make a patch for that (and remember to also include the exportati= on of > > > > > the '--' symbols). > > > > > > > > > > > > > Many thanks again! That code definitely made this work week more en= joyable ;-) > > > > > > > > Sorry for the delay with the patch, little time left these days for > > > > side projects or even trivial contributions like this. > > > > See if the attached patches could do! > > > > > > They were very helpful. I just pushed heavily edited versions of > > > them to master. I used them as a starting point and credited you as > > > co-author (I could have done the other way round, crediting myself > > > as co-author, but the changes I did were a bit too extensive for > > > that). > > No problem for me, edit as much as you want! just glad to help. > I'd be just as happy if you just thanked me in the commit message. By the way I looked at your doc version and very much approve it. The one about public API I think I don't even deserve co-authorship :-D Filippo From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 10:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Filippo Argiolas Cc: 65418@debbugs.gnu.org, Eli Zaretskii , Felician Nemeth , Philip Kaludercic Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169382471524234 (code B ref 65418); Mon, 04 Sep 2023 10:52:02 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 10:51:55 +0000 Received: from localhost ([127.0.0.1]:48872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7BS-0006Io-HD for submit@debbugs.gnu.org; Mon, 04 Sep 2023 06:51:54 -0400 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:57798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7BP-0006IZ-KX for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 06:51:52 -0400 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2bd0d135ca3so21065571fa.3 for <65418@debbugs.gnu.org>; Mon, 04 Sep 2023 03:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693824705; x=1694429505; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wqfdHOydkyfDzFrTknfEut4G+VC1mRX/D2tOrGYyx6k=; b=GhlRWx0AfUyZaJBvJsW/znw09EIQ7wOKBqhjTpB5dJbpVAgqy+dWV7DtmTzixrKdw/ QAEuTIFI8MxwcmGcxleDJWdiQAYVui7nE/hhSq/njyGo57PBuuVDlw1NzSMWylDupHGB 1jvRl1hnBy0RHS4AYF7TA6txNsHJ49AhfB/HOhF70u1GEOKHuBGOerrJ5mHKotSP3xov V5gDCKrI9TxkydXYu6jkSUJ4Jfb9SlcB9bxJ+cck7QTv+XMA1MVj4MnGB7a8bVORWNbU 2lfpT2yX13k5mzZmdxuuoptq8OsW2S2YKHyx4J+2AEOOxlvTiGAWbBaYoz9L2BEBmcrU /I5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693824705; x=1694429505; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wqfdHOydkyfDzFrTknfEut4G+VC1mRX/D2tOrGYyx6k=; b=C+2mw4o979w1BedRc+b2wdPBbOwp8UDKdm/mHTOopayTzXKid9GDZK7ODnDzgrxBI6 2XKX2DrBd+9SYEZhm48Mg7RVRLeHlIEFaCtMYGR6VkRilntcKptZXssknMzn7jQqzFrD AtiSJHQc6u9tE7U3zBEq/Zx4q/7js12LxTpjORGDpzN0FYhSHg8ZNgl+qIStt1vos7jb 2CbOE5u7SOCeGXRFRUGL9hvGgw/eBBG/UQmwVtUK0Zn/8ei3OMFljsot5VO7wyfSMmTV vrGZj59OO43P5PrKU9UFRMFT+mUiKWaaNJhw0gLceXB7bX8BC0D5Yq+RMwJtBGIQfdFK duRQ== X-Gm-Message-State: AOJu0YyiJ+80p4aODYonOiEFFAGmcZYYnHMvYkHx0rEi9thBcelX2/3v iLrEkMaycUJjCke5IKcF6Was9b71qOjqwyejpWw= X-Google-Smtp-Source: AGHT+IFTaYreyxBEjNtfgNIGHzX1My5wR9eQNqCJZakxEocaso+AhD9tcFKbBMu4fXutQGg6CtqzisHjGqwvB59DsTA= X-Received: by 2002:a2e:8805:0:b0:2b6:ea3b:f082 with SMTP id x5-20020a2e8805000000b002b6ea3bf082mr6357883ljh.38.1693824705049; Mon, 04 Sep 2023 03:51:45 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 4 Sep 2023 11:51:33 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Sep 4, 2023 at 5:09=E2=80=AFAM Filippo Argiolas wrote: > > On Mon, Sep 4, 2023 at 5:59=E2=80=AFAM Filippo Argiolas > wrote: > > > > On Mon, Sep 4, 2023 at 3:06=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > > > > > On Mon, Sep 4, 2023 at 2:05=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > > > > > > > On Thu, Aug 31, 2023 at 6:28=E2=80=AFPM Filippo Argiolas > > > > wrote: > > > > > > > > > > On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > > > > > Glad to help. You're lucky I'm not some kind of wine connoisse= ur ;-) > > > > > > Make a patch for that (and remember to also include the exporta= tion of > > > > > > the '--' symbols). > > > > > > > > > > > > > > > > Many thanks again! That code definitely made this work week more = enjoyable ;-) > > > > > > > > > > Sorry for the delay with the patch, little time left these days f= or > > > > > side projects or even trivial contributions like this. > > > > > See if the attached patches could do! > > > > > > > > They were very helpful. I just pushed heavily edited versions of > > > > them to master. I used them as a starting point and credited you a= s > > > > co-author (I could have done the other way round, crediting myself > > > > as co-author, but the changes I did were a bit too extensive for > > > > that). > > > > No problem for me, edit as much as you want! just glad to help. > > I'd be just as happy if you just thanked me in the commit message. > > By the way I looked at your doc version and very much approve it. The > one about public API I think I don't even deserve co-authorship :-D It's mainly because i started by applying your patch then doing multiple changes to them. My intuition also tells me that the remnants of both your contribution are indeed "trivial" (as measured both in absolute LOC and complexity) But I admit I'm not fully aware of how these things are counted "officially", so better safe than sorry and I reverted them. But I would very much like to re-revert of course, as this was a lot of work and is a pretty valuable change, IMO. Let's wait for Eli to explain how to proceed. Jo=C3=A3o From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: felician.nemeth@gmail.com, philipk@posteo.net, filippo.argiolas@gmail.com, 65418@debbugs.gnu.org Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.16938276956794 (code B ref 65418); Mon, 04 Sep 2023 11:42:02 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 11:41:35 +0000 Received: from localhost ([127.0.0.1]:48957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7xX-0001lW-Hg for submit@debbugs.gnu.org; Mon, 04 Sep 2023 07:41:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7xU-0001lI-P4 for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 07:41:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd7xO-0005jv-8Q; Mon, 04 Sep 2023 07:41:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=yitpdNPpX6nghmD0qUo0r+k4zOCMjNwPTw1BF1iDNv4=; b=qjVgIs0/XGI0vFPsaupH 5mhxWo8Lki0nqFd5QtEZ4/sQTHtkiF+VbF5pLiYiZQQyrEAPeAG/8858dNKpLmn4+EPW0GjaxBH1s ZrA9qjt1SftEYDPvpxLISkg+w3cjOO+PMd2hKY0X+MpAkkNVwDKk7yRQARzjCD+9p+v6pNV0lheXk p/ReQgU1gh2zDWU5wyHdFqwG5NfB4KwIeFVC/98qQN18+O5M+nNhp+525AhO5D7otA0zIuFmFitHv G6h5WWLZfrykd9A/quDG7FvlL6W8s1mr3EGfcVnJChaAaxtyeR5M34pEoYgiAL6kTCcE5mDslp8ci eEEe8wIdOXai6A==; Date: Mon, 04 Sep 2023 14:41:08 +0300 Message-Id: <83jzt65for.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Mon, 4 Sep 2023 02:08:47 +0100) References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Mon, 4 Sep 2023 02:08:47 +0100 > Cc: Felician Nemeth , 65418@debbugs.gnu.org, > Philip Kaludercic > > I'm assuming you don't have a problem with that, else, we'll have to > find another solution. Eli, can we send Filippo a CA request form? Done off-list. From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: felician.nemeth@gmail.com, philipk@posteo.net, filippo.argiolas@gmail.com, 65418@debbugs.gnu.org Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169383150513198 (code B ref 65418); Mon, 04 Sep 2023 12:46:02 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 12:45:05 +0000 Received: from localhost ([127.0.0.1]:49033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd8wz-0003Qo-AC for submit@debbugs.gnu.org; Mon, 04 Sep 2023 08:45:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd8wt-0003Pt-MV for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 08:45:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd8wn-0004yQ-HR; Mon, 04 Sep 2023 08:44:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=erRtVjC6kQNNDLd5NYUGVc57DiKYHrQTO1KEr/tAqWM=; b=PosLZe2otLebhG5CK8ex jiWpAg/VZypk1/lhb5I83YweoJI89wlq6CWqe0KbAr2vLBSfaZlkfCgjNEDag6rRus/dEFEXAMpKu LiaMEu7mpPAQvlgum+6vKWg9PvKLs/bn1dr4xGpXj8tbIaXMaGy4rslJyfaAlovYnAJRvkDX3gndg h+95k6Lp+a2GdUOQJXQd6/b5uIjLRzkEEHtMhVvvK1BCmb8fwlcbwmnzWY8RhIyHq5ZLNZmvlqKic Xx5acu3WIz/fgh+/dWdxqsHA6m/mpZ4BxX76rUrzPmKAw/jb6EXJQu1sRS/dNtq41KbF99p+RPrYj oLlVF80i8Vco4A==; Date: Mon, 04 Sep 2023 15:44:34 +0300 Message-Id: <837cp65cr1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Mon, 4 Sep 2023 11:51:33 +0100) References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Mon, 4 Sep 2023 11:51:33 +0100 > Cc: Eli Zaretskii , Felician Nemeth , 65418@debbugs.gnu.org, > Philip Kaludercic > > On Mon, Sep 4, 2023 at 5:09 AM Filippo Argiolas > wrote: > > > > On Mon, Sep 4, 2023 at 5:59 AM Filippo Argiolas > > wrote: > > > > > > On Mon, Sep 4, 2023 at 3:06 AM João Távora wrote: > > > > > > > > On Mon, Sep 4, 2023 at 2:05 AM João Távora wrote: > > > > > > > > > > On Thu, Aug 31, 2023 at 6:28 PM Filippo Argiolas > > > > > wrote: > > > > > > > > > > > > On Sun, Aug 27, 2023 at 3:58 PM João Távora wrote: > > > > > > > Glad to help. You're lucky I'm not some kind of wine connoisseur ;-) > > > > > > > Make a patch for that (and remember to also include the exportation of > > > > > > > the '--' symbols). > > > > > > > > > > > > > > > > > > > Many thanks again! That code definitely made this work week more enjoyable ;-) > > > > > > > > > > > > Sorry for the delay with the patch, little time left these days for > > > > > > side projects or even trivial contributions like this. > > > > > > See if the attached patches could do! > > > > > > > > > > They were very helpful. I just pushed heavily edited versions of > > > > > them to master. I used them as a starting point and credited you as > > > > > co-author (I could have done the other way round, crediting myself > > > > > as co-author, but the changes I did were a bit too extensive for > > > > > that). > > > > > > No problem for me, edit as much as you want! just glad to help. > > > I'd be just as happy if you just thanked me in the commit message. > > > > By the way I looked at your doc version and very much approve it. The > > one about public API I think I don't even deserve co-authorship :-D > > It's mainly because i started by applying your patch then doing multiple > changes to them. > > My intuition also tells me that the remnants of both your > contribution are indeed "trivial" (as measured both in absolute LOC > and complexity) > > But I admit I'm not fully aware of how these things are counted > "officially", so better safe than sorry and I reverted them. But > I would very much like to re-revert of course, as this was a lot > of work and is a pretty valuable change, IMO. Let's wait for Eli to > explain how to proceed. To provide a helpful answer I need to know how much code was provided by Filippo. Where can I see that? From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 12:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: felician.nemeth@gmail.com, philipk@posteo.net, filippo.argiolas@gmail.com, 65418@debbugs.gnu.org Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169383164813438 (code B ref 65418); Mon, 04 Sep 2023 12:48:01 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 12:47:28 +0000 Received: from localhost ([127.0.0.1]:49043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd8zH-0003Ug-Hn for submit@debbugs.gnu.org; Mon, 04 Sep 2023 08:47:27 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:49639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd8zE-0003UK-IC for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 08:47:25 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2b9d07a8d84so19853281fa.3 for <65418@debbugs.gnu.org>; Mon, 04 Sep 2023 05:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693831639; x=1694436439; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ecrEOxtQ0BBJhBBxhjPDw4wrcxXk9AanjwA8ByX/B1g=; b=pPfs6ybw+uirbrAZ8lfMtqNz0Hy7Xhl/68wyw+iSa6cdYfRNAyf1U12JaIVY3WdKRD eKmfjCqrdX3iJTUbccPsUe/brrCUiCqmCXJnwPDcUX5uMYM69EGg9b0Jm9RLm/vZMpHD NniCmQ0xAX1Fu8/F6L5Hf5JPr5Za54gZD9UUrAc0TBVX6VXw71CrZ4L0r7bBTDYqxv9d 6lerksg5dv+STsSeOgX4DLkbBYdDgaYh/8KwUSrQZibVgt0DXe3zyNXeeg0pK7xQFids iCbJyDn5GLUtx0cDd1I1xtDIn6U1sN8gYgU9DlOxPovnUtO3qs1gzrZjTY3Xj2563rAB pUEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693831639; x=1694436439; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ecrEOxtQ0BBJhBBxhjPDw4wrcxXk9AanjwA8ByX/B1g=; b=JFmMRVayLWEbxE6rXrXpuXHD6Ty0MZ2TVyyLzfYoataF1YTIrkTgf2lRPCrwxFSJcc 7Ucky+zcL5rgIBYCHX+ebxdVFir6jguRxkoSPlqXvKGE6GU1w+FCIfGK06ECrJphqvd5 zgcM/uXJbpSS1gr72Ja8Qt+J1aU2wBouolV3xOluzIGHL+cyMxQmCIwGvBGCffSpwplF UIcxFpUGgeuDrt+5deRe85gRpSqn+LT9uTl/hQBAcDV5658oby5czuXkQRfmoi++KOc6 bxueJ1Hv1tM0YgwzdfqEgSv5jhoAKY647i2ToX61C84tCZ55t9PQ9T7lJXD3Se+lJHQN L0tw== X-Gm-Message-State: AOJu0Yy6Vfwvy8DPXm1ID2xFP0h/jXNhLSjHO+RZ7hea6NKaFsRmO7aV lhcZkRi4L+UWV1CHVw5f3hCuSGLJlOcEhssWw6Y= X-Google-Smtp-Source: AGHT+IHeCpNqyWUI8QxN1Kd2N19XjA5PcJJU9KFBNGTOgFITcjGgKXR2dv3ofisiIGu3pHFDp9fBFkFPCNQ9UYKX+Kw= X-Received: by 2002:a2e:804e:0:b0:2bd:169e:3819 with SMTP id p14-20020a2e804e000000b002bd169e3819mr6627400ljg.17.1693831638448; Mon, 04 Sep 2023 05:47:18 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> <837cp65cr1.fsf@gnu.org> In-Reply-To: <837cp65cr1.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 4 Sep 2023 13:49:51 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Sep 4, 2023 at 1:44=E2=80=AFPM Eli Zaretskii wrote: > > But I admit I'm not fully aware of how these things are counted > > "officially", so better safe than sorry and I reverted them. But > > I would very much like to re-revert of course, as this was a lot > > of work and is a pretty valuable change, IMO. Let's wait for Eli to > > explain how to proceed. > > To provide a helpful answer I need to know how much code was provided > by Filippo. Where can I see that? Some 4 or 5 messages ago in this thread. Here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65418#32 Two patches are there and they correspond more or less to the two (very heavily modified) commits I did on top of them. Jo=C3=A3o From unknown Sun Aug 17 01:48:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: felician.nemeth@gmail.com, philipk@posteo.net, filippo.argiolas@gmail.com, 65418@debbugs.gnu.org Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169384429627187 (code B ref 65418); Mon, 04 Sep 2023 16:19:02 +0000 Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 16:18:16 +0000 Received: from localhost ([127.0.0.1]:52412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdCHI-00074P-0J for submit@debbugs.gnu.org; Mon, 04 Sep 2023 12:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdCHF-00074C-Nx for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 12:18:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdCHA-0000Kc-9T; Mon, 04 Sep 2023 12:18:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MQN9I3JwyIUwRM0tgHoQJpRRCfp/U+3nw47kpWwTFJY=; b=lf0oKxMzLk1/d80UoWVz M61NXI+wsTU6JY6EYmpVszpUKktqUaPReIexeDfJnQstZlUHiTZwXXkYxzi8bPoD0ncIRU9Tu471Y /fmbNnnfcyS+i2yQ6LgEZMdow6YP6oQowWZst69hCC/DRMJNhnl00TkzGmeWpysdGZuGjkFrl87Y4 jG5ENj9m3mmgLfiUCcVHhruC69fAz4nOt4qpk8Yw4dSgUIitjR6adlEyTIWy5Tij3HjRAtCDIuZ1R v63QcZsuouG0T/AuQjuVJzZIzBV3NGAtPkMEemKgl+l9vOMOYxJgQV+JbBh9Uk0TyEeB1ojdeoDQK 2sLYXB/xqkawbA==; Date: Mon, 04 Sep 2023 19:17:47 +0300 Message-Id: <83y1hl52vo.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Mon, 4 Sep 2023 13:49:51 +0100) References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> <837cp65cr1.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Mon, 4 Sep 2023 13:49:51 +0100 > Cc: filippo.argiolas@gmail.com, felician.nemeth@gmail.com, > 65418@debbugs.gnu.org, philipk@posteo.net > > On Mon, Sep 4, 2023 at 1:44 PM Eli Zaretskii wrote: > > > > But I admit I'm not fully aware of how these things are counted > > > "officially", so better safe than sorry and I reverted them. But > > > I would very much like to re-revert of course, as this was a lot > > > of work and is a pretty valuable change, IMO. Let's wait for Eli to > > > explain how to proceed. > > > > To provide a helpful answer I need to know how much code was provided > > by Filippo. Where can I see that? > > Some 4 or 5 messages ago in this thread. Here: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65418#32 > > Two patches are there and they correspond more or less to the two > (very heavily modified) commits I did on top of them. The first of these 2 patches is trivial. The second one is not trivial, but it looks like you've rewritten the text almost from scratch, so I indeed think we don't need any legal paperwork from Filippo for these changes, and you can install those on master. (I would still encourage Filippo to start the paperwork rolling, so that we could accept his contributions in the future without limitations.) Thanks. From unknown Sun Aug 17 01:48:56 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Filippo Argiolas Subject: bug#65418: closed (Re: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension) Message-ID: References: X-Gnu-PR-Message: they-closed 65418 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 65418@debbugs.gnu.org Date: Mon, 04 Sep 2023 20:36:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1693859762-19265-1" This is a multi-part message in MIME format... ------------=_1693859762-19265-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #65418: 29.1; Eglot: support clangd inactiveRegions extension which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 65418@debbugs.gnu.org. --=20 65418: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65418 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1693859762-19265-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 65418-done) by debbugs.gnu.org; 4 Sep 2023 20:35:31 +0000 Received: from localhost ([127.0.0.1]:52735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdGIF-0004zj-5u for submit@debbugs.gnu.org; Mon, 04 Sep 2023 16:35:31 -0400 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:42103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdGIB-0004zS-87 for 65418-done@debbugs.gnu.org; Mon, 04 Sep 2023 16:35:29 -0400 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2bcc331f942so21806011fa.0 for <65418-done@debbugs.gnu.org>; Mon, 04 Sep 2023 13:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693859721; x=1694464521; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qkx3eTrpuWp/C9uxZSIW5tycuDJ7oBsu7T3PLNRa3Rk=; b=WoRhYoKwIownRDj74KIT41NEy32GoUMsrh5Pkr7CMEgJrussHhwx8JpmuFFCubbWgF x+4CH5ePlb+bAkVbsx00fFAP31fPhiyg0kVICc1+d3oNHnJ1H9hIyPThwJuIMDElJh/m f7dxCyMyheGQ1UZUZT3cqb6uEdb413AeBHpgVO0yteARdSUCNQ/9OMYG61oZ0HHSUN/Y IyrhHbMnTn8MGYGb7s15yGVZ/vRE7GoIutdH9vpWWmkVsdIN0i3xvEbz/BkBDWooQk5L B7JXeMBgXK/BKHjwgWd2YFiqP4LHYY6eNVmE+7TgZ9pgpiOb4Th3sq7x5/JpcdQ2GDYR 1msA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693859721; x=1694464521; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qkx3eTrpuWp/C9uxZSIW5tycuDJ7oBsu7T3PLNRa3Rk=; b=SJKe4cp5rFPuCykMVbw0Ka/jRbH9a1KX/7UcWVJ23UfA1IjindvufhEdUsqB9e7+IF b23+3aDPR1OiK1WiwzRGT3pgobscYvD7nPCj6gHAeGmUFXTdT9uvdftJ1AC1u6mWkl2i b8bhvSrdyUy16XeKr+C5N+OxAr9diSNRMlcgc5i1Gbwxd2eWTT6PyJkhxVNYjpFrZ2mJ 9odhdQxOVSzU1Q49a6S9Xc7xSODXvJEf6J8ojNE7IOtmIgKAchwpJ9XZODdqrTrAtPwf CBOQaFHC4+lUI63iFnjUhYWz3vemkml6pgVgkM+PdFSc1oVVJD9Nd966yWIBf8s+7LWh Orgw== X-Gm-Message-State: AOJu0YwoKWe1rRrF6QhE44m/ulOgnx7bDimHIwlqlHI3KJiAcVUS1mEZ pVPMCst/b4V4WGxwPCmgQSbQVZkUCvpTwonKpdw= X-Google-Smtp-Source: AGHT+IHMboSfiuq19VE6H4xYUkf04zlZTwHnX/3X0AbuoY5nmYh2BF05D+FpNwlMqk6+W+BDGonGz4KeQUInPF2FHzg= X-Received: by 2002:a2e:900e:0:b0:2b6:d0c1:7cd0 with SMTP id h14-20020a2e900e000000b002b6d0c17cd0mr3757133ljg.22.1693859721000; Mon, 04 Sep 2023 13:35:21 -0700 (PDT) MIME-Version: 1.0 References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> <837cp65cr1.fsf@gnu.org> <83y1hl52vo.fsf@gnu.org> In-Reply-To: <83y1hl52vo.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 4 Sep 2023 21:37:54 +0100 Message-ID: Subject: Re: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension To: Eli Zaretskii , 65418-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65418-done Cc: felician.nemeth@gmail.com, philipk@posteo.net, filippo.argiolas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Sep 4, 2023 at 5:18=E2=80=AFPM Eli Zaretskii wrote: > The first of these 2 patches is trivial. The second one is not > trivial, but it looks like you've rewritten the text almost from > scratch, so I indeed think we don't need any legal paperwork from > Filippo for these changes, and you can install those on master. (I > would still encourage Filippo to start the paperwork rolling, so that > we could accept his contributions in the future without limitations.) Thanks very much for checking. I just re-pushed the two commits. And with this, closing the bug. ------------=_1693859762-19265-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Aug 2023 08:57:08 +0000 Received: from localhost ([127.0.0.1]:55533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY0ih-0006Nf-KD for submit@debbugs.gnu.org; Mon, 21 Aug 2023 04:57:08 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY0UE-0005wL-P4 for submit@debbugs.gnu.org; Mon, 21 Aug 2023 04:42:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY0U6-0008Mt-S1 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 04:42:02 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qY0U4-00036J-HM for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 04:42:02 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-68a40d85593so423135b3a.2 for ; Mon, 21 Aug 2023 01:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692607318; x=1693212118; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=zHkxHgQx5H/vGOuKqu9m2UFSF3XXOxGbAgKNdyKc7gY=; b=YnTKe9vcWbyCkUDVfryVCr/gJp4RlV1xnNnCqx4PZPIkmG/bBB8DB2jL5AzFeGAdfr QGUQb/Hy72581I6DlCmo0uf2C5+HAf2Y1OivLLFop/eaGrtejBbgEUo+y/Tiq4HymzVq uKOurwD/O3DlpC66vdokipv91rb8Nomtbffr74OC2h16JdGg5S1t6eF2xmr23lLFqVXB BDXRRDv52hwIDmDXSc+6UHAog+XJ80VtKgonMQGAhf33m5mwc8SGxcV545k5zjZXm+Ii 3dAh8fQ12jPU8WUw5Kt2YaRFZkpT7UrqOBOZs9l6gM+qYedGVy/D4ZyLhZKop3Nbv2PT TvbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692607318; x=1693212118; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zHkxHgQx5H/vGOuKqu9m2UFSF3XXOxGbAgKNdyKc7gY=; b=Dk97FQTi/fPvMPCqWW5V38eI8yJQ2WtWzK5YgqCNG4RrKBAfEPpozUmi/xLfCjgkAH p3XDdQRgTSCC1Yatgai8fAlG2rnaw94jyRwGgat9CAnmiQ/5/9L4w4RBHHsf18hFZqh8 5Kv4xecpY4/D3IHj3NUNLN4Mx9bdN1GDUJB8+oSSfhdNOQDBbrayXq00v3jlwZJzTSXD FoQ6l6O4fWpwtdPX2ji6yYQOPIYAJowLk+8n4ePhjutVDUBQ3aqU7Xgqq4HShNQHoFEZ A6ybHWQQMpshTDNq6vCa9rvlg0cy33W9sUOi9lWaU9ySA2JBuG18i5nI2xX49Wan6Ec4 xHVw== X-Gm-Message-State: AOJu0Yyt329AnfoooJw1K4e+DFm/dT8lgOSlS1w8J1h378hUxx6dNUVy NDBnOSSGI2URcW4PM0COPz7J5x/qcTyCThx2WPzGySC5nhI= X-Google-Smtp-Source: AGHT+IENopFqH/pW6yM78RYXIJ2XEoNBrskZ+gHj/tHqrTQ5gOaauklRA6qTteOVdVBGRN3MH/5B1+5cwdFNmb/YIg8= X-Received: by 2002:a05:6a00:22d4:b0:687:60bf:aed9 with SMTP id f20-20020a056a0022d400b0068760bfaed9mr4860000pfj.24.1692607317841; Mon, 21 Aug 2023 01:41:57 -0700 (PDT) MIME-Version: 1.0 From: Filippo Argiolas Date: Mon, 21 Aug 2023 10:41:46 +0200 Message-ID: Subject: 29.1; Eglot: support clangd inactiveRegions extension To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=filippo.argiolas@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 21 Aug 2023 04:57:05 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, I've recently been working in some big C project with ton of ifdefs and inactive code regions. One of the few annoyances (maybe the last) remaining with emacs+eglot is the inability to show these regions as grayed out in a LSP aware way. This was maybe possibile until now with clangd with semantic tokens but they've recently introduced a new protocol extension that should solve this problem in a much easier to implement way. It's been introduced in clangd 17 with the review [1]. It should be pretty straightforward to implement as it's just a server notification that sends inactive regions ranges once enabled. In [2] you can find the pull request that added support for this in vscode clangd extension. I did some experiment on my own but I'm still not able to see the notifications. Probably I'm missing something within eglot code base, my impression was that enabling the inactiveRegions capability would get me some Unknown notification message but I wasn't able to see them. Anyways it would be great if eglot could support this. Not sure UI-wise what would be the best approach, vscode patch reduces the opacity of the inactive regions but rendering them as comment would also be nice at first. 1. https://reviews.llvm.org/D143974 2. https://github.com/clangd/vscode-clangd/pull/193/commits/ef75f637e7f79f94064369368ca665861836e482 ------------=_1693859762-19265-1--