GNU bug report logs - #65410
[PATCH] gnu: prboom-plus: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65410 in the body.
You can then email your comments to 65410 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: prboom-plus: Fix build.
Date: Sun, 20 Aug 2023 20:55:03 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

* gnu/packages/games.scm (prboom-plus)[arguments]<#:phases>:
Set CFLAGS to '-fcommon'.
---
 gnu/packages/games.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a5fa19fc20..4563089326 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2381,6 +2381,9 @@ (define-public prboom-plus
                                      (assoc-ref %outputs "out") "/bin"))
       #:phases
       (modify-phases %standard-phases
+        (add-before 'configure 'set-CFLAGS
+          (lambda _
+            (setenv "CFLAGS" "-fcommon")))
         (add-after 'set-paths 'set-sdl'paths
           (lambda* (#:key inputs #:allow-other-keys)
             (setenv "CPATH"

base-commit: 95a1a819dffa833bdd7a47f272da7ee4ff3260c8
-- 
2.41.0

Message #8 received at 65410 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: iyzsong <at> envs.net, 65410 <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: Re: [bug#65410] [PATCH] gnu: prboom-plus: Fix build.
Date: Sun, 20 Aug 2023 17:43:32 +0200

Am Sonntag, dem 20.08.2023 um 20:55 +0800 schrieb iyzsong <at> envs.net:
> From: 宋文武 <iyzsong <at> member.fsf.org>
> 
> * gnu/packages/games.scm (prboom-plus)[arguments]<#:phases>:
> Set CFLAGS to '-fcommon'.
> ---
>  gnu/packages/games.scm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index a5fa19fc20..4563089326 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -2381,6 +2381,9 @@ (define-public prboom-plus
>                                       (assoc-ref %outputs "out")
> "/bin"))
>        #:phases
>        (modify-phases %standard-phases
> +        (add-before 'configure 'set-CFLAGS
> +          (lambda _
> +            (setenv "CFLAGS" "-fcommon")))
Could this be added via #:configure-flags?

Message #11 received at 65410 <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> envs.net
To: 65410 <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH v2] gnu: prboom-plus: Fix build.
Date: Mon, 21 Aug 2023 18:31:12 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

* gnu/packages/games.scm (prboom-plus)[arguments]<#:configure-flags>:
Add "CFLAGS=-fcommon".
---
 gnu/packages/games.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a5fa19fc20..e1b6dbd43b 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2376,7 +2376,7 @@ (define-public prboom-plus
                 #t))))
    (build-system gnu-build-system)
    (arguments
-    '(#:configure-flags '("--disable-cpu-opt")
+    '(#:configure-flags '("--disable-cpu-opt" "CFLAGS=-fcommon")
       #:make-flags `(,(string-append "gamesdir="
                                      (assoc-ref %outputs "out") "/bin"))
       #:phases

base-commit: 3c6b6941a2c76c26ebf0c1bfd7f901a22c19dce1
-- 
2.41.0

Message #14 received at 65410 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 65410 <at> debbugs.gnu.org, 宋文武 <iyzsong <at> member.fsf.org>
Subject: Re: bug#65410: [PATCH] gnu: prboom-plus: Fix build.
Date: Mon, 21 Aug 2023 18:32:15 +0800

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Sonntag, dem 20.08.2023 um 20:55 +0800 schrieb iyzsong <at> envs.net:
>> +          (lambda _
>> +            (setenv "CFLAGS" "-fcommon")))
> Could this be added via #:configure-flags?

Yes, updated patch sent, thanks!

Message #19 received at 65410-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: 65410-done <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: bug#65410: [PATCH] gnu: prboom-plus: Fix build.
Date: Wed, 23 Aug 2023 18:59:59 +0800

Pushed now, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.