GNU bug report logs - #65401
30.0.50; custom-theme-directory :type could be enhanced

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: maurooaranda <at> gmail.com, 65401 <at> debbugs.gnu.org
Subject: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced
Date: Mon, 21 Aug 2023 14:05:07 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  65401 <at> debbugs.gnu.org
> Date: Mon, 21 Aug 2023 08:00:35 +0000
> 
> Mauro Aranda <maurooaranda <at> gmail.com> writes:
> 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> >>> Date: Sun, 20 Aug 2023 09:35:17 -0300
> >>> Cc: 65401 <at> debbugs.gnu.org
> >>> From: Mauro Aranda <maurooaranda <at> gmail.com>
> >>>
> >>> Eli Zaretskii <eliz <at> gnu.org> writes:
> >>>
> >>>  > If the directory doesn't have to exist, then what is the difference
> >>>  > between :directory and :string?
> >>>
> >>> Completion when editing via Customize is the only one it comes to my
> >>> mind right now (useful when the user wants to edit it to some directory
> >>> it already exists).
> >>
> >> Then I don't see why would anyone object to the change you propose.
> >> It has no downsides, AFAICT.
> >>
> >> Thanks.
> >
> > OK, thank you.  I attach the patch.
> >
> > From c34dea06956f2a3d098badf9cea089bee0f7b61b Mon Sep 17 00:00:00 2001
> > From: Mauro Aranda <maurooaranda <at> gmail.com>
> > Date: Sun, 20 Aug 2023 10:39:49 -0300
> > Subject: [PATCH] Improve type of custom-theme-directory (Bug#65401)
> >
> > * lisp/custom.el (custom-theme-directory): Make it of type directory.
> > ---
> >  lisp/custom.el | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lisp/custom.el b/lisp/custom.el
> > index 083349e3591..5b244464d0b 100644
> > --- a/lisp/custom.el
> > +++ b/lisp/custom.el
> > @@ -1208,9 +1208,9 @@ custom-theme-directory
> >  directory.  By default, Emacs searches for custom themes in this
> >  directory first---see `custom-theme-load-path'."
> >    :initialize #'custom-initialize-delay
> > -  :type 'string
> > +  :type 'directory
> >    :group 'customize
> > -  :version "22.1")
> > +  :version "30.1")
> 
> Does the version tag have to be bumped, for a metadata change this like?

Probably not.  AFAIK, this is only used for showing "new and changed"
options when users upgrade, and this change will be invisible at user
level.

Stefan, am I missing something?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.