From unknown Wed Jun 18 00:22:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65401 <65401@debbugs.gnu.org> To: bug#65401 <65401@debbugs.gnu.org> Subject: Status: 30.0.50; custom-theme-directory :type could be enhanced Reply-To: bug#65401 <65401@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:22:49 +0000 retitle 65401 30.0.50; custom-theme-directory :type could be enhanced reassign 65401 emacs submitter 65401 Mauro Aranda severity 65401 normal tag 65401 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 06:48:27 2023 Received: (at submit) by debbugs.gnu.org; 20 Aug 2023 10:48:27 +0000 Received: from localhost ([127.0.0.1]:53171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXfyt-00082z-FH for submit@debbugs.gnu.org; Sun, 20 Aug 2023 06:48:27 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXfyr-00082D-Je for submit@debbugs.gnu.org; Sun, 20 Aug 2023 06:48:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXfyj-00056a-5L for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 06:48:17 -0400 Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXfyg-0003Ok-LS for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 06:48:16 -0400 Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-56c711a889dso1624500eaf.0 for ; Sun, 20 Aug 2023 03:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692528492; x=1693133292; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=41cPdmNn7XvXvmxFk/2l9eHDUj/neYetRZNqxPpkVG4=; b=P3bleEidM2deiufUalZ3UrqBDWkOs4Iil9RlKxOnl/8IS1H+m0dO//EgIZHPc45RF+ zcxpn6y4Q8fOyT1eENNqPkxdHZzh8FPrAksls6mLbDP889RtMR/JQaTfCdMomCI6iWui m5rF/br/pcqNCNmuXtzyOMC/+MzghazB/LKmEVuyhY0gdViK+G/RVecnQi6AWiRcQptK ZV02dfXJe+zWneIEk03UJHDPkTDlsXPCJaH+WCIugQPQ1+rhLwQjUInfZLyvgbH+pmlp 14o/vUUlKV3TIwCqhBFbvIN61Qea1kp/IyZu3oQ19nWww7dsFFTtdk2g3oiiwH41zYeo AccA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692528492; x=1693133292; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=41cPdmNn7XvXvmxFk/2l9eHDUj/neYetRZNqxPpkVG4=; b=j8jj5M0wdMhzChzm1FGRMZ/YSyJTwuRQqBG2nFEUgS6cRS7c61LAkR0sxDrkbkdpaF qcm4AKpt5NxJGWhlwrGQ+1wvzw7qKwIDIz1pSOTQ7lzYoUkehqj8aBlawXwUP68CEnEZ gtaWVk9H4PC8ZITdhKTzoSyJKGBBgT+xDpcZP9lnfMQZoPvUXH3oJPFcRC/rL3CmWkfm cATSAFT9D8/r5ASfe2ik+u1TYcM9ptEub+rBh1MT/Lpu7kr4WWSlZngcE8H5x71GSmbS DjRJgPPErB4sOIqBBZiNHDvmPbd4U5q3RNiZ8qbl29qnGdgyTA8kJ7AfSkhOhCMXamIk KwpQ== X-Gm-Message-State: AOJu0Ywwj/Yew+ufE5wvDeFbT+eFrNOqyn6BIkvUgGuWfADyENvnih6F CvsZinbZKOidLrl9mfRvGukbiU3erGc= X-Google-Smtp-Source: AGHT+IGyZOYTT9oQck6LjjCjgZh2FHD6x9I+csbyo+blmmvL+BzwEeL2ncFrIzPA6PV69/QPiMlPYQ== X-Received: by 2002:a05:6870:15d5:b0:1c0:f8a7:ec14 with SMTP id k21-20020a05687015d500b001c0f8a7ec14mr5802716oad.57.1692528492143; Sun, 20 Aug 2023 03:48:12 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id v19-20020a4a9753000000b005660ff9e037sm2752469ooi.25.2023.08.20.03.48.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Aug 2023 03:48:11 -0700 (PDT) Message-ID: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> Date: Sun, 20 Aug 2023 07:48:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: 30.0.50; custom-theme-directory :type could be enhanced Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c32; envelope-from=maurooaranda@gmail.com; helo=mail-oo1-xc32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The user option custom-theme-directory is supposed to hold a directory name.  But its :type is a string. I realize that it isn't really a bug, but in order to offer better completion, at least, I'd like to change the type to be directory.  So I'm filing this bug report to see if people would object to such a change. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 07:12:51 2023 Received: (at 65401) by debbugs.gnu.org; 20 Aug 2023 11:12:51 +0000 Received: from localhost ([127.0.0.1]:53185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXgMV-0000Fz-2m for submit@debbugs.gnu.org; Sun, 20 Aug 2023 07:12:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXgMP-0000Fi-Vy for 65401@debbugs.gnu.org; Sun, 20 Aug 2023 07:12:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXgMI-0000pn-PV; Sun, 20 Aug 2023 07:12:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/uaATBgmr/W7lu4U4U/a0iPj7Oij172UjbPcbYsws5U=; b=EXxWoYxJKPddu90lPhkX LLj5HJMMdLKyrn0nXK4YFqd4BxCjtfGzKycOsQwg/u2cswKtQSM+CfZbsHUsJBO2Ig9zqH/iiMXiU sd2+qX4iXQt4uCMbiOl5kG6xb0AKrGvNHwhQ6k4lODC0997whdMlANU0Nm0bJXrfcotc3PWWh7Udd 7XXpsBCljv9V3NiMNwdbfKcNox2N1z5fehk0rlth6cuvolU1VC6cpPdFHoZdCpeUeeAWL71eMLJpY JI87tge7bIkKTTvEhe5DOt1x/IBfUwkTXE0Eimm/1PH30aVLs4jfZV5ELyqZjLZqmcTp5I5DkaSIb pM+2a6yjF37mSg==; Date: Sun, 20 Aug 2023 14:12:51 +0300 Message-Id: <83pm3ivufg.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> (message from Mauro Aranda on Sun, 20 Aug 2023 07:48:09 -0300) Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65401 Cc: 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 20 Aug 2023 07:48:09 -0300 > From: Mauro Aranda > > The user option custom-theme-directory is supposed to hold a directory > name.  But its :type is a string. > > I realize that it isn't really a bug, but in order to offer better > completion, at least, I'd like to change the type to be directory.  So > I'm filing this bug report to see if people would object to such a > change. Does the directory have to exist? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 07:28:59 2023 Received: (at 65401) by debbugs.gnu.org; 20 Aug 2023 11:28:59 +0000 Received: from localhost ([127.0.0.1]:53233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXgc7-0000g4-4C for submit@debbugs.gnu.org; Sun, 20 Aug 2023 07:28:59 -0400 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:52572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXgc6-0000fs-4J for 65401@debbugs.gnu.org; Sun, 20 Aug 2023 07:28:58 -0400 Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3a7e68f4214so1898406b6e.1 for <65401@debbugs.gnu.org>; Sun, 20 Aug 2023 04:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692530931; x=1693135731; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t4UR3oLMdPGtIhb7tW/exFHxuzzw1LplT9BGS0DKkiQ=; b=nx90RExYMgEmOlC8oqotkPNdiycLTDw126zoZ9duKG+eT9oHp/ZBi9peu+LueN6D4U 7bteLiJ/ENSjoc+4cNLhxN328w2uoxbWTwhSv4aHofDi79xkJtuf1o9AakDGQtvFd5m9 fkDAy8VSu/7Q61Vll3An1sqU/DsisEze2z36kMoGxN/JmXwVEZgJUZYu0BvLnN6naxur 14eCf1gaRDKfX+VlxzmhxnaXTeXrr0SsvFDAzet1C845DSmD4fBC2hnEqB/JF4DV/PqY Saz+Q6e89xLPPql3iHWSQJ2glQLxyWqboRYs4FEvKKec7XW+55g/B0o5nzqBxARYtr9y uHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692530931; x=1693135731; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t4UR3oLMdPGtIhb7tW/exFHxuzzw1LplT9BGS0DKkiQ=; b=aayGIkCvBhX4pOuSdKKlSJWxYWpSCljU/cLKONngQds5OGJ8a8OvIsglIYgOQfBaBy ubyx1JPXuOOvXKggul9aEVycVL0DHo7dSz12iVqnRM/b70rjP4cnaQCV4Ih2Sq0T1k7p yokxHAz7q8iY5176S3x3JOl9dv5KekcMqD2OXG9eS2KvaUNLbT+NGeRzZDYPxb81k0bg iTNn6rSEaka/GQSjpA4X2xcqojTcB1DKeqOh8EuB/vpo1kxyyrrpW3ARnIzHM3EcaeRP M71ZxNhh2BOqsijD8ezpVne3WV0cPaRi1AZD9kbGGPEag+Qf+vBIONDY1H1QuGCXMceH 0CZg== X-Gm-Message-State: AOJu0YxaNVp2ao4IJa4Hjf2zaUqpuEBIL6CbaiDM5hMCMTDrztnKFVrL IeqeUYqXLhHrq3D9c3zFYna78ICX9ew= X-Google-Smtp-Source: AGHT+IEB+TeR7N7PXOfQumuI3mHdBBhH93y61QfD/bSUlAR36RNB2WvBulT3kIfrXux4w5r8G1mGpw== X-Received: by 2002:a05:6870:8194:b0:1c3:c43d:838 with SMTP id k20-20020a056870819400b001c3c43d0838mr6304676oae.39.1692530930762; Sun, 20 Aug 2023 04:28:50 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id ef13-20020a0568701a8d00b001c548ecc52asm3078489oab.13.2023.08.20.04.28.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Aug 2023 04:28:50 -0700 (PDT) Message-ID: <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> Date: Sun, 20 Aug 2023 08:28:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Content-Language: en-US To: Eli Zaretskii References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> From: Mauro Aranda In-Reply-To: <83pm3ivufg.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65401 Cc: 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Eli Zaretskii writes: >> Date: Sun, 20 Aug 2023 07:48:09 -0300 >> From: Mauro Aranda >> >> The user option custom-theme-directory is supposed to hold a directory >> name.  But its :type is a string. >> >> I realize that it isn't really a bug, but in order to offer better >> completion, at least, I'd like to change the type to be directory.  So >> I'm filing this bug report to see if people would object to such a >> change. > > Does the directory have to exist? I don't think so.  And I don't see a reason to force the existence by putting a non-nil :must-match property. The function custom-theme--load-path takes care of filtering out custom-theme-directory if it doesn't exist. And to check I evaled: (defcustom custom-theme-directory user-emacs-directory   "Default user directory for storing custom theme files. The command `customize-create-theme' writes theme files into this directory.  By default, Emacs searches for custom themes in this directory first---see `custom-theme-load-path'."   :initialize #'custom-initialize-delay   :type 'directory   :group 'customize   :version "22.1") M-x customize-option RET custom-theme-directory Changed the value to something like "~/nonexistent" and set it for the session. M-x customize-create-theme Answer y at the prompt Give the theme a dummy name. Action the Save Theme button The theme was created under: ~/nonexistent/dummy-theme.el From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 08:26:44 2023 Received: (at 65401) by debbugs.gnu.org; 20 Aug 2023 12:26:44 +0000 Received: from localhost ([127.0.0.1]:53295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXhW0-0004k0-7Y for submit@debbugs.gnu.org; Sun, 20 Aug 2023 08:26:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXhVx-0004jm-UM for 65401@debbugs.gnu.org; Sun, 20 Aug 2023 08:26:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXhVq-0007wM-UG; Sun, 20 Aug 2023 08:26:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lLWk6EjrtOH6nMLQmGY0yMBghyYxjpEEcsZGElf+vjc=; b=CCT0S6lZud2a6fE05rwN Mn/ATPLiDxUk/4Dqo3mhb4DXZZSRk8xgTVSGxrWmJJwXll6Te1JDgHUldzgIVscZCO2DPi0d9tqDV a+44LgUZzS74smfniZg75ebo9YyKc2VAzorfogUE5v7VtoNQZm7iznJ8oQyfXbL58yN4Q4WcRktFJ l7DC57xbZP3FWomaZv1fcuR4b6kfoN/NGG88E5kh2D/XZNxfw4fxu+C7fFOjruFGYakPYw38bxSmo lR6UrzZfKDT1i4M9osf3dfuZIpyKmhQHOADPMHrmdyg2hNZvLh+WBg9hpceuno3J6VMLZj7z2lRxG /VbOnsqR0UyCTQ==; Date: Sun, 20 Aug 2023 15:26:50 +0300 Message-Id: <83o7j1x5kl.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> (message from Mauro Aranda on Sun, 20 Aug 2023 08:28:48 -0300) Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65401 Cc: 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 20 Aug 2023 08:28:48 -0300 > Cc: 65401@debbugs.gnu.org > From: Mauro Aranda > > Eli Zaretskii writes: > > > Does the directory have to exist? > > I don't think so.  And I don't see a reason to force the existence by > putting a non-nil :must-match property. > > The function custom-theme--load-path takes care of filtering out > custom-theme-directory if it doesn't exist. If the directory doesn't have to exist, then what is the difference between :directory and :string? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 08:35:29 2023 Received: (at 65401) by debbugs.gnu.org; 20 Aug 2023 12:35:29 +0000 Received: from localhost ([127.0.0.1]:53299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXheT-0004xg-8G for submit@debbugs.gnu.org; Sun, 20 Aug 2023 08:35:29 -0400 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:47265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXheS-0004xS-AJ for 65401@debbugs.gnu.org; Sun, 20 Aug 2023 08:35:28 -0400 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6bcac140aaaso2068027a34.2 for <65401@debbugs.gnu.org>; Sun, 20 Aug 2023 05:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692534920; x=1693139720; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UsxUm13kMyjpDlbD6YmY38cBSF+WBwBRqI6rSUR4AK4=; b=N5xCCTEniboN9LGxePnzwz9xbK3e3t2+qdXiVL22tmFGeAirHyM+4eRY1o/OTmz02B vld9J035wcRRZUoMYU5Ul/dfrKZyrf9HNJGhch4t5Qmc0cddZb3d9OSaFeSQbauVAcrF n/nPfMxNTikWai3uh+IZpGjcBKnBeLRkAMr+D3F1X7mJsNemVgZ4FusAyHqMHQ05SkxX aaJTb4WsynXfUK5ZNv2LO3LmP+xKQj2dVOlO8/TmWNSgv7nmO0vnd9iIApVAauTAVhZf 4BYRBlAPLKkS2vbha10ZXqm+X9wb1T174K46uv6kPF4yd7MFqFotPVmp4Bu/CVcYisa2 Ux4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692534920; x=1693139720; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UsxUm13kMyjpDlbD6YmY38cBSF+WBwBRqI6rSUR4AK4=; b=An04UDdxY/rPyBuW4qLXZA3uJW4Mz4WvzvKPeRZ2/HzfN8y5F5rwa+7hlf6mUpjPsq RQN5kkYFA4nzqsUekUtLp2aTxD0FI3PqlsDWFZWnyxx0IrOt6j30FcAgOtr0c3Z+xyH9 e6YoMZ1chILu4Q97CLN4X5poEShMMQae3qYV+wkM41iIgQmGMdf0dS2ke8RkDlCPy7H3 yPWKndfHFetR95tuOrffXhc3hDEBwaBTdZYzE1ocZQBT4j2iB4JqU5/c+dWkhCPPtLwa iU7eOW/bR/Agavj30ml9Mo6kjTgmoLO1JD+yId4zZz5JNitJEfcy960FbdUzCkZ+/4Ok 2DEg== X-Gm-Message-State: AOJu0YxROuylGZBz+Xug9oUmBxgWTexc2XBocMKjC9EYTaaWc71yCCOZ wAk44hkvdOYLWqZmYZZiliYJvj0NRp8= X-Google-Smtp-Source: AGHT+IF/d9nfdAjjTiX1eT6T62NUKZ0QbhgSmVrWsfILNpIi/xG+kRJ/J5MO/+4fbkkn6ebBU9xkiQ== X-Received: by 2002:a05:6830:1e57:b0:6bc:de9b:a3e6 with SMTP id e23-20020a0568301e5700b006bcde9ba3e6mr5623995otj.24.1692534920342; Sun, 20 Aug 2023 05:35:20 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id p23-20020a056830131700b006b89596bc61sm2533686otq.61.2023.08.20.05.35.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Aug 2023 05:35:19 -0700 (PDT) Message-ID: <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> Date: Sun, 20 Aug 2023 09:35:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Content-Language: en-US To: Eli Zaretskii References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> From: Mauro Aranda In-Reply-To: <83o7j1x5kl.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65401 Cc: 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Eli Zaretskii writes: >> Date: Sun, 20 Aug 2023 08:28:48 -0300 >> Cc: 65401@debbugs.gnu.org >> From: Mauro Aranda >> >> Eli Zaretskii writes: >> >>  > Does the directory have to exist? >> >> I don't think so.  And I don't see a reason to force the existence by >> putting a non-nil :must-match property. >> >> The function custom-theme--load-path takes care of filtering out >> custom-theme-directory if it doesn't exist. > > If the directory doesn't have to exist, then what is the difference > between :directory and :string? Completion when editing via Customize is the only one it comes to my mind right now (useful when the user wants to edit it to some directory it already exists).  Compare the results of: emacs -Q M-x customize-option RET custom-theme-directory Enter ~/ M-TAB and emacs -Q Eval the following (defcustom custom-theme-directory user-emacs-directory   "Default user directory for storing custom theme files. The command `customize-create-theme' writes theme files into this directory.  By default, Emacs searches for custom themes in this directory first---see `custom-theme-load-path'."   :initialize #'custom-initialize-delay   :type 'directory   :group 'customize   :version "22.1") M-x customize-option RET custom-theme-directory Enter ~/ M-TAB From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 09:32:17 2023 Received: (at 65401) by debbugs.gnu.org; 20 Aug 2023 13:32:18 +0000 Received: from localhost ([127.0.0.1]:53333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXiXR-0006TZ-L8 for submit@debbugs.gnu.org; Sun, 20 Aug 2023 09:32:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXiXO-0006TN-HB for 65401@debbugs.gnu.org; Sun, 20 Aug 2023 09:32:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXiXH-00051d-3p; Sun, 20 Aug 2023 09:32:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TixIvh9gA00g+pMyNCqyMj5ROO7JCeImVTDns3YMa78=; b=fE60DkzIsHdK 0+y7AkC9EVNPEmi4/2N4cYGw7NyGSQBBejg3FKQhTyLFtHdBDo/pBcHnQNh59h2JQfCiOL+PljJo+ wZf5ylfk2tZ6phvYdBUxO3HfHv1BiangeZXYaHr9aOvkDNBx3+b1gfK/QxP2E3LbUU8U8VS+VxY8R VPwdSIkLt9XybBL0UsBBKnX76ZWVP8aBeLAP1QvRVyz3j0fYf0vwesZD5CVfnP7ydL2ecyzZIscFE NBnGDAnjJ90PrRV7gsbq2nt5OtvW7rNuR+B0jWPkg4dCDEcDKr2ddM14PoRgu/uzADVVV9S4CNb83 bInHHHU2+imOFXCSS4wnYQ==; Date: Sun, 20 Aug 2023 16:32:21 +0300 Message-Id: <83msylx2je.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> (message from Mauro Aranda on Sun, 20 Aug 2023 09:35:17 -0300) Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65401 Cc: 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 20 Aug 2023 09:35:17 -0300 > Cc: 65401@debbugs.gnu.org > From: Mauro Aranda > > Eli Zaretskii writes: > > > If the directory doesn't have to exist, then what is the difference > > between :directory and :string? > > Completion when editing via Customize is the only one it comes to my > mind right now (useful when the user wants to edit it to some directory > it already exists). Then I don't see why would anyone object to the change you propose. It has no downsides, AFAICT. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 09:43:44 2023 Received: (at 65401) by debbugs.gnu.org; 20 Aug 2023 13:43:44 +0000 Received: from localhost ([127.0.0.1]:53346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXiiV-0006lg-MP for submit@debbugs.gnu.org; Sun, 20 Aug 2023 09:43:44 -0400 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]:62833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXiiU-0006lT-0Y for 65401@debbugs.gnu.org; Sun, 20 Aug 2023 09:43:42 -0400 Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-56e0d6651fbso1892687eaf.1 for <65401@debbugs.gnu.org>; Sun, 20 Aug 2023 06:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692539014; x=1693143814; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=aE8t5PsWW6/HUgrENO+ca+u+Z1Zj4z6CEL829AZjZqY=; b=PG2m81FG4j80BGRc1YyjN4FE/YQyNsXepvIMuj0kP3iTOW7z9ey/w0dcSuwRfGltWM mNtXYCDHOA8o0uKgXR57whDjkqad0ueZiw5dEVL9XRBe1ya733+HaY9pR4O564pCuN+M I/hrXOo+F1aOGzGdJIDNrlOy6U0srWobWeSEPzbwfMi+yQXis2g5KWL6W6ORdApv5JO3 xNezO1uiGOKmdAQBsoMsjoz6W42/FyvFQBW5IylnDxdWEv1atHvFEPtdAOywRNkZbxcC ZOrkC2togJfCxmL13w6Dt9NSDXIuG8GeKT3W2QEICc5FXAP+BHGh7DRZNN30fzlv9B1e fw0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692539014; x=1693143814; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aE8t5PsWW6/HUgrENO+ca+u+Z1Zj4z6CEL829AZjZqY=; b=hp88F+ESkNnyP7OWiFqLzRCPktU5NdTDB7qQvnNn1ePKEymCnA6M/XlKFLy9bL7x6J ceiWJAtAfZzGnQiSdv/vsl1ageTX1g9XcpJ4i0ybnL2ybBDNiTTvkevBLCVwf9S76o87 9ZNGvffDmXirEbM63CImTsoNjOgQ6dk/SgnNj2wxSwm2almFw1M7pHGk9JgFSZ3P3/TG jt0Il0BIM1TOc+8F47FeJ42JWrizhlJ9dTNgmgbIGGtrjp9Du11APC1lt2C334fPCUh3 Apz8VKqcYQ7m1w2EnIjSb24JkeVdYfUAm/sKBaEEffl6zYscN3IW6/+57PvidN61cN8n b76g== X-Gm-Message-State: AOJu0Yw6KU14yWk+0pRMMUuBScPIRPOF8tG2n2gB2tVGI27a70cOSvxr IayXrZKcI6kZ5x+V8vqR89A= X-Google-Smtp-Source: AGHT+IF4obC8WGoShDqWF1851JGymvhwPWCHfWvK2gqZj2gA1kmjol/eI+DtkglK1SFoQ1VwifmAqQ== X-Received: by 2002:a05:6808:1a27:b0:3a7:17b6:34f1 with SMTP id bk39-20020a0568081a2700b003a717b634f1mr3370654oib.4.1692539014324; Sun, 20 Aug 2023 06:43:34 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id eu21-20020a056808289500b003a1f359ba4esm2701050oib.14.2023.08.20.06.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Aug 2023 06:43:33 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------DHBhkLlFCwUtmW0HF0R8nJi3" Message-ID: Date: Sun, 20 Aug 2023 10:43:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Content-Language: en-US To: Eli Zaretskii References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> <83msylx2je.fsf@gnu.org> From: Mauro Aranda In-Reply-To: <83msylx2je.fsf@gnu.org> X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65401 Cc: 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) This is a multi-part message in MIME format. --------------DHBhkLlFCwUtmW0HF0R8nJi3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Eli Zaretskii writes: >> Date: Sun, 20 Aug 2023 09:35:17 -0300 >> Cc: 65401@debbugs.gnu.org >> From: Mauro Aranda >> >> Eli Zaretskii writes: >> >>  > If the directory doesn't have to exist, then what is the difference >>  > between :directory and :string? >> >> Completion when editing via Customize is the only one it comes to my >> mind right now (useful when the user wants to edit it to some directory >> it already exists). > > Then I don't see why would anyone object to the change you propose. > It has no downsides, AFAICT. > > Thanks. OK, thank you.  I attach the patch. --------------DHBhkLlFCwUtmW0HF0R8nJi3 Content-Type: text/x-patch; charset=UTF-8; name="0001-Improve-type-of-custom-theme-directory-Bug-65401.patch" Content-Disposition: attachment; filename*0="0001-Improve-type-of-custom-theme-directory-Bug-65401.patch" Content-Transfer-Encoding: base64 RnJvbSBjMzRkZWEwNjk1NmYyYTNkMDk4YmFkZjljZWEwODliZWUwZjdiNjFiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFN1biwgMjAgQXVnIDIwMjMgMTA6Mzk6NDkgLTAzMDAKU3ViamVjdDog W1BBVENIXSBJbXByb3ZlIHR5cGUgb2YgY3VzdG9tLXRoZW1lLWRpcmVjdG9yeSAoQnVnIzY1 NDAxKQoKKiBsaXNwL2N1c3RvbS5lbCAoY3VzdG9tLXRoZW1lLWRpcmVjdG9yeSk6IE1ha2Ug aXQgb2YgdHlwZSBkaXJlY3RvcnkuCi0tLQogbGlzcC9jdXN0b20uZWwgfCA0ICsrLS0KIDEg ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvbGlzcC9jdXN0b20uZWwgYi9saXNwL2N1c3RvbS5lbAppbmRleCAwODMzNDllMzU5 MS4uNWIyNDQ0NjRkMGIgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzdG9tLmVsCisrKyBiL2xpc3Av Y3VzdG9tLmVsCkBAIC0xMjA4LDkgKzEyMDgsOSBAQCBjdXN0b20tdGhlbWUtZGlyZWN0b3J5 CiBkaXJlY3RvcnkuICBCeSBkZWZhdWx0LCBFbWFjcyBzZWFyY2hlcyBmb3IgY3VzdG9tIHRo ZW1lcyBpbiB0aGlzCiBkaXJlY3RvcnkgZmlyc3QtLS1zZWUgYGN1c3RvbS10aGVtZS1sb2Fk LXBhdGgnLiIKICAgOmluaXRpYWxpemUgIydjdXN0b20taW5pdGlhbGl6ZS1kZWxheQotICA6 dHlwZSAnc3RyaW5nCisgIDp0eXBlICdkaXJlY3RvcnkKICAgOmdyb3VwICdjdXN0b21pemUK LSAgOnZlcnNpb24gIjIyLjEiKQorICA6dmVyc2lvbiAiMzAuMSIpCiAKIChkZWZ2YXIgY3Vz dG9tLXRoZW1lLWxvYWQtcGF0aCAobGlzdCAnY3VzdG9tLXRoZW1lLWRpcmVjdG9yeSB0KQog ICAiTGlzdCBvZiBkaXJlY3RvcmllcyB0byBzZWFyY2ggZm9yIGN1c3RvbSB0aGVtZSBmaWxl cy4KLS0gCjIuMzQuMQoK --------------DHBhkLlFCwUtmW0HF0R8nJi3-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 04:00:46 2023 Received: (at 65401) by debbugs.gnu.org; 21 Aug 2023 08:00:47 +0000 Received: from localhost ([127.0.0.1]:55473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXzqA-0004xg-K4 for submit@debbugs.gnu.org; Mon, 21 Aug 2023 04:00:46 -0400 Received: from mout02.posteo.de ([185.67.36.66]:45759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXzq8-0004xT-FR for 65401@debbugs.gnu.org; Mon, 21 Aug 2023 04:00:45 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BA0D2240106 for <65401@debbugs.gnu.org>; Mon, 21 Aug 2023 10:00:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692604836; bh=VpBujNsjjTp8lAKZRBxfAE5jztHgnvTWJXC3J2qZ1R4=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=G6Und+eeV/YSdhQWgETEZaFNJJcc0KA6tR/m3C9S3i7Ifbxax+0JcDvzn6uKLGJV+ bPSJwVVT7fESoa6D2hwDmBxqqGl+/r+iIx44DOFMRix5d7pz2vKIfvF16Jg2dgLeYK momXOfGFJTI+mO6Hb2FVOjbAmMkeLsllUFj3S/t4vgeIIVk70sUmliJ7j61nj9Xn5s ZyKygv1ApJxiQjNQiAvrhkVCyLiBcky+5DsZ3GJFnrF+M7Mef/04fv8rAVPH2jcGUS +/doTeDPYrmoDr5apk85cV2XPVlbslqJduX6V7uOnQJb6ok9WbRdSn8OyDCr8J9ULb lmIlaqDBzx8rA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RTlK00Nv4z9rxK; Mon, 21 Aug 2023 10:00:35 +0200 (CEST) From: Philip Kaludercic To: Mauro Aranda Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced In-Reply-To: (Mauro Aranda's message of "Sun, 20 Aug 2023 10:43:31 -0300") References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> <83msylx2je.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Mon, 21 Aug 2023 08:00:35 +0000 Message-ID: <874jksj04c.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65401 Cc: Eli Zaretskii , 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mauro Aranda writes: > Eli Zaretskii writes: > >>> Date: Sun, 20 Aug 2023 09:35:17 -0300 >>> Cc: 65401@debbugs.gnu.org >>> From: Mauro Aranda >>> >>> Eli Zaretskii writes: >>> >>>=C2=A0 > If the directory doesn't have to exist, then what is the differ= ence >>>=C2=A0 > between :directory and :string? >>> >>> Completion when editing via Customize is the only one it comes to my >>> mind right now (useful when the user wants to edit it to some directory >>> it already exists). >> >> Then I don't see why would anyone object to the change you propose. >> It has no downsides, AFAICT. >> >> Thanks. > > OK, thank you.=C2=A0 I attach the patch. > > From c34dea06956f2a3d098badf9cea089bee0f7b61b Mon Sep 17 00:00:00 2001 > From: Mauro Aranda > Date: Sun, 20 Aug 2023 10:39:49 -0300 > Subject: [PATCH] Improve type of custom-theme-directory (Bug#65401) > > * lisp/custom.el (custom-theme-directory): Make it of type directory. > --- > lisp/custom.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/custom.el b/lisp/custom.el > index 083349e3591..5b244464d0b 100644 > --- a/lisp/custom.el > +++ b/lisp/custom.el > @@ -1208,9 +1208,9 @@ custom-theme-directory > directory. By default, Emacs searches for custom themes in this > directory first---see `custom-theme-load-path'." > :initialize #'custom-initialize-delay > - :type 'string > + :type 'directory > :group 'customize > - :version "22.1") > + :version "30.1") Does the version tag have to be bumped, for a metadata change this like? >=20=20 > (defvar custom-theme-load-path (list 'custom-theme-directory t) > "List of directories to search for custom theme files. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 07:05:00 2023 Received: (at 65401) by debbugs.gnu.org; 21 Aug 2023 11:05:00 +0000 Received: from localhost ([127.0.0.1]:55683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY2iR-0001T3-L5 for submit@debbugs.gnu.org; Mon, 21 Aug 2023 07:05:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY2iQ-0001Sn-2U for 65401@debbugs.gnu.org; Mon, 21 Aug 2023 07:04:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY2iI-00086a-DJ; Mon, 21 Aug 2023 07:04:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IsYLQnHIZbLAdUFaA/FhA/9CNJPQfxn3KlKqyf/eQvE=; b=TLYvNb+bMATaad0toRuM Byjw03AhfgMTYu4mqjpydCUD3EZfllOMxf1sajz4cqMunmsewG/kYjRSKNzj4AgIc28bvFMjPKQOM LchyA08WZ1jTQsU5BgYsvoUiB3dV6wVVDA57v+eosHFezs4yeQAnNIGt1C5UH75KvokhBNNAzmxlw 47NZdEhXmwYtgR2VtPS3lY/vy2lS9vd/lQuaEFZfQXI/4xWXfgXHvFNjk7hooxogMVVZ+dUQnPiJ4 g64xvEaYlYjFRLiHDnTc9G1vy0ypVtQgQoD+d8fV9yUSEA6dDhdtytAnsC36h5JZ9T5zZD/BdIDPc 0dujn2/j64gAEw==; Date: Mon, 21 Aug 2023 14:05:07 +0300 Message-Id: <83v8d8veos.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic , Stefan Monnier In-Reply-To: <874jksj04c.fsf@posteo.net> (message from Philip Kaludercic on Mon, 21 Aug 2023 08:00:35 +0000) Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> <83msylx2je.fsf@gnu.org> <874jksj04c.fsf@posteo.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65401 Cc: maurooaranda@gmail.com, 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: Eli Zaretskii , 65401@debbugs.gnu.org > Date: Mon, 21 Aug 2023 08:00:35 +0000 > > Mauro Aranda writes: > > > Eli Zaretskii writes: > > > >>> Date: Sun, 20 Aug 2023 09:35:17 -0300 > >>> Cc: 65401@debbugs.gnu.org > >>> From: Mauro Aranda > >>> > >>> Eli Zaretskii writes: > >>> > >>>  > If the directory doesn't have to exist, then what is the difference > >>>  > between :directory and :string? > >>> > >>> Completion when editing via Customize is the only one it comes to my > >>> mind right now (useful when the user wants to edit it to some directory > >>> it already exists). > >> > >> Then I don't see why would anyone object to the change you propose. > >> It has no downsides, AFAICT. > >> > >> Thanks. > > > > OK, thank you.  I attach the patch. > > > > From c34dea06956f2a3d098badf9cea089bee0f7b61b Mon Sep 17 00:00:00 2001 > > From: Mauro Aranda > > Date: Sun, 20 Aug 2023 10:39:49 -0300 > > Subject: [PATCH] Improve type of custom-theme-directory (Bug#65401) > > > > * lisp/custom.el (custom-theme-directory): Make it of type directory. > > --- > > lisp/custom.el | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lisp/custom.el b/lisp/custom.el > > index 083349e3591..5b244464d0b 100644 > > --- a/lisp/custom.el > > +++ b/lisp/custom.el > > @@ -1208,9 +1208,9 @@ custom-theme-directory > > directory. By default, Emacs searches for custom themes in this > > directory first---see `custom-theme-load-path'." > > :initialize #'custom-initialize-delay > > - :type 'string > > + :type 'directory > > :group 'customize > > - :version "22.1") > > + :version "30.1") > > Does the version tag have to be bumped, for a metadata change this like? Probably not. AFAIK, this is only used for showing "new and changed" options when users upgrade, and this change will be invisible at user level. Stefan, am I missing something? From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 08:39:31 2023 Received: (at 65401) by debbugs.gnu.org; 21 Aug 2023 12:39:31 +0000 Received: from localhost ([127.0.0.1]:55806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY4Bv-0003Ln-H7 for submit@debbugs.gnu.org; Mon, 21 Aug 2023 08:39:31 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY4Bt-0003Lb-Rg for 65401@debbugs.gnu.org; Mon, 21 Aug 2023 08:39:30 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 268191000BD; Mon, 21 Aug 2023 08:39:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1692621561; bh=hytmXbsyp8n99u5Sykt1gn8EMYDLKv0WCn0mwxaoUvk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kFcgyjB3f4nBcdJHABtUBsZpMqrjlnjopRkeeI98rcL63Cm14EymvQWazpHJfeScZ iD/o/5UyG70e2Ubt17MOTMQspKwLgsROV0U1gsKL4YWjjEi3n2uavyDz82JB1EEw3/ H/8yGAA/BqG2NwlD70x/yK9GQwNRvqwsCWk5kprAkn1lN2BKB48Y7Qw7daYedkdP8H PYof9RYi4GgeggYnK4XtKgEjUMa98D+dUR3/x5FSW2YDXazbJkmpxuhyUAgWgjQvFO AxnxkzB68/sExBaiU0mIZvBlaRG+mN4AAuhJ+nwXHgK6y6GV3uU5DNNqJciX8d+xCR uoefR9htTo+HA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1B98510006B; Mon, 21 Aug 2023 08:39:21 -0400 (EDT) Received: from pastel (unknown [45.72.228.154]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E25FD12031C; Mon, 21 Aug 2023 08:39:20 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced In-Reply-To: <83v8d8veos.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Aug 2023 14:05:07 +0300") Message-ID: References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> <83msylx2je.fsf@gnu.org> <874jksj04c.fsf@posteo.net> <83v8d8veos.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 21 Aug 2023 08:39:20 -0400 MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.173 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65401 Cc: Philip Kaludercic , maurooaranda@gmail.com, 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > - :type 'string >> > + :type 'directory >> > :group 'customize >> > - :version "22.1") >> > + :version "30.1") >> >> Does the version tag have to be bumped, for a metadata change this like? > > Probably not. AFAIK, this is only used for showing "new and changed" > options when users upgrade, and this change will be invisible at > user level. Agreed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 10:42:02 2023 Received: (at 65401) by debbugs.gnu.org; 21 Aug 2023 14:42:02 +0000 Received: from localhost ([127.0.0.1]:57449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY66T-00018U-Nl for submit@debbugs.gnu.org; Mon, 21 Aug 2023 10:42:02 -0400 Received: from mail-oo1-xc29.google.com ([2607:f8b0:4864:20::c29]:54692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY66R-000187-9f for 65401@debbugs.gnu.org; Mon, 21 Aug 2023 10:42:00 -0400 Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-570db728a48so423385eaf.1 for <65401@debbugs.gnu.org>; Mon, 21 Aug 2023 07:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692628911; x=1693233711; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DEaBq+cJgQx+PB6qwV39Qia2ZQqXMDi1m/8tA+6mJug=; b=NXF9cb4nlEruXy99yqJQ63WGntoNd6pnrosMsHZxOeOUAARAPxPiglpONwVFxTp0em NC62Bp/yCuGfYHI0Og7d60BrcXwtqVpBF9g+9dHayZIz+7MkkKGOdZ88kNh1Fb6QzPkq xopZzimZPw00jcMj1zqKExIxNoQ1SDvXHKVcXxYLEnZhfJkIvXltc9oQ+Y7qrl1xiixZ 7wl0kRbL/jr2hSS3venfmjlZ2xOqJkEQo/yoO2SvmsR7+QEjQ+yQZ6A5cA8RD+Asg1Bu dWAwAhk0+mIDri1SkhJK/xlgAzjHmwhyPIVFVmeHIlOUuQmt9qcsTGib8zZEX1ukHfiC V9OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692628911; x=1693233711; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DEaBq+cJgQx+PB6qwV39Qia2ZQqXMDi1m/8tA+6mJug=; b=YRmnhKX59mXzBZn5l/JAo+VUdw9AWAyMQBEB6xBJfUvF38Pc0dC357JPq2G/AV/jZq KTF3cI57UuuDr9nGWveEQvDogN6p5oSsvwSIf5gk2PZRjaPLaRUPsWseHOYGmdpuFReM OA1F9E2mXPB3oIfxTBolWUmBKHel1QmZNx0OWxUAIFyKpN3zVtX4rNBLIsRTAZy17SDX wo65oVvwV7S7p+5UybZqci6jQKAIO76eH64KpiezadztYjSvYi8Uu0ctRHQ8gYo+Z5oS m+xeV4UqUC/i3Yn8mf7Z67u9Q40oe81qXXBt/5wta9evT9GHoE6Hh7Jbz5qUi9vJDTdK /fvg== X-Gm-Message-State: AOJu0Yy1z3PDdKW5uFit7D+ckm47vielF2HagccqbPK+d1Bh5AnQPkOr afdH8h448gkJoNg8tiqdovw= X-Google-Smtp-Source: AGHT+IGdT1UmjycVSvi1lzRqfEZ/1DoX+hnIF54Apj38SqB2wKp3P9L5zbPEnTUHmgtft86ltWE0pw== X-Received: by 2002:a4a:270e:0:b0:56e:9e98:2cfd with SMTP id l14-20020a4a270e000000b0056e9e982cfdmr4830910oof.2.1692628911349; Mon, 21 Aug 2023 07:41:51 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id q82-20020a4a3355000000b00541fbbbcd31sm3335965ooq.5.2023.08.21.07.41.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 07:41:50 -0700 (PDT) Message-ID: Date: Mon, 21 Aug 2023 11:41:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Content-Language: en-US To: Philip Kaludercic References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> <83msylx2je.fsf@gnu.org> <874jksj04c.fsf@posteo.net> From: Mauro Aranda In-Reply-To: <874jksj04c.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65401 Cc: Eli Zaretskii , 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Philip Kaludercic writes: > Mauro Aranda writes: > >> >> OK, thank you.  I attach the patch. >> >> From c34dea06956f2a3d098badf9cea089bee0f7b61b Mon Sep 17 00:00:00 2001 >> From: Mauro Aranda >> Date: Sun, 20 Aug 2023 10:39:49 -0300 >> Subject: [PATCH] Improve type of custom-theme-directory (Bug#65401) >> >> * lisp/custom.el (custom-theme-directory): Make it of type directory. >> --- >>  lisp/custom.el | 4 ++-- >>  1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lisp/custom.el b/lisp/custom.el >> index 083349e3591..5b244464d0b 100644 >> --- a/lisp/custom.el >> +++ b/lisp/custom.el >> @@ -1208,9 +1208,9 @@ custom-theme-directory >>  directory.  By default, Emacs searches for custom themes in this >>  directory first---see `custom-theme-load-path'." >>    :initialize #'custom-initialize-delay >> -  :type 'string >> +  :type 'directory >>    :group 'customize >> -  :version "22.1") >> +  :version "30.1") > > Does the version tag have to be bumped, for a metadata change this like? > I wasn't sure.  But now I can see why it was wrong to update it. Thank you for noticing it. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 10:46:39 2023 Received: (at 65401) by debbugs.gnu.org; 21 Aug 2023 14:46:39 +0000 Received: from localhost ([127.0.0.1]:57467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY6Aw-0001L5-VT for submit@debbugs.gnu.org; Mon, 21 Aug 2023 10:46:39 -0400 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:48463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY6Av-0001Kl-8u for 65401@debbugs.gnu.org; Mon, 21 Aug 2023 10:46:37 -0400 Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3a81154c5f5so2367031b6e.1 for <65401@debbugs.gnu.org>; Mon, 21 Aug 2023 07:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692629189; x=1693233989; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=5L0ZopQXiSYjeqwfAM1F0QYL9wq4B/jv9XvKaiPuGIc=; b=pC+zU48IBVSthfoJndL41TwyaECfPDpigmLMNW18j5EJnmei6uA/qzslREICRXhHiQ eEZz592i3SulwzCtSw8LYBJfiPMVSKmkd9pdTAss8h/NJUiKcYOmvUR2aC99LSCfhZ7c O0kJLNYh3/m6QwYdJ7ua3NohPLeJLu8Qf0S1WyurGAih8K2gAYQbGtri2SJSva9EXqup dMaz88aPHrbGiNMrC8DGimvxBHcZn7ynKZbig2VPxop2ZziOYYzxeONXhZALuCKJlbvy 67pW6pBOpkD3E6PdaJ2UDkvrcDnWAdjiDS5XIjUCbGGaI+jzLzTTlkFTX14OHyzW32n/ yBAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692629189; x=1693233989; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5L0ZopQXiSYjeqwfAM1F0QYL9wq4B/jv9XvKaiPuGIc=; b=CF0pzkqKThJbjIZ3ml2HDb/AEtB8qmL7Dn2bD3zgQVXtbDNFIl6PpqjUcpy0EIN6G1 ptXbYvFgmq+Z3CTAuvV25nCiE+BJB9eTSOJ6K0JLmD8rGfHATz8LUsIiib6KseLPSC29 WP8VL/h2lt4GMcEm17PDjUjJGyVajOT1Fh7yuGp9LfAamayNIfhtT1m5QXqnRDzazpJF iKBhbn9a1+bpvywA6BM70rMSdARZbDjj0e/qZ+/lWd15EZFLJwgvEHuhP7H2RvNv+EEO F8ZI2zeQ3pA46EC4OG4MV53HP6oovilQPYgUGMECafZ2oKgNr+hVZMC7twWwraLOk8Sd H+Vg== X-Gm-Message-State: AOJu0Yyt3uFRQ+dH0UdBYbFy6vqQ5Qa+fagM3gfD9B23cidQIZiORROF nPBhzHo69FFcsMHRcdupTc8= X-Google-Smtp-Source: AGHT+IE8l3BzPQ/vyit0FLV3OXZSEozpgZjWolNsqOvjpt8ZkEx9E2w1ZqDzBVBuMKwsYPEphA0i2w== X-Received: by 2002:a54:4499:0:b0:3a7:208c:4406 with SMTP id v25-20020a544499000000b003a7208c4406mr7697708oiv.1.1692629189351; Mon, 21 Aug 2023 07:46:29 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id a28-20020a056808099c00b003a75748af5esm3625277oic.30.2023.08.21.07.46.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 07:46:28 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------yON5095XlFzOFeO0qAeKeJ2X" Message-ID: Date: Mon, 21 Aug 2023 11:46:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Content-Language: en-US To: Stefan Monnier , Eli Zaretskii References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> <83msylx2je.fsf@gnu.org> <874jksj04c.fsf@posteo.net> <83v8d8veos.fsf@gnu.org> From: Mauro Aranda In-Reply-To: X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65401 Cc: Philip Kaludercic , 65401@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) This is a multi-part message in MIME format. --------------yON5095XlFzOFeO0qAeKeJ2X Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Stefan Monnier writes: >>> > -  :type 'string >>> > +  :type 'directory >>> >    :group 'customize >>> > -  :version "22.1") >>> > +  :version "30.1") >>> >>> Does the version tag have to be bumped, for a metadata change this like? >> >> Probably not.  AFAIK, this is only used for showing "new and changed" >> options when users upgrade, and this change will be invisible at >> user level. > > Agreed. > > >         Stefan Sending an updated patch.  Thanks. --------------yON5095XlFzOFeO0qAeKeJ2X Content-Type: text/x-patch; charset=UTF-8; name="0001-Improve-type-of-custom-theme-directory-Bug-65401.patch" Content-Disposition: attachment; filename*0="0001-Improve-type-of-custom-theme-directory-Bug-65401.patch" Content-Transfer-Encoding: base64 RnJvbSBhNzlkMDFiNjJkNDZmZmUxMjFlMGI3ZGIyNjgwM2Q0ZmVjYzMwMTA1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFN1biwgMjAgQXVnIDIwMjMgMTA6Mzk6NDkgLTAzMDAKU3ViamVjdDog W1BBVENIXSBJbXByb3ZlIHR5cGUgb2YgY3VzdG9tLXRoZW1lLWRpcmVjdG9yeSAoQnVnIzY1 NDAxKQoKKiBsaXNwL2N1c3RvbS5lbCAoY3VzdG9tLXRoZW1lLWRpcmVjdG9yeSk6IE1ha2Ug aXQgb2YgdHlwZSBkaXJlY3RvcnkuCi0tLQogbGlzcC9jdXN0b20uZWwgfCAyICstCiAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg YS9saXNwL2N1c3RvbS5lbCBiL2xpc3AvY3VzdG9tLmVsCmluZGV4IDA4MzM0OWUzNTkxLi41 YzEzNGZmN2YxMyAxMDA2NDQKLS0tIGEvbGlzcC9jdXN0b20uZWwKKysrIGIvbGlzcC9jdXN0 b20uZWwKQEAgLTEyMDgsNyArMTIwOCw3IEBAIGN1c3RvbS10aGVtZS1kaXJlY3RvcnkKIGRp cmVjdG9yeS4gIEJ5IGRlZmF1bHQsIEVtYWNzIHNlYXJjaGVzIGZvciBjdXN0b20gdGhlbWVz IGluIHRoaXMKIGRpcmVjdG9yeSBmaXJzdC0tLXNlZSBgY3VzdG9tLXRoZW1lLWxvYWQtcGF0 aCcuIgogICA6aW5pdGlhbGl6ZSAjJ2N1c3RvbS1pbml0aWFsaXplLWRlbGF5Ci0gIDp0eXBl ICdzdHJpbmcKKyAgOnR5cGUgJ2RpcmVjdG9yeQogICA6Z3JvdXAgJ2N1c3RvbWl6ZQogICA6 dmVyc2lvbiAiMjIuMSIpCiAKLS0gCjIuMzQuMQoK --------------yON5095XlFzOFeO0qAeKeJ2X-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 19:12:41 2023 Received: (at control) by debbugs.gnu.org; 23 Aug 2023 23:12:41 +0000 Received: from localhost ([127.0.0.1]:35541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYx1l-0005I5-5l for submit@debbugs.gnu.org; Wed, 23 Aug 2023 19:12:41 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:48360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYx1i-0005Hq-Sa for control@debbugs.gnu.org; Wed, 23 Aug 2023 19:12:39 -0400 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-52683b68c2fso7649016a12.0 for ; Wed, 23 Aug 2023 16:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692832349; x=1693437149; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=yhlfSWSMPrO35TcWFFLxKcRvGrTwPAVXF+5eA+LKUII=; b=hAvyd0SeOv9BxVneBHV6DThx0EmbtdytYWgR5PdV9Ub/hERpAlM+D9AegNuTviBtGF G8nlAh8LphWgCa2DtJf3nE3a/xv5MMqQqB8spfxFsnNJrweQPni3HFvyhZeoF1hYkIO/ McI81qz7Ou6USF++50L5L8yGL3EQSjQHz90Z16DucXZtprqt3v3BZ5VRQsy/SGe758w/ bOK21UzxJAVxODm+n2wQErfhCHXlkZ2UfPUITHWKIlDJotjX1NZDbgY+kbJoi9S+NwlD 7jAmuJCa1Vz5pwsGbmeZpsKkY2Ahe4p0nijk+YZyfXTvR3KB47YrETdQCjgrAxRT6G0h Rt5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692832349; x=1693437149; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yhlfSWSMPrO35TcWFFLxKcRvGrTwPAVXF+5eA+LKUII=; b=jmJh5GwBN/p0P3qsElRZ8I1Dla40o7stvHUkNmt79dFidLSY3kqOlA3oUaBZX0GIRd nABiF9A9iuaVX7JGbKhKwuWp9BsQEswoptZ4I2CTKsgWsQ//1Sgx9BJaMZ51lKlimLuB AEwVXnoyg5yNHjKHlmk1nqcLE6/+mbJRZi2qKHN2dUevlO+mMN1Fh8yYT9tOJmY+eqRp 22uZBw6u6X2LNhciZRIcfx2TKfb9ym+xTqFS6vxT/WDA4GpenVGf/is7VMZ2PwpSH2ek osMC+oM76FjbLGs7Z0Pz1Nm1ZbVhh2F2XYpM8OBOHoHcHPb/U7JgAx+CrSdWpHY3jn57 YX7w== X-Gm-Message-State: AOJu0Yy2mHajSVUE3po/wNEZq0srUOGVGpDIHq7ETsnYsnCUFNcq6KIt efVbplARLH4U1DZLANtT6dzN43IFmAqby6JHyug73US00yU= X-Google-Smtp-Source: AGHT+IHAyzlpwqF9DLBVTYRTPwQJkY24cOaUOiwnZv549sS231ZUQz/fLZndIGDI/cSajBg0m7itt7ZdwzFJ+0J6zqM= X-Received: by 2002:a05:6402:3447:b0:523:bfec:490f with SMTP id l7-20020a056402344700b00523bfec490fmr11824457edc.0.1692832349202; Wed, 23 Aug 2023 16:12:29 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Thu, 24 Aug 2023 01:12:18 +0200 Message-ID: Subject: To: control Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 65401 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:531 listed in] [list.dnswl.org] 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 65401 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 26 04:02:13 2023 Received: (at 65401-done) by debbugs.gnu.org; 26 Aug 2023 08:02:13 +0000 Received: from localhost ([127.0.0.1]:41683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZoFI-00042R-Je for submit@debbugs.gnu.org; Sat, 26 Aug 2023 04:02:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZoFG-00042D-E0 for 65401-done@debbugs.gnu.org; Sat, 26 Aug 2023 04:02:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZoF5-0004fC-9G; Sat, 26 Aug 2023 04:01:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ZH9Q6uGWXs/IEkN+uAc+t5Pt5oWIbiNh6evB+toVZEw=; b=fg28uqBSV9nyP3HgfCW8 axCRNFXLLfz12xDtE6wAFgUDgzvbcJPEzRUXgMqZXSFnX4C57+MDONN2pBZGif4nN8zbDF+n4KXvS Z5nyqx6pZE5c72pUTwzZfJB3WGZLJ31mKOYUWV3QU3Q7oY/UT52tDck69XlmBSjCYcgsB2iPTmZsg wn3/AbRqtk7oKGG0uneJg2fGfSpOFuv9nnXg1hZ5rTGWmbPqSUVRHHOQVugUNmV7Cj1wKFfxFVW/S /XmMRIoWHSMGsRyzLBLgJvwx4vp5Y2uMcYJEgssWCdSWf802Qxsh45YeEwJuZbmBbRmRdNW//Ubk+ 0W7O2l9bJo8Oyw==; Date: Sat, 26 Aug 2023 11:02:28 +0300 Message-Id: <83zg2ekz8r.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: (message from Mauro Aranda on Mon, 21 Aug 2023 11:46:26 -0300) Subject: Re: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> <83msylx2je.fsf@gnu.org> <874jksj04c.fsf@posteo.net> <83v8d8veos.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65401-done Cc: 65401-done@debbugs.gnu.org, philipk@posteo.net, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 21 Aug 2023 11:46:26 -0300 > Cc: Philip Kaludercic , 65401@debbugs.gnu.org > From: Mauro Aranda > > Stefan Monnier writes: > > >>> > -  :type 'string > >>> > +  :type 'directory > >>> >    :group 'customize > >>> > -  :version "22.1") > >>> > +  :version "30.1") > >>> > >>> Does the version tag have to be bumped, for a metadata change this > like? > >> > >> Probably not.  AFAIK, this is only used for showing "new and changed" > >> options when users upgrade, and this change will be invisible at > >> user level. > > > > Agreed. > > > > > >         Stefan > > Sending an updated patch.  Thanks. Thanks, installed on the master branch, and closing the bug. From unknown Wed Jun 18 00:22:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 23 Sep 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator