GNU bug report logs - #65387
[PATCH] New user option 'submit-emacs-patch-display-help'

Previous Next

Package: emacs;

Reported by: Eshel Yaron <me <at> eshelyaron.com>

Date: Sat, 19 Aug 2023 19:34:01 UTC

Severity: wishlist

Tags: patch

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Eshel Yaron <me <at> eshelyaron.com>, 65387 <at> debbugs.gnu.org
Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help'
Date: Sun, 20 Aug 2023 19:37:18 +0300
>> I don't know if it justifies a new option, as you say, and I don't mind
>> keeping a modified `submit-emacs-patch` in my config.
>
> Let's see what others think about this new command.
>
> Would people please voice their opinions about adding it?

If 'submit-emacs-patch' used 'pop-to-buffer-same-window'
instead of 'switch-to-buffer' like in the patch below,
then using such simple config would be possible:

  (add-to-list 'display-buffer-alist
               '("\\*Patch Help\\*"
                 display-buffer-no-window
                 (allow-no-window . t)))

PS: This patch doesn't preclude adding an option.

diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index bebaad720db..409ef7165fe 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -509,7 +509,7 @@ submit-emacs-patch
      (list (read-string (format-prompt "This patch is about" guess)
                         nil nil guess)
            file)))
-  (switch-to-buffer "*Patch Help*")
+  (pop-to-buffer-same-window "*Patch Help*")
   (let ((inhibit-read-only t))
     (erase-buffer)
     (insert "Thank you for considering submitting a patch to the Emacs project.\n\n"




This bug report was last modified 1 year and 251 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.