From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 65387@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1692473612687 (code B ref -1); Sat, 19 Aug 2023 19:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Aug 2023 19:33:32 +0000 Received: from localhost ([127.0.0.1]:52320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXRhU-0000B1-98 for submit@debbugs.gnu.org; Sat, 19 Aug 2023 15:33:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:47536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXRhR-0000Am-Co for submit@debbugs.gnu.org; Sat, 19 Aug 2023 15:33:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXRhK-0003ql-Fv for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:33:22 -0400 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXRhI-00052g-5f for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:33:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1692473599; bh=6p1RZc9h8CulN/OMao3X/946smaWIL6JioSXIRs/xOU=; h=From:To:Subject:Date:From; b=tsPSVmCx2BwSTRdS28DoZEDTvOplRRMvbd78mV8VBoRMJaHjRWXkxI183q/D5UiHz tE5z0En6e2A6Z5OEiZFC+SMTsJvoyRc4dLL6DDmrVdye4WJVP44dSP1B68PS9m5V95 PtsxT6TGW9kh+14up+k3CcqUodmF99gd6D+M1JwjV3Ph7rs/SEz5bRe99IM8EUQtUE +6urw0h420EyvIghGhARlmqh/236xcJheIdXlp38FjKxQhIHoYFMcFsKtAsR0CK8l4 6hqAN5iMemv4baVLqCOZimkiphXGizL4+LH4f7EON2lOr3wgWj04+EMN3Ewv4HWY4k mRofFrBTFz8Kg== From: Eshel Yaron Date: Sat, 19 Aug 2023 21:33:14 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Hi, This patch adds a user option for disabling the *Patch Help* buffer that `submit-emacs-patch` displays. In GNU Emacs 30.0.50 (build 23, x86_64-apple-darwin22.5.0, NS appkit-2299.60 Version 13.4 (Build 22F66)) of 2023-08-19 built on Dazzs-MacBook-Pro.local Repository revision: 44697457c6048464a68b6d58a1c4cf967fd5be06 Repository branch: submit-emacs-patch-display-help Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.4 Configured using: 'configure 'CFLAGS=-g0 -O3' --with-native-compilation --with-json --with-imagemagick --with-tree-sitter --enable-link-time-optimization' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-New-user-option-submit-emacs-patch-display-help.patch >From 28bf05cdafa8b9d00a47a932d20569097289b6d4 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 19 Aug 2023 21:24:34 +0200 Subject: [PATCH] New user option 'submit-emacs-patch-display-help' This lets users prevent 'submit-emacs-patch' from displaying a buffer with instructions about submitting patches when they no longer need it. * lisp/mail/emacsbug.el (submit-emacs-patch-display-help): New user option. (submit-emacs-patch): Use it. * doc/emacs/trouble.texi (Sending Patches): Document it. * etc/NEWS: Announce it. --- doc/emacs/trouble.texi | 7 +++++++ etc/NEWS | 6 ++++++ lisp/mail/emacsbug.el | 45 +++++++++++++++++++++++------------------- 3 files changed, 38 insertions(+), 20 deletions(-) diff --git a/doc/emacs/trouble.texi b/doc/emacs/trouble.texi index d2e8ac3452a..279b17dca2d 100644 --- a/doc/emacs/trouble.texi +++ b/doc/emacs/trouble.texi @@ -1336,6 +1336,13 @@ Sending Patches form that is clearly safe to install. @end itemize +@vindex submit-emacs-patch-display-help +By default, @kbd{M-x submit-emacs-patch} displays a buffer with some +instructions alongside the Message mode buffer. If you're already +familiar with these instructions after submitting a patch or two, you +can disable this help by customizing the user option +@code{submit-emacs-patch-display-help} to @code{nil}. + @node Contributing @section Contributing to Emacs Development @cindex contributing to Emacs diff --git a/etc/NEWS b/etc/NEWS index 6588299c532..ab868b9f3a4 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -99,6 +99,12 @@ This allows the user to customize the prompt that is appended by 'yes-or-no-p' when asking questions. The default value is "(yes or no) ". ++++ +** New user option 'submit-emacs-patch-display-help'. +You can set this user option to nil to prevent 'submit-emacs-patch' +from displaying a help buffer with instructions for submitting +patches. + --- ** New face 'display-time-date-and-time'. This is used for displaying the time and date components of diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index bebaad720db..9c2120530a6 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -50,6 +50,10 @@ report-emacs-bug-no-explanations "If non-nil, suppress the explanations given for the sake of novice users." :type 'boolean) +(defcustom submit-emacs-patch-display-help t + "If non-nil, `submit-emacs-patch' displays some help in another buffer." + :type 'boolean) + ;; User options end here. (defvar report-emacs-bug-orig-text nil @@ -509,26 +513,27 @@ submit-emacs-patch (list (read-string (format-prompt "This patch is about" guess) nil nil guess) file))) - (switch-to-buffer "*Patch Help*") - (let ((inhibit-read-only t)) - (erase-buffer) - (insert "Thank you for considering submitting a patch to the Emacs project.\n\n" - "Please describe what the patch fixes (or, if it's a new feature, what it\n" - "implements) in the mail buffer below. When done, use the " - (substitute-command-keys "\\\\[message-send-and-exit] command\n") - "to send the patch as an email to the Emacs issue tracker.\n\n" - "If this is the first time you're submitting an Emacs patch, please\n" - "read the ") - (insert-text-button - "CONTRIBUTE" - 'action (lambda (_) - (view-buffer - (find-file-noselect - (expand-file-name "CONTRIBUTE" installation-directory))))) - (insert " file first.\n") - (goto-char (point-min)) - (view-mode 1) - (button-mode 1)) + (when submit-emacs-patch-display-help + (switch-to-buffer "*Patch Help*") + (let ((inhibit-read-only t)) + (erase-buffer) + (insert "Thank you for considering submitting a patch to the Emacs project.\n\n" + "Please describe what the patch fixes (or, if it's a new feature, what it\n" + "implements) in the mail buffer below. When done, use the " + (substitute-command-keys "\\\\[message-send-and-exit] command\n") + "to send the patch as an email to the Emacs issue tracker.\n\n" + "If this is the first time you're submitting an Emacs patch, please\n" + "read the ") + (insert-text-button + "CONTRIBUTE" + 'action (lambda (_) + (view-buffer + (find-file-noselect + (expand-file-name "CONTRIBUTE" installation-directory))))) + (insert " file first.\n") + (goto-char (point-min)) + (view-mode 1) + (button-mode 1))) (compose-mail-other-window report-emacs-bug-address subject) (message-goto-body) (insert "\n\n\n") -- 2.41.0 --=-=-=-- From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eshel Yaron Cc: 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.16924751053189 (code B ref 65387); Sat, 19 Aug 2023 19:59:02 +0000 Received: (at 65387) by debbugs.gnu.org; 19 Aug 2023 19:58:25 +0000 Received: from localhost ([127.0.0.1]:52342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXS5Z-0000pN-9Y for submit@debbugs.gnu.org; Sat, 19 Aug 2023 15:58:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXS5X-0000pA-Bl for 65387@debbugs.gnu.org; Sat, 19 Aug 2023 15:58:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXS5Q-0001tt-Rb; Sat, 19 Aug 2023 15:58:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=USxcnceO/45VeZrlFT2EqIXd9Or4SvdZRUK1GvIvNtA=; b=XCBdvgOhQj4t dHUXW4WmJJL+F4TPdBlNiLsEijeGmXkcpF8CFUuEWi7mDOPSw0c1l07b4NIIgWz0Ffb1jvjGZUgpL Qd4hwzlwLVOTkPy2PclqzUo2q2GLsCEItqMFrYI9QRjQWCPvxbvRIcCvgE6oJPvqiBJiyrwXIdt+E js8NbMIhJ3CNcdNaSOQl05K9tB+8w1geGfRu6uhtkcwKlIYHer5qHyzofKcmMtRgaH4iyL+JZ64gu LfaKSaUwlxTu26gT8e8Ja/a5KelooKUHkxBfq1BE2wyx0LJr0tuhrOyACuvApGwn5ZiReseKohRpF maa1p+9O3OPfSP7gIUk9CA==; Date: Sat, 19 Aug 2023 22:58:30 +0300 Message-Id: <83jztqyfbt.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 19 Aug 2023 21:33:14 +0200 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This patch adds a user option for disabling the *Patch Help* buffer that > `submit-emacs-patch` displays. Thanks, but why is it important to be able to disable the instructions, enough to justify this new option? I expect experienced people not to use this command at all, so its main purpose is for the newbies. From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.16924785859521 (code B ref 65387); Sat, 19 Aug 2023 20:57:02 +0000 Received: (at 65387) by debbugs.gnu.org; 19 Aug 2023 20:56:25 +0000 Received: from localhost ([127.0.0.1]:52381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXSzg-0002TV-MP for submit@debbugs.gnu.org; Sat, 19 Aug 2023 16:56:24 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:56992 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXSze-0002TN-9K for 65387@debbugs.gnu.org; Sat, 19 Aug 2023 16:56:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1692478580; bh=iuGpVtZVqtyZ7l6IyMWketBauYbB+sEQjNMcGhkLwqQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=K5R+1M5nug6Asd6akOyDepc/F/xTrnQt+ypgiH2NSYMLXlnaM9RAZQilmwqm5cNcr PocZK6iiFOnCmYEccQyihrTwhTHeoTqrFywwqe/q0XsYk2jg2PePsQzwoBC58/Gc65 Ie5uzD7hq3hE+nHdC6WjZFtMOxRL30kpAmuNvX5ZnSg7dvzWLdUjzwYYDy1nT/XRHN FbN665mauPz2U5sIOVnKrMYUQ2WuLuc+NqB6Ybs1eLHeRpLRpkx1wzoa0QT4MAq2Ln 4ISiyV8Bb6ptPomg0xJlts1QcPdfgkG0+8C8lgsVMruGNmbSYrfme1B5UZOQwFDN47 sKxpd2tmyJy8A== From: Eshel Yaron In-Reply-To: <83jztqyfbt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Aug 2023 22:58:30 +0300") References: <83jztqyfbt.fsf@gnu.org> Date: Sat, 19 Aug 2023 22:56:18 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Sat, 19 Aug 2023 21:33:14 +0200 >> From: Eshel Yaron via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> This patch adds a user option for disabling the *Patch Help* buffer that >> `submit-emacs-patch` displays. > > Thanks, but why is it important to be able to disable the > instructions, enough to justify this new option? I expect experienced > people not to use this command at all, so its main purpose is for the > newbies. Ah I actually find this command quite convenient, except for that instructions buffer that tends to get in my way. So I guess this option is useful for us semi-newbies :) I don't know if it justifies a new option, as you say, and I don't mind keeping a modified `submit-emacs-patch` in my config. I do wonder, since `(info "(emacs)Sending Patches")` recommends using `submit-emacs-patch` and that always seemed easier than doing `C-x m` and adding the destination address and the attachment patch afterwards, what alternative you'd expect experienced users to go with? Thanks, Eshel From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 06:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eshel Yaron Cc: 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.1692511623560 (code B ref 65387); Sun, 20 Aug 2023 06:08:01 +0000 Received: (at 65387) by debbugs.gnu.org; 20 Aug 2023 06:07:03 +0000 Received: from localhost ([127.0.0.1]:52737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXbaY-00008y-Lq for submit@debbugs.gnu.org; Sun, 20 Aug 2023 02:07:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXbaW-00008T-V1 for 65387@debbugs.gnu.org; Sun, 20 Aug 2023 02:07:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXbaQ-0001Qh-7U; Sun, 20 Aug 2023 02:06:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9GUmP26yk4AQxxTmXJ4UZOCjhYZEFZpqMfwKnAvaF8k=; b=hne5N+/rVOTV 36DIJ9OzmBizJQkrZxU08UG4yQWb1zFHe/Hfssv3WRWk7jNW6A0nouDq5/vntYluB5ZNhjEU+rh5p TBWiaAA7Fs48XD5Rk5db38gdHwNN3saf4nbyUWGAntIqrcblbGMPZPbYczPrOCUURy7342rhhILR2 cDnrimUIAFr93xuXpUEGFOy0MP94hX+yVGBafAtFwdxhG1JbBrk53tVGzyriCc5hTkXh16WYsxiOq C6vc9KN5XY+nPEGt3ZsdRAR8Ulp+pb+dRVu1VE3eJCHfXbvUH/hDHeNbTNHrwwIMlzzvd0CLq15wv 0FDBVnGO+Syhi58uFsLF3g==; Date: Sun, 20 Aug 2023 09:07:09 +0300 Message-Id: <83fs4exn5e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Eshel Yaron on Sat, 19 Aug 2023 22:56:18 +0200) References: <83jztqyfbt.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: 65387@debbugs.gnu.org > Date: Sat, 19 Aug 2023 22:56:18 +0200 > > Eli Zaretskii writes: > > >> This patch adds a user option for disabling the *Patch Help* buffer that > >> `submit-emacs-patch` displays. > > > > Thanks, but why is it important to be able to disable the > > instructions, enough to justify this new option? I expect experienced > > people not to use this command at all, so its main purpose is for the > > newbies. > > Ah I actually find this command quite convenient, except for that > instructions buffer that tends to get in my way. So I guess this option > is useful for us semi-newbies :) > > I don't know if it justifies a new option, as you say, and I don't mind > keeping a modified `submit-emacs-patch` in my config. > > I do wonder, since `(info "(emacs)Sending Patches")` recommends using > `submit-emacs-patch` and that always seemed easier than doing `C-x m` > and adding the destination address and the attachment patch afterwards, > what alternative you'd expect experienced users to go with? Let's see what others think about this new command. Would people please voice their opinions about adding it? From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Eshel Yaron , 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.169251819912856 (code B ref 65387); Sun, 20 Aug 2023 07:57:01 +0000 Received: (at 65387) by debbugs.gnu.org; 20 Aug 2023 07:56:39 +0000 Received: from localhost ([127.0.0.1]:53031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXdId-0003LI-CP for submit@debbugs.gnu.org; Sun, 20 Aug 2023 03:56:39 -0400 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:62854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXdIb-0003L4-3N for 65387@debbugs.gnu.org; Sun, 20 Aug 2023 03:56:37 -0400 Received: by mail-pj1-x1041.google.com with SMTP id 98e67ed59e1d1-26934bc3059so2317682a91.1 for <65387@debbugs.gnu.org>; Sun, 20 Aug 2023 00:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692518189; x=1693122989; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p65S8D+gESy3fAhzqOaQwkqqK9e2z1Kvd9bkhK4e0d0=; b=BAuPcAwKDV2XsWTVju4uEQQV2L5Aaio5NQL5DvQcbktcAPiX4JkWRx8hY9iutVfGJW h6e6TNfQpubyicGcZ1IgG8hTbb3lnZWQ8PyQg/WfnEZA51oIItdPzDCkgZUQ0KXJmlxK 4ep0be0EqOIf5UbpUIw41dO1od5qOoa95J+FgxFZGJ8zHmLdsQ5BbTTxLV0CdtT53fL9 yjinFCIDejzzBJZPcB0YfuW0pCHqiDes9Z1ioPTitv57LP3Ld7f6/SPPkcgYhL+oJ855 sZ8fyaxjk5r+sDESIXhZ746MkDIZhtkFzGeJmINgNcN6F8T+nunOAIQMtuLBMBmhWzZe PUHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692518189; x=1693122989; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p65S8D+gESy3fAhzqOaQwkqqK9e2z1Kvd9bkhK4e0d0=; b=FCTuY6Ou6VsJdj5VIz1pw/VCqqfVvpHC5AnMgcnBnMB6bv9lsv6We8Sb+vZ5Oc/GPX dfLwpWulauDGmObbRyUp40Pejs6x4huVzFOZfZYKU6w5hrRnexPNUA3CGMEJ6sj9Iw3P BYpjrMb70k8BcZERabT/CKJRLHE89L2rhoYO9pfW1Gt//7EjlhgYMcK2wt9oikAaghm9 7UYPIiBYlKDldCoXHlsg/OG44WYN0tpqYWqdUFJCm2Zhh0F8bdC1S4B2ay0lVXIVhRqO Qy1sUMI9uZ6ooXC+QuYWgEkcoqqDBk5+pUfh4mByaHWydHJy6Gnc5DIPlPXOaEycRYDj e2pw== X-Gm-Message-State: AOJu0Yzejn/73pevLbizutcUwOGhwFOAfM/EK60G1HN97bO42hq8K4IH IqlTX/Ql17zj1aGx/cDnRgU= X-Google-Smtp-Source: AGHT+IG0aKQYKmhElumPLAlZyN7bvP9kjNdTz4kmeMtyycti3oMUoia5XrMStji9U6WLfS0Zpj+lCQ== X-Received: by 2002:a17:90a:64ca:b0:25d:d224:9fb9 with SMTP id i10-20020a17090a64ca00b0025dd2249fb9mr4992325pjm.24.1692518189516; Sun, 20 Aug 2023 00:56:29 -0700 (PDT) Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id 8-20020a17090a1a4800b002677739860fsm4394312pjl.34.2023.08.20.00.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 00:56:29 -0700 (PDT) From: Visuwesh In-Reply-To: <83fs4exn5e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Aug 2023 09:07:09 +0300") References: <83jztqyfbt.fsf@gnu.org> <83fs4exn5e.fsf@gnu.org> Date: Sun, 20 Aug 2023 13:26:26 +0530 Message-ID: <877cpqywnp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: =?UTF-8?Q?[=E0=AE=9E=E0=AE=BE=E0=AE=AF=E0=AE=BF=E0=AE=B1=E0=AF=81_?= =?UTF-8?Q?=E0=AE=86=E0=AE=95=E0=AE=B8=E0=AF=8D=E0=AE=9F=E0=AF=8D?= 20, 2023] Eli Zaretskii wrote: >> Ah I actually find this command quite convenient, except for that >> instructions buffer that tends to get in my way. So I guess this option >> is useful for us semi-newbies :) >> >> I don't know i [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [118.185.152.162 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (visuweshm[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1041 listed in] [list.dnswl.org] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: =?UTF-8?Q?[=E0=AE=9E=E0=AE=BE=E0=AE=AF=E0=AE=BF=E0=AE=B1=E0=AF=81_?= =?UTF-8?Q?=E0=AE=86=E0=AE=95=E0=AE=B8=E0=AF=8D=E0=AE=9F=E0=AF=8D?= 20, 2023] Eli Zaretskii wrote: >> Ah I actually find this command quite convenient, except for that >> instructions buffer that tends to get in my way. So I guess this option >> is useful for us semi-newbies :) >> >> I don't know i [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1041 listed in] [list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [118.185.152.162 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (visuweshm[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager [=E0=AE=9E=E0=AE=BE=E0=AE=AF=E0=AE=BF=E0=AE=B1=E0=AF=81 =E0=AE=86=E0=AE=95= =E0=AE=B8=E0=AF=8D=E0=AE=9F=E0=AF=8D 20, 2023] Eli Zaretskii wrote: =20 >> Ah I actually find this command quite convenient, except for that >> instructions buffer that tends to get in my way. So I guess this option >> is useful for us semi-newbies :) >>=20 >> I don't know if it justifies a new option, as you say, and I don't mind >> keeping a modified `submit-emacs-patch` in my config. >>=20 >> I do wonder, since `(info "(emacs)Sending Patches")` recommends using >> `submit-emacs-patch` and that always seemed easier than doing `C-x m` >> and adding the destination address and the attachment patch afterwards, >> what alternative you'd expect experienced users to go with? > > Let's see what others think about this new command. > > Would people please voice their opinions about adding it? I was thinking of proposing such a patch myself sometime=E2=84=A2. I think= I would end up using the command more if I could turn off the help buffer. Though, I think the user option report-emacs-bug-no-explanations could be reused instead. From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 10:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Eshel Yaron , 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.169252560525214 (code B ref 65387); Sun, 20 Aug 2023 10:01:01 +0000 Received: (at 65387) by debbugs.gnu.org; 20 Aug 2023 10:00:05 +0000 Received: from localhost ([127.0.0.1]:53113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXfE4-0006Yb-Hi for submit@debbugs.gnu.org; Sun, 20 Aug 2023 06:00:04 -0400 Received: from sonic309-24.consmr.mail.ir2.yahoo.com ([77.238.179.82]:37552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXfE0-0006XV-Gi for 65387@debbugs.gnu.org; Sun, 20 Aug 2023 06:00:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1692525593; bh=1v8mpjS4xkrDi5dK5+VWXdzKRFmljP9SOX64WeOXz6Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=kHkh6HhGLxHnQtiFrMVAEXJan8Y+DRvL2xLyQfRDQrqqTe5gE5wjP76D5tdQeE3JPTTGZKZn5wxNJvI3nVBNavXBHrul/nP1UCqCCwDQspMp0TSgRxIi9OufT6d7j/u7sqGjciZ2kHrvhyn55pgLLBeURR4XDTmmw7mvcXTNTbG63v0fGJuZ0/0B/voUyY36UJeJa8LKpx6a+5RbcZcjGAFQJbt5DUfXVLQm8kxoUX6HsyD3Mk4aVkFu7G6ezdbt7g5xMdV/uqS1WVMMgbA0qVgRAbef3/PRF2weRiqEEuh8WTCUEsZOvG40yUsx9oN/6an+3PIFaF1IoUCxp+phTQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692525593; bh=x3fsOTAHCYSadR1kEIiWKDjxhTd/51sVI2oVl7MW4D6=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Z4fj/y4KYFf6XAvMY40NEEuIYEVbvKur47o1GFHJTcI10PffEsXxRHW/j3fSyLrtv2Jpf0rKqoHPcYcPuWL9TloRiNYVQ8/oU9xfNxr0F6UjwhL4gqQAtiYq5xCBT4cOM7eyaO6S8j3zvymxY9y6jPY6mP5S8zj7CYItJLoUWeJgvobmspLfJys5LPrqWh6Aw+6brEfIAAkdtLgceqNHG7HKajO+q0iHPvFNyEQNg65K20BqlE+Hb8X4zDIgO1IgXmroGY5X37IXqCxz4snGQRdrkTOZv61yI3rFnAWgtsomAT90n6yTxi7xKRHMyGEb+UFYrBjWwqDjuY2b8ux8fA== X-YMail-OSG: fsXO5rUVM1k.eV5hbiydhNJlcLiv0z6zCcZXMmWgd5JPwq8_2PPAwLK1Pu0h4lc qNF4su79Nwppo3_jnhcjd1QHC4SM5AinrVrxV2zjBDMmK8d8OAUltcI.3l9Whr_rZcSD9VDF3.lI DNulWxX5_Lw1reBGFSwHIdFz8cGM4bW88uyoeQBXUu5uLr61F3DPe_uuBrgxYy_sGEoQkUEQ.A8H 3DJnPVDXd38AavY0cZQdF34GtJ.YzVtjBJBO3ZUUCPXXi33MaYPHcf6b20JxbX4WYGm8uDzg2IBo FDfDSRE.6rDQ2N77063w8XaqofgimPyFp27UtTCR6p.yr_CqXpwZ20KEZApFRgvdLa0OwSYWoF1S FMWCD5hx_pN1lboc4RENCfQ46thjucKpmvQgG6rcveyNqX32v7AcZ3OmE_WHfnDz4iRjgqOXx0_7 FpGcS9qVMCqJSsnQ.V7v0xMeAoZy3J65x0CoiyVBWTFnWlbgen_ELiZLW5OFvdX12Gr0m_YWsu6v 9vyk7Zd.PMxTHoax58AfE_7lg35lS5i8wdPqkok0ElSVdL4YQev1FnkupVtZirsLO9B94oOQG5F7 WeNuphP2BstXgOy12TbIwUdSeQr2i4dfnTvdy7gulstf38Gfl08eR4a9rr9zvaRZP.liOQxre2It 0NFymGnwLaI14I_Vi_u219.T_2XGySdJRRdlI0n1rvOgWViQ.HXecuG2aUbJVwMR6jBvrclbJVJm JPNPrANfrG48XZNLQ1b6i3zGpvFcmCA5VAGV56EJNCKhSqWuBm4aRFJ9emFC3S9X9hht3m85nQFR DTsPT_917uRq28k9Myue95LqvZHpuWjfDW5DFdzGbIz0GmWOk1wh.FdlJQVBTJxlopgpt7Jvwu1M 3MO5XUeLnt1SKwQIXKsywyQVTGjf5FZErCQ1HqW9zqtjTSIPM0PoSsW_7aacmv7kee7za5v8Znx1 C6vhO8MAh9TyjjSOFEwkRhK13nW9bdRd5rKGcaRanccjSjq4yxs1XSf.3MpYdPOCBtrpeP8JsUuj u4por2YepXGt4bfJkAR_yB_joopqzBmhXHzS6WPTo2kdetl7FIxgl4EC0YLi3g9drf0d3wKT1uMN gg90.IDjz5txl5Sg5648UbuAdx27u23VDwDSaVu1vuMCBQYrYqKrjQcEQyunksLotjEV7NcjFp6P AASdEIXAgr510llpZE6WZyen6f77e_khR.rRH2yCjISJO1xsQaQ3vSBYRGuD0aYWdibJXGHEPjuV J5SF8B72o70WKvDh0b4AY4a32AJwwsjGnCJ8ijLmLZ4_BAEEc8p_q.vwnnVlpdKYtOTsGrD7Gq7f 3SiK5vzUHp68khMwQvmQAWQ_ZqCnkPF1k.hh1f9vua35wa4Z8Gv2hFcOLRLPCIeDGkxRh6ojZk_J DgFcSWxn5V2OmPWO8Q4xWZ3Qh6xkNxRya3UxGxYmkUxo_5g6ZATvPFhIOBTBAtJf82FTbBgFg_DX Ry8nZeNASABFiDUQUpW6I6Cccmu5D0s9YGczPIm3n_Se7nfvAJeVBojFi_4LBwDHkXcnilyDr5so 52xmOB4Ts4LiH67rYFzV6tG7HonQsOLoNdI5fnPhTkq8q_ASiXaitUQ69syL8FpN2mRe_vPLTrRz xqhZSgh2be5qQznGv6MJtNngFIo.SH18et6s_X9leAZ8R8CWL_TS_Nq508tCNRk6kb1NSplzV5ou BNlNQLKsRhCtUC4H4.6cu1wtz9Tiy39SXM9if9FNufmVAJldByJV9YorX1e.X1ZFWct3cRjDcSFi DDJpagH7O.XzzhclwOSFpGMYHFcL5_A1wz.iTgqHAuGGsYHKnpsoVAO1ZS.k2amD5nVggUOLU3Ka E.0iTLcaApG.ksbfNFb3hj2Y3C5G4wY855XkglfmxmUn7ysKhgvSWLIUuU8RAgRzqHPijBUFsC0P f7MReU82NyEJvVpOTb49Z1mXcp2O3R.HUZOjYt8v0ZOCLdeQ4usJ50r9jPoGPf6J4h9KvKOeZ3ck kV23bAEdngaaKprNTTiy5tkKKBTn6fwjEYLQEBXCBQNtge34QMDd77pfkWrN.D01pyoqn7QAJWfD Axhqn_GrsOyoJEFGi0OvMT07YxXEzv8Ewcpg4iMPv.vo4FAW6lR6Lcz9jvhEOPHw2bjvrnlU1UH1 HXUJ5YvLLi4R9kDBwumDddsmCCf.WYbm49RiVI3NC6wMBZxFuEu14WQ_NTYvPqVfofSkx3qA.Isg aSTPhHq_qwdAvFuMBdhmW31LuFDEVn80IPbkr5hcX_KY- X-Sonic-MF: X-Sonic-ID: 4a45970b-2b8d-4f78-8cc1-93b822b3df8f Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Sun, 20 Aug 2023 09:59:53 +0000 Received: by hermes--production-ir2-5cc57b9c45-6h5c4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cd80867583bd5e97df0411aa785bc3e7; Sun, 20 Aug 2023 09:59:48 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= In-Reply-To: <83fs4exn5e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Aug 2023 09:07:09 +0300") References: <83jztqyfbt.fsf@gnu.org> <83fs4exn5e.fsf@gnu.org> Date: Sun, 20 Aug 2023 11:59:47 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1704 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: 65387@debbugs.gnu.org >> Date: Sat, 19 Aug 2023 22:56:18 +0200 >> >> Eli Zaretskii writes: >> >> >> This patch adds a user option for disabling the *Patch Help* buffer that >> >> `submit-emacs-patch` displays. >> > >> > Thanks, but why is it important to be able to disable the >> > instructions, enough to justify this new option? I expect experienced >> > people not to use this command at all, so its main purpose is for the >> > newbies. >> >> Ah I actually find this command quite convenient, except for that >> instructions buffer that tends to get in my way. So I guess this option >> is useful for us semi-newbies :) >> >> I don't know if it justifies a new option, as you say, and I don't mind >> keeping a modified `submit-emacs-patch` in my config. >> >> I do wonder, since `(info "(emacs)Sending Patches")` recommends using >> `submit-emacs-patch` and that always seemed easier than doing `C-x m` >> and adding the destination address and the attachment patch afterwards, >> what alternative you'd expect experienced users to go with? > > Let's see what others think about this new command. > > Would people please voice their opinions about adding it? Instead of just a toggle, we could make the new option a tristate: - `nil`: Only displays the buffer to compose the email (what is proposed in this bug report). - `help`: Displays instructions on how to send the patch (current behavior). - `patch`: Displays the patch that you want to submit in the split window. Perhaps this adds useful enough functionality that adding a new configuration option feels more justified. From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 11:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: Eli Zaretskii , 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.169253136613298 (code B ref 65387); Sun, 20 Aug 2023 11:37:02 +0000 Received: (at 65387) by debbugs.gnu.org; 20 Aug 2023 11:36:06 +0000 Received: from localhost ([127.0.0.1]:53243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXgiz-0003SP-I6 for submit@debbugs.gnu.org; Sun, 20 Aug 2023 07:36:06 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:49390 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXgix-0003SH-Mu for 65387@debbugs.gnu.org; Sun, 20 Aug 2023 07:36:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1692531361; bh=cKxF94EAZiqT+EwCaZpeMIc4/KGFTtFvNYz1V5b7CUc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=R+v9FtLOLzqV0q99EOvzvxmc3bS6bDiOJDcH6ghH5Wcgos2fdSs8nk6XVuVv45hsC eSjvdiJZKmohHlUlfCTmwUI4U1L8ZVEFwXgO5FEJG2r7KalQjhz8oCKgQs6J0mpDb9 Twr54d71whXUmC/9cg/1J7m+vkEVWG1tFFtHln4POHM4D/nPb0Cis0eYsSmcjdEO93 0RFd6IY1xI/aAuuF6LU5oet/6w2mb3XZKVG8m6Mls1+DGEZphNZVRlxzmmguj79W35 MRfemedZyQRyS0iiAPL5kdA2t9NewJAFlAwXfbzQNHRGrEssLCC53cz3MEPJ1XnP7S Keh4VIExe/0nw== From: Eshel Yaron In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sun, 20 Aug 2023 11:59:47 +0200") References: <83jztqyfbt.fsf@gnu.org> <83fs4exn5e.fsf@gnu.org> Date: Sun, 20 Aug 2023 13:35:56 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Daniel Mart=C3=ADn writes: > Instead of just a toggle, we could make the new option a tristate: > > - `nil`: Only displays the buffer to compose the email (what is proposed = in > this bug report). > - `help`: Displays instructions on how to send the patch (current > behavior).=20=20 > - `patch`: Displays the patch that you want to submit in the split > window. Good idea, thanks. I've added something like that in the following updated patch: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v2-0001-New-user-option-submit-emacs-patch-display-help.patch >From 10c943cbf340255d0577a03fe4b3d74af840a9e2 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 19 Aug 2023 21:24:34 +0200 Subject: [PATCH v2] New user option 'submit-emacs-patch-display-help' This lets users prevent 'submit-emacs-patch' from displaying a buffer with instructions about submitting patches when they no longer need it. * lisp/mail/emacsbug.el (submit-emacs-patch-display-help): New user option. (submit-emacs-patch): Use it. * doc/emacs/trouble.texi (Sending Patches): Document it. * etc/NEWS: Announce it. --- doc/emacs/trouble.texi | 9 +++++++ etc/NEWS | 7 ++++++ lisp/mail/emacsbug.el | 54 ++++++++++++++++++++++++++---------------- 3 files changed, 50 insertions(+), 20 deletions(-) diff --git a/doc/emacs/trouble.texi b/doc/emacs/trouble.texi index d2e8ac3452a..042637ed8fc 100644 --- a/doc/emacs/trouble.texi +++ b/doc/emacs/trouble.texi @@ -1336,6 +1336,15 @@ Sending Patches form that is clearly safe to install. @end itemize +@vindex submit-emacs-patch-display-help +By default, @kbd{M-x submit-emacs-patch} displays a buffer with some +instructions alongside the Message mode buffer. If you're already +familiar with these instructions after submitting a patch or two, you +can disable this help by customizing the user option +@code{submit-emacs-patch-display-help} to @code{nil}. If you set this +option to @code{patch}, Emacs displays the patch you're about to +submit instead of the instructions buffer. + @node Contributing @section Contributing to Emacs Development @cindex contributing to Emacs diff --git a/etc/NEWS b/etc/NEWS index 6588299c532..5ea8a204522 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -99,6 +99,13 @@ This allows the user to customize the prompt that is appended by 'yes-or-no-p' when asking questions. The default value is "(yes or no) ". ++++ +** New user option 'submit-emacs-patch-display-help'. +You can set this user option to nil to prevent 'submit-emacs-patch' +from displaying a help buffer with instructions for submitting +patches. If you set this option to 'patch', Emacs displays the patch +you're about to submit instead of the instructions buffer. + --- ** New face 'display-time-date-and-time'. This is used for displaying the time and date components of diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index bebaad720db..b93aed47bac 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -50,6 +50,17 @@ report-emacs-bug-no-explanations "If non-nil, suppress the explanations given for the sake of novice users." :type 'boolean) +(defcustom submit-emacs-patch-display-help t + "Whether `submit-emacs-patch' displays help in another buffer. + +If nil, display only the message buffer without additional help. If this is +the symbol `patch', display the patch you are submitting in another buffer. +Any other value says to display a buffer with instructions for submitting +patches (this is the default for the sake of novice users)." + :type '(choice (const :tag "Do not display help" nil) + (const :tag "Display instructions" t) + (const :tag "Display patch" patch))) + ;; User options end here. (defvar report-emacs-bug-orig-text nil @@ -509,26 +520,29 @@ submit-emacs-patch (list (read-string (format-prompt "This patch is about" guess) nil nil guess) file))) - (switch-to-buffer "*Patch Help*") - (let ((inhibit-read-only t)) - (erase-buffer) - (insert "Thank you for considering submitting a patch to the Emacs project.\n\n" - "Please describe what the patch fixes (or, if it's a new feature, what it\n" - "implements) in the mail buffer below. When done, use the " - (substitute-command-keys "\\\\[message-send-and-exit] command\n") - "to send the patch as an email to the Emacs issue tracker.\n\n" - "If this is the first time you're submitting an Emacs patch, please\n" - "read the ") - (insert-text-button - "CONTRIBUTE" - 'action (lambda (_) - (view-buffer - (find-file-noselect - (expand-file-name "CONTRIBUTE" installation-directory))))) - (insert " file first.\n") - (goto-char (point-min)) - (view-mode 1) - (button-mode 1)) + (pcase submit-emacs-patch-display-help + ('patch (find-file file)) + ((pred (not null)) + (switch-to-buffer "*Patch Help*") + (let ((inhibit-read-only t)) + (erase-buffer) + (insert "Thank you for considering submitting a patch to the Emacs project.\n\n" + "Please describe what the patch fixes (or, if it's a new feature, what it\n" + "implements) in the mail buffer below. When done, use the " + (substitute-command-keys "\\\\[message-send-and-exit] command\n") + "to send the patch as an email to the Emacs issue tracker.\n\n" + "If this is the first time you're submitting an Emacs patch, please\n" + "read the ") + (insert-text-button + "CONTRIBUTE" + 'action (lambda (_) + (view-buffer + (find-file-noselect + (expand-file-name "CONTRIBUTE" installation-directory))))) + (insert " file first.\n") + (goto-char (point-min)) + (view-mode 1) + (button-mode 1)))) (compose-mail-other-window report-emacs-bug-address subject) (message-goto-body) (insert "\n\n\n") -- 2.41.0 --=-=-=-- From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 17:28:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Eshel Yaron , 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.169255246318843 (code B ref 65387); Sun, 20 Aug 2023 17:28:04 +0000 Received: (at 65387) by debbugs.gnu.org; 20 Aug 2023 17:27:43 +0000 Received: from localhost ([127.0.0.1]:54754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXmDG-0004tq-Vo for submit@debbugs.gnu.org; Sun, 20 Aug 2023 13:27:43 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:42171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXmDF-0004tN-Dk for 65387@debbugs.gnu.org; Sun, 20 Aug 2023 13:27:41 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0D34C40006; Sun, 20 Aug 2023 17:27:32 +0000 (UTC) From: Juri Linkov In-Reply-To: <83fs4exn5e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Aug 2023 09:07:09 +0300") Organization: LINKOV.NET References: <83jztqyfbt.fsf@gnu.org> <83fs4exn5e.fsf@gnu.org> Date: Sun, 20 Aug 2023 19:37:18 +0300 Message-ID: <86wmxqp12h.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I don't know if it justifies a new option, as you say, and I don't mind >> keeping a modified `submit-emacs-patch` in my config. > > Let's see what others think about this new command. > > Would people please voice their opinions about adding it? If 'submit-emacs-patch' used 'pop-to-buffer-same-window' instead of 'switch-to-buffer' like in the patch below, then using such simple config would be possible: (add-to-list 'display-buffer-alist '("\\*Patch Help\\*" display-buffer-no-window (allow-no-window . t))) PS: This patch doesn't preclude adding an option. diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index bebaad720db..409ef7165fe 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -509,7 +509,7 @@ submit-emacs-patch (list (read-string (format-prompt "This patch is about" guess) nil nil guess) file))) - (switch-to-buffer "*Patch Help*") + (pop-to-buffer-same-window "*Patch Help*") (let ((inhibit-read-only t)) (erase-buffer) (insert "Thank you for considering submitting a patch to the Emacs project.\n\n" From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Eshel Yaron , 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.16940224741281 (code B ref 65387); Wed, 06 Sep 2023 17:48:02 +0000 Received: (at 65387) by debbugs.gnu.org; 6 Sep 2023 17:47:54 +0000 Received: from localhost ([127.0.0.1]:37553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdwd7-0000KZ-G5 for submit@debbugs.gnu.org; Wed, 06 Sep 2023 13:47:53 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:55623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdwd3-0000Jh-W7 for 65387@debbugs.gnu.org; Wed, 06 Sep 2023 13:47:51 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-501be2d45e0so35291e87.3 for <65387@debbugs.gnu.org>; Wed, 06 Sep 2023 10:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694022463; x=1694627263; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=W77eDsu9l7nFLtGMGS7agCA34eAXx0N94wXe/ZLmG94=; b=DaT6yRxLvWSf0jC+78dHmhDER5Lbm4I6pgZk9x+lRV5D8gdTKbmO9GdBViHEfHCNOK 53xU6Cr0p7+HyUYUdaXaM+rFa0evkWGTHWTGhMvcX2mDkzHhorkPH87vVNtCA2t994pU PODZPQU/fCu55VQdNghbzIXruGrwcKpAzz4sDaaQBXsXmVo7qh5nlKytI9j6EX4vM53T e6kCPf07NgnE2OXhW/hNXZVkeqmUWPZyRypptbc4psl612vYV462SpBP10a89CM06MIq 8EFN2JWEW0PdT4REaqa6m29uS2Eo5hzPGeZf+BkoAJoqSeu7oPSQIEaeSBAqCg96XVOX H3kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694022463; x=1694627263; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W77eDsu9l7nFLtGMGS7agCA34eAXx0N94wXe/ZLmG94=; b=cpW2ZYzlBB5A+1jxZ/Wlkhpa2z2hcmlgu15P1udvaMHpDtPVeC6cTVeEe/FK58TKYr 3NmYc/YbDRFaAEBFsEctwRMZPQXuu8nM2hEXoOGeLPnU/gbVnDsNbucleiHLG0S5Ey3e MH469t7pbQEcpJ01Owli75tmGFSpMMBdKCBUO8D8ahAivVWxWceMDHvMctUr+vgessSY sdZ5d8b15PtlUJKId9zIUVwUU2C6848hZ1pRQyTwOB6Nhku5MNgZKtKeqN/d51N9lGDU VO9skqWXf5to6aUDqTf7OlLM2T/hAIFWAvNEE0X61Lf1igAX58DXCpmbux5WlqzpV2qC zKYg== X-Gm-Message-State: AOJu0YxyJRIfrpdDS92KxAHPQecRK5d5css2pJbv5BgR8F7PZdfVGWHK n7i0+xfI5QvsxhFawi8nTkri4wiHoNyzlpFLUzE= X-Google-Smtp-Source: AGHT+IGZsCdM05vfGaqrxg99d93TuSESVZWd8w9GILxrY3QzkaB6O1f9OP3cEwplL7WbT0Hd92F/OxkVTvGBzANciJU= X-Received: by 2002:a19:3850:0:b0:4f7:6453:f3f1 with SMTP id d16-20020a193850000000b004f76453f3f1mr2703753lfj.15.1694022462464; Wed, 06 Sep 2023 10:47:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Sep 2023 10:47:41 -0700 From: Stefan Kangas In-Reply-To: <83fs4exn5e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Aug 2023 09:07:09 +0300") References: <83jztqyfbt.fsf@gnu.org> <83fs4exn5e.fsf@gnu.org> MIME-Version: 1.0 Date: Wed, 6 Sep 2023 10:47:41 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Would people please voice their opinions about adding it? I think it would be nice to eventually make `M-x submit-emacs-patch' into something even more powerful, more suitable for advanced users. I'm thinking of something closer to debbugs, so that you set some option to your Emacs source tree, and it'll create the patches and attach them to the current email for you. So I think I like the idea here, as it seems to go in that direction. From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 18:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: me@eshelyaron.com, 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.16940251415901 (code B ref 65387); Wed, 06 Sep 2023 18:33:01 +0000 Received: (at 65387) by debbugs.gnu.org; 6 Sep 2023 18:32:21 +0000 Received: from localhost ([127.0.0.1]:37651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdxK9-0001X6-0y for submit@debbugs.gnu.org; Wed, 06 Sep 2023 14:32:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdxK7-0001Wt-1g for 65387@debbugs.gnu.org; Wed, 06 Sep 2023 14:32:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdxK0-00022F-ET; Wed, 06 Sep 2023 14:32:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=a0psP0QSJWTvCKUUaNFr5PV7v8tBKd+ISSVCZJ+ykso=; b=lLZ26Vkf+Dea +wAKmqUcAYxpVV33rIUuwiW6ahVPd7Qxls+PhZUD6K6uKVE2fth/fnUTwkBlQH1HjkhNjNz0zUSJV EIucw4xIssYBpmcn++DBawt47Xf4oJesQEsXvvPeZdbVWkz5+rrhG0IZlhZmL1puf8Mx9QKBw5AAm d6xzMyt4fANadKRI58apIsdNpoxgxxinpcMMXG8V0WaA1s31WJSpYxj3sz98e4OrS5Q9tGnbqbZdP B8j9V4Nwc7e+OPxkPReHGcBkAKSodXXLn+DOBwkWWWqkm8/M5NmPAwTreKGHZa63OcYbTaPaa7klD SDP8YSPXBRcuD4oe/4LAQw==; Date: Wed, 06 Sep 2023 21:31:35 +0300 Message-Id: <83cyyv17co.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Wed, 6 Sep 2023 10:47:41 -0700) References: <83jztqyfbt.fsf@gnu.org> <83fs4exn5e.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 6 Sep 2023 10:47:41 -0700 > Cc: Eshel Yaron , 65387@debbugs.gnu.org > > Eli Zaretskii writes: > > > Would people please voice their opinions about adding it? > > I think it would be nice to eventually make `M-x submit-emacs-patch' > into something even more powerful, more suitable for advanced users. > > I'm thinking of something closer to debbugs, so that you set some option > to your Emacs source tree, and it'll create the patches and attach them > to the current email for you. > > So I think I like the idea here, as it seems to go in that direction. TBH, I fail to see how disabling the instruction is going in the direction you described. But if this is part of some larger plan to that effect, I don't mind. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 13 08:38:09 2023 Received: (at control) by debbugs.gnu.org; 13 Sep 2023 12:38:09 +0000 Received: from localhost ([127.0.0.1]:32825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgP8D-0006tL-4U for submit@debbugs.gnu.org; Wed, 13 Sep 2023 08:38:09 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:46101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgP88-0006sk-G7 for control@debbugs.gnu.org; Wed, 13 Sep 2023 08:38:07 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2bf8b9c5ca0so57280151fa.0 for ; Wed, 13 Sep 2023 05:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694608673; x=1695213473; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=ypt05I1ULws2DtBS9TXs1HvVH7UyEY/grNy35i7Wc9w=; b=gioZ/2irIFCEojs9FRLP2vbXkXAizPjFR1stMBoin6pgNRbsykbYkioZXcZTpTeNHj /v0WvG7YyQR4ZbXz657B+JOYFPTl/7KKjE21qjuBxOACdiufhqT3vPUMnwymvr+VaQVX /GoIlW1iQd2Wc/zy+Yqd1LJoXSZR49jzoiYuyN/6Rcw14t1FuN7Ip/XYqrFuJz1xFBJ2 n60JObmZTFTsLoSiSToYqMFbuQwwQt41ArSIFs105++FNiF2QZDI7SydfxoMW+V3320J LeCWRxqHGxIs0nAIUGMX6P/fmZDytW9/cOs7rwJacq0EKpmbhylpyi+iUyM4HOrIb7sz K0oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694608673; x=1695213473; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ypt05I1ULws2DtBS9TXs1HvVH7UyEY/grNy35i7Wc9w=; b=cOpSGx1eCZc38qy2Vbdi7P2AOHOQ32SEyYZHnLMcp7BXndlAn87DHh5zNbwB9PjjEI Mnsrpjo/3i5R46JKLbSmOYuKEMYSTk3UMshzRUj4VSl73/YUnW4nSJBMx944bvBe5Jmp 763J+ExAkpg2Q+AY6+EXbyp3ODsatjCvyIzSDuuu/dvRLJzG/8Vsn+kLt6AaldET5+pg jNZEd7ObQRLqjI7MMwdKhud3Yo8MBVVnCCtBX1dG4/mb+ekcr5ENk7i6dB74jqKKJfwC zKxO6LVNu5UZWVCxJBfMHntmc+L+KdAgeh/a4pJOhl2SJ02ZPSXoObB+tccfV1vK94R1 0v4Q== X-Gm-Message-State: AOJu0YzO7x/a6uViwpAhvpP/vZBKny2hT2FiQUBLnKBBlfV1X2gfxOqK 7sj1EEzQe//6PwX/xOgyQ2KR31TwCMgIaJFFtC7EZROK X-Google-Smtp-Source: AGHT+IFulrXO09UeQRNDKkXvzxkqaRnJ3ucCm4T9jVyOIv/a9+/lUuqNCNIvCjn+sC97Q2qHw+ngy2Vui4zwymeJoi4= X-Received: by 2002:a2e:a282:0:b0:2bc:ddf2:4fcb with SMTP id k2-20020a2ea282000000b002bcddf24fcbmr2005421lja.1.1694608672912; Wed, 13 Sep 2023 05:37:52 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Sep 2023 05:37:52 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 13 Sep 2023 05:37:52 -0700 Message-ID: Subject: control message for bug #65387 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 65387 wishlist quit From unknown Fri Sep 19 23:37:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2023 07:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Eshel Yaron , 65387@debbugs.gnu.org Received: via spool by 65387-submit@debbugs.gnu.org id=B65387.17001197005997 (code B ref 65387); Thu, 16 Nov 2023 07:29:02 +0000 Received: (at 65387) by debbugs.gnu.org; 16 Nov 2023 07:28:20 +0000 Received: from localhost ([127.0.0.1]:54411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3WnU-0001Yf-E9 for submit@debbugs.gnu.org; Thu, 16 Nov 2023 02:28:20 -0500 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]:47595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3WnS-0001YP-LW for 65387@debbugs.gnu.org; Thu, 16 Nov 2023 02:28:19 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 44C3C20005; Thu, 16 Nov 2023 07:28:09 +0000 (UTC) From: Juri Linkov In-Reply-To: <86wmxqp12h.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 20 Aug 2023 19:37:18 +0300") Organization: LINKOV.NET References: <83jztqyfbt.fsf@gnu.org> <83fs4exn5e.fsf@gnu.org> <86wmxqp12h.fsf@mail.linkov.net> Date: Thu, 16 Nov 2023 09:25:36 +0200 Message-ID: <86bkbutb0v.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> I don't know if it justifies a new option, as you say, and I don't mind >>> keeping a modified `submit-emacs-patch` in my config. >> >> Let's see what others think about this new command. >> >> Would people please voice their opinions about adding it? > > If 'submit-emacs-patch' used 'pop-to-buffer-same-window' > instead of 'switch-to-buffer' like in the patch below, > then using such simple config would be possible: > > (add-to-list 'display-buffer-alist > '("\\*Patch Help\\*" > display-buffer-no-window > (allow-no-window . t))) > > @@ -509,7 +509,7 @@ submit-emacs-patch > (list (read-string (format-prompt "This patch is about" guess) > nil nil guess) > file))) > - (switch-to-buffer "*Patch Help*") > + (pop-to-buffer-same-window "*Patch Help*") Now pushed. And maybe this could be closed? From unknown Fri Sep 19 23:37:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eshel Yaron Subject: bug#65387: closed (Re: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help') Message-ID: References: X-Gnu-PR-Message: they-closed 65387 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 65387@debbugs.gnu.org Date: Fri, 15 Dec 2023 01:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1702602842-8295-1" This is a multi-part message in MIME format... ------------=_1702602842-8295-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #65387: [PATCH] New user option 'submit-emacs-patch-display-help' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 65387@debbugs.gnu.org. --=20 65387: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65387 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1702602842-8295-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 65387-done) by debbugs.gnu.org; 15 Dec 2023 01:13:08 +0000 Received: from localhost ([127.0.0.1]:51307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDwlH-00028Y-Jf for submit@debbugs.gnu.org; Thu, 14 Dec 2023 20:13:07 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:60740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDwlF-000283-AS for 65387-done@debbugs.gnu.org; Thu, 14 Dec 2023 20:13:05 -0500 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-54dcfca54e0so167579a12.1 for <65387-done@debbugs.gnu.org>; Thu, 14 Dec 2023 17:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702602780; x=1703207580; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=QREuqvVaBCax+OQCF9AIleRiFnG5SP80hqAslwofbo8=; b=d9L6zDaB2OYPTYqHBryL2+btCaIREq784kFseRninKYSaCx8kRyN/H4FHCIY7k4kBb xOrSaNuyG2Tl+VrxIfISRt2RRsOrUOFvM7cRZuLY0H3mvOO7X+yMkXFXeZ0EKDtShi9J tg5IOsYxbMMy+CUDYI0rcHk44GDaqKocJj0u8yiOcKrvzqqoyi7L3rhPETPfx3M7b9RC 4vMoH2/ro3OJbjKxxzCpc6x07mNXmYIbIHB+soOijL5LvFWsLPozZINFkrDjoJPwrkNK XyRzclLGjyPw2Yqxqsrj62S/G/BNPGBA6r240tNnMTfQZu+p76nE8mjDjMotbZs0wdK/ 8r7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702602780; x=1703207580; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QREuqvVaBCax+OQCF9AIleRiFnG5SP80hqAslwofbo8=; b=YRjq/pe6NVF813h/UB9Ntd8coSuZUdk1DdZCpIFzjde2yWX/jdsXOwJ06+2cYibGhw IqHR7pGgsL0CDhPH0nKt0ws/BjIHQmoPzhvrVWer48fTDAhbAbA8szUKTrftU9YW3O2J q/BaQbRp5YJfUDd6BDdeykeM+U6TdNaGvmORK8SpPAFVrrtd1whjynEnyc4sn1UggRt7 2cdjBoMESohLR+vS+6o1fL0DbNf8Swi1+EBkT1WyHe3TSaNVwL7cnSp0o227/ujqDmXV JwHVPhnyHS8g/GertbDfk5rZTGg2yBlOhsPnJ9YxilnDXamaszsrNf5Fv9JY/IB88gGJ VWiA== X-Gm-Message-State: AOJu0YypJY9hDvwyEnsUP1RkWnPWy2a7tsdt/hw2itOsaNcex4jogs7R 8ztSzz56Tf9T88ifJEi0lbnAWYUzIcOI2/E9zOE= X-Google-Smtp-Source: AGHT+IGvc/5QuLUUSLq9Ews7oQgJbvU4Gs6R3ejP79adoeJ9w++Ci274p18rFwUE0EVWz1EcbQuYLBEmQ9dtVozpHus= X-Received: by 2002:a50:d5c3:0:b0:552:610d:4f34 with SMTP id g3-20020a50d5c3000000b00552610d4f34mr1207494edj.30.1702602779941; Thu, 14 Dec 2023 17:12:59 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 14 Dec 2023 17:12:59 -0800 From: Stefan Kangas In-Reply-To: <86bkbutb0v.fsf@mail.linkov.net> References: <83jztqyfbt.fsf@gnu.org> <83fs4exn5e.fsf@gnu.org> <86wmxqp12h.fsf@mail.linkov.net> <86bkbutb0v.fsf@mail.linkov.net> MIME-Version: 1.0 Date: Thu, 14 Dec 2023 17:12:59 -0800 Message-ID: Subject: Re: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' To: Juri Linkov , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65387-done Cc: Eshel Yaron , 65387-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Now pushed. And maybe this could be closed? Done. ------------=_1702602842-8295-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Aug 2023 19:33:32 +0000 Received: from localhost ([127.0.0.1]:52320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXRhU-0000B1-98 for submit@debbugs.gnu.org; Sat, 19 Aug 2023 15:33:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:47536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXRhR-0000Am-Co for submit@debbugs.gnu.org; Sat, 19 Aug 2023 15:33:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXRhK-0003ql-Fv for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:33:22 -0400 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXRhI-00052g-5f for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:33:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1692473599; bh=6p1RZc9h8CulN/OMao3X/946smaWIL6JioSXIRs/xOU=; h=From:To:Subject:Date:From; b=tsPSVmCx2BwSTRdS28DoZEDTvOplRRMvbd78mV8VBoRMJaHjRWXkxI183q/D5UiHz tE5z0En6e2A6Z5OEiZFC+SMTsJvoyRc4dLL6DDmrVdye4WJVP44dSP1B68PS9m5V95 PtsxT6TGW9kh+14up+k3CcqUodmF99gd6D+M1JwjV3Ph7rs/SEz5bRe99IM8EUQtUE +6urw0h420EyvIghGhARlmqh/236xcJheIdXlp38FjKxQhIHoYFMcFsKtAsR0CK8l4 6hqAN5iMemv4baVLqCOZimkiphXGizL4+LH4f7EON2lOr3wgWj04+EMN3Ewv4HWY4k mRofFrBTFz8Kg== From: Eshel Yaron To: bug-gnu-emacs@gnu.org Subject: [PATCH] New user option 'submit-emacs-patch-display-help' Date: Sat, 19 Aug 2023 21:33:14 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Hi, This patch adds a user option for disabling the *Patch Help* buffer that `submit-emacs-patch` displays. In GNU Emacs 30.0.50 (build 23, x86_64-apple-darwin22.5.0, NS appkit-2299.60 Version 13.4 (Build 22F66)) of 2023-08-19 built on Dazzs-MacBook-Pro.local Repository revision: 44697457c6048464a68b6d58a1c4cf967fd5be06 Repository branch: submit-emacs-patch-display-help Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.4 Configured using: 'configure 'CFLAGS=-g0 -O3' --with-native-compilation --with-json --with-imagemagick --with-tree-sitter --enable-link-time-optimization' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-New-user-option-submit-emacs-patch-display-help.patch >From 28bf05cdafa8b9d00a47a932d20569097289b6d4 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 19 Aug 2023 21:24:34 +0200 Subject: [PATCH] New user option 'submit-emacs-patch-display-help' This lets users prevent 'submit-emacs-patch' from displaying a buffer with instructions about submitting patches when they no longer need it. * lisp/mail/emacsbug.el (submit-emacs-patch-display-help): New user option. (submit-emacs-patch): Use it. * doc/emacs/trouble.texi (Sending Patches): Document it. * etc/NEWS: Announce it. --- doc/emacs/trouble.texi | 7 +++++++ etc/NEWS | 6 ++++++ lisp/mail/emacsbug.el | 45 +++++++++++++++++++++++------------------- 3 files changed, 38 insertions(+), 20 deletions(-) diff --git a/doc/emacs/trouble.texi b/doc/emacs/trouble.texi index d2e8ac3452a..279b17dca2d 100644 --- a/doc/emacs/trouble.texi +++ b/doc/emacs/trouble.texi @@ -1336,6 +1336,13 @@ Sending Patches form that is clearly safe to install. @end itemize +@vindex submit-emacs-patch-display-help +By default, @kbd{M-x submit-emacs-patch} displays a buffer with some +instructions alongside the Message mode buffer. If you're already +familiar with these instructions after submitting a patch or two, you +can disable this help by customizing the user option +@code{submit-emacs-patch-display-help} to @code{nil}. + @node Contributing @section Contributing to Emacs Development @cindex contributing to Emacs diff --git a/etc/NEWS b/etc/NEWS index 6588299c532..ab868b9f3a4 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -99,6 +99,12 @@ This allows the user to customize the prompt that is appended by 'yes-or-no-p' when asking questions. The default value is "(yes or no) ". ++++ +** New user option 'submit-emacs-patch-display-help'. +You can set this user option to nil to prevent 'submit-emacs-patch' +from displaying a help buffer with instructions for submitting +patches. + --- ** New face 'display-time-date-and-time'. This is used for displaying the time and date components of diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index bebaad720db..9c2120530a6 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -50,6 +50,10 @@ report-emacs-bug-no-explanations "If non-nil, suppress the explanations given for the sake of novice users." :type 'boolean) +(defcustom submit-emacs-patch-display-help t + "If non-nil, `submit-emacs-patch' displays some help in another buffer." + :type 'boolean) + ;; User options end here. (defvar report-emacs-bug-orig-text nil @@ -509,26 +513,27 @@ submit-emacs-patch (list (read-string (format-prompt "This patch is about" guess) nil nil guess) file))) - (switch-to-buffer "*Patch Help*") - (let ((inhibit-read-only t)) - (erase-buffer) - (insert "Thank you for considering submitting a patch to the Emacs project.\n\n" - "Please describe what the patch fixes (or, if it's a new feature, what it\n" - "implements) in the mail buffer below. When done, use the " - (substitute-command-keys "\\\\[message-send-and-exit] command\n") - "to send the patch as an email to the Emacs issue tracker.\n\n" - "If this is the first time you're submitting an Emacs patch, please\n" - "read the ") - (insert-text-button - "CONTRIBUTE" - 'action (lambda (_) - (view-buffer - (find-file-noselect - (expand-file-name "CONTRIBUTE" installation-directory))))) - (insert " file first.\n") - (goto-char (point-min)) - (view-mode 1) - (button-mode 1)) + (when submit-emacs-patch-display-help + (switch-to-buffer "*Patch Help*") + (let ((inhibit-read-only t)) + (erase-buffer) + (insert "Thank you for considering submitting a patch to the Emacs project.\n\n" + "Please describe what the patch fixes (or, if it's a new feature, what it\n" + "implements) in the mail buffer below. When done, use the " + (substitute-command-keys "\\\\[message-send-and-exit] command\n") + "to send the patch as an email to the Emacs issue tracker.\n\n" + "If this is the first time you're submitting an Emacs patch, please\n" + "read the ") + (insert-text-button + "CONTRIBUTE" + 'action (lambda (_) + (view-buffer + (find-file-noselect + (expand-file-name "CONTRIBUTE" installation-directory))))) + (insert " file first.\n") + (goto-char (point-min)) + (view-mode 1) + (button-mode 1))) (compose-mail-other-window report-emacs-bug-address subject) (message-goto-body) (insert "\n\n\n") -- 2.41.0 --=-=-=-- ------------=_1702602842-8295-1--