GNU bug report logs - #65386
[PATCH] ; Refine some 'package-vc' docstrings

Previous Next

Package: emacs;

Reported by: Eshel Yaron <me <at> eshelyaron.com>

Date: Sat, 19 Aug 2023 18:08:02 UTC

Severity: normal

Tags: patch

Fixed in version 30.1

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 65386 <at> debbugs.gnu.org
Subject: bug#65386: [PATCH] ; Refine some 'package-vc' docstrings
Date: Sun, 20 Aug 2023 08:13:19 +0000

Eshel Yaron <me <at> eshelyaron.com> writes:


>>>  (defcustom package-vc-allow-side-effects nil
>>> -  "Whether to process :make and :shell-command spec arguments.
>>> +  "Whether to run extra build commands when installing VC packages.
>>
>> The name of this variable is very far from what it means.  Running
>> commands and "side effects" are barely related to each other.  Please
>> consider renaming the variable.  How about
>> package-vc-allow-build-commands?
>>
>
> I agree.  Philip, any objections to renaming this variable?  I don't
> know if people already use it.

If we find a better name, I have no objection since the user option was
recently added.
This bug report was last modified 1 year and 359 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.